Re: [PATCH v2] scheduler: enhancement to show_state_filter

2017-08-08 Thread Yafang Shao
2017-08-08 19:24 GMT+08:00 Peter Zijlstra : > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing in e-mail?On Tue, Aug 08, 2017 at > 07:07:26PM +0800, Yafang Shao wrote: Thanks for

Re: [PATCH v2] scheduler: enhancement to show_state_filter

2017-08-08 Thread Peter Zijlstra
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail?On Tue, Aug 08, 2017 at 07:07:26PM +0800, Yafang Shao wrote:

Re: [PATCH v2] scheduler: enhancement to show_state_filter

2017-08-08 Thread Yafang Shao
Okay. I will submit the whole work in a new patch later. 2017-08-08 19:04 GMT+08:00 Peter Zijlstra : > On Tue, Aug 08, 2017 at 06:36:41PM +0800, Yafang Shao wrote: >> After this change got approved, I will try to make some changes in SysRq. > > No, that's not how it works. Show the whole work.

Re: [PATCH v2] scheduler: enhancement to show_state_filter

2017-08-08 Thread Peter Zijlstra
On Tue, Aug 08, 2017 at 06:36:41PM +0800, Yafang Shao wrote: > After this change got approved, I will try to make some changes in SysRq. No, that's not how it works. Show the whole work.

Re: [PATCH v2] scheduler: enhancement to show_state_filter

2017-08-08 Thread Yafang Shao
Hi Peter, In oder to make it readable, I have comment in the patch why this change is made, - if (!state_filter || (p->state & state_filter)) + /* in case we want to set TASK_RUNNING specifically */ + if ((p->state != TASK_RUNNING ? p->state <<

Re: [PATCH v2] scheduler: enhancement to show_state_filter

2017-08-08 Thread Peter Zijlstra
On Tue, Aug 08, 2017 at 04:50:23PM +0800, Yafang Shao wrote: > Hi Peter, > > The point is we call use it as bellow, > show_state_filter(TASK_RUNNING); > because TASK_RUNNING is 0, that will dump all tasks. > > Under some circumstance, we need this to dump only tasks in TASK_RUNNING > state.

Re: [PATCH v2] scheduler: enhancement to show_state_filter

2017-08-08 Thread Yafang Shao
Hi Peter, The point is we call use it as bellow, show_state_filter(TASK_RUNNING); because TASK_RUNNING is 0, that will dump all tasks. Under some circumstance, we need this to dump only tasks in TASK_RUNNING state. Thanks Yafang 2017-08-08 16:30 GMT+08:00 Peter Zijlstra : > On Tue, Aug 08,

Re: [PATCH v2] scheduler: enhancement to show_state_filter

2017-08-08 Thread Peter Zijlstra
On Tue, Aug 08, 2017 at 08:53:10PM +0800, Yafang Shao wrote: > Sometimes we want to get tasks in TASK_RUNNING sepcifically, > instead of dump all tasks. > For example, when the loadavg are high, we want to dump > tasks in TASK_RUNNING and TASK_UNINTERRUPTIBLE, which contribute > to system load. But

[PATCH v2] scheduler: enhancement to show_state_filter

2017-08-07 Thread Yafang Shao
Sometimes we want to get tasks in TASK_RUNNING sepcifically, instead of dump all tasks. For example, when the loadavg are high, we want to dump tasks in TASK_RUNNING and TASK_UNINTERRUPTIBLE, which contribute to system load. But mostly there're lots of tasks in Sleep state, which occupies almost al