Re: [PATCH v2 03/36] mm: use do_futex() instead of sys_futex() in mm_release()

2018-03-17 Thread Dominik Brodowski
On Fri, Mar 16, 2018 at 02:44:54PM -0700, Darren Hart wrote: > On Fri, Mar 16, 2018 at 07:03:53PM +, Andy Lutomirski wrote: > > On Fri, Mar 16, 2018 at 6:43 PM, Darren Hart wrote: > > > On Thu, Mar 15, 2018 at 08:04:56PM +0100, Dominik Brodowski wrote: > > >> sys_futex()

Re: [PATCH v2 03/36] mm: use do_futex() instead of sys_futex() in mm_release()

2018-03-17 Thread Dominik Brodowski
On Fri, Mar 16, 2018 at 02:44:54PM -0700, Darren Hart wrote: > On Fri, Mar 16, 2018 at 07:03:53PM +, Andy Lutomirski wrote: > > On Fri, Mar 16, 2018 at 6:43 PM, Darren Hart wrote: > > > On Thu, Mar 15, 2018 at 08:04:56PM +0100, Dominik Brodowski wrote: > > >> sys_futex() is a wrapper to

Re: [PATCH v2 03/36] mm: use do_futex() instead of sys_futex() in mm_release()

2018-03-16 Thread Darren Hart
On Fri, Mar 16, 2018 at 07:03:53PM +, Andy Lutomirski wrote: > On Fri, Mar 16, 2018 at 6:43 PM, Darren Hart wrote: > > On Thu, Mar 15, 2018 at 08:04:56PM +0100, Dominik Brodowski wrote: > >> sys_futex() is a wrapper to do_futex() which does not modify any > >> values

Re: [PATCH v2 03/36] mm: use do_futex() instead of sys_futex() in mm_release()

2018-03-16 Thread Darren Hart
On Fri, Mar 16, 2018 at 07:03:53PM +, Andy Lutomirski wrote: > On Fri, Mar 16, 2018 at 6:43 PM, Darren Hart wrote: > > On Thu, Mar 15, 2018 at 08:04:56PM +0100, Dominik Brodowski wrote: > >> sys_futex() is a wrapper to do_futex() which does not modify any > >> values here: > >> > >> - uaddr,

Re: [PATCH v2 03/36] mm: use do_futex() instead of sys_futex() in mm_release()

2018-03-16 Thread Andy Lutomirski
On Fri, Mar 16, 2018 at 6:43 PM, Darren Hart wrote: > On Thu, Mar 15, 2018 at 08:04:56PM +0100, Dominik Brodowski wrote: >> sys_futex() is a wrapper to do_futex() which does not modify any >> values here: >> >> - uaddr, val and val3 are kept the same >> >> - op is masked

Re: [PATCH v2 03/36] mm: use do_futex() instead of sys_futex() in mm_release()

2018-03-16 Thread Andy Lutomirski
On Fri, Mar 16, 2018 at 6:43 PM, Darren Hart wrote: > On Thu, Mar 15, 2018 at 08:04:56PM +0100, Dominik Brodowski wrote: >> sys_futex() is a wrapper to do_futex() which does not modify any >> values here: >> >> - uaddr, val and val3 are kept the same >> >> - op is masked with FUTEX_CMD_MASK, but

Re: [PATCH v2 03/36] mm: use do_futex() instead of sys_futex() in mm_release()

2018-03-16 Thread Darren Hart
On Thu, Mar 15, 2018 at 08:04:56PM +0100, Dominik Brodowski wrote: > sys_futex() is a wrapper to do_futex() which does not modify any > values here: > > - uaddr, val and val3 are kept the same > > - op is masked with FUTEX_CMD_MASK, but is always set to FUTEX_WAKE. > Therefore, val2 is always

Re: [PATCH v2 03/36] mm: use do_futex() instead of sys_futex() in mm_release()

2018-03-16 Thread Darren Hart
On Thu, Mar 15, 2018 at 08:04:56PM +0100, Dominik Brodowski wrote: > sys_futex() is a wrapper to do_futex() which does not modify any > values here: > > - uaddr, val and val3 are kept the same > > - op is masked with FUTEX_CMD_MASK, but is always set to FUTEX_WAKE. > Therefore, val2 is always

Re: [PATCH v2 03/36] mm: use do_futex() instead of sys_futex() in mm_release()

2018-03-16 Thread Thomas Gleixner
On Thu, 15 Mar 2018, Dominik Brodowski wrote: > sys_futex() is a wrapper to do_futex() which does not modify any > values here: > > - uaddr, val and val3 are kept the same > > - op is masked with FUTEX_CMD_MASK, but is always set to FUTEX_WAKE. > Therefore, val2 is always 0. > > - as utime

Re: [PATCH v2 03/36] mm: use do_futex() instead of sys_futex() in mm_release()

2018-03-16 Thread Thomas Gleixner
On Thu, 15 Mar 2018, Dominik Brodowski wrote: > sys_futex() is a wrapper to do_futex() which does not modify any > values here: > > - uaddr, val and val3 are kept the same > > - op is masked with FUTEX_CMD_MASK, but is always set to FUTEX_WAKE. > Therefore, val2 is always 0. > > - as utime

[PATCH v2 03/36] mm: use do_futex() instead of sys_futex() in mm_release()

2018-03-15 Thread Dominik Brodowski
sys_futex() is a wrapper to do_futex() which does not modify any values here: - uaddr, val and val3 are kept the same - op is masked with FUTEX_CMD_MASK, but is always set to FUTEX_WAKE. Therefore, val2 is always 0. - as utime is set to NULL, *timeout is NULL Cc: Thomas Gleixner

[PATCH v2 03/36] mm: use do_futex() instead of sys_futex() in mm_release()

2018-03-15 Thread Dominik Brodowski
sys_futex() is a wrapper to do_futex() which does not modify any values here: - uaddr, val and val3 are kept the same - op is masked with FUTEX_CMD_MASK, but is always set to FUTEX_WAKE. Therefore, val2 is always 0. - as utime is set to NULL, *timeout is NULL Cc: Thomas Gleixner Cc: Ingo