Re: [PATCH v2 1/5] spmi: pmic-arb: hardcode IRQ counts

2019-01-07 Thread Stephen Boyd
Quoting Brian Masney (2019-01-06 18:11:41) > @@ -1062,19 +1076,6 @@ static int pmic_gpio_remove(struct platform_device > *pdev) > return 0; > } > > -static const struct of_device_id pmic_gpio_of_match[] = { > - { .compatible = "qcom,pm8916-gpio" }, /* 4 GPIO's */ > - {

Re: [PATCH v2 1/5] spmi: pmic-arb: hardcode IRQ counts

2019-01-07 Thread Linus Walleij
On Mon, Jan 7, 2019 at 3:11 AM Brian Masney wrote: > Note: The qcom,pms405-gpio looks suspicious to me. The existing code > will start at gpio1, which is supposed to be a hole according to the > comment. I can fix this in a later patch if there is a desire. I didn't > do it now to try to keep

Re: [PATCH v2 1/5] spmi: pmic-arb: hardcode IRQ counts

2019-01-06 Thread kbuild test robot
Hi Brian, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on pinctrl/devel] [also build test WARNING on v5.0-rc1 next-20190103] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v2 1/5] spmi: pmic-arb: hardcode IRQ counts

2019-01-06 Thread Brian Masney
The probing of this driver calls platform_irq_count, which will setup all of the IRQs that are available. This is a problem since some of these IRQs may be setup in an IRQ hierarchy later in the boot process by spmi-gpio. This will cause these hwirqs to be associated with multiple Linux virqs and