Re: [PATCH v2 2/2] reset: Add GPIO support to reset controller framework

2014-01-07 Thread Maxime Ripard
On Tue, Jan 07, 2014 at 12:28:09PM +0100, Philipp Zabel wrote: > Am Dienstag, den 07.01.2014, 12:19 +0100 schrieb Maxime Ripard: > > > I was under the (wrong) impression that gpiod_direction_output takes a > > > logical value as gpiod_set_value does. Will fix that. > > > > I don't think

Re: [PATCH v2 2/2] reset: Add GPIO support to reset controller framework

2014-01-07 Thread Philipp Zabel
Am Dienstag, den 07.01.2014, 12:19 +0100 schrieb Maxime Ripard: > Hi Philipp, > > On Tue, Jan 07, 2014 at 10:52:21AM +0100, Philipp Zabel wrote: > > > > + const char *gpio_con_id = "reset"; > > > > + struct reset_controller_dev *rcdev; > > > > + struct reset_control *rstc; > > >

Re: [PATCH v2 2/2] reset: Add GPIO support to reset controller framework

2014-01-07 Thread Maxime Ripard
Hi Philipp, On Tue, Jan 07, 2014 at 10:52:21AM +0100, Philipp Zabel wrote: > > > + const char *gpio_con_id = "reset"; > > > + struct reset_controller_dev *rcdev; > > > + struct reset_control *rstc; > > > + struct gpio_desc *gpiod; > > > + bool asserted = false; > > > + char scratch[48]; > > > +

Re: [PATCH v2 2/2] reset: Add GPIO support to reset controller framework

2014-01-07 Thread Philipp Zabel
Hi Maxime, Am Montag, den 06.01.2014, 19:14 +0100 schrieb Maxime Ripard: > > +struct reset_control *gpio_reset_control_get(struct device *dev, const > > char *id) > > +{ > > + const char *assert_prop = "reset-initially-asserted"; > > I guess you meant reset-boot-asserted here, right? Yes,

Re: [PATCH v2 2/2] reset: Add GPIO support to reset controller framework

2014-01-07 Thread Philipp Zabel
Hi Maxime, Am Montag, den 06.01.2014, 19:14 +0100 schrieb Maxime Ripard: +struct reset_control *gpio_reset_control_get(struct device *dev, const char *id) +{ + const char *assert_prop = reset-initially-asserted; I guess you meant reset-boot-asserted here, right? Yes, thank you.

Re: [PATCH v2 2/2] reset: Add GPIO support to reset controller framework

2014-01-07 Thread Maxime Ripard
Hi Philipp, On Tue, Jan 07, 2014 at 10:52:21AM +0100, Philipp Zabel wrote: + const char *gpio_con_id = reset; + struct reset_controller_dev *rcdev; + struct reset_control *rstc; + struct gpio_desc *gpiod; + bool asserted = false; + char scratch[48]; + int ret; + + if

Re: [PATCH v2 2/2] reset: Add GPIO support to reset controller framework

2014-01-07 Thread Philipp Zabel
Am Dienstag, den 07.01.2014, 12:19 +0100 schrieb Maxime Ripard: Hi Philipp, On Tue, Jan 07, 2014 at 10:52:21AM +0100, Philipp Zabel wrote: + const char *gpio_con_id = reset; + struct reset_controller_dev *rcdev; + struct reset_control *rstc; + struct

Re: [PATCH v2 2/2] reset: Add GPIO support to reset controller framework

2014-01-07 Thread Maxime Ripard
On Tue, Jan 07, 2014 at 12:28:09PM +0100, Philipp Zabel wrote: Am Dienstag, den 07.01.2014, 12:19 +0100 schrieb Maxime Ripard: I was under the (wrong) impression that gpiod_direction_output takes a logical value as gpiod_set_value does. Will fix that. I don't think gpiod_set_value does

Re: [PATCH v2 2/2] reset: Add GPIO support to reset controller framework

2014-01-06 Thread Maxime Ripard
Hi Philipp, On Mon, Jan 06, 2014 at 06:55:03PM +0100, Philipp Zabel wrote: > This adds support for GPIO controlled reset pins on peripheral ICs to the > reset > controller framework. Currently there is no support for specifying a delay > between assertion and de-assertion of the reset signal, so

[PATCH v2 2/2] reset: Add GPIO support to reset controller framework

2014-01-06 Thread Philipp Zabel
This adds support for GPIO controlled reset pins on peripheral ICs to the reset controller framework. Currently there is no support for specifying a delay between assertion and de-assertion of the reset signal, so this has to be handled by the drivers. Signed-off-by: Philipp Zabel --- Changes

[PATCH v2 2/2] reset: Add GPIO support to reset controller framework

2014-01-06 Thread Philipp Zabel
This adds support for GPIO controlled reset pins on peripheral ICs to the reset controller framework. Currently there is no support for specifying a delay between assertion and de-assertion of the reset signal, so this has to be handled by the drivers. Signed-off-by: Philipp Zabel

Re: [PATCH v2 2/2] reset: Add GPIO support to reset controller framework

2014-01-06 Thread Maxime Ripard
Hi Philipp, On Mon, Jan 06, 2014 at 06:55:03PM +0100, Philipp Zabel wrote: This adds support for GPIO controlled reset pins on peripheral ICs to the reset controller framework. Currently there is no support for specifying a delay between assertion and de-assertion of the reset signal, so