Re: [PATCH v2 2/3] cpufreq: Remove unused function __cpufreq_driver_getavg

2013-06-05 Thread Stratos Karafotis
I think you are right. I will reorder 2/3 and 3/3 with the change you suggested. Thanks, Stratos Viresh Kumar wrote: >On 4 June 2013 20:36, Stratos Karafotis wrote: >> On 06/04/2013 08:19 AM, Viresh Kumar wrote: >>> Should this be done in 3/3 ? >>> >> >> acpi-cpufreq does not use mperf after

Re: [PATCH v2 2/3] cpufreq: Remove unused function __cpufreq_driver_getavg

2013-06-05 Thread Viresh Kumar
On 4 June 2013 20:36, Stratos Karafotis wrote: > On 06/04/2013 08:19 AM, Viresh Kumar wrote: >> Should this be done in 3/3 ? >> > > acpi-cpufreq does not use mperf after 2/3. Why should we compile it with > CONFIG_X86_ACPI_CPUFREQ? > Do you want me to move the change in 3/3? I somehow feel now

Re: [PATCH v2 2/3] cpufreq: Remove unused function __cpufreq_driver_getavg

2013-06-05 Thread Viresh Kumar
On 4 June 2013 20:36, Stratos Karafotis strat...@semaphore.gr wrote: On 06/04/2013 08:19 AM, Viresh Kumar wrote: Should this be done in 3/3 ? acpi-cpufreq does not use mperf after 2/3. Why should we compile it with CONFIG_X86_ACPI_CPUFREQ? Do you want me to move the change in 3/3? I

Re: [PATCH v2 2/3] cpufreq: Remove unused function __cpufreq_driver_getavg

2013-06-05 Thread Stratos Karafotis
I think you are right. I will reorder 2/3 and 3/3 with the change you suggested. Thanks, Stratos Viresh Kumar viresh.ku...@linaro.org wrote: On 4 June 2013 20:36, Stratos Karafotis strat...@semaphore.gr wrote: On 06/04/2013 08:19 AM, Viresh Kumar wrote: Should this be done in 3/3 ?

Re: [PATCH v2 2/3] cpufreq: Remove unused function __cpufreq_driver_getavg

2013-06-04 Thread Stratos Karafotis
On 06/04/2013 08:19 AM, Viresh Kumar wrote: On 4 June 2013 01:18, Stratos Karafotis wrote: Calculation of frequency target in ondemand governor changed and it is s/frequency target/target frequency I will change it also in 3/3 that I use the same. independent from measured average

Re: [PATCH v2 2/3] cpufreq: Remove unused function __cpufreq_driver_getavg

2013-06-04 Thread Stratos Karafotis
On 06/04/2013 08:19 AM, Viresh Kumar wrote: On 4 June 2013 01:18, Stratos Karafotis strat...@semaphore.gr wrote: Calculation of frequency target in ondemand governor changed and it is s/frequency target/target frequency I will change it also in 3/3 that I use the same. independent from

Re: [PATCH v2 2/3] cpufreq: Remove unused function __cpufreq_driver_getavg

2013-06-03 Thread Viresh Kumar
On 4 June 2013 01:18, Stratos Karafotis wrote: > Calculation of frequency target in ondemand governor changed and it is s/frequency target/target frequency > independent from measured average frequency. > > Remove unused__cpufreq_driver_getavg function and getavg member from > cpufreq_driver

[PATCH v2 2/3] cpufreq: Remove unused function __cpufreq_driver_getavg

2013-06-03 Thread Stratos Karafotis
Calculation of frequency target in ondemand governor changed and it is independent from measured average frequency. Remove unused__cpufreq_driver_getavg function and getavg member from cpufreq_driver struct. Also, remove the callback getavg in acpi_cpufreq_driver. Signed-off-by: Stratos

Re: [PATCH v2 2/3] cpufreq: Remove unused function __cpufreq_driver_getavg

2013-06-03 Thread Viresh Kumar
On 4 June 2013 01:18, Stratos Karafotis strat...@semaphore.gr wrote: Calculation of frequency target in ondemand governor changed and it is s/frequency target/target frequency independent from measured average frequency. Remove unused__cpufreq_driver_getavg function and getavg member from

[PATCH v2 2/3] cpufreq: Remove unused function __cpufreq_driver_getavg

2013-06-03 Thread Stratos Karafotis
Calculation of frequency target in ondemand governor changed and it is independent from measured average frequency. Remove unused__cpufreq_driver_getavg function and getavg member from cpufreq_driver struct. Also, remove the callback getavg in acpi_cpufreq_driver. Signed-off-by: Stratos