Re: [PATCH v2 3/3] bio: convert get_user_pages_fast() --> pin_user_pages_fast()

2020-08-29 Thread John Hubbard
On 8/29/20 8:02 AM, Christoph Hellwig wrote: - size = iov_iter_get_pages(iter, pages, LONG_MAX, nr_pages, ); + size = iov_iter_pin_user_pages(iter, pages, LONG_MAX, nr_pages, ); This is really a comment to the previous patch, but I only spotted it here: I think the right name is

Re: [PATCH v2 3/3] bio: convert get_user_pages_fast() --> pin_user_pages_fast()

2020-08-29 Thread Christoph Hellwig
> - size = iov_iter_get_pages(iter, pages, LONG_MAX, nr_pages, ); > + size = iov_iter_pin_user_pages(iter, pages, LONG_MAX, nr_pages, > ); This is really a comment to the previous patch, but I only spotted it here: I think the right name is iov_iter_pin_pages, as bvec, kvec and pipe

[PATCH v2 3/3] bio: convert get_user_pages_fast() --> pin_user_pages_fast()

2020-08-29 Thread John Hubbard
Change generic block/bio Direct IO routines, to acquire FOLL_PIN user pages via the recently added routines: iov_iter_pin_user_pages() iov_iter_pin_user_pages_alloc() pin_user_page() This effectively converts several file systems (ext4, for example) that use the common Direct IO