Re: [PATCH v3 12/12] ARM: dtsi: axp81x: set pinmux for GPIO0/1 when used as LDOs

2017-10-11 Thread Chen-Yu Tsai
On Thu, Oct 12, 2017 at 3:09 AM, Linus Walleij wrote: > On Wed, Oct 11, 2017 at 2:00 PM, Maxime Ripard > wrote: > >> What about not enforcing any muxing state when we want to mux to the >> "ldo" function? We just leave it to whatever value it is, that way we >> keep it under the regulator framewo

Re: [PATCH v3 12/12] ARM: dtsi: axp81x: set pinmux for GPIO0/1 when used as LDOs

2017-10-11 Thread Linus Walleij
On Wed, Oct 11, 2017 at 2:00 PM, Maxime Ripard wrote: > What about not enforcing any muxing state when we want to mux to the > "ldo" function? We just leave it to whatever value it is, that way we > keep it under the regulator framework's control, and we don't disrupt > anything when the pin is r

Re: [PATCH v3 12/12] ARM: dtsi: axp81x: set pinmux for GPIO0/1 when used as LDOs

2017-10-11 Thread Maxime Ripard
On Tue, Oct 10, 2017 at 03:09:11AM +, Chen-Yu Tsai wrote: > On Wed, Oct 4, 2017 at 3:35 PM, Quentin Schulz > wrote: > > Hi Chen-Yu, Linus, > > > > On 03/10/2017 17:08, Chen-Yu Tsai wrote: > >> On Tue, Oct 3, 2017 at 10:47 PM, Maxime Ripard > >> wrote: > >>> Hi Linus, > >>> > >>> On Tue, Oct 0

Re: [PATCH v3 12/12] ARM: dtsi: axp81x: set pinmux for GPIO0/1 when used as LDOs

2017-10-11 Thread Linus Walleij
On Wed, Oct 4, 2017 at 9:35 AM, Quentin Schulz wrote: > Just to be a little more precise, > - 0: drive low > - 1: drive high > - 2: input with interrupt triggering > - 3: LDO on > - 4: LDO off > - 5~7: floating (or ADC) > > for AXP813, and > - 0: drive low >

Re: [PATCH v3 12/12] ARM: dtsi: axp81x: set pinmux for GPIO0/1 when used as LDOs

2017-10-09 Thread Chen-Yu Tsai
On Wed, Oct 4, 2017 at 3:35 PM, Quentin Schulz wrote: > Hi Chen-Yu, Linus, > > On 03/10/2017 17:08, Chen-Yu Tsai wrote: >> On Tue, Oct 3, 2017 at 10:47 PM, Maxime Ripard >> wrote: >>> Hi Linus, >>> >>> On Tue, Oct 03, 2017 at 09:27:17AM +, Linus Walleij wrote: On Mon, Oct 2, 2017 at 2:08

Re: [PATCH v3 12/12] ARM: dtsi: axp81x: set pinmux for GPIO0/1 when used as LDOs

2017-10-04 Thread Quentin Schulz
Hi Chen-Yu, Linus, On 03/10/2017 17:08, Chen-Yu Tsai wrote: > On Tue, Oct 3, 2017 at 10:47 PM, Maxime Ripard > wrote: >> Hi Linus, >> >> On Tue, Oct 03, 2017 at 09:27:17AM +, Linus Walleij wrote: >>> On Mon, Oct 2, 2017 at 2:08 PM, Quentin Schulz >>> wrote: >>> On AXP813/818, GPIO0 and

Re: [PATCH v3 12/12] ARM: dtsi: axp81x: set pinmux for GPIO0/1 when used as LDOs

2017-10-03 Thread Chen-Yu Tsai
On Tue, Oct 3, 2017 at 10:47 PM, Maxime Ripard wrote: > Hi Linus, > > On Tue, Oct 03, 2017 at 09:27:17AM +, Linus Walleij wrote: >> On Mon, Oct 2, 2017 at 2:08 PM, Quentin Schulz >> wrote: >> >> > On AXP813/818, GPIO0 and GPIO1 can be used as LDO as (respectively) >> > ldo_io0 and ldo_io1. >>

Re: [PATCH v3 12/12] ARM: dtsi: axp81x: set pinmux for GPIO0/1 when used as LDOs

2017-10-03 Thread Maxime Ripard
Hi Linus, On Tue, Oct 03, 2017 at 09:27:17AM +, Linus Walleij wrote: > On Mon, Oct 2, 2017 at 2:08 PM, Quentin Schulz > wrote: > > > On AXP813/818, GPIO0 and GPIO1 can be used as LDO as (respectively) > > ldo_io0 and ldo_io1. > (...) > > + gpio0_ldo: gpio0_ldo { > > +

Re: [PATCH v3 12/12] ARM: dtsi: axp81x: set pinmux for GPIO0/1 when used as LDOs

2017-10-03 Thread Maxime Ripard
On Tue, Oct 03, 2017 at 09:18:37AM +, Russell King - ARM Linux wrote: > On Tue, Oct 03, 2017 at 10:06:29AM +0800, Chen-Yu Tsai wrote: > > On Tue, Oct 3, 2017 at 4:42 AM, Maxime Ripard > > wrote: > > > On Mon, Oct 02, 2017 at 12:08:54PM +, Quentin Schulz wrote: > > >> On AXP813/818, GPIO0 a

Re: [PATCH v3 12/12] ARM: dtsi: axp81x: set pinmux for GPIO0/1 when used as LDOs

2017-10-03 Thread Linus Walleij
On Mon, Oct 2, 2017 at 2:08 PM, Quentin Schulz wrote: > On AXP813/818, GPIO0 and GPIO1 can be used as LDO as (respectively) > ldo_io0 and ldo_io1. (...) > + gpio0_ldo: gpio0_ldo { > + pins = "GPIO0"; > + function = "ldo"; > +

Re: [PATCH v3 12/12] ARM: dtsi: axp81x: set pinmux for GPIO0/1 when used as LDOs

2017-10-03 Thread Russell King - ARM Linux
On Tue, Oct 03, 2017 at 10:06:29AM +0800, Chen-Yu Tsai wrote: > On Tue, Oct 3, 2017 at 4:42 AM, Maxime Ripard > wrote: > > On Mon, Oct 02, 2017 at 12:08:54PM +, Quentin Schulz wrote: > >> On AXP813/818, GPIO0 and GPIO1 can be used as LDO as (respectively) > >> ldo_io0 and ldo_io1. > >> > >> Le

Re: [PATCH v3 12/12] ARM: dtsi: axp81x: set pinmux for GPIO0/1 when used as LDOs

2017-10-02 Thread Chen-Yu Tsai
On Tue, Oct 3, 2017 at 4:42 AM, Maxime Ripard wrote: > On Mon, Oct 02, 2017 at 12:08:54PM +, Quentin Schulz wrote: >> On AXP813/818, GPIO0 and GPIO1 can be used as LDO as (respectively) >> ldo_io0 and ldo_io1. >> >> Let's add the pinctrl properties to the said regulators. >> >> Signed-off-by:

Re: [PATCH v3 12/12] ARM: dtsi: axp81x: set pinmux for GPIO0/1 when used as LDOs

2017-10-02 Thread Maxime Ripard
On Mon, Oct 02, 2017 at 12:08:54PM +, Quentin Schulz wrote: > On AXP813/818, GPIO0 and GPIO1 can be used as LDO as (respectively) > ldo_io0 and ldo_io1. > > Let's add the pinctrl properties to the said regulators. > > Signed-off-by: Quentin Schulz > --- > arch/arm/boot/dts/axp81x.dtsi | 14

[PATCH v3 12/12] ARM: dtsi: axp81x: set pinmux for GPIO0/1 when used as LDOs

2017-10-02 Thread Quentin Schulz
On AXP813/818, GPIO0 and GPIO1 can be used as LDO as (respectively) ldo_io0 and ldo_io1. Let's add the pinctrl properties to the said regulators. Signed-off-by: Quentin Schulz --- arch/arm/boot/dts/axp81x.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts