Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-03-05 Thread Wolfram Sang
> + qup->adap.nr = pdev->id; > + qup->adap.dev.parent = qup->dev; > + qup->adap.dev.of_node = pdev->dev.of_node; > + strlcpy(qup->adap.name, "QUP I2C adapter", sizeof(qup->adap.name)); > + > + ret = i2c_add_numbered_adapter(>adap); I'd suggest to use just i2c_add_adapter and

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-03-05 Thread Wolfram Sang
+ qup-adap.nr = pdev-id; + qup-adap.dev.parent = qup-dev; + qup-adap.dev.of_node = pdev-dev.of_node; + strlcpy(qup-adap.name, QUP I2C adapter, sizeof(qup-adap.name)); + + ret = i2c_add_numbered_adapter(qup-adap); I'd suggest to use just i2c_add_adapter and let the core

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-25 Thread Andy Gross
On Tue, Feb 25, 2014 at 08:07:13AM -0800, Bjorn Andersson wrote: [snip] > The v2 model will get BAM (DMAEngine) support soon, v1 uses an > older DMA core. So there's a difference. I'm not aware what differences > there are between 2.1.1 and 2.2.1. Difference between 2.1.1 and 2.2.1: - high

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-25 Thread Bjorn Andersson
On Fri, Feb 21, 2014 at 3:06 AM, Mark Rutland wrote: > On Fri, Feb 21, 2014 at 12:38:10AM +, Bjorn Andersson wrote: [...] > >> +static const struct of_device_id qup_i2c_dt_match[] = { >> + { .compatible = "qcom,i2c-qup-v1.1.1" }, >> + { .compatible = "qcom,i2c-qup-v2.1.1" }, >> +

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-25 Thread Bjorn Andersson
On Fri, Feb 21, 2014 at 3:06 AM, Mark Rutland mark.rutl...@arm.com wrote: On Fri, Feb 21, 2014 at 12:38:10AM +, Bjorn Andersson wrote: [...] +static const struct of_device_id qup_i2c_dt_match[] = { + { .compatible = qcom,i2c-qup-v1.1.1 }, + { .compatible = qcom,i2c-qup-v2.1.1

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-25 Thread Andy Gross
On Tue, Feb 25, 2014 at 08:07:13AM -0800, Bjorn Andersson wrote: [snip] The v2 model will get BAM (DMAEngine) support soon, v1 uses an older DMA core. So there's a difference. I'm not aware what differences there are between 2.1.1 and 2.2.1. Difference between 2.1.1 and 2.2.1: - high speed

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-24 Thread Bjorn Andersson
On Mon 24 Feb 09:40 PST 2014, Josh Cartwright wrote: > On Mon, Feb 24, 2014 at 12:33:10PM +0200, Ivan T. Ivanov wrote: > > On Fri, 2014-02-21 at 09:35 -0600, Kumar Gala wrote: > > > On Feb 20, 2014, at 6:38 PM, Bjorn Andersson > > > wrote: > > > > > > > This bus driver supports the QUP i2c

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-24 Thread Bjorn Andersson
On Fri 21 Feb 00:16 PST 2014, Maxime Ripard wrote: > Hi Bjorn, > > On Thu, Feb 20, 2014 at 04:38:10PM -0800, Bjorn Andersson wrote: > > +static int qup_i2c_probe(struct platform_device *pdev) > > +{ > > [ snip ] > > > + > > + qup_i2c_enable_clocks(qup); > > + > > [ snip ] > > > + > > +

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-24 Thread Bjorn Andersson
On Thu 20 Feb 18:53 PST 2014, Emilio L?pez wrote: > Hi Bjorn, > > El 20/02/14 21:38, Bjorn Andersson escribió: [...] > > + clk_freq = 10; > > + if (!of_property_read_u32(node, "clock-frequency", )) > > + clk_freq = val; > > val will be modified only if no error occurs, so you

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-24 Thread Bjorn Andersson
On Thu 20 Feb 16:52 PST 2014, Joe Perches wrote: > On Thu, 2014-02-20 at 16:38 -0800, Bjorn Andersson wrote: > > This bus driver supports the QUP i2c hardware controller in the Qualcomm > > SOCs. > > The Qualcomm Universal Peripheral Engine (QUP) is a general purpose data > > path > > engine

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-24 Thread Josh Cartwright
On Mon, Feb 24, 2014 at 12:33:10PM +0200, Ivan T. Ivanov wrote: > On Fri, 2014-02-21 at 09:35 -0600, Kumar Gala wrote: > > On Feb 20, 2014, at 6:38 PM, Bjorn Andersson > > wrote: > > > > > This bus driver supports the QUP i2c hardware controller in the Qualcomm > > > SOCs. > > > The Qualcomm

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-24 Thread Ivan T. Ivanov
Hi, On Fri, 2014-02-21 at 09:35 -0600, Kumar Gala wrote: > On Feb 20, 2014, at 6:38 PM, Bjorn Andersson > wrote: > > > This bus driver supports the QUP i2c hardware controller in the Qualcomm > > SOCs. > > The Qualcomm Universal Peripheral Engine (QUP) is a general purpose data > > path >

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-24 Thread Ivan T. Ivanov
Hi, On Fri, 2014-02-21 at 09:35 -0600, Kumar Gala wrote: On Feb 20, 2014, at 6:38 PM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: This bus driver supports the QUP i2c hardware controller in the Qualcomm SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-24 Thread Josh Cartwright
On Mon, Feb 24, 2014 at 12:33:10PM +0200, Ivan T. Ivanov wrote: On Fri, 2014-02-21 at 09:35 -0600, Kumar Gala wrote: On Feb 20, 2014, at 6:38 PM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: This bus driver supports the QUP i2c hardware controller in the Qualcomm SOCs.

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-24 Thread Bjorn Andersson
On Thu 20 Feb 16:52 PST 2014, Joe Perches wrote: On Thu, 2014-02-20 at 16:38 -0800, Bjorn Andersson wrote: This bus driver supports the QUP i2c hardware controller in the Qualcomm SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general purpose data path engine with

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-24 Thread Bjorn Andersson
On Thu 20 Feb 18:53 PST 2014, Emilio L?pez wrote: Hi Bjorn, El 20/02/14 21:38, Bjorn Andersson escribió: [...] + clk_freq = 10; + if (!of_property_read_u32(node, clock-frequency, val)) + clk_freq = val; val will be modified only if no error occurs, so you may

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-24 Thread Bjorn Andersson
On Fri 21 Feb 00:16 PST 2014, Maxime Ripard wrote: Hi Bjorn, On Thu, Feb 20, 2014 at 04:38:10PM -0800, Bjorn Andersson wrote: +static int qup_i2c_probe(struct platform_device *pdev) +{ [ snip ] + + qup_i2c_enable_clocks(qup); + [ snip ] + +

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-24 Thread Bjorn Andersson
On Mon 24 Feb 09:40 PST 2014, Josh Cartwright wrote: On Mon, Feb 24, 2014 at 12:33:10PM +0200, Ivan T. Ivanov wrote: On Fri, 2014-02-21 at 09:35 -0600, Kumar Gala wrote: On Feb 20, 2014, at 6:38 PM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: This bus driver supports

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-21 Thread Kumar Gala
On Feb 20, 2014, at 6:38 PM, Bjorn Andersson wrote: > This bus driver supports the QUP i2c hardware controller in the Qualcomm SOCs. > The Qualcomm Universal Peripheral Engine (QUP) is a general purpose data path > engine with input/output FIFOs and an embedded i2c mini-core. The driver >

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-21 Thread Mark Rutland
On Fri, Feb 21, 2014 at 12:38:10AM +, Bjorn Andersson wrote: > This bus driver supports the QUP i2c hardware controller in the Qualcomm SOCs. > The Qualcomm Universal Peripheral Engine (QUP) is a general purpose data path > engine with input/output FIFOs and an embedded i2c mini-core. The

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-21 Thread Maxime Ripard
Hi Bjorn, On Thu, Feb 20, 2014 at 04:38:10PM -0800, Bjorn Andersson wrote: > +static int qup_i2c_probe(struct platform_device *pdev) > +{ [ snip ] > + > + qup_i2c_enable_clocks(qup); > + [ snip ] > + > + pm_runtime_set_autosuspend_delay(qup->dev, MSEC_PER_SEC); > +

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-21 Thread Maxime Ripard
Hi Bjorn, On Thu, Feb 20, 2014 at 04:38:10PM -0800, Bjorn Andersson wrote: +static int qup_i2c_probe(struct platform_device *pdev) +{ [ snip ] + + qup_i2c_enable_clocks(qup); + [ snip ] + + pm_runtime_set_autosuspend_delay(qup-dev, MSEC_PER_SEC); +

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-21 Thread Mark Rutland
On Fri, Feb 21, 2014 at 12:38:10AM +, Bjorn Andersson wrote: This bus driver supports the QUP i2c hardware controller in the Qualcomm SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general purpose data path engine with input/output FIFOs and an embedded i2c mini-core. The driver

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-21 Thread Kumar Gala
On Feb 20, 2014, at 6:38 PM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: This bus driver supports the QUP i2c hardware controller in the Qualcomm SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general purpose data path engine with input/output FIFOs and an embedded i2c

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-20 Thread Emilio López
Hi Bjorn, El 20/02/14 21:38, Bjorn Andersson escribió: This bus driver supports the QUP i2c hardware controller in the Qualcomm SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general purpose data path engine with input/output FIFOs and an embedded i2c mini-core. The driver supports

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-20 Thread Joe Perches
On Thu, 2014-02-20 at 16:38 -0800, Bjorn Andersson wrote: > This bus driver supports the QUP i2c hardware controller in the Qualcomm SOCs. > The Qualcomm Universal Peripheral Engine (QUP) is a general purpose data path > engine with input/output FIFOs and an embedded i2c mini-core. The driver >

[PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-20 Thread Bjorn Andersson
This bus driver supports the QUP i2c hardware controller in the Qualcomm SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general purpose data path engine with input/output FIFOs and an embedded i2c mini-core. The driver supports FIFO mode (for low bandwidth applications) and block mode

[PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-20 Thread Bjorn Andersson
This bus driver supports the QUP i2c hardware controller in the Qualcomm SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general purpose data path engine with input/output FIFOs and an embedded i2c mini-core. The driver supports FIFO mode (for low bandwidth applications) and block mode

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-20 Thread Joe Perches
On Thu, 2014-02-20 at 16:38 -0800, Bjorn Andersson wrote: This bus driver supports the QUP i2c hardware controller in the Qualcomm SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general purpose data path engine with input/output FIFOs and an embedded i2c mini-core. The driver

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-20 Thread Emilio López
Hi Bjorn, El 20/02/14 21:38, Bjorn Andersson escribió: This bus driver supports the QUP i2c hardware controller in the Qualcomm SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general purpose data path engine with input/output FIFOs and an embedded i2c mini-core. The driver supports