Re: [PATCH v3 2/3] gpio: pca953x: add support for pca9505

2013-01-28 Thread Linus Walleij
On Sat, Jan 26, 2013 at 11:02 PM, Gregory CLEMENT wrote: > I was about to fix the issues you have pointed but I didn't find anything like > > #ifdef CONFIG_ARCH_PXA > if (cpu_is_pxa25x()) { > #ifdef CONFIG_CPU_PXA26x > count = 89; > gpio_type =

Re: [PATCH v3 2/3] gpio: pca953x: add support for pca9505

2013-01-28 Thread Linus Walleij
On Sat, Jan 26, 2013 at 11:02 PM, Gregory CLEMENT gregory.clem...@free-electrons.com wrote: I was about to fix the issues you have pointed but I didn't find anything like #ifdef CONFIG_ARCH_PXA if (cpu_is_pxa25x()) { #ifdef CONFIG_CPU_PXA26x count = 89;

Re: [PATCH v3 2/3] gpio: pca953x: add support for pca9505

2013-01-27 Thread Haojian Zhuang
On 27 January 2013 06:02, Gregory CLEMENT wrote: > On 01/25/2013 09:51 AM, Linus Walleij wrote: >> On Fri, Jan 25, 2013 at 9:36 AM, Gregory CLEMENT >> wrote: >> >>> Well, at the beginning I thought adding support for pca9505 was just a >>> matter >>> of a couple of lines to add. Then I realized

Re: [PATCH v3 2/3] gpio: pca953x: add support for pca9505

2013-01-27 Thread Haojian Zhuang
On 27 January 2013 06:02, Gregory CLEMENT gregory.clem...@free-electrons.com wrote: On 01/25/2013 09:51 AM, Linus Walleij wrote: On Fri, Jan 25, 2013 at 9:36 AM, Gregory CLEMENT gregory.clem...@free-electrons.com wrote: Well, at the beginning I thought adding support for pca9505 was just a

Re: [PATCH v3 2/3] gpio: pca953x: add support for pca9505

2013-01-26 Thread Gregory CLEMENT
On 01/25/2013 09:51 AM, Linus Walleij wrote: > On Fri, Jan 25, 2013 at 9:36 AM, Gregory CLEMENT > wrote: > >> Well, at the beginning I thought adding support for pca9505 was just a matter >> of a couple of lines to add. Then I realized that I need to handle the 40 >> bits >> case, and I ended

Re: [PATCH v3 2/3] gpio: pca953x: add support for pca9505

2013-01-26 Thread Gregory CLEMENT
On 01/25/2013 09:51 AM, Linus Walleij wrote: On Fri, Jan 25, 2013 at 9:36 AM, Gregory CLEMENT gregory.clem...@free-electrons.com wrote: Well, at the beginning I thought adding support for pca9505 was just a matter of a couple of lines to add. Then I realized that I need to handle the 40

Re: [PATCH v3 2/3] gpio: pca953x: add support for pca9505

2013-01-25 Thread Linus Walleij
On Fri, Jan 25, 2013 at 9:36 AM, Gregory CLEMENT wrote: > Well, at the beginning I thought adding support for pca9505 was just a matter > of a couple of lines to add. Then I realized that I need to handle the 40 bits > case, and I ended up refactoring all access to the registers. So now I am on

Re: [PATCH v3 2/3] gpio: pca953x: add support for pca9505

2013-01-25 Thread Gregory CLEMENT
On 01/25/2013 09:16 AM, Linus Walleij wrote: > On Tue, Jan 22, 2013 at 10:10 PM, Gregory CLEMENT > wrote: > >> Now that pca953x driver can handle GPIO expanders with more than 32 >> bits this patch adds the support for the pca9505 which cam with 40 >> GPIOs. >> >> Signed-off-by: Gregory CLEMENT

Re: [PATCH v3 2/3] gpio: pca953x: add support for pca9505

2013-01-25 Thread Linus Walleij
On Tue, Jan 22, 2013 at 10:10 PM, Gregory CLEMENT wrote: > Now that pca953x driver can handle GPIO expanders with more than 32 > bits this patch adds the support for the pca9505 which cam with 40 > GPIOs. > > Signed-off-by: Gregory CLEMENT Patch applied, thanks. But guys, this driver contains

Re: [PATCH v3 2/3] gpio: pca953x: add support for pca9505

2013-01-25 Thread Linus Walleij
On Tue, Jan 22, 2013 at 10:10 PM, Gregory CLEMENT gregory.clem...@free-electrons.com wrote: Now that pca953x driver can handle GPIO expanders with more than 32 bits this patch adds the support for the pca9505 which cam with 40 GPIOs. Signed-off-by: Gregory CLEMENT

Re: [PATCH v3 2/3] gpio: pca953x: add support for pca9505

2013-01-25 Thread Gregory CLEMENT
On 01/25/2013 09:16 AM, Linus Walleij wrote: On Tue, Jan 22, 2013 at 10:10 PM, Gregory CLEMENT gregory.clem...@free-electrons.com wrote: Now that pca953x driver can handle GPIO expanders with more than 32 bits this patch adds the support for the pca9505 which cam with 40 GPIOs.

Re: [PATCH v3 2/3] gpio: pca953x: add support for pca9505

2013-01-25 Thread Linus Walleij
On Fri, Jan 25, 2013 at 9:36 AM, Gregory CLEMENT gregory.clem...@free-electrons.com wrote: Well, at the beginning I thought adding support for pca9505 was just a matter of a couple of lines to add. Then I realized that I need to handle the 40 bits case, and I ended up refactoring all access to

[PATCH v3 2/3] gpio: pca953x: add support for pca9505

2013-01-22 Thread Gregory CLEMENT
Now that pca953x driver can handle GPIO expanders with more than 32 bits this patch adds the support for the pca9505 which cam with 40 GPIOs. Signed-off-by: Gregory CLEMENT --- drivers/gpio/gpio-pca953x.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpio/gpio-pca953x.c

[PATCH v3 2/3] gpio: pca953x: add support for pca9505

2013-01-22 Thread Gregory CLEMENT
Now that pca953x driver can handle GPIO expanders with more than 32 bits this patch adds the support for the pca9505 which cam with 40 GPIOs. Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com --- drivers/gpio/gpio-pca953x.c |2 ++ 1 file changed, 2 insertions(+) diff --git