Re: [PATCH v3 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SDM845

Quoting Amit Nischal (2018-04-18 06:03:49) > On 2018-04-17 09:21, Stephen Boyd wrote: > > Quoting Amit Nischal (2018-04-03 06:22:41) > >> + > >> +static struct clk_rcg2 gcc_usb30_prim_mock_utmi_clk_src = { > >> + .cmd_rcgr = 0xf030, > >> + .mnd_width = 0, > >> + .hid_width = 5, >

Re: [PATCH v3 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SDM845

Quoting Amit Nischal (2018-04-18 06:03:49) > On 2018-04-17 09:21, Stephen Boyd wrote: > > Quoting Amit Nischal (2018-04-03 06:22:41) > >> + > >> +static struct clk_rcg2 gcc_usb30_prim_mock_utmi_clk_src = { > >> + .cmd_rcgr = 0xf030, > >> + .mnd_width = 0, > >> + .hid_width = 5, >

Re: [PATCH v3 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SDM845

Quoting Manu Gautam (2018-04-18 09:38:41) > Hi Amit, > > > On 4/18/2018 6:33 PM, Amit Nischal wrote: > >>> +   /* Disable the GPLL0 active input to MMSS and GPU via MISC > >>> registers */ > >>> +   regmap_update_bits(regmap, 0x09ffc, 0x3, 0x3); > >>> +   regmap_update_bits(regmap, 

Re: [PATCH v3 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SDM845

Quoting Manu Gautam (2018-04-18 09:38:41) > Hi Amit, > > > On 4/18/2018 6:33 PM, Amit Nischal wrote: > >>> +   /* Disable the GPLL0 active input to MMSS and GPU via MISC > >>> registers */ > >>> +   regmap_update_bits(regmap, 0x09ffc, 0x3, 0x3); > >>> +   regmap_update_bits(regmap, 

Re: [PATCH v3 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SDM845

Hi Amit, On 4/18/2018 6:33 PM, Amit Nischal wrote: >>> +   /* Disable the GPLL0 active input to MMSS and GPU via MISC >>> registers */ >>> +   regmap_update_bits(regmap, 0x09ffc, 0x3, 0x3); >>> +   regmap_update_bits(regmap, 0x71028, 0x3, 0x3); >> >> I think we'll have to throw in 

Re: [PATCH v3 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SDM845

Hi Amit, On 4/18/2018 6:33 PM, Amit Nischal wrote: >>> +   /* Disable the GPLL0 active input to MMSS and GPU via MISC >>> registers */ >>> +   regmap_update_bits(regmap, 0x09ffc, 0x3, 0x3); >>> +   regmap_update_bits(regmap, 0x71028, 0x3, 0x3); >> >> I think we'll have to throw in 

Re: [PATCH v3 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SDM845

On 2018-04-17 09:21, Stephen Boyd wrote: Quoting Amit Nischal (2018-04-03 06:22:41) diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig index fbf4532..c961e89 100644 --- a/drivers/clk/qcom/Kconfig +++ b/drivers/clk/qcom/Kconfig @@ -218,6 +218,15 @@ config MSM_MMCC_8996

Re: [PATCH v3 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SDM845

On 2018-04-17 09:21, Stephen Boyd wrote: Quoting Amit Nischal (2018-04-03 06:22:41) diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig index fbf4532..c961e89 100644 --- a/drivers/clk/qcom/Kconfig +++ b/drivers/clk/qcom/Kconfig @@ -218,6 +218,15 @@ config MSM_MMCC_8996

Re: [PATCH v3 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SDM845

Quoting Amit Nischal (2018-04-03 06:22:41) > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig > index fbf4532..c961e89 100644 > --- a/drivers/clk/qcom/Kconfig > +++ b/drivers/clk/qcom/Kconfig > @@ -218,6 +218,15 @@ config MSM_MMCC_8996 > Say Y if you want to support

Re: [PATCH v3 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SDM845

Quoting Amit Nischal (2018-04-03 06:22:41) > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig > index fbf4532..c961e89 100644 > --- a/drivers/clk/qcom/Kconfig > +++ b/drivers/clk/qcom/Kconfig > @@ -218,6 +218,15 @@ config MSM_MMCC_8996 > Say Y if you want to support

[PATCH v3 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SDM845

From: Taniya Das Add support for the global clock controller found on SDM845 based devices. This should allow most non-multimedia device drivers to probe and control their clocks. Signed-off-by: Taniya Das Signed-off-by: Amit Nischal

[PATCH v3 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SDM845

From: Taniya Das Add support for the global clock controller found on SDM845 based devices. This should allow most non-multimedia device drivers to probe and control their clocks. Signed-off-by: Taniya Das Signed-off-by: Amit Nischal --- The patch is dependent upon the below patches related