Re: [PATCH v3 4/4] iio: adc: add support for Allwinner SoCs ADC

2016-08-24 Thread Maxime Ripard
On Thu, Aug 04, 2016 at 10:41:00AM +0200, Quentin Schulz wrote: > > However, I'm not sure this is even possible. Isn't the point of the > > runtime_pm precisely to not be called while you're using the device? > > I agree on the principle but I am using runtime_pm functions (I am > mainly talking

Re: [PATCH v3 4/4] iio: adc: add support for Allwinner SoCs ADC

2016-08-24 Thread Maxime Ripard
On Thu, Aug 04, 2016 at 10:41:00AM +0200, Quentin Schulz wrote: > > However, I'm not sure this is even possible. Isn't the point of the > > runtime_pm precisely to not be called while you're using the device? > > I agree on the principle but I am using runtime_pm functions (I am > mainly talking

Re: [PATCH v3 4/4] iio: adc: add support for Allwinner SoCs ADC

2016-08-21 Thread Jonathan Cameron
On 26/07/16 08:43, Quentin Schulz wrote: > The Allwinner SoCs all have an ADC that can also act as a touchscreen > controller and a thermal sensor. This patch adds the ADC driver which is > based on the MFD for the same SoCs ADC. > > This also registers the thermal adc channel in the iio map

Re: [PATCH v3 4/4] iio: adc: add support for Allwinner SoCs ADC

2016-08-21 Thread Jonathan Cameron
On 26/07/16 08:43, Quentin Schulz wrote: > The Allwinner SoCs all have an ADC that can also act as a touchscreen > controller and a thermal sensor. This patch adds the ADC driver which is > based on the MFD for the same SoCs ADC. > > This also registers the thermal adc channel in the iio map

Re: [PATCH v3 4/4] iio: adc: add support for Allwinner SoCs ADC

2016-08-04 Thread Quentin Schulz
On 04/08/2016 11:56, Russell King - ARM Linux wrote: > On Tue, Jul 26, 2016 at 09:43:47AM +0200, Quentin Schulz wrote: >> +static int sunxi_gpadc_adc_read(struct iio_dev *indio_dev, int channel, >> +int *val) >> +{ >> +struct sunxi_gpadc_dev *info =

Re: [PATCH v3 4/4] iio: adc: add support for Allwinner SoCs ADC

2016-08-04 Thread Quentin Schulz
On 04/08/2016 11:56, Russell King - ARM Linux wrote: > On Tue, Jul 26, 2016 at 09:43:47AM +0200, Quentin Schulz wrote: >> +static int sunxi_gpadc_adc_read(struct iio_dev *indio_dev, int channel, >> +int *val) >> +{ >> +struct sunxi_gpadc_dev *info =

Re: [PATCH v3 4/4] iio: adc: add support for Allwinner SoCs ADC

2016-08-04 Thread Russell King - ARM Linux
On Tue, Jul 26, 2016 at 09:43:47AM +0200, Quentin Schulz wrote: > +static int sunxi_gpadc_adc_read(struct iio_dev *indio_dev, int channel, > + int *val) > +{ > + struct sunxi_gpadc_dev *info = iio_priv(indio_dev); > + int ret = 0; > + > +

Re: [PATCH v3 4/4] iio: adc: add support for Allwinner SoCs ADC

2016-08-04 Thread Russell King - ARM Linux
On Tue, Jul 26, 2016 at 09:43:47AM +0200, Quentin Schulz wrote: > +static int sunxi_gpadc_adc_read(struct iio_dev *indio_dev, int channel, > + int *val) > +{ > + struct sunxi_gpadc_dev *info = iio_priv(indio_dev); > + int ret = 0; > + > +

Re: [PATCH v3 4/4] iio: adc: add support for Allwinner SoCs ADC

2016-08-04 Thread Quentin Schulz
Hi Maxime, On 29/07/2016 09:12, Maxime Ripard wrote: > On Tue, Jul 26, 2016 at 09:43:47AM +0200, Quentin Schulz wrote: [...] >> +static int sunxi_gpadc_adc_read(struct iio_dev *indio_dev, int channel, >> +int *val) >> +{ >> +struct sunxi_gpadc_dev *info =

Re: [PATCH v3 4/4] iio: adc: add support for Allwinner SoCs ADC

2016-08-04 Thread Quentin Schulz
Hi Maxime, On 29/07/2016 09:12, Maxime Ripard wrote: > On Tue, Jul 26, 2016 at 09:43:47AM +0200, Quentin Schulz wrote: [...] >> +static int sunxi_gpadc_adc_read(struct iio_dev *indio_dev, int channel, >> +int *val) >> +{ >> +struct sunxi_gpadc_dev *info =

Re: [PATCH v3 4/4] iio: adc: add support for Allwinner SoCs ADC

2016-07-29 Thread Maxime Ripard
On Tue, Jul 26, 2016 at 09:43:47AM +0200, Quentin Schulz wrote: > The Allwinner SoCs all have an ADC that can also act as a touchscreen > controller and a thermal sensor. This patch adds the ADC driver which is > based on the MFD for the same SoCs ADC. > > This also registers the thermal adc

Re: [PATCH v3 4/4] iio: adc: add support for Allwinner SoCs ADC

2016-07-29 Thread Maxime Ripard
On Tue, Jul 26, 2016 at 09:43:47AM +0200, Quentin Schulz wrote: > The Allwinner SoCs all have an ADC that can also act as a touchscreen > controller and a thermal sensor. This patch adds the ADC driver which is > based on the MFD for the same SoCs ADC. > > This also registers the thermal adc

[PATCH v3 4/4] iio: adc: add support for Allwinner SoCs ADC

2016-07-26 Thread Quentin Schulz
The Allwinner SoCs all have an ADC that can also act as a touchscreen controller and a thermal sensor. This patch adds the ADC driver which is based on the MFD for the same SoCs ADC. This also registers the thermal adc channel in the iio map array so iio_hwmon could use it without modifying the

[PATCH v3 4/4] iio: adc: add support for Allwinner SoCs ADC

2016-07-26 Thread Quentin Schulz
The Allwinner SoCs all have an ADC that can also act as a touchscreen controller and a thermal sensor. This patch adds the ADC driver which is based on the MFD for the same SoCs ADC. This also registers the thermal adc channel in the iio map array so iio_hwmon could use it without modifying the