Re: [PATCH v3 5/6] spi: sun6i: introduce register set/unset helpers

On Tue, Apr 03, 2018 at 06:44:48PM +0300, Sergey Suloev wrote: > Two helper functions were added in order to set/unset > specified flags in registers. > > Signed-off-by: Sergey Suloev Again, I'm not really sure what the benefit of that is. Your diffstat is pretty much

Re: [PATCH v3 5/6] spi: sun6i: introduce register set/unset helpers

On Tue, Apr 03, 2018 at 06:44:48PM +0300, Sergey Suloev wrote: > Two helper functions were added in order to set/unset > specified flags in registers. > > Signed-off-by: Sergey Suloev Again, I'm not really sure what the benefit of that is. Your diffstat is pretty much identical, so it's

Re: [PATCH v3 5/6] spi: sun6i: introduce register set/unset helpers

Hi Sergey, Thank you for the patch! Yet something to improve: [auto build test ERROR on spi/for-next] [also build test ERROR on v4.16 next-20180403] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v3 5/6] spi: sun6i: introduce register set/unset helpers

Hi Sergey, Thank you for the patch! Yet something to improve: [auto build test ERROR on spi/for-next] [also build test ERROR on v4.16 next-20180403] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v3 5/6] spi: sun6i: introduce register set/unset helpers

Two helper functions were added in order to set/unset specified flags in registers. Signed-off-by: Sergey Suloev --- drivers/spi/spi-sun6i.c | 37 - 1 file changed, 16 insertions(+), 21 deletions(-) diff --git a/drivers/spi/spi-sun6i.c

[PATCH v3 5/6] spi: sun6i: introduce register set/unset helpers

Two helper functions were added in order to set/unset specified flags in registers. Signed-off-by: Sergey Suloev --- drivers/spi/spi-sun6i.c | 37 - 1 file changed, 16 insertions(+), 21 deletions(-) diff --git a/drivers/spi/spi-sun6i.c