Re: [PATCH v4 02/10] pinctrl: axp209: add pinctrl features

Hi Quentin, Thank you for the patch! Yet something to improve: [auto build test ERROR on pinctrl/devel] [also build test ERROR on v4.15-rc2 next-20171205] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v4 02/10] pinctrl: axp209: add pinctrl features

Hi Quentin, Thank you for the patch! Yet something to improve: [auto build test ERROR on pinctrl/devel] [also build test ERROR on v4.15-rc2 next-20171205] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v4 02/10] pinctrl: axp209: add pinctrl features

Hi, On Mon, Dec 04, 2017 at 09:07:52AM +0100, Quentin Schulz wrote: > >> +static int axp20x_pmx_set_mux(struct pinctrl_dev *pctldev, > >> +unsigned int function, unsigned int group) > >> +{ > >> + struct axp20x_gpio *gpio = pinctrl_dev_get_drvdata(pctldev); > >> +

Re: [PATCH v4 02/10] pinctrl: axp209: add pinctrl features

Hi, On Mon, Dec 04, 2017 at 09:07:52AM +0100, Quentin Schulz wrote: > >> +static int axp20x_pmx_set_mux(struct pinctrl_dev *pctldev, > >> +unsigned int function, unsigned int group) > >> +{ > >> + struct axp20x_gpio *gpio = pinctrl_dev_get_drvdata(pctldev); > >> +

Re: [PATCH v4 02/10] pinctrl: axp209: add pinctrl features

Hi Maxime, On 01/12/2017 16:57, Maxime Ripard wrote: > On Fri, Dec 01, 2017 at 02:44:43PM +0100, Quentin Schulz wrote: >> +static void axp20x_gpio_set(struct gpio_chip *chip, unsigned offset, >> +int value) >> +{ > > checkpatch output: > WARNING: Prefer 'unsigned int' to

Re: [PATCH v4 02/10] pinctrl: axp209: add pinctrl features

Hi Maxime, On 01/12/2017 16:57, Maxime Ripard wrote: > On Fri, Dec 01, 2017 at 02:44:43PM +0100, Quentin Schulz wrote: >> +static void axp20x_gpio_set(struct gpio_chip *chip, unsigned offset, >> +int value) >> +{ > > checkpatch output: > WARNING: Prefer 'unsigned int' to

Re: [PATCH v4 02/10] pinctrl: axp209: add pinctrl features

On Fri, Dec 01, 2017 at 02:44:43PM +0100, Quentin Schulz wrote: > +static void axp20x_gpio_set(struct gpio_chip *chip, unsigned offset, > + int value) > +{ checkpatch output: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > +static int axp20x_pmx_set_mux(struct

Re: [PATCH v4 02/10] pinctrl: axp209: add pinctrl features

On Fri, Dec 01, 2017 at 02:44:43PM +0100, Quentin Schulz wrote: > +static void axp20x_gpio_set(struct gpio_chip *chip, unsigned offset, > + int value) > +{ checkpatch output: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > +static int axp20x_pmx_set_mux(struct

[PATCH v4 02/10] pinctrl: axp209: add pinctrl features

The X-Powers AXP209 has 3 GPIOs. GPIO0/1 can each act either as a GPIO, an ADC or a LDO regulator. GPIO2 can only act as a GPIO. This adds the pinctrl features to the driver so GPIO0/1 can be used as ADC or LDO regulator. Signed-off-by: Quentin Schulz ---

[PATCH v4 02/10] pinctrl: axp209: add pinctrl features

The X-Powers AXP209 has 3 GPIOs. GPIO0/1 can each act either as a GPIO, an ADC or a LDO regulator. GPIO2 can only act as a GPIO. This adds the pinctrl features to the driver so GPIO0/1 can be used as ADC or LDO regulator. Signed-off-by: Quentin Schulz --- drivers/pinctrl/pinctrl-axp209.c | 306