Re: [PATCH v5] eventfs: Remove eventfs_file and just use eventfs_inode

2023-11-23 Thread Heiko Carstens
On Thu, Nov 23, 2023 at 10:23:49AM -0500, Steven Rostedt wrote: > On Thu, 23 Nov 2023 12:25:48 +0100 > Heiko Carstens wrote: > > > So, if it helps (this still happens with Linus' master branch): > > > > create_dir_dentry() is called with a "struct eventfs_inode *ei" (second > > parameter),

Re: [PATCH v5] eventfs: Remove eventfs_file and just use eventfs_inode

2023-11-23 Thread Steven Rostedt
On Thu, 23 Nov 2023 12:25:48 +0100 Heiko Carstens wrote: > So, if it helps (this still happens with Linus' master branch): > > create_dir_dentry() is called with a "struct eventfs_inode *ei" (second > parameter), which points to a data structure where "is_freed" is 1. Then it > looks like

Re: [PATCH v5] eventfs: Remove eventfs_file and just use eventfs_inode

2023-11-23 Thread Ajay Kaher
> On 23-Nov-2023, at 4:55 PM, Heiko Carstens wrote: > > !! External Email > > On Fri, Nov 17, 2023 at 03:38:29PM +0100, Heiko Carstens wrote: >> On Fri, Nov 17, 2023 at 03:23:35PM +0100, Heiko Carstens wrote: >>> I think this patch causes from time to time crashes when running ftrace >>>

Re: [PATCH v5] eventfs: Remove eventfs_file and just use eventfs_inode

2023-11-23 Thread Heiko Carstens
On Fri, Nov 17, 2023 at 03:38:29PM +0100, Heiko Carstens wrote: > On Fri, Nov 17, 2023 at 03:23:35PM +0100, Heiko Carstens wrote: > > I think this patch causes from time to time crashes when running ftrace > > selftests. In particular I guess there is a bug wrt error handling in this > > function

Re: [PATCH v5] eventfs: Remove eventfs_file and just use eventfs_inode

2023-11-17 Thread Heiko Carstens
On Fri, Nov 17, 2023 at 03:23:35PM +0100, Heiko Carstens wrote: > I think this patch causes from time to time crashes when running ftrace > selftests. In particular I guess there is a bug wrt error handling in this > function (see below for call trace): > > > +static struct dentry * > >

Re: [PATCH v5] eventfs: Remove eventfs_file and just use eventfs_inode

2023-11-17 Thread Heiko Carstens
Hi Steven, On Wed, Oct 04, 2023 at 04:50:07PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > Instead of having a descriptor for every file represented in the eventfs > directory, only have the directory itself represented. Change the API to > send in a list of entries that

[PATCH v5] eventfs: Remove eventfs_file and just use eventfs_inode

2023-10-04 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Instead of having a descriptor for every file represented in the eventfs directory, only have the directory itself represented. Change the API to send in a list of entries that represent all the files in the directory (but not other directories). The entry list