Re: [PATCH v5 2/2] PCI: mediatek: Set up class type and vendor ID for MT7622

2018-03-16 Thread Lorenzo Pieralisi
On Wed, Jan 03, 2018 at 02:39:04PM +0800, Honghui Zhang wrote: > On Tue, 2018-01-02 at 10:56 +, Lorenzo Pieralisi wrote: > > On Thu, Dec 28, 2017 at 09:39:12AM +0800, Honghui Zhang wrote: > > > On Wed, 2017-12-27 at 12:45 -0600, Bjorn Helgaas wrote: > > > > On Wed, Dec 27, 2017 at 08:59:54AM +0

Re: [PATCH v5 2/2] PCI: mediatek: Set up class type and vendor ID for MT7622

2018-03-16 Thread Lorenzo Pieralisi
On Wed, Dec 27, 2017 at 12:45:42PM -0600, Bjorn Helgaas wrote: [...] > > + /* Set up class code for MT7622 */ > > + val = PCI_CLASS_BRIDGE_PCI << 16; > > + writel(val, port->base + PCIE_CONF_CLASS); > > 1) Your comments mention MT7622 specifically, but this code is

Re: [PATCH v5 2/2] PCI: mediatek: Set up class type and vendor ID for MT7622

2018-01-03 Thread Lorenzo Pieralisi
On Wed, Jan 03, 2018 at 02:39:04PM +0800, Honghui Zhang wrote: > On Tue, 2018-01-02 at 10:56 +, Lorenzo Pieralisi wrote: > > On Thu, Dec 28, 2017 at 09:39:12AM +0800, Honghui Zhang wrote: > > > On Wed, 2017-12-27 at 12:45 -0600, Bjorn Helgaas wrote: > > > > On Wed, Dec 27, 2017 at 08:59:54AM +0

Re: [PATCH v5 2/2] PCI: mediatek: Set up class type and vendor ID for MT7622

2018-01-02 Thread Honghui Zhang
On Tue, 2018-01-02 at 10:56 +, Lorenzo Pieralisi wrote: > On Thu, Dec 28, 2017 at 09:39:12AM +0800, Honghui Zhang wrote: > > On Wed, 2017-12-27 at 12:45 -0600, Bjorn Helgaas wrote: > > > On Wed, Dec 27, 2017 at 08:59:54AM +0800, honghui.zh...@mediatek.com > > > wrote: > > > > From: Honghui Zha

Re: [PATCH v5 2/2] PCI: mediatek: Set up class type and vendor ID for MT7622

2018-01-02 Thread Lorenzo Pieralisi
On Thu, Dec 28, 2017 at 09:39:12AM +0800, Honghui Zhang wrote: > On Wed, 2017-12-27 at 12:45 -0600, Bjorn Helgaas wrote: > > On Wed, Dec 27, 2017 at 08:59:54AM +0800, honghui.zh...@mediatek.com wrote: > > > From: Honghui Zhang > > > > > > The hardware default value of IDs and class type is not co

Re: [PATCH v5 2/2] PCI: mediatek: Set up class type and vendor ID for MT7622

2017-12-27 Thread Honghui Zhang
On Wed, 2017-12-27 at 12:45 -0600, Bjorn Helgaas wrote: > On Wed, Dec 27, 2017 at 08:59:54AM +0800, honghui.zh...@mediatek.com wrote: > > From: Honghui Zhang > > > > The hardware default value of IDs and class type is not correct, > > fix that by setup the correct values before start up. > > > >

Re: [PATCH v5 2/2] PCI: mediatek: Set up class type and vendor ID for MT7622

2017-12-27 Thread Bjorn Helgaas
On Wed, Dec 27, 2017 at 08:59:54AM +0800, honghui.zh...@mediatek.com wrote: > From: Honghui Zhang > > The hardware default value of IDs and class type is not correct, > fix that by setup the correct values before start up. > > Signed-off-by: Honghui Zhang > --- > drivers/pci/host/pcie-mediatek

[PATCH v5 2/2] PCI: mediatek: Set up class type and vendor ID for MT7622

2017-12-26 Thread honghui.zhang
From: Honghui Zhang The hardware default value of IDs and class type is not correct, fix that by setup the correct values before start up. Signed-off-by: Honghui Zhang --- drivers/pci/host/pcie-mediatek.c | 12 include/linux/pci_ids.h | 2 ++ 2 files changed, 14 insertio