Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On 11/10/2016 12:42 PM, Bjorn Helgaas wrote: > For the PNP/ACPI quirks, there are two interesting cases: > > 1) Firmware provides a PNP0C02 device, but its _CRS doesn't include > the ECAM space, and > > 2) Firmware doesn't provide a PNP0C02 device at all. > > For case 1, we could

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On 11/10/2016 12:42 PM, Bjorn Helgaas wrote: > For the PNP/ACPI quirks, there are two interesting cases: > > 1) Firmware provides a PNP0C02 device, but its _CRS doesn't include > the ECAM space, and > > 2) Firmware doesn't provide a PNP0C02 device at all. > > For case 1, we could

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On 11/03/2016 10:00 AM, Bjorn Helgaas wrote: > It turns out that we can't use the _CRS of host bridges because of the > Producer/Consumer bit screwup [1]. So the fallback is to include the > ECAM space in the _CRS of a PNP0C02 device. This is what the PCI > Firmware spec r3.0, Table 4-2,

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On 11/03/2016 10:00 AM, Bjorn Helgaas wrote: > It turns out that we can't use the _CRS of host bridges because of the > Producer/Consumer bit screwup [1]. So the fallback is to include the > ECAM space in the _CRS of a PNP0C02 device. This is what the PCI > Firmware spec r3.0, Table 4-2,

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On Thu, Nov 10, 2016 at 06:25:16PM +0800, Ard Biesheuvel wrote: > On 10 November 2016 at 06:49, Bjorn Helgaas wrote: > > On Wed, Nov 09, 2016 at 08:29:23PM +, Ard Biesheuvel wrote: > >> Hi Bjorn, > >> > >> On 9 November 2016 at 20:06, Bjorn Helgaas

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On Thu, Nov 10, 2016 at 06:25:16PM +0800, Ard Biesheuvel wrote: > On 10 November 2016 at 06:49, Bjorn Helgaas wrote: > > On Wed, Nov 09, 2016 at 08:29:23PM +, Ard Biesheuvel wrote: > >> Hi Bjorn, > >> > >> On 9 November 2016 at 20:06, Bjorn Helgaas wrote: > >> > On Wed, Nov 09, 2016 at

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On Thu, Nov 10, 2016 at 06:25:16PM +0800, Ard Biesheuvel wrote: > On 10 November 2016 at 06:49, Bjorn Helgaas wrote: > > On Wed, Nov 09, 2016 at 08:29:23PM +, Ard Biesheuvel wrote: > >> Hi Bjorn, > >> > >> On 9 November 2016 at 20:06, Bjorn Helgaas

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On Thu, Nov 10, 2016 at 06:25:16PM +0800, Ard Biesheuvel wrote: > On 10 November 2016 at 06:49, Bjorn Helgaas wrote: > > On Wed, Nov 09, 2016 at 08:29:23PM +, Ard Biesheuvel wrote: > >> Hi Bjorn, > >> > >> On 9 November 2016 at 20:06, Bjorn Helgaas wrote: > >> > On Wed, Nov 09, 2016 at

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On 10 November 2016 at 06:49, Bjorn Helgaas wrote: > On Wed, Nov 09, 2016 at 08:29:23PM +, Ard Biesheuvel wrote: >> Hi Bjorn, >> >> On 9 November 2016 at 20:06, Bjorn Helgaas wrote: >> > On Wed, Nov 09, 2016 at 02:25:56PM -0500, Christopher Covington

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On 10 November 2016 at 06:49, Bjorn Helgaas wrote: > On Wed, Nov 09, 2016 at 08:29:23PM +, Ard Biesheuvel wrote: >> Hi Bjorn, >> >> On 9 November 2016 at 20:06, Bjorn Helgaas wrote: >> > On Wed, Nov 09, 2016 at 02:25:56PM -0500, Christopher Covington wrote: >> >> Hi Bjorn, >> >> >> [...] >>

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On Wed, Nov 09, 2016 at 08:29:23PM +, Ard Biesheuvel wrote: > Hi Bjorn, > > On 9 November 2016 at 20:06, Bjorn Helgaas wrote: > > On Wed, Nov 09, 2016 at 02:25:56PM -0500, Christopher Covington wrote: > >> Hi Bjorn, > >> > [...] > >> > >> We're working to add the PNP0C02

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On Wed, Nov 09, 2016 at 08:29:23PM +, Ard Biesheuvel wrote: > Hi Bjorn, > > On 9 November 2016 at 20:06, Bjorn Helgaas wrote: > > On Wed, Nov 09, 2016 at 02:25:56PM -0500, Christopher Covington wrote: > >> Hi Bjorn, > >> > [...] > >> > >> We're working to add the PNP0C02 resource to future

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

Hi Bjorn, On 9 November 2016 at 20:06, Bjorn Helgaas wrote: > On Wed, Nov 09, 2016 at 02:25:56PM -0500, Christopher Covington wrote: >> Hi Bjorn, >> [...] >> >> We're working to add the PNP0C02 resource to future firmware, but it's >> not in the current firmware. Are dmesg

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

Hi Bjorn, On 9 November 2016 at 20:06, Bjorn Helgaas wrote: > On Wed, Nov 09, 2016 at 02:25:56PM -0500, Christopher Covington wrote: >> Hi Bjorn, >> [...] >> >> We're working to add the PNP0C02 resource to future firmware, but it's >> not in the current firmware. Are dmesg and /proc/iomem from

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On Wed, Nov 09, 2016 at 02:25:56PM -0500, Christopher Covington wrote: > Hi Bjorn, > > On 11/02/2016 12:08 PM, Bjorn Helgaas wrote: > > On Tue, Nov 01, 2016 at 07:06:31AM -0600, c...@codeaurora.org wrote: > >> Hi Bjorn, > >> > >> On 2016-10-31 15:48, Bjorn Helgaas wrote: > >>> On Wed, Sep 21,

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On Wed, Nov 09, 2016 at 02:25:56PM -0500, Christopher Covington wrote: > Hi Bjorn, > > On 11/02/2016 12:08 PM, Bjorn Helgaas wrote: > > On Tue, Nov 01, 2016 at 07:06:31AM -0600, c...@codeaurora.org wrote: > >> Hi Bjorn, > >> > >> On 2016-10-31 15:48, Bjorn Helgaas wrote: > >>> On Wed, Sep 21,

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

Hi Bjorn, On 11/02/2016 12:08 PM, Bjorn Helgaas wrote: > On Tue, Nov 01, 2016 at 07:06:31AM -0600, c...@codeaurora.org wrote: >> Hi Bjorn, >> >> On 2016-10-31 15:48, Bjorn Helgaas wrote: >>> On Wed, Sep 21, 2016 at 06:38:05PM -0400, Christopher Covington wrote: The Qualcomm Technologies

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

Hi Bjorn, On 11/02/2016 12:08 PM, Bjorn Helgaas wrote: > On Tue, Nov 01, 2016 at 07:06:31AM -0600, c...@codeaurora.org wrote: >> Hi Bjorn, >> >> On 2016-10-31 15:48, Bjorn Helgaas wrote: >>> On Wed, Sep 21, 2016 at 06:38:05PM -0400, Christopher Covington wrote: The Qualcomm Technologies

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On 11/3/2016 4:43 PM, Bjorn Helgaas wrote: > On Thu, Nov 03, 2016 at 12:58:10PM -0400, Sinan Kaya wrote: >> >> On 11/3/2016 10:00 AM, Bjorn Helgaas wrote: >>> On Wed, Nov 02, 2016 at 12:36:16PM -0400, Sinan Kaya wrote: Hi Bjorn, On 11/2/2016 12:08 PM, Bjorn Helgaas wrote: > On

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On 11/3/2016 4:43 PM, Bjorn Helgaas wrote: > On Thu, Nov 03, 2016 at 12:58:10PM -0400, Sinan Kaya wrote: >> >> On 11/3/2016 10:00 AM, Bjorn Helgaas wrote: >>> On Wed, Nov 02, 2016 at 12:36:16PM -0400, Sinan Kaya wrote: Hi Bjorn, On 11/2/2016 12:08 PM, Bjorn Helgaas wrote: > On

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On Thu, Nov 03, 2016 at 12:58:10PM -0400, Sinan Kaya wrote: > > On 11/3/2016 10:00 AM, Bjorn Helgaas wrote: > > On Wed, Nov 02, 2016 at 12:36:16PM -0400, Sinan Kaya wrote: > >> Hi Bjorn, > >> > >> On 11/2/2016 12:08 PM, Bjorn Helgaas wrote: > >>> On Tue, Nov 01, 2016 at 07:06:31AM -0600,

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On Thu, Nov 03, 2016 at 12:58:10PM -0400, Sinan Kaya wrote: > > On 11/3/2016 10:00 AM, Bjorn Helgaas wrote: > > On Wed, Nov 02, 2016 at 12:36:16PM -0400, Sinan Kaya wrote: > >> Hi Bjorn, > >> > >> On 11/2/2016 12:08 PM, Bjorn Helgaas wrote: > >>> On Tue, Nov 01, 2016 at 07:06:31AM -0600,

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On 11/3/2016 12:58 PM, Sinan Kaya wrote: >> > This is the crucial point I have failed to communicate clearly: the >> > PNP0C02 resource is *always* required, even if the MCFG is correct. >> > > Interesting... > > It looks like there is a lot of lessons learnt here from history. > > I think this

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On 11/3/2016 12:58 PM, Sinan Kaya wrote: >> > This is the crucial point I have failed to communicate clearly: the >> > PNP0C02 resource is *always* required, even if the MCFG is correct. >> > > Interesting... > > It looks like there is a lot of lessons learnt here from history. > > I think this

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On 11/3/2016 10:00 AM, Bjorn Helgaas wrote: > On Wed, Nov 02, 2016 at 12:36:16PM -0400, Sinan Kaya wrote: >> Hi Bjorn, >> >> On 11/2/2016 12:08 PM, Bjorn Helgaas wrote: >>> On Tue, Nov 01, 2016 at 07:06:31AM -0600, c...@codeaurora.org wrote: Hi Bjorn, On 2016-10-31 15:48, Bjorn

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On 11/3/2016 10:00 AM, Bjorn Helgaas wrote: > On Wed, Nov 02, 2016 at 12:36:16PM -0400, Sinan Kaya wrote: >> Hi Bjorn, >> >> On 11/2/2016 12:08 PM, Bjorn Helgaas wrote: >>> On Tue, Nov 01, 2016 at 07:06:31AM -0600, c...@codeaurora.org wrote: Hi Bjorn, On 2016-10-31 15:48, Bjorn

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On Wed, Nov 02, 2016 at 12:36:16PM -0400, Sinan Kaya wrote: > Hi Bjorn, > > On 11/2/2016 12:08 PM, Bjorn Helgaas wrote: > > On Tue, Nov 01, 2016 at 07:06:31AM -0600, c...@codeaurora.org wrote: > >> Hi Bjorn, > >> > >> On 2016-10-31 15:48, Bjorn Helgaas wrote: > >>> On Wed, Sep 21, 2016 at

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On Wed, Nov 02, 2016 at 12:36:16PM -0400, Sinan Kaya wrote: > Hi Bjorn, > > On 11/2/2016 12:08 PM, Bjorn Helgaas wrote: > > On Tue, Nov 01, 2016 at 07:06:31AM -0600, c...@codeaurora.org wrote: > >> Hi Bjorn, > >> > >> On 2016-10-31 15:48, Bjorn Helgaas wrote: > >>> On Wed, Sep 21, 2016 at

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On Wed, Nov 02, 2016 at 11:08:20AM -0500, Bjorn Helgaas wrote: > On Tue, Nov 01, 2016 at 07:06:31AM -0600, c...@codeaurora.org wrote: > > Hi Bjorn, > > > > On 2016-10-31 15:48, Bjorn Helgaas wrote: > > >On Wed, Sep 21, 2016 at 06:38:05PM -0400, Christopher Covington wrote: > > >>The Qualcomm

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On Wed, Nov 02, 2016 at 11:08:20AM -0500, Bjorn Helgaas wrote: > On Tue, Nov 01, 2016 at 07:06:31AM -0600, c...@codeaurora.org wrote: > > Hi Bjorn, > > > > On 2016-10-31 15:48, Bjorn Helgaas wrote: > > >On Wed, Sep 21, 2016 at 06:38:05PM -0400, Christopher Covington wrote: > > >>The Qualcomm

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

Hi Bjorn, On 11/2/2016 12:08 PM, Bjorn Helgaas wrote: > On Tue, Nov 01, 2016 at 07:06:31AM -0600, c...@codeaurora.org wrote: >> Hi Bjorn, >> >> On 2016-10-31 15:48, Bjorn Helgaas wrote: >>> On Wed, Sep 21, 2016 at 06:38:05PM -0400, Christopher Covington wrote: The Qualcomm Technologies

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

Hi Bjorn, On 11/2/2016 12:08 PM, Bjorn Helgaas wrote: > On Tue, Nov 01, 2016 at 07:06:31AM -0600, c...@codeaurora.org wrote: >> Hi Bjorn, >> >> On 2016-10-31 15:48, Bjorn Helgaas wrote: >>> On Wed, Sep 21, 2016 at 06:38:05PM -0400, Christopher Covington wrote: The Qualcomm Technologies

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On Tue, Nov 01, 2016 at 07:06:31AM -0600, c...@codeaurora.org wrote: > Hi Bjorn, > > On 2016-10-31 15:48, Bjorn Helgaas wrote: > >On Wed, Sep 21, 2016 at 06:38:05PM -0400, Christopher Covington wrote: > >>The Qualcomm Technologies QDF2432 SoC does not support accesses > >>smaller > >>than 32 bits

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On Tue, Nov 01, 2016 at 07:06:31AM -0600, c...@codeaurora.org wrote: > Hi Bjorn, > > On 2016-10-31 15:48, Bjorn Helgaas wrote: > >On Wed, Sep 21, 2016 at 06:38:05PM -0400, Christopher Covington wrote: > >>The Qualcomm Technologies QDF2432 SoC does not support accesses > >>smaller > >>than 32 bits

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

Hi Bjorn, On 2016-10-31 15:48, Bjorn Helgaas wrote: On Wed, Sep 21, 2016 at 06:38:05PM -0400, Christopher Covington wrote: The Qualcomm Technologies QDF2432 SoC does not support accesses smaller than 32 bits to the PCI configuration space. Register the appropriate quirk. Signed-off-by:

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

Hi Bjorn, On 2016-10-31 15:48, Bjorn Helgaas wrote: On Wed, Sep 21, 2016 at 06:38:05PM -0400, Christopher Covington wrote: The Qualcomm Technologies QDF2432 SoC does not support accesses smaller than 32 bits to the PCI configuration space. Register the appropriate quirk. Signed-off-by:

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On Wed, Sep 21, 2016 at 06:38:05PM -0400, Christopher Covington wrote: > The Qualcomm Technologies QDF2432 SoC does not support accesses smaller > than 32 bits to the PCI configuration space. Register the appropriate > quirk. > > Signed-off-by: Christopher Covington Hi

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

On Wed, Sep 21, 2016 at 06:38:05PM -0400, Christopher Covington wrote: > The Qualcomm Technologies QDF2432 SoC does not support accesses smaller > than 32 bits to the PCI configuration space. Register the appropriate > quirk. > > Signed-off-by: Christopher Covington Hi Christopher, Can you

[PATCHv2] PCI: QDF2432 32 bit config space accessors

The Qualcomm Technologies QDF2432 SoC does not support accesses smaller than 32 bits to the PCI configuration space. Register the appropriate quirk. Signed-off-by: Christopher Covington --- drivers/acpi/pci_mcfg.c | 8 drivers/pci/ecam.c | 10 ++

[PATCHv2] PCI: QDF2432 32 bit config space accessors

The Qualcomm Technologies QDF2432 SoC does not support accesses smaller than 32 bits to the PCI configuration space. Register the appropriate quirk. Signed-off-by: Christopher Covington --- drivers/acpi/pci_mcfg.c | 8 drivers/pci/ecam.c | 10 ++