Re: [RFC] Don't print sample_type bits in non-group events not set in the group's was Re: [PATCH] perf, script: Fix crash with printing mixed trace point and other events

2019-01-29 Thread Jiri Olsa
On Tue, Jan 29, 2019 at 09:48:51AM +0100, Arnaldo Carvalho de Melo wrote: > Em Mon, Jan 28, 2019 at 09:00:37AM -0800, Andi Kleen escreveu: > > > > also now it won't make sample for slave events > > > > with zero value/period read > > > > > > > > note the patch needs to be split into more patches,

Re: [RFC] Don't print sample_type bits in non-group events not set in the group's was Re: [PATCH] perf, script: Fix crash with printing mixed trace point and other events

2019-01-29 Thread Arnaldo Carvalho de Melo
Em Mon, Jan 28, 2019 at 09:00:37AM -0800, Andi Kleen escreveu: > > > also now it won't make sample for slave events > > > with zero value/period read > > > > > > note the patch needs to be split into more patches, > > > sending it all together for discussion over the solution > > > > any

Re: [RFC] Don't print sample_type bits in non-group events not set in the group's was Re: [PATCH] perf, script: Fix crash with printing mixed trace point and other events

2019-01-28 Thread Andi Kleen
> > also now it won't make sample for slave events > > with zero value/period read > > > > note the patch needs to be split into more patches, > > sending it all together for discussion over the solution > > any feedback on this one? Looks good to me. Reviewed-by: Andi Kleen -Andi

Re: [RFC] Don't print sample_type bits in non-group events not set in the group's was Re: [PATCH] perf, script: Fix crash with printing mixed trace point and other events

2019-01-28 Thread Jiri Olsa
On Sat, Jan 19, 2019 at 04:37:45PM +0100, Jiri Olsa wrote: > On Fri, Jan 18, 2019 at 08:11:42AM -0800, Andi Kleen wrote: > > > +static bool perf_evsel__should_skip(struct perf_evsel *evsel) > > > +{ > > > + struct perf_event_attr *attr = >attr; > > > + struct perf_evsel *leader = evsel->leader; >

Re: [RFC] Don't print sample_type bits in non-group events not set in the group's was Re: [PATCH] perf, script: Fix crash with printing mixed trace point and other events

2019-01-19 Thread Jiri Olsa
On Fri, Jan 18, 2019 at 08:11:42AM -0800, Andi Kleen wrote: > > +static bool perf_evsel__should_skip(struct perf_evsel *evsel) > > +{ > > + struct perf_event_attr *attr = >attr; > > + struct perf_evsel *leader = evsel->leader; > > + > > + return (leader != evsel) && !attr->freq &&

Re: [RFC] Don't print sample_type bits in non-group events not set in the group's was Re: [PATCH] perf, script: Fix crash with printing mixed trace point and other events

2019-01-18 Thread Jiri Olsa
On Fri, Jan 18, 2019 at 08:11:42AM -0800, Andi Kleen wrote: > > +static bool perf_evsel__should_skip(struct perf_evsel *evsel) > > +{ > > + struct perf_event_attr *attr = >attr; > > + struct perf_evsel *leader = evsel->leader; > > + > > + return (leader != evsel) && !attr->freq &&

Re: [RFC] Don't print sample_type bits in non-group events not set in the group's was Re: [PATCH] perf, script: Fix crash with printing mixed trace point and other events

2019-01-18 Thread Andi Kleen
> +static bool perf_evsel__should_skip(struct perf_evsel *evsel) > +{ > + struct perf_event_attr *attr = >attr; > + struct perf_evsel *leader = evsel->leader; > + > + return (leader != evsel) && !attr->freq && !attr->sample_freq; > +} > + > static int process_sample_event(struct

Re: [RFC] Don't print sample_type bits in non-group events not set in the group's was Re: [PATCH] perf, script: Fix crash with printing mixed trace point and other events

2019-01-18 Thread Jiri Olsa
On Fri, Jan 18, 2019 at 10:42:05AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jan 18, 2019 at 10:01:06AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Fri, Jan 18, 2019 at 09:59:20AM -0300, Arnaldo Carvalho de Melo escreveu: > > > Thanks, tested and applied. > > > > While testing I found

[RFC] Don't print sample_type bits in non-group events not set in the group's was Re: [PATCH] perf, script: Fix crash with printing mixed trace point and other events

2019-01-18 Thread Arnaldo Carvalho de Melo
Em Fri, Jan 18, 2019 at 10:01:06AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Jan 18, 2019 at 09:59:20AM -0300, Arnaldo Carvalho de Melo escreveu: > > Thanks, tested and applied. > > While testing I found something odd, the cycles events are not showing > > the CPU and the probe events