Re: [RFC 1/2] ARM: dts: exynos: Add proper regulator states for suspend-to-mem for odroid-u3
Hi Krzysztof,
On Fri, 15 Feb 2019 at 13:01, Krzysztof Kozlowski wrote:
>
> On Thu, 14 Feb 2019 at 19:35, Anand Moon wrote:
> >
> > hi Krzysztof,
> >
> > Thanks fro your review comments.
> >
> > On Thu, 14 Feb 2019 at 18:11, Krzysztof Kozlowski wrote:
> > >
> > > Hi Anand,
> > >
> > > Thanks for the patch. See comments below.
> > >
> > > On Wed, 13 Feb 2019 at 22:41, Anand Moon wrote:
> > > >
> > > > Add suspend-to-mem node to regulator core to be enabled or disabled
> > > > during system suspend and also support changing the regulator operating
> > > > mode during runtime and when the system enter sleep mode.
> > > >
> > > > Cc: Marek Szyprowski
> > > > Cc: Krzysztof Kozlowski
> > > > Cc: Chanwoo Choi
> > > > Signed-off-by: Anand Moon
> > > > ---
> > > >
> > > > Changes from previos patch
> > > > [0] https://patchwork.kernel.org/patch/10712549/
> > > >
> > > > Set all the WAKEUP source regulator in suspend-on state.
> > > > LD04, LD012, LD015, LD020, LD022
> > > > Set all the non used regulator in suspend-odd state
> > > > LD02, LD03, LD05, LD06, LD07, LD011, LD013, LDO14, LD016
> > > >
> > > > BUCK5, BUCK6, BUCK7 and not confirable as per driver max77686-regulator
> > > >
> > > > Tested on microSD card and it resumes correcly after suspend.
> > > > eMMC is not able to resume after entering into suspend state,
> > > > which need to be investigated and how to debug more.
> > > > ---
> > > > .../boot/dts/exynos4412-odroid-common.dtsi| 63 +++
> > > > arch/arm/boot/dts/exynos4412-odroidu3.dts | 3 +
> > > > 2 files changed, 66 insertions(+)
> > > >
> > > > diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > > > b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > > > index 08d3a0a7b4eb..e984461c37d9 100644
> > > > --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > > > +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > > > @@ -288,6 +288,9 @@
> > > > regulator-min-microvolt = <180>;
> > > > regulator-max-microvolt = <180>;
> > > > regulator-always-on;
> > > > + regulator-state-mem {
> > > > + regulator-off-in-suspend;
> > > > + };
> > >
> > > I see my comment from previous patch was not addressed.
> >
> > I left this unchanged since this regulator is not active linked and used.
> > Ok I will change this to regulator-on-in-suspend,
>
> Why?
>
> Previous patch was setting this to "on". I said that this is noop and
> if you want to add it, I need explanation why this regulator has to
> stay on during suspend.
>
> So you changed to "off"... which is still noop... and you did not
> provide explanation. Now you replied that you will change to "on"...
> so this will be circle. Still without explanation.
>
I have added some debug prints to get more inputs.
Here is the boot logs for sdcard suspend resume
[1] https://pastebin.com/wvJvJidp
[root@archl-u3m ~]# rtcwake -d /dev/rtc0 -m mem -s 10
rtcwake: assuming RTC uses UTC ...
rtcwake: wakeup from "mem" using /dev/rtc0 at Fri Feb 15 13:28:06 2019
[ 97.165349] PM: suspend entry (deep)
[ 97.165846] PM: Syncing filesystems ... done.
[ 97.344436] Freezing user space processes ... (elapsed 0.006 seconds) done.
[ 97.354738] OOM killer disabled.
[ 97.356028] Freezing remaining freezable tasks ... (elapsed 0.004
seconds) done.
[ 97.413453] smsc95xx 1-2:1.0 eth0: entering SUSPEND2 mode
[ 97.423227] sd 0:0:0:0: [sda] Synchronizing SCSI cache
[ 97.444346] dwc2 1248.hsotg: suspending usb gadget g_ether
[ 97.446728] dwc2 1248.hsotg: dwc2_hsotg_ep_disable: called for ep0
[ 97.451287] dwc2 1248.hsotg: dwc2_hsotg_ep_disable: called for ep0
[ 97.457742] dwc2 1248.hsotg: new device is full-speed
[ 97.465766] wake enabled for irq 119
[ 97.466979] BUCK9: No configuration
[ 97.470417] BUCK8_P3V3: No configuration
[ 97.474131] BUCK7_2.0V: No configuration
[ 97.477954] BUCK6_1.35V: No configuration
[ 97.481946] VDDQ_CKEM1_2_1.2V: No configuration
[ 97.487930] BUCK4: regulator suspend disable supported
[ 97.491964] BUCK3: regulator suspend disable supported
[ 97.497184] BUCK1: regulator suspend disable supported
[ 97.501838] LDO26: No configuration
[ 97.505383] LDO24: No configuration
[ 97.508761] LDO23: No configuration
[ 97.512368] LDO19: No configuration
[ 97.515706] LDO18: No configuration
[ 97.519178] LDO17: No configuration
[ 97.523076] LDO16: regulator suspend disable supported
[ 97.528154] LDO15: regulator suspend disable supported
[ 97.533367] LDO14: regulator suspend disable supported
[ 97.538447] LDO12: regulator suspend disable supported
[ 97.543603] LDO11: regulator suspend disable supported
[ 97.548308] LDO9: No configuration
[ 97.552107]
Re: [RFC 1/2] ARM: dts: exynos: Add proper regulator states for suspend-to-mem for odroid-u3
Hi Krzysztof,
On Fri, 15 Feb 2019 at 13:01, Krzysztof Kozlowski wrote:
>
> On Thu, 14 Feb 2019 at 19:35, Anand Moon wrote:
> >
> > hi Krzysztof,
> >
> > Thanks fro your review comments.
> >
> > On Thu, 14 Feb 2019 at 18:11, Krzysztof Kozlowski wrote:
> > >
> > > Hi Anand,
> > >
> > > Thanks for the patch. See comments below.
> > >
> > > On Wed, 13 Feb 2019 at 22:41, Anand Moon wrote:
> > > >
> > > > Add suspend-to-mem node to regulator core to be enabled or disabled
> > > > during system suspend and also support changing the regulator operating
> > > > mode during runtime and when the system enter sleep mode.
> > > >
> > > > Cc: Marek Szyprowski
> > > > Cc: Krzysztof Kozlowski
> > > > Cc: Chanwoo Choi
> > > > Signed-off-by: Anand Moon
> > > > ---
> > > >
> > > > Changes from previos patch
> > > > [0] https://patchwork.kernel.org/patch/10712549/
> > > >
> > > > Set all the WAKEUP source regulator in suspend-on state.
> > > > LD04, LD012, LD015, LD020, LD022
> > > > Set all the non used regulator in suspend-odd state
> > > > LD02, LD03, LD05, LD06, LD07, LD011, LD013, LDO14, LD016
> > > >
> > > > BUCK5, BUCK6, BUCK7 and not confirable as per driver max77686-regulator
> > > >
> > > > Tested on microSD card and it resumes correcly after suspend.
> > > > eMMC is not able to resume after entering into suspend state,
> > > > which need to be investigated and how to debug more.
> > > > ---
> > > > .../boot/dts/exynos4412-odroid-common.dtsi| 63 +++
> > > > arch/arm/boot/dts/exynos4412-odroidu3.dts | 3 +
> > > > 2 files changed, 66 insertions(+)
> > > >
> > > > diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > > > b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > > > index 08d3a0a7b4eb..e984461c37d9 100644
> > > > --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > > > +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > > > @@ -288,6 +288,9 @@
> > > > regulator-min-microvolt = <180>;
> > > > regulator-max-microvolt = <180>;
> > > > regulator-always-on;
> > > > + regulator-state-mem {
> > > > + regulator-off-in-suspend;
> > > > + };
> > >
> > > I see my comment from previous patch was not addressed.
> >
> > I left this unchanged since this regulator is not active linked and used.
> > Ok I will change this to regulator-on-in-suspend,
>
> Why?
>
> Previous patch was setting this to "on". I said that this is noop and
> if you want to add it, I need explanation why this regulator has to
> stay on during suspend.
>
> So you changed to "off"... which is still noop... and you did not
> provide explanation. Now you replied that you will change to "on"...
> so this will be circle. Still without explanation.
>
I will re check with my previous patch and the driver code which
support suspend state.
Ok check the regulator driver max77686-regulator and enable the logs their.
> >
> > From documentation device tree binding regulator.txt
> > "- regulator-always-on: boolean, regulator should never be disabled"
> >
> > But some regulator switches to a low power mode under light current loads
> > and the device automatically switches back to a fast response mode as the
> > output load increases.
> >
> > >
> > > > };
> > > >
> > > > ldo3_reg: LDO3 {
> > > > @@ -295,6 +298,9 @@
> > > > regulator-min-microvolt = <180>;
> > > > regulator-max-microvolt = <180>;
> > > > regulator-always-on;
> > > > + regulator-state-mem {
> > > > + regulator-off-in-suspend;
> > > > + };
> > >
> > > The same...
> >
> > Ok I will change this to regulator-on-in-suspend,
>
> The same - why changing this to on or off? I need explanation why this
> should be in first place.
I will check in the driver code.
>
> > >
> > > > };
> > > >
> > > > ldo4_reg: LDO4 {
> > > > @@ -302,6 +308,9 @@
> > > > regulator-min-microvolt = <280>;
> > > > regulator-max-microvolt = <280>;
> > > > regulator-boot-on;
> > > > + regulator-state-mem {
> > > > + regulator-on-in-suspend;
> > > > + };
> > > > };
> > > >
> > > > ldo5_reg: LDO5 {
> > > > @@ -310,6 +319,9 @@
> > > > regulator-max-microvolt = <180>;
> > > > regulator-always-on;
> > > > regulator-boot-on;
> > > > +
Re: [RFC 1/2] ARM: dts: exynos: Add proper regulator states for suspend-to-mem for odroid-u3
On Thu, 14 Feb 2019 at 19:35, Anand Moon wrote:
>
> hi Krzysztof,
>
> Thanks fro your review comments.
>
> On Thu, 14 Feb 2019 at 18:11, Krzysztof Kozlowski wrote:
> >
> > Hi Anand,
> >
> > Thanks for the patch. See comments below.
> >
> > On Wed, 13 Feb 2019 at 22:41, Anand Moon wrote:
> > >
> > > Add suspend-to-mem node to regulator core to be enabled or disabled
> > > during system suspend and also support changing the regulator operating
> > > mode during runtime and when the system enter sleep mode.
> > >
> > > Cc: Marek Szyprowski
> > > Cc: Krzysztof Kozlowski
> > > Cc: Chanwoo Choi
> > > Signed-off-by: Anand Moon
> > > ---
> > >
> > > Changes from previos patch
> > > [0] https://patchwork.kernel.org/patch/10712549/
> > >
> > > Set all the WAKEUP source regulator in suspend-on state.
> > > LD04, LD012, LD015, LD020, LD022
> > > Set all the non used regulator in suspend-odd state
> > > LD02, LD03, LD05, LD06, LD07, LD011, LD013, LDO14, LD016
> > >
> > > BUCK5, BUCK6, BUCK7 and not confirable as per driver max77686-regulator
> > >
> > > Tested on microSD card and it resumes correcly after suspend.
> > > eMMC is not able to resume after entering into suspend state,
> > > which need to be investigated and how to debug more.
> > > ---
> > > .../boot/dts/exynos4412-odroid-common.dtsi| 63 +++
> > > arch/arm/boot/dts/exynos4412-odroidu3.dts | 3 +
> > > 2 files changed, 66 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > > b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > > index 08d3a0a7b4eb..e984461c37d9 100644
> > > --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > > +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > > @@ -288,6 +288,9 @@
> > > regulator-min-microvolt = <180>;
> > > regulator-max-microvolt = <180>;
> > > regulator-always-on;
> > > + regulator-state-mem {
> > > + regulator-off-in-suspend;
> > > + };
> >
> > I see my comment from previous patch was not addressed.
>
> I left this unchanged since this regulator is not active linked and used.
> Ok I will change this to regulator-on-in-suspend,
Why?
Previous patch was setting this to "on". I said that this is noop and
if you want to add it, I need explanation why this regulator has to
stay on during suspend.
So you changed to "off"... which is still noop... and you did not
provide explanation. Now you replied that you will change to "on"...
so this will be circle. Still without explanation.
>
> From documentation device tree binding regulator.txt
> "- regulator-always-on: boolean, regulator should never be disabled"
>
> But some regulator switches to a low power mode under light current loads
> and the device automatically switches back to a fast response mode as the
> output load increases.
>
> >
> > > };
> > >
> > > ldo3_reg: LDO3 {
> > > @@ -295,6 +298,9 @@
> > > regulator-min-microvolt = <180>;
> > > regulator-max-microvolt = <180>;
> > > regulator-always-on;
> > > + regulator-state-mem {
> > > + regulator-off-in-suspend;
> > > + };
> >
> > The same...
>
> Ok I will change this to regulator-on-in-suspend,
The same - why changing this to on or off? I need explanation why this
should be in first place.
> >
> > > };
> > >
> > > ldo4_reg: LDO4 {
> > > @@ -302,6 +308,9 @@
> > > regulator-min-microvolt = <280>;
> > > regulator-max-microvolt = <280>;
> > > regulator-boot-on;
> > > + regulator-state-mem {
> > > + regulator-on-in-suspend;
> > > + };
> > > };
> > >
> > > ldo5_reg: LDO5 {
> > > @@ -310,6 +319,9 @@
> > > regulator-max-microvolt = <180>;
> > > regulator-always-on;
> > > regulator-boot-on;
> > > + regulator-state-mem {
> > > + regulator-off-in-suspend;
> > > + };
> > > };
> > >
> > > ldo6_reg: LDO6 {
> > > @@ -317,6 +329,9 @@
> > > regulator-min-microvolt = <100>;
> > > regulator-max-microvolt = <100>;
> > > regulator-always-on;
> > > +
Re: [RFC 1/2] ARM: dts: exynos: Add proper regulator states for suspend-to-mem for odroid-u3
hi Krzysztof,
Thanks fro your review comments.
On Thu, 14 Feb 2019 at 18:11, Krzysztof Kozlowski wrote:
>
> Hi Anand,
>
> Thanks for the patch. See comments below.
>
> On Wed, 13 Feb 2019 at 22:41, Anand Moon wrote:
> >
> > Add suspend-to-mem node to regulator core to be enabled or disabled
> > during system suspend and also support changing the regulator operating
> > mode during runtime and when the system enter sleep mode.
> >
> > Cc: Marek Szyprowski
> > Cc: Krzysztof Kozlowski
> > Cc: Chanwoo Choi
> > Signed-off-by: Anand Moon
> > ---
> >
> > Changes from previos patch
> > [0] https://patchwork.kernel.org/patch/10712549/
> >
> > Set all the WAKEUP source regulator in suspend-on state.
> > LD04, LD012, LD015, LD020, LD022
> > Set all the non used regulator in suspend-odd state
> > LD02, LD03, LD05, LD06, LD07, LD011, LD013, LDO14, LD016
> >
> > BUCK5, BUCK6, BUCK7 and not confirable as per driver max77686-regulator
> >
> > Tested on microSD card and it resumes correcly after suspend.
> > eMMC is not able to resume after entering into suspend state,
> > which need to be investigated and how to debug more.
> > ---
> > .../boot/dts/exynos4412-odroid-common.dtsi| 63 +++
> > arch/arm/boot/dts/exynos4412-odroidu3.dts | 3 +
> > 2 files changed, 66 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > index 08d3a0a7b4eb..e984461c37d9 100644
> > --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> > @@ -288,6 +288,9 @@
> > regulator-min-microvolt = <180>;
> > regulator-max-microvolt = <180>;
> > regulator-always-on;
> > + regulator-state-mem {
> > + regulator-off-in-suspend;
> > + };
>
> I see my comment from previous patch was not addressed.
I left this unchanged since this regulator is not active linked and used.
Ok I will change this to regulator-on-in-suspend,
>From documentation device tree binding regulator.txt
"- regulator-always-on: boolean, regulator should never be disabled"
But some regulator switches to a low power mode under light current loads
and the device automatically switches back to a fast response mode as the
output load increases.
>
> > };
> >
> > ldo3_reg: LDO3 {
> > @@ -295,6 +298,9 @@
> > regulator-min-microvolt = <180>;
> > regulator-max-microvolt = <180>;
> > regulator-always-on;
> > + regulator-state-mem {
> > + regulator-off-in-suspend;
> > + };
>
> The same...
Ok I will change this to regulator-on-in-suspend,
>
> > };
> >
> > ldo4_reg: LDO4 {
> > @@ -302,6 +308,9 @@
> > regulator-min-microvolt = <280>;
> > regulator-max-microvolt = <280>;
> > regulator-boot-on;
> > + regulator-state-mem {
> > + regulator-on-in-suspend;
> > + };
> > };
> >
> > ldo5_reg: LDO5 {
> > @@ -310,6 +319,9 @@
> > regulator-max-microvolt = <180>;
> > regulator-always-on;
> > regulator-boot-on;
> > + regulator-state-mem {
> > + regulator-off-in-suspend;
> > + };
> > };
> >
> > ldo6_reg: LDO6 {
> > @@ -317,6 +329,9 @@
> > regulator-min-microvolt = <100>;
> > regulator-max-microvolt = <100>;
> > regulator-always-on;
> > + regulator-state-mem {
> > + regulator-off-in-suspend;
> > + };
> > };
> >
> > ldo7_reg: LDO7 {
> > @@ -324,18 +339,27 @@
> > regulator-min-microvolt = <100>;
> > regulator-max-microvolt = <100>;
> > regulator-always-on;
> > + regulator-state-mem {
> > + regulator-off-in-suspend;
> > + };
> > };
> >
> > ldo8_reg: LDO8 {
> >
Re: [RFC 1/2] ARM: dts: exynos: Add proper regulator states for suspend-to-mem for odroid-u3
Hi Anand,
Thanks for the patch. See comments below.
On Wed, 13 Feb 2019 at 22:41, Anand Moon wrote:
>
> Add suspend-to-mem node to regulator core to be enabled or disabled
> during system suspend and also support changing the regulator operating
> mode during runtime and when the system enter sleep mode.
>
> Cc: Marek Szyprowski
> Cc: Krzysztof Kozlowski
> Cc: Chanwoo Choi
> Signed-off-by: Anand Moon
> ---
>
> Changes from previos patch
> [0] https://patchwork.kernel.org/patch/10712549/
>
> Set all the WAKEUP source regulator in suspend-on state.
> LD04, LD012, LD015, LD020, LD022
> Set all the non used regulator in suspend-odd state
> LD02, LD03, LD05, LD06, LD07, LD011, LD013, LDO14, LD016
>
> BUCK5, BUCK6, BUCK7 and not confirable as per driver max77686-regulator
>
> Tested on microSD card and it resumes correcly after suspend.
> eMMC is not able to resume after entering into suspend state,
> which need to be investigated and how to debug more.
> ---
> .../boot/dts/exynos4412-odroid-common.dtsi| 63 +++
> arch/arm/boot/dts/exynos4412-odroidu3.dts | 3 +
> 2 files changed, 66 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index 08d3a0a7b4eb..e984461c37d9 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -288,6 +288,9 @@
> regulator-min-microvolt = <180>;
> regulator-max-microvolt = <180>;
> regulator-always-on;
> + regulator-state-mem {
> + regulator-off-in-suspend;
> + };
I see my comment from previous patch was not addressed.
> };
>
> ldo3_reg: LDO3 {
> @@ -295,6 +298,9 @@
> regulator-min-microvolt = <180>;
> regulator-max-microvolt = <180>;
> regulator-always-on;
> + regulator-state-mem {
> + regulator-off-in-suspend;
> + };
The same...
> };
>
> ldo4_reg: LDO4 {
> @@ -302,6 +308,9 @@
> regulator-min-microvolt = <280>;
> regulator-max-microvolt = <280>;
> regulator-boot-on;
> + regulator-state-mem {
> + regulator-on-in-suspend;
> + };
> };
>
> ldo5_reg: LDO5 {
> @@ -310,6 +319,9 @@
> regulator-max-microvolt = <180>;
> regulator-always-on;
> regulator-boot-on;
> + regulator-state-mem {
> + regulator-off-in-suspend;
> + };
> };
>
> ldo6_reg: LDO6 {
> @@ -317,6 +329,9 @@
> regulator-min-microvolt = <100>;
> regulator-max-microvolt = <100>;
> regulator-always-on;
> + regulator-state-mem {
> + regulator-off-in-suspend;
> + };
> };
>
> ldo7_reg: LDO7 {
> @@ -324,18 +339,27 @@
> regulator-min-microvolt = <100>;
> regulator-max-microvolt = <100>;
> regulator-always-on;
> + regulator-state-mem {
> + regulator-off-in-suspend;
> + };
> };
>
> ldo8_reg: LDO8 {
> regulator-name = "VDD10_HDMI_1.0V";
> regulator-min-microvolt = <100>;
> regulator-max-microvolt = <100>;
> + regulator-state-mem {
> + regulator-on-in-suspend;
> + };
> };
>
> ldo10_reg: LDO10 {
> regulator-name = "VDDQ_MIPIHSI_1.8V";
> regulator-min-microvolt = <180>;
> regulator-max-microvolt = <180>;
> + regulator-state-mem {
> + regulator-on-in-suspend;
> +
[RFC 1/2] ARM: dts: exynos: Add proper regulator states for suspend-to-mem for odroid-u3
Add suspend-to-mem node to regulator core to be enabled or disabled
during system suspend and also support changing the regulator operating
mode during runtime and when the system enter sleep mode.
Cc: Marek Szyprowski
Cc: Krzysztof Kozlowski
Cc: Chanwoo Choi
Signed-off-by: Anand Moon
---
Changes from previos patch
[0] https://patchwork.kernel.org/patch/10712549/
Set all the WAKEUP source regulator in suspend-on state.
LD04, LD012, LD015, LD020, LD022
Set all the non used regulator in suspend-odd state
LD02, LD03, LD05, LD06, LD07, LD011, LD013, LDO14, LD016
BUCK5, BUCK6, BUCK7 and not confirable as per driver max77686-regulator
Tested on microSD card and it resumes correcly after suspend.
eMMC is not able to resume after entering into suspend state,
which need to be investigated and how to debug more.
---
.../boot/dts/exynos4412-odroid-common.dtsi| 63 +++
arch/arm/boot/dts/exynos4412-odroidu3.dts | 3 +
2 files changed, 66 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index 08d3a0a7b4eb..e984461c37d9 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -288,6 +288,9 @@
regulator-min-microvolt = <180>;
regulator-max-microvolt = <180>;
regulator-always-on;
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
};
ldo3_reg: LDO3 {
@@ -295,6 +298,9 @@
regulator-min-microvolt = <180>;
regulator-max-microvolt = <180>;
regulator-always-on;
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
};
ldo4_reg: LDO4 {
@@ -302,6 +308,9 @@
regulator-min-microvolt = <280>;
regulator-max-microvolt = <280>;
regulator-boot-on;
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ };
};
ldo5_reg: LDO5 {
@@ -310,6 +319,9 @@
regulator-max-microvolt = <180>;
regulator-always-on;
regulator-boot-on;
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
};
ldo6_reg: LDO6 {
@@ -317,6 +329,9 @@
regulator-min-microvolt = <100>;
regulator-max-microvolt = <100>;
regulator-always-on;
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
};
ldo7_reg: LDO7 {
@@ -324,18 +339,27 @@
regulator-min-microvolt = <100>;
regulator-max-microvolt = <100>;
regulator-always-on;
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
};
ldo8_reg: LDO8 {
regulator-name = "VDD10_HDMI_1.0V";
regulator-min-microvolt = <100>;
regulator-max-microvolt = <100>;
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ };
};
ldo10_reg: LDO10 {
regulator-name = "VDDQ_MIPIHSI_1.8V";
regulator-min-microvolt = <180>;
regulator-max-microvolt = <180>;
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ };
};
ldo11_reg: LDO11 {
@@ -343,6 +367,9 @@
regulator-min-microvolt = <180>;
regulator-max-microvolt = <180>;
regulator-always-on;
+ regulator-state-mem {
+
