Re: [alsa-devel] [RFC PATCH] ASoC: wm8960: Use physical width for bclk

2017-03-15 Thread Daniel Baluta
On Wed, Mar 15, 2017 at 3:33 PM, Mark Brown wrote: > On Wed, Mar 15, 2017 at 09:19:01AM +, Charles Keepax wrote: >> On Tue, Mar 14, 2017 at 06:57:02PM +0200, Daniel Baluta wrote: > >> > - wm8960->bclk = snd_soc_params_to_bclk(params); >> > + wm8960->bclk = params_physical_width(params) * >

Re: [RFC PATCH] ASoC: wm8960: Use physical width for bclk

2017-03-15 Thread Mark Brown
On Wed, Mar 15, 2017 at 09:19:01AM +, Charles Keepax wrote: > On Tue, Mar 14, 2017 at 06:57:02PM +0200, Daniel Baluta wrote: > > - wm8960->bclk = snd_soc_params_to_bclk(params); > > + wm8960->bclk = params_physical_width(params) * > > + params_channels(params) * params_rate(param

Re: [RFC PATCH] ASoC: wm8960: Use physical width for bclk

2017-03-15 Thread Daniel Baluta
On Mi, 2017-03-15 at 09:19 +, Charles Keepax wrote: > On Tue, Mar 14, 2017 at 06:57:02PM +0200, Daniel Baluta wrote: > > > > bclk is derived from sysclk with the help of bclk_divs. Anyhow, for > > S20_3LE format there is no bclk_divs that could be used to derive > > an exact bclk. > > > > We

Re: [RFC PATCH] ASoC: wm8960: Use physical width for bclk

2017-03-15 Thread Charles Keepax
On Tue, Mar 14, 2017 at 06:57:02PM +0200, Daniel Baluta wrote: > bclk is derived from sysclk with the help of bclk_divs. Anyhow, for > S20_3LE format there is no bclk_divs that could be used to derive > an exact bclk. > > We can fix this by using storage size instead the exact > number of bits of

[RFC PATCH] ASoC: wm8960: Use physical width for bclk

2017-03-14 Thread Daniel Baluta
bclk is derived from sysclk with the help of bclk_divs. Anyhow, for S20_3LE format there is no bclk_divs that could be used to derive an exact bclk. We can fix this by using storage size instead the exact number of bits of the sample when computing bclk. With this approach we can play S20_3LE enc