Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-19 Thread Mel Gorman
On Tue, Nov 18, 2014 at 12:18:43PM -0500, Sasha Levin wrote: > On 11/18/2014 11:56 AM, Aneesh Kumar K.V wrote: > >>> 4. Similarly, does the kernel boot properly without without patches? > >> > > >> > Yes, the kernel works fine without the patches both with and without fake > >> > numa. > > > >

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-19 Thread Mel Gorman
On Tue, Nov 18, 2014 at 12:18:43PM -0500, Sasha Levin wrote: On 11/18/2014 11:56 AM, Aneesh Kumar K.V wrote: 4. Similarly, does the kernel boot properly without without patches? Yes, the kernel works fine without the patches both with and without fake numa. Hmm that is

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-18 Thread Sasha Levin
On 11/18/2014 11:56 AM, Aneesh Kumar K.V wrote: >>> 4. Similarly, does the kernel boot properly without without patches? >> > >> > Yes, the kernel works fine without the patches both with and without fake >> > numa. > > Hmm that is interesting. I am not sure how writeback_fid can be > related. We

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-18 Thread Mel Gorman
On Tue, Nov 18, 2014 at 10:26:41PM +0530, Aneesh Kumar K.V wrote: > Sasha Levin writes: > > > On 11/18/2014 10:42 AM, Mel Gorman wrote: > >> 1. I'm assuming this is a KVM setup but can you confirm? > > > > Yes. > > > >> 2. Are you using numa=fake=N? > > > > Yes. numa=fake=24, which is probably

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-18 Thread Mel Gorman
On Tue, Nov 18, 2014 at 10:03:30PM +0530, Aneesh Kumar K.V wrote: > > diff --git a/arch/powerpc/mm/copro_fault.c b/arch/powerpc/mm/copro_fault.c > > index 5a236f0..46152aa 100644 > > --- a/arch/powerpc/mm/copro_fault.c > > +++ b/arch/powerpc/mm/copro_fault.c > > @@ -64,7 +64,12 @@ int

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-18 Thread Aneesh Kumar K.V
Sasha Levin writes: > On 11/18/2014 10:42 AM, Mel Gorman wrote: >> 1. I'm assuming this is a KVM setup but can you confirm? > > Yes. > >> 2. Are you using numa=fake=N? > > Yes. numa=fake=24, which is probably way more nodes on any physical machine > than the new code was tested on? > >> 3. If

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-18 Thread Sasha Levin
On 11/18/2014 10:42 AM, Mel Gorman wrote: > 1. I'm assuming this is a KVM setup but can you confirm? Yes. > 2. Are you using numa=fake=N? Yes. numa=fake=24, which is probably way more nodes on any physical machine than the new code was tested on? > 3. If you are using fake NUMA, what happens

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-18 Thread Aneesh Kumar K.V
Mel Gorman writes: > On Mon, Nov 17, 2014 at 01:56:19PM +0530, Aneesh Kumar K.V wrote: >> Mel Gorman writes: >> >> > This is follow up from the "pipe/page fault oddness" thread. >> > >> > Automatic NUMA balancing depends on being able to protect PTEs to trap a >> > fault and gather reference

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-18 Thread Mel Gorman
On Mon, Nov 17, 2014 at 01:56:19PM +0530, Aneesh Kumar K.V wrote: > Mel Gorman writes: > > > This is follow up from the "pipe/page fault oddness" thread. > > > > Automatic NUMA balancing depends on being able to protect PTEs to trap a > > fault and gather reference locality information. Very

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-18 Thread Mel Gorman
On Fri, Nov 14, 2014 at 10:29:41PM -0500, Sasha Levin wrote: > On 11/14/2014 08:32 AM, Mel Gorman wrote:> This is follow up from the > "pipe/page fault oddness" thread. > > Hi Mel, > > Applying this patch series I've started seeing the following straight away: > > [ 367.547848]

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-18 Thread Mel Gorman
On Fri, Nov 14, 2014 at 10:29:41PM -0500, Sasha Levin wrote: On 11/14/2014 08:32 AM, Mel Gorman wrote: This is follow up from the pipe/page fault oddness thread. Hi Mel, Applying this patch series I've started seeing the following straight away: [ 367.547848] page:ea0003fb7db0

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-18 Thread Mel Gorman
On Mon, Nov 17, 2014 at 01:56:19PM +0530, Aneesh Kumar K.V wrote: Mel Gorman mgor...@suse.de writes: This is follow up from the pipe/page fault oddness thread. Automatic NUMA balancing depends on being able to protect PTEs to trap a fault and gather reference locality information. Very

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-18 Thread Aneesh Kumar K.V
Mel Gorman mgor...@suse.de writes: On Mon, Nov 17, 2014 at 01:56:19PM +0530, Aneesh Kumar K.V wrote: Mel Gorman mgor...@suse.de writes: This is follow up from the pipe/page fault oddness thread. Automatic NUMA balancing depends on being able to protect PTEs to trap a fault and gather

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-18 Thread Sasha Levin
On 11/18/2014 10:42 AM, Mel Gorman wrote: 1. I'm assuming this is a KVM setup but can you confirm? Yes. 2. Are you using numa=fake=N? Yes. numa=fake=24, which is probably way more nodes on any physical machine than the new code was tested on? 3. If you are using fake NUMA, what happens if

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-18 Thread Aneesh Kumar K.V
Sasha Levin sasha.le...@oracle.com writes: On 11/18/2014 10:42 AM, Mel Gorman wrote: 1. I'm assuming this is a KVM setup but can you confirm? Yes. 2. Are you using numa=fake=N? Yes. numa=fake=24, which is probably way more nodes on any physical machine than the new code was tested on?

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-18 Thread Mel Gorman
On Tue, Nov 18, 2014 at 10:03:30PM +0530, Aneesh Kumar K.V wrote: diff --git a/arch/powerpc/mm/copro_fault.c b/arch/powerpc/mm/copro_fault.c index 5a236f0..46152aa 100644 --- a/arch/powerpc/mm/copro_fault.c +++ b/arch/powerpc/mm/copro_fault.c @@ -64,7 +64,12 @@ int

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-18 Thread Mel Gorman
On Tue, Nov 18, 2014 at 10:26:41PM +0530, Aneesh Kumar K.V wrote: Sasha Levin sasha.le...@oracle.com writes: On 11/18/2014 10:42 AM, Mel Gorman wrote: 1. I'm assuming this is a KVM setup but can you confirm? Yes. 2. Are you using numa=fake=N? Yes. numa=fake=24, which is probably

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-18 Thread Sasha Levin
On 11/18/2014 11:56 AM, Aneesh Kumar K.V wrote: 4. Similarly, does the kernel boot properly without without patches? Yes, the kernel works fine without the patches both with and without fake numa. Hmm that is interesting. I am not sure how writeback_fid can be related. We use writeback

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-17 Thread Aneesh Kumar K.V
Mel Gorman writes: > This is follow up from the "pipe/page fault oddness" thread. > > Automatic NUMA balancing depends on being able to protect PTEs to trap a > fault and gather reference locality information. Very broadly speaking it > would mark PTEs as not present and use another bit to

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-17 Thread Aneesh Kumar K.V
Mel Gorman mgor...@suse.de writes: This is follow up from the pipe/page fault oddness thread. Automatic NUMA balancing depends on being able to protect PTEs to trap a fault and gather reference locality information. Very broadly speaking it would mark PTEs as not present and use another bit

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-14 Thread Sasha Levin
On 11/14/2014 08:32 AM, Mel Gorman wrote:> This is follow up from the "pipe/page fault oddness" thread. Hi Mel, Applying this patch series I've started seeing the following straight away: [ 367.547848] page:ea0003fb7db0 count:1007 mapcount:1005 mapping:8800691f2f58 index:0x37 [

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-14 Thread Linus Torvalds
On Fri, Nov 14, 2014 at 5:32 AM, Mel Gorman wrote: > > This series is very heavily based on patches from Linus and Aneesh to > replace the existing PTE/PMD NUMA helper functions with normal change > protections. I did alter and add parts of it but I consider them relatively > minor contributions.

[RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-14 Thread Mel Gorman
This is follow up from the "pipe/page fault oddness" thread. Automatic NUMA balancing depends on being able to protect PTEs to trap a fault and gather reference locality information. Very broadly speaking it would mark PTEs as not present and use another bit to distinguish between NUMA hinting

[RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-14 Thread Mel Gorman
This is follow up from the pipe/page fault oddness thread. Automatic NUMA balancing depends on being able to protect PTEs to trap a fault and gather reference locality information. Very broadly speaking it would mark PTEs as not present and use another bit to distinguish between NUMA hinting

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-14 Thread Linus Torvalds
On Fri, Nov 14, 2014 at 5:32 AM, Mel Gorman mgor...@suse.de wrote: This series is very heavily based on patches from Linus and Aneesh to replace the existing PTE/PMD NUMA helper functions with normal change protections. I did alter and add parts of it but I consider them relatively minor

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-14 Thread Sasha Levin
On 11/14/2014 08:32 AM, Mel Gorman wrote: This is follow up from the pipe/page fault oddness thread. Hi Mel, Applying this patch series I've started seeing the following straight away: [ 367.547848] page:ea0003fb7db0 count:1007 mapcount:1005 mapping:8800691f2f58 index:0x37 [