Re: [RFCv1 1/5] arm64: dts: meson: Add missing 5V_EN gpio signal for VCC5V regulator

[Anand Moon]

Hi Neil,

On Mon, 7 Oct 2019 at 19:49, Neil Armstrong  wrote:
>
> Hi Anand,
>
> On 07/10/2019 15:16, Anand Moon wrote:
> > As per schematics add missing 5V_EN gpio signal to enable
> > VCC5V regulator node.
> >
> > Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2)
> > Cc: Martin Blumenstingl 
> > Cc: Jerome Brunet 
> > Cc: Neil Armstrong 
> > Signed-off-by: Anand Moon 
> > ---
> >  arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts 
> > b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> > index 42f15405750c..a9a661258886 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> > @@ -94,6 +94,9 @@
> >   regulator-max-microvolt = <500>;
> >   regulator-always-on;
> >   vin-supply = <_12v>;
> > + /* U12 NB679GD 5V_EN */
> > + gpio = < GPIOH_8 GPIO_OPEN_DRAIN>;
> > + enable-active-high;
>
> This GPIO is handled by the BL301 SCP firmware, I'm personally against
> adding this to the DT since it's out of control of Linux or any OS.
>
> Neil
>

Thanks for your input.

> >   };
> >
> >   vcc_1v8: regulator-vcc_1v8 {
> >
>

Best Regards
-Anand

Re: [RFCv1 1/5] arm64: dts: meson: Add missing 5V_EN gpio signal for VCC5V regulator

[Neil Armstrong]

Hi Anand,

On 07/10/2019 15:16, Anand Moon wrote:
> As per schematics add missing 5V_EN gpio signal to enable
> VCC5V regulator node.
> 
> Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2)
> Cc: Martin Blumenstingl 
> Cc: Jerome Brunet 
> Cc: Neil Armstrong 
> Signed-off-by: Anand Moon 
> ---
>  arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts 
> b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> index 42f15405750c..a9a661258886 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> @@ -94,6 +94,9 @@
>   regulator-max-microvolt = <500>;
>   regulator-always-on;
>   vin-supply = <_12v>;
> + /* U12 NB679GD 5V_EN */
> + gpio = < GPIOH_8 GPIO_OPEN_DRAIN>;
> + enable-active-high;

This GPIO is handled by the BL301 SCP firmware, I'm personally against
adding this to the DT since it's out of control of Linux or any OS.

Neil

>   };
>  
>   vcc_1v8: regulator-vcc_1v8 {
> 

[RFCv1 1/5] arm64: dts: meson: Add missing 5V_EN gpio signal for VCC5V regulator

[Anand Moon]

As per schematics add missing 5V_EN gpio signal to enable
VCC5V regulator node.

Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2)
Cc: Martin Blumenstingl 
Cc: Jerome Brunet 
Cc: Neil Armstrong 
Signed-off-by: Anand Moon 
---
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts 
b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
index 42f15405750c..a9a661258886 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
@@ -94,6 +94,9 @@
regulator-max-microvolt = <500>;
regulator-always-on;
vin-supply = <_12v>;
+   /* U12 NB679GD 5V_EN */
+   gpio = < GPIOH_8 GPIO_OPEN_DRAIN>;
+   enable-active-high;
};
 
vcc_1v8: regulator-vcc_1v8 {
-- 
2.23.0