Re: [RFCv1 2/5] arm64: dts: meson: Add missing pwm control gpio signal for pwm-regulator
Hi Neil,
On Mon, 7 Oct 2019 at 19:50, Neil Armstrong wrote:
>
> On 07/10/2019 15:16, Anand Moon wrote:
> > As per schematics add missing VDDCPUA_PWM and VDDCPUB_PWM
> > gpio signal use to enable/disable the pwm regulator for DVFS.
> >
> > Fixes: d14734a04a8a (arm64: dts: meson-g12b-odroid-n2: enable DVFS)
> > Cc: Martin Blumenstingl
> > Cc: Jerome Brunet
> > Cc: Neil Armstrong
> > Signed-off-by: Anand Moon
> > ---
> > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 4
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> > b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> > index a9a661258886..66262a6ab3fe 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> > @@ -135,6 +135,8 @@
> >
> > regulator-boot-on;
> > regulator-always-on;
> > + /* VDDCPUA_PWM */
> > + enable-gpios = < GPIOE_1 GPIO_ACTIVE_HIGH>;
> > };
> >
> > vddcpu_b: regulator-vddcpu-b {
> > @@ -154,6 +156,8 @@
> >
> > regulator-boot-on;
> > regulator-always-on;
> > + /* VDDCPUB_PWM */
> > + enable-gpios = < GPIOE_2 GPIO_ACTIVE_HIGH>;
> > };
> >
> > hub_5v: regulator-hub_5v {
> >
>
> Same as 5V_EN, This GPIO is handled by the BL301 SCP firmware, I'm personally
> against
> adding this to the DT since it's out of control of Linux or any OS.
>
> This GPIO id controlles by the PSCI call to SCP to enable/disable
> the CPU clusters.
>
> Neil
Thanks for your input's.
Best Regards
-Anand
Re: [RFCv1 2/5] arm64: dts: meson: Add missing pwm control gpio signal for pwm-regulator
On 07/10/2019 15:16, Anand Moon wrote:
> As per schematics add missing VDDCPUA_PWM and VDDCPUB_PWM
> gpio signal use to enable/disable the pwm regulator for DVFS.
>
> Fixes: d14734a04a8a (arm64: dts: meson-g12b-odroid-n2: enable DVFS)
> Cc: Martin Blumenstingl
> Cc: Jerome Brunet
> Cc: Neil Armstrong
> Signed-off-by: Anand Moon
> ---
> arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> index a9a661258886..66262a6ab3fe 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> @@ -135,6 +135,8 @@
>
> regulator-boot-on;
> regulator-always-on;
> + /* VDDCPUA_PWM */
> + enable-gpios = < GPIOE_1 GPIO_ACTIVE_HIGH>;
> };
>
> vddcpu_b: regulator-vddcpu-b {
> @@ -154,6 +156,8 @@
>
> regulator-boot-on;
> regulator-always-on;
> + /* VDDCPUB_PWM */
> + enable-gpios = < GPIOE_2 GPIO_ACTIVE_HIGH>;
> };
>
> hub_5v: regulator-hub_5v {
>
Same as 5V_EN, This GPIO is handled by the BL301 SCP firmware, I'm personally
against
adding this to the DT since it's out of control of Linux or any OS.
This GPIO id controlles by the PSCI call to SCP to enable/disable
the CPU clusters.
Neil
[RFCv1 2/5] arm64: dts: meson: Add missing pwm control gpio signal for pwm-regulator
As per schematics add missing VDDCPUA_PWM and VDDCPUB_PWM
gpio signal use to enable/disable the pwm regulator for DVFS.
Fixes: d14734a04a8a (arm64: dts: meson-g12b-odroid-n2: enable DVFS)
Cc: Martin Blumenstingl
Cc: Jerome Brunet
Cc: Neil Armstrong
Signed-off-by: Anand Moon
---
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
index a9a661258886..66262a6ab3fe 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
@@ -135,6 +135,8 @@
regulator-boot-on;
regulator-always-on;
+ /* VDDCPUA_PWM */
+ enable-gpios = < GPIOE_1 GPIO_ACTIVE_HIGH>;
};
vddcpu_b: regulator-vddcpu-b {
@@ -154,6 +156,8 @@
regulator-boot-on;
regulator-always-on;
+ /* VDDCPUB_PWM */
+ enable-gpios = < GPIOE_2 GPIO_ACTIVE_HIGH>;
};
hub_5v: regulator-hub_5v {
--
2.23.0
