Re: [RFCv1 4/5] arm64: dts: meson: Add missing regulator linked to VCCV5 regulator to VDDIO_C/TF_IO

2019-10-07 Thread Anand Moon 
Hi Neil,

On Mon, 7 Oct 2019 at 19:51, Neil Armstrong  wrote:
>
> On 07/10/2019 15:16, Anand Moon wrote:
> > As per schematics add missing VCCV5 power supply to VDDIO_C/TF_IO
> > regulator. Also add TF_3V3N_1V8_EN signal name to gpio pin.
> >
> > Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2)
> > Cc: Martin Blumenstingl 
> > Cc: Jerome Brunet 
> > Cc: Neil Armstrong 
> > Signed-off-by: Anand Moon 
> > ---
> >  arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts 
> > b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> > index 6bd23a1e7e1d..5daf176452f7 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> > @@ -66,11 +66,14 @@
> >   regulator-min-microvolt = <180>;
> >   regulator-max-microvolt = <330>;
> >
> > + /* TF_3V3N_1V8_EN */
> >   gpios = <_ao GPIOAO_9 GPIO_ACTIVE_HIGH>;
> >   gpios-states = <0>;
> >
> >   states = <330 0>,
> ><180 1>;
> > + /* U16 RT9179GB */
> > + vin-supply = <_5v>;
> >   };
> >
> >   flash_1v8: regulator-flash_1v8 {
> >
>
> Reviewed-by: Neil Armstrong 

Thanks,

Best Regards
-Anand

Re: [RFCv1 4/5] arm64: dts: meson: Add missing regulator linked to VCCV5 regulator to VDDIO_C/TF_IO

2019-10-07 Thread Neil Armstrong 
On 07/10/2019 15:16, Anand Moon wrote:
> As per schematics add missing VCCV5 power supply to VDDIO_C/TF_IO
> regulator. Also add TF_3V3N_1V8_EN signal name to gpio pin.
> 
> Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2)
> Cc: Martin Blumenstingl 
> Cc: Jerome Brunet 
> Cc: Neil Armstrong 
> Signed-off-by: Anand Moon 
> ---
>  arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts 
> b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> index 6bd23a1e7e1d..5daf176452f7 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> @@ -66,11 +66,14 @@
>   regulator-min-microvolt = <180>;
>   regulator-max-microvolt = <330>;
>  
> + /* TF_3V3N_1V8_EN */
>   gpios = <_ao GPIOAO_9 GPIO_ACTIVE_HIGH>;
>   gpios-states = <0>;
>  
>   states = <330 0>,
><180 1>;
> + /* U16 RT9179GB */
> + vin-supply = <_5v>;
>   };
>  
>   flash_1v8: regulator-flash_1v8 {
> 

Reviewed-by: Neil Armstrong

[RFCv1 4/5] arm64: dts: meson: Add missing regulator linked to VCCV5 regulator to VDDIO_C/TF_IO

2019-10-07 Thread Anand Moon 
As per schematics add missing VCCV5 power supply to VDDIO_C/TF_IO
regulator. Also add TF_3V3N_1V8_EN signal name to gpio pin.

Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2)
Cc: Martin Blumenstingl 
Cc: Jerome Brunet 
Cc: Neil Armstrong 
Signed-off-by: Anand Moon 
---
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts 
b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
index 6bd23a1e7e1d..5daf176452f7 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
@@ -66,11 +66,14 @@
regulator-min-microvolt = <180>;
regulator-max-microvolt = <330>;
 
+   /* TF_3V3N_1V8_EN */
gpios = <_ao GPIOAO_9 GPIO_ACTIVE_HIGH>;
gpios-states = <0>;
 
states = <330 0>,
 <180 1>;
+   /* U16 RT9179GB */
+   vin-supply = <_5v>;
};
 
flash_1v8: regulator-flash_1v8 {
-- 
2.23.0