On Fri, Sep 27 2013, Jens Axboe wrote:
> On 09/27/2013 05:26 AM, Akhil Bhansali wrote:
> > Hello Jens,
> >
> > There are few improvements suggested by community for driver:
> > 1. Replacement of custom macros for debug printing. (DPRINTK / VPRINTK).
> > 2. Reformatting of "skd_request_fn" which
On 09/27/2013 05:26 AM, Akhil Bhansali wrote:
> Hello Jens,
>
> There are few improvements suggested by community for driver:
> 1. Replacement of custom macros for debug printing. (DPRINTK / VPRINTK).
> 2. Reformatting of "skd_request_fn" which is too long.
>
> Kindly let us know if you see any
Phansalkar; Andrew Morton
Subject: Re: [block:for-next 5/6] drivers/block/skd_main.c:441:3: error:
implicit declaration of function 'readq'
On 09/23/2013 05:59 AM, Akhil Bhansali wrote:
> Hello Jens,
>
> I am sending a patch created on top of "Andrew's latest changes" to disa
; Andrew Morton
Subject: Re: [block:for-next 5/6] drivers/block/skd_main.c:441:3: error:
implicit declaration of function 'readq'
On 09/23/2013 05:59 AM, Akhil Bhansali wrote:
Hello Jens,
I am sending a patch created on top of Andrew's latest changes to disable
the 32 bit compilation of kronos
On 09/27/2013 05:26 AM, Akhil Bhansali wrote:
Hello Jens,
There are few improvements suggested by community for driver:
1. Replacement of custom macros for debug printing. (DPRINTK / VPRINTK).
2. Reformatting of skd_request_fn which is too long.
Kindly let us know if you see any other
On Fri, Sep 27 2013, Jens Axboe wrote:
On 09/27/2013 05:26 AM, Akhil Bhansali wrote:
Hello Jens,
There are few improvements suggested by community for driver:
1. Replacement of custom macros for debug printing. (DPRINTK / VPRINTK).
2. Reformatting of skd_request_fn which is too long.
On 09/23/2013 05:59 AM, Akhil Bhansali wrote:
> Hello Jens,
>
> I am sending a patch created on top of "Andrew's latest changes" to disable
> the 32 bit compilation of kronos driver.
>
> The patch takes care of following.
> 1. checkpatch.pl was showing 3 errors for assignment in if condition, I
zeof(struct skd_special_context) * skdev->n_special);
--
1.7.9.5
From: Akhil Bhansali
Sent: Thursday, September 19, 2013 5:39 PM
To: Jens Axboe
Cc: kbuild test robot; OS Engineering; Ramprasad Chinthekindi;
jmo...@redhat.com; linux-kernel@vger.kernel.org; A
: [block:for-next 5/6] drivers/block/skd_main.c:441:3: error:
implicit declaration of function 'readq'
On Wed, Sep 18 2013, Akhil Bhansali wrote:
Hi Jens,
Please accept this patch that takes care of warnings related to i386
compilation.
1. Implicit function declaration of readq and writeq
On 09/23/2013 05:59 AM, Akhil Bhansali wrote:
Hello Jens,
I am sending a patch created on top of Andrew's latest changes to disable
the 32 bit compilation of kronos driver.
The patch takes care of following.
1. checkpatch.pl was showing 3 errors for assignment in if condition, I have
_
From: Jens Axboe [ax...@kernel.dk]
Sent: Wednesday, September 18, 2013 8:06 PM
To: Akhil Bhansali
Cc: kbuild test robot; OS Engineering; Ramprasad Chinthekindi;
jmo...@redhat.com; linux-kernel@vger.kernel.org; Amit Phansalkar
Subject: Re: [block:for-next 5/6] drivers/block
: Jens Axboe [ax...@kernel.dk]
Sent: Wednesday, September 18, 2013 8:06 PM
To: Akhil Bhansali
Cc: kbuild test robot; OS Engineering; Ramprasad Chinthekindi;
jmo...@redhat.com; linux-kernel@vger.kernel.org; Amit Phansalkar
Subject: Re: [block:for-next 5/6] drivers/block/skd_main.c:441:3: error
On Wed, Sep 18, 2013 at 3:05 AM, Akhil Bhansali
wrote:
> Hi Jens,
>
> Please accept this patch that takes care of warnings related to i386
> compilation.
> 1. Implicit function declaration of readq and writeq.
> 2. Format related warnings for VPRINTK.
>
> From
On Wed, Sep 18 2013, Akhil Bhansali wrote:
> Hi Jens,
>
> Please accept this patch that takes care of warnings related to i386
> compilation.
> 1. Implicit function declaration of readq and writeq.
> 2. Format related warnings for VPRINTK.
You should get rid of the VPRINTK() as well, we do have
:55 PM
To: Akhil Bhansali
Cc: kbuild test robot; OS Engineering; Ramprasad Chinthekindi;
jmo...@redhat.com; linux-kernel@vger.kernel.org
Subject: Re: [block:for-next 5/6] drivers/block/skd_main.c:441:3: error:
implicit declaration of function 'readq'
On 09/13/2013 06:59 AM, Akhil Bhansali wrote
To: Akhil Bhansali
Cc: kbuild test robot; OS Engineering; Ramprasad Chinthekindi;
jmo...@redhat.com; linux-kernel@vger.kernel.org
Subject: Re: [block:for-next 5/6] drivers/block/skd_main.c:441:3: error:
implicit declaration of function 'readq'
On 09/13/2013 06:59 AM, Akhil Bhansali wrote
On Wed, Sep 18 2013, Akhil Bhansali wrote:
Hi Jens,
Please accept this patch that takes care of warnings related to i386
compilation.
1. Implicit function declaration of readq and writeq.
2. Format related warnings for VPRINTK.
You should get rid of the VPRINTK() as well, we do have debug
On Wed, Sep 18, 2013 at 3:05 AM, Akhil Bhansali
akhilashok.bhans...@hgst.com wrote:
Hi Jens,
Please accept this patch that takes care of warnings related to i386
compilation.
1. Implicit function declaration of readq and writeq.
2. Format related warnings for VPRINTK.
From
On 09/13/2013 06:59 AM, Akhil Bhansali wrote:
> This patch takes care of warnings related to
> 1. Implicit function declaration for readq / writeq.
> 2. Warnings related to -Wformat.
Please do it on top of what was already fixed up. The readq, for
instance, is not even used in the driver.
--
ptember 12, 2013 1:45 AM
To: Akhil Bhansali
Cc: Ramprasad Chinthekindi; Jens Axboe; kbuild-...@01.org
Subject: [block:for-next 5/6] drivers/block/skd_main.c:441:3: error: implicit
declaration of function 'readq'
tree: git://git.kernel.dk/linux-block.git for-next
head: b497e021a24be0eeb3c1a4ad9b2a
: Ramprasad Chinthekindi; Jens Axboe; kbuild-...@01.org
Subject: [block:for-next 5/6] drivers/block/skd_main.c:441:3: error: implicit
declaration of function 'readq'
tree: git://git.kernel.dk/linux-block.git for-next
head: b497e021a24be0eeb3c1a4ad9b2a04275ab5edc0
commit
On 09/13/2013 06:59 AM, Akhil Bhansali wrote:
This patch takes care of warnings related to
1. Implicit function declaration for readq / writeq.
2. Warnings related to -Wformat.
Please do it on top of what was already fixed up. The readq, for
instance, is not even used in the driver.
--
Jens
22 matches
Mail list logo
