Re: Do we need to disable preemption in flush_tlb_range()?

2018-03-16 Thread Alexey Brodkin
Hi Peter, On Fri, 2018-03-16 at 11:11 +0100, Peter Zijlstra wrote: > On Thu, Mar 15, 2018 at 09:39:31AM +, Alexey Brodkin wrote: > > Hi Peter, > > > > On Thu, 2018-03-15 at 09:27 +0100, Peter Zijlstra wrote: > > > On Wed, Mar 14, 2018 at 01:19:01PM -0700, Vineet Gupta wrote: > > > > +CC Peter

Re: Do we need to disable preemption in flush_tlb_range()?

2018-03-16 Thread Peter Zijlstra
On Thu, Mar 15, 2018 at 09:39:31AM +, Alexey Brodkin wrote: > Hi Peter, > > On Thu, 2018-03-15 at 09:27 +0100, Peter Zijlstra wrote: > > On Wed, Mar 14, 2018 at 01:19:01PM -0700, Vineet Gupta wrote: > > > +CC Peter since we have his attention ;-) > > > > Yeah, timezone collision there, I typi

Re: Do we need to disable preemption in flush_tlb_range()?

2018-03-15 Thread Vineet Gupta
+CC some more folks for intc/irq insights - please see question at the bottom ! On 03/15/2018 02:39 AM, Alexey Brodkin wrote: Hi Peter, On Thu, 2018-03-15 at 09:27 +0100, Peter Zijlstra wrote: On Wed, Mar 14, 2018 at 01:19:01PM -0700, Vineet Gupta wrote: +CC Peter since we have his attention

Re: Do we need to disable preemption in flush_tlb_range()?

2018-03-15 Thread Alexey Brodkin
Hi Peter, On Thu, 2018-03-15 at 09:27 +0100, Peter Zijlstra wrote: > On Wed, Mar 14, 2018 at 01:19:01PM -0700, Vineet Gupta wrote: > > +CC Peter since we have his attention ;-) > > Yeah, timezone collision there, I typically sleep at 1am ;-) > > > On 03/01/2018 07:13 AM, Alexey Brodkin wrote: >

Re: Do we need to disable preemption in flush_tlb_range()?

2018-03-15 Thread Peter Zijlstra
On Wed, Mar 14, 2018 at 01:19:01PM -0700, Vineet Gupta wrote: > +CC Peter since we have his attention ;-) Yeah, timezone collision there, I typically sleep at 1am ;-) > On 03/01/2018 07:13 AM, Alexey Brodkin wrote: > > Hi Vineet, > > > > Just noticed that in comments for smp_call_function_many()

Re: Do we need to disable preemption in flush_tlb_range()?

2018-03-14 Thread Vineet Gupta
+CC Peter since we have his attention ;-) On 03/01/2018 07:13 AM, Alexey Brodkin wrote: Hi Vineet, Just noticed that in comments for smp_call_function_many() it is said that preemption must be disabled during its execution. And that function gets executed among other ways like that: --

Re: Do we need to disable preemption in flush_tlb_range()?

2018-03-14 Thread Alexey Brodkin
Ping! On Thu, 2018-03-01 at 18:13 +0300, Alexey Brodkin wrote: > Hi Vineet, > > Just noticed that in comments for smp_call_function_many() it is said that > preemption must be disabled during its execution. And that function gets > executed > among other ways like that: > ---

Do we need to disable preemption in flush_tlb_range()?

2018-03-01 Thread Alexey Brodkin
Hi Vineet, Just noticed that in comments for smp_call_function_many() it is said that preemption must be disabled during its execution. And that function gets executed among other ways like that: -->8--- flush_tlb_range() -> on_each_cpu_mask()