Re: [PATCH 2/2] thp: support split page table lock

2013-09-09 Thread Alex Thorlton
On Mon, Sep 09, 2013 at 10:34:45AM +0800, Daniel J Blueman wrote: > On Saturday, 7 September 2013 02:10:02 UTC+8, Naoya Horiguchi wrote: > >Hi Alex, > > > >On Fri, Sep 06, 2013 at 11:04:23AM -0500, Alex Thorlton wrote: > >> On Thu, Sep 05, 2013 at 05:27:46PM -0400, Naoya Horiguchi wrote: > >> >

Re: [PATCH 2/2] thp: support split page table lock

2013-09-09 Thread Alex Thorlton
On Mon, Sep 09, 2013 at 10:34:45AM +0800, Daniel J Blueman wrote: On Saturday, 7 September 2013 02:10:02 UTC+8, Naoya Horiguchi wrote: Hi Alex, On Fri, Sep 06, 2013 at 11:04:23AM -0500, Alex Thorlton wrote: On Thu, Sep 05, 2013 at 05:27:46PM -0400, Naoya Horiguchi wrote: Thp related

Re: [PATCH 2/2] thp: support split page table lock

2013-09-08 Thread Daniel J Blueman
On Saturday, 7 September 2013 02:10:02 UTC+8, Naoya Horiguchi wrote: Hi Alex, On Fri, Sep 06, 2013 at 11:04:23AM -0500, Alex Thorlton wrote: > On Thu, Sep 05, 2013 at 05:27:46PM -0400, Naoya Horiguchi wrote: > > Thp related code also uses per process mm->page_table_lock now. > > So making it

RE: [PATCH 2/2] thp: support split page table lock

2013-09-08 Thread Aneesh Kumar K.V
"Kirill A. Shutemov" writes: > Naoya Horiguchi wrote: >> Thp related code also uses per process mm->page_table_lock now. >> So making it fine-grained can provide better performance. >> >> This patch makes thp support split page table lock by using page->ptl >> of the pages storing

RE: [PATCH 2/2] thp: support split page table lock

2013-09-08 Thread Aneesh Kumar K.V
Kirill A. Shutemov kirill.shute...@linux.intel.com writes: Naoya Horiguchi wrote: Thp related code also uses per process mm-page_table_lock now. So making it fine-grained can provide better performance. This patch makes thp support split page table lock by using page-ptl of the pages

Re: [PATCH 2/2] thp: support split page table lock

2013-09-08 Thread Daniel J Blueman
On Saturday, 7 September 2013 02:10:02 UTC+8, Naoya Horiguchi wrote: Hi Alex, On Fri, Sep 06, 2013 at 11:04:23AM -0500, Alex Thorlton wrote: On Thu, Sep 05, 2013 at 05:27:46PM -0400, Naoya Horiguchi wrote: Thp related code also uses per process mm-page_table_lock now. So making it

Re: [PATCH 2/2] thp: support split page table lock

2013-09-06 Thread Naoya Horiguchi
Hi Alex, On Fri, Sep 06, 2013 at 11:04:23AM -0500, Alex Thorlton wrote: > On Thu, Sep 05, 2013 at 05:27:46PM -0400, Naoya Horiguchi wrote: > > Thp related code also uses per process mm->page_table_lock now. > > So making it fine-grained can provide better performance. > > > > This patch makes

Re: [PATCH 2/2] thp: support split page table lock

2013-09-06 Thread Naoya Horiguchi
On Fri, Sep 06, 2013 at 07:46:25PM +0300, Kirill A. Shutemov wrote: > Naoya Horiguchi wrote: > > Hi Kirill, > > > > On Fri, Sep 06, 2013 at 01:48:03PM +0300, Kirill A. Shutemov wrote: > > > Naoya Horiguchi wrote: > > > > Thp related code also uses per process mm->page_table_lock now. > > > > So

Re: [PATCH 2/2] thp: support split page table lock

2013-09-06 Thread Kirill A. Shutemov
Naoya Horiguchi wrote: > Hi Kirill, > > On Fri, Sep 06, 2013 at 01:48:03PM +0300, Kirill A. Shutemov wrote: > > Naoya Horiguchi wrote: > > > Thp related code also uses per process mm->page_table_lock now. > > > So making it fine-grained can provide better performance. > > > > > > This patch

Re: [PATCH 2/2] thp: support split page table lock

2013-09-06 Thread Naoya Horiguchi
Hi Kirill, On Fri, Sep 06, 2013 at 01:48:03PM +0300, Kirill A. Shutemov wrote: > Naoya Horiguchi wrote: > > Thp related code also uses per process mm->page_table_lock now. > > So making it fine-grained can provide better performance. > > > > This patch makes thp support split page table lock by

Re: [PATCH 2/2] thp: support split page table lock

2013-09-06 Thread Alex Thorlton
On Thu, Sep 05, 2013 at 05:27:46PM -0400, Naoya Horiguchi wrote: > Thp related code also uses per process mm->page_table_lock now. > So making it fine-grained can provide better performance. > > This patch makes thp support split page table lock by using page->ptl > of the pages storing

RE: [PATCH 2/2] thp: support split page table lock

2013-09-06 Thread Kirill A. Shutemov
Naoya Horiguchi wrote: > Thp related code also uses per process mm->page_table_lock now. > So making it fine-grained can provide better performance. > > This patch makes thp support split page table lock by using page->ptl > of the pages storing "pmd_trans_huge" pmds. > > Some functions like

RE: [PATCH 2/2] thp: support split page table lock

2013-09-06 Thread Kirill A. Shutemov
Naoya Horiguchi wrote: Thp related code also uses per process mm-page_table_lock now. So making it fine-grained can provide better performance. This patch makes thp support split page table lock by using page-ptl of the pages storing pmd_trans_huge pmds. Some functions like

Re: [PATCH 2/2] thp: support split page table lock

2013-09-06 Thread Alex Thorlton
On Thu, Sep 05, 2013 at 05:27:46PM -0400, Naoya Horiguchi wrote: Thp related code also uses per process mm-page_table_lock now. So making it fine-grained can provide better performance. This patch makes thp support split page table lock by using page-ptl of the pages storing pmd_trans_huge

Re: [PATCH 2/2] thp: support split page table lock

2013-09-06 Thread Naoya Horiguchi
Hi Kirill, On Fri, Sep 06, 2013 at 01:48:03PM +0300, Kirill A. Shutemov wrote: Naoya Horiguchi wrote: Thp related code also uses per process mm-page_table_lock now. So making it fine-grained can provide better performance. This patch makes thp support split page table lock by using

Re: [PATCH 2/2] thp: support split page table lock

2013-09-06 Thread Kirill A. Shutemov
Naoya Horiguchi wrote: Hi Kirill, On Fri, Sep 06, 2013 at 01:48:03PM +0300, Kirill A. Shutemov wrote: Naoya Horiguchi wrote: Thp related code also uses per process mm-page_table_lock now. So making it fine-grained can provide better performance. This patch makes thp support

Re: [PATCH 2/2] thp: support split page table lock

2013-09-06 Thread Naoya Horiguchi
On Fri, Sep 06, 2013 at 07:46:25PM +0300, Kirill A. Shutemov wrote: Naoya Horiguchi wrote: Hi Kirill, On Fri, Sep 06, 2013 at 01:48:03PM +0300, Kirill A. Shutemov wrote: Naoya Horiguchi wrote: Thp related code also uses per process mm-page_table_lock now. So making it

Re: [PATCH 2/2] thp: support split page table lock

2013-09-06 Thread Naoya Horiguchi
Hi Alex, On Fri, Sep 06, 2013 at 11:04:23AM -0500, Alex Thorlton wrote: On Thu, Sep 05, 2013 at 05:27:46PM -0400, Naoya Horiguchi wrote: Thp related code also uses per process mm-page_table_lock now. So making it fine-grained can provide better performance. This patch makes thp support

Re: [PATCH 2/2] thp: support split page table lock

2013-09-03 Thread Naoya Horiguchi
> diff --git v3.11-rc3.orig/mm/huge_memory.c v3.11-rc3/mm/huge_memory.c > index 243e710..3cb29e1 100644 > --- v3.11-rc3.orig/mm/huge_memory.c > +++ v3.11-rc3/mm/huge_memory.c ... > @@ -864,14 +868,17 @@ int copy_huge_pmd(struct mm_struct *dst_mm, struct > mm_struct *src_mm, > pmd_t pmd; >

Re: [PATCH 2/2] thp: support split page table lock

2013-09-03 Thread Naoya Horiguchi
diff --git v3.11-rc3.orig/mm/huge_memory.c v3.11-rc3/mm/huge_memory.c index 243e710..3cb29e1 100644 --- v3.11-rc3.orig/mm/huge_memory.c +++ v3.11-rc3/mm/huge_memory.c ... @@ -864,14 +868,17 @@ int copy_huge_pmd(struct mm_struct *dst_mm, struct mm_struct *src_mm, pmd_t pmd;

Re: [PATCH 2/2] thp: support split page table lock

2013-09-02 Thread Naoya Horiguchi
Kirill, thank you for the comment. On Mon, Sep 02, 2013 at 01:53:27PM +0300, Kirill A. Shutemov wrote: > Naoya Horiguchi wrote: > > Thp related code also uses per process mm->page_table_lock now. So making > > it fine-grained can provide better performance. > > > > This patch makes thp support

RE: [PATCH 2/2] thp: support split page table lock

2013-09-02 Thread Kirill A. Shutemov
Naoya Horiguchi wrote: > Thp related code also uses per process mm->page_table_lock now. So making > it fine-grained can provide better performance. > > This patch makes thp support split page table lock which makes us use > page->ptl of the pages storing "pmd_trans_huge" pmds. Hm. So, you use

RE: [PATCH 2/2] thp: support split page table lock

2013-09-02 Thread Kirill A. Shutemov
Naoya Horiguchi wrote: Thp related code also uses per process mm-page_table_lock now. So making it fine-grained can provide better performance. This patch makes thp support split page table lock which makes us use page-ptl of the pages storing pmd_trans_huge pmds. Hm. So, you use page-ptl

Re: [PATCH 2/2] thp: support split page table lock

2013-09-02 Thread Naoya Horiguchi
Kirill, thank you for the comment. On Mon, Sep 02, 2013 at 01:53:27PM +0300, Kirill A. Shutemov wrote: Naoya Horiguchi wrote: Thp related code also uses per process mm-page_table_lock now. So making it fine-grained can provide better performance. This patch makes thp support split page