RE: [PATCH v1 0/5] Add Tiger Lake/Elkhart Lake support to pmc_core driver

2019-09-30 Thread Kammela, Gayatri
> On top of that the fully inconsistent SoC naming through the existing code / > new additions. I will fix it in the existing code/new additions in v2. > > I'm pretty sure you need to spell platforms as Tiger Lake, Elkhart Lake and so > on everywhere. Sorry, I was careful about naming convention

RE: [PATCH v1 0/5] Add Tiger Lake/Elkhart Lake support to pmc_core driver

2019-09-30 Thread Kammela, Gayatri
> On Thu, Sep 26, 2019 at 9:43 PM Gayatri Kammela > wrote: > > Thank you for the series, I'll comment them later. Thank you Andy! > > For now, check how to properly setup prefix for all patches. The Title all > broken. I'm sorry about that. I will fix it in v2 > > > Patch 1: Cleans up

Re: [PATCH v1 0/5] Add Tiger Lake/Elkhart Lake support to pmc_core driver

2019-09-27 Thread Andy Shevchenko
On Fri, Sep 27, 2019 at 9:01 AM Andy Shevchenko wrote: > On Thu, Sep 26, 2019 at 9:43 PM Gayatri Kammela > wrote: > > Thank you for the series, I'll comment them later. > > For now, check how to properly setup prefix for all patches. The Title > all broken. > On top of that the fully

Re: [PATCH v1 0/5] Add Tiger Lake/Elkhart Lake support to pmc_core driver

2019-09-27 Thread Andy Shevchenko
On Thu, Sep 26, 2019 at 9:43 PM Gayatri Kammela wrote: Thank you for the series, I'll comment them later. For now, check how to properly setup prefix for all patches. The Title all broken. > Patch 1: Cleans up termination lines > Patch 2: Refactor driver for ease of adding new SoCs > Patch 3: