Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2019-01-25 Thread Andy Shevchenko
On Fri, Jan 25, 2019 at 11:57:57AM -0600, Pierre-Louis Bossart wrote: > > > > > The only minor annoyance I'm experiencing now, is a large amount of > > > > debug output from something in kernel log when audio is played on the > > > > system: > > > > writing to lpe: : 01 01 01 01 00 00 08

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2019-01-25 Thread Pierre-Louis Bossart
The only minor annoyance I'm experiencing now, is a large amount of debug output from something in kernel log when audio is played on the system: writing to lpe: : 01 01 01 01 00 00 08 00 ff ff ff ff 55 00 00 00 U... writing to lpe: : 01 01 01 01 00 00 1a 00 ff ff

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2019-01-25 Thread Pierre-Louis Bossart
On 1/24/19 11:16 PM, Mogens Jensen wrote: ‐‐‐ Original Message ‐‐‐ On Tuesday, January 22, 2019 7:27 PM, Pierre-Louis Bossart wrote: On 1/20/19 11:55 PM, Mogens Jensen wrote: The only minor annoyance I'm experiencing now, is a large amount of debug output from something in kernel

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2019-01-24 Thread Mogens Jensen
‐‐‐ Original Message ‐‐‐ On Tuesday, January 22, 2019 7:27 PM, Pierre-Louis Bossart wrote: > On 1/20/19 11:55 PM, Mogens Jensen wrote: > > > The only minor annoyance I'm experiencing now, is a large amount of debug > > output from something in kernel log when audio is played on the syst

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2019-01-24 Thread Hans de Goede
Hi, On 21-01-19 06:55, Mogens Jensen wrote: ‐‐‐ Original Message ‐‐‐ On Friday, January 18, 2019 3:35 PM, Hans de Goede wrote: Hi, On 1/17/19 8:30 PM, Mogens Jensen wrote: ‐‐‐ Original Message ‐‐‐ On Thursday, January 17, 2019 12:05 PM, Hans de Goede hdego...@redhat.com wro

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2019-01-22 Thread Pierre-Louis Bossart
On 1/20/19 11:55 PM, Mogens Jensen wrote: The only minor annoyance I'm experiencing now, is a large amount of debug output from something in kernel log when audio is played on the system: writing to lpe: : 01 01 01 01 00 00 08 00 ff ff ff ff 55 00 00 00 U... writing to l

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2019-01-20 Thread Mogens Jensen
‐‐‐ Original Message ‐‐‐ On Friday, January 18, 2019 3:35 PM, Hans de Goede wrote: > Hi, > > On 1/17/19 8:30 PM, Mogens Jensen wrote: > > > ‐‐‐ Original Message ‐‐‐ > > On Thursday, January 17, 2019 12:05 PM, Hans de Goede hdego...@redhat.com > > wrote: > > > > > Hi, > > > On 17-

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2019-01-18 Thread Hans de Goede
Hi, On 1/17/19 8:30 PM, Mogens Jensen wrote: ‐‐‐ Original Message ‐‐‐ On Thursday, January 17, 2019 12:05 PM, Hans de Goede wrote: Hi, On 17-01-19 10:12, Dean Wallace wrote: Hi Hans, Mogens, On 17-01-19, Mogens Jensen wrote: Kernel is compiled with SND_SOC_INTEL_CHT_BSW_MAX98090

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2019-01-18 Thread Hans de Goede
Hi, On 1/17/19 2:16 PM, Dean Wallace wrote: On 17-01-19, Hans de Goede wrote: Mogens, Dean, can you please try the SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH driver, without reverting any patches, with the attached patch on top and see if that helps? Hi Hans. Just compiled 4.20.3 with your new

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2019-01-17 Thread Mogens Jensen
‐‐‐ Original Message ‐‐‐ On Thursday, January 17, 2019 12:05 PM, Hans de Goede wrote: > Hi, > > On 17-01-19 10:12, Dean Wallace wrote: > > > Hi Hans, Mogens, > > On 17-01-19, Mogens Jensen wrote: > > > > > Kernel is compiled with SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH and the > > > quir

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2019-01-17 Thread Johannes Stezenbach
On Thu, Jan 17, 2019 at 01:05:35PM +0100, Hans de Goede wrote: > On 17-01-19 10:12, Dean Wallace wrote: > > On 17-01-19, Mogens Jensen wrote: > > > Kernel is compiled with SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH and the > > > quirk seems to have fixed the problem caused by commit 648e921888ad > >

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2019-01-17 Thread Dean Wallace
On 17-01-19, Hans de Goede wrote: > Mogens, Dean, can you please try the SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH > driver, without reverting any patches, with the attached patch on top and > see if that helps? Hi Hans. Just compiled 4.20.3 with your new patch and no other patches. First impressi

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2019-01-17 Thread Hans de Goede
Hi, On 17-01-19 10:12, Dean Wallace wrote: Hi Hans, Mogens, On 17-01-19, Mogens Jensen wrote: Kernel is compiled with SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH and the quirk seems to have fixed the problem caused by commit 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL"), as

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2019-01-17 Thread Dean Wallace
Hi Hans, Mogens, On 17-01-19, Mogens Jensen wrote: > Kernel is compiled with SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH and the quirk > seems to have fixed the problem caused by commit 648e921888ad ("clk: x86: > Stop marking clocks as CLK_IS_CRITICAL"), as sound is now working if running > "speak

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2019-01-16 Thread Mogens Jensen
‐‐‐ Original Message ‐‐‐ On Sunday, December 2, 2018 12:25 PM, Hans de Goede wrote: > Hi, > > On 01-11-18 07:55, Mogens Jensen wrote: > > > ‐‐‐ Original Message ‐‐‐ > > On Wednesday, October 31, 2018 9:29 AM, Hans de Goede hdego...@redhat.com > > wrote: > > > > > Hi, > > > On 31-

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-12-02 Thread Hans de Goede
Hi, On 01-11-18 07:55, Mogens Jensen wrote: ‐‐‐ Original Message ‐‐‐ On Wednesday, October 31, 2018 9:29 AM, Hans de Goede wrote: Hi, On 31-10-18 07:02, Mogens Jensen wrote: ‐‐‐ Original Message ‐‐‐ On Tuesday, October 30, 2018 7:10 PM, Hans de Goede hdego...@redhat.com wr

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-11-02 Thread Dean Wallace
On 02-11-18, Hans de Goede wrote: > Hi, > > On 01-11-18 16:50, Dean Wallace wrote: > > On 01-11-18, Hans de Goede wrote: > > > Hi, > > > > > > On 01-11-18 15:28, Dean Wallace wrote: > > > > On 01-11-18, Hans de Goede wrote: > > > > > Hi, > > > > > > > > > > On 01-11-18 11:37, Dean Wallace wrote:

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-11-02 Thread Hans de Goede
Hi, On 01-11-18 16:50, Dean Wallace wrote: On 01-11-18, Hans de Goede wrote: Hi, On 01-11-18 15:28, Dean Wallace wrote: On 01-11-18, Hans de Goede wrote: Hi, On 01-11-18 11:37, Dean Wallace wrote: On 31-10-18, Pierre-Louis Bossart wrote: Just thought it worth mentioning, this new patch

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-11-01 Thread Dean Wallace
On 01-11-18, Hans de Goede wrote: > Hi, > > On 01-11-18 15:28, Dean Wallace wrote: > > On 01-11-18, Hans de Goede wrote: > > > Hi, > > > > > > On 01-11-18 11:37, Dean Wallace wrote: > > > > On 31-10-18, Pierre-Louis Bossart wrote: > > > > > > > > > > > Just thought it worth mentioning, this new

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-11-01 Thread Dean Wallace
On 01-11-18, Hans de Goede wrote: > Hi, > > On 01-11-18 15:28, Dean Wallace wrote: > > On 01-11-18, Hans de Goede wrote: > > > Hi, > > > > > > On 01-11-18 11:37, Dean Wallace wrote: > > > > On 31-10-18, Pierre-Louis Bossart wrote: > > > > > > > > > > > Just thought it worth mentioning, this new

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-11-01 Thread Dean Wallace
On 01-11-18, Hans de Goede wrote: > Hi, > > On 01-11-18 15:28, Dean Wallace wrote: > > On 01-11-18, Hans de Goede wrote: > > > Hi, > > > > > > On 01-11-18 11:37, Dean Wallace wrote: > > > > On 31-10-18, Pierre-Louis Bossart wrote: > > > > > > > > > > > Just thought it worth mentioning, this new

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-11-01 Thread Hans de Goede
Hi, On 01-11-18 15:28, Dean Wallace wrote: On 01-11-18, Hans de Goede wrote: Hi, On 01-11-18 11:37, Dean Wallace wrote: On 31-10-18, Pierre-Louis Bossart wrote: Just thought it worth mentioning, this new patch that fixes sound again, seems to have ressurected an old issue with PLL unlock.

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-11-01 Thread Dean Wallace
On 01-11-18, Hans de Goede wrote: > Hi, > > On 01-11-18 11:37, Dean Wallace wrote: > > On 31-10-18, Pierre-Louis Bossart wrote: > > > > > > > Just thought it worth mentioning, this new patch that fixes sound > > > > again, seems to have ressurected an old issue with PLL unlock. I'm > > > > seein

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-11-01 Thread Hans de Goede
Hi, On 01-11-18 11:37, Dean Wallace wrote: On 31-10-18, Pierre-Louis Bossart wrote: Just thought it worth mentioning, this new patch that fixes sound again, seems to have ressurected an old issue with PLL unlock. I'm seeing journal entries after fresh boot .. ``` picard kernel: max98090

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-11-01 Thread Hans de Goede
Hi, On 31-10-18 23:27, Pierre-Louis Bossart wrote: Just thought it worth mentioning, this new patch that fixes sound again, seems to have ressurected an old issue with PLL unlock.  I'm seeing journal entries after fresh boot .. ``` picard kernel: max98090 i2c-193C9890:00: PLL unlocked pic

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-11-01 Thread Dean Wallace
On 31-10-18, Pierre-Louis Bossart wrote: > > > Just thought it worth mentioning, this new patch that fixes sound > > again, seems to have ressurected an old issue with PLL unlock. I'm > > seeing journal entries after fresh boot .. > > > > ``` > > picard kernel: max98090 i2c-193C9890:00: PLL

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-31 Thread Mogens Jensen
‐‐‐ Original Message ‐‐‐ On Wednesday, October 31, 2018 9:29 AM, Hans de Goede wrote: > Hi, > > On 31-10-18 07:02, Mogens Jensen wrote: > > > ‐‐‐ Original Message ‐‐‐ > > On Tuesday, October 30, 2018 7:10 PM, Hans de Goede hdego...@redhat.com > > wrote: > > > > > Hi, > > > On 30

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-31 Thread Dean Wallace
On 31-10-18, Pierre-Louis Bossart wrote: > > > Just thought it worth mentioning, this new patch that fixes sound > > again, seems to have ressurected an old issue with PLL unlock. I'm > > seeing journal entries after fresh boot .. > > > > ``` > > picard kernel: max98090 i2c-193C9890:00: PLL

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-31 Thread Pierre-Louis Bossart
Just thought it worth mentioning, this new patch that fixes sound again, seems to have ressurected an old issue with PLL unlock. I'm seeing journal entries after fresh boot .. ``` picard kernel: max98090 i2c-193C9890:00: PLL unlocked picard systemd[462]: Started Sound Service. picard kern

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-31 Thread Dean Wallace
On 31-10-18, Hans de Goede wrote: > Hi, > > On 30-10-18 17:15, Dean Wallace wrote: > > On 30-10-18, Hans de Goede wrote: > > > Hi, > > > > > > On 30-10-18 16:46, Hans de Goede wrote: > > > > Hi, > > > > > > > > On 30-10-18 16:04, Pierre-Louis Bossart wrote: > > > > > In addition I am not aware o

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-31 Thread Dean Wallace
On 31-10-18, Hans de Goede wrote: > Thanks, can you give the attached patch a try. This does the same > as the previous one you tested, but then only on the Swanky. > > Note I've added: > > Reported-and-tested-by: Dean Wallace > > To the commit message, I hope that is ok with you, if not let me

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-31 Thread Hans de Goede
Hi, On 30-10-18 17:15, Dean Wallace wrote: On 30-10-18, Hans de Goede wrote: Hi, On 30-10-18 16:46, Hans de Goede wrote: Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: In addition I am not aware of any baytrail device using plt_clk_0, so moving a common machine driver such a cht_bsw_max

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-31 Thread Dean Wallace
On 31-10-18, Hans de Goede wrote: > Hi, > > On 31-10-18 07:02, Mogens Jensen wrote: > > ‐‐‐ Original Message ‐‐‐ > > On Tuesday, October 30, 2018 7:10 PM, Hans de Goede > > wrote: > > > > > Hi, > > > > > > On 30-10-18 19:56, Mogens Jensen wrote: > > > > > > > ‐‐‐ Original Message

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-31 Thread Hans de Goede
Hi, On 31-10-18 07:02, Mogens Jensen wrote: ‐‐‐ Original Message ‐‐‐ On Tuesday, October 30, 2018 7:10 PM, Hans de Goede wrote: Hi, On 30-10-18 19:56, Mogens Jensen wrote: ‐‐‐ Original Message ‐‐‐ On Tuesday, October 30, 2018 4:04 PM, Hans de Goede hdego...@redhat.com wrote

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Mogens Jensen
‐‐‐ Original Message ‐‐‐ On Tuesday, October 30, 2018 7:10 PM, Hans de Goede wrote: > Hi, > > On 30-10-18 19:56, Mogens Jensen wrote: > > > ‐‐‐ Original Message ‐‐‐ > > On Tuesday, October 30, 2018 4:04 PM, Hans de Goede hdego...@redhat.com > > wrote: > > > > > Hi, > > > On 30-10

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
Hi, On 30-10-18 19:56, Mogens Jensen wrote: ‐‐‐ Original Message ‐‐‐ On Tuesday, October 30, 2018 4:04 PM, Hans de Goede wrote: Hi, On 30-10-18 16:46, Hans de Goede wrote: Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: In addition I am not aware of any baytrail device using p

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Mogens Jensen
‐‐‐ Original Message ‐‐‐ On Tuesday, October 30, 2018 4:04 PM, Hans de Goede wrote: > Hi, > > On 30-10-18 16:46, Hans de Goede wrote: > > > Hi, > > On 30-10-18 16:04, Pierre-Louis Bossart wrote: > > > > > In addition I am not aware of any baytrail device using plt_clk_0, so > > > moving

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
Hi Pierre-Louis, On 30-10-18 17:27, Pierre-Louis Bossart wrote: On 10/30/18 11:02 AM, Hans de Goede wrote: Hi, On 30-10-18 16:46, Hans de Goede wrote: Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: On 10/30/18 9:38 AM, Dean Wallace wrote: On 30-10-18, Hans de Goede wrote: Hi Dean,

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Pierre-Louis Bossart
On 10/30/18 11:02 AM, Hans de Goede wrote: Hi, On 30-10-18 16:46, Hans de Goede wrote: Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: On 10/30/18 9:38 AM, Dean Wallace wrote: On 30-10-18, Hans de Goede wrote: Hi Dean, Attached are 2 different attempts at fixing this. When trying th

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Andy Shevchenko
On Tue, Oct 30, 2018 at 1:05 PM Hans de Goede wrote: > for i in /sys/kernel/debug/clk/pmc_plt_clk_?; do echo -n "$i: "; cat > $i/clk_flags; echo; done Just a side note about nice tool, called `grep` :-) grep -H . /sys/kernel/debug/clk/pmc_plt_clk_*/clk_flags does above in one call. -- With

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Dean Wallace
On 30-10-18, Hans de Goede wrote: > Hi, > > On 30-10-18 16:46, Hans de Goede wrote: > > Hi, > > > > On 30-10-18 16:04, Pierre-Louis Bossart wrote: > > > In addition I am not aware of any baytrail device using plt_clk_0, > > > so moving a common machine driver such a cht_bsw_max98090_ti to use > >

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Pierre-Louis Bossart
On 10/30/18 10:46 AM, Hans de Goede wrote: Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: On 10/30/18 9:38 AM, Dean Wallace wrote: On 30-10-18, Hans de Goede wrote: Hi Dean, Attached are 2 different attempts at fixing this. When trying these patches do not forget to remove the revert

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
Hi, On 30-10-18 16:46, Hans de Goede wrote: Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: In addition I am not aware of any baytrail device using plt_clk_0, so moving a common machine driver such a cht_bsw_max98090_ti to use plt_clk0 only would break other devices (e.g. Rambi/Orco). Asking

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
Hi, On 30-10-18 16:46, Hans de Goede wrote: Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: On 10/30/18 9:38 AM, Dean Wallace wrote: On 30-10-18, Hans de Goede wrote: Hi Dean, Attached are 2 different attempts at fixing this. When trying these patches do not forget to remove the revert

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: On 10/30/18 9:38 AM, Dean Wallace wrote: On 30-10-18, Hans de Goede wrote: Hi Dean, Attached are 2 different attempts at fixing this. When trying these patches do not forget to remove the revert of the "Stop-marking-clocks-as-CLK_IS_CRITICA

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Pierre-Louis Bossart
On 10/30/18 10:03 AM, Andy Shevchenko wrote: On Tue, Oct 30, 2018 at 4:48 PM Hans de Goede wrote: On 30-10-18 15:38, Dean Wallace wrote: Excellent work Hans. Compiled 4.19 with 0001-ASoC-intel-cht_bsw_max98090_ti-Use-pmc_plt_clk_0-ins.patch, sound works as before. for i in /sys/kernel/debu

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Pierre-Louis Bossart
On 10/30/18 9:38 AM, Dean Wallace wrote: On 30-10-18, Hans de Goede wrote: Hi Dean, Attached are 2 different attempts at fixing this. When trying these patches do not forget to remove the revert of the "Stop-marking-clocks-as-CLK_IS_CRITICAL" commit. Please first try the 0001-ASoC-intel-ch

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Andy Shevchenko
On Tue, Oct 30, 2018 at 4:48 PM Hans de Goede wrote: > On 30-10-18 15:38, Dean Wallace wrote: > > Excellent work Hans. Compiled 4.19 with > > 0001-ASoC-intel-cht_bsw_max98090_ti-Use-pmc_plt_clk_0-ins.patch, sound > > works as before. > > > > for i in /sys/kernel/debug/clk/pmc_plt_clk_?; do echo

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
Hi, On 30-10-18 15:38, Dean Wallace wrote: On 30-10-18, Hans de Goede wrote: Hi Dean, Attached are 2 different attempts at fixing this. When trying these patches do not forget to remove the revert of the "Stop-marking-clocks-as-CLK_IS_CRITICAL" commit. Please first try the 0001-ASoC-intel-c

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Dean Wallace
On 30-10-18, Hans de Goede wrote: > Hi Dean, > > Attached are 2 different attempts at fixing this. > > When trying these patches do not forget to remove the revert of the > "Stop-marking-clocks-as-CLK_IS_CRITICAL" commit. > > Please first try the > 0001-ASoC-intel-cht_bsw_max98090_ti-Use-pmc_pl

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
Hi Dean, Attached are 2 different attempts at fixing this. When trying these patches do not forget to remove the revert of the "Stop-marking-clocks-as-CLK_IS_CRITICAL" commit. Please first try the 0001-ASoC-intel-cht_bsw_max98090_ti-Use-pmc_plt_clk_0-ins.patch patch I expect that one to do the

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
Hi, On 30-10-18 11:17, Hans de Goede wrote: Hi Pierre-Louis, On 29-10-18 23:03, Pierre-Louis Bossart wrote: On 10/29/18 2:08 PM, Dean Wallace wrote: On 29-10-18, Andy Shevchenko wrote: On Mon, Oct 29, 2018 at 7:52 PM Andy Shevchenko wrote: Cc: Pierre as well. On Mon, Oct 29, 2018 at 7:48

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
Hi Pierre-Louis, On 29-10-18 23:03, Pierre-Louis Bossart wrote: On 10/29/18 2:08 PM, Dean Wallace wrote: On 29-10-18, Andy Shevchenko wrote: On Mon, Oct 29, 2018 at 7:52 PM Andy Shevchenko wrote: Cc: Pierre as well. On Mon, Oct 29, 2018 at 7:48 PM Stephen Boyd wrote: Quoting Dean Wallace

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-29 Thread Pierre-Louis Bossart
On 10/29/18 2:08 PM, Dean Wallace wrote: On 29-10-18, Andy Shevchenko wrote: On Mon, Oct 29, 2018 at 7:52 PM Andy Shevchenko wrote: Cc: Pierre as well. On Mon, Oct 29, 2018 at 7:48 PM Stephen Boyd wrote: Quoting Dean Wallace (2018-10-25 16:25:17) I have found a regression in 4.18.15 that

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-29 Thread Dean Wallace
On 29-10-18, Andy Shevchenko wrote: > On Mon, Oct 29, 2018 at 7:52 PM Andy Shevchenko > wrote: > > > > Cc: Pierre as well. > > > > On Mon, Oct 29, 2018 at 7:48 PM Stephen Boyd wrote: > > > > > > Quoting Dean Wallace (2018-10-25 16:25:17) > > > > I have found a regression in 4.18.15 that means I l

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-29 Thread Andy Shevchenko
On Mon, Oct 29, 2018 at 7:52 PM Andy Shevchenko wrote: > > Cc: Pierre as well. > > On Mon, Oct 29, 2018 at 7:48 PM Stephen Boyd wrote: > > > > Quoting Dean Wallace (2018-10-25 16:25:17) > > > I have found a regression in 4.18.15 that means I lose sound on my old > > > Toshiba Chromebook 2 (Swanky

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-29 Thread Andy Shevchenko
Cc: Pierre as well. On Mon, Oct 29, 2018 at 7:48 PM Stephen Boyd wrote: > > Quoting Dean Wallace (2018-10-25 16:25:17) > > I have found a regression in 4.18.15 that means I lose sound on my old > > Toshiba Chromebook 2 (Swanky). My system details are:- > > > > Toshiba Chromebook (Swanky) > > MrC

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-29 Thread Stephen Boyd
Quoting Dean Wallace (2018-10-25 16:25:17) > I have found a regression in 4.18.15 that means I lose sound on my old > Toshiba Chromebook 2 (Swanky). My system details are:- > > Toshiba Chromebook (Swanky) > MrChromebox UEFI coreboot > Arch Linux running latest alsa/pulseaudio > > Upgraded kernel