Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-23 Thread Pavel Machek
On Mon 2015-11-23 11:46:37, Charles Keepax wrote: > On Mon, Nov 23, 2015 at 11:30:41AM +, Mark Brown wrote: > > On Mon, Nov 23, 2015 at 10:25:22AM +, Richard Fitzgerald wrote: > > > On Mon, 2015-11-23 at 11:11 +0100, Pavel Machek wrote: > > > > > > That's what I'm saying. It is good to

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-23 Thread Lee Jones
On Mon, 23 Nov 2015, Charles Keepax wrote: > On Mon, Nov 23, 2015 at 11:30:41AM +, Mark Brown wrote: > > On Mon, Nov 23, 2015 at 10:25:22AM +, Richard Fitzgerald wrote: > > > On Mon, 2015-11-23 at 11:11 +0100, Pavel Machek wrote: > > > > > > That's what I'm saying. It is good to know who

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-23 Thread Charles Keepax
On Mon, Nov 23, 2015 at 11:30:41AM +, Mark Brown wrote: > On Mon, Nov 23, 2015 at 10:25:22AM +, Richard Fitzgerald wrote: > > On Mon, 2015-11-23 at 11:11 +0100, Pavel Machek wrote: > > > > That's what I'm saying. It is good to know who is the person of > > > authority, as you can't tell

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-23 Thread Mark Brown
On Mon, Nov 23, 2015 at 10:25:22AM +, Richard Fitzgerald wrote: > On Mon, 2015-11-23 at 11:11 +0100, Pavel Machek wrote: > > That's what I'm saying. It is good to know who is the person of > > authority, as you can't tell from the From: address. > It's unreasonable to expect that one member

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-23 Thread Richard Fitzgerald
On Mon, 2015-11-23 at 11:11 +0100, Pavel Machek wrote: > On Mon 2015-11-23 08:18:57, Lee Jones wrote: > > On Sun, 22 Nov 2015, Pavel Machek wrote: > > > > > On Mon 2015-11-16 14:11:42, Charles Keepax wrote: > > > > On Sat, Nov 14, 2015 at 10:16:33PM +0100, Pavel Machek wrote: > > > > > HiOn Sat

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-23 Thread Pavel Machek
On Mon 2015-11-23 08:18:57, Lee Jones wrote: > On Sun, 22 Nov 2015, Pavel Machek wrote: > > > On Mon 2015-11-16 14:11:42, Charles Keepax wrote: > > > On Sat, Nov 14, 2015 at 10:16:33PM +0100, Pavel Machek wrote: > > > > HiOn Sat 2015-11-14 18:49:40, Mark Brown wrote: > > > > > On Sat, Nov 14,

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-23 Thread Lee Jones
On Sun, 22 Nov 2015, Pavel Machek wrote: > On Mon 2015-11-16 14:11:42, Charles Keepax wrote: > > On Sat, Nov 14, 2015 at 10:16:33PM +0100, Pavel Machek wrote: > > > HiOn Sat 2015-11-14 18:49:40, Mark Brown wrote: > > > > On Sat, Nov 14, 2015 at 06:59:16PM +0100, Pavel Machek wrote: > > > > > > >

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-23 Thread Richard Fitzgerald
On Mon, 2015-11-23 at 11:11 +0100, Pavel Machek wrote: > On Mon 2015-11-23 08:18:57, Lee Jones wrote: > > On Sun, 22 Nov 2015, Pavel Machek wrote: > > > > > On Mon 2015-11-16 14:11:42, Charles Keepax wrote: > > > > On Sat, Nov 14, 2015 at 10:16:33PM +0100, Pavel Machek wrote: > > > > > HiOn Sat

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-23 Thread Mark Brown
On Mon, Nov 23, 2015 at 10:25:22AM +, Richard Fitzgerald wrote: > On Mon, 2015-11-23 at 11:11 +0100, Pavel Machek wrote: > > That's what I'm saying. It is good to know who is the person of > > authority, as you can't tell from the From: address. > It's unreasonable to expect that one member

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-23 Thread Lee Jones
On Sun, 22 Nov 2015, Pavel Machek wrote: > On Mon 2015-11-16 14:11:42, Charles Keepax wrote: > > On Sat, Nov 14, 2015 at 10:16:33PM +0100, Pavel Machek wrote: > > > HiOn Sat 2015-11-14 18:49:40, Mark Brown wrote: > > > > On Sat, Nov 14, 2015 at 06:59:16PM +0100, Pavel Machek wrote: > > > > > > >

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-23 Thread Pavel Machek
On Mon 2015-11-23 08:18:57, Lee Jones wrote: > On Sun, 22 Nov 2015, Pavel Machek wrote: > > > On Mon 2015-11-16 14:11:42, Charles Keepax wrote: > > > On Sat, Nov 14, 2015 at 10:16:33PM +0100, Pavel Machek wrote: > > > > HiOn Sat 2015-11-14 18:49:40, Mark Brown wrote: > > > > > On Sat, Nov 14,

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-23 Thread Charles Keepax
On Mon, Nov 23, 2015 at 11:30:41AM +, Mark Brown wrote: > On Mon, Nov 23, 2015 at 10:25:22AM +, Richard Fitzgerald wrote: > > On Mon, 2015-11-23 at 11:11 +0100, Pavel Machek wrote: > > > > That's what I'm saying. It is good to know who is the person of > > > authority, as you can't tell

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-23 Thread Lee Jones
On Mon, 23 Nov 2015, Charles Keepax wrote: > On Mon, Nov 23, 2015 at 11:30:41AM +, Mark Brown wrote: > > On Mon, Nov 23, 2015 at 10:25:22AM +, Richard Fitzgerald wrote: > > > On Mon, 2015-11-23 at 11:11 +0100, Pavel Machek wrote: > > > > > > That's what I'm saying. It is good to know who

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-23 Thread Pavel Machek
On Mon 2015-11-23 11:46:37, Charles Keepax wrote: > On Mon, Nov 23, 2015 at 11:30:41AM +, Mark Brown wrote: > > On Mon, Nov 23, 2015 at 10:25:22AM +, Richard Fitzgerald wrote: > > > On Mon, 2015-11-23 at 11:11 +0100, Pavel Machek wrote: > > > > > > That's what I'm saying. It is good to

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-21 Thread Pavel Machek
On Mon 2015-11-16 14:11:42, Charles Keepax wrote: > On Sat, Nov 14, 2015 at 10:16:33PM +0100, Pavel Machek wrote: > > HiOn Sat 2015-11-14 18:49:40, Mark Brown wrote: > > > On Sat, Nov 14, 2015 at 06:59:16PM +0100, Pavel Machek wrote: > > > > > > > Well, mfd_core.c seems to call

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-21 Thread Pavel Machek
On Mon 2015-11-16 14:11:42, Charles Keepax wrote: > On Sat, Nov 14, 2015 at 10:16:33PM +0100, Pavel Machek wrote: > > HiOn Sat 2015-11-14 18:49:40, Mark Brown wrote: > > > On Sat, Nov 14, 2015 at 06:59:16PM +0100, Pavel Machek wrote: > > > > > > > Well, mfd_core.c seems to call

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-16 Thread Mark Brown
On Mon, Nov 16, 2015 at 01:29:47PM +0100, Pavel Machek wrote: > > > Ok, so you are saying that if I fix mfd initialization, sound will > > > automagically switch from global regulators to device-specific > > > regulators and things will start working? > > Yes. > Ok, so something like this

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-16 Thread Charles Keepax
On Mon, Nov 16, 2015 at 01:29:47PM +0100, Pavel Machek wrote: > Hi! > > > > > Every single sound driver gets this right, none of them assume the name > > > > is global. What makes you say that they assume names are global? > > > > > Ok, so you are saying that if I fix mfd initialization, sound

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-16 Thread Charles Keepax
On Sat, Nov 14, 2015 at 10:16:33PM +0100, Pavel Machek wrote: > HiOn Sat 2015-11-14 18:49:40, Mark Brown wrote: > > On Sat, Nov 14, 2015 at 06:59:16PM +0100, Pavel Machek wrote: > > > > > Well, mfd_core.c seems to call regulator_bulk_register_supply_alias() > > > with device that does not have

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-16 Thread Charles Keepax
On Sat, Nov 14, 2015 at 06:59:16PM +0100, Pavel Machek wrote: > Hi! > > > If you're asking about the regulator API or embedded ALSA both of those > > are me but there are other things in here - the driver you're working > > with and the MFD core at least. At the minute I'm not convinced that > >

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-16 Thread Charles Keepax
On Mon, Nov 16, 2015 at 01:29:47PM +0100, Pavel Machek wrote: > Hi! > > > > > Every single sound driver gets this right, none of them assume the name > > > > is global. What makes you say that they assume names are global? > > > > > Ok, so you are saying that if I fix mfd initialization, sound

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-16 Thread Pavel Machek
Hi! > > > Every single sound driver gets this right, none of them assume the name > > > is global. What makes you say that they assume names are global? > > > Ok, so you are saying that if I fix mfd initialization, sound will > > automagically switch from global regulators to device-specific >

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-16 Thread Mark Brown
On Mon, Nov 16, 2015 at 08:45:34AM +0100, Pavel Machek wrote: > > > Ok, so SND_SOC_DAPM_REGULATOR_SUPPLY() does not work, because I have > > > two regulators, right? Is there similar macro I can use? > > No? What would make you say that? > Plus, I'd expect to see some kind of "struct device"

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-16 Thread Charles Keepax
On Sat, Nov 14, 2015 at 10:16:33PM +0100, Pavel Machek wrote: > HiOn Sat 2015-11-14 18:49:40, Mark Brown wrote: > > On Sat, Nov 14, 2015 at 06:59:16PM +0100, Pavel Machek wrote: > > > > > Well, mfd_core.c seems to call regulator_bulk_register_supply_alias() > > > with device that does not have

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-16 Thread Charles Keepax
On Mon, Nov 16, 2015 at 01:29:47PM +0100, Pavel Machek wrote: > Hi! > > > > > Every single sound driver gets this right, none of them assume the name > > > > is global. What makes you say that they assume names are global? > > > > > Ok, so you are saying that if I fix mfd initialization, sound

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-16 Thread Pavel Machek
Hi! > > > Every single sound driver gets this right, none of them assume the name > > > is global. What makes you say that they assume names are global? > > > Ok, so you are saying that if I fix mfd initialization, sound will > > automagically switch from global regulators to device-specific >

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-16 Thread Charles Keepax
On Mon, Nov 16, 2015 at 01:29:47PM +0100, Pavel Machek wrote: > Hi! > > > > > Every single sound driver gets this right, none of them assume the name > > > > is global. What makes you say that they assume names are global? > > > > > Ok, so you are saying that if I fix mfd initialization, sound

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-16 Thread Charles Keepax
On Sat, Nov 14, 2015 at 06:59:16PM +0100, Pavel Machek wrote: > Hi! > > > If you're asking about the regulator API or embedded ALSA both of those > > are me but there are other things in here - the driver you're working > > with and the MFD core at least. At the minute I'm not convinced that > >

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-16 Thread Mark Brown
On Mon, Nov 16, 2015 at 01:29:47PM +0100, Pavel Machek wrote: > > > Ok, so you are saying that if I fix mfd initialization, sound will > > > automagically switch from global regulators to device-specific > > > regulators and things will start working? > > Yes. > Ok, so something like this

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-16 Thread Mark Brown
On Mon, Nov 16, 2015 at 08:45:34AM +0100, Pavel Machek wrote: > > > Ok, so SND_SOC_DAPM_REGULATOR_SUPPLY() does not work, because I have > > > two regulators, right? Is there similar macro I can use? > > No? What would make you say that? > Plus, I'd expect to see some kind of "struct device"

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-15 Thread Pavel Machek
Hi! > > > > Well, mfd_core.c seems to call regulator_bulk_register_supply_alias() > > > > with device that does not have dev_name initialized. > > > > OK, that'll be the problem then - we're not mapping the supply into the > > > individual child device but rather system wide, probably because

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-15 Thread Pavel Machek
Hi! > > > > Well, mfd_core.c seems to call regulator_bulk_register_supply_alias() > > > > with device that does not have dev_name initialized. > > > > OK, that'll be the problem then - we're not mapping the supply into the > > > individual child device but rather system wide, probably because

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-14 Thread Mark Brown
On Sat, Nov 14, 2015 at 10:16:33PM +0100, Pavel Machek wrote: > HiOn Sat 2015-11-14 18:49:40, Mark Brown wrote: > > On Sat, Nov 14, 2015 at 06:59:16PM +0100, Pavel Machek wrote: > > > Well, mfd_core.c seems to call regulator_bulk_register_supply_alias() > > > with device that does not have

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-14 Thread Pavel Machek
HiOn Sat 2015-11-14 18:49:40, Mark Brown wrote: > On Sat, Nov 14, 2015 at 06:59:16PM +0100, Pavel Machek wrote: > > > Well, mfd_core.c seems to call regulator_bulk_register_supply_alias() > > with device that does not have dev_name initialized. > > OK, that'll be the problem then - we're not

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-14 Thread Mark Brown
On Sat, Nov 14, 2015 at 06:59:16PM +0100, Pavel Machek wrote: > Well, mfd_core.c seems to call regulator_bulk_register_supply_alias() > with device that does not have dev_name initialized. OK, that'll be the problem then - we're not mapping the supply into the individual child device but rather

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-14 Thread Pavel Machek
Hi! > > Obviously I'll need to use the existing interfaces, or extend them as > > needed. I'd expect subsystem maintainer to know if the existing > > interfaces are ok or what needs to be fixed, but it seems you either > > don't know how your subsystem works, or are not willing to tell me. > > I

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-14 Thread Mark Brown
On Sat, Nov 14, 2015 at 08:44:00AM +0100, Pavel Machek wrote: > Obviously I'll need to use the existing interfaces, or extend them as > needed. I'd expect subsystem maintainer to know if the existing > interfaces are ok or what needs to be fixed, but it seems you either > don't know how your

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-14 Thread Mark Brown
On Sat, Nov 14, 2015 at 08:44:00AM +0100, Pavel Machek wrote: > Obviously I'll need to use the existing interfaces, or extend them as > needed. I'd expect subsystem maintainer to know if the existing > interfaces are ok or what needs to be fixed, but it seems you either > don't know how your

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-14 Thread Pavel Machek
Hi! > > Obviously I'll need to use the existing interfaces, or extend them as > > needed. I'd expect subsystem maintainer to know if the existing > > interfaces are ok or what needs to be fixed, but it seems you either > > don't know how your subsystem works, or are not willing to tell me. > > I

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-14 Thread Mark Brown
On Sat, Nov 14, 2015 at 06:59:16PM +0100, Pavel Machek wrote: > Well, mfd_core.c seems to call regulator_bulk_register_supply_alias() > with device that does not have dev_name initialized. OK, that'll be the problem then - we're not mapping the supply into the individual child device but rather

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-14 Thread Pavel Machek
HiOn Sat 2015-11-14 18:49:40, Mark Brown wrote: > On Sat, Nov 14, 2015 at 06:59:16PM +0100, Pavel Machek wrote: > > > Well, mfd_core.c seems to call regulator_bulk_register_supply_alias() > > with device that does not have dev_name initialized. > > OK, that'll be the problem then - we're not

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-14 Thread Mark Brown
On Sat, Nov 14, 2015 at 10:16:33PM +0100, Pavel Machek wrote: > HiOn Sat 2015-11-14 18:49:40, Mark Brown wrote: > > On Sat, Nov 14, 2015 at 06:59:16PM +0100, Pavel Machek wrote: > > > Well, mfd_core.c seems to call regulator_bulk_register_supply_alias() > > > with device that does not have

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-13 Thread Pavel Machek
On Fri 2015-11-13 22:53:55, Mark Brown wrote: > On Fri, Nov 13, 2015 at 10:58:12PM +0100, Pavel Machek wrote: > > On Tue 2015-10-13 12:53:55, Mark Brown wrote: > > > On Mon, Oct 12, 2015 at 10:11:38PM +0200, Pavel Machek wrote: > > > > > > No, you definitely shouldn't be doing this - the

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-13 Thread Mark Brown
On Fri, Nov 13, 2015 at 10:58:12PM +0100, Pavel Machek wrote: > On Tue 2015-10-13 12:53:55, Mark Brown wrote: > > On Mon, Oct 12, 2015 at 10:11:38PM +0200, Pavel Machek wrote: > > > > No, you definitely shouldn't be doing this - the regulator names should > > > > reflect the names the device has

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-13 Thread Pavel Machek
On Tue 2015-10-13 12:53:55, Mark Brown wrote: > On Mon, Oct 12, 2015 at 10:11:38PM +0200, Pavel Machek wrote: > > On Mon 2015-10-12 16:47:15, Mark Brown wrote: > > > On Mon, Oct 12, 2015 at 11:00:45AM +0200, Pavel Machek wrote: > > > > > static const struct regulator_desc arizona_ldo1_hc = { > >

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-13 Thread Mark Brown
On Fri, Nov 13, 2015 at 10:58:12PM +0100, Pavel Machek wrote: > On Tue 2015-10-13 12:53:55, Mark Brown wrote: > > On Mon, Oct 12, 2015 at 10:11:38PM +0200, Pavel Machek wrote: > > > > No, you definitely shouldn't be doing this - the regulator names should > > > > reflect the names the device has

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-13 Thread Pavel Machek
On Tue 2015-10-13 12:53:55, Mark Brown wrote: > On Mon, Oct 12, 2015 at 10:11:38PM +0200, Pavel Machek wrote: > > On Mon 2015-10-12 16:47:15, Mark Brown wrote: > > > On Mon, Oct 12, 2015 at 11:00:45AM +0200, Pavel Machek wrote: > > > > > static const struct regulator_desc arizona_ldo1_hc = { > >

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-11-13 Thread Pavel Machek
On Fri 2015-11-13 22:53:55, Mark Brown wrote: > On Fri, Nov 13, 2015 at 10:58:12PM +0100, Pavel Machek wrote: > > On Tue 2015-10-13 12:53:55, Mark Brown wrote: > > > On Mon, Oct 12, 2015 at 10:11:38PM +0200, Pavel Machek wrote: > > > > > > No, you definitely shouldn't be doing this - the

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-10-13 Thread Mark Brown
On Mon, Oct 12, 2015 at 10:11:38PM +0200, Pavel Machek wrote: > On Mon 2015-10-12 16:47:15, Mark Brown wrote: > > On Mon, Oct 12, 2015 at 11:00:45AM +0200, Pavel Machek wrote: > > > static const struct regulator_desc arizona_ldo1_hc = { > > > - .name = "LDO1", > > No, you definitely shouldn't

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-10-13 Thread Mark Brown
On Mon, Oct 12, 2015 at 10:11:38PM +0200, Pavel Machek wrote: > On Mon 2015-10-12 16:47:15, Mark Brown wrote: > > On Mon, Oct 12, 2015 at 11:00:45AM +0200, Pavel Machek wrote: > > > static const struct regulator_desc arizona_ldo1_hc = { > > > - .name = "LDO1", > > No, you definitely shouldn't

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-10-12 Thread Pavel Machek
Hi! On Mon 2015-10-12 16:47:15, Mark Brown wrote: > On Mon, Oct 12, 2015 at 11:00:45AM +0200, Pavel Machek wrote: > > > Does this look like a step in right direction? > > > static const struct regulator_desc arizona_ldo1_hc = { > > - .name = "LDO1", > > No, you definitely shouldn't be doing

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-10-12 Thread Mark Brown
On Mon, Oct 12, 2015 at 11:00:45AM +0200, Pavel Machek wrote: > Does this look like a step in right direction? > static const struct regulator_desc arizona_ldo1_hc = { > - .name = "LDO1", No, you definitely shouldn't be doing this - the regulator names should reflect the names the device

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-10-12 Thread Charles Keepax
On Mon, Oct 12, 2015 at 11:00:45AM +0200, Pavel Machek wrote: > Hi! > > > I guess you would need to be careful with the machine driver as > > well, you will need to use a snd_soc_codec_conf structure for at > > least one (although I would do both) of the CODECs to give a > > prefix for all the

multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-10-12 Thread Pavel Machek
Hi! > I guess you would need to be careful with the machine driver as > well, you will need to use a snd_soc_codec_conf structure for at > least one (although I would do both) of the CODECs to give a > prefix for all the widget/control names, otherwise those will > clash and everything will

multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-10-12 Thread Pavel Machek
Hi! > I guess you would need to be careful with the machine driver as > well, you will need to use a snd_soc_codec_conf structure for at > least one (although I would do both) of the CODECs to give a > prefix for all the widget/control names, otherwise those will > clash and everything will

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-10-12 Thread Mark Brown
On Mon, Oct 12, 2015 at 11:00:45AM +0200, Pavel Machek wrote: > Does this look like a step in right direction? > static const struct regulator_desc arizona_ldo1_hc = { > - .name = "LDO1", No, you definitely shouldn't be doing this - the regulator names should reflect the names the device

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-10-12 Thread Charles Keepax
On Mon, Oct 12, 2015 at 11:00:45AM +0200, Pavel Machek wrote: > Hi! > > > I guess you would need to be careful with the machine driver as > > well, you will need to use a snd_soc_codec_conf structure for at > > least one (although I would do both) of the CODECs to give a > > prefix for all the

Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs

2015-10-12 Thread Pavel Machek
Hi! On Mon 2015-10-12 16:47:15, Mark Brown wrote: > On Mon, Oct 12, 2015 at 11:00:45AM +0200, Pavel Machek wrote: > > > Does this look like a step in right direction? > > > static const struct regulator_desc arizona_ldo1_hc = { > > - .name = "LDO1", > > No, you definitely shouldn't be doing