Re: ARC build -O3 (was Re: subtle side effect of commit a1c48bb160f836)

2015-07-02 Thread Vineet Gupta
On Friday 03 July 2015 01:20 AM, Michal Marek wrote: >>> >> Reported-by: Vineet Gupta >>> >> Signed-off-by: Michal Marek >> > >> > Sweet, that works for me with the following patch below. >> > >> > Some logistics things: >> > - It would be nice to keep both of these patches together - do u

Re: ARC build -O3 (was Re: subtle side effect of commit a1c48bb160f836)

2015-07-02 Thread Michal Marek
Dne 2.7.2015 v 07:27 Vineet Gupta napsal(a): > On Wednesday 01 July 2015 08:49 PM, Michal Marek wrote: >> On Wed, Jun 24, 2015 at 05:50:16PM +0530, Vineet Gupta wrote: >>> On Thursday 18 June 2015 04:02 PM, Vineet Gupta wrote: On Thursday 18 June 2015 03:44 PM, Michal Marek wrote: > Uh,

Re: ARC build -O3 (was Re: subtle side effect of commit a1c48bb160f836)

2015-07-02 Thread Vineet Gupta
On Friday 03 July 2015 01:20 AM, Michal Marek wrote: Reported-by: Vineet Gupta vineet.gup...@synopsys.com Signed-off-by: Michal Marek mma...@suse.com Sweet, that works for me with the following patch below. Some logistics things: - It would be nice to keep both of these patches

Re: ARC build -O3 (was Re: subtle side effect of commit a1c48bb160f836)

2015-07-02 Thread Michal Marek
Dne 2.7.2015 v 07:27 Vineet Gupta napsal(a): On Wednesday 01 July 2015 08:49 PM, Michal Marek wrote: On Wed, Jun 24, 2015 at 05:50:16PM +0530, Vineet Gupta wrote: On Thursday 18 June 2015 04:02 PM, Vineet Gupta wrote: On Thursday 18 June 2015 03:44 PM, Michal Marek wrote: Uh, this is not what

ARC build -O3 (was Re: subtle side effect of commit a1c48bb160f836)

2015-07-01 Thread Vineet Gupta
On Wednesday 01 July 2015 08:49 PM, Michal Marek wrote: > On Wed, Jun 24, 2015 at 05:50:16PM +0530, Vineet Gupta wrote: >> On Thursday 18 June 2015 04:02 PM, Vineet Gupta wrote: >>> On Thursday 18 June 2015 03:44 PM, Michal Marek wrote: Uh, this is not what I meant. KCFLAGS is a *user*

Re: subtle side effect of commit a1c48bb160f836

2015-07-01 Thread Michal Marek
On Wed, Jun 24, 2015 at 05:50:16PM +0530, Vineet Gupta wrote: > On Thursday 18 June 2015 04:02 PM, Vineet Gupta wrote: > > On Thursday 18 June 2015 03:44 PM, Michal Marek wrote: > >> Uh, this is not what I meant. KCFLAGS is a *user* setting. It's meant to > >> be set in the environment or command

Re: subtle side effect of commit a1c48bb160f836

2015-07-01 Thread Michal Marek
On Wed, Jun 24, 2015 at 05:50:16PM +0530, Vineet Gupta wrote: On Thursday 18 June 2015 04:02 PM, Vineet Gupta wrote: On Thursday 18 June 2015 03:44 PM, Michal Marek wrote: Uh, this is not what I meant. KCFLAGS is a *user* setting. It's meant to be set in the environment or command line.

ARC build -O3 (was Re: subtle side effect of commit a1c48bb160f836)

2015-07-01 Thread Vineet Gupta
On Wednesday 01 July 2015 08:49 PM, Michal Marek wrote: On Wed, Jun 24, 2015 at 05:50:16PM +0530, Vineet Gupta wrote: On Thursday 18 June 2015 04:02 PM, Vineet Gupta wrote: On Thursday 18 June 2015 03:44 PM, Michal Marek wrote: Uh, this is not what I meant. KCFLAGS is a *user* setting. It's

Re: subtle side effect of commit a1c48bb160f836

2015-06-24 Thread Vineet Gupta
Hi Michal, On Thursday 18 June 2015 04:02 PM, Vineet Gupta wrote: > On Thursday 18 June 2015 03:44 PM, Michal Marek wrote: >> Dne 18.6.2015 v 10:45 Vineet Gupta napsal(a): On Thursday 18 June 2015 01:43 PM, Michal Marek wrote: >> Alternatively, as we already have

Re: subtle side effect of commit a1c48bb160f836

2015-06-24 Thread Vineet Gupta
Hi Michal, On Thursday 18 June 2015 04:02 PM, Vineet Gupta wrote: On Thursday 18 June 2015 03:44 PM, Michal Marek wrote: Dne 18.6.2015 v 10:45 Vineet Gupta napsal(a): On Thursday 18 June 2015 01:43 PM, Michal Marek wrote: Alternatively, as we already have CONFIG_CC_OPTIMIZE_FOR_SIZE,

Re: subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Vineet Gupta
On Thursday 18 June 2015 03:44 PM, Michal Marek wrote: > Dne 18.6.2015 v 10:45 Vineet Gupta napsal(a): >> > On Thursday 18 June 2015 01:43 PM, Michal Marek wrote: > Alternatively, as we already have CONFIG_CC_OPTIMIZE_FOR_SIZE, > a(nother) Kconfig option may make sense. >>> >> We

Re: subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Michal Marek
Dne 18.6.2015 v 10:45 Vineet Gupta napsal(a): > On Thursday 18 June 2015 01:43 PM, Michal Marek wrote: Alternatively, as we already have CONFIG_CC_OPTIMIZE_FOR_SIZE, a(nother) Kconfig option may make sense. >> We can also introduce some ARCH_CFLAGS that is appended near the end of >> the

Re: subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Vineet Gupta
+CC Claudiu - ARC gcc guru On Thursday 18 June 2015 02:25 PM, Geert Uytterhoeven wrote: > Hi Vineet, > > On Thu, Jun 18, 2015 at 10:45 AM, Vineet Gupta > wrote: >> On Thursday 18 June 2015 01:43 PM, Michal Marek wrote: > Alternatively, as we already have CONFIG_CC_OPTIMIZE_FOR_SIZE, >

Re: subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Geert Uytterhoeven
Hi Vineet, On Thu, Jun 18, 2015 at 10:45 AM, Vineet Gupta wrote: > On Thursday 18 June 2015 01:43 PM, Michal Marek wrote: >>> > Alternatively, as we already have CONFIG_CC_OPTIMIZE_FOR_SIZE, >>> > a(nother) Kconfig option may make sense. >> We can also introduce some ARCH_CFLAGS that is appended

Re: subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Vineet Gupta
On Thursday 18 June 2015 01:43 PM, Michal Marek wrote: >> > Alternatively, as we already have CONFIG_CC_OPTIMIZE_FOR_SIZE, >> > a(nother) Kconfig option may make sense. > We can also introduce some ARCH_CFLAGS that is appended near the end of > the list, and have arc/Makefile add its -O3 there.

Re: subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Michal Marek
On Thu, Jun 18, 2015 at 09:10:30AM +0200, Geert Uytterhoeven wrote: > Hi Vineet, > > On Thu, Jun 18, 2015 at 8:47 AM, Vineet Gupta > wrote: > > commit a1c48bb160f8368 "Makefile: Fix unrecognized cross-compiler command > > line > > options" moved ARCH specific cc option handling before common

Re: subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Vineet Gupta
On Thursday 18 June 2015 01:07 PM, Geert Uytterhoeven wrote: >>> >> Can we include $(srctree)/arch/$(SRCARCH)/Makefile twice? >> > >> > Something like this would be ideal, but does that not bring back your >> > warnings ? > I don't think so. The warnings were caused by using the host compiler

Re: subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Geert Uytterhoeven
On Thu, Jun 18, 2015 at 9:33 AM, Vineet Gupta wrote: > On Thursday 18 June 2015 12:40 PM, Geert Uytterhoeven wrote: >> On Thu, Jun 18, 2015 at 8:47 AM, Vineet Gupta >> wrote: >>> > commit a1c48bb160f8368 "Makefile: Fix unrecognized cross-compiler command >>> > line >>> > options" moved ARCH

Re: subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Vineet Gupta
On Thursday 18 June 2015 12:40 PM, Geert Uytterhoeven wrote: > On Thu, Jun 18, 2015 at 8:47 AM, Vineet Gupta > wrote: >> > commit a1c48bb160f8368 "Makefile: Fix unrecognized cross-compiler command >> > line >> > options" moved ARCH specific cc option handling before common -Os/O2 setup. >> > >>

Re: subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Geert Uytterhoeven
Hi Vineet, On Thu, Jun 18, 2015 at 8:47 AM, Vineet Gupta wrote: > commit a1c48bb160f8368 "Makefile: Fix unrecognized cross-compiler command line > options" moved ARCH specific cc option handling before common -Os/O2 setup. > > For ARC this had a subtle effect that we can no longer over-ride

subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Vineet Gupta
Hi Geert, commit a1c48bb160f8368 "Makefile: Fix unrecognized cross-compiler command line options" moved ARCH specific cc option handling before common -Os/O2 setup. For ARC this had a subtle effect that we can no longer over-ride generic -O2 with -O3, hence a performance regression observed

subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Vineet Gupta
Hi Geert, commit a1c48bb160f8368 Makefile: Fix unrecognized cross-compiler command line options moved ARCH specific cc option handling before common -Os/O2 setup. For ARC this had a subtle effect that we can no longer over-ride generic -O2 with -O3, hence a performance regression observed going

Re: subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Geert Uytterhoeven
Hi Vineet, On Thu, Jun 18, 2015 at 8:47 AM, Vineet Gupta vineet.gup...@synopsys.com wrote: commit a1c48bb160f8368 Makefile: Fix unrecognized cross-compiler command line options moved ARCH specific cc option handling before common -Os/O2 setup. For ARC this had a subtle effect that we can no

Re: subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Michal Marek
Dne 18.6.2015 v 10:45 Vineet Gupta napsal(a): On Thursday 18 June 2015 01:43 PM, Michal Marek wrote: Alternatively, as we already have CONFIG_CC_OPTIMIZE_FOR_SIZE, a(nother) Kconfig option may make sense. We can also introduce some ARCH_CFLAGS that is appended near the end of the list, and

Re: subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Vineet Gupta
On Thursday 18 June 2015 12:40 PM, Geert Uytterhoeven wrote: On Thu, Jun 18, 2015 at 8:47 AM, Vineet Gupta vineet.gup...@synopsys.com wrote: commit a1c48bb160f8368 Makefile: Fix unrecognized cross-compiler command line options moved ARCH specific cc option handling before common -Os/O2

Re: subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Geert Uytterhoeven
On Thu, Jun 18, 2015 at 9:33 AM, Vineet Gupta vineet.gup...@synopsys.com wrote: On Thursday 18 June 2015 12:40 PM, Geert Uytterhoeven wrote: On Thu, Jun 18, 2015 at 8:47 AM, Vineet Gupta vineet.gup...@synopsys.com wrote: commit a1c48bb160f8368 Makefile: Fix unrecognized cross-compiler command

Re: subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Michal Marek
On Thu, Jun 18, 2015 at 09:10:30AM +0200, Geert Uytterhoeven wrote: Hi Vineet, On Thu, Jun 18, 2015 at 8:47 AM, Vineet Gupta vineet.gup...@synopsys.com wrote: commit a1c48bb160f8368 Makefile: Fix unrecognized cross-compiler command line options moved ARCH specific cc option handling

Re: subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Vineet Gupta
On Thursday 18 June 2015 01:07 PM, Geert Uytterhoeven wrote: Can we include $(srctree)/arch/$(SRCARCH)/Makefile twice? Something like this would be ideal, but does that not bring back your warnings ? I don't think so. The warnings were caused by using the host compiler instead of the

Re: subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Vineet Gupta
On Thursday 18 June 2015 01:43 PM, Michal Marek wrote: Alternatively, as we already have CONFIG_CC_OPTIMIZE_FOR_SIZE, a(nother) Kconfig option may make sense. We can also introduce some ARCH_CFLAGS that is appended near the end of the list, and have arc/Makefile add its -O3 there. But I'd

Re: subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Geert Uytterhoeven
Hi Vineet, On Thu, Jun 18, 2015 at 10:45 AM, Vineet Gupta vineet.gup...@synopsys.com wrote: On Thursday 18 June 2015 01:43 PM, Michal Marek wrote: Alternatively, as we already have CONFIG_CC_OPTIMIZE_FOR_SIZE, a(nother) Kconfig option may make sense. We can also introduce some ARCH_CFLAGS

Re: subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Vineet Gupta
+CC Claudiu - ARC gcc guru On Thursday 18 June 2015 02:25 PM, Geert Uytterhoeven wrote: Hi Vineet, On Thu, Jun 18, 2015 at 10:45 AM, Vineet Gupta vineet.gup...@synopsys.com wrote: On Thursday 18 June 2015 01:43 PM, Michal Marek wrote: Alternatively, as we already have

Re: subtle side effect of commit a1c48bb160f836

2015-06-18 Thread Vineet Gupta
On Thursday 18 June 2015 03:44 PM, Michal Marek wrote: Dne 18.6.2015 v 10:45 Vineet Gupta napsal(a): On Thursday 18 June 2015 01:43 PM, Michal Marek wrote: Alternatively, as we already have CONFIG_CC_OPTIMIZE_FOR_SIZE, a(nother) Kconfig option may make sense. We can also introduce some