Re: [PATCH] apple-gmux: Restore switch registers on suspend/resume

2012-07-29 Thread Andreas Heider
Am 29.07.12 03:18, schrieb David Woodhouse: On Sun, 2012-07-29 at 01:42 +0100, David Woodhouse wrote: If I don't hack it to switch the mux to IGD at boot time, I never manage to get a sane picture out of the Intel device after switching to it. It's late now, but I'll try to get a proper debug lo

[PATCH] regulator: core: Fix argument to _notifier_call_chain call

2012-07-29 Thread Axel Lin
Pass the address of best_val rather than the value of best_val for the third argument to _notifier_call_chain(). This fixes below build warning: CC drivers/regulator/core.o drivers/regulator/core.c: In function '_regulator_do_set_voltage': drivers/regulator/core.c:2183:10: warning: cast to

Re: genirq: Flags mismatch irq 5. 00000000 (ES1688) vs. 00000000

2012-07-29 Thread Takashi Iwai
At Sat, 28 Jul 2012 17:13:53 +0200, Daniel Mack wrote: > > diff --git a/sound/isa/es1688/es1688_lib.c b/sound/isa/es1688/es1688_lib.c > index 1d47be8..7cb309a 100644 > --- a/sound/isa/es1688/es1688_lib.c > +++ b/sound/isa/es1688/es1688_lib.c > @@ -658,18 +658,25 @@ int snd_es1688_create(struct snd

[PATCH] pinctrl-sirf: remove devm_kfree at error path

2012-07-29 Thread Devendra Naga
the pointers that are allocated with devm_kzalloc will be automatically freed, at unload time. Signed-off-by: Devendra Naga --- drivers/pinctrl/pinctrl-sirf.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-sirf.c b/drivers/pinctrl/pinctrl-sirf.c index 2aae8a8..7fca

[PATCH 1/9] KVM: iommu: fix releasing unmapped page

2012-07-29 Thread Xiao Guangrong
There are two bugs: - the 'error page' is forgot to be released [ it is unneeded after commit a2766325cf9f9, for backport, we still do kvm_release_pfn_clean for the error pfn ] - guest pages are always released regardless of the unmapped page (e,g, caused by hwpoison) Signed-off-by: Xiao

[PATCH 2/9] KVM: define kvm_fault_pfn statically

2012-07-29 Thread Xiao Guangrong
After that, the exported and un-inline function, get_fault_pfn, can be removed Signed-off-by: Xiao Guangrong --- arch/x86/kvm/mmu.c |2 +- include/linux/kvm_host.h |3 ++- virt/kvm/kvm_main.c | 12 +++- 3 files changed, 6 insertions(+), 11 deletions(-) diff --git a/

[PATCH 3/9] KVM: define kvm_hwpoison_pfn statically

2012-07-29 Thread Xiao Guangrong
Then, get_hwpoison_pfn and is_hwpoison_pfn can be removed Signed-off-by: Xiao Guangrong --- arch/x86/kvm/mmu.c |2 +- include/linux/kvm_host.h |4 ++-- virt/kvm/kvm_main.c | 13 + 3 files changed, 4 insertions(+), 15 deletions(-) diff --git a/arch/x86/kvm/mmu.c

[PATCH 4/9] KVM: define kvm_bad_pfn statically

2012-07-29 Thread Xiao Guangrong
Then, remove get_bad_pfn Signed-off-by: Xiao Guangrong --- include/linux/kvm_host.h |1 + virt/kvm/kvm_main.c |7 +-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index 4de56cd..b02203f 100644 --- a/include/li

[PATCH 5/9] KVM: inline is_*_pfn functions

2012-07-29 Thread Xiao Guangrong
These functions are exported and can not inline, move them to kvm_host.h to eliminate the overload of function call Signed-off-by: Xiao Guangrong --- include/linux/kvm_host.h | 19 --- virt/kvm/kvm_main.c | 18 -- 2 files changed, 16 insertions(+), 21 del

[PATCH 6/9] KVM: remove the unused declare

2012-07-29 Thread Xiao Guangrong
Remove it since it is not used anymore Signed-off-by: Xiao Guangrong --- include/linux/kvm_host.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index 98255ce..387ecc5 100644 --- a/include/linux/kvm_host.h +++ b/inclu

[PATCH 7/9] KVM: define kvm_bad_page statically

2012-07-29 Thread Xiao Guangrong
It is used to eliminate the overload of function call and cleanup the code Signed-off-by: Xiao Guangrong --- include/linux/kvm_host.h |9 +++-- virt/kvm/async_pf.c |2 +- virt/kvm/kvm_main.c | 13 + 3 files changed, 9 insertions(+), 15 deletions(-) diff --git

[PATCH 8/9] KVM: do not release the error pfn

2012-07-29 Thread Xiao Guangrong
After commit a2766325cf9f9, the error pfn is replaced by the error code, it need not be released anymore [ The patch is compiling tested for powerpc ] Signed-off-by: Xiao Guangrong --- arch/powerpc/kvm/e500_tlb.c |1 - arch/x86/kvm/mmu.c |6 +++--- arch/x86/kvm/mmu_audit.c|

[PATCH 9/9] KVM: do not release the error page

2012-07-29 Thread Xiao Guangrong
After commit a2766325cf9f9, the error page is replaced by the error code, it need not be released anymore [ The patch is compiling tested for powerpc ] Signed-off-by: Xiao Guangrong --- arch/powerpc/kvm/44x_tlb.c |1 - arch/powerpc/kvm/book3s_pr.c |4 +--- arch/x86/kvm/svm.c

[PATCH] staging:net:fixed to fit tty_driver's kref field

2012-07-29 Thread Baodong Chen
Fixed code to fix tty_driver's kref field checkpatch.pl clean up Signed-off-by: Baodong Chen --- drivers/staging/net/pc300_tty.c | 763 --- 1 files changed, 386 insertions(+), 377 deletions(-) diff --git a/drivers/staging/net/pc300_tty.c b/drivers/staging/net

Re: [RFC] netconsole.txt: "nc" needs "-p" to specify the listening port

2012-07-29 Thread Milton Miller
[adding Rob as Doc maintanier] On Sat, 28 Jul 2012 about 11:08:16 -, Dirk Gouders wrote: > Borislav Petkov writes: > > > On Fri, Jul 27, 2012 at 11:24:53AM +0200, Dirk Gouders wrote: > >> Cong Wang writes: > >> > >> > On Fri, Jul 27, 2012 at 2:35 PM, Dirk Gouders > >> > wrote: > >> >> Hi

[git pull] FireWire updates post v3.5

2012-07-29 Thread Stefan Richter
Linus, please pull from the tag "firewire-updates" at git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git firewire-updates to receive the following IEEE 1394 (FireWire) subsystem changes: - Small fixes and optimizations. - A new sysfs attribute to tell local and remote

Re: [net-next RFC V5 4/5] virtio_net: multiqueue support

2012-07-29 Thread Michael S. Tsirkin
On Sat, Jul 21, 2012 at 02:02:58PM +0200, Sasha Levin wrote: > On 07/20/2012 03:40 PM, Michael S. Tsirkin wrote: > >> - err = init_vqs(vi); > >> > +if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) > >> > +vi->has_cvq = true; > >> > + > > How about we disable multiqueue i

Re: [net-next RFC V5 4/5] virtio_net: multiqueue support

2012-07-29 Thread Michael S. Tsirkin
On Mon, Jul 23, 2012 at 01:48:35PM +0800, Jason Wang wrote: > >>+ } > >> > >>- if (virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ)) { > >>+ ret = vi->vdev->config->find_vqs(vi->vdev, total_vqs, vqs, callbacks, > >>+(const char **)names); > >>+ if (ret)

Re: [dm-devel] [PATCH 2/3] Introduce percpu rw semaphores

2012-07-29 Thread Eric Dumazet
On Sun, 2012-07-29 at 01:13 -0400, Mikulas Patocka wrote: > Each cpu should have its own rw semaphore in its cache, so I don't see a > problem there. > > When you change block size, all 4096 rw semaphores are locked for write, > but changing block size is not a performance sensitive operation.

[PATCH] Documentation: update mount option in filesystem/vfat.txt

2012-07-29 Thread Namjae Jeon
update two mount option(discard, nfs) in vfat.txt. Signed-off-by: Namjae Jeon --- Documentation/filesystems/vfat.txt | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/filesystems/vfat.txt b/Documentation/filesystems/vfat.txt index ead764b..dd322a4 100644 --- a/Doc

[PATCH] udf: extent cache implementation for manipulating block map

2012-07-29 Thread Namjae Jeon
From: Namjae Jeon While mapping logical blocks of a file to physical blocks on the partition, everytime UDF read file metadata from the begining which decrease preformance. The drawback of this scheme is more prominent while reading large files. For example, while reading a large file of ~5GB, re

Re: [PATCH V4 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-29 Thread Michael S. Tsirkin
On Sat, Jul 28, 2012 at 10:21:05AM +0800, Asias He wrote: > This patch introduces bio-based IO path for virtio-blk. > > Compared to request-based IO path, bio-based IO path uses driver > provided ->make_request_fn() method to bypasses the IO scheduler. It > handles the bio to device directly witho

Re: [PATCH] staging:net:fixed to fit tty_driver's kref field

2012-07-29 Thread Jiri Slaby
On 07/29/2012 10:40 AM, Baodong Chen wrote: > Fixed code to fix tty_driver's kref field > checkpatch.pl clean up > Signed-off-by: Baodong Chen NACK. Please read Documentation/SubmittingPatches first. This is an unreviewable patch. You do too many diverse changes in one patch. Make your changes s

[PATCH 1/2] pch_phub: fix sparse warning

2012-07-29 Thread Devendra Naga
sparse warns about using 0 as NULL pointer, drivers/misc/pch_phub.c:702:44: warning: Using plain integer as NULL pointer Signed-off-by: Devendra Naga --- drivers/misc/pch_phub.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/pch_phub.c b/drivers/misc/pch_phu

[PATCH 2/2] pch_phub: use module_pci_driver

2012-07-29 Thread Devendra Naga
this driver's pch_phub_pci_init, and pch_phub_pci_exit functions with the module_init and module_exit calls can be replaced with module_pci_driver Signed-off-by: Devendra Naga --- drivers/misc/pch_phub.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/

[PATCH] ext4: add error handling when discard cmd is fail in FITRIM

2012-07-29 Thread Namjae Jeon
Although free extents is proper not trimmed(mmc driver return error code while sending trim command), currently FITRIM ioctl return success. Add exception routine to inform user error code. #> ./fitrim_test end_request: I/O error, dev mmcblk0, sector 27232 EXT4-fs warning (device mmcblk0): ext4_tr

Re: [PATCH] Documentation: update mount option in filesystem/vfat.txt

2012-07-29 Thread OGAWA Hirofumi
Namjae Jeon writes: > update two mount option(discard, nfs) in vfat.txt. Good catch. However, "--" doesn't seem to be aligned. Maybe, you are using the TAB as 4 spaces, or such? Otherwise, looks good to me. > Signed-off-by: Namjae Jeon > --- > Documentation/filesystems/vfat.txt | 11 ++

Re: [PATCH 8/9] KVM: do not release the error pfn

2012-07-29 Thread Xiao Guangrong
kvm_release_pfn_clean in kvm_handle_bad_page() also can be removed, please review this one instead. Changelog: remove kvm_release_pfn_clean in kvm_handle_bad_page() From: Xiao Guangrong Subject: [PATCH 08/21] KVM: do not release the error pfn After commit a2766325cf9f9, the error pfn is rep

[PATCH] es1688 - freeup resources on init failure

2012-07-29 Thread Fengguang Wu
> > err = snd_es1688_init(chip, 1); > > if (err < 0) > > - return err; > > + goto exit_release_dma; > > > > /* Register device */ > > return snd_device_new(card, SNDRV_DEV_LOWLEVEL, chip, &ops); > > + > > +exit_release_dma: > > + free_dma(chip->dma8); > > +ex

Re: [RFC] netconsole.txt: "nc" needs "-p" to specify the listening port

2012-07-29 Thread Dirk Gouders
Milton Miller writes: > [adding Rob as Doc maintanier] > > On Sat, 28 Jul 2012 about 11:08:16 -, Dirk Gouders wrote: >> Borislav Petkov writes: >> >> > On Fri, Jul 27, 2012 at 11:24:53AM +0200, Dirk Gouders wrote: >> >> Cong Wang writes: >> >> >> >> > On Fri, Jul 27, 2012 at 2:35 PM, Dirk

Re: [PATCH] netfilter: PTR_RET can be used

2012-07-29 Thread walter harms
Am 29.07.2012 02:45, schrieb Fengguang Wu: > This quiets the coccinelle warnings: > > net/bridge/netfilter/ebtable_filter.c:107:1-3: WARNING: PTR_RET can be used > net/bridge/netfilter/ebtable_nat.c:107:1-3: WARNING: PTR_RET can be used > net/ipv6/netfilter/ip6table_filter.c:65:1-3: WARNING: PTR

Re: [PATCH] netfilter: PTR_RET can be used

2012-07-29 Thread Fengguang Wu
> > --- linux.orig/net/bridge/netfilter/ebtable_filter.c2012-07-29 > > 08:41:09.703759534 +0800 > > +++ linux/net/bridge/netfilter/ebtable_filter.c 2012-07-29 > > 08:41:14.255759643 +0800 > > @@ -100,9 +100,7 @@ static struct nf_hook_ops ebt_ops_filter > > static int __net_init frame

Re: [PATCH] Documentation: update mount option in filesystem/vfat.txt

2012-07-29 Thread Namjae Jeon
2012/7/29 OGAWA Hirofumi : > Namjae Jeon writes: Hi OGAWA. > >> update two mount option(discard, nfs) in vfat.txt. > > Good catch. > > However, "--" doesn't seem to be aligned. Maybe, you are using the TAB > as 4 spaces, or such? Otherwise, looks good to me. Okay, I will resend after fixing it. Th

Re: [PATCH] net: move "IPv6: sending pkt_too_big to self" to NETDEBUG

2012-07-29 Thread Philipp Kern
On Sat, Jul 28, 2012 at 10:29:20AM -0700, Joe Perches wrote: > On Sat, 2012-07-28 at 17:06 +0200, Philipp Kern wrote: > > ip6_xmit checks if the outgoing packet is larger than the path MTU and > > emits ICMPv6 packet too big locally if this is the case. Logging this, > > even at KERN_DEBUG, confuse

[PATCH v2] Documentation: update mount option in filesystem/vfat.txt

2012-07-29 Thread Namjae Jeon
update two mount options(discard, nfs) in vfat.txt. Signed-off-by: Namjae Jeon --- Documentation/filesystems/vfat.txt | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/filesystems/vfat.txt b/Documentation/filesystems/vfat.txt index ead764b..f643f69 100644 --- a/Do

Re: [PATCH 1/6] rbtree: rb_erase updates and comments

2012-07-29 Thread Michel Lespinasse
On Sat, Jul 28, 2012 at 9:04 PM, George Spelvin wrote: > I was just looking at the beginning of the 2-children case and wondering: > > + /* > +* Old is the node we want to erase. It's got left and right > +* children, which makes things difficult. Let'

Re: rcu: INFO: rcu_preempt detected stalls on CPUs/tasks on v3.6

2012-07-29 Thread Avi Kivity
On 07/27/2012 02:27 PM, Sasha Levin wrote: > On 07/26/2012 01:42 PM, Avi Kivity wrote: >> On 07/24/2012 08:10 PM, Sasha Levin wrote: >>> [ 215.026612] NMI backtrace for cpu 1 >>> [ 215.026612] CPU 1 >>> [ 215.026612] Pid: 2395, comm: pageattr-test Tainted: GW >>> 3.5.0-sasha-01644-g8

Re: appletalk/cops_probe BUG: soft lockup - CPU#1 stuck for 23s!

2012-07-29 Thread Alan Cox
On Sun, 29 Jul 2012 20:40:22 +0800 Fengguang Wu wrote: > Hi, > > This is probably a rather old bug, triggered while doing randconfig > boot tests in kvm: I'm not sure testing old devices with no safe probe method is useful in this context ? Alan -- To unsubscribe from this list: send the line

Re: [PATCH V3 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-29 Thread Michael S. Tsirkin
On Sat, Jul 28, 2012 at 10:38:41AM +0800, Asias He wrote: > On 07/27/2012 08:33 AM, Rusty Russell wrote: > >On Fri, 13 Jul 2012 16:38:51 +0800, Asias He wrote: > >>Add 'virtio_blk.use_bio=1' to kernel cmdline or 'modprobe virtio_blk > >>use_bio=1' to enable ->make_request_fn() based I/O path. > >

Re: appletalk/cops_probe BUG: soft lockup - CPU#1 stuck for 23s!

2012-07-29 Thread Fengguang Wu
On Sun, Jul 29, 2012 at 02:00:03PM +0100, Alan Cox wrote: > On Sun, 29 Jul 2012 20:40:22 +0800 > Fengguang Wu wrote: > > > Hi, > > > > This is probably a rather old bug, triggered while doing randconfig > > boot tests in kvm: > > I'm not sure testing old devices with no safe probe method is use

[BUG] hard LOCKUP occurred multiple times on linux 3.4

2012-07-29 Thread Vladimir Volovich
Hi all, I've got several hard lockups on a system running kernel 3.4-trunk-amd64, from debian package linux-image-3.4-trunk-amd64 version 3.4.1-1~experimental.1 Apparently the lockups happened when opening a gmail page in iceweasel (could possibly be related to google talk plugin, since I saw it

[PATCH] staging:net:fixed to fit tty_driver's kref field

2012-07-29 Thread Baodong Chen
Fixed code to fix tty_driver's kref field Coding style issues Signed-off-by: Baodong Chen --- drivers/staging/net/pc300_tty.c | 123 -- 1 files changed, 65 insertions(+), 58 deletions(-) diff --git a/drivers/staging/net/pc300_tty.c b/drivers/staging/net/pc30

[RFC][PATCH 4/6] sh: TMU: Introduce clocksource/clock events suspend/resume routines

2012-07-29 Thread Rafael J. Wysocki
Introduce suspend/resume routines for SH TMU clock source and clock event device such that if those devices belong to a PM domain, the generic PM domains framework will be notified that the given domain may be turned off (during system suspend) or that it has to be turned on (during system resume)

[RFC][PATCH 3/6] timekeeping: Add suspend and resume of clock event devices

2012-07-29 Thread Rafael J. Wysocki
Some clock event devices, for example such that belong to PM domains, need to be handled in a spcial way during the timekeeping suspend and resume (which takes place in the system core, or "syscore", stages of system power transitions) in analogy with clock sources. Introduce .suspend() and .resu

[RFC][PATCH 1/6] PM / Domains: Introduce simplified power on routine for system resume

2012-07-29 Thread Rafael J. Wysocki
Introduce function pm_genpd_sync_poweron() for restoring domain power during resume from system suspend and hibernation. It can be much simpler than pm_genpd_poweron(), because it doesn't have to care about locking and it can skip many checks done by the latter. Modify pm_genpd_resume_noirq() an

[RFC][PATCH 5/6] sh: CMT: Introduce clocksource/clock events suspend/resume routines

2012-07-29 Thread Rafael J. Wysocki
Introduce suspend/resume routines for SH CMT clock event devices and modify the suspend/resume routines for SH CMT clock sources such that if those devices belong to a PM domain, the generic PM domains framework will be notified that the given domain may be turned off (during system suspend) or th

[RFC][PATCH 6/6] sh: MTU2: Introduce clock events suspend/resume routines

2012-07-29 Thread Rafael J. Wysocki
Introduce suspend/resume routines for SH MTU2 clock event devices such that if those devices belong to a PM domain, the generic PM domains framework will be notified that the given domain may be turned off (during system suspend) or that it has to be turned on (during system resume). Signed-off-b

[RFC][PATCH 0/6] PM: Suspend/resume for clock sources/clock event devices in PM domains

2012-07-29 Thread Rafael J. Wysocki
Hi all, There is a problem with clock sources and clock event devices belonging to PM domains that they have to be marked as "always on", to prevent those domains from being turned off unexpectedly, which also prevents the domains from being turned off during system suspend, although that might be

[RFC][PATCH 2/6] PM / Domains: Add power off/on function for system core suspend stage

2012-07-29 Thread Rafael J. Wysocki
Introduce function pm_genpd_syscore_switch() and two wrappers around it, pm_genpd_syscore_poweroff() and pm_genpd_syscore_poweron(), allowing the callers to let the generic PM domains framework know that the given device is not necessary any more and its PM domain can be turned off (the former) or

Re: [PATCH] es1688 - freeup resources on init failure

2012-07-29 Thread Daniel Mack
On 29.07.2012 13:39, Fengguang Wu wrote: >>> err = snd_es1688_init(chip, 1); >>> if (err < 0) >>> - return err; >>> + goto exit_release_dma; >>> >>> /* Register device */ >>> return snd_device_new(card, SNDRV_DEV_LOWLEVEL, chip, &ops); >>> + >>> +exit_release_d

Re: [PATCH v7 2/2] kvm: KVM_EOIFD, an eventfd for EOIs

2012-07-29 Thread Michael S. Tsirkin
On Tue, Jul 24, 2012 at 02:43:22PM -0600, Alex Williamson wrote: > This new ioctl enables an eventfd to be triggered when an EOI is > written for a specified irqchip pin. The first user of this will > be external device assignment through VFIO, using a level irqfd > for asserting a PCI INTx interr

Re: [PATCH v7 1/2] kvm: Extend irqfd to support level interrupts

2012-07-29 Thread Michael S. Tsirkin
On Tue, Jul 24, 2012 at 02:43:14PM -0600, Alex Williamson wrote: > In order to inject a level interrupt from an external source using an > irqfd, we need to allocate a new irq_source_id. This allows us to > assert and (later) de-assert an interrupt line independently from > users of KVM_IRQ_LINE a

Re: An Andre To Remember

2012-07-29 Thread Stan Hoeppner
On 7/28/2012 7:11 PM, Nicholas A. Bellinger wrote: > On Fri, 2012-07-27 at 13:56 -0400, Jeff Garzik wrote: >> An Andre To Remember >> July 2012 >> >> Linux lost a friend and advocate this month. Though never a household >> name, Andre Hedrick had a positive impact on everyone today runni

Re: [PATCH V1 3/3] OMAP: Define TCA6424 max number of possible IRQs

2012-07-29 Thread Linus Walleij
On Sat, Jul 28, 2012 at 8:10 AM, Chandrabhanu Mahapatra wrote: > From: Leed Aguilar > > TCA6424 being a 24 bit I2C and SMBus I/O expander has 24 available GPIO lines > that can be used as IRQs lines. So, the support for 24 more IRQ lines has been > added to the kernel. > > Signed-off-by: Leed Ag

Re: [PATCH] gpio-sch: Fix leak of resource

2012-07-29 Thread Linus Walleij
On Tue, Jul 24, 2012 at 2:55 PM, Alan Cox wrote: > From: Alan Cox > > Signed-off-by: Alan Cox > --- > > drivers/gpio/gpio-sch.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-sch.c b/drivers/gpio/gpio-sch.c > index 424dce8..8707d45 100644 > ---

Re: [PATCHv3] locks: prevent side-effects of locks_release_private before file_lock is initialized

2012-07-29 Thread J. Bruce Fields
On Fri, Jul 27, 2012 at 04:45:52PM -0400, J. Bruce Fields wrote: > On Fri, Jul 27, 2012 at 12:42:52AM -0400, Filipe Brandenburger wrote: > > When calling fcntl(fd, F_SETLEASE, lck) [with lck=F_WRLCK or F_RDLCK], > > the custom signal or owner (if any were previously set using F_SETSIG > > or F_SETO

Re: [RFC PATCH v2 04/32] PCI: add PCIe capabilities access functions to hide differences among PCIe specs

2012-07-29 Thread Jiang Liu
On 07/25/2012 05:12 AM, Don Dutile wrote: > On 07/24/2012 12:31 PM, Jiang Liu wrote: >> +int pci_pcie_capability_read_word(struct pci_dev *dev, int pos, u16 *val) >> +{ >> +int ret = 0; >> + >> +*val = 0; >> +if (pos& 1) >> +return -EINVAL; >> + >> +if (pci_pcie_capability_

Re: [PATCH v2] gpio: Add Avionic Design N-bit GPIO expander support

2012-07-29 Thread Linus Walleij
On Mon, Jul 23, 2012 at 1:59 PM, Thierry Reding wrote: > This commit adds a driver for the Avionic Design N-bit GPIO expander. > The expander provides a variable number of GPIO pins with interrupt > support. (...) > diff --git a/Documentation/devicetree/bindings/gpio/gpio-adnp.txt > b/Documentat

[PATCH 1/2] lp8727_charger: free_irq when lp8727_register_psy fail

2012-07-29 Thread Devendra Naga
actually the driver does a request_threaded_irq and after this it calls lp8727_register_psy, and if it fails it doesn't free the irqs that it registered to Signed-off-by: Devendra Naga --- drivers/power/lp8727_charger.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dr

[PATCH 2/2] lp8727_charger: unregister power supply at error path of lp8727_register_psy

2012-07-29 Thread Devendra Naga
if usb power supply registration fails, we wont unregister the ac power supply if battery power supply registration fails, we wont unregister the usb, and ac supply, take care of those things and also no need of goto -err_mem: at the fail case of kzalloc simply can have return -ENO

[PATCH 0/14] uprobes: acked patches

2012-07-29 Thread Oleg Nesterov
Hello. Re-send. No changes, just added the acks from Srikar. "uprobes: mmap_region() corrupts mm->mm_rb if uprobe_mmap() fails" I sent yesterday doesn't depend on this series, it can go ahead to fix the serious problem. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-ke

[PATCH 02/14] uprobes: __replace_page() should not use page_address_in_vma()

2012-07-29 Thread Oleg Nesterov
page_address_in_vma(old_page) in __replace_page() is ugly and wrong. The caller already knows the correct virtual address, this page was found by get_user_pages(vaddr). However, page_address_in_vma() can actually fail if page->mapping was cleared by __delete_from_page_cache() after get_user_pages(

[PATCH 01/14] uprobes: don't recheck vma/f_mapping in write_opcode()

2012-07-29 Thread Oleg Nesterov
write_opcode() rechecks valid_vma() and ->f_mapping, this is pointless. The caller, register_for_each_vma() or uprobe_mmap(), has already done these checks under mmap_sem. To clarify, uprobe_mmap() checks valid_vma() only, but we can rely on build_probe_list(vm_file->f_mapping->host). Signed-off-

[PATCH 04/14] uprobes: cleanup and document write_opcode()->lock_page(old_page)

2012-07-29 Thread Oleg Nesterov
The comment above write_opcode()->lock_page(old_page) tells about the race with do_wp_page(). I don't really understand which exactly race it means, but afaics this lock_page() was not enough to close all races with do_wp_page(). Anyway, since 77fc4af1 this code is always called with ->mmap_sem ho

[PATCH 06/14] uprobes: suppress uprobe_munmap() from mmput()

2012-07-29 Thread Oleg Nesterov
uprobe_munmap() does get_user_pages() and it is also called from the final mmput()->exit_mmap() path. This slows down exit/mmput() for no reason, and I think it is simply dangerous/wrong to try to fault-in a page into the dying mm. If nothing else, this happens after the last sync_mm_rss(), afaics

[PATCH 08/14] uprobes: kill copy_vma()->uprobe_mmap()

2012-07-29 Thread Oleg Nesterov
Kill copy_vma()->uprobe_mmap(new_vma), it is absolutely wrong. This new_vma was just initialized to represent the new unmapped area, [vm_start, vm_end) was returned by get_unmapped_area() in the caller. This means that uprobe_mmap()->get_user_pages() will fail for sure, simply because find_vma()

[PATCH 11/14] uprobes: introduce vaddr_to_offset(vma, vaddr)

2012-07-29 Thread Oleg Nesterov
Add the new helper, vaddr_to_offset(vma, vaddr) which returns the offset in vma->vm_file this vaddr is mapped at. Change build_probe_list() and find_active_uprobe() to use the new helper, the next patch adds another user. Signed-off-by: Oleg Nesterov Acked-by: Srikar Dronamraju --- kernel/even

[PATCH 12/14] uprobes: fix register_for_each_vma()->vma_address() check

2012-07-29 Thread Oleg Nesterov
1. register_for_each_vma() checks that vma_address() == vaddr but this is not enough. We should also ensure that vaddr >= vm_start, find_vma() guarantees "vaddr < vm_end" only. 2. After the prevous changes, register_for_each_vma() is the only reason why vma_address() has to return loff_t,

[PATCH 13/14] uprobes: rename vma_address() and make it return "unsigned long"

2012-07-29 Thread Oleg Nesterov
1. vma_address() returns loff_t, this looks confusing and this is unnecessary after the previous change. Make it return "ulong", all callers truncate the result anyway. 2. Its name conflicts with mm/rmap.c:vma_address(), rename it to offset_to_vaddr(), this matches vaddr_to_offset(). Sig

[PATCH 14/14] uprobes: __replace_page() needs munlock_vma_page()

2012-07-29 Thread Oleg Nesterov
Like do_wp_page(), __replace_page() should do munlock_vma_page() for the case when the old page still has other !VM_LOCKED mappings. Unfortunately this needs mm/internal.h. Also, move put_page() outside of ptl lock. This doesn't really matter but looks a bit better. Signed-off-by: Oleg Nesterov

[PATCH 09/14] uprobes: kill insert_vm_struct()->uprobe_mmap()

2012-07-29 Thread Oleg Nesterov
Kill insert_vm_struct()->uprobe_mmap(). It is not needed, nobody except arch/ia64/kernel/perfmon.c uses insert_vm_struct(vma) with vma->vm_file != NULL. And it is wrong. Again, get_user_pages() can not succeed before vma_link(vma) makes is visible to find_vma(). And even if this worked, we must no

[PATCH 10/14] uprobes: teach build_probe_list() to consider the range

2012-07-29 Thread Oleg Nesterov
Currently build_probe_list() builds the list of all uprobes attached to the given inode, and the caller should filter out those who don't fall into the [start,end) range, this is sub-optimal. This patch turns find_least_offset_node() into find_node_in_range() which returns the first node inside th

[PATCH 05/14] uprobes: uprobe_mmap/munmap needs list_for_each_entry_safe()

2012-07-29 Thread Oleg Nesterov
The bug was introduced by me in 449d0d7c "uprobes: Simplify the usage of uprobe->pending_list". Yes, we do not care about uprobe->pending_list after return and nobody can remove the current list entry, but put_uprobe(uprobe) can actually free it and thus we need list_for_each_safe(). Reported-by:

[PATCH 07/14] uprobes: fix overflow in vma_address/find_active_uprobe

2012-07-29 Thread Oleg Nesterov
vma->vm_pgoff is "unsigned long", it should be promoted to loff_t before the multiplication to avoid the overflow. Signed-off-by: Oleg Nesterov Acked-by: Srikar Dronamraju --- kernel/events/uprobes.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/events/uprob

[PATCH 03/14] uprobes: kill write_opcode()->lock_page(new_page)

2012-07-29 Thread Oleg Nesterov
write_opcode() does lock_page(new_page) for no reason. Nobody can see this page until __replace_page() exposes it under ptl lock, and we do nothing with this page after pte_unmap_unlock(). If nothing else, the similar code in do_wp_page() doesn't lock the new page for page_add_new_anon_rmap/set_pt

Re: [dm-devel] [PATCH 2/3] Introduce percpu rw semaphores

2012-07-29 Thread Eric Dumazet
On Sun, 2012-07-29 at 12:10 +0200, Eric Dumazet wrote: > You can probably design something needing no more than 4 bytes per cpu, > and this thing could use non locked operations as bonus. > > like the following ... Coming back from my bike ride, here is a more polished version with proper synchr

[PATCH V3 0/3] PNP: Allow PNP resources to be disabled (interface)

2012-07-29 Thread Witold Szczeponik
Hello everybody, this simple patch series continues the work begun in commit 18fd470a48396c8795ba7256c5973e92ffa25cb3 where ACPI PNP resource templates with empty/disabled resources are handled. The aim of this patch series is to allow to set resources as "disabled" using the "/sys/bus/pnp/

[PATCH V3 1/3] PNP: Simplify setting of resources

2012-07-29 Thread Witold Szczeponik
This patch factors out the setting of PNP resources into one function which is then reused for all PNP resource types. This makes the code more concise and avoids duplication. The parameters "type" and "flags" are not used at the moment but will be used by follow-up patches. Placeholders for t

[PATCH V3 2/3] PNP: Allow resources to be set as disabled

2012-07-29 Thread Witold Szczeponik
This patch allows to set PNP resources as "disabled". As such, the patch is a follow-up to commit 18fd470a48396c8795ba7256c5973e92ffa25cb3 where parsing of ACPI PNP resources that can be disabled was made possible. The patch achieves this by allowing the strings "disabled" and "" to be used as

Re: [PATCH v2] Documentation: update mount option in filesystem/vfat.txt

2012-07-29 Thread OGAWA Hirofumi
Namjae Jeon writes: > update two mount options(discard, nfs) in vfat.txt. Thanks. Acked-by: OGAWA Hirofumi > Signed-off-by: Namjae Jeon > --- > Documentation/filesystems/vfat.txt | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/filesystems/vfat.txt > b/

[PATCH V3 3/3] PNP: Handle IORESOURCE_BITS in resource allocation

2012-07-29 Thread Witold Szczeponik
The patch copies the flags masked by IORESOURCE_BITS from a resource's template. This is necessary because the resource settings require proper IORESOURCE_BITS which are not known during the definition of these resources using the "/sys/bus/pnp/*/*/resources" interface. (In fact, they should no

Re: [PATCH] apple-gmux: Restore switch registers on suspend/resume

2012-07-29 Thread David Woodhouse
On Sun, 2012-07-29 at 09:46 +0200, Andreas Heider wrote: > Am 29.07.12 03:18, schrieb David Woodhouse: > > On Sun, 2012-07-29 at 01:42 +0100, David Woodhouse wrote: > >> If I don't hack it to switch the mux to IGD at boot time, I never manage > >> to get a sane picture out of the Intel device after

Re: [PATCH V3 0/3] PNP: Allow PNP resources to be disabled (interface)

2012-07-29 Thread Rafael J. Wysocki
Hi, On Sunday, July 29, 2012, Witold Szczeponik wrote: > Hello everybody, > > this simple patch series continues the work begun in commit > 18fd470a48396c8795ba7256c5973e92ffa25cb3 where ACPI PNP resource templates > with empty/disabled resources are handled. > > The aim of this patch serie

Re: [PATCH V3 0/3] PNP: Allow PNP resources to be disabled (interface)

2012-07-29 Thread Witold Szczeponik
On 29/07/12 21:22, Rafael J. Wysocki wrote: > Hi, > [... long snip ...] > > Do I understand correctly that you want to disable those things through > sysfs? > > Rafael > Hi Rafael, the aim is to select a PNP ACPI option where resources can be disabled (or are not needed). E.g., the paral

Re: [PATCH] apple-gmux: Restore switch registers on suspend/resume

2012-07-29 Thread Andreas Heider
Am 29.07.12 21:05, schrieb David Woodhouse: On Sun, 2012-07-29 at 09:46 +0200, Andreas Heider wrote: Am 29.07.12 03:18, schrieb David Woodhouse: On Sun, 2012-07-29 at 01:42 +0100, David Woodhouse wrote: If I don't hack it to switch the mux to IGD at boot time, I never manage to get a sane pict

Re: [PATCH] staging:net:fixed to fit tty_driver's kref field

2012-07-29 Thread Sam Ravnborg
On Sun, Jul 29, 2012 at 10:06:32PM +0800, Baodong Chen wrote: > Fixed code to fix tty_driver's kref field > Coding style issues > > Signed-off-by: Baodong Chen Hi Baodong. As already pointed out by Jiri please split this up in several patches. [PATCH 1/x] staging:net:pc300: fix white space usa

Re: [PATCH] apple-gmux: Restore switch registers on suspend/resume

2012-07-29 Thread Matthew Garrett
Working: Modeline 10:"1920x1200" 60 154000 1920 1968 2000 2080 1200 1203 1209 1235 0x48 0xa Broken: Modeline 20:"1280x800" 60 72500 1280 1328 1360 1423 800 803 809 846 0x8 0xa And it looks like intel_lvds->edid is only set during intel_lvds_init(). That seems less than ideal. How about somethin

[PATCH 1/9] drivers/usb/host/ehci-atmel.c: use devm_ functions

2012-07-29 Thread Julia Lawall
From: Julia Lawall The various devm_ functions allocate memory that is released when a driver detaches. This patch uses these functions for data that is allocated in the probe function of a platform device and is only freed in the remove function. Signed-off-by: Julia Lawall --- Not compiled.

[PATCH] use devm_ functions

2012-07-29 Thread Julia Lawall
The semantic patch (http://coccinelle.lip6.fr/) used in generating this patch is as follows. Some manual cleanup may be required. This improves on the previous version in that more devm functions are treated. virtual after_start virtual returned virtual returnedDup virtual arg virtual all_args v

[PATCH 4/9] drivers/usb/host/ehci-grlib.c: use devm_ functions

2012-07-29 Thread Julia Lawall
From: Julia Lawall The various devm_ functions allocate memory that is released when a driver detaches. This patch uses these functions for data that is allocated in the probe function of a platform device and is only freed in the remove function. Signed-off-by: Julia Lawall --- Not compiled.

[PATCH 5/9] drivers/usb/host/ehci-ixp4xx.c: use devm_ functions

2012-07-29 Thread Julia Lawall
From: Julia Lawall The various devm_ functions allocate memory that is released when a driver detaches. This patch uses these functions for data that is allocated in the probe function of a platform device and is only freed in the remove function. Signed-off-by: Julia Lawall --- Not compiled.

[PATCH 2/9] drivers/usb/host/ehci-au1xxx.c: use devm_ functions

2012-07-29 Thread Julia Lawall
From: Julia Lawall The various devm_ functions allocate memory that is released when a driver detaches. This patch uses these functions for data that is allocated in the probe function of a platform device and is only freed in the remove function. Signed-off-by: Julia Lawall --- Not compiled.

[PATCH 6/9] drivers/usb/host/ehci-ls1x.c: use devm_ functions

2012-07-29 Thread Julia Lawall
From: Julia Lawall The various devm_ functions allocate memory that is released when a driver detaches. This patch uses these functions for data that is allocated in the probe function of a platform device and is only freed in the remove function. Signed-off-by: Julia Lawall --- Not compiled.

[PATCH 7/9] drivers/usb/host/ehci-msm.c: use devm_ functions

2012-07-29 Thread Julia Lawall
From: Julia Lawall The various devm_ functions allocate memory that is released when a driver detaches. This patch uses these functions for data that is allocated in the probe function of a platform device and is only freed in the remove function. The original code was also missing a call to io

[PATCH 8/9] drivers/usb/host/ehci-mv.c: use devm_ functions

2012-07-29 Thread Julia Lawall
From: Julia Lawall The various devm_ functions allocate memory that is released when a driver detaches. This patch uses these functions for data that is allocated in the probe function of a platform device and is only freed in the remove function. A new label name is created in one case to bett

[PATCH 9/9] drivers/usb/host/ehci-mxc.c: use devm_ functions

2012-07-29 Thread Julia Lawall
From: Julia Lawall The various devm_ functions allocate memory that is released when a driver detaches. This patch uses these functions for data that is allocated in the probe function of a platform device and is only freed in the remove function. Signed-off-by: Julia Lawall --- Not compiled.

[PATCH 3/9] drivers/usb/host/ehci-cns3xxx.c: use devm_ functions

2012-07-29 Thread Julia Lawall
From: Julia Lawall The various devm_ functions allocate memory that is released when a driver detaches. This patch uses these functions for data that is allocated in the probe function of a platform device and is only freed in the remove function. Signed-off-by: Julia Lawall --- Not compiled.

Re: drm/nouveau: crash regression in 3.5

2012-07-29 Thread Marcin Slusarz
On Thu, Jul 26, 2012 at 02:56:22PM +0200, Ortwin Glück wrote: > On 25.07.2012 20:42, Marcin Slusarz wrote: > > Good, below patch should fix this panic. > > > > Note that you can hit an oops in drm_handle_vblank because patch from > > http://lists.freedesktop.org/archives/dri-devel/2012-May/023498.h

Re: [PATCH 1/7] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-07-29 Thread Mark Brown
On Fri, Jul 27, 2012 at 01:38:48PM +0100, Lee Jones wrote: > If a list of widgets is provided and one of them fails to be added as > a control, the present semantics fail all subsequent widgets. A better > solution would be to only fail that widget, but pursue in attempting > to add the rest of the

Re: [PATCH v2] gpio: Add Avionic Design N-bit GPIO expander support

2012-07-29 Thread Arnd Bergmann
On Sunday 29 July 2012, Linus Walleij wrote: > > +- #interrupt-cells: Should be 2. The first cell contains the GPIO number, > > + whereas the second cell is used to specify flags: > > +bits[3:0] trigger type and level flags > > + 1 = low-to-high edge triggered > > + 2 = high-to-low e

  1   2   3   >