linux-next: build failure after merge of the akpm tree

2012-09-26 Thread Stephen Rothwell
Hi Andrew, After merging the akpm tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: net/key/af_key.c: In function 'pfkey_add': net/key/af_key.c:1476:9: error: implicit declaration of function 'audit_get_sessionid' [-Werror=implicit-function-declaration] net/core/dev.c:

[PATCH] staging:vt6656: Fix tabs error in 80211mgr.c

2012-09-26 Thread Ilya gorskin
This is a patch to the 80211mgr.c file that fixes up a tabs error found by the checkpatch.pl tool Signed-off-by: Goirskin Ilya reven...@gmail.com --- drivers/staging/vt6656/80211mgr.c | 628 +++--- 1 file changed, 310 insertions(+), 318 deletions(-) diff --git

Re: [PATCH] pagemap: fix wrong KPF_THP on slab pages

2012-09-26 Thread Naoya Horiguchi
On Wed, Sep 26, 2012 at 12:02:34AM -0400, Naoya Horiguchi wrote: ... + * page is a thp, not a non-huge compound page. + */ + else if (PageTransCompound(page) !PageSlab(page)) u |= 1 KPF_THP; Good catch! Will this report THP for the various drivers that do

Re: [PATCH] media: mt9p031/mt9t001/mt9v032: use V4L2_CID_TEST_PATTERN for test pattern control

2012-09-26 Thread Prabhakar Lad
Hi Laurent, Thanks for the review. On Tue, Sep 25, 2012 at 9:30 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Prabhakar, Thank you for the patch. On Tuesday 25 September 2012 18:29:25 Prabhakar wrote: From: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Lad,

[PATCH] CMA: migrate mlocked page

2012-09-26 Thread Minchan Kim
Now CMA can't migrate mlocked page so it ends up fail to allocate contiguous memory space. It's not good for CMA. This patch makes mlocked page be migrated out. Of course, it can affect realtime processes but in CMA usecase, contiguos memory allocation failing is far worse than access latency to

[PATCH] x86_64: Work around old gas bug

2012-09-26 Thread Tao Guo
gas in binutils(2.16.91) could not parse parentheses within macro parameters, and this is a workaround to make old gas work without generating below errors: arch/x86/kernel/entry_64.S: Assembler messages: arch/x86/kernel/entry_64.S:387: Error: too many positional arguments

[PATCH v2] media: mt9p031/mt9t001/mt9v032: use V4L2_CID_TEST_PATTERN for test pattern control

2012-09-26 Thread Prabhakar
From: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: Sakari Ailus sakari.ai...@iki.fi Cc: Paul Gortmaker paul.gortma...@windriver.com Cc: Jean

Re: [PATCH v4 5/5] MFD: ti_tscadc: add suspend/resume functionality

2012-09-26 Thread Shubhrajyoti
On Wednesday 26 September 2012 10:50 AM, Patil, Rachna wrote: This patch adds support for suspend/resume of TSC/ADC MFDevice. this should be merged with the patch adding support else we may end up in a case where patch a does the runtime calls and the call back handlers added later.

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-26 Thread Inderpal Singh
On 25 September 2012 18:47, Jassi Brar jassisinghb...@gmail.com wrote: On Tue, Sep 25, 2012 at 2:27 PM, Inderpal Singh inderpal.si...@linaro.org wrote: Since peripheral channel resources are not being allocated at probe, no need to flush the channels and free the resources in remove function.

Re: [PATCHv1 6/6] MAINTAINERS: add recently created files to dw_dmac section

2012-09-26 Thread Andy Shevchenko
On Tue, 2012-09-25 at 09:57 -0700, Joe Perches wrote: On Tue, 2012-09-25 at 16:37 +0300, Andy Shevchenko wrote: On Tue, 2012-09-25 at 06:19 -0700, Joe Perches wrote: You also added yourself as a maintainer. Congrats/sympathies, etc... Actually I prefer to be just a supporter, because

Re: [PATCH V2] GPIO: gpio-pxa: fix bug when get gpio value

2012-09-26 Thread Haojian Zhuang
On Wed, Sep 26, 2012 at 9:46 AM, Neil Zhang zhan...@marvell.com wrote: We need to return 0 or 1 when get gpio value. Signed-off-by: Neil Zhang zhan...@marvell.com --- drivers/gpio/gpio-pxa.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/gpio/gpio-pxa.c

Re: [PATCH] x86/fixup_irq: Clean the offlining CPU from the irq affinity mask

2012-09-26 Thread Srivatsa S. Bhat
On 09/26/2012 08:02 PM, Chuansheng Liu wrote: When one CPU is going offline, and fixup_irqs() will re-set the irq affinity in some cases, we should clean the offlining CPU from the irq affinity. The reason is setting offlining CPU as of the affinity is useless. Moreover, the smp_affinity

[PATCH] CMA: decrease cc.nr_migratepages after reclaiming pagelist

2012-09-26 Thread Minchan Kim
The reclaim_clean_pages_from_list reclaims clean pages before migration so cc.nr_migratepages should be updated. Currently, there is no problem but it can be wrong if we try to use the vaule in future. Cc: Mel Gorman mgor...@suse.de Cc: Michal Nazarewicz min...@mina86.com Cc: Bartlomiej

Re: [PATCHv1 2/6] dmaengine: dw_dmac: add driver for Atmel AT32

2012-09-26 Thread Andy Shevchenko
On Wed, 2012-09-26 at 09:20 +0530, viresh kumar wrote: On Tue, Sep 25, 2012 at 5:43 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: From: Heikki Krogerus heikki.kroge...@linux.intel.com This driver should be usable on all platforms that depend on clk API. This is not what

Re: [PATCH] staging:vt6656: Fix tabs error in 80211mgr.c

2012-09-26 Thread Dan Carpenter
On Wed, Sep 26, 2012 at 12:05:11PM +0600, Ilya gorskin wrote: This is a patch to the 80211mgr.c file that fixes up a tabs error found by the checkpatch.pl tool Signed-off-by: Goirskin Ilya reven...@gmail.com --- drivers/staging/vt6656/80211mgr.c | 628

Re: [PATCHv1 2/6] dmaengine: dw_dmac: add driver for Atmel AT32

2012-09-26 Thread viresh kumar
On Wed, Sep 26, 2012 at 12:17 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: This separate driver makes no sense in case it is built properly without CLK framework. Let me check this and leave comments at patch 1/6. Following is the commit that introduced this change :) commit

RE: [PATCH] x86/fixup_irq: Clean the offlining CPU from the irq affinity mask

2012-09-26 Thread Liu, Chuansheng
+ } else if (cpumask_test_cpu(cpu, data-affinity)) + cpumask_clear_cpu(cpu, data-affinity); You meant to use 'affinity' (instead of data-affinity) in the above 2 statements right? Note that we do chip-irq_set_affinity(data, affinity, true); further down.

Re: [QUESTION] Can uprobe_event support @ADDR, $retval, offs(FETCHARG)?

2012-09-26 Thread Hyeoncheol Lee
Hi, 2012/9/26 Masami Hiramatsu masami.hiramatsu...@hitachi.com: (2012/09/26 11:52), Hyeoncheol Lee wrote: Hi, uprobe_event only supports %REG arguments. I think that memory fetch, return value fetch, memory dereference functions in kernel/trace/trace_probe.c are good for uprobe_event. So

Re: [PATCHv1 2/6] dmaengine: dw_dmac: add driver for Atmel AT32

2012-09-26 Thread Andy Shevchenko
On Wed, Sep 26, 2012 at 9:51 AM, viresh kumar viresh.ku...@linaro.org wrote: On Wed, Sep 26, 2012 at 12:17 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: This separate driver makes no sense in case it is built properly without CLK framework. Let me check this and leave comments

Re: [GIT PULL 0/2] perf/core fixes

2012-09-26 Thread Ingo Molnar
* Arnaldo Carvalho de Melo a...@infradead.org wrote: Hi Ingo, Please consider pulling, on top of the previous req, - Arnaldo The following changes since commit b1ac754b67b5a875d63bee880f60ccb0c6bd8899: tools lib traceevent: Handle alloc_arg failure (2012-09-24 12:31:52

Re: [PATCH RESEND] gpio-lpc32xx: Fix value handling of gpio_direction_output()

2012-09-26 Thread Linus Walleij
On Tue, Sep 25, 2012 at 9:53 AM, Roland Stigge sti...@antcom.de wrote: For GPIOs of gpio-lpc32xx, gpio_direction_output() ignores the value argument (initial value of output). This patch fixes this by setting the level accordingly. Signed-off-by: Roland Stigge sti...@antcom.de Acked-by:

Re: [QUESTION] Can uprobe_event support @ADDR, $retval, offs(FETCHARG)?

2012-09-26 Thread Hyeoncheol Lee
2012/9/26 Srikar Dronamraju sri...@linux.vnet.ibm.com: Perhaps, it is not so small things, but at least, we can try. In the userspace, memories(pages) can be paged out on swap or files. In that case, memory dereference function needs to track down the data on the disk and it causes I/O. This

Re: [PATCHv1 5/6] MAINTAINERS: fix indentation for Viresh Kumar

2012-09-26 Thread Andy Shevchenko
On Wed, 2012-09-26 at 09:06 +0530, viresh kumar wrote: On Tue, Sep 25, 2012 at 5:43 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Viresh Kumar viresh.li...@gmail.com --- MAINTAINERS | 16

Re: [PATCH] x86_64: Work around old gas bug

2012-09-26 Thread Jan Beulich
On 26.09.12 at 08:15, Tao Guo glorious...@gmail.com wrote: gas in binutils(2.16.91) could not parse parentheses within macro parameters, This description of yours contradicts the last hunk of the patch - iirc the requirement for macro parameters in those old gas versions is to be fully

[BISECTED] snd-hda-intel audio distortion in Linus' current tree

2012-09-26 Thread Steven Noonan
Started having audio problems when trying out the latest tree (v3.6-rc7-10-g56d27ad). When playing any kind of audio, there was significant distortion, mostly crackling noise. I'm using a Lenovo ThinkPad X230 (Panther Point). I did a git-bisect to locate the problem, and it seems this commit is

Re: [PATCH] pagemap: fix wrong KPF_THP on slab pages

2012-09-26 Thread Fengguang Wu
On Wed, Sep 26, 2012 at 02:06:08AM -0400, Naoya Horiguchi wrote: On Wed, Sep 26, 2012 at 12:02:34AM -0400, Naoya Horiguchi wrote: ... +* page is a thp, not a non-huge compound page. +*/ + else if (PageTransCompound(page) !PageSlab(page)) u

Re: Out of memory on 3.5 kernels

2012-09-26 Thread Nico Schottelius
David Rientjes [Mon, Sep 24, 2012 at 03:43:27PM -0700]: [...] And those objects are consuming ~2.3GB of slab on your 4GB machine and seems to only have occurred between v3.4.2 to v3.5.3. It would be interesting to see what kmemleak would tell us. As the Archlinux kernel does not

Re: Out of memory on 3.5 kernels

2012-09-26 Thread Nico Schottelius
Good morning, Dave Kleikamp [Tue, Sep 25, 2012 at 10:07:14AM -0500]: Active / Total Objects (% used): 1165130 / 1198087 (97.2%) Active / Total Slabs (% used) : 81027 / 81027 (100.0%) Active / Total Caches (% used) : 69 / 101 (68.3%) Active / Total Size (% used) :

Re: [PATCH] perf record: add meta-data support for pipe-mode

2012-09-26 Thread Stephane Eranian
On Wed, Sep 26, 2012 at 7:50 AM, David Ahern dsah...@gmail.com wrote: I like the idea, but can't checkout the patch - does not apply to Arnaldo's latest perf/core branch. mind rebasing? It's against tip-master. David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in

Re: [PATCHv1 3/6] dmaengine: dw_dmac: Add PCI part of the driver

2012-09-26 Thread Andy Shevchenko
On Wed, 2012-09-26 at 09:30 +0530, viresh kumar wrote: On Tue, Sep 25, 2012 at 5:43 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: diff --git a/drivers/dma/dw_dmac_at32.c b/drivers/dma/dw_dmac_at32.c index 7bc7ac4..5c9180e 100644 --- a/drivers/dma/dw_dmac_at32.c +++

RE: [PATCH 1/3] virtio_console:Merge struct buffer_token into struct port_buffer

2012-09-26 Thread Sjur BRENDELAND
This merge reduces code size by unifying the approach for sending scatter-lists and regular buffers. Any type of write operation (splice, write, put_chars) will now allocate a port_buffer and send_buf() and free_buf() can always be used. Thanks! This looks much nicer and simpler. I

[PATCH] MAINTAINERS: fix indentation for Viresh Kumar

2012-09-26 Thread Viresh Kumar
From: Andy Shevchenko andriy.shevche...@linux.intel.com Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Viresh Kumar viresh.ku...@linaro.org --- MAINTAINERS | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH 10/16] perf report: Make another loop for output resorting

2012-09-26 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com Now the event grouping viewing requires collapsing all members in a group to the leader. Thus hists__output_resort should be called after collapsing all entries in evlist. Cc: Jiri Olsa jo...@redhat.com Cc: Stephane Eranian eran...@google.com

[PATCH 02/16] perf hists: Introduce struct he_stat

2012-09-26 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com The struct he_stat is for separating out statistics data of a hist entry. It is required for later changes. It's just a mechanical change and should have no functional differences. Cc: Jiri Olsa jo...@redhat.com Cc: Arun Sharma asha...@fb.com Cc:

[PATCH 05/16] perf tools: Keep group information

2012-09-26 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com Add a few of group-related field in struct perf_{evlist,evsel} so that the group information in a evlist can be known easily. Cc: Jiri Olsa jo...@redhat.com Cc: Stephane Eranian eran...@google.com Signed-off-by: Namhyung Kim namhy...@kernel.org ---

Re: [PATCH V2 1/1] perf, Add support for Xeon-Phi PMU

2012-09-26 Thread Ingo Molnar
* Cyrill Gorcunov gorcu...@openvz.org wrote: On Tue, Sep 25, 2012 at 12:23:23PM -0400, Vince Weaver wrote: Hello This is an updated version of the patch. It uses ARCH_PERFMON_EVENTSEL_INT for the DATA_READ event, with the assumption that x86_pmu_hw_config() is going to set that bit

[PATCH 16/16] perf report: Add --group option

2012-09-26 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com Add --group option to enable event grouping. When enabled, all the group members information will be shown together with the leader. Cc: Jiri Olsa jo...@redhat.com Cc: Stephane Eranian eran...@google.com Signed-off-by: Namhyung Kim namhy...@kernel.org ---

[PATCH 15/16] perf report: Show group description when event group is enabled

2012-09-26 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com When using event group viewer, it's better to show the group description rather than the leader information alone. If a leader did not contain any member, it's a non-group event. Cc: Jiri Olsa jo...@redhat.com Cc: Stephane Eranian eran...@google.com Cc:

[PATCH 04/16] perf hists: Add more helpers for hist entry stat

2012-09-26 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com Add and use he_stat__add_{period,stat} for calculating hist entry's stat. It will be used for accumulated stats later as well. Cc: Jiri Olsa jo...@redhat.com Cc: Arun Sharma asha...@fb.com Cc: Stephane Eranian eran...@google.com Cc: Frederic Weisbecker

[PATCH 03/16] perf hists: Move he-stat.nr_events initialization to a template

2012-09-26 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com Since it is set to 1 for a new hist entry, no need to set to separately. Move it to a template entry. Cc: Jiri Olsa jo...@redhat.com Cc: Arun Sharma asha...@fb.com Cc: Stephane Eranian eran...@google.com Cc: Frederic Weisbecker fweis...@gmail.com

[PATCH 14/16] perf report: Bypass non-leader events when event group is enabled

2012-09-26 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com Since we have all necessary information in the leader events and other members don't, bypass members. Member events will be shown along with the leaders if event group is enabled. Cc: Jiri Olsa jo...@redhat.com Cc: Stephane Eranian eran...@google.com Cc:

[PATCH 13/16] perf ui/gtk: Add support for event group view

2012-09-26 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com Show group members' overhead also when showing the leader's if event group is enabled. At this time, only implemented overhead part in order to ease review and other parts can be added later once this patch settled down. Cc: Jiri Olsa jo...@redhat.com Cc:

[PATCH 12/16] perf ui/browser: Add support for event group view

2012-09-26 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com Show group members' overhead also when showing the leader's if event group is enabled. At this time, only implemented overhead part in order to ease review and other parts can be added later once this patch settled down. Cc: Jiri Olsa jo...@redhat.com Cc:

[PATCH 11/16] perf ui/hist: Add support for event group view

2012-09-26 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com Show group members' overhead also when showing the leader's if event group is enabled. At this time, only implemented overhead part in order to ease review and other parts can be added later once this patch settled down. Cc: Jiri Olsa jo...@redhat.com Cc:

[PATCH 09/16] perf hists: Maintain total periods of group members in the leader

2012-09-26 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com Like group_stats in hist_entry, total periods information also need to be known to the leader. Cc: Jiri Olsa jo...@redhat.com Cc: Stephane Eranian eran...@google.com Signed-off-by: Namhyung Kim namhy...@kernel.org --- tools/perf/util/hist.c | 25

[PATCH 07/16] perf header: Add HEADER_GROUP_DESC feature

2012-09-26 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com Save group relationship information so that it can be restored when perf report is running. Cc: Jiri Olsa jo...@redhat.com Cc: Stephane Eranian eran...@google.com Signed-off-by: Namhyung Kim namhy...@kernel.org --- tools/perf/builtin-record.c | 3 +

[PATCH 00/16] perf report: Add suppport for event group view (v2)

2012-09-26 Thread Namhyung Kim
Hi, This is my second attempt to support event group on perf report. For basic idea and usage example, please see my original post [1]. The main difference than v1 is adding HEADER_GROUP_DESC feature and use it for regenerating group relationship on perf report. It will save actual (i.e.

[PATCH 08/16] perf hists: Collapse group hist_entries to a leader

2012-09-26 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com To support viewing an event group together, collapse all of members in the group to the leader's tree. The entries in the leaders' tree will have group_stats to store those information. This patch introduced an additional field 'event_group' in

[PATCH 06/16] perf evlist: Add perf_evlist__recalc_nr_groups

2012-09-26 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com During the event parsing, perf_evlist can have leader-only groups which has nr_members as 1. Since they has no difference than a normal non-group event don't count them as a event group. Add perf_evlist__recalc_nr_groups to count actual group numbers.

[PATCH 01/16] perf hists: Add missing period_* fields when collapsing a hist entry

2012-09-26 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com So that the perf report won't lost the cpu utilization information. For example, if there're two process that have same name. $ perf report --stdio --showcpuutilization -s pid [SNIP] # Overhead sysus Command: Pid #

Re: [PATCH] x86/fixup_irq: Clean the offlining CPU from the irq affinity mask

2012-09-26 Thread Srivatsa S. Bhat
On 09/26/2012 12:22 PM, Liu, Chuansheng wrote: + } else if (cpumask_test_cpu(cpu, data-affinity)) + cpumask_clear_cpu(cpu, data-affinity); You meant to use 'affinity' (instead of data-affinity) in the above 2 statements right? Note that we do

Re: [PATCH v3 8/9] perf hists browser: Add option for runtime switching perf data file

2012-09-26 Thread Feng Tang
On Tue, Sep 25, 2012 at 08:17:03AM -0300, Arnaldo Carvalho de Melo wrote: Em Tue, Sep 25, 2012 at 04:20:53PM +0800, Feng Tang escreveu: On Tue, 25 Sep 2012 11:11:21 +0900 Namhyung Kim namhy...@kernel.org wrote: Ditto. Plus it might leak previous input_name. Nice catch, will check the

RE: [PATCH] x86/fixup_irq: Clean the offlining CPU from the irq affinity mask

2012-09-26 Thread Liu, Chuansheng
Btw, on a slightly different note, I'm also rather surprised that the above code doesn't care about the return value of chip-irq_set_affinity() .. Shouldn't we warn if that fails? It seems another case when irq_set_affinity is NULL whenever affinity is changed or not before that, For this

Re: [PATCH] x86_64: Work around old gas bug

2012-09-26 Thread Tao Guo
On 9/26/12, Jan Beulich jbeul...@suse.com wrote: On 26.09.12 at 08:15, Tao Guo glorious...@gmail.com wrote: gas in binutils(2.16.91) could not parse parentheses within macro parameters, This description of yours contradicts the last hunk of the patch - iirc the requirement for macro

RE: [PATCH] x86/fixup_irq: Clean the offlining CPU from the irq affinity mask

2012-09-26 Thread Liu, Chuansheng
Shouldn't we warn if that fails? printk(Cannot set affinity for irq %i\n, irq); This is the warning when set affinity failed.

RE: [PATCH] x86/fixup_irq: Clean the offlining CPU from the irq affinity mask

2012-09-26 Thread Liu, Chuansheng
In that case, we would end up with an incorrect data-affinity right? Moving the clean cpu mask code into if (chip-irq_set_affinity)? Will resend the patch and will judge the chip-irq_set_affinity(data, affinity, true) return value.

RE: [RFC PATCH 00/13] DMA Engine support for AM33xx

2012-09-26 Thread Hebbar, Gururaja
On Fri, Sep 21, 2012 at 23:52:11, Porter, Matt wrote: On Fri, Sep 21, 2012 at 08:27:07AM +, Hebbar, Gururaja wrote: On Thu, Sep 20, 2012 at 20:13:33, Porter, Matt wrote: This series adds DMA Engine support for AM33xx, which uses an EDMA DMAC. The EDMA DMAC has been previously

Re: [PATCH] x86/fixup_irq: Clean the offlining CPU from the irq affinity mask

2012-09-26 Thread Srivatsa S. Bhat
On 09/26/2012 01:47 PM, Liu, Chuansheng wrote: Shouldn't we warn if that fails? printk(Cannot set affinity for irq %i\n, irq); This is the warning when set affinity failed. I know.. What I meant is, the code warns only if chip-irq_set_affinity is NULL and doesn't care if

[PATCH RESEND] x86/fixup_irq: Clean the offlining CPU from the irq affinity mask

2012-09-26 Thread Chuansheng Liu
When one CPU is going offline, and fixup_irqs() will re-set the irq affinity in some cases, we should clean the offlining CPU from the irq affinity. The reason is setting offlining CPU as of the affinity is useless. Moreover, the smp_affinity value will be confusing when the offlining CPU come

RE: [PATCH] x86/fixup_irq: Clean the offlining CPU from the irq affinity mask

2012-09-26 Thread Liu, Chuansheng
I know.. What I meant is, the code warns only if chip-irq_set_affinity is NULL and doesn't care if chip-irq_set_affinity was not NULL and the function failed to set the affinity (ie., when chip-irq_set_affinity() returns error). In other words, I meant to say that this is one more case where

Re: [PATCH] slab: Ignore internal flags in cache creation

2012-09-26 Thread Glauber Costa
On 09/26/2012 04:46 AM, David Rientjes wrote: On Tue, 25 Sep 2012, Christoph Lameter wrote: No cache should ever pass those as a creation flags. We can just ignore this bit if it happens to be passed (such as when duplicating a cache in the kmem memcg patches) Acked-by: Christoph Lameter

[PATCH 0/3] zram/zsmalloc promotion

2012-09-26 Thread Minchan Kim
/block/zram which is suggested by Nitin. I don't know who should merge whose tree. So I will add both Greg and Jens to To. This patchset is based on next-20120926. Minchan Kim (3): zsmalloc: promote to lib/ zram: promote zram from staging zram: select ZSMALLOC when ZRAM is configured drivers

[PATCH 3/3] zram: select ZSMALLOC when ZRAM is configured

2012-09-26 Thread Minchan Kim
At the monent, we can configure zram in driver/block once zsmalloc in /lib menu is configured firstly. It's not convenient. User can configure zram in driver/block regardless of zsmalloc enabling by this patch. Signed-off-by: Minchan Kim minc...@kernel.org --- drivers/block/zram/Kconfig |3

[PATCH] x86_64: Work around old gas bug

2012-09-26 Thread Tao Guo
gas in binutils(2.16.91) could not parse parentheses within macro parameters unless fully parenthesized, and this is a workaround to make old gas work without generating below errors: arch/x86/kernel/entry_64.S: Assembler messages: arch/x86/kernel/entry_64.S:387: Error: too many positional

Re: [PATCH RESEND] x86/fixup_irq: Clean the offlining CPU from the irq affinity mask

2012-09-26 Thread Srivatsa S. Bhat
On 09/26/2012 11:08 PM, Chuansheng Liu wrote: When one CPU is going offline, and fixup_irqs() will re-set the irq affinity in some cases, we should clean the offlining CPU from the irq affinity. The reason is setting offlining CPU as of the affinity is useless. Moreover, the smp_affinity

GFS2: Pre-pull patch posting (merge window)

2012-09-26 Thread Steven Whitehouse
Hi, We've collected up a goodly number of patches in the -nmw tree now and we can hold off any further changes until the following merge window, so here is the current tree content. The major feature this time is the rbm conversion in the resource group code. The new struct gfs2_rbm specifies

[PATCH 01/27] GFS2: Merge two nearly identical xattr functions

2012-09-26 Thread Steven Whitehouse
There were two functions in the xattr code which were nearly identical, the only difference being that one was copy data into the unstuffed xattrs and the other was copying data out from it. This patch merges the two functions such that the code which deal with iteration over the unstuffed xattrs

RE: [PATCH RESEND] x86/fixup_irq: Clean the offlining CPU from the irq affinity mask

2012-09-26 Thread Liu, Chuansheng
Please hold on.. I'm not yet done reviewing, I might have more comments :-) Sure, welcome, thanks again.

[PATCH 10/27] GFS2: change function gfs2_direct_IO to use a normal gfs2_glock_dq

2012-09-26 Thread Steven Whitehouse
From: Bob Peterson rpete...@redhat.com This patch changes function gfs2_direct_IO so that it uses a normal call to gfs2_glock_dq rather than a call to a multiple-dq of one item. Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git

[PATCH 19/27] GFS2: Fall back to ignoring reservations, if there are no other blocks left

2012-09-26 Thread Steven Whitehouse
When we get to the stage of allocating blocks, we know that the resource group in question must contain enough free blocks, otherwise gfs2_inplace_reserve() would have failed. So if we are left with only free blocks which are reserved, then we must use those. This can happen if another node has

[PATCH 22/27] GFS2: Stop block extents at the end of bitmaps

2012-09-26 Thread Steven Whitehouse
From: Bob Peterson rpete...@redhat.com This patch stops multiple block allocations if a nonzero return code is received from gfs2_rbm_from_block. Without this patch, if enough pressure is put on the file system, you get a kernel warning quickly followed by: BUG: unable to handle kernel NULL

[PATCH 25/27] GFS2: Fix infinite loop in rbm_find

2012-09-26 Thread Steven Whitehouse
From: Bob Peterson rpete...@redhat.com This patch fixes an infinite loop in gfs2_rbm_find that was introduced by the previous patch. The problem occurred when the length was less than 3 but the rbm block was byte-aligned, causing it to improperly return a extent length of zero, which caused it to

[PATCH 27/27] GFS2: Write out dirty inode metadata in delayed deletes

2012-09-26 Thread Steven Whitehouse
From: Benjamin Marzinski bmarz...@redhat.com If a dirty GFS2 inode was being deleted but was in use by another node, its metadata was not getting written out before GFS2 checked for dirty buffers in gfs2_ail_flush(). GFS2 was relying on inode_go_sync() to write out the metadata when the other

Re: [PATCH] x86/fixup_irq: Clean the offlining CPU from the irq affinity mask

2012-09-26 Thread Srivatsa S. Bhat
On 09/26/2012 01:40 PM, Liu, Chuansheng wrote: Btw, on a slightly different note, I'm also rather surprised that the above code doesn't care about the return value of chip-irq_set_affinity() .. Shouldn't we warn if that fails? It seems another case when irq_set_affinity is NULL whenever

[PATCH 26/27] GFS2: fix s_writers.counter imbalance in gfs2_ail_empty_gl

2012-09-26 Thread Steven Whitehouse
From: Eric Sandeen sand...@redhat.com gfs2_ail_empty_gl() contains an inline version of gfs2_trans_begin(), so it needs an explicit sb_start_intwrite() as well, to balance the sb_end_intwrite() which will be called by gfs2_trans_end(). With this, xfstest 068 passes on lock_nolock local gfs2.

[PATCH 24/27] GFS2: Consolidate free block searching functions

2012-09-26 Thread Steven Whitehouse
With the recently added block reservation code, an additional function was added to search for free blocks. This had a restriction of only being able to search for aligned extents of free blocks. As a result the allocation patterns when reserving blocks were suboptimal when the existing allocation

[PATCH 04/27] GFS2: Replace rgblk_search with gfs2_rbm_find

2012-09-26 Thread Steven Whitehouse
This is part of a series of patches which are introducing the gfs2_rbm structure throughout the block allocation code. The main aim of this part is to create a search function which can deal directly with struct gfs2_rbm. In this case it specifies the initial position at which to start the search

[PATCH 12/27] GFS2: Combine functions gfs2_glock_wait and wait_on_holder

2012-09-26 Thread Steven Whitehouse
From: Bob Peterson rpete...@redhat.com Function gfs2_glock_wait only called function wait_on_holder and returned its return code, so they were combined for readability. Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git

[PATCH 15/27] GFS2: Eliminate unnecessary check for state 3 in bitfit

2012-09-26 Thread Steven Whitehouse
From: Bob Peterson rpete...@redhat.com Function gfs2_bitfit was checking for state 3, but that's impossible since it is only called from rgblk_search, which receives only GFS2_BLKST_ constants. Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com

[PATCH 17/27] GFS2: Use rbm for gfs2_setbit()

2012-09-26 Thread Steven Whitehouse
Use the rbm structure for gfs2_setbit() in order to simplify the arguments to the function. We have to add a bool to control whether the clone bitmap should be updated (if it exists) but otherwise it is a more or less direct substitution. Signed-off-by: Steven Whitehouse swhit...@redhat.com diff

[PATCH 20/27] GFS2: Improve block reservation tracing

2012-09-26 Thread Steven Whitehouse
This patch improves the tracing of block reservations by removing some corner cases and also providing more useful detail in the traces. A new field is added to the reservation structure to contain the inode number. This is used since in certain contexts it is not possible to access the inode

[PATCH 23/27] GFS2: Get rid of I_MUTEX_QUOTA usage

2012-09-26 Thread Steven Whitehouse
From: Jan Kara j...@suse.cz GFS2 uses i_mutex on its system quota inode to synchronize writes to quota file. Since this is an internal inode to GFS2 (not part of directory hiearchy or visible by user) we are safe to define locking rules for it. So let's just get it its own locking class to make

[PATCH 21/27] GFS2: Fix unclaimed_blocks() wrapping bug and clean up

2012-09-26 Thread Steven Whitehouse
When rgd-rd_free_clone is less than rgd-rd_reserved, the unclaimed_blocks() calculation would wrap and produce incorrect results. This patch checks for this condition when this function is called from gfs2_mblk_search() In addition, the use of this particular function in other places in the code

[PATCH 18/27] GFS2: Fix -show_options() for statfs slow

2012-09-26 Thread Steven Whitehouse
The -show_options() function for GFS2 was not correctly displaying the value when statfs slow in in use. Signed-off-by: Steven Whitehouse swhit...@redhat.com Reported-by: Milos Jakubicek xja...@fi.muni.cz diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index 3cbac68..79cac70 100644 ---

[PATCH 16/27] GFS2: Use rbm for gfs2_testbit()

2012-09-26 Thread Steven Whitehouse
Change the arguments to gfs2_testbit() so that it now just takes an rbm specifying the position of the two bit entry to return. Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index 47d2346..3a288ce 100644 --- a/fs/gfs2/rgrp.c +++

[PATCH 14/27] GFS2: Eliminate redundant calls to may_grant

2012-09-26 Thread Steven Whitehouse
From: Bob Peterson rpete...@redhat.com Function add_to_queue was checking may_grant for the passed-in holder for every iteration of its gh2 loop. Now it only checks it once at the beginning to see if a try lock is futile. Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by: Steven

[PATCH 13/27] GFS2: Combine functions gfs2_glock_dq_wait and wait_on_demote

2012-09-26 Thread Steven Whitehouse
From: Bob Peterson rpete...@redhat.com Function gfs2_glock_dq_wait called two-line function wait_on_demote, so they were combined. Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index

[PATCH 11/27] GFS2: inline __gfs2_glock_schedule_for_reclaim

2012-09-26 Thread Steven Whitehouse
From: Bob Peterson rpete...@redhat.com Since function gfs2_glock_schedule_for_reclaim is only two significant lines, we can eliminate it, simplifying the code and making it more readable. Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by: Steven Whitehouse swhit...@redhat.com diff

[PATCH 09/27] GFS2: rbm code cleanup

2012-09-26 Thread Steven Whitehouse
From: Bob Peterson rpete...@redhat.com This patch fixes a few small rbm related things. First, it fixes a corner case where the rbm needs to switch bitmaps and wasn't adjusting its buffer pointer. Second, there's a white space issue fixed. Third, the logic in function gfs2_rbm_from_block was

RE: [PATCH RESEND] x86/fixup_irq: Clean the offlining CPU from the irq affinity mask

2012-09-26 Thread Liu, Chuansheng
A return value of 0 and 1 are acceptable. So this check isn't correct. Regards, Srivatsa S. Bhat Which case value 1 is acceptable, could you share? Thanks. OMG, why did you drop the other hunk which cleared the cpu *before* invoking -irq_set_affinity()? IMO, altering irq affinity

[PATCH 08/27] GFS2: Fix case where reservation finished at end of rgrp

2012-09-26 Thread Steven Whitehouse
One corner case which the original patch failed to take into account was when there is a reservation which ended such that the following block was one beyond the end of the rgrp in question. This extra test fixes that case. Signed-off-by: Steven Whitehouse swhit...@redhat.com Reported-by: Bob

Re: [PATCH v2] media: mt9p031/mt9t001/mt9v032: use V4L2_CID_TEST_PATTERN for test pattern control

2012-09-26 Thread Laurent Pinchart
Hi Prabhakar, Thanks for the patch. On Wednesday 26 September 2012 12:05:10 Prabhakar wrote: From: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Cc: Laurent Pinchart

Re: [RFC 2/4] memcg: make it suck faster

2012-09-26 Thread Glauber Costa
On 09/26/2012 01:02 AM, Andrew Morton wrote: nomemcg : memcg compile disabled. base : memcg enabled, patch not applied. bypassed : memcg enabled, with patch applied. basebypassed User 109.12 105.64 System 1646.84 1597.98 Elapsed

[PATCH 05/27] GFS2: Update gfs2_get_block_type() to use rbm

2012-09-26 Thread Steven Whitehouse
Use the new gfs2_rbm_from_block() function to replace an open coded version of the same code. Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index bd3b926..0c1be38 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c @@ -1824,27 +1824,14 @@ void

Re: [Xen-devel] [PATCH 2/2] xen/pciback: When resetting the device don't disable twice.

2012-09-26 Thread Jan Beulich
On 25.09.12 at 23:27, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: We call 'pci_disable_device' which sets the bus_master to zero and it also disables the PCI_COMMAND. There is no need to do it outside the PCI library. Not really - pci_disable_device() only does anything if enable_cnt

[PATCH 07/27] GFS2: Use RB_CLEAR_NODE() rather than rb_init_node()

2012-09-26 Thread Steven Whitehouse
From: Michel Lespinasse wal...@google.com gfs2 calls RB_EMPTY_NODE() to check if nodes are not on an rbtree. The corresponding initialization function is RB_CLEAR_NODE(). rb_init_node() was never clearly defined and is going away. Signed-off-by: Michel Lespinasse wal...@google.com Signed-off-by:

[PATCH 06/27] GFS2: Update rgblk_free() to use rbm

2012-09-26 Thread Steven Whitehouse
Replace open coded version with a call to gfs2_rbm_from_block() Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index 0c1be38..06476b3 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c @@ -1890,46 +1890,30 @@ static u64 gfs2_alloc_extent(const

[PATCH 03/27] GFS2: Add structure to contain rgrp, bitmap, offset tuple

2012-09-26 Thread Steven Whitehouse
This patch introduces a new structure, gfs2_rbm, which is a tuple of a resource group, a bitmap within the resource group and an offset within that bitmap. This is designed to make manipulating these sets of variables easier. There is also a new helper function which converts this representation

[PATCH 02/27] GFS2: Remove rs_requested field from reservations

2012-09-26 Thread Steven Whitehouse
The rs_requested field is left over from the original allocation code, however this should have been a parameter passed to the various functions from gfs2_inplace_reserve() and not a member of the reservation structure as the value is not required after the initial allocation. This also helps

Re: [PATCH v3 3/9] perf script: Add more filter to find_scripts()

2012-09-26 Thread Feng Tang
On Tue, 25 Sep 2012 10:47:03 +0900 Namhyung Kim namhy...@kernel.org wrote: Hi Feng, On Mon, 24 Sep 2012 23:24:05 +0800, Feng Tang wrote: As suggested by Arnaldo, many scripts have their own usages and need capture specific events or tracepoints, so only those scripts whose targe events

  1   2   3   4   5   6   7   8   9   10   >