Re: [PATCH v3 0/2] make kASLR vs hibernation boot-time selectable

2014-06-14 Thread Kees Cook
On Fri, Jun 13, 2014 at 4:25 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Friday, June 13, 2014 01:30:34 PM Kees Cook wrote: Distros want to be able to offer CONFIG_RANDOMIZE_BASE as well as CONFIG_HIBERNATION in a single kernel. Instead of making kASLR depend on !HIBERNATION at compile

Re: random: Benchamrking fast_mix2

2014-06-14 Thread Theodore Ts'o
OK, so I normally do my testing using 32-bit kernels under KVM. On a i386 kernel, running under kvm (again using a Lenovo T540 with a i7-4900MQ CPU), with the original fast_mix, I get a timestamp count of 166 cycles using a weighted smoothed average. Using your fast_mix2 I get around 450 cycles.

Re: random: Benchamrking fast_mix2

2014-06-14 Thread Theodore Ts'o
On Sat, Jun 14, 2014 at 01:25:27AM -0400, George Spelvin wrote: When I did a quick comparison of your 64-bit fast_mix2 variant, it's much slower than either the 32-bit fast_mix2, or the original fast_mix alrogithm. That is f***ing *bizarre*. For me, it's *significantly* faster. You

Re: [RFC] random: is the IRQF_TIMER test working as intended?

2014-06-14 Thread Theodore Ts'o
On Sat, Jun 14, 2014 at 12:55:20AM -0400, George Spelvin wrote: I'm trying to understand the entropy credit computation in add_interrupt_randomness. A few things confuse me, and I'm wondering if it's intended to be that way. In general, yes. It's intended this way. I'm trying to be

[PATCH -tip ] [Bugfix] x86/kprobes: Fix build errors and blacklist context_track_user

2014-06-14 Thread Masami Hiramatsu
This reverts commit ecd50f714c421c759354632dd00f70c718c95b10 since it causes build errors with CONFIG_CONTEXT_TRACKING and that has been made from misunderstandings; context_track_user_*() don't involve much in interrupt context, it just returns if in_interrupt() is true. Instead of changing the

[PATCH-v2 1/4] random: always update the entropy pool under the spinlock

2014-06-14 Thread Theodore Ts'o
Instead of using lockless techniques introduced in commit 902c098a3663, use spin_trylock to try to grab entropy pool's lock. If we can't get the lock, then just try again on the next interrupt. Based on discussions with George Spelvin. Signed-off-by: Theodore Ts'o ty...@mit.edu Cc: George

[PATCH-v2 4/4] random: clean up interrupt entropy accounting for archs w/o cycle counters

2014-06-14 Thread Theodore Ts'o
For architectures that don't have cycle counters, the algorithm for deciding when to avoid giving entropy credit due to back-to-back timer interrupts didn't make any sense, since we were checking every 64 interrupts. Change it so that we only give an entropy credit if the majority of the

[PATCH-v2 2/4] random: remove unneeded hash of a portion of the entropy pool

2014-06-14 Thread Theodore Ts'o
We previously extracted a portion of the entropy pool in mix_pool_bytes() and hashed it in to avoid racing CPU's from returning duplicate random values. Now that we are using a spinlock to prevent this from happening, this is no longer necessary. So remove it, to simplify the code a bit.

[PATCH-v2 3/4] random: only update the last_pulled time if we actually transferred entropy

2014-06-14 Thread Theodore Ts'o
In xfer_secondary_pull(), check to make sure we need to pull from the secondary pool before checking and potentially updating the last_pulled time. Signed-off-by: Theodore Ts'o ty...@mit.edu Cc: George Spelvin li...@horizon.com --- drivers/char/random.c | 11 +++ 1 file changed, 7

polyester oxford fabric use for bag

2014-06-14 Thread YR
Dear sir: We are professional do the polyester fabric and PU ULY coating .All of the Item we can do like 300D,600D,900D.If you have samples please send me .And i will give you a good price .All of our fabric can used for bags,tent ,horse cloth ,covers so on. we have a high quality . I hope

Re: [PATCH v2 08/10] mm, cma: clean-up cma allocation error path

2014-06-14 Thread Aneesh Kumar K.V
Joonsoo Kim iamjoonsoo@lge.com writes: We can remove one call sites for clear_cma_bitmap() if we first call it before checking error number. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com Reviewed-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com diff --git a/mm/cma.c b/mm/cma.c

Re: [PATCH v2 09/10] mm, cma: move output param to the end of param list

2014-06-14 Thread Aneesh Kumar K.V
Joonsoo Kim iamjoonsoo@lge.com writes: Conventionally, we put output param to the end of param list. cma_declare_contiguous() doesn't look like that, so change it. Additionally, move down cma_areas reference code to the position where it is really needed. Signed-off-by: Joonsoo Kim

Re: [RFC] random: is the IRQF_TIMER test working as intended?

2014-06-14 Thread George Spelvin
In general, yes. It's intended this way. I'm trying to be extremely conservative with my entropy measurements, and part of it is because there is generally a huge amount of interrupts available, at least on desktop systems, and I'd much rather be very conservative than not. To be absolutely

Re: [PATCH v2 00/10] CMA: generalize CMA reserved area management code

2014-06-14 Thread Aneesh Kumar K.V
Joonsoo Kim iamjoonsoo@lge.com writes: Currently, there are two users on CMA functionality, one is the DMA subsystem and the other is the kvm on powerpc. They have their own code to manage CMA reserved area even if they looks really similar. From my guess, it is caused by some needs on

Re: [PATCH-v2 4/4] random: clean up interrupt entropy accounting for archs w/o cycle counters

2014-06-14 Thread George Spelvin
+ if (cycles || (fast_pool-notimer_count = 32)) + credit++; Ah, this addresses my concern about too few interrupts, too. If the (non-timer) interrupt rate is less than 32/second, you'll never get any credit. (If you want to support this mode of operation and still have a

[PATCH] staging: lustre: remove memset(0) after LIBCFS_ALLOC

2014-06-14 Thread Vitaly Osipov
Joe Perches mentioned on driverdev-devel that memset after LIBCFS_ALLOC is not necessary as it is already done during LIBCFS_ALLOC_POST. This commit removes these unnecessary memsets. Based on the results of running a cocci patch along the lines of: @@ expression E1, E2; @@ LIBCFS_ALLOC

Re: [PATCH 0/2] make kASLR vs hibernation boot-time selectable

2014-06-14 Thread Kees Cook
On Fri, Jun 13, 2014 at 5:39 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Friday, June 13, 2014 05:08:21 PM Kees Cook wrote: On Fri, Jun 13, 2014 at 5:14 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Friday, June 13, 2014 03:59:57 PM Kees Cook wrote: On Fri, Jun 13, 2014 at 3:54

Re: [RFC PATCH] checkpatch: Attempt to find unnecessary 'out of memory' messages

2014-06-14 Thread Julia Lawall
With a semantic patch that searches for the various calls and then a string containing the letters emory, I get removals of the messages below. Do any of these messages look useful? For example, some are generated with specific functions, such as IRDA_ERROR or BT_ERR. If none of the

Re: random: Benchamrking fast_mix2

2014-06-14 Thread George Spelvin
Want to give this patch a try on your collection of machines? Not until I fix it to +#if ADD_INTERRUPT_BENCH +static unsigned long avg_cycles; + +#define AVG_SHIFT 8/* Exponential average factor k=1/256 */ +#define FIXED_1_2 (1 (AVG_SHIFT-1)) + +static void add_interrupt_bench(cycles_t

Re: [RFC PATCH] checkpatch: Attempt to find unnecessary 'out of memory' messages

2014-06-14 Thread Joe Perches
On Sat, 2014-06-14 at 09:40 +0200, Julia Lawall wrote: With a semantic patch that searches for the various calls and then a string containing the letters emory, I get removals of the messages below. Do any of these messages look useful? For example, some are generated with specific

Re: [PATCHv2 1/2] rx51_battery: convert to iio consumer

2014-06-14 Thread Pavel Machek
On Wed 2014-04-23 18:09:37, Sebastian Reichel wrote: On Sun, Apr 20, 2014 at 02:08:23PM +0200, Pavel Machek wrote: On Sat 2014-03-29 11:09:45, Jonathan Cameron wrote: On 01/03/14 20:22, Sebastian Reichel wrote: Update rx51-battery driver to use the new IIO API of twl4030-madc and add

Re: Kernel for olpc-1.75

2014-06-14 Thread Pavel Machek
Hi! On Sat, Jun 7, 2014 at 11:53 PM, Pavel Machek pa...@ucw.cz wrote: I broke installation on olpc-1.75, and I guess its time for it to start running self-compiled kernel. (It still boots if I hold right game key, but I can no longer control backlight. It does not boot at all by

Re: [PATCH v2] Documentation: Rename hpfall.c = freefall.c, fixes for Dell

2014-06-14 Thread Pavel Machek
On Wed 2014-06-11 10:02:07, Pali Roh?r wrote: Dell kernel driver dell-smo8800 provides same freefall interface as hp_accel so program hpfall.c works also on Dell laptops. So rename it to freefall.c. Dell driver does not provide hp::hddprotect led so make sure that freefall.c works also if

Re: [PATCH v2 07/10] PPC, KVM, CMA: use general CMA reserved area management framework

2014-06-14 Thread Aneesh Kumar K.V
Joonsoo Kim iamjoonsoo@lge.com writes: Now, we have general CMA reserved area management framework, so use it for future maintainabilty. There is no functional change. Acked-by: Michal Nazarewicz min...@mina86.com Acked-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Joonsoo Kim

[tip:perf/urgent] x86/kprobes: Fix build errors and blacklist context_track_user

2014-06-14 Thread tip-bot for Masami Hiramatsu
Commit-ID: 4cdf77a828b056258f48a9f6078bd2f77d9704bb Gitweb: http://git.kernel.org/tip/4cdf77a828b056258f48a9f6078bd2f77d9704bb Author: Masami Hiramatsu masami.hiramatsu...@hitachi.com AuthorDate: Sat, 14 Jun 2014 06:47:12 + Committer: Ingo Molnar mi...@kernel.org CommitDate: Sat, 14

[PATCH] Suppress -Wignored-qualifiers warnings

2014-06-14 Thread Bart Van Assche
Avoid that gcc reports the following warning when building with W=1: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Ingo Molnar mi...@kernel.org Cc: Peter Zijlstra pet...@infradead.org Cc: Vincent Guittot

Re: [Linux-ima-user] oraphaned keywords in audit log text [was: Re: [PATCH] integrity: get comm using lock to avoid race in string] printing

2014-06-14 Thread Dmitry Kasatkin
On 14 June 2014 03:02, Richard Guy Briggs r...@redhat.com wrote: On 14/04/02, Richard Guy Briggs wrote: On 14/04/02, Mimi Zohar wrote: On Wed, 2014-04-02 at 14:18 -0400, Eric Paris wrote: On Wed, 2014-04-02 at 14:12 -0400, Mimi Zohar wrote: On Wed, 2014-04-02 at 14:00 -0400, Steve Grubb

Re: [PATCH v2] delete unnecessary bootmem struct page array

2014-06-14 Thread Richard Weinberger
Hi! Am 03.06.2014 07:30, schrieb Real Name: From: Honggang Li enjoymind...@gmail.com The patch based on linux-next-2014-06-02. The old init_maps function does two things: 1) allocates and initializes one struct page array for bootmem 2) count the number of total pages After removed

console / fbdev: fbcon support for bits_per_pixel = 1?

2014-06-14 Thread Stefan Biereigel
CC: linux-console, linux-fbdev Hello Kernel Developers, for a university assignment we are developing a frame buffer driver for a monochrome display. We succeeded so far in making a simple RAM frame buffer module, which is needed as the basis (we don't have read access to the RAM in the LCD).

[PATCH 1/1] PM / Runtime: let rpm_resume fail if rpm disabled and device suspended.

2014-06-14 Thread Allen Yu
dev-power.is_suspended is set after core suspends device during system suspend. This flag mostly means device is not operational (all I/O been quiesced, no more data read or write acceptible, etc.), hence it's dangerous to access hardware if device is suspended even though runtime PM status is

Re: [PATCH v2 07/10] PPC, KVM, CMA: use general CMA reserved area management framework

2014-06-14 Thread Aneesh Kumar K.V
Joonsoo Kim iamjoonsoo@lge.com writes: Now, we have general CMA reserved area management framework, so use it for future maintainabilty. There is no functional change. Acked-by: Michal Nazarewicz min...@mina86.com Acked-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Joonsoo Kim

Re: [PATCH v2 06/10] CMA: generalize CMA reserved area management functionality

2014-06-14 Thread Aneesh Kumar K.V
Joonsoo Kim iamjoonsoo@lge.com writes: Currently, there are two users on CMA functionality, one is the DMA subsystem and the other is the kvm on powerpc. They have their own code to manage CMA reserved area even if they looks really similar. From my guess, it is caused by some needs on

Re: [PATCH v2 05/10] DMA, CMA: support arbitrary bitmap granularity

2014-06-14 Thread Aneesh Kumar K.V
Joonsoo Kim iamjoonsoo@lge.com writes: ppc kvm's cma region management requires arbitrary bitmap granularity, since they want to reserve very large memory and manage this region with bitmap that one bit for several pages to reduce management overheads. So support arbitrary bitmap

Re: [PATCH v2 06/10] CMA: generalize CMA reserved area management functionality

2014-06-14 Thread Aneesh Kumar K.V
Joonsoo Kim iamjoonsoo@lge.com writes: Currently, there are two users on CMA functionality, one is the DMA subsystem and the other is the kvm on powerpc. They have their own code to manage CMA reserved area even if they looks really similar. From my guess, it is caused by some needs on

Re: [PATCH v2 06/10] CMA: generalize CMA reserved area management functionality

2014-06-14 Thread Aneesh Kumar K.V
Joonsoo Kim iamjoonsoo@lge.com writes: Currently, there are two users on CMA functionality, one is the DMA subsystem and the other is the kvm on powerpc. They have their own code to manage CMA reserved area even if they looks really similar. From my guess, it is caused by some needs on

Re: [PATCH 3.15 00/12] 3.15.1-stable review

2014-06-14 Thread Satoru Takeuchi
At Fri, 13 Jun 2014 08:16:02 -0700, Guenter Roeck wrote: On 06/12/2014 04:21 PM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 3.15.1 release. There are 12 patches in this series, all will be posted as a response to this one. If anyone has any issues with

copying file results in out of memory, kills other processes, makes system unavailable

2014-06-14 Thread David Newall
Hi all, First, I'm not subscribed to any of the mailing lists addressed. Please copy me in replies. I'm not sure if this is an LVM issue or a MM issue. I rather think it's the latter, and I'll explain why, towards the end of this email. I'm running a qemu virtual machine, 2 x i686 with

Re: random: Benchamrking fast_mix2

2014-06-14 Thread George Spelvin
And I have of course embarrassed myself publicly by getting the sign wrong. That's what I get for posting *before* booting the result. You may now point and bray like a donkey. :-) Anyway. the following actually works: #if ADD_INTERRUPT_BENCH static unsigned long avg_cycles, avg_deviation;

Re: [PATCH] rcu: Only pin GP kthread when full dynticks is actually used

2014-06-14 Thread Paul E. McKenney
On Fri, Jun 13, 2014 at 10:06:06PM -0700, Paul E. McKenney wrote: On Sat, Jun 14, 2014 at 01:39:36AM +0200, Frederic Weisbecker wrote: On Fri, Jun 13, 2014 at 04:27:15PM -0700, Paul E. McKenney wrote: [ . . . ] If I was to extend rcu_needs_cpu(), I would add a flag and another counter

[PATCH v2] media: v4l2-core: v4l2-dv-timings.c: Cleaning up code wrong value used in aspect ratio.

2014-06-14 Thread Rickard Strandqvist
Wrong value used in same cases for the aspect ratio. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/media/v4l2-core/v4l2-dv-timings.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-dv-timings.c

[PATCH v2] media: v4l2-core: v4l2-dv-timings.c: Cleaning up code wrong value used in aspect ratio.

2014-06-14 Thread Rickard Strandqvist
Wrong value used in same cases for the aspect ratio. This is likely a cut and paste mistake. This was partly found using a static code analysis program called cppcheck. Rickard Strandqvist (1): media: v4l2-core: v4l2-dv-timings.c: Cleaning up code wrong value used in aspect ratio.

[PATCH 2/2] staging: rtl8712: use kcalloc instead of kmalloc(x*y,...)

2014-06-14 Thread Vitaly Osipov
Replaced kmalloc(x*y, ...) with kcalloc(x,y,...) Signed-off-by: Vitaly Osipov vitaly.osi...@gmail.com --- drivers/staging/rtl8712/rtl871x_mlme.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c

[f2fs-dev][PATCH] f2fs: refactor flush_nat_entries codes for reducing NAT writes

2014-06-14 Thread Chao Yu
Although building NAT journal in cursum reduce the read/write work for NAT block, but previous design leave us lower performance when write checkpoint frequently for these cases: 1. if journal in cursum has already full, it's a bit of waste that we flush all nat entries to page for persistence,

[PATCH 1/2] staging: rtl8712: replace kmalloc(..., sizeof(T))

2014-06-14 Thread Vitaly Osipov
As suggested by Andy Shevchenko on driverdev-devel, replace v = ... sizeof(struct type_of_v) - sizeof(*v) Based on a cocci patch along the lines of @@ type T; expression E; identifier V; @@ T *V; ... - V = kmalloc(sizeof(T), E); + V = kmalloc(sizeof(*V), E); @@ type T; expression E; identifier

Re: [PATCH v6] iio: add support of the max1027

2014-06-14 Thread Jonathan Cameron
On 07/06/14 14:38, Philippe Reynes wrote: This driver add partial support of the maxim 1027/1029/1031. Differential mode is not supported. It was tested on armadeus apf27 board. Signed-off-by: Philippe Reynes trem...@yahoo.fr Hi, There is one trivial bit inline. If no one else raises

Re: kmemleak: Unable to handle kernel paging request

2014-06-14 Thread Catalin Marinas
On 13 Jun 2014, at 22:44, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Fri, 2014-06-13 at 09:56 +0100, Catalin Marinas wrote: OK, so that's the DART table allocated via alloc_dart_table(). Is dart_tablebase removed from the kernel linear mapping after allocation? Yes. If

Re: console / fbdev: fbcon support for bits_per_pixel = 1?

2014-06-14 Thread Bruno Prémont
Hi Stefan, On Sat, 14 June 2014 Stefan Biereigel ste...@biereigel.de wrote: CC: linux-console, linux-fbdev Hello Kernel Developers, for a university assignment we are developing a frame buffer driver for a monochrome display. We succeeded so far in making a simple RAM frame buffer module,

[PATCH] sched: fix possible divide by zero in avg_atom calculation

2014-06-14 Thread Mateusz Guzik
proc_sched_show_task does: if (nr_switches) do_div(avg_atom, nr_switches); nr_switches is unsigned long and do_div truncates it to 32 bits, which means it can test non-zero on e.g. x86-64 and be truncated to zero for division. Fix the problem by using div64_ul instead. As a side effect

Re: [PATCH] rcu: Only pin GP kthread when full dynticks is actually used

2014-06-14 Thread Frederic Weisbecker
On Fri, Jun 13, 2014 at 10:06:06PM -0700, Paul E. McKenney wrote: One complication... So if the grace period has gone on for a long time, and you are returning to kernel mode, RCU will need the scheduling-clock tick. However, in that very same situation, if you are returning to idle or to

Re: [PATCH 2/2] staging: tidspbridge: Fix function pointer spacing in struct definition

2014-06-14 Thread Jeff Oczek
On Fri, Jun 13, 2014 at 08:31:40PM -0700, Joe Perches wrote: On Fri, 2014-06-13 at 22:48 -0400, Jeff Oczek wrote: -s32(*fread) (void *, size_t, size_t, void *); -s32(*fseek) (void *, long, int); -s32(*ftell) (void *); -s32(*fclose) (void *); - void *(*fopen) (const

Re: [PATCH v3] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-14 Thread Yang,Wei
On 06/13/2014 09:39 PM, Alan Stern wrote: On Fri, 13 Jun 2014, Yang,Wei wrote: On 06/09/2014 02:19 PM, wei.y...@windriver.com wrote: From: Yang Wei wei.y...@windriver.com While loading g_mass_storage module, the following warning is triggered. WARNING: at drivers/usb/gadget/composite.c:

Re: [PATCH] rcu: Only pin GP kthread when full dynticks is actually used

2014-06-14 Thread Frederic Weisbecker
On Sat, Jun 14, 2014 at 04:26:39AM -0700, Paul E. McKenney wrote: On Fri, Jun 13, 2014 at 10:06:06PM -0700, Paul E. McKenney wrote: On Sat, Jun 14, 2014 at 01:39:36AM +0200, Frederic Weisbecker wrote: On Fri, Jun 13, 2014 at 04:27:15PM -0700, Paul E. McKenney wrote: [ . . . ] If I

[PATCH v2 2/2] staging: tidspbridge: Fix whitespace for pointers in function headers

2014-06-14 Thread Jeff Oczek
Change style in function headers from 'type * ptr' to 'type *ptr' Signed-off-by: Jeff Oczek jeffoc...@gmail.com --- drivers/staging/tidspbridge/include/dspbridge/dblldefs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 1/2] staging: tidspbridge: Add parameter names to function ptrs in struct dbll_attrs

2014-06-14 Thread Jeff Oczek
Add more descriptive names to function pointers in definition of struct dbll_attrs Signed-off-by: Jeff Oczek jeffoc...@gmail.com --- drivers/staging/tidspbridge/include/dspbridge/dblldefs.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v2] net: wireless: rtlwifi: rtl8188ee: hw.c: Cleaning up if statement that always evaluates to false

2014-06-14 Thread Rickard Strandqvist
I found a logical error in an if statement that always evaluates to false. This has after same discussion resulted in that we add a macro to handle this. This was partly found using a static code analysis program called cppcheck. Rickard Strandqvist (1): net: wireless: rtlwifi: rtl8188ee:

[PATCH v2] net: wireless: rtlwifi: rtl8188ee: hw.c: Cleaning up if statement that always evaluates to false

2014-06-14 Thread Rickard Strandqvist
I found a logical error in an if statement that always evaluates to false. This has after same discussion resulted in that we add a macro to handle this. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/net/wireless/rtlwifi/rtl8188ee/hw.c |2 +- 1 file

[PATCH v2] net: wireless: rtlwifi: rtl8188ee: reg.h: Cleaning up if statement that always evaluates to false

2014-06-14 Thread Rickard Strandqvist
I found a logical error in an if statement that always evaluates to false. This has after same discussion resulted in that we add a macro to handle this. This was partly found using a static code analysis program called cppcheck. Rickard Strandqvist (1): net: wireless: rtlwifi: rtl8188ee:

[PATCH v2] net: wireless: rtlwifi: rtl8188ee: reg.h: Cleaning up if statement that always evaluates to false

2014-06-14 Thread Rickard Strandqvist
I found a logical error in an if statement that always evaluates to false. This has after same discussion resulted in that we add a macro to handle this. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/net/wireless/rtlwifi/rtl8188ee/reg.h |1 + 1 file

Re: [PATCH v2] net: wireless: rtlwifi: rtl8188ee: hw.c: Cleaning up if statement that always evaluates to false

2014-06-14 Thread Peter Wu
On Saturday 14 June 2014 15:24:32 Rickard Strandqvist wrote: I found a logical error in an if statement that always evaluates to false. This has after same discussion resulted in that we add a macro to handle this. This commit message is useless. If you really need to refer to a mailing list

Re: [PATCH v6] iio: add support of the max1027

2014-06-14 Thread Hartmut Knaack
Philippe Reynes schrieb: This driver add partial support of the maxim 1027/1029/1031. Differential mode is not supported. It was tested on armadeus apf27 board. Signed-off-by: Philippe Reynes trem...@yahoo.fr --- .../devicetree/bindings/iio/adc/max1027-adc.txt| 22 +

Re: [PATCH 2/2] iio: mxs-lradc: add ADC channel 9 as a copy of channel 8

2014-06-14 Thread Jonathan Cameron
On 10/06/14 23:51, Marek Vasut wrote: On Tuesday, June 10, 2014 at 03:41:35 PM, Robert Hodaszi wrote: Commit c8231a9af8147f8a401fc55931ec44abfb937660 (iio: mxs-lradc: compute temperature from channel 8 and 9) merged channel 8 and channel 9 to create an IIO_TEMP channel. It changed the number of

Re: [PATCH v6] iio: add support of the max1027

2014-06-14 Thread Hartmut Knaack
Jonathan Cameron schrieb: On 07/06/14 14:38, Philippe Reynes wrote: This driver add partial support of the maxim 1027/1029/1031. Differential mode is not supported. It was tested on armadeus apf27 board. Signed-off-by: Philippe Reynes trem...@yahoo.fr Hi, There is one trivial bit

Re: [PATCH 1/2] iio: mxs-lradc: fix divider

2014-06-14 Thread Jonathan Cameron
On 10/06/14 23:47, Marek Vasut wrote: On Tuesday, June 10, 2014 at 03:41:34 PM, Robert Hodaszi wrote: All channels' single measurement are happening on CH 0. So enabling / disabling the divider once is not enough, because it has impact on all channels. Set only a flag, then check this on each

Re: [PATCH v6] iio: add support of the max1027

2014-06-14 Thread Jonathan Cameron
On 14/06/14 14:52, Hartmut Knaack wrote: Philippe Reynes schrieb: This driver add partial support of the maxim 1027/1029/1031. Differential mode is not supported. It was tested on armadeus apf27 board. Signed-off-by: Philippe Reynes trem...@yahoo.fr Hi Philippe, There's just enough stuff in

Re: [PATCH 2/2] staging: rtl8712: use kcalloc instead of kmalloc(x*y, ...)

2014-06-14 Thread Jonas Gorski
On Sat, Jun 14, 2014 at 1:48 PM, Vitaly Osipov vitaly.osi...@gmail.com wrote: Replaced kmalloc(x*y, ...) with kcalloc(x,y,...) Signed-off-by: Vitaly Osipov vitaly.osi...@gmail.com --- drivers/staging/rtl8712/rtl871x_mlme.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [PATCH] rcu: Only pin GP kthread when full dynticks is actually used

2014-06-14 Thread Paul E. McKenney
On Sat, Jun 14, 2014 at 03:10:15PM +0200, Frederic Weisbecker wrote: On Sat, Jun 14, 2014 at 04:26:39AM -0700, Paul E. McKenney wrote: On Fri, Jun 13, 2014 at 10:06:06PM -0700, Paul E. McKenney wrote: On Sat, Jun 14, 2014 at 01:39:36AM +0200, Frederic Weisbecker wrote: On Fri, Jun 13,

Re: [PATCH 1/1] PM / Runtime: let rpm_resume fail if rpm disabled and device suspended.

2014-06-14 Thread Alan Stern
On Sat, 14 Jun 2014, Allen Yu wrote: dev-power.is_suspended is set after core suspends device during system suspend. This flag mostly means device is not operational (all I/O been quiesced, no more data read or write acceptible, etc.), hence it's dangerous to access hardware if device

Re: [PATCH] staging: ced1401: fix sparse warning for ced1401

2014-06-14 Thread Greg KH
On Sat, Jun 14, 2014 at 02:04:38PM +0900, Seunghun Lee wrote: This patch fixes below warning. drivers/staging/ced1401/ced_ioc.c:703:30: warning: incorrect type in assignment (different address spaces) drivers/staging/ced1401/ced_ioc.c:703:30:expected void *[usertype] lpvBuff

Re: [PATCH v6] iio: add support of the max1027

2014-06-14 Thread Jonathan Cameron
On 14/06/14 15:09, Jonathan Cameron wrote: On 14/06/14 14:52, Hartmut Knaack wrote: Philippe Reynes schrieb: This driver add partial support of the maxim 1027/1029/1031. Differential mode is not supported. It was tested on armadeus apf27 board. Signed-off-by: Philippe Reynes trem...@yahoo.fr

Re: [PATCH 3.15 00/12] 3.15.1-stable review

2014-06-14 Thread Greg Kroah-Hartman
On Sat, Jun 14, 2014 at 07:31:20PM +0900, Satoru Takeuchi wrote: At Fri, 13 Jun 2014 08:16:02 -0700, Guenter Roeck wrote: On 06/12/2014 04:21 PM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 3.15.1 release. There are 12 patches in this series, all

[PATCH 1/2] regulator: max1586 add device-tree support

2014-06-14 Thread Robert Jarzmik
Add device-tree support to max1586. The driver can still be used with the legacy platform data, or the new device-tree way. This work is heavily inspired by the device-tree support of its cousin max8660 driver. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/regulator/max1586.c

[PATCH 2/2] regulator: max1586 add device-tree support

2014-06-14 Thread Robert Jarzmik
Add max1586 regulator device-tree bindings documentation. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- .../bindings/regulator/max1586-regulator.txt | 28 ++ 1 file changed, 28 insertions(+) create mode 100644

Re: [RFC PATCH] OF: fix of_find_node_by_path() assumption that of_allnodes is root

2014-06-14 Thread Grant Likely
On Fri, Jun 13, 2014 at 4:06 PM, Grant Likely grant.lik...@linaro.org wrote: On Fri, Jun 13, 2014 at 2:52 PM, Rob Herring robherri...@gmail.com wrote: On Fri, Jun 13, 2014 at 12:53 AM, Frank Rowand frowand.l...@gmail.com wrote: From: Frank Rowand frank.row...@sonymobile.com Pantelis

Re: [PATCH] staging: iio: fix coding style

2014-06-14 Thread Jonathan Cameron
On 13/06/14 06:56, Jimmy Picard wrote: This patch fixes coding style reported by checkpatch.pl that missing a blank line after declarations. Signed-off-by: Jimmy Picard jimmyp11f...@gmail.com Hmm. This is in the trivial enough to be marginally annoying category of basically noise. Normally

Re: random: Benchamrking fast_mix2

2014-06-14 Thread George Spelvin
Unfortunately, my test suite is not particularly lightweight. Here are some figures (idle at full speed, and doing a parallel kernel compile) for a 2.5 GHz Phenom. Quite different numbers compared to the Ivy Bridge. When the processor is bust, fast_mix takes longer, instead. And even the rolled

[PATCH] usb: gadget: fsl_qe_udc: Introduce use of managed version of kzalloc

2014-06-14 Thread Himangi Saraogi
This patch moves data allocated using kzalloc to managed data allocated using devm_kzalloc and cleans now unnecessary kfrees in probe and remove functions. Also, the unnecesary labels are removed and some labels are renamed to preserve ordering. The following Coccinelle semantic patch was used

[GIT PULL] HSI fixes for 3.16

2014-06-14 Thread Sebastian Reichel
Hi Linus, The following changes since commit eafaebd987fcd001e2c123c050939a29c625d673: HSI: Introduce Nokia N900 modem driver (2014-05-16 00:55:42 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-hsi.git tags/hsi-for-3.16-fixes1 for

Re: [PATCH] staging: iio: fix coding style

2014-06-14 Thread Jonathan Cameron
On 09/04/14 19:09, Joel Porquet wrote: As suggested by checkpatch.pl, use dev_info() instead of printk(KERN_INFO ...) to print message. Signed-off-by: Joel Porquet j...@porquet.org This line has been removed by another patch in the meantime. --- Only tested by compilation.

Re: [Intel-gfx] 3.15-rc5: Regression in i915 driver?

2014-06-14 Thread Thomas Meyer
Am Montag, den 19.05.2014, 09:07 +0200 schrieb Daniel Vetter: On Sun, May 18, 2014 at 08:13:38PM +0100, Chris Wilson wrote: On Sun, May 18, 2014 at 09:08:40PM +0200, Thomas Meyer wrote: Am Montag, den 12.05.2014, 07:33 +0100 schrieb Chris Wilson: On Sun, May 11, 2014 at 07:40:57PM +0200,

Re: Status of Power Supply Subsystem

2014-06-14 Thread Sebastian Reichel
Hi Rafael, You can volunteer to take over the maintainership, but then I guess it would make sense to push this through the PM tree anyway, so please feel free to send a pull request with those fixes to me. I waited a bit to see if maybe Dmitry or David want to give feedback. But I haven't

[PATCH] MAINTAINERS: power_supply: update maintainership

2014-06-14 Thread Sebastian Reichel
Take over maintanence for orphaned power supply subsystem and move the git tree to a new kernel.org based repository. Signed-off-by: Sebastian Reichel s...@kernel.org --- Hi, As suggested by Rafael in [0] I volunteer to take over the orphaned power supply subsystem. [0]

Re: [PATCH] iio: adc: at91_adc: Correct call to input_free_device

2014-06-14 Thread Jonathan Cameron
On 13/06/14 18:11, Himangi Saraogi wrote: This error handling code can be reached before st-ts_input is initialized, so it is safer to always use the original name, input_dev. A simplified version of the semantic match that finds this problem is: // smpl @r exists@ local idexpression struct

[PATCH] Coccinelle : Script to detect cast after memory allocation

2014-06-14 Thread Himangi Saraogi
This script detects cases of use of cast for the value returned by kmalloc, kzalloc, kcalloc, kmem_cache_alloc, kmem_cache_zalloc, kmem_cache_alloc_node, kmalloc_node and kzalloc_node and removes the cast as it is not useful. This Coccinelle script replaces drop_kmalloc_cast.cocci as it removes

RE: [PATCH 2/7] cpufreq: intel_pstate: Avoid duplicate call of intel_pstate_get_scaled_busy

2014-06-14 Thread Doug Smythies
I am sorry to be late chiming in on this one. On 2014.06.10 09:27 Stratos Karafotis wrote: On 10/06/2014 07:05 μμ, Dirk Brandewie wrote: On 06/09/2014 02:00 PM, Stratos Karafotis wrote: Store busy_scaled value to avoid to duplicate call of intel_pstate_get_scaled_busy on every sampling

Re: [PATCHv2 1/2] rx51_battery: convert to iio consumer

2014-06-14 Thread Sebastian Reichel
On Sat, Jun 14, 2014 at 10:32:32AM +0200, Pavel Machek wrote: The problem is, that the power subsystem maintainers seem to be too busy with real life. The last change in their git [0] was 2014-02-01 and I haven't seen any mail from them on the mailinglist since about the same time. I have

Re: Status of Power Supply Subsystem

2014-06-14 Thread David Woodhouse
On Sat, 2014-06-14 at 17:36 +0200, Sebastian Reichel wrote: I waited a bit to see if maybe Dmitry or David want to give feedback. But I haven't received anything, so I volunteer to take this subsystem over. I've never really done much with the subsystem except getting Dmitry set up to

[ANNOUNCE] kmod 18

2014-06-14 Thread Lucas De Marchi
kmod 18 is out: ftp://ftp.kernel.org/pub/linux/utils/kernel/kmod/kmod-18.tar.xz ftp://ftp.kernel.org/pub/linux/utils/kernel/kmod/kmod-18.tar.sign Small fixes to libkmod, tools and testsuite. The biggest visible change is in depmod, that now fails if dependency loops are present.

Re: [PATCH-v2 4/4] random: clean up interrupt entropy accounting for archs w/o cycle counters

2014-06-14 Thread Theodore Ts'o
On Sat, Jun 14, 2014 at 03:28:49AM -0400, George Spelvin wrote: + if (cycles || (fast_pool-notimer_count = 32)) + credit++; Ah, this addresses my concern about too few interrupts, too. If the (non-timer) interrupt rate is less than 32/second, you'll never get any credit.

Re: [PATCH] Coccinelle : Script to detect cast after memory allocation

2014-06-14 Thread Joe Perches
On Sat, 2014-06-14 at 21:15 +0530, Himangi Saraogi wrote: This script detects cases of use of cast for the value returned by kmalloc, kzalloc, kcalloc, kmem_cache_alloc, kmem_cache_zalloc, kmem_cache_alloc_node, kmalloc_node and kzalloc_node and removes the cast as it is not useful. This

Re: [PATCH] Coccinelle : Script to detect cast after memory allocation

2014-06-14 Thread Julia Lawall
On Sat, 14 Jun 2014, Joe Perches wrote: On Sat, 2014-06-14 at 21:15 +0530, Himangi Saraogi wrote: This script detects cases of use of cast for the value returned by kmalloc, kzalloc, kcalloc, kmem_cache_alloc, kmem_cache_zalloc, kmem_cache_alloc_node, kmalloc_node and kzalloc_node and

[PATCH 1/2] selinux: simple cleanup for cond_read_node()

2014-06-14 Thread Namhyung Kim
The node-cur_state and len can be read in a single call of next_entry(). And setting len before reading is a dead write so can be eliminated. Signed-off-by: Namhyung Kim namhy...@kernel.org --- security/selinux/ss/conditional.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff

[PATCH 2/2] selinux: fix a possible memory leak in cond_read_node()

2014-06-14 Thread Namhyung Kim
The cond_read_node() should free the given node on error path as it's not linked to p-cond_list yet. This is done via cond_node_destroy() but it's not called when next_entry() fails before the expr loop. Signed-off-by: Namhyung Kim namhy...@kernel.org --- security/selinux/ss/conditional.c | 2

Re: [PATCH-v2 4/4] random: clean up interrupt entropy accounting for archs w/o cycle counters

2014-06-14 Thread George Spelvin
I agree with your points, with one exception. Which may be me misunderstanding. Also note that the question is not whether the non-timer interrupt rate is less than 32 seconds, but rather out of the last 64 interrupts, how many of the interrupts come from non-timer sources? That's not the

[PATCH] arch: powerpc: platforms: cell: cbe_thermal.c: Cleaning up a variable is of the wrong type

2014-06-14 Thread Rickard Strandqvist
This variable is of the wrong type, everywhere it is used it should be an unsigned int rather than a int. This was partly found using a static code analysis program called cppcheck. Rickard Strandqvist (1): arch: powerpc: platforms: cell: cbe_thermal.c: Cleaning up a variable is of the wrong

[PATCH] arch: powerpc: platforms: cell: cbe_thermal.c: Cleaning up a variable is of the wrong type

2014-06-14 Thread Rickard Strandqvist
This variable is of the wrong type, everywhere it is used it should be an unsigned int rather than a int. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- arch/powerpc/platforms/cell/cbe_thermal.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: random: Benchamrking fast_mix2

2014-06-14 Thread Theodore Ts'o
OK, using your averaging scheme, on a 32-bit KVM kernel, running at idle, here are my quick results: Original 48028 51419 46021 50065 44750 49231 Fastmix 2, 3 interations 95956 58313 97295 57599 97242 56942 Fastmix 2, 2 iterations 68998 41496 68940 41471 68619 41576 Fastmix 2, 2

Re: [PATCH 0/2] make kASLR vs hibernation boot-time selectable

2014-06-14 Thread H. Peter Anvin
On 06/13/2014 05:39 PM, Rafael J. Wysocki wrote: -#define RESTORE_MAGIC0x0123456789ABCDEFUL +#define RESTORE_MAGIC0x0123456789ABCDF0UL bikeshed Please don't pick numbers like this for magic numbers... *everyone else does, too.* In general, picking a random number is a

Re: Status of Power Supply Subsystem

2014-06-14 Thread Dmitry Eremin-Solenikov
Hello, colleagues, On Sat, Jun 14, 2014 at 7:53 PM, David Woodhouse dw...@infradead.org wrote: On Sat, 2014-06-14 at 17:36 +0200, Sebastian Reichel wrote: I waited a bit to see if maybe Dmitry or David want to give feedback. But I haven't received anything, so I volunteer to take this

Re: [PATCH] Coccinelle : Script to detect cast after memory allocation

2014-06-14 Thread Joe Perches
On Sat, 2014-06-14 at 18:11 +0200, Julia Lawall wrote: On Sat, 14 Jun 2014, Joe Perches wrote: [] Perhaps make this more generic for any void *? Something like: @@ void *t; type other; @@ - (other *)t + t [] Perhaps it would be reasonable to add this among

Re: Status of Power Supply Subsystem

2014-06-14 Thread Sebastian Reichel
On Sat, Jun 14, 2014 at 08:59:35PM +0400, Dmitry Eremin-Solenikov wrote: Hello, colleagues, Hi, welcome back :) On Sat, Jun 14, 2014 at 7:53 PM, David Woodhouse dw...@infradead.org wrote: On Sat, 2014-06-14 at 17:36 +0200, Sebastian Reichel wrote: I waited a bit to see if maybe Dmitry or

  1   2   3   4   5   >