Re: [PATCH cgroup/for-4.3-fixes] cgroup, writeback: don't enable cgroup writeback on traditional hierarchies

2015-09-26 Thread Artem Bityutskiy
On Fri, 2015-09-25 at 11:49 -0400, Tejun Heo wrote: > Hello, Artem. I've applied this patch on top of ced255c Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux I've added 'ignore_loglevel' to the kernel boot parameters. I have the serial console configured and I

[PATCHv2 1/3] zpool: add compaction api

2015-09-26 Thread Vitaly Wool
This patch adds two functions to the zpool API: zpool_compact() and zpool_get_num_compacted(). The former triggers compaction for the underlying allocator and the latter retrieves the number of pages migrated due to compaction for the whole time of this pool's existence. Signed-off-by: Vitaly

[PATCHv2 0/3] align zpool/zbud/zsmalloc on the api

2015-09-26 Thread Vitaly Wool
Here comes the second iteration over zpool/zbud/zsmalloc API alignment. This time I divide it into three patches: for zpool, for zbud and for zsmalloc :) Patches are non-intrusive and do not change any existing functionality. They only add up stuff for the alignment purposes. -- To unsubscribe

Re: [PATCH] coccinelle: assign signed result to unsigned variable

2015-09-26 Thread SF Markus Elfring
> To collect function calls that have a return value of a given type t, > it should be sufficient to do the following: > > @@ > t e; > identifier f; > @@ > > f(...)@e Is such a SmPL approach better than a variant like the following? @find_function@ type t; identifier f; @@ t f(...) { ... }

Re: [PATCH] coccinelle: assign signed result to unsigned variable

2015-09-26 Thread Julia Lawall
On Sat, 26 Sep 2015, SF Markus Elfring wrote: > > To collect function calls that have a return value of a given type t, > > it should be sufficient to do the following: > > > > @@ > > t e; > > identifier f; > > @@ > > > > f(...)@e > > Is such a SmPL approach better than a variant like the

Re: [PATCH] coccinelle: assign signed result to unsigned variable

2015-09-26 Thread SF Markus Elfring
> Generally I want to catch all assignments of signed function result to > unsigned var. Such a static source code analysis will be useful to some degree. > In this script I have implemented it this way: > 1. Look for all assignments 'unsigned = signed' (rs rule). > 2. Check if signed from rs

Re: [PATCH 10/26] x86, pkeys: notify userspace about protection key faults

2015-09-26 Thread Ingo Molnar
* Dave Hansen wrote: > On 09/25/2015 12:11 AM, Ingo Molnar wrote: > >>> > > Btw., how does pkey support interact with hugepages? > >> > > >> > Surprisingly little. I've made sure that everything works with huge > >> > pages and > >> > that the (huge) PTEs and VMAs get set up

Re: [GIT PULL 0/3] perf/urgent fixes

2015-09-26 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > Hi Ingo, > > Please consider pulling, > > - Arnaldo > > The following changes since commit d0d0313c2ae4bc220c4ed96ce340860a4e74a2e9: > > Merge tag 'perf-urgent-for-mingo' of >

Re: [PATCH 1/2] x86/efi: Map EFI memmap entries in-order at runtime

2015-09-26 Thread Ard Biesheuvel
On 25 September 2015 at 22:56, Ingo Molnar wrote: > > So this commit worries me. > > This bug is a good find, and the fix is obviously needed and urgent, but I'm > not > sure about the implementation at all. (I've Cc:-ed a few more x86 low level > gents.) > > * Matt Fleming

Re: AMD-IOMMU and problem with __init(data)?

2015-09-26 Thread Alexander Holler
Am 23.09.2015 um 21:04 schrieb Alexander Holler: Am 23.09.2015 um 17:50 schrieb Alexander Holler: Am 23.09.2015 um 13:43 schrieb Joerg Roedel: If it's necessary, I could try put together a small patch which kills a system (reproducible here). That would help too, please also send me your

Re: [PATCH v2 4/7] x86, acpi, cpu-hotplug: Enable acpi to register all possible cpus at boot time.

2015-09-26 Thread Tang Chen
Hi Rafael, On 09/11/2015 07:10 AM, Rafael J. Wysocki wrote: On Thursday, September 10, 2015 12:27:46 PM Tang Chen wrote: .. Can you please avoid using the same (or at least very similar changelog) for multiple patches in the series? That doesn't help a lot. OK, will update the comment

Re: [PATCH] Input: input.h: Fix EVIOCSFF macro inconsistency by using _IOW()

2015-09-26 Thread Elias Vanderstuyft
On Thu, Sep 17, 2015 at 7:26 PM, Elias Vanderstuyft wrote: > Just like the EVIOCSABS(abs) macro, use the more compact > _IOW(..., type) instead of _IOC(_IOC_WRITE, ..., sizeof(type)) > for the EVIOCSFF macro. > > Signed-off-by: Elias Vanderstuyft > --- >

Re: [PATCH] coccinelle: assign signed result to unsigned variable

2015-09-26 Thread SF Markus Elfring
>> The connection between the SmPL specification "f(...)@e" and the desired >> return type >> was not obvious for me so far. > > The nearest enclosing expression of the ) is the whole function call itself. Thanks for your explanation. Now I guess that the enclosing context is a particular

Re: [PATCH 3/5] UBI: switch the UBI device in read-only mode when mtd returns -EROFS

2015-09-26 Thread Boris Brezillon
Hi Richard, On Fri, 25 Sep 2015 19:34:42 +0200 Richard Weinberger wrote: > Am 25.09.2015 um 17:09 schrieb Boris Brezillon: > > The NAND layer is now able to forward power-cut emulation errors from > > a NAND driver to the MTD user. > > Check for this kind of errors in UBI and

Re: [PATCH v2 3/7] x86, gfp: Cache best near node for memory allocation.

2015-09-26 Thread Tang Chen
Hi, tj On 09/11/2015 03:29 AM, Tejun Heo wrote: Hello, On Thu, Sep 10, 2015 at 12:27:45PM +0800, Tang Chen wrote: diff --git a/include/linux/gfp.h b/include/linux/gfp.h index ad35f30..1a1324f 100644 --- a/include/linux/gfp.h +++ b/include/linux/gfp.h @@ -307,13 +307,19 @@ static inline struct

Re: [RFT v3] eata: Convert eata driver as normal PCI and platform device drivers

2015-09-26 Thread Arthur Marsh
Arthur Marsh wrote on 24/09/15 15:26: Jiang Liu wrote on 24/09/15 13:58: Hi James, Thanks for review. How about the attached patch which addresses the three suggestions from you? Thanks! Gerry I've applied the patch, rebuilt the kernel and verified that it allows unloading of the

[PATCH] btrfs: remove unneeded NULL initializer for struct fs_path

2015-09-26 Thread Alexandru Moise
fs_path_alloc() either returns an alloc'ed struct fs_path or NULL, no need to initialize the pointer to NULL. Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com> --- fs/btrfs/send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c

Re: No more new fbdev drivers, please

2015-09-26 Thread Geert Uytterhoeven
On Fri, Sep 25, 2015 at 12:41 PM, Kamil Lulko wrote: >> fbdev is (more or less) maintained, but it's a deprecated framework. All >> new Linux display drivers should be done on DRM. > > > What about no-mmu platforms? DRM has a big fat MMU dependency in the > kconfig, is

[PATCH] genirq: Fix race in register_irq_proc()

2015-09-26 Thread Ben Hutchings
Per-IRQ directories in procfs are created only when a handler is first added to the irqdesc, not when the irqdesc is created. In the case of a shared IRQ, multiple tasks can race to create a directory. This race condition seems to have been present forever, but is easier to hit with async

[PATCH 1/1] dmaengine: dw: resolve recursion lock when audio playback

2015-09-26 Thread yitian
when audio playback is running, user space will call snd_pcm_lib_write1() function, it will first get pcm stream lock, after that it may call function snd_pcm_update_hw_ptr(), the call stack will be as below: snd_pcm_lib_write1 <-- got pcm stream lock --> snd_pcm_update_hw_ptr -->

Re: [PATCH 2/2] arm64/efi: Don't pad between EFI_MEMORY_RUNTIME regions

2015-09-26 Thread Ard Biesheuvel
On 25 September 2015 at 23:01, Ingo Molnar wrote: > > * Matt Fleming wrote: > >> From: Ard Biesheuvel >> >> The new Properties Table feature introduced in UEFIv2.5 may split >> memory regions that cover PE/COFF memory images

[PATCHv2 2/3] zbud: add compaction callbacks

2015-09-26 Thread Vitaly Wool
Add no-op compaction callbacks to zbud. Signed-off-by: Vitaly Wool --- mm/zbud.c | 12 1 file changed, 12 insertions(+) diff --git a/mm/zbud.c b/mm/zbud.c index fa48bcdf..d67c0aa 100644 --- a/mm/zbud.c +++ b/mm/zbud.c @@ -195,6 +195,16 @@ static void

[PATCH 0/5] memcg: charge page tables (x86) and pipe buffers

2015-09-26 Thread Vladimir Davydov
Hi, There are at least two object types left that can be allocated by an unprivileged process and go uncharged to memcg - pipe buffers and page tables. This patch set tries to make them accounted. Comments are welcome. Thanks, Vladimir Davydov (5): mm: uncharge kmem pages from generic

[PATCH 2/5] fs: charge pipe buffers to memcg

2015-09-26 Thread Vladimir Davydov
Pipe buffers can be generated unrestrictedly by an unprivileged userspace process, so they shouldn't go unaccounted. Signed-off-by: Vladimir Davydov --- fs/pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/pipe.c b/fs/pipe.c index

[PATCH 1/5] mm: uncharge kmem pages from generic free_page path

2015-09-26 Thread Vladimir Davydov
Currently, to charge a page to kmemcg one should use alloc_kmem_pages helper. When the page is not needed anymore it must be freed with free_kmem_pages helper, which will uncharge the page before freeing it. Such a design is acceptable for thread info pages and kmalloc large allocations, which are

[PATCH 5/5] x86: charge page table pages to memcg

2015-09-26 Thread Vladimir Davydov
As noted in the comment to commit dc6c9a35b66b5 ("mm: account pmd page tables to the process"), "unprivileged process can allocate significant amount of memory -- >500 MiB on x86_64 -- and stay unnoticed by oom-killer and memory cgroup". While the above-mentioned commit fixed the problem in case

[PATCH 3/5] memcg: teach uncharge_list to uncharge kmem pages

2015-09-26 Thread Vladimir Davydov
Page table pages are batched-freed in release_pages on most architectures. If we want to charge them to kmemcg (this is what is done later in this series), we need to teach mem_cgroup_uncharge_list to handle kmem pages. With PageKmem helper introduced previously this is trivial. Signed-off-by:

[PATCH 4/5] mm: add __get_free_kmem_pages helper

2015-09-26 Thread Vladimir Davydov
Works exactly as __get_free_pages except it also tries to charge newly allocated pages to kmemcg. It will be used by the next patch. Signed-off-by: Vladimir Davydov --- include/linux/gfp.h | 1 + mm/page_alloc.c | 12 2 files changed, 13 insertions(+)

Re: [PATCH 2/2] arm64/efi: Don't pad between EFI_MEMORY_RUNTIME regions

2015-09-26 Thread Ingo Molnar
* Matt Fleming wrote: > From: Ard Biesheuvel > > The new Properties Table feature introduced in UEFIv2.5 may split > memory regions that cover PE/COFF memory images into separate code > and data regions. Since these regions only differ in

Re: No more new fbdev drivers, please

2015-09-26 Thread Ilia Mirkin
On Sat, Sep 26, 2015 at 3:15 AM, Sudip Mukherjee wrote: > BTW, I had a doubt about drm drivers. Is there any library or test suite > to test the driver? I am almost halfway in making a KMS driver for SM712 > but still don't know how to test it properly. I was thinkig

[PATCH] usb: gadget: bdc: fix memory leak

2015-09-26 Thread Sudip Mukherjee
If dma_pool_alloc() fails we are jumping to fail and releasing all the bd_tables which have been added to the chain but we missed freeing this bd_table which was just allocated and still not added to the chain of bd_table. Signed-off-by: Sudip Mukherjee ---

Re: [PATCH v2 3/7] x86, gfp: Cache best near node for memory allocation.

2015-09-26 Thread Tang Chen
Hi, Christoph, tj, On 09/11/2015 08:14 AM, Christoph Lameter wrote: On Thu, 10 Sep 2015, Tejun Heo wrote: Why not just update node_data[]->node_zonelist in the first place? Also, what's the synchronization rule here? How are allocators synchronized against node hot [un]plugs? Also,

Re: [PATCH v4 3/5] ARM: mediatek: add smp bringup code

2015-09-26 Thread Russell King - ARM Linux
On Thu, Sep 24, 2015 at 11:38:58PM +0800, Yingjoe Chen wrote: > +struct mtk_smp_boot_info { > + unsigned long smp_base; ... > +static const struct mtk_smp_boot_info mtk_mt8135_tz_boot = { > + 0x80002000, 0x3fc, ... > +static const struct mtk_smp_boot_info mtk_mt6589_boot = { > +

Re: [PATCH v2 5/7] x86, acpi, cpu-hotplug: Introduce apicid_to_cpuid[] array to store persistent cpuid <-> apicid mapping.

2015-09-26 Thread Tang Chen
Hi tj, On 09/11/2015 03:55 AM, Tejun Heo wrote: Hello, So, overall, I think this is the right way to go although I have no idea whether the acpi part is okay. Thank you very much for reviewing. :) +/* + * Current allocated max logical CPU ID plus 1. + * All allocated CPU ID should be in

Re: [PATCH] coccinelle: assign signed result to unsigned variable

2015-09-26 Thread SF Markus Elfring
> Your approach finds a function definition. Yes. - I assumed that it might also be relevant. > My approach works on the call directly, using whatever type information is > available. The connection between the SmPL specification "f(...)@e" and the desired return type was not obvious for me

arch/x86: memcpy() "confusion"

2015-09-26 Thread Sedat Dilek
Hi, while still playing with llvmlinux patches against Linux v4.3-rc2+ I wondered about the diverse usage of memcpy() in several string*.[c,h] files below x86 arch. Just FYI: I am here on Ubuntu/precise AMD64. The background is my build breaks again due to commit (see [1])... "x86, efi,

[PATCH] cpufreq: p4-clockmod: Replace bool_int_array[NR_CPUS] with bitmap

2015-09-26 Thread Denys Vlasenko
Straigntforward conversion from int has_N44_O17_errata[NR_CPUS] to DECLARE_BITMAP(has_N44_O17_errata, NR_CPUS) Saves about 2 kbytes in bss for NR_CPUS=512. Signed-off-by: Denys Vlasenko CC: Viresh Kumar CC: Rafael J. Wysocki

[PATCH] x86/kgdb: Replace bool_int_array[NR_CPUS] with bitmap

2015-09-26 Thread Denys Vlasenko
Straigntforward conversion from int was_in_debug_nmi[NR_CPUS] to DECLARE_BITMAP(was_in_debug_nmi, NR_CPUS) Saves about 2 kbytes in bss for NR_CPUS=512. Signed-off-by: Denys Vlasenko CC: Jason Wessel CC: Ingo Molnar CC:

Re: [RFC] PCI: Unassigned Expansion ROM BARs

2015-09-26 Thread Daniel J Blueman
On Thursday, September 24, 2015 at 10:50:07 AM UTC+8, Myron Stowe wrote: > I've encountered numerous bugzilla reports related to platform BIOS' not > programming valid values into a PCI device's Type 0 Configuration space > "Expansion ROM Base Address" field (a.k.a. Expansion ROM BAR). The main >

[PATCHv2 3/3] zsmalloc: add compaction callbacks

2015-09-26 Thread Vitaly Wool
Add compaction callbacks for zpool compaction API extension. Signed-off-by: Vitaly Wool --- mm/zsmalloc.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index f135b1b..8f2ddd1 100644 --- a/mm/zsmalloc.c +++

Re: No more new fbdev drivers, please

2015-09-26 Thread Geert Uytterhoeven
Hi Daniel, On Thu, Sep 24, 2015 at 5:23 PM, Daniel Vetter wrote: > On Thu, Sep 24, 2015 at 02:46:21PM +0200, Thomas Petazzoni wrote: >> Or are there some plans to make the writing of DRM drivers for very >> simple/trivial devices a bit simpler? > > Since years I'm trying to sell

[PATCH v2] fbdev: broadsheetfb: fix memory leak

2015-09-26 Thread Sudip Mukherjee
We have requested the firmware and it was loaded but we missed releasing it both on success and error. Signed-off-by: Sudip Mukherjee --- v1: relased the firmware only on the error path. drivers/video/fbdev/broadsheetfb.c | 8 +--- 1 file changed, 5 insertions(+), 3

Re: [PATCH 3/3] drivers/misc/sgi-gru: fix return of error

2015-09-26 Thread Dimitri Sivanich
Acked-by: Dimitri Sivanich On Mon, Sep 21, 2015 at 03:48:19PM +0530, Sudip Mukherjee wrote: > If kzalloc() fails then gms is NULL and we are returning NULL, but the > functions which called this function gru_register_mmu_notifier() are not > expecting NULL as the return. They

Re: [RESEND PATCH] sched: consider missed ticks when updating global cpu load

2015-09-26 Thread Frederic Weisbecker
On Fri, Sep 25, 2015 at 05:52:37PM +0900, byungchul.p...@lge.com wrote: > From: Byungchul Park > > hello, > > i have already sent this patch about 1 month ago. > (see https://lkml.org/lkml/2015/8/13/160) > > now, i am resending the same patch with adding some additional

RE: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle

2015-09-26 Thread Chen, Yu C
Hi, Rafael, > -Original Message- > From: linux-pm-ow...@vger.kernel.org [mailto:linux-pm- > ow...@vger.kernel.org] On Behalf Of Rafael J. Wysocki > Sent: Friday, September 25, 2015 9:57 PM > To: Chen, Yu C > Cc: Wysocki, Rafael J; jiang@linux.intel.com; Zhang, Rui; Brown, Len; >

[PATCH] Documentation: ACPI: add copy_dsdt to ACPI format options.

2015-09-26 Thread Rami Rosen
commit aa2110cb1a7510f9b834adfb39b05d4843a35d35 ("ACPI: add boot option acpi=copy_dsdt to fix corrupt DSDT") added copy_dsdt as an ACPI boot option, but did not add it to ACPI format options in Documentation/kernel-parameters.txt. This patch fixes it. Signed-off-by: Rami Rosen

[GIT PULL] char/misc driver fixes for 4.3-rc3

2015-09-26 Thread Greg KH
The following changes since commit 1f93e4a96c9109378204c147b3eec0d0e8100fde: Linux 4.3-rc2 (2015-09-20 14:32:34 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/ tags/char-misc-4.3-rc3 for you to fetch changes up to

[PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

2015-09-26 Thread Punit Vara
This patch is to the rtl871x_ioctl_linux.c that fixes up following warning reported by checkpatch.pl : - Comparisons should place the constant on the right side of the test Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 1

Re: rwx mapping between ex_table and rodata

2015-09-26 Thread Kees Cook
On Fri, Sep 25, 2015 at 12:22 AM, Ingo Molnar wrote: > > * Kees Cook wrote: > >> On Thu, Sep 24, 2015 at 1:26 PM, Stephen Smalley wrote: >> > Hi, >> > >> > With the attached config and 4.3-rc2 on x86_64, I see the following in >> >

[GIT PULL] Driver core fixes for 4.3-rc3

2015-09-26 Thread Greg KH
The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: Linux 4.3-rc1 (2015-09-12 16:35:56 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/ tags/driver-core-4.3-rc3 for you to fetch changes up to

Re: [PATCH 1/2] x86/efi: Map EFI memmap entries in-order at runtime

2015-09-26 Thread H. Peter Anvin
I think it "works" because the affected BIOSes don't put spaces between the chunks. I have discussed this with Matt. On September 26, 2015 10:01:14 AM PDT, Andy Lutomirski wrote: >On Fri, Sep 25, 2015 at 10:56 PM, Ingo Molnar wrote: >> >> So this commit

Re: [PATCH v4 6/7] blk-mq: fix freeze queue race

2015-09-26 Thread Tejun Heo
Hello, On Sun, Sep 27, 2015 at 02:09:24AM +0900, Akinobu Mita wrote: > @@ -420,7 +420,9 @@ static void blk_mq_sysfs_init(struct request_queue *q) > /* see blk_register_queue() */ > void blk_mq_finish_init(struct request_queue *q) > { > + mutex_lock(>mq_freeze_lock); >

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

2015-09-26 Thread Larry Finger
On 09/26/2015 11:49 AM, Punit Vara wrote: This patch is to the rtl871x_ioctl_linux.c that fixes up following warning reported by checkpatch.pl : - Comparisons should place the constant on the right side of the test Signed-off-by: Punit Vara This warning is crap. WTF

Re: [PATCH V2] staging: rtl8723au: Remove unneeded endianness conversions

2015-09-26 Thread Larry Finger
On 09/24/2015 02:11 AM, Lars Svensson wrote: Fixing Sparse warnings in rtw_security.c. When checking crc, both actual and expected value was converted to cpu endianness before comparing, causing sparse warnings as below. Since the values are read from the buffer in correct byte order the extra

Re: drivers/power/wm831x_power.c:569:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

2015-09-26 Thread Sebastian Reichel
Hi Valentin, On Tue, Sep 22, 2015 at 07:28:23PM +0200, Valentin Rothberg wrote: > From bceb7cace76aba9212db56be939bfecaacb75bc2 Mon Sep 17 00:00:00 2001 > From: Valentin Rothberg > Date: Tue, 22 Sep 2015 19:00:40 +0200 > Subject: [PATCH] wm831x_power: Use IRQF_ONESHOT

Re: [PATCH v3] drivers: power: twl4030_charger: fix link problems when building as module

2015-09-26 Thread Sebastian Reichel
Hi Marek, On Fri, Sep 25, 2015 at 10:20:45PM +0200, Marek Belisko wrote: > If either twl4030_charger or twl4030_madc is configured as MODULE, > we get build (link) errors. > > To solve, the direct call of twl4030_get_madc_conversion() is replaced > by a call to iio_read_channel_processed(). > >

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

2015-09-26 Thread punit vara
On Sat, Sep 26, 2015 at 11:15 PM, Larry Finger wrote: > On 09/26/2015 11:49 AM, Punit Vara wrote: >> >> This patch is to the rtl871x_ioctl_linux.c that fixes up following >> warning reported by checkpatch.pl : >> >> - Comparisons should place the constant on the right

Re: [PATCH v2 3/7] x86, gfp: Cache best near node for memory allocation.

2015-09-26 Thread Tejun Heo
Hello, Tang. On Sat, Sep 26, 2015 at 05:31:07PM +0800, Tang Chen wrote: > >>@@ -307,13 +307,19 @@ static inline struct page *alloc_pages_node(int nid, > >>gfp_t gfp_mask, > >>if (nid < 0) > >>nid = numa_node_id(); > >>+ if (!node_online(nid)) > >>+ nid =

Re: [PATCH v4 1/7] blk-mq: avoid setting hctx->tags->cpumask before allocation

2015-09-26 Thread Christoph Hellwig
Looks good. I actually just came up with exactly the same fix after Keith told me to test hotplug for my nvme changes. Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

Re: No more new fbdev drivers, please

2015-09-26 Thread David Herrmann
Hi On Sat, Sep 26, 2015 at 8:01 PM, Geert Uytterhoeven wrote: > Hi Alex, > > On Sat, Sep 26, 2015 at 7:07 PM, Alex Deucher wrote: >> On Sat, Sep 26, 2015 at 4:28 AM, Geert Uytterhoeven >> wrote: >>> On Thu, Sep 24, 2015 at 5:23

Re: First kernel patch (optimization)

2015-09-26 Thread Eric Curtin
Hi Dimitry, > Is it Debian-derivative by any chance? Their capslock setup is wonky > because CapsLock key does no actually set up as a CapsLock but another > modifier. Also is it in X or is it on text console? Because X handles > led state on its own... I'm on Fedora 22. Yeah, you're correct X

[PATCH] rtc: Add a driver for Micro Crystal RV8803

2015-09-26 Thread Alexandre Belloni
This driver supports the following functions: - reading and settings time - alarms when connected to an IRQ - reading and clearing the voltage low flags - nvram Signed-off-by: Alexandre Belloni --- drivers/rtc/Kconfig | 9 + drivers/rtc/Makefile

Re: [PATCH] coccinelle: assign signed result to unsigned variable

2015-09-26 Thread Julia Lawall
On Sat, 26 Sep 2015, SF Markus Elfring wrote: > >> The connection between the SmPL specification "f(...)@e" and the desired > >> return type > >> was not obvious for me so far. > > > > The nearest enclosing expression of the ) is the whole function call itself. > > Thanks for your explanation. >

Re: [RFC PATCH] PM / Runtime: runtime: Add sysfs option for forcing runtime suspend

2015-09-26 Thread Alan Stern
On Sat, 26 Sep 2015, Rafael J. Wysocki wrote: > > > So something like: > > > > > > echo on >/sys/.../power/control (in case the device was > > > already in runtime suspend with wakeups enabled) > > > echo off >/sys/.../power/wakeup > > > echo auto >/sys/.../power/control

Re: [PATCH] coccinelle: assign signed result to unsigned variable

2015-09-26 Thread Julia Lawall
On Sat, 26 Sep 2015, SF Markus Elfring wrote: > >> * Will a command-line parameter like "--include-headers-for-types" > >> be needed here? > > > > This argument is never needed. It is only an optimization. It means that > > he header files are only considered when collecting type information,

[PATCH v4 5/7] blk-mq: avoid inserting requests before establishing new mapping

2015-09-26 Thread Akinobu Mita
Notifier callbacks for CPU_ONLINE action can be run on the other CPU than the CPU which was just onlined. So it is possible for the process running on the just onlined CPU to insert request and run hw queue before establishing new mapping which is done by blk_mq_queue_reinit_notify(). This can

[PATCH v4 7/7] blk-mq: fix deadlock when reading cpu_list

2015-09-26 Thread Akinobu Mita
CPU hotplug handling for blk-mq (blk_mq_queue_reinit) acquires all_q_mutex in blk_mq_queue_reinit_notify() and then removes sysfs entries by blk_mq_sysfs_unregister(). Removing sysfs entry needs to be blocked until the active reference of the kernfs_node to be zero. On the other hand, reading

[PATCH v4 6/7] blk-mq: fix freeze queue race

2015-09-26 Thread Akinobu Mita
There are several race conditions while freezing queue. When unfreezing queue, there is a small window between decrementing q->mq_freeze_depth to zero and percpu_ref_reinit() call with q->mq_usage_counter. If the other calls blk_mq_freeze_queue_start() in the window, q->mq_freeze_depth is

[PATCH v4 0/7] blk-mq: fix race conditions on cpu hotplug handling

2015-09-26 Thread Akinobu Mita
This patchset addresses several race conditions on cpu hotplug handling for blk-mq. All problems can be reproducible by the following script. while true; do echo 0 > /sys/devices/system/cpu/cpu1/online echo 1 > /sys/devices/system/cpu/cpu1/online done & while true; do

Re: [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode

2015-09-26 Thread Sebastian Reichel
Hi Marek, On Fri, Sep 25, 2015 at 10:20:47PM +0200, Marek Belisko wrote: > Added new iio properties which are required for twl4030-charger driver and > allow to use twl4030-madc indirectly. > > Signed-off-by: Marek Belisko > --- > arch/arm/boot/dts/twl4030.dtsi | 2 ++ > 1

Re: [PATCH] HID: hid-input: allow input_configured callback return errors

2015-09-26 Thread Nikolai Kondrashov
On 09/26/2015 02:14 AM, Dmitry Torokhov wrote: When configuring input device via input_configured callback we may encounter errors (for example input_mt_init_slots() may fail). Instead of continuing with half-initialized input device let's allow driver indicate failures. diff --git

[PATCH] Input: serio - fix blocking of parport

2015-09-26 Thread Sudip Mukherjee
If parkbd_allocate_serio() fails to allocate memory we are releasing the parport but we missed unregistering the device. As a result this device with exclusive access to that parport remains registered. And no other device will be able to use that parport even though this driver has failed to

[PATCH] regulator: axp20x: Fix enable bit indexes for DCDC4 and DCDC5

2015-09-26 Thread Chen-Yu Tsai
The enable bit indexes for DCDC4 and DCDC5 regulators are off by 1. We haven't run into any problems with this since either the regulators aren't defined in the DT and aren't used, or all the DCDC regulators have the "always-on" property set, as they are almost always used for system critical

Re: [PATCH] coccinelle: assign signed result to unsigned variable

2015-09-26 Thread SF Markus Elfring
> It doesn't matter, as long as the type is available. I suggest to make the circumstances better known when this will be the case. >> How do you think about reuse another data type enumeration there? > > No idea what you mean by this. A SmPL variable can also be connected with a data type

Re: [PATCH v3 1/3] ARM: uniphier: add outer cache support

2015-09-26 Thread Masahiro Yamada
2015-09-22 14:27 GMT+09:00 Masahiro Yamada : > Hi Russell, > > > 2015-09-22 4:38 GMT+09:00 Russell King - ARM Linux : >> On Fri, Sep 18, 2015 at 01:37:32PM +0900, Masahiro Yamada wrote: >>> +/** >>> + * __uniphier_cache_maint_common - run a

Re: drivers/power/wm831x_power.c:569:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

2015-09-26 Thread Sebastian Reichel
Hi, On Tue, Sep 22, 2015 at 10:01:33PM +0200, Valentin Rothberg wrote: > I CCed Anton, who signed with Mark the responsible commit. mh Mark is now working for Linaro, so he probably didn't see this thread and Anton no longer maintains the power-supply subsystem. Maybe you could add support for

[GIT PULL] TTY/Serial fixes for 4.3-rc3

2015-09-26 Thread Greg KH
The following changes since commit 1f93e4a96c9109378204c147b3eec0d0e8100fde: Linux 4.3-rc2 (2015-09-20 14:32:34 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/ tags/tty-4.3-rc3 for you to fetch changes up to

[GIT PULL] Staging driver fixes for 4.3-rc3

2015-09-26 Thread Greg KH
The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: Linux 4.3-rc1 (2015-09-12 16:35:56 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.3-rc3 for you to fetch changes up to

[GIT PULL] USB driver fixes for 4.3-rc3

2015-09-26 Thread Greg KH
The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: Linux 4.3-rc1 (2015-09-12 16:35:56 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.3-rc3 for you to fetch changes up to

Re: [PATCH 1/2] x86/efi: Map EFI memmap entries in-order at runtime

2015-09-26 Thread Andy Lutomirski
On Fri, Sep 25, 2015 at 10:56 PM, Ingo Molnar wrote: > > So this commit worries me. > > This bug is a good find, and the fix is obviously needed and urgent, but I'm > not > sure about the implementation at all. (I've Cc:-ed a few more x86 low level > gents.) > > * Matt Fleming

Re: [PATCH v2 5/7] x86, acpi, cpu-hotplug: Introduce apicid_to_cpuid[] array to store persistent cpuid <-> apicid mapping.

2015-09-26 Thread Tejun Heo
On Sat, Sep 26, 2015 at 05:52:09PM +0800, Tang Chen wrote: > >>+static int allocate_logical_cpuid(int apicid) > >>+{ > >>+ int i; > >>+ > >>+ /* > >>+* cpuid <-> apicid mapping is persistent, so when a cpu is up, > >>+* check if the kernel has allocated a cpuid for it. > >>+*/ >

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

2015-09-26 Thread Joshua Clayton
On Saturday, September 26, 2015 11:24:06 PM punit vara wrote: > On Sat, Sep 26, 2015 at 11:15 PM, Larry Finger > wrote: > > On 09/26/2015 11:49 AM, Punit Vara wrote: > >> > >> This patch is to the rtl871x_ioctl_linux.c that fixes up following > >> warning reported by

Re: x86_64: MAX_LOCAL_APIC way too big?

2015-09-26 Thread Ingo Molnar
* Denys Vlasenko wrote: > For 64-bit kernels, MAX_LOCAL_APIC is 32k: > > #ifdef CONFIG_X86_32 > ... > #else > # define MAX_IO_APICS 128 > # define MAX_LOCAL_APIC 32768 > #endif > > (It seems to be a bit of a misnomer, it's not a maximum > number of APICs we support, it's

[tip:perf/urgent] perf intel-pt: Remove no_force_psb from documentation

2015-09-26 Thread tip-bot for Adrian Hunter
Commit-ID: 597ee40722bf05195f91a41e88e15b79bdab152c Gitweb: http://git.kernel.org/tip/597ee40722bf05195f91a41e88e15b79bdab152c Author: Adrian Hunter AuthorDate: Thu, 24 Sep 2015 13:05:21 +0300 Committer: Arnaldo Carvalho de Melo CommitDate:

[tip:perf/urgent] perf tools: Fix copying of /proc/kcore

2015-09-26 Thread tip-bot for Adrian Hunter
Commit-ID: b5cabbcbd157a4bf5a92dfc85134999a3b55342d Gitweb: http://git.kernel.org/tip/b5cabbcbd157a4bf5a92dfc85134999a3b55342d Author: Adrian Hunter AuthorDate: Thu, 24 Sep 2015 13:05:22 +0300 Committer: Arnaldo Carvalho de Melo CommitDate:

[tip:perf/urgent] perf probe: Use existing routine to look for a kernel module by dso->short_name

2015-09-26 Thread tip-bot for Arnaldo Carvalho de Melo
Commit-ID: 266fa2b22294909ddf6e7d2f8acfe07adf9fd978 Gitweb: http://git.kernel.org/tip/266fa2b22294909ddf6e7d2f8acfe07adf9fd978 Author: Arnaldo Carvalho de Melo AuthorDate: Thu, 24 Sep 2015 11:24:18 -0300 Committer: Arnaldo Carvalho de Melo CommitDate:

Re: No more new fbdev drivers, please

2015-09-26 Thread Sudip Mukherjee
On Thu, Sep 24, 2015 at 03:27:01PM +0300, Tomi Valkeinen wrote: > Hi all, > > fbdev is (more or less) maintained, but it's a deprecated framework. All > new Linux display drivers should be done on DRM. > > SM750 hardware seems to support multiple outputs, hardware overlays, 2D > accelerator...

Re: [PATCH] coccinelle: assign signed result to unsigned variable

2015-09-26 Thread Julia Lawall
To collect function calls that have a return value of a given type t, it should be sufficient to do the following: @@ t e; identifier f; @@ f(...)@e The @e notation reaches upwards to match the innermost enclosing term of the right kind (here expression). t can of course be arbitrarily

Re: [PATCH] coccinelle: assign signed result to unsigned variable

2015-09-26 Thread Julia Lawall
On Sat, 26 Sep 2015, SF Markus Elfring wrote: > > Your approach finds a function definition. > > Yes. - I assumed that it might also be relevant. > > > > > My approach works on the call directly, using whatever type information is > > available. > > The connection between the SmPL

[PATCH] rtc: rx8025: remove unnecessary braces

2015-09-26 Thread Alexandre Belloni
braces {} are not necessary for single statement blocks Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rx8025.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-rx8025.c b/drivers/rtc/rtc-rx8025.c index

[PATCH v3] platform/x86: Toshiba WMI Hotkey Driver

2015-09-26 Thread Azael Avalos
Toshiba laptops that feature WMI events for hotkeys were left unsupported by the toshiba_acpi driver, however, commit a88bc06e5aec ("toshiba_acpi: Avoid registering input device on WMI event laptops") added hardware support for such laptops, but the hotkeys are not handled there. This driver adds

Re: [PATCH] coccinelle: assign signed result to unsigned variable

2015-09-26 Thread Julia Lawall
On Sat, 26 Sep 2015, SF Markus Elfring wrote: > > It doesn't matter, as long as the type is available. > > I suggest to make the circumstances better known when this will be the case. It is like for the type of anything. If the declaration of the thing is available with the type information, eg

[PATCH v4 3/7] blk-mq: Fix use after of free q->mq_map

2015-09-26 Thread Akinobu Mita
CPU hotplug handling for blk-mq (blk_mq_queue_reinit) updates q->mq_map by blk_mq_update_queue_map() for all request queues in all_q_list. On the other hand, q->mq_map is released before deleting the queue from all_q_list. So if CPU hotplug event occurs in the window, invalid memory access can

[PATCH v4 1/7] blk-mq: avoid setting hctx->tags->cpumask before allocation

2015-09-26 Thread Akinobu Mita
When unmapped hw queue is remapped after CPU topology is changed, hctx->tags->cpumask has to be set after hctx->tags is setup in blk_mq_map_swqueue(), otherwise it causes null pointer dereference. Fixes: f26cdc8536 ("blk-mq: Shared tag enhancements") Signed-off-by: Akinobu Mita

[PATCH v4 2/7] blk-mq: fix sysfs registration/unregistration race

2015-09-26 Thread Akinobu Mita
There is a race between cpu hotplug handling and adding/deleting gendisk for blk-mq, where both are trying to register and unregister the same sysfs entries. null_add_dev --> blk_mq_init_queue --> blk_mq_init_allocated_queue --> add to 'all_q_list' (*) --> add_disk

[PATCH v4 4/7] blk-mq: fix q->mq_usage_counter access race

2015-09-26 Thread Akinobu Mita
CPU hotplug handling for blk-mq (blk_mq_queue_reinit) accesses q->mq_usage_counter while freezing all request queues in all_q_list. On the other hand, q->mq_usage_counter is deinitialized in blk_mq_free_queue() before deleting the queue from all_q_list. So if CPU hotplug event occurs in the

Re: [PATCH 1/2] x86/efi: Map EFI memmap entries in-order at runtime

2015-09-26 Thread Ard Biesheuvel
On 26 September 2015 at 10:20, H. Peter Anvin wrote: > I think it "works" because the affected BIOSes don't put spaces between the > chunks. I have discussed this with Matt. > Forgive the ASCII art but perhaps an illustration might help: before the 2.5 feature, PE/COFF runtime

Re: No more new fbdev drivers, please

2015-09-26 Thread Geert Uytterhoeven
Hi David, On Sat, Sep 26, 2015 at 8:13 PM, David Herrmann wrote: > On Sat, Sep 26, 2015 at 8:01 PM, Geert Uytterhoeven > wrote: >> On Sat, Sep 26, 2015 at 7:07 PM, Alex Deucher wrote: >>> On Sat, Sep 26, 2015 at 4:28 AM, Geert

[PATCH 4.2 125/134] IB/iser: Fix possible bogus DMA unmapping

2015-09-26 Thread Greg Kroah-Hartman
4.2-stable review patch. If anyone has any objections, please let me know. -- From: Sagi Grimberg commit 8d5944d80359e645feb2ebd069a6f4caf7825e40 upstream. If iser_initialize_task_headers() routine failed before dma mapping, we should not attempt to unmap

[PATCH 4.2 124/134] IB/iser: Fix missing return status check in iser_send_data_out

2015-09-26 Thread Greg Kroah-Hartman
4.2-stable review patch. If anyone has any objections, please let me know. -- From: Sagi Grimberg commit d16739055bd1f562ae4d83e69f7f7f1cefcfbe16 upstream. Since commit "IB/iser: Fix race between iser connection teardown..." iser_initialize_task_headers()

  1   2   3   4   5   6   7   8   9   10   >