Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Srishti Sharma
On Sat, Sep 30, 2017 at 11:36 AM, Julia Lawall wrote: > > > On Sat, 30 Sep 2017, Srishti Sharma wrote: > >> On Sat, Sep 30, 2017 at 10:35 AM, Julia Lawall wrote: >> > >> > >> > On Sat, 30 Sep 2017, Srishti Sharma wrote: >> > >> >> For variables of the

Re: [PATCH v2] netlink: do not proceed if dump's start() errs

2017-09-30 Thread David Miller
From: "Jason A. Donenfeld" Date: Thu, 28 Sep 2017 00:41:44 +0200 > Drivers that use the start method for netlink dumping rely on dumpit not > being called if start fails. For example, ila_xlat.c allocates memory > and assigns it to cb->args[0] in its start() function. It might

Re: [PATCH] RDMA/hns: return 0 rather than return a garbage status value

2017-09-30 Thread Wei Hu (Xavier)
Thanks, Colin Ian King Acked-by: Wei Hu (Xavier) On 2017/9/30 4:13, Colin King wrote: From: Colin Ian King For the case where hr_qp->state == IB_QPS_RESET, an uninitialized value in ret is being returned by function hns_roce_v2_query_qp.

Re: [PATCH v2] VFS: Handle lazytime in do_mount()

2017-09-30 Thread Markus Trippelsdorf
On 2017.09.19 at 17:25 +0200, Lukas Czerner wrote: > On Tue, Sep 19, 2017 at 12:37:24PM +0200, Markus Trippelsdorf wrote: > > Since commit e462ec50cb5fa ("VFS: Differentiate mount flags (MS_*) from > > internal superblock flags") the lazytime mount option didn't get passed > > on anymore. > > > >

[RFC PATCH 2/2] block/cfq: Fix memory leak of async cfqq

2017-09-30 Thread Jeffy Chen
Currently we only unref the async cfqqs in cfq_pd_offline, which would not be called when CONFIG_CFQ_GROUP_IOSCHED is disabled. Kmemleak reported: unreferenced object 0xffc0cd9fc000 (size 240): comm "kworker/3:1", pid 52, jiffies 4294673527 (age 97.149s) hex dump (first 32 bytes): 01

[RFC PATCH 1/2] block: Treat all read ops as synchronous

2017-09-30 Thread Jeffy Chen
We added some in/out ops(eg. REQ_OP_SCSI_IN/OUT), but currently the op_is_sync() is only checking REQ_OP_READ. So treat all read ops as synchronous. Fixes: aebf526b53ae ("block: fold cmd_type into the REQ_OP_ space") Signed-off-by: Jeffy Chen ---

Re: [PATCH] mm, hugetlb: fix "treat_as_movable" condition in htlb_alloc_mask

2017-09-30 Thread Alexandru Moise
On Fri, Sep 29, 2017 at 02:16:10PM -0700, Mike Kravetz wrote: > Adding Anshuman > > On 09/29/2017 01:43 PM, Alexandru Moise wrote: > > On Fri, Sep 29, 2017 at 05:13:39PM +0200, Alexandru Moise wrote: > >> > >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c > >> index 424b0ef08a60..ab28de0122af 100644 >

Re: [PATCH v6 2/2] tracing: Add support for preempt and irq enable/disable events

2017-09-30 Thread Steven Rostedt
On Mon, 25 Sep 2017 17:23:00 -0700 Joel Fernandes wrote: > The trace_hardirqs_off API can be called even when IRQs are already > off. This is unlike the trace_hardirqs_on which checks if IRQs are off > (atleast from some callsites), here are the definitions just for >

[PATCH V5 00/14] blk-mq-sched: improve sequential I/O performance(part 1)

2017-09-30 Thread Ming Lei
Hi Jens, In Red Hat internal storage test wrt. blk-mq scheduler, we found that I/O performance is much bad with mq-deadline, especially about sequential I/O on some multi-queue SCSI devcies(lpfc, qla2xxx, SRP...) Turns out one big issue causes the performance regression: requests are still

Re: [PATCH 0/2 v8] oom: capture unreclaimable slab info in oom message

2017-09-30 Thread Tetsuo Handa
Yang Shi wrote: > On 9/28/17 1:45 PM, Tetsuo Handa wrote: > > Yang Shi wrote: > >> On 9/28/17 12:57 PM, Tetsuo Handa wrote: > >>> Yang Shi wrote: > On 9/27/17 9:36 PM, Tetsuo Handa wrote: > > On 2017/09/28 6:46, Yang Shi wrote: > >> Changelog v7 -> v8: > >> * Adopted Michal’s

Re: random insta-reboots on AMD Phenom II

2017-09-30 Thread Adam Borowski
On Sat, Sep 30, 2017 at 01:11:37PM +0200, Borislav Petkov wrote: > On Sat, Sep 30, 2017 at 04:05:16AM +0200, Adam Borowski wrote: > > Any hints how to debug this? > > Do > rdmsr -a 0xc0010015 > as root and paste it here. 110 110 110 110 110 110 on both 4.13.4 and

Hello Friend

2017-09-30 Thread Wang_Jianlin
-- I intend to give you a portion of my wealth as a free-will financial donation to you, Respond to partake, please contact my private email for more details Wang Jianlin Wanda Group

Re: random insta-reboots on AMD Phenom II

2017-09-30 Thread Borislav Petkov
On Sat, Sep 30, 2017 at 01:29:03PM +0200, Adam Borowski wrote: > On Sat, Sep 30, 2017 at 01:11:37PM +0200, Borislav Petkov wrote: > > On Sat, Sep 30, 2017 at 04:05:16AM +0200, Adam Borowski wrote: > > > Any hints how to debug this? > > > > Do > > rdmsr -a 0xc0010015 > > as root and paste it here.

Re: random insta-reboots on AMD Phenom II

2017-09-30 Thread Markus Trippelsdorf
On 2017.09.30 at 13:53 +0200, Borislav Petkov wrote: > On Sat, Sep 30, 2017 at 01:29:03PM +0200, Adam Borowski wrote: > > On Sat, Sep 30, 2017 at 01:11:37PM +0200, Borislav Petkov wrote: > > > On Sat, Sep 30, 2017 at 04:05:16AM +0200, Adam Borowski wrote: > > > > Any hints how to debug this? > > >

[PATCH v2] nvme-pci: Use PCI bus address for data/queues in CMB

2017-09-30 Thread Abhishek Shah
Currently, NVMe PCI host driver is programming CMB dma address as I/O SQs addresses. This results in failures on systems where 1:1 outbound mapping is not used (example Broadcom iProc SOCs) because CMB BAR will be progammed with PCI bus address but NVMe PCI EP will try to access CMB using dma

[PATCH] net: stmmac: dwmac-rk: Add RK3128 GMAC support

2017-09-30 Thread David Wu
Add constants and callback functions for the dwmac on rk3128 soc. As can be seen, the base structure is the same, only registers and the bits in them moved slightly. Signed-off-by: David Wu --- .../devicetree/bindings/net/rockchip-dwmac.txt | 1 +

Re: [PATCH V7 0/6] block/scsi: safe SCSI quiescing

2017-09-30 Thread Martin Steigerwald
Hi Ming. Ming Lei - 30.09.17, 14:12: > Please consider this patchset for V4.15, and it fixes one > kind of long-term I/O hang issue in either block legacy path > or blk-mq. > > The current SCSI quiesce isn't safe and easy to trigger I/O deadlock. Isn´t that material for -stable as well? I´d

Re: [PATCH V7 0/6] block/scsi: safe SCSI quiescing

2017-09-30 Thread Ming Lei
Hi Martin, On Sat, Sep 30, 2017 at 11:47:10AM +0200, Martin Steigerwald wrote: > Hi Ming. > > Ming Lei - 30.09.17, 14:12: > > Please consider this patchset for V4.15, and it fixes one > > kind of long-term I/O hang issue in either block legacy path > > or blk-mq. > > > > The current SCSI quiesce

[PATCH V5 3/7] sbitmap: introduce __sbitmap_for_each_set()

2017-09-30 Thread Ming Lei
We need to iterate ctx starting from any ctx in round robin way, so introduce this helper. Cc: Omar Sandoval Tested-by: Oleksandr Natalenko Tested-by: Tom Nguyen Tested-by: Paolo Valente Signed-off-by:

[PATCH V5 4/7] blk-mq: introduce blk_mq_dequeue_from_ctx()

2017-09-30 Thread Ming Lei
This function is introduced for dequeuing request from sw queue so that we can dispatch it in scheduler's way. More importantly, some SCSI devices may set q->queue_depth, which is a per-request_queue limit, and applied on pending I/O from all hctxs. This function is introduced for avoiding to

[PATCH V5 1/7] blk-mq: issue rq directly in blk_mq_request_bypass_insert()

2017-09-30 Thread Ming Lei
With issuing rq directly in blk_mq_request_bypass_insert(), we can: 1) avoid to acquire hctx->lock. 2) the dispatch result can be returned to dm-rq, so that dm-rq can use this information for improving I/O performance, and part2 of this patchset will do that. 3) Also the following patch for

[PATCH V5 2/7] blk-mq-sched: fix scheduler bad performance

2017-09-30 Thread Ming Lei
When hw queue is busy, we shouldn't take requests from scheduler queue any more, otherwise it is difficult to do IO merge. This patch fixes the awful IO performance on some SCSI devices(lpfc, qla2xxx, ...) when mq-deadline/kyber is used by not taking requests if hw queue is busy. Tested-by:

[PATCH V5 6/7] blk-mq-sched: improve dispatching from sw queue

2017-09-30 Thread Ming Lei
SCSI devices use host-wide tagset, and the shared driver tag space is often quite big. Meantime there is also queue depth for each lun(.cmd_per_lun), which is often small. So lots of requests may stay in sw queue, and we always flush all belonging to same hw queue and dispatch them all to driver,

[PATCH V5 5/7] blk-mq-sched: move actual dispatching into one helper

2017-09-30 Thread Ming Lei
So that it becomes easy to support to dispatch from sw queue in the following patch. No functional change. Reviewed-by: Bart Van Assche Reviewed-by: Omar Sandoval Tested-by: Oleksandr Natalenko Tested-by: Tom Nguyen

[PATCH V5 7/7] blk-mq-sched: don't dequeue request until all in ->dispatch are flushed

2017-09-30 Thread Ming Lei
During dispatching, we moved all requests from hctx->dispatch to one temporary list, then dispatch them one by one from this list. Unfortunately during this period, run queue from other contexts may think the queue is idle, then start to dequeue from sw/scheduler queue and still try to dispatch

Re: [PATCH] clk: rockchip: Delete an error message for a failed memory allocation in rockchip_clk_register_cpuclk()

2017-09-30 Thread Heiko Stuebner
Am Mittwoch, 27. September 2017, 11:44:30 CEST schrieb SF Markus Elfring: > From: Markus Elfring > Date: Wed, 27 Sep 2017 11:38:17 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle

Re: [PATCH v2] Staging: rtl8723bs: Remove unnecessary comments.

2017-09-30 Thread Tobin C. Harding
Hi Shreeya, We don't usually add a period to the subject line for kernel patches. (reason: we only have about 52 characters for the commit brief description so best not to waste any). On Sat, Sep 30, 2017 at 01:30:34PM +0530, Shreeya Patel wrote: > This patch removes unnecessary comments which

Re: [PATCH v2] Staging: rtl8723bs: Remove unnecessary comments.

2017-09-30 Thread Shreeya Patel
On Sat, 2017-09-30 at 21:06 +1000, Tobin C. Harding wrote: > Hi Shreeya, > > We don't usually add a period to the subject line for kernel patches. > (reason: we only have about > 52 characters for the commit brief description so best not to waste > any). > > On Sat, Sep 30, 2017 at 01:30:34PM

Re: [PATCH 01/12] usb: mtu3: fix error return code in ssusb_gadget_init()

2017-09-30 Thread Sergei Shtylyov
Hello! On 9/28/2017 3:17 AM, Chunfeng Yun wrote: When fail to get irq number, platform_get_irq() may return Failing. IRQ. :-) -EPROBE_DEFER, but we ignore it and always return -ENODEV, so fix it. Signed-off-by: Chunfeng Yun --- drivers/usb/mtu3/mtu3_core.c

[PATCH 4/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Srishti Sharma
For variables of the type struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma

[PATCH 2/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Srishti Sharma
For variables of the type struct list_head use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma

[PATCH 3/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Srishti Sharma
For variables of the type struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma

Re: [lkp-robot] [blk] 47e0fb461f: BUG:unable_to_handle_kernel

2017-09-30 Thread NeilBrown
On Thu, Sep 21 2017, kernel test robot wrote: > FYI, we noticed the following commit: > > commit: 47e0fb461fca1a68a566c82fcc006cc787312d8c ("blk: make the bioset > rescue_workqueue optional.") > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master > > in testcase: trinity >

Re: [Outreachy kernel] [PATCH 6/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Julia Lawall
On Sat, 30 Sep 2017, Srishti Sharma wrote: > For variables of type struct list_head* use list_entry to access > current list element instead of using container_of. Done by the > following semantic patch by coccinelle. > > @r@ > struct list_head* l; > @@ > > -container_of > +list_entry >

Re: [PATCH V5 00/14] blk-mq-sched: improve sequential I/O performance(part 1)

2017-09-30 Thread Ming Lei
On Sat, Sep 30, 2017 at 06:27:13PM +0800, Ming Lei wrote: > Hi Jens, > > In Red Hat internal storage test wrt. blk-mq scheduler, we > found that I/O performance is much bad with mq-deadline, especially > about sequential I/O on some multi-queue SCSI devcies(lpfc, qla2xxx, > SRP...) > > Turns out

Re: [PATCH REBASED 3/6] s390: Add __down_read_killable()

2017-09-30 Thread Heiko Carstens
On Sat, Sep 30, 2017 at 12:36:12PM +0200, Martin Schwidefsky wrote: > On Sat, 30 Sep 2017 11:20:02 +0200 > Heiko Carstens wrote: > > > On Fri, Sep 29, 2017 at 07:06:18PM +0300, Kirill Tkhai wrote: > > > Similar to __down_write_killable(), and read killable primitive. >

Re: [PATCH] phy: rockchip-typec: Check for errors from tcphy_phy_init()

2017-09-30 Thread Guenter Roeck
On Fri, Sep 29, 2017 at 4:58 PM, Douglas Anderson wrote: > The function tcphy_phy_init() could return an error but the callers > weren't checking the return value. They should. In at least one case > while testing I saw the message "wait pma ready timeout" which >

Re: [PATCH REBASED 3/6] s390: Add __down_read_killable()

2017-09-30 Thread Martin Schwidefsky
On Sat, 30 Sep 2017 12:36:12 +0200 Martin Schwidefsky wrote: > On Sat, 30 Sep 2017 11:20:02 +0200 > Heiko Carstens wrote: > > > On Fri, Sep 29, 2017 at 07:06:18PM +0300, Kirill Tkhai wrote: > > > Similar to __down_write_killable(), and read

Re: [PATCH v2 RESEND 2/2] x86/mm/KASLR: Do not adapt the size of the direct mapping section for SGI UV system

2017-09-30 Thread Baoquan He
Hi Mike, On 09/28/17 at 07:10am, Mike Travis wrote: > > > On 9/28/2017 2:01 AM, Ingo Molnar wrote: > > > > > If on SGI UV system, the kaslr_regions[0].size_tb, namely the size of > > > the direct mapping section, is incorrect. > > > > > > Its direct mapping size includes two parts: > > > #1

[PATCH V5 0/8] blk-mq: improve bio merge for none scheduler

2017-09-30 Thread Ming Lei
Hi, Patch 1 ~ 2 uses q->queue_depth as hint for setting up scheduler queue depth. Patch 3 ~ 8 improve bio merge via hash table in sw queue, which makes bio merge more efficient than current approch in which only the last 8 requests in sw queue are checked. Also this way has been used in block

[PATCH] vme: Fix integer overflow checking in vme_check_window()

2017-09-30 Thread Dan Carpenter
The controversial part of this patch is that I've changed it so we now prevent integer overflows for VME_USER types and before we didn't. I view it as kernel-hardening. I looked at a couple places that used VME_USER types and they seemed pretty suspicious so I'm pretty sure preventing overflows

[PATCH V5 5/8] block: add check on elevator for supporting bio merge via hashtable from blk-mq sw queue

2017-09-30 Thread Ming Lei
blk_mq_sched_try_merge() will be reused in following patches to support bio merge to blk-mq sw queue, so add checkes to related functions which are called from blk_mq_sched_try_merge(). Tested-by: Oleksandr Natalenko Tested-by: Tom Nguyen Tested-by:

[PATCH V5 2/8] blk-mq-sched: use q->queue_depth as hint for q->nr_requests

2017-09-30 Thread Ming Lei
SCSI sets q->queue_depth from shost->cmd_per_lun, and q->queue_depth is per request_queue and more related to scheduler queue compared with hw queue depth, which can be shared by queues, such as TAG_SHARED. This patch tries to use q->queue_depth as hint for computing q->nr_requests, which should

[PATCH V5 1/8] blk-mq-sched: introduce blk_mq_sched_queue_depth()

2017-09-30 Thread Ming Lei
The following patch will use one hint to figure out default queue depth for scheduler queue, so introduce the helper of blk_mq_sched_queue_depth() for this purpose. Reviewed-by: Christoph Hellwig Reviewed-by: Bart Van Assche Tested-by: Oleksandr Natalenko

[PATCH V5 7/8] blk-mq-sched: refactor blk_mq_sched_try_merge()

2017-09-30 Thread Ming Lei
This patch introduces one function __blk_mq_try_merge() which will be resued for bio merge to sw queue in the following patch. No functional change. Tested-by: Oleksandr Natalenko Tested-by: Tom Nguyen Tested-by: Paolo Valente

[PATCH V5 6/8] block: introduce .last_merge and .hash to blk_mq_ctx

2017-09-30 Thread Ming Lei
Prepare for supporting bio merge to sw queue if no blk-mq io scheduler is taken. Tested-by: Oleksandr Natalenko Tested-by: Tom Nguyen Tested-by: Paolo Valente Signed-off-by: Ming Lei ---

[PATCH V5 8/8] blk-mq: improve bio merge from blk-mq sw queue

2017-09-30 Thread Ming Lei
This patch uses hash table to do bio merge from sw queue, then we can align to blk-mq scheduler/block legacy's way for bio merge. Turns out bio merge via hash table is more efficient than simple merge on the last 8 requests in sw queue. On SCSI SRP, it is observed ~10% IOPS is increased in

[PATCH V5 4/8] block: move actual bio merge code into __elv_merge

2017-09-30 Thread Ming Lei
So that we can reuse __elv_merge() to merge bio into requests from sw queue in the following patches. No functional change. Tested-by: Oleksandr Natalenko Tested-by: Tom Nguyen Tested-by: Paolo Valente Signed-off-by: Ming

[PATCH V5 3/8] block: introduce rqhash helpers

2017-09-30 Thread Ming Lei
We need this helpers for supporting to use hashtable to improve bio merge from sw queue in the following patches. No functional change. Tested-by: Oleksandr Natalenko Tested-by: Tom Nguyen Tested-by: Paolo Valente

[PATCH 2/5] dm-mpath: don't call blk_mq_delay_run_hw_queue() in case of BLK_STS_RESOURCE

2017-09-30 Thread Ming Lei
If .queue_rq() returns BLK_STS_RESOURCE, blk-mq will rerun the queue in the three situations: 1) if BLK_MQ_S_SCHED_RESTART is set - queue is rerun after one rq is completed, see blk_mq_sched_restart() which is run from blk_mq_free_request() 2) BLK_MQ_S_TAG_WAITING is set - queue is rerun after

Re: [RESEND RFC PATCH 0/7] sun8i H3 HDMI glue driver for DW HDMI

2017-09-30 Thread Alexey Kardashevskiy
On 21/09/17 06:01, Jernej Skrabec wrote: > [added media mailing list due to CEC question] > > This patch series adds a HDMI glue driver for Allwinner H3 SoC. For now, only > video and CEC functionality is supported. Audio needs more tweaks. > > Series is based on the H3 DE2 patch series

[PATCH] x86/CPU/AMD, mm: Extend with mem_encrypt=sme option

2017-09-30 Thread Borislav Petkov
On Fri, Sep 29, 2017 at 06:06:52PM -0500, Brijesh Singh wrote: > The mem_encrypt=on activates both SME and SEV. Add a new argument to disable > the SEV and allow SME. The argument can be useful when SEV has issues and > we want to disable it. > > early_detect_mem_encrypt() [cpu/amd.com] will need

[PATCH v2] f2fs: order free nid allocator

2017-09-30 Thread Chao Yu
Previously, there is no restrict order among free nid allocators, if there are no free nids being cached in memory, previous allocator will try to load them by scanning NAT pages, but after that, these newly loaded free nids could be grabbed by later allocators, result in long delay of previous

Re: [PATCH] mm: kill kmemcheck again

2017-09-30 Thread Steven Rostedt
On Wed, 27 Sep 2017 17:02:07 +0200 Michal Hocko wrote: > > Now that 2 years have passed, and all distros provide gcc that supports > > KASAN, kill kmemcheck again for the very same reasons. > > This is just too large to review manually. How have you generated the > patch?

Re: [PATCH REBASED 3/6] s390: Add __down_read_killable()

2017-09-30 Thread Martin Schwidefsky
On Sat, 30 Sep 2017 11:20:02 +0200 Heiko Carstens wrote: > On Fri, Sep 29, 2017 at 07:06:18PM +0300, Kirill Tkhai wrote: > > Similar to __down_write_killable(), and read killable primitive. > > > > Signed-off-by: Kirill Tkhai > > --- > >

Re: [PATCH 0/6] Replace container_of with list_entry

2017-09-30 Thread Tobin C. Harding
On Sat, Sep 30, 2017 at 12:49:00PM +0530, Srishti Sharma wrote: > Replaces instances of container_of with list_entry to > access current list element. > > Srishti Sharma (6): > Staging: rtl8188eu: core: Use list_entry instead of container_of > Staging: rtl8188eu: core: Use list_entry instead

Re: random insta-reboots on AMD Phenom II

2017-09-30 Thread Borislav Petkov
On Sat, Sep 30, 2017 at 04:05:16AM +0200, Adam Borowski wrote: > Any hints how to debug this? Do rdmsr -a 0xc0010015 as root and paste it here. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.

[PATCH 4/5] dm-mpath: cache ti->clone during requeue

2017-09-30 Thread Ming Lei
During requeue, block layer won't change the request any more, such as no merge, so we can cache ti->clone and let .clone_and_map_rq check if the cache can be hit. Signed-off-by: Ming Lei --- drivers/md/dm-mpath.c | 31 --- drivers/md/dm-rq.c

[PATCH 3/5] dm-mpath: return DM_MAPIO_REQUEUE in case of rq allocation failure

2017-09-30 Thread Ming Lei
blk-mq will rerun queue via RESTART after one request is completed, so not necessary to wait random time for requeuing, we should trust blk-mq to do it. More importantly, we need return BLK_STS_RESOURCE to blk-mq so that dequeue from I/O scheduler can be stopped, then I/O merge gets improved.

[PATCH 0/5] dm-rq: improve sequential I/O performance

2017-09-30 Thread Ming Lei
Hi, This 1st one patch removes one log message which can be triggered very easily. The 2nd patch removes the workaround of blk_mq_delay_run_hw_queue() in case of requeue, this way isn't necessary, and more worse, it makes BLK_MQ_S_SCHED_RESTART not working, and degarde I/O performance. The 3rd

[PATCH 1/5] dm-mpath: remove annoying message of 'blk_get_request() returned -11'

2017-09-30 Thread Ming Lei
It is very normal to see allocation failure, so not necessary to dump it and annoy people. Signed-off-by: Ming Lei --- drivers/md/dm-mpath.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c index 11f273d2f018..e8094d8fbe0d

[PATCH 5/5] dm-rq: improve I/O merge by dealing with underlying STS_RESOURCE

2017-09-30 Thread Ming Lei
If the underlying queue returns BLK_STS_RESOURCE, we let dm-rq handle the requeue instead of blk-mq, then I/O merge can be improved because underlying's out-of-resource can be perceived and handled by dm-rq now. Follows IOPS test of mpath on lpfc, fio(libaio, bs:4k, dio, queue_depth:64, 8 jobs).

[PATCH 1/2] pinctrl: rockchip: Fix the rk3399 gpio0 and gpio1 banks' drv_offset at pmu grf

2017-09-30 Thread David Wu
The offset of gpio0 and gpio1 bank drive strength is 0x8, not 0x4. But the mux is 0x4, we couldn't use the IOMUX_WIDTH_4BIT flag, so we give them actual offset. Signed-off-by: David Wu --- drivers/pinctrl/pinctrl-rockchip.c | 12 ++-- 1 file changed, 6

[PATCH 2/2] pinctrl: rockchip: Fix the correct routing config for the gmac-m1 pins of rmii and rgmii

2017-09-30 Thread David Wu
If the gmac-m1 optimization(bit10) is selected, the gpio function of gmac pins is not valid. We may use the rmii mode for gmac interface, the pins such as rx_d2, rx_d3, which the rgmii mode used, but rmii not used could be taken as gpio function. So gmac_rxd0m1 selects the bit2, and gmac_rxd0m3

[PATCH 0/2] Fix two pinctrl issues

2017-09-30 Thread David Wu
They are: 1. Fix the rk3399 gpio0 and gpio1 banks' drive strength offset. 2. Fix the correct routing config for the gmac-m1 pins between rmii and rgmii. David Wu (2): pinctrl: rockchip: Fix the rk3399 gpio0 and gpio1 banks' drv_offset at pmu grf pinctrl: rockchip: Fix the correct routing

ce07a9415f ("locking/lockdep: Make check_prev_add() able to .."): BUG: unable to handle kernel NULL pointer dereference at 00000020

2017-09-30 Thread kernel test robot
Greetings, 0day kernel testing robot got the below dmesg and the first bad commit is https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master commit ce07a9415f266e181a0a33033a5f7138760240a4 Author: Byungchul Park AuthorDate: Mon Aug 7 16:12:51 2017

[PATCH v3] Staging: rtl8723bs: Remove unnecessary comments.

2017-09-30 Thread Shreeya Patel
Remove unnecessary comments which are there to explain why call to memset is in comments. Both of the comments are not needed as they are not very useful. Signed-off-by: Shreeya Patel --- Changes in v2: -Remove some more unnecessary comments and make the

Re: [PATCH 2/2] pinctrl: rockchip: Fix the correct routing config for the gmac-m1 pins of rmii and rgmii

2017-09-30 Thread Heiko Stuebner
Hi David, Am Samstag, 30. September 2017, 20:13:21 CEST schrieb David Wu: > If the gmac-m1 optimization(bit10) is selected, the gpio function > of gmac pins is not valid. We may use the rmii mode for gmac interface, > the pins such as rx_d2, rx_d3, which the rgmii mode used, but rmii not > used

Re: [PATCH v2] netlink: do not proceed if dump's start() errs

2017-09-30 Thread David Miller
From: Johannes Berg Date: Sat, 30 Sep 2017 08:56:10 +0200 > On Thu, 2017-09-28 at 00:41 +0200, Jason A. Donenfeld wrote: >> Drivers that use the start method for netlink dumping rely on dumpit >> not >> being called if start fails. For example, ila_xlat.c allocates

Re: [PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

2017-09-30 Thread Leon Romanovsky
On Sat, Sep 30, 2017 at 05:28:59PM +0800, Wei Hu (Xavier) wrote: > If the IOMMU is enabled, the length of sg obtained from > __iommu_map_sg_attrs is not 4kB. When the IOVA is set with the sg > dma address, the IOVA will not be page continuous. and the VA > returned from dma_alloc_coherent is a

Re: [Part2 PATCH v4 05/29] crypto: ccp: Add Platform Security Processor (PSP) device support

2017-09-30 Thread Borislav Petkov
On Sat, Sep 30, 2017 at 10:55:25AM -0500, Brijesh Singh wrote: > CRYPTO_DEV_CCP_DD is supported on aarch64 and x86. Whereas the PSP > interface I am adding is available on x86 only hence its safe to add add > depend on CPU_SUP_AMD for CRYPTO_DEV_SP_PSP. I think just from having CRYPTO_DEV_CCP_DD

Re: Reply Urgent

2017-09-30 Thread Info
Hello, How are you doing? We have an inheritance of a deceased client with your surname. Contact Mr Andrew Bailey by this email address: ands...@europe.com with your full names for further information's. Thanks for your understanding. Melissa. -- Correo

[PATCH] thunderbolt: make tb_domain_type const

2017-09-30 Thread Bhumika Goyal
Make this const as it is only stored in the const field of a device structure. Make the declaration in header const too. Structure found using Coccinelle and changes done by hand. Signed-off-by: Bhumika Goyal --- drivers/thunderbolt/domain.c | 2 +- drivers/thunderbolt/tb.h

Re: Linux 4.13.4

2017-09-30 Thread Ed Tomlinson
Hi, It works with 14-rc2, so I rebuilt 13.4 with the commit included again and its behaving too :-/ Something strange must have happened in the original 13.4 build or my hw was in a strange state (for two boots...) Sorry for the noise. Thanks Ed Tomlinson On Saturday, September 30, 2017

Re: [PATCH v2] ARM: multi_v7_defconfig: Enable USB3503 driver

2017-09-30 Thread Krzysztof Kozlowski
On Thu, Sep 28, 2017 at 10:27:03PM +0200, Linus Lüssing wrote: > The Odroid U3 (Exynos 4412 based) for instance needs this driver, > otherwise its USB hub will not come up. > > Also selecting it as built-in to allow booting from USB without > an initrd/initramfs. exynos_defconfig does the same

[PATCH] libata: make ata_port_type const

2017-09-30 Thread Bhumika Goyal
Make this const as it is only stored in the const field of a device structure. Make the declaration in header const too. Structure found using Coccinelle and changes done by hand. Signed-off-by: Bhumika Goyal --- drivers/ata/libata-core.c | 2 +- drivers/ata/libata.h |

Re: [PATCHv2 2/7] usb: dwc2: add support for STM32F7 USB OTG HS

2017-09-30 Thread John Youn
On 09/29/2017 07:22 AM, Amelie DELAUNAY wrote: > Hi, > > Gentle ping for driver review submitted on August 28th. > > Thanks, > Amelie > > On 08/28/2017 04:20 PM, Amelie Delaunay wrote: >> This patch adds the dwc2_set_params function for STM32F7 USB OTG HS. >> >> Signed-off-by: Amelie Delaunay

[PATCH] FS-Cache: make fscache_fsdef_netfs_def const

2017-09-30 Thread Bhumika Goyal
Make fscache_fsdef_netfs_def const as it is only stored in a const field of a fscache_cookie structure. Make the declaration const too. Structure found using Coccinelle and changes done by hand. Signed-off-by: Bhumika Goyal --- fs/fscache/fsdef.c| 2 +-

[PATCH] scsi: esas2r: make bin_attr_default_nvram const

2017-09-30 Thread Bhumika Goyal
Make this const as it is only passed to the const arguments of the functions sysfs_remove_bin_file and sysfs_create_bin_file. Make the declaration const too. Structure found using Coccinelle and changes done by hand. Signed-off-by: Bhumika Goyal ---

Re: f34c8585ed ("rcutorture: Invoke call_rcu() from timer handler"): WARNING: kernel stack regs at bdf19a20 in trinity-c0:12909 has bad 'bp' value bdf17850

2017-09-30 Thread Paul E. McKenney
On Sat, Sep 30, 2017 at 10:15:30AM +0800, kernel test robot wrote: > Greetings, > > 0day kernel testing robot got the below dmesg and the first bad commit is > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > > commit f34c8585ed70f0f9b5ff9cf59c0dd533cddb975f >

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

2017-09-30 Thread Sinan Kaya
On 9/30/2017 1:49 AM, Govindarajulu Varadarajan wrote: > This patch does a pci_bus_walk and adds all the devices to a list. After > unlocking (up_read) _bus_sem, we go through the list and call > err_handler of the devices with devic_lock() held. This way, we dont try > to hold both locks at same

Nouveau nullptr on NVIDIA NVA8

2017-09-30 Thread Woody Suwalski
Starting with the drm merge af3c8d98508d37541d4bf57f13a984a7f73a328c for 4.13-rc1, the NVidia NVS3100M display on Dell Latitude E6410 had a nullptr crash on startup. As a result later the suspend2ram was locking up. Traced to a null ptr in nv50_mstm_service(), which seems to be called only

Re: random insta-reboots on AMD Phenom II

2017-09-30 Thread Brian Gerst
On Sat, Sep 30, 2017 at 8:47 AM, Markus Trippelsdorf wrote: > On 2017.09.30 at 13:53 +0200, Borislav Petkov wrote: >> On Sat, Sep 30, 2017 at 01:29:03PM +0200, Adam Borowski wrote: >> > On Sat, Sep 30, 2017 at 01:11:37PM +0200, Borislav Petkov wrote: >> > > On Sat, Sep 30,

Re: Linux 4.13.4

2017-09-30 Thread Greg KH
On Sat, Sep 30, 2017 at 09:49:28AM -0400, Ed Tomlinson wrote: > Hi, > > This build causes very annoying flickering on my display. I am using the in > kernel amdgpu module to drive a RX480 with 4G via display port. When X is > started (kde) I get flickers that are extrememly distracting. The

Re: Linux 4.13.4

2017-09-30 Thread Ed Tomlinson
Hi I did things old school via patch -R. This is what I reverted: --- diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c index 4083be61b328..6417febe18b9 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +++

Re: random insta-reboots on AMD Phenom II

2017-09-30 Thread Markus Trippelsdorf
On 2017.09.30 at 10:20 -0400, Brian Gerst wrote: > On Sat, Sep 30, 2017 at 8:47 AM, Markus Trippelsdorf > wrote: > > On 2017.09.30 at 13:53 +0200, Borislav Petkov wrote: > >> On Sat, Sep 30, 2017 at 01:29:03PM +0200, Adam Borowski wrote: > >> > On Sat, Sep 30, 2017 at

Re: Linux 4.13.4

2017-09-30 Thread Greg KH
On Sat, Sep 30, 2017 at 11:14:42AM -0400, Ed Tomlinson wrote: > Hi > > I did things old school via patch -R. This is what I reverted: > > --- > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > index 4083be61b328..6417febe18b9 100644 > ---

Re: [PATCH v2 2/2] pid: Remove pidhash

2017-09-30 Thread Gargi Sharma
On Wed, Sep 27, 2017 at 9:58 PM, Oleg Nesterov wrote: > If I was not clear... > > in short, after this patch the very first idr_alloc_cyclic() is already > wrong. Because, once again, the new not-fully-initialized pid can be found > by find_pid_ns(). If the PIDNS_ADDING check

Re: [PATCH] crypto: ccp: Build the AMD secure processor driver only with AMD CPU support

2017-09-30 Thread Borislav Petkov
On Sat, Sep 30, 2017 at 09:06:26AM -0500, Brijesh Singh wrote: > > diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig > > index 627f3e61dcac..f58a6521270b 100644 > > --- a/drivers/crypto/ccp/Kconfig > > +++ b/drivers/crypto/ccp/Kconfig > > @@ -1,5 +1,6 @@ > > config

Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

2017-09-30 Thread John Youn
On 09/20/2017 12:57 PM, John Stultz wrote: > So here are a few dwc2 fixes that I've been using with HiKey. > I'm not totally sure these are all ideal, but they avoid edge case > issues that we have been running into with switching between > gadget mode and host mode. > > I'd guess the first two

Re: [PATCH] kvm/x86: Handle async PF in RCU read-side critical sections

2017-09-30 Thread Paul E. McKenney
On Sat, Sep 30, 2017 at 07:41:56AM +0800, Boqun Feng wrote: > On Fri, Sep 29, 2017 at 04:43:39PM +, Paul E. McKenney wrote: > > On Fri, Sep 29, 2017 at 04:53:57PM +0200, Paolo Bonzini wrote: > > > On 29/09/2017 13:01, Boqun Feng wrote: > > > > Sasha Levin reported a WARNING: > > > > > > > > |

Re: Linux 4.13.4

2017-09-30 Thread Ed Tomlinson
Hi, This build causes very annoying flickering on my display. I am using the in kernel amdgpu module to drive a RX480 with 4G via display port. When X is started (kde) I get flickers that are extrememly distracting. The linux install is arch stable and is up to date. Nothing interesting in

Re: [PATCH] crypto: ccp: Build the AMD secure processor driver only with AMD CPU support

2017-09-30 Thread Brijesh Singh
On 9/30/17 3:30 AM, Borislav Petkov wrote: ... > From: Borislav Petkov > > This is AMD-specific hardware so present it in Kconfig only when AMD > CPU support is enabled. > > Signed-off-by: Borislav Petkov > Cc: Brijesh Singh > Cc: Tom

Re: random insta-reboots on AMD Phenom II

2017-09-30 Thread Borislav Petkov
On Sat, Sep 30, 2017 at 08:11:51AM -0700, Andy Lutomirski wrote: > Yeah, working on it. It's not a straightforward revert. Thanks. At least you have testers :-) -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.

Re: Linux 4.13.4

2017-09-30 Thread Ed Tomlinson
Hi It looks to be this commit. 4.14-rc2 is building Thanks Ed commit 2890decfd9969cac21067ca0c734fbccaf74d634 Author: Zhang, Jerry Date: Fri Jul 14 18:20:17 2017 +0800 drm/amdgpu: read reg in each iterator of psp_wait_for loop v2: fix the SOS loading failure

[PATCH] usb: gadget: configfs: Fix memory leak of interface directory data

2017-09-30 Thread Andrew Gabbasov
Kmemleak checking configuration reports a memory leak in usb_os_desc_prepare_interf_dir function when rndis function instance is freed and then allocated again. For example, this happens with FunctionFS driver with RNDIS function enabled when "ffs-test" test application is run several times in a

Re: [Part2 PATCH v4 05/29] crypto: ccp: Add Platform Security Processor (PSP) device support

2017-09-30 Thread Brijesh Singh
On 9/29/17 10:16 AM, Borislav Petkov wrote: ... > + >> +config CRYPTO_DEV_SP_PSP >> +bool "Platform Security Processor (PSP) device" >> +default y >> +depends on CRYPTO_DEV_CCP_DD > So this last symbol CRYPTO_DEV_CCP_DD is default m and it doesn't depend > on anything. And I'm

Re: random insta-reboots on AMD Phenom II

2017-09-30 Thread Andy Lutomirski
On Sat, Sep 30, 2017 at 8:50 AM, Borislav Petkov wrote: > On Sat, Sep 30, 2017 at 02:47:11PM +0200, Markus Trippelsdorf wrote: >> Changing the TLB code so late might not be a good idea... > > The new lazy code is too risky to keep as we don't know what else will > break. The

[PATCH] vfio-mdev: make mdev_fops const and static

2017-09-30 Thread Bhumika Goyal
Make this const as it is only passed to a const argument of the function mdev_register_device. Make it static as it is not referenced in any other file. Structure found using Coccinelle and changes done by hand. Signed-off-by: Bhumika Goyal --- samples/vfio-mdev/mtty.c | 2

[no subject]

2017-09-30 Thread E G
I am Ms.Ella Golan, I am the Executive Vice President Banking Division with FIRST INTERNATIONAL BANK OF ISRAEL LTD (FIBI). I am getting in touch with you regarding an extremely important and urgent matter. If you would oblige me the opportunity, I shall provide you with details upon your

  1   2   3   4   5   >