Re: [PATCH 1/3] iio: adc: ina2xx: Mask flag bits in bus voltage register

2017-10-08 Thread Jonathan Cameron
On Sun, 1 Oct 2017 21:48:16 +0200 Stefan Brüns wrote: > Lower bits of the INA219/220 bus voltage register are conversion > status flags, properly mask the value. > > Signed-off-by: Stefan Brüns Hi, good to find this issue, but the

Re: [PATCH] um: Fix kcov crash before kernel is started.

2017-10-08 Thread Thomas Meyer
On Sun, Oct 08, 2017 at 12:44:12PM +0200, Richard Weinberger wrote: > Am Sonntag, 8. Oktober 2017, 12:31:58 CEST schrieb Thomas Meyer: > > UMLs current_thread_info() unconditionally assumes that the top of the stack > > contains the thread_info structure. But on UML the __sanitizer_cov_trace_pc >

[PATCH v2 2/3] rtl8188eu: Fix a possible sleep-in-atomic bug in rtw_createbss_cmd

2017-10-08 Thread Jia-Ju Bai
The driver may sleep under a spinlock, and the function call path is: rtw_surveydone_event_callback(acquire the spinlock) rtw_createbss_cmd kzalloc(GFP_KERNEL) --> may sleep To fix it, GFP_KERNEL is replaced with GFP_ATOMIC. This bug is found by my static analysis tool and my code review.

[PATCH v2 1/3] rtl8188eu: Fix a possible sleep-in-atomic bug in rtw_disassoc_cmd

2017-10-08 Thread Jia-Ju Bai
The driver may sleep under a spinlock, and the function call path is: rtw_set_802_11_bssid(acquire the spinlock) rtw_disassoc_cmd kzalloc(GFP_KERNEL) --> may sleep To fix it, GFP_KERNEL is replaced with GFP_ATOMIC. This bug is found by my static analysis tool and my code review.

[PATCH v2 3/3] rtl8188eu: Fix a possible sleep-in-atomic bug in _rtw_pwr_wakeup

2017-10-08 Thread Jia-Ju Bai
The driver may sleep under a spinlock, and the function call path is: rtw_set_802_11_disassociate(acquire the spinlock) _rtw_pwr_wakeup usleep_range --> may sleep To fix it, usleep_range is replaced with udelay. This bug is found by my static analysis tool and my code review.

Re: [RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk

2017-10-08 Thread Anand Moon
Hi Krzysztof, On 6 October 2017 at 12:08, Krzysztof Kozlowski wrote: > On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon wrote: >> update the usbdrd link control and phy contol clks. > > The commit title and especially commit message should explain why you > are

Re: [PATCH v2 06/10] staging: rtl8723bs: Add space after ','

2017-10-08 Thread Harsha Sharma
On Wed, Sep 13, 2017 at 2:11 AM, Greg KH wrote: > On Tue, Sep 12, 2017 at 07:05:23PM +0530, Harsha Sharma wrote: >> Space required after ',' >> >> Signed-off-by: Harsha Sharma >> --- >> Changes in v2: >> -Rebase against staging-testing and

[PATCH] arcmsr: Fix possible sleep-in-atomic bugs in arcmsr_queue_command

2017-10-08 Thread Jia-Ju Bai
The driver may sleep under a spinlock, and the function call paths are: arcmsr_queue_command(acquire the spinlock) arcmsr_queue_command_lck arcmsr_handle_virtual_command arcmsr_iop_message_xfer arcmsr_iop_parking arcmsr_stop_adapter_bgrb

[PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed

2017-10-08 Thread Jia-Ju Bai
No rcu_read_lock is called, but rcu_read_unlock is still called. Thus rcu_read_unlock should be removed. Signed-off-by: Jia-Ju Bai --- drivers/net/wireless/ath/wcn36xx/main.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ath/wcn36xx/main.c

Re: [PATCH net-next RFC 5/9] net: dsa: forward hardware timestamping ioctls to switch driver

2017-10-08 Thread Richard Cochran
On Thu, Sep 28, 2017 at 10:25:34AM -0700, Florian Fainelli wrote: > This echoes back to Andrew's comments in patch 2, but we may have to > prefer PHY timestamping over MAC timestamping if both are available? > Richard, is that usually how the preference should be made? No, if the MAC supports

Re: [Part2 PATCH v5.1 12.1/31] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

2017-10-08 Thread Borislav Petkov
On Sun, Oct 08, 2017 at 08:30:47AM -0500, Brijesh Singh wrote: > During the device probe, sev_ops_init() will be called for every device > instance which claims to support the SEV.  One of the device will be > 'master' but we don't the master until we probe all the instances. Hence > the probe for

Re: [RFC PATCH] crypto: make the seed() function optional

2017-10-08 Thread PrasannaKumar Muralidharan
Hi Herbert, On 7 October 2017 at 09:03, Herbert Xu wrote: > Mathieu Malaterre wrote: >> This makes it simplier for driver author to not provide the seed() function >> in case of a pseudo RNG where the seed operation is a no-op. >> >> Document that

Re: [PATCH v3 0/6] iio: Introduce the generic counter interface

2017-10-08 Thread Jonathan Cameron
On Thu, 5 Oct 2017 14:13:14 -0400 William Breathitt Gray wrote: > There have been some significant implementation changes for this version > of the patchset. Here's a brief summary of the updates: > > - Inline comments throughout the industrial-counter.c file; this >

Re: [PATCH v3 4/6] docs: Add IIO Generic Counter Interface documentation

2017-10-08 Thread Jonathan Cameron
On Thu, 5 Oct 2017 14:14:24 -0400 William Breathitt Gray wrote: > This patch adds high-level documentation about the IIO Generic Counter > Interface. > > Signed-off-by: William Breathitt Gray Put it into the relevant index.rst to get and make

Re: [PATCH v3 3/6] iio: Documentation: Add IIO Generic Counter sysfs documentation

2017-10-08 Thread Jonathan Cameron
On Thu, 5 Oct 2017 14:13:59 -0400 William Breathitt Gray wrote: > This patch adds standard documentation for the userspace sysfs > atrributes of the IIO Generic Counter Interface. > > Signed-off-by: William Breathitt Gray It's a good start -

Re: [PATCH v3 1/6] iio: Implement counter channel specification and IIO_SIGNAL constant

2017-10-08 Thread Jonathan Cameron
On Thu, 5 Oct 2017 14:13:30 -0400 William Breathitt Gray wrote: > Counters are IIO devices that are exposed via a generic counter > interface consisting of one or more counter signals (IIO_SIGNAL) linked > to one or more counter values (IIO_COUNT). > > This patch

Linux 4.9.54

2017-10-08 Thread Greg KH
I'm announcing the release of the 4.9.54 kernel. All users of the 4.9 kernel series must upgrade. The updated 4.9.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.9.y and can be browsed at the normal kernel.org git web browser:

Re: Linux 4.9.54

2017-10-08 Thread Greg KH
diff --git a/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt b/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt new file mode 100644 index ..6ec1a880ac18 --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt @@ -0,0 +1,46 @@

Re: Linux 4.4.91

2017-10-08 Thread Greg KH
diff --git a/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt b/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt new file mode 100644 index ..6ec1a880ac18 --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt @@ -0,0 +1,46 @@

Re: [PATCH v5 0/9] mtd: sharpslpart partition parser

2017-10-08 Thread Robert Jarzmik
Robert Jarzmik writes: > Boris Brezillon writes: > >> Hi Robert, >> Wait a bit before applying. I think patches 6 to 9 have a dependency on >> patch 1 (it's not a build dependency, but NAND partitioning might be >> wrong if you apply

Re: [PATCH 2/3] iio: adc: ina2xx: Adhere to documented ABI, use Ohm instead of uOhm

2017-10-08 Thread Jonathan Cameron
On Sun, 1 Oct 2017 21:48:17 +0200 Stefan Brüns wrote: > According to the ABI documentation, the shunt resistor value should be > specificied in Ohm. As this is also used/documented for the MAX9611, > use the same for the INA2xx driver. > > This poses an ABI break

Re: [PATCH v5 0/9] mtd: sharpslpart partition parser

2017-10-08 Thread Boris Brezillon
On Sun, 8 Oct 2017 12:09:50 +0200 Boris Brezillon wrote: > On Sun, 08 Oct 2017 11:53:11 +0200 > Robert Jarzmik wrote: > > > Robert Jarzmik writes: > > > > > Boris Brezillon

Re: [PATCH 2/2] lib: Improve a size determination in seven functions

2017-10-08 Thread Geert Uytterhoeven
On Sat, Oct 7, 2017 at 7:50 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 7 Oct 2017 19:19:45 +0200 > > Replace the specification of data structures by pointer dereferences > as the parameter for the operator

[BUG] gma500: Possible sleep-in-atomic bugs in gma_resume_pci

2017-10-08 Thread Jia-Ju Bai
The driver may sleep under a spinlock, and the function call paths are: gma_power_begin (acquire the spinlock) gma_resume_pci pci_set_power_state __pci_start_power_transition (drivers/pci/pci.c) msleep --> may sleep gma_power_begin (acquire the spinlock) gma_resume_pci

Re: [PATCH] IB/ipoib: Convert timers to use timer_setup()

2017-10-08 Thread Leon Romanovsky
On Wed, Oct 04, 2017 at 05:45:54PM -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Doug Ledford

Re: [Part2 PATCH v5.1 12.1/31] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

2017-10-08 Thread Brijesh Singh
On 10/7/17 1:40 PM, Borislav Petkov wrote: ... > A bunch of fixes ontop: > > * sev_fops_registered is superfluous if you can use psp->has_sev_fops I am okay with all your fixes except this one. I will add my comment below. ... > static int sev_ops_init(struct psp_device *psp) > { >

Re: [PATCH v3 6/6] iio: 104-quad-8: Add IIO generic counter interface support

2017-10-08 Thread Jonathan Cameron
On Thu, 5 Oct 2017 14:14:53 -0400 William Breathitt Gray wrote: > This patch adds support for the IIO generic counter interface to the > 104-QUAD-8 driver. The existing 104-QUAD-8 device interface should not > be affected by this patch; all changes are intended as

Re: [Intel-gfx] [PATCH v3] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

2017-10-08 Thread Chris Wilson
Quoting Harsha Sharma (2017-10-08 15:04:07) > @@ -624,7 +624,7 @@ static bool intel_fbdev_init_bios(struct drm_device *dev, > ifbdev->preferred_bpp = fb->base.format->cpp[0] * 8; > ifbdev->fb = fb; > > - drm_framebuffer_reference(>fb->base); > +

Re: [PATCH net-next RFC 2/9] net: dsa: mv88e6xxx: expose switch time as a PTP hardware clock

2017-10-08 Thread Richard Cochran
On Fri, Sep 29, 2017 at 03:17:02PM +, Brandon Streiff wrote: > > Although now that I'm looking it over again, I'm also not certain of > the need. Even if we're called more frequently than we expect, that > doesn't seem to be harmful with regard to timekeeping. Hmm. Just keep it simple and

[PATCH] dt-bindings: samsung: Document binding for new Odroid HC1 board

2017-10-08 Thread Krzysztof Kozlowski
Document the binding for new Hardkernel Odroid HC1 board. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt

Re: [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk

2017-10-08 Thread Anand Moon
Hi Krzysztof, On 6 October 2017 at 12:12, Krzysztof Kozlowski wrote: > On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon wrote: >> remove the disable and enable of phy clk. >> phy clk is needed to tune the phy controller. > > Drivers should in general enable and

[PATCH v3 06/10] staging: rtl8723bs: Add space after ','

2017-10-08 Thread Harsha Sharma
Space is required after ',' according to linux-kernel coding style. Signed-off-by: Harsha Sharma --- Other patches from this patchset have already been merged and only this one is remaining. Changes in v3: -Change log message and rebase against staging-testing

[PATCH] arm64: kdump: Avoid to power off nonpanic CPUs

2017-10-08 Thread Leo Yan
commit a88ce63b642c ("arm64: kexec: have own crash_smp_send_stop() for crash dump for nonpanic cores") introduces ARM64 architecture function crash_smp_send_stop() to replace the weak function, this results in the nonpanic CPUs to be hot-plugged out and CPUs are placed into low power state on

Re: [PATCH net-next RFC 1/9] net: dsa: mv88e6xxx: add accessors for PTP/TAI registers

2017-10-08 Thread Richard Cochran
On Thu, Sep 28, 2017 at 10:25:33AM -0500, Brandon Streiff wrote: > This patch implements support for accessing PTP/TAI registers through To avoid confusion, it would be helpful to mention what TAI stands for here and also in the source code comments! Thanks, Richard

Re: [PATCH] um: Fix kcov crash before kernel is started.

2017-10-08 Thread Richard Weinberger
Am Sonntag, 8. Oktober 2017, 12:31:58 CEST schrieb Thomas Meyer: > UMLs current_thread_info() unconditionally assumes that the top of the stack > contains the thread_info structure. But on UML the __sanitizer_cov_trace_pc > function is called for *all* functions! This results in an early crash: >

Re: [PATCH] iio: adc: dln2-adc: fix build error

2017-10-08 Thread Jonathan Cameron
On Sat, 7 Oct 2017 16:53:20 -0700 Randy Dunlap wrote: > From: Randy Dunlap > > The dln2-adc driver uses interface(s) that are controlled by the > IIO_TRIGGERED_BUFFER Kconfig symbol, so the driver needs to select > that symbol to prevent the build

Re: [PATCH net-next RFC 2/9] net: dsa: mv88e6xxx: expose switch time as a PTP hardware clock

2017-10-08 Thread Richard Cochran
On Fri, Sep 29, 2017 at 03:28:02PM +, Brandon Streiff wrote: > > NETWORK_PHY_TIMESTAMPING implies NET_PTP_CLASSIFY (which I do use) > and net/core/timestamping.c (which I didn't). It probably makes more > sense to just depend on NET_PTP_CLASSIFY directly. Yes, that makes sense to do, if you

[BUG] rtl8188eu: Some possible sleep-in-atomic bugs in ips_leave

2017-10-08 Thread Jia-Ju Bai
CC to mailing list. On 2017/10/8 20:13, Jia-Ju Bai wrote: The driver may sleep under a spinlock when calling the function "ips_leave", which causes some possible sleep-in-atomic bugs. Here are several examples: rtw_set_802_11_disassociate (acquire the spinlock) _rtw_pwr_wakeup ips_leave

Linux 4.14: Reported regressions as of Sunday, 2017-10-08

2017-10-08 Thread Thorsten Leemhuis
Hi! Find below my second regression report for Linux 4.14. It lists 8 regressions I'm currently aware of. One regression was fixed since last weeks report. One was in there that shouldn't have been there. As always: Are you aware of any other regressions? Then please let me know by mail (a simple

Re: [PATCH v2] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

2017-10-08 Thread Harsha Sharma
On Fri, Sep 29, 2017 at 10:00 AM, Harsha Sharma wrote: > Replace instances of drm_framebuffer_reference/unreference() with > *_get/put() suffixes and drm_dev_unref with *_put() suffix > because get/put is shorter and consistent with the > kernel use of *_get/put

Re: [RFC PATCH] mm: shm: round up tmpfs size to huge page size when huge=always

2017-10-08 Thread Kirill A. Shutemov
On Sat, Oct 07, 2017 at 04:22:10AM +0800, Yang Shi wrote: > When passing "huge=always" option for mounting tmpfs, THP is supposed to > be allocated all the time when it can fit, but when the available space is > smaller than the size of THP (2MB on x86), shmem fault handler still tries > to

Re: [PATCHv2 1/2] mm: Introduce wrappers to access mm->nr_ptes

2017-10-08 Thread Kirill A. Shutemov
On Fri, Oct 06, 2017 at 04:10:31PM -0700, Dave Hansen wrote: > On 10/05/2017 03:14 AM, Kirill A. Shutemov wrote: > > +++ b/arch/sparc/mm/hugetlbpage.c > > @@ -396,7 +396,7 @@ static void hugetlb_free_pte_range(struct mmu_gather > > *tlb, pmd_t *pmd, > > > > pmd_clear(pmd); > >

Re: [PATCH v3 5/6] iio: Add dummy counter driver

2017-10-08 Thread Jonathan Cameron
On Thu, 5 Oct 2017 14:14:38 -0400 William Breathitt Gray wrote: > This patch introduces the dummy counter driver. The dummy counter driver > serves as a reference implementation of a driver that utilizes the > Generic Counter interface. This is great - I was planning to

Re: [PATCH] gpio: thunderx: remove unused .map() hook from irq_domain_ops

2017-10-08 Thread Masahiro Yamada
2017-09-22 6:54 GMT+09:00 David Daney : > On 09/13/2017 07:37 PM, Masahiro Yamada wrote: >> >> This driver implements .alloc() hook, so .map() is not used. > > > Although this comment is true for this driver, it is unclear to me if the > statement is true in the general

[PATCH v3] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

2017-10-08 Thread Harsha Sharma
Replace instances of drm_framebuffer_reference/unreference() with *_get/put() suffixes and drm_dev_unref with *_put() suffix because get/put is shorter and consistent with the kernel use of *_get/put suffixes. Done with following coccinelle semantic patch @@ expression ex; @@ (

Re: [PATCH net-next RFC 2/9] net: dsa: mv88e6xxx: expose switch time as a PTP hardware clock

2017-10-08 Thread Richard Cochran
On Thu, Sep 28, 2017 at 10:25:34AM -0500, Brandon Streiff wrote: > +static int mv88e6xxx_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm) > +{ > + if (scaled_ppm == 0) > + return 0; > + > + return -EOPNOTSUPP; > +} We really want to have an adjustable clock here. More

[PATCH 0/2] crypto: lrw - Fixes for the 'create()' function

2017-10-08 Thread Christophe JAILLET
The first patch is the same as the one committed for crypto/xts.c applied a few days ago. (commit 5125e4e867ab ("crypto: xts - Fix an error handling path in 'create()'") in /git/herbert/crypto-2.6.git) The 2nd one is a pure speculation from me. The create function in 'crypto/xts.c' and

Re: [RFC GIT Pull V2] core watchdog sanitizing

2017-10-08 Thread Greg KH
On Fri, Oct 06, 2017 at 12:06:42AM +0200, Thomas Gleixner wrote: > Linus, > > please consider to pull the latest core-watchdog-for-linus git tree from: > >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > core-watchdog-for-linus > > The watchdog (hard/softlockup detector) code is

[PATCH 1/2] crypto: lrw - Fix an error handling path in 'create()'

2017-10-08 Thread Christophe JAILLET
All error handling paths 'goto err_drop_spawn' except this one. In order to avoid some resources leak, we should do it as well here. Fixes: 700cb3f5fe75 ("crypto: lrw - Convert to skcipher") Signed-off-by: Christophe JAILLET --- crypto/lrw.c | 6 -- 1 file

[PATCH 2/2] crypto: lrw - Check for incorrect cipher name

2017-10-08 Thread Christophe JAILLET
If the cipher name does not start with 'ecb(' we should bail out, as done in the 'create()' function in 'crypto/xts.c'. Fixes: 700cb3f5fe75 ("crypto: lrw - Convert to skcipher") Signed-off-by: Christophe JAILLET --- This patch is 100% speculative. It is based on

Re: [PATCH v3 00/17] kernel-doc: add supported to document nested structs/

2017-10-08 Thread Markus Heiser
> Am 07.10.2017 um 18:34 schrieb Jonathan Corbet : > > On Wed, 4 Oct 2017 08:48:38 -0300 > Mauro Carvalho Chehab wrote: > >> Right now, it is not possible to document nested struct and nested unions. >> kernel-doc simply ignore them. >> >> Add

Re: [PATCH 3/3] iio: adc: ina2xx: Allow setting Shunt Voltage PGA gain and Bus Voltage range

2017-10-08 Thread Jonathan Cameron
On Sun, 1 Oct 2017 21:48:18 +0200 Stefan Brüns wrote: > Reducing shunt and bus voltage range improves the accuracy, so allow > altering the default settings. > > Both settings are exposed as gain values. While for the shunt voltage > this is straightforward, the

Re: [PATCH v5 0/9] mtd: sharpslpart partition parser

2017-10-08 Thread Boris Brezillon
On Sun, 08 Oct 2017 11:53:11 +0200 Robert Jarzmik wrote: > Robert Jarzmik writes: > > > Boris Brezillon writes: > > > >> Hi Robert, > >> Wait a bit before applying. I think patches 6 to 9 have a dependency

[PATCH] um: Fix kcov crash before kernel is started.

2017-10-08 Thread Thomas Meyer
UMLs current_thread_info() unconditionally assumes that the top of the stack contains the thread_info structure. But on UML the __sanitizer_cov_trace_pc function is called for *all* functions! This results in an early crash: Prevent kcov from using invalid curent_thread_info() data by checking

Re: [PATCH v7 1/2] dt-bindings: gpio: uniphier: add UniPhier GPIO binding

2017-10-08 Thread Masahiro Yamada
Hi Linus, 2017-09-27 22:42 GMT+09:00 Linus Walleij : > On Wed, Sep 27, 2017 at 4:45 AM, Masahiro Yamada > wrote: > >> This GPIO controller is used on UniPhier SoC family. >> >> The vendor specific property "socionext,interrupt-ranges" is

Re: [PATCH net-next RFC 8/9] net: dsa: mv88e6xxx: add rx/tx timestamping support

2017-10-08 Thread Richard Cochran
On Thu, Sep 28, 2017 at 10:25:40AM -0500, Brandon Streiff wrote: > +static bool mv88e6xxx_should_tstamp(struct mv88e6xxx_chip *chip, int port, > + struct sk_buff *skb, unsigned int type) > +{ > + struct mv88e6xxx_port_hwtstamp *ps = >port_hwtstamp[port]; > +

Re: [PATCH 0/2] lib: Adjustments for 11 function implementations

2017-10-08 Thread Andy Shevchenko
On Sun, 2017-10-08 at 10:42 +0200, Christoph Hellwig wrote: > Please stop sending this crap. It's a move from one preference to > another slightly different one. You are free to apply your preference > if you do a major overhaul of some code (subject to maintainer > approval), > but without that

Re: [PATCH v3 2/6] iio: Introduce the generic counter interface

2017-10-08 Thread Jonathan Cameron
On Thu, 5 Oct 2017 14:13:44 -0400 William Breathitt Gray wrote: > This patch introduces the IIO generic counter interface for supporting > counter devices. The generic counter interface serves as a catch-all to > enable rudimentary support for devices that qualify as

Re: Build regressions/improvements in v4.14-rc3

2017-10-08 Thread Thomas Meyer
On Sun, Oct 08, 2017 at 09:50:53AM +1100, Michael Ellerman wrote: > Thomas Meyer writes: > > > On Thu, Oct 05, 2017 at 01:43:31PM +1100, Michael Ellerman wrote: > >> Thomas Meyer writes: > >> > On Tue, Oct 03, 2017 at 08:18:14PM +1100, Michael Ellerman wrote: >

Re: [PATCH v9 2/5] x86/cpuid: Add generic table for cpuid dependencies

2017-10-08 Thread Thomas Gleixner
On Fri, 6 Oct 2017, Andi Kleen wrote: > From: Andi Kleen > > Some CPUID features depend on other features. Currently it's > possible to to clear dependent features, but not clear the base features, > which can cause various interesting problems. > > This patch implements

Re: [PATCH v9 4/5] x86/xsave: Make XSAVE check the base CPUID features before enabling

2017-10-08 Thread Thomas Gleixner
On Fri, 6 Oct 2017, Andi Kleen wrote: > From: Andi Kleen > > Before enabling XSAVE, not only check the XSAVE specific CPUID bits, > but also the base CPUID features of the respective XSAVE feature. > This allows to disable individual XSAVE states using the existing >

Re: [for-next][PATCH 15/16] ftrace: Add freeing algorithm to free ftrace_mod_maps

2017-10-08 Thread Joel Fernandes
Hi Steve, > "Joel Fernandes (Google)" wrote: [..] > Also could you let me know what is the correct behavior of the filters > after a module being traced is unloaded, are the filters supposed to > be setup again after the module is unloaded, before the module can be >

Re: [PATCH 0/2] lib: Adjustments for 11 function implementations

2017-10-08 Thread Christoph Hellwig
Please stop sending this crap. It's a move from one preference to another slightly different one. You are free to apply your preference if you do a major overhaul of some code (subject to maintainer approval), but without that they simply are churn. NAK for both patches.

[PATCH 0/2] staginng: atomisp: memory allocation cleanups

2017-10-08 Thread Aishwarya Pant
Patch series performs minor code cleanups using coccinelle to simplify memory allocation tests and remove redundant OOM log messages. Aishwarya Pant (2): staging: atomisp2: cleanup null check on memory allocation staging: atomisp: cleanup out of memory messages

Re: [PATCH 4.9 000/104] 4.9.54-stable review

2017-10-08 Thread Greg Kroah-Hartman
On Sat, Oct 07, 2017 at 07:44:24AM -0700, Guenter Roeck wrote: > On 10/07/2017 02:39 AM, Greg Kroah-Hartman wrote: > > On Fri, Oct 06, 2017 at 10:50:38AM +0200, Greg Kroah-Hartman wrote: > > > This is the start of the stable review cycle for the 4.9.54 release. > > > There are 104 patches in this

Re: [PATCH 3.18 00/35] 3.18.74-stable review

2017-10-08 Thread Greg Kroah-Hartman
On Sat, Oct 07, 2017 at 07:43:34AM -0700, Guenter Roeck wrote: > On 10/07/2017 02:40 AM, Greg Kroah-Hartman wrote: > > On Fri, Oct 06, 2017 at 11:24:40AM +0200, Greg Kroah-Hartman wrote: > > > This is the start of the stable review cycle for the 3.18.74 release. > > > There are 35 patches in this

Re: [PATCH 2/2] iommu/amd: Enforce alignment for MSI IRQs

2017-10-08 Thread Thomas Gleixner
On Fri, 6 Oct 2017, Joerg Roedel wrote: > From: Joerg Roedel > > Make use of the new alignment capability of > alloc_irq_index() to enforce IRQ index alignment > for MSI. > > Reported-by: Thomas Gleixner > Fixes: 2b324506341cb ('iommu/amd: Add routines to

Re: [PATCH] Userfaultfd: Add description for UFFD_FEATURE_SIGBUS

2017-10-08 Thread Mike Rapoport
Hello Prakash, On Fri, Oct 06, 2017 at 07:52:20PM -0700, Prakash Sangappa wrote: > Userfaultfd feature UFFD_FEATURE_SIGBUS was merged recently and should > be available in Linux 4.14 release. This patch is for the manpage > changes documenting this API. > > Documents the following commit: > >

Re: powerpc: Always initialize input array when calling epapr_hypercall()

2017-10-08 Thread Michael Ellerman
On Thu, 2017-09-28 at 13:33:39 UTC, Seth Forshee wrote: > Several callers to epapr_hypercall() pass an uninitialized stack > allocated array for the input arguments, presumably because they > have no input arguments. However this can produce errors like > this one > >

Re: selftests/powerpc: Use snprintf to construct DSCR sysfs interface paths

2017-10-08 Thread Michael Ellerman
On Thu, 2017-09-28 at 13:34:26 UTC, Seth Forshee wrote: > Currently sprintf is used, and while paths should never exceed > the size of the buffer it is theoretically possible since > dirent.d_name is 256 bytes. As a result this trips > -Wformat-overflow, and since the test is built with -Wall

Re: [1/1] powerpc: get_wchan(): solve possible race scenario due to parallel wakeup

2017-10-08 Thread Michael Ellerman
On Tue, 2016-04-19 at 10:18:21 UTC, Kautuk Consul wrote: > Add a check for p->state == TASK_RUNNING so that any wake-ups on > task_struct p in the interim lead to 0 being returned by get_wchan(). > > Signed-off-by: Kautuk Consul Applied to powerpc next, thanks.

Re: Linux 3.18.74

2017-10-08 Thread Greg KH
diff --git a/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt b/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt new file mode 100644 index ..6ec1a880ac18 --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt @@ -0,0 +1,46 @@

Linux 3.18.74

2017-10-08 Thread Greg KH
I'm announcing the release of the 3.18.74 kernel. All users of the 3.18 kernel series must upgrade. The updated 3.18.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-3.18.y and can be browsed at the normal kernel.org git web

Linux 4.4.91

2017-10-08 Thread Greg KH
I'm announcing the release of the 4.4.91 kernel. All users of the 4.4 kernel series must upgrade. The updated 4.4.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.4.y and can be browsed at the normal kernel.org git web browser:

[PATCH 2/2] staging: atomisp: cleanup out of memory messages

2017-10-08 Thread Aishwarya Pant
Logging of explicit out of memory messages is redundant since memory allocation failures produce a backtrace. Done with the help of the following cocci script: @@ expression ex, ret; statement s; constant char[] c; constant err; identifier f, l; @@ ex =

[PATCH 1/2] staging: atomisp2: cleanup null check on memory allocation

2017-10-08 Thread Aishwarya Pant
For memory allocation functions that fail with a NULL return value, it is preferred to use the (!x) test in place of (x == NULL). Changes in atomisp2/css2400/sh_css.c were done by hand. Done with the help of the following cocci script: @@ type T; T* p; statement s,s1; @@ p =

Re: [PATCH v5 2/4] dmaengine: Add STM32 MDMA driver

2017-10-08 Thread Vinod Koul
On Thu, Sep 28, 2017 at 05:36:41PM +0200, Pierre-Yves MORDRET wrote: > This patch adds the driver for the STM32 MDMA controller. > > Master Direct memory access (MDMA) is used in order to provide high-speed > data transfer between memory and memory or between peripherals and memory. > > MDMA

Re: [PATCH v5 1/4] dt-bindings: Document the STM32 MDMA bindings

2017-10-08 Thread Vinod Koul
On Thu, Sep 28, 2017 at 05:36:40PM +0200, Pierre-Yves MORDRET wrote: > This patch adds documentation of device tree bindings for the STM32 MDMA > controller. Applied, thanks -- ~Vinod

Re: [PATCH] vmalloc: add __alloc_vm_area() for optimizing vmap stack

2017-10-08 Thread Christoph Hellwig
This looks fine in general, but a few comments: - can you split adding the new function from switching over the fork code? - at least kasan and vmalloc_user/vmalloc_32_user use very similar patterns, can you switch them over as well? - the new __alloc_vm_area looks very different from

Re: [PATCH 4.9 000/104] 4.9.54-stable review

2017-10-08 Thread Greg Kroah-Hartman
On Sat, Oct 07, 2017 at 11:56:17AM -0500, Tom Gall wrote: > > > On Oct 6, 2017, at 3:50 AM, Greg Kroah-Hartman > > wrote: > > > > This is the start of the stable review cycle for the 4.9.54 release. > > There are 104 patches in this series, all will be posted as a

Re: [PATCH 1/2] iommu/amd: Add align parameter to alloc_irq_index()

2017-10-08 Thread Thomas Gleixner
On Fri, 6 Oct 2017, Joerg Roedel wrote: > From: Joerg Roedel > > For multi-MSI IRQ ranges the IRQ index needs to be aligned > to the power-of-two of the requested IRQ count. Extend the > alloc_irq_index() function to allow such an allocation. > > Reported-by: Thomas Gleixner

[RFC] workqueue: Fix irq inversion deadlock in manage_workers()

2017-10-08 Thread Boqun Feng
Josef reported a HARDIRQ-safe -> HARDIRQ-unsafe lock order detected by lockdep: | [ 1270.472259] WARNING: HARDIRQ-safe -> HARDIRQ-unsafe lock order detected | [ 1270.472783] 4.14.0-rc1-xfstests-12888-g76833e8 #110 Not tainted | [ 1270.473240] -

Re: [PATCH net-next RFC 4/9] net: dsa: mv88e6xxx: add support for event capture

2017-10-08 Thread Richard Cochran
There are some issues here. On Thu, Sep 28, 2017 at 10:25:36AM -0500, Brandon Streiff wrote: > +static int mv88e6xxx_config_periodic_trig(struct mv88e6xxx_chip *chip, > + u32 ns, u16 picos) > +{ > + int err; > + u16 global_config; > + > + if

Re: [PATCH] arm64: kdump: Avoid to power off nonpanic CPUs

2017-10-08 Thread Mark Rutland
Hi Leo, On Sun, Oct 08, 2017 at 10:12:46PM +0800, Leo Yan wrote: > commit a88ce63b642c ("arm64: kexec: have own crash_smp_send_stop() for > crash dump for nonpanic cores") introduces ARM64 architecture function > crash_smp_send_stop() to replace the weak function, this results in > the nonpanic

Re: [PATCH 11/12] net/mlx5: replace with

2017-10-08 Thread David Miller
From: Masahiro Yamada Date: Mon, 9 Oct 2017 01:10:12 +0900 > The header include/linux/mlx5/driver.h requires the definition of > struct radix_tree_root, but does not need to know anything about > other radix tree stuff. > > Include instead of to > reduce the

Re: [RESEND PATCH] prctl: add PR_[GS]ET_PDEATHSIG_PROC

2017-10-08 Thread Jürg Billeter
On Thu, 2017-10-05 at 18:27 +0200, Oleg Nesterov wrote: > On 10/03, Jürg Billeter wrote: > > > > My use case is to provide a way for a process to spawn a child and > > ensure that no descendants survive when that child dies. Avoiding > > runaway processes is desirable in many situations. My

[PATCH] kconfig: Document important expression functions

2017-10-08 Thread Ulf Magnusson
Many of these functions are quite the head scratchers if you don't know what they're trying to do. Document them. Also make it clear which functions rewrite expressions in-place and which return new expressions. This prevents memory errors. No functional changes. Only comments added.

Re: [PATCH] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-08 Thread Andy Shevchenko
On Thu, Oct 5, 2017 at 9:04 PM, Hans de Goede wrote: > It seems that the WMI GUID used by the PEAQ 2-in-1 WMI hotkeys is not > as unique as a GUID should be and is used on some other devices too. > > This is causing spurious key-press reports on these other devices. > > This

Re: [6/8] cris-cryptocop: Delete two variables in cryptocop_ioctl_process()

2017-10-08 Thread Alexander Sverdlin
Hello Markus, On 26/08/16 14:56, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 26 Aug 2016 13:40:29 +0200 > > A zero was assigned to the local variables "cipher_done" and "csum_done" > at one place. But they were not read within this function. >

Re: [PATCH v6 05/11] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-10-08 Thread Corentin Labbe
On Thu, Sep 28, 2017 at 09:37:08AM +0200, Corentin Labbe wrote: > On Wed, Sep 27, 2017 at 04:02:10PM +0200, Andrew Lunn wrote: > > Hi Corentin > > > > > +Required properties for the mdio-mux node: > > > + - compatible = "mdio-mux" > > > > This is too generic. Please add a more specific

Re: [BUG] GPF on reboot of box

2017-10-08 Thread Steven Rostedt
On Sat, 7 Oct 2017 15:49:33 -0700 Andy Lutomirski wrote: > Howdy, batman! Can you try the attached patch? Yep and it worked. Reported-by: Steven Rostedt (VMware) Tested-by: Steven Rostedt (VMware) Thanks! -- Steve

Re: [PATCH net-next RFC 8/9] net: dsa: mv88e6xxx: add rx/tx timestamping support

2017-10-08 Thread Richard Cochran
On Thu, Sep 28, 2017 at 10:25:40AM -0500, Brandon Streiff wrote: > We also utilize a feature of the "generation 3" PTP hardware that lets > us to embed the timestamp value into one of the reserved fields in the > PTP header. This lets us extract the timestamp out of the header and > avoid an SMI

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

2017-10-08 Thread Mark Rutland
On Sat, Oct 07, 2017 at 03:10:06AM +, Levin, Alexander (Sasha Levin) wrote: > On Fri, Oct 06, 2017 at 07:13:22PM +0100, Mark Rutland wrote: > >Hi Greg, > > > >On Fri, Oct 06, 2017 at 10:52:04AM +0200, Greg Kroah-Hartman wrote: > >> 4.9-stable review patch. If anyone has any objections, please

Re: [PATCH v5 09/14] platform/x86: dell-smbios: Introduce dispatcher for SMM calls

2017-10-08 Thread Andy Shevchenko
On Sat, Oct 7, 2017 at 7:59 AM, Mario Limonciello wrote: > This splits up the dell-smbios driver into two drivers: > * dell-smbios > * dell-smbios-smm > > dell-smbios can operate with multiple different dispatcher drivers to > perform SMBIOS operations. > > Also modify

Re: [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk

2017-10-08 Thread Krzysztof Kozlowski
On Sun, Oct 08, 2017 at 06:11:12PM +0530, Anand Moon wrote: > Hi Krzysztof, > > On 6 October 2017 at 12:12, Krzysztof Kozlowski wrote: > > On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon wrote: > >> remove the disable and enable of phy clk. > >> phy clk is

[PATCH 12/12] drm/i915: replace with

2017-10-08 Thread Masahiro Yamada
The header drivers/gpu/drm/i915/i915_gem_context.h requires the definition of struct radix_tree_root, but does not need to know anything about other radix tree stuff. Include instead of to reduce the number of included header files. While we are here, let's add missing where radix tree

[PATCH 08/12] fscache: include

2017-10-08 Thread Masahiro Yamada
This header needs to know the definition of struct radix_tree_root. Signed-off-by: Masahiro Yamada --- include/linux/fscache.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/fscache.h b/include/linux/fscache.h index f4ff47d..0a67b2f5 100644 ---

[PATCH 04/12] writeback: replace with

2017-10-08 Thread Masahiro Yamada
This header requires the definition of struct radix_tree_root, but does not need to know anything about other radix tree stuff. Include instead of to reduce the header dependency. Signed-off-by: Masahiro Yamada --- include/linux/backing-dev-defs.h | 2 +- 1

[PATCH 06/12] fs: replace with

2017-10-08 Thread Masahiro Yamada
This header requires the definition of struct radix_tree_root, but does not need to know anything about other radix tree stuff. Include instead of to reduce the header dependency. Signed-off-by: Masahiro Yamada --- include/linux/fs.h | 2 +- 1 file changed, 1

[PATCH 03/12] irqdomain: replace with

2017-10-08 Thread Masahiro Yamada
This header requires the definition of struct radix_tree_root, but does not need to know anything about other radix tree stuff. Include instead of to reduce the header dependency. Signed-off-by: Masahiro Yamada --- include/linux/irqdomain.h | 2 +- 1 file

  1   2   3   4   5   6   >