Re: [PATCH v2] USB: add SPDX identifiers to all remaining files in drivers/usb/

2017-11-04 Thread Greg Kroah-Hartman
On Fri, Nov 03, 2017 at 05:53:01PM +0100, Johan Hovold wrote: > On Fri, Nov 03, 2017 at 11:28:30AM +0100, Greg Kroah-Hartman wrote: > > It's good to have SPDX identifiers in all files to make it easier to > > audit the kernel tree for correct licenses. > > > > Update the drivers/usb/ and

Re: [PATCH] Documentation: Add Frank Rowand to list of enforcement statement endorsers

2017-11-04 Thread g...@kroah.com
On Fri, Nov 03, 2017 at 12:50:58PM -0700, frowand.l...@gmail.com wrote: > From: Frank Rowand > > Add my name to the list. > > Signed-off-by: Frank Rowand Thanks, now applied. > --- > > Hi Greg, > > I noticed that there is a double entry for

Re: [RFT][PATCH v2 1/2] PM / domains: Rework governor code to be more consistent

2017-11-04 Thread Rafael J. Wysocki
On Sat, Nov 4, 2017 at 3:34 AM, Ramesh Thomas wrote: > On 2017-11-03 at 12:47:20 +0100, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> >> The genpd governor currently uses negative PM QoS values to indicate >> the "no suspend"

Re: [RFC][PATCH] x86, kaiser: do not require mapping process kernel stacks

2017-11-04 Thread Andy Lutomirski
On Fri, Nov 3, 2017 at 3:03 PM, Dave Hansen wrote: > > With the KAISER code that I posted a few days ago, we map and unmap > each of the kernel stacks when they are created. That's slow and > it is also the single largest thing still mapped into the user > address space. >

Re: [PATCH v10 4/5] watchdog: Add RAVE SP watchdog driver

2017-11-04 Thread Greg Kroah-Hartman
On Tue, Oct 31, 2017 at 09:36:55AM -0700, Andrey Smirnov wrote: > This driver provides access to RAVE SP watchdog functionality. > > Cc: linux-kernel@vger.kernel.org > Cc: linux-watch...@vger.kernel.org > Cc: cphe...@gmail.com > Cc: Lucas Stach > Cc: Nikita Yushchenko

[PATCH] writeback: remove the unused function parameter

2017-11-04 Thread Wang Long
Signed-off-by: Wang Long --- include/linux/backing-dev.h | 2 +- mm/page-writeback.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h index 1662157..186a2e7 100644 ---

Re: [PATCH v10 1/5] serdev: Make .remove in struct serdev_device_driver optional

2017-11-04 Thread Greg Kroah-Hartman
On Tue, Oct 31, 2017 at 09:36:52AM -0700, Andrey Smirnov wrote: > Using devres infrastructure it is possible to write a serdev driver > that doesn't have any code that needs to be called as a part of > .remove. Add code to make .remove optional. What about manual unbind from userspace through

Re: [PATCH 3/3] nvme: fix eui_show() print format

2017-11-04 Thread Javier González
> On 3 Nov 2017, at 16.16, Joe Perches wrote: > > On Fri, 2017-11-03 at 13:55 +0100, Christoph Hellwig wrote: >> On Fri, Nov 03, 2017 at 11:02:50AM +0100, Javier González wrote: >>> Signed-off-by: Javier González > [] >>> diff --git

Re: [PATCH v4 03/20] firmware: arm_scmi: add basic driver infrastructure for SCMI

2017-11-04 Thread Jassi Brar
On Fri, Nov 3, 2017 at 8:17 PM, Sudeep Holla wrote: . > +int scmi_do_xfer(const struct scmi_handle *handle, struct scmi_xfer *xfer) > +{ > + int ret; > + int timeout; > + struct scmi_info *info = handle_to_scmi_info(handle); > + struct device

[PATCH v2] writeback: remove the unused function parameter

2017-11-04 Thread Wang Long
The parameter `struct bdi_writeback *wb` is not been used in the function body. so we just remove it. Signed-off-by: Wang Long --- include/linux/backing-dev.h | 2 +- mm/page-writeback.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] writeback: remove the unused function parameter 【外域邮件.谨慎查阅】

2017-11-04 Thread wanglong
> On 4 Nov 2017, at 7:41 PM, gre...@linuxfoundation.org wrote: > > On Thu, Nov 02, 2017 at 11:44:32PM -0400, Wang Long wrote: >> Signed-off-by: Wang Long >> --- > > I know I don't take patches without any changelog text :( > I will add some changelog and send v2

[PATCH 2/4] target: Combine two condition checks into one statement in target_xcopy_do_work()

2017-11-04 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 4 Nov 2017 13:26:46 +0100 The same label was used by goto statements after two condition checks. Thus use a single statement instead. Signed-off-by: Markus Elfring ---

[PATCH 3/4] target: Improve a size determination in three functions

2017-11-04 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 4 Nov 2017 13:35:08 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

Re: [PATCH V0 2/3] perf/x86/intel/bm.c: Add Intel Branch Monitoring support

2017-11-04 Thread Jiri Olsa
On Fri, Nov 03, 2017 at 11:00:05AM -0700, Megha Dey wrote: SNIP > + event->event_caps |= PERF_EV_CAP_BM; > + /* > + * cfg contains one of the 6 possible Branch Monitoring events > + */ > + cfg = event->attr.config; > + if (cfg < 0 || cfg > (BM_MAX_EVENTS - 1)) > +

Re: [PATCH V0 2/3] perf/x86/intel/bm.c: Add Intel Branch Monitoring support

2017-11-04 Thread Jiri Olsa
On Fri, Nov 03, 2017 at 11:00:05AM -0700, Megha Dey wrote: SNIP > + > +static int intel_bm_event_nmi_handler(unsigned int cmd, struct pt_regs *regs) > +{ > + struct perf_event *event; > + union bm_detect_status stat; > + struct perf_sample_data data; > + int i; > + unsigned

Re: [PATCH] net: usb: asix: fill null-ptr-deref in asix_suspend

2017-11-04 Thread David Miller
From: Andrey Konovalov Date: Thu, 2 Nov 2017 21:26:59 +0100 > When asix_suspend() is called dev->driver_priv might not have been > assigned a value, so we need to check that it's not NULL. > > Found by syzkaller. ... > Signed-off-by: Andrey Konovalov

Re: [PATCH] mm: filemap: remove include of hardirq.h

2017-11-04 Thread Matthew Wilcox
On Sat, Nov 04, 2017 at 02:47:48AM +0800, Yang Shi wrote: > in_atomic() has been moved to include/linux/preempt.h, and the filemap.c > doesn't use in_atomic() directly at all, so it sounds unnecessary to > include hardirq.h. > With removing hardirq.h, around 32 bytes can be saved for x86_64

Re: [PATCH 07/12] hwrng: bcm2835-rng: Manage an optional clock

2017-11-04 Thread Stefan Wahren
Hi Florian, > Florian Fainelli hat am 2. November 2017 um 02:04 > geschrieben: > > > One of the last steps before bcm63xx-rng can be eliminated is to manage > a clock during hwrng::init and hwrng::cleanup, so fetch it in the probe > function, and manage it during these

Re: [PATCH] net: sched: cls_u32: use bitwise & rather than logical && on n->flags

2017-11-04 Thread David Miller
From: Colin King Date: Fri, 3 Nov 2017 08:09:45 + > From: Colin Ian King > > Currently n->flags is being operated on by a logical && operator rather > than a bitwise & operator. This looks incorrect as these should be bit > flag

RE: [PATCH 10/17] hyper-v: trace vmbus_open()

2017-11-04 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Saturday, November 4, 2017 4:05 AM > To: KY Srinivasan > Cc: Steven Rostedt ; o...@aepfle.de; Stephen > Hemminger ; jasow...@redhat.com;

Re: [PATCH 1/1] drm/amd/powerplay: initialize a variable before using it

2017-11-04 Thread Nicolas Iooss
On Sun, Sep 3, 2017 at 2:00 PM, Nicolas Iooss wrote: > > Function vega10_apply_state_adjust_rules() only initializes > stable_pstate_sclk_dpm_percentage when > data->registry_data.stable_pstate_sclk_dpm_percentage is not between 1 > and 100. The variable is then used

Re: [PATCH V0 2/3] perf/x86/intel/bm.c: Add Intel Branch Monitoring support

2017-11-04 Thread Jiri Olsa
On Fri, Nov 03, 2017 at 11:00:05AM -0700, Megha Dey wrote: SNIP > + event->hw.bm_ctrl = (bm_window_size << BM_WINDOW_SIZE_SHIFT) | > + (bm_guest_disable << BM_GUEST_DISABLE_SHIFT) | > + (bm_lbr_freeze << BM_LBR_FREEZE_SHIFT) | > +

Re: [PATCH V0 2/3] perf/x86/intel/bm.c: Add Intel Branch Monitoring support

2017-11-04 Thread Jiri Olsa
On Fri, Nov 03, 2017 at 11:00:05AM -0700, Megha Dey wrote: SNIP > +static unsigned int bm_threshold = BM_MAX_THRESHOLD; > +static unsigned int bm_mispred_evt_cnt; > + > +/* Branch monitoring counter owners */ > +static struct perf_event *bm_counter_owner[2]; SNIP > + * Find a hardware

Re: [PATCH V0 2/3] perf/x86/intel/bm.c: Add Intel Branch Monitoring support

2017-11-04 Thread Jiri Olsa
On Fri, Nov 03, 2017 at 11:00:05AM -0700, Megha Dey wrote: SNIP > + > +static void intel_bm_event_update(struct perf_event *event) > +{ > + union bm_detect_status cur_stat; > + > + rdmsrl(BR_DETECT_STATUS_MSR, cur_stat.raw); > + local64_set(>hw.prev_count, (uint64_t)cur_stat.raw); >

Re: [PATCH V0 2/3] perf/x86/intel/bm.c: Add Intel Branch Monitoring support

2017-11-04 Thread Jiri Olsa
On Fri, Nov 03, 2017 at 11:00:05AM -0700, Megha Dey wrote: SNIP > + > +static int intel_bm_event_nmi_handler(unsigned int cmd, struct pt_regs *regs) > +{ > + struct perf_event *event; > + union bm_detect_status stat; > + struct perf_sample_data data; > + int i; > + unsigned

Re: [PATCH 3/5] dt-bindings: arm: Document Socionext MB86S71 and Fujitsu F-Cue

2017-11-04 Thread Andreas Färber
Am 04.11.2017 um 22:57 schrieb Ard Biesheuvel: > On 4 November 2017 at 13:44, Andreas Färber wrote: >> Hi everyone, >> >> The non-building clk driver has been removed for 4.14, but this patchset >> seems stuck on matters of naming and maintenance... >> >> Am 30.06.2017 um 01:18

Re: [PATCH 1/3] nvme: do not check for ns on rw path

2017-11-04 Thread Keith Busch
On Sat, Nov 04, 2017 at 09:18:25AM +0100, Christoph Hellwig wrote: > On Fri, Nov 03, 2017 at 09:02:04AM -0600, Keith Busch wrote: > > If the namespace has metadata, but the request doesn't have a metadata > > payload attached to it for whatever reason, we can't construct the command > > for that

Re: Introduce clock precision to help time travelers was Re: Extreme time jitter with suspend/resume cycles

2017-11-04 Thread Alexandre Belloni
On 18/10/2017 at 23:56:38 +0200, Pavel Machek wrote: > > Some RTCs will tell you when they lost time/time accuracy and this > > should be properly reported by the driver. If not, this has to be > > implemented. > > How is it reported to the userspace? > Userspace will get -EINVAL when using the

Re: [PATCH 3/5] dt-bindings: arm: Document Socionext MB86S71 and Fujitsu F-Cue

2017-11-04 Thread Ard Biesheuvel
On 4 November 2017 at 15:30, Andreas Färber wrote: > Am 04.11.2017 um 22:57 schrieb Ard Biesheuvel: >> On 4 November 2017 at 13:44, Andreas Färber wrote: >>> Hi everyone, >>> >>> The non-building clk driver has been removed for 4.14, but this patchset >>>

Re: [PATCH 10/17] hyper-v: trace vmbus_open()

2017-11-04 Thread Greg KH
On Wed, Nov 01, 2017 at 05:43:08PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On > > Behalf Of Steven Rostedt > > Sent: Tuesday, October 31, 2017 6:10 AM > > To: Greg KH > >

Re: [RFT][PATCH v2 2/2] PM / QoS: Fix device resume latency framework

2017-11-04 Thread Rafael J. Wysocki
On Sat, Nov 4, 2017 at 12:30 PM, Rafael J. Wysocki wrote: > On Sat, Nov 4, 2017 at 3:28 AM, Ramesh Thomas wrote: >> On 2017-11-03 at 09:39:08 -0700, Reinette Chatre wrote: >>> Hi Rafael, >>> >>> I started to test this but found myself triggering one of

[PATCH v3] tty: serial: meson: allow baud-rates lower than 9600

2017-11-04 Thread Thomas Rohloff
Devices like DCF77 receivers need the baud-rate to be as low as 50. I have tested this on a Meson GXL device with uart_A. Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Carlo Caione Cc: Kevin Hilman Cc:

Re: [PATCH v3] tty: serial: meson: allow baud-rates lower than 9600

2017-11-04 Thread Greg Kroah-Hartman
On Sat, Nov 04, 2017 at 02:00:00PM +0100, V10lator wrote: > Devices like DCF77 receivers need the baud-rate to be as low as 50. > > I have tested this on a Meson GXL device with uart_A. > > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: Carlo Caione

[PATCH 0/4] target: Adjustments for four function implementations

2017-11-04 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 4 Nov 2017 14:09:09 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Use common error handling code in three functions Combine two condition checks into one statement

Re: [PATCH] netfilter/ipvs: clear ipvs_property flag when SKB net namespace changed

2017-11-04 Thread David Miller
From: Simon Horman Date: Thu, 2 Nov 2017 15:46:50 +0100 > On Sat, Oct 28, 2017 at 01:33:09PM +0300, Julian Anastasov wrote: >> >> Hello, >> >> On Thu, 26 Oct 2017, Ye Yin wrote: >> >> > When run ipvs in two different network namespace at the same host, and one >> >

Re: [PATCH 3/5] dt-bindings: arm: Document Socionext MB86S71 and Fujitsu F-Cue

2017-11-04 Thread Ard Biesheuvel
On 4 November 2017 at 13:44, Andreas Färber wrote: > Hi everyone, > > The non-building clk driver has been removed for 4.14, but this patchset > seems stuck on matters of naming and maintenance... > > Am 30.06.2017 um 01:18 schrieb Masahiro Yamada: >> Hi Andreas, >> >>

Re: drivers/x86: add thinkpad-wmi

2017-11-04 Thread Corentin Chary
On Tue, Oct 24, 2017 at 10:59 PM, Mario Limonciello wrote: > Hi Chary, > > I think it's interesting to see this submission coming in at this time. > We're working on setting up precedent for how WMI vendor drivers should work > right now and I have another patch series

[PATCH 1/5] selftests/x86/protection_keys: Fix syscall NR redefinition warnings

2017-11-04 Thread Andy Lutomirski
On new enough glibc, the pkey syscalls numbers are available. Check first before defining them to avoid warnings like: protection_keys.c:198:0: warning: "SYS_pkey_alloc" redefined Cc: Dave Hansen Cc: sta...@vger.kernel.org Signed-off-by: Andy Lutomirski

[PATCH 3/5] selftests/x86/ldt_gdt: Add infrastructure to test set_thread_area()

2017-11-04 Thread Andy Lutomirski
Much of the test design could apply to set_thread_area() (i.e. GDT), not just modify_ldt(). Add set_thread_area() to the install_valid_mode() helper. Signed-off-by: Andy Lutomirski --- tools/testing/selftests/x86/ldt_gdt.c | 53 --- 1 file

[PATCH 0/5] Minor selftests improvements

2017-11-04 Thread Andy Lutomirski
This improves and robustifies the ldt_gdt test and fixes compiler warnings in the protection_keys test. Andy Lutomirski (5): selftests/x86/protection_keys: Fix syscall NR redefinition warnings selftests/x86/ldt_gdt: Robustify against set_thread_area() and LAR oddities

Re: [RFT][PATCH v2 2/2] PM / QoS: Fix device resume latency framework

2017-11-04 Thread Rafael J. Wysocki
On Fri, Nov 3, 2017 at 5:39 PM, Reinette Chatre wrote: > Hi Rafael, > > I started to test this but found myself triggering one of the warnings: > > On 11/3/2017 4:50 AM, Rafael J. Wysocki wrote: >> --- linux-pm.orig/include/linux/pm_qos.h >> +++

Re: [PATCH v17 4/6] virtio-balloon: VIRTIO_BALLOON_F_SG

2017-11-04 Thread Tetsuo Handa
Wei Wang wrote: > On 11/03/2017 07:25 PM, Tetsuo Handa wrote: > >> @@ -184,8 +307,12 @@ static unsigned fill_balloon(struct virtio_balloon > >> *vb, size_t num) > >> > >>num_allocated_pages = vb->num_pfns; > >>/* Did we get any? */ > >> - if (vb->num_pfns != 0) > >> -

[RFT][Update][PATCH v2 2/2] PM / QoS: Fix device resume latency framework

2017-11-04 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The special value of 0 for device resume latency PM QoS means "no restriction", but there are two problems with that. First, device resume latency PM QoS requests with 0 as the value are always put in front of requests with positive values in

Re: [PATCH v3 net-next 0/5] eBPF-based device cgroup controller

2017-11-04 Thread David Miller
From: Roman Gushchin Date: Thu, 2 Nov 2017 13:15:25 -0400 > This patchset introduces an eBPF-based device controller for cgroup > v2. This doesn't apply cleanly to net-next, please respin. Thank you.

Re: [PATCH] usb: musb: musb_host: Introduce postponed URB giveback

2017-11-04 Thread Matwey V. Kornilov
Hi Bin, I've just checked that the issue is still present in 4.13.10. 2017-04-27 13:20 GMT+03:00 Matwey V. Kornilov : > This commit changes the order of actions undertaken in > musb_advance_schedule() in order to overcome issue with broken > isochronous transfer [1]. > > There

[PATCH urgent] Revert "x86/mm: Stop calling leave_mm() in idle code"

2017-11-04 Thread Andy Lutomirski
This reverts commit 43858b4f25cf0adc5c2ca9cf5ce5fdf2532941e5. The reason I removed the leave_mm() calls in question is because the heuristic wasn't needed after that patch. With the original version of my PCID series, we never flushed a "lazy cpu" (i.e. a CPU running kernel thread) due a flush

Re: [RFT][PATCH v2 2/2] PM / QoS: Fix device resume latency framework

2017-11-04 Thread Rafael J. Wysocki
On Sat, Nov 4, 2017 at 3:28 AM, Ramesh Thomas wrote: > On 2017-11-03 at 09:39:08 -0700, Reinette Chatre wrote: >> Hi Rafael, >> >> I started to test this but found myself triggering one of the warnings: >> >> On 11/3/2017 4:50 AM, Rafael J. Wysocki wrote: >> > ---

Re: [PATCH] writeback: remove the unused function parameter

2017-11-04 Thread Greg KH
On Thu, Nov 02, 2017 at 11:44:32PM -0400, Wang Long wrote: > Signed-off-by: Wang Long > --- I know I don't take patches without any changelog text :(

Re: linux-next: build warnings after merge of the tip tree

2017-11-04 Thread Masami Hiramatsu
On Sat, 4 Nov 2017 09:01:34 +0100 Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > > net/sctp/probe.c: In function 'sctpprobe_exit': > > > net/sctp/probe.c:240:2: warning: 'unregister_jprobe' is deprecated > > > [-Wdeprecated-declarations] > > >

[PATCH v3] tty: serial: meson: allow baud-rates lower than 9600

2017-11-04 Thread V10lator
Devices like DCF77 receivers need the baud-rate to be as low as 50. I have tested this on a Meson GXL device with uart_A. Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Carlo Caione Cc: Kevin Hilman Cc:

[PATCH 1/4] target: Use common error handling code in three functions

2017-11-04 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 4 Nov 2017 13:13:20 +0100 Adjust jump targets so that a bit of exception handling can be better reused at the end of these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

Re: [PATCH] tcp_nv: use do_div() instead of expensive div64_u64()

2017-11-04 Thread David Miller
From: Konstantin Khlebnikov Date: Thu, 02 Nov 2017 17:07:05 +0300 > Average RTT is 32-bit thus full 64-bit division is redundant. > > Signed-off-by: Konstantin Khlebnikov > Suggested-by: Stephen Hemminger >

Re: [PATCH V3 0/7] blk-mq: don't allocate driver tag beforehand for flush rq

2017-11-04 Thread Jens Axboe
On 11/03/2017 10:17 PM, Ming Lei wrote: > On Thu, Nov 02, 2017 at 11:24:31PM +0800, Ming Lei wrote: >> Hi Jens, >> >> This patchset avoids to allocate driver tag beforehand for flush rq >> in case of I/O scheduler, then flush rq isn't treated specially >> wrt. get/put driver tag, code gets cleanup

Re: [PATCH v1 3/3] KVM: arm64: add ESB in exception handler entry and exit.

2017-11-04 Thread kbuild test robot
-ci/linux/commits/Dongjiu-Geng/arm64-add-a-macro-for-SError-synchronization/20171104-224216 base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core config: arm64-allmodconfig (attached as .config) compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce

[PATCH] usbtmc: Use common error handling code in three functions

2017-11-04 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 4 Nov 2017 19:36:56 +0100 * Adjust jump targets so that two error messages are stored only once at the end of these function implementations. * Replace 11 calls of the function "dev_err" and 11 assignments to the variable "rv"

Re: [PATCH V3 0/7] blk-mq: don't allocate driver tag beforehand for flush rq

2017-11-04 Thread Jens Axboe
On 11/04/2017 08:18 AM, Jens Axboe wrote: > On 11/03/2017 10:17 PM, Ming Lei wrote: >> On Thu, Nov 02, 2017 at 11:24:31PM +0800, Ming Lei wrote: >>> Hi Jens, >>> >>> This patchset avoids to allocate driver tag beforehand for flush rq >>> in case of I/O scheduler, then flush rq isn't treated

Re: [PATCH 2/2 v4] typec: tcpm: Only request matching pdos

2017-11-04 Thread Badhri Jagan Sridharan
Please disregard v4. Going to send another version again. On Sat, Nov 4, 2017 at 11:59 AM, Badhri Jagan Sridharan wrote: > At present, TCPM code assumes that local device supports > variable/batt pdos and always selects the pdo with highest > possible power within the board

Re: [PATCH 1/2] drivers: hwmon: Add W83773G driver

2017-11-04 Thread Guenter Roeck
On 11/01/2017 11:33 PM, Lei YU wrote: Nuvoton W83773G is a hardware monitor IC providing one local temperature and two remote temperature sensors. I agree that a separate driver for this chip make sense. Some work to do, though. This is only an initial review; later versions will probably

Re: [PATCH 07/12] hwrng: bcm2835-rng: Manage an optional clock

2017-11-04 Thread Andrew Lunn
Hi Florian > > >> +/* Clock is optional on most platforms */ > > >> +priv->clk = devm_clk_get(dev, NULL); > > >> +if (IS_ERR(priv->clk)) > > >> +priv->clk = NULL; > > > > > > at least in case of EPROBE_DEFERED this isn't the expected behavior. > > > Maybe

[PATCH] rtlwifi: remove redundant initialization to cfg_cmd

2017-11-04 Thread Colin King
From: Colin Ian King cfg_cmd is initialized to zero and this value is never read, instead it is over-written in the start of a do-while loop. Remove the redundant initialization. Cleans up clang warning: drivers/net/wireless/realtek/rtlwifi/core.c:1750:22: warning:

Re: [PATCH 3/5] dt-bindings: arm: Document Socionext MB86S71 and Fujitsu F-Cue

2017-11-04 Thread Andreas Färber
Am 04.11.2017 um 23:39 schrieb Ard Biesheuvel: > On 4 November 2017 at 15:30, Andreas Färber wrote: >> Am 04.11.2017 um 22:57 schrieb Ard Biesheuvel: >>> On 4 November 2017 at 13:44, Andreas Färber wrote: Hi everyone, The non-building clk driver

[PATCH v6 9/9] i2c: rcar: skip DMA if buffer is not safe

2017-11-04 Thread Wolfram Sang
This HW is prone to races, so it needs to setup new messages in irq context. That means we can't alloc bounce buffers if a message buffer is not DMA safe. So, in that case, simply fall back to PIO. Reviewed-by: Jonathan Cameron Signed-off-by: Wolfram Sang

[PATCH v6 6/9] i2c: smbus: use DMA safe buffers for emulated SMBus transactions

2017-11-04 Thread Wolfram Sang
For all block commands, try to allocate a DMA safe buffer and mark it accordingly. Only use the stack, if the buffers cannot be allocated. Signed-off-by: Wolfram Sang --- drivers/i2c/i2c-core-smbus.c | 45 ++-- 1 file

[PATCH v6 7/9] i2c: add docs to clarify DMA handling

2017-11-04 Thread Wolfram Sang
Reviewed-by: Jonathan Cameron Reviewed-by: Mauro Carvalho Chehab Signed-off-by: Wolfram Sang --- Documentation/i2c/DMA-considerations | 67 1 file changed, 67

[PATCH v6 1/9] i2c: add a message flag for DMA safe buffers

2017-11-04 Thread Wolfram Sang
I2C has no requirement that the buffer of a message needs to be DMA safe. In case it is, it can now be flagged, so drivers wishing to do DMA can use the buffer directly. Reviewed-by: Jonathan Cameron Signed-off-by: Wolfram Sang ---

[PATCH v6 0/9] i2c: document DMA handling and add helpers for it

2017-11-04 Thread Wolfram Sang
So, after revisiting old mail threads, taking part in a similar discussion on the USB list, and implementing a not-convincing solution before, here is what I cooked up to document and ease DMA handling for I2C within Linux. Please have a look at the documentation introduced in patch 7 for details.

[PATCH v6 8/9] i2c: sh_mobile: use core helper to decide when to use DMA

2017-11-04 Thread Wolfram Sang
This ensures that we fall back to PIO if the message length is too small for DMA being useful. Otherwise, we use DMA. A bounce buffer might be applied by the helper if the original message buffer is not DMA safe. Reviewed-by: Jonathan Cameron Signed-off-by: Wolfram

Re: [PATCH] scsi: require CAP_SYS_ADMIN to write to procfs interface

2017-11-04 Thread Aleksa Sarai
Previously, the only capability effectively required to operate on the /proc/scsi interface was CAP_DAC_OVERRIDE (or for some other files, having an fsuid of GLOBAL_ROOT_UID was enough). This means that semi-privileged processes could interfere with core components of a system (such as causing a

Re: [PATCH] rtlwifi: remove redundant initialization to cfg_cmd

2017-11-04 Thread Larry Finger
On 11/04/2017 02:37 PM, Colin King wrote: From: Colin Ian King cfg_cmd is initialized to zero and this value is never read, instead it is over-written in the start of a do-while loop. Remove the redundant initialization. Cleans up clang warning:

Re: T20 Cpuidle Freeze

2017-11-04 Thread Marcel Ziswiler
On Fri, 2017-11-03 at 21:52 +0300, Dmitry Osipenko wrote: > I haven't seen any problems with the cpuidle on next and 4.14-rc7 > works fine. > > # cat /sys/devices/system/cpu/cpu[0-1]/cpuidle/state[0-1]/usage > 162283 > 32905 > 254669 > 32905 > > # cat

Re: [PATCH v2] scsi: require CAP_SYS_ADMIN to write to procfs interface

2017-11-04 Thread Randy Dunlap
On 11/04/2017 01:26 PM, Aleksa Sarai wrote: > Previously, the only capability effectively required to operate on the > /proc/scsi interface was CAP_DAC_OVERRIDE (or for some other files, > having an fsuid of GLOBAL_ROOT_UID was enough). This means that > semi-privileged processes could interfere

Re: [PATCH 2/2] typec: tcpm: Only request matching pdos

2017-11-04 Thread Badhri Jagan Sridharan
On Thu, Nov 2, 2017 at 4:00 AM, Heikki Krogerus wrote: > Hi, > > +Dan and Guenter > > I'm sorry for the late reply. These slipped under my radar. I do > have a one more proposal below, and a few nits.. > > On Wed, Oct 18, 2017 at 01:22:48PM -0700, Badhri Jagan

[PATCH] scsi: require CAP_SYS_ADMIN to write to procfs interface

2017-11-04 Thread Aleksa Sarai
Previously, the only capability effectively required to operate on the /proc/scsi interface was CAP_DAC_OVERRIDE (or for some other files, having an fsuid of GLOBAL_ROOT_UID was enough). This means that semi-privileged processes could interfere with core components of a system (such as causing a

[PATCH 1/2 v4] typec: tcpm: Validate source and sink caps

2017-11-04 Thread Badhri Jagan Sridharan
The source and sink caps should follow the following rules. This patch validates whether the src_caps/snk_caps adheres to it. 6.4.1 Capabilities Message A Capabilities message (Source Capabilities message or Sink Capabilities message) shall have at least one Power Data Object for vSafe5V. The

[PATCH 2/2 v4] typec: tcpm: Only request matching pdos

2017-11-04 Thread Badhri Jagan Sridharan
At present, TCPM code assumes that local device supports variable/batt pdos and always selects the pdo with highest possible power within the board limit. This assumption might not hold good for all devices. To overcome this, this patch makes TCPM only accept a source_pdo when there is a matching

Re: [PATCH 1/2 v4] typec: tcpm: Validate source and sink caps

2017-11-04 Thread Badhri Jagan Sridharan
Please disregard v4. Going to send another version again. On Sat, Nov 4, 2017 at 11:59 AM, Badhri Jagan Sridharan wrote: > The source and sink caps should follow the following rules. > This patch validates whether the src_caps/snk_caps adheres > to it. > > 6.4.1 Capabilities

[PATCH 2/2 v5] typec: tcpm: Only request matching pdos

2017-11-04 Thread Badhri Jagan Sridharan
At present, TCPM code assumes that local device supports variable/batt pdos and always selects the pdo with highest possible power within the board limit. This assumption might not hold good for all devices. To overcome this, this patch makes TCPM only accept a source_pdo when there is a matching

[PATCH 1/2 v5] typec: tcpm: Validate source and sink caps

2017-11-04 Thread Badhri Jagan Sridharan
The source and sink caps should follow the following rules. This patch validates whether the src_caps/snk_caps adheres to it. 6.4.1 Capabilities Message A Capabilities message (Source Capabilities message or Sink Capabilities message) shall have at least one Power Data Object for vSafe5V. The

Re: [PATCH 07/12] hwrng: bcm2835-rng: Manage an optional clock

2017-11-04 Thread Russell King - ARM Linux
On Sat, Nov 04, 2017 at 08:37:31PM +0100, Andrew Lunn wrote: > Hi Florian > > > > >> + /* Clock is optional on most platforms */ > > > >> + priv->clk = devm_clk_get(dev, NULL); > > > >> + if (IS_ERR(priv->clk)) > > > >> + priv->clk = NULL; > > > > > > > > at least in

[PATCH] USB: core: Improve unlocking of a mutex in two functions

2017-11-04 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 4 Nov 2017 21:00:46 +0100 * Add jump targets so that a call of the function "mutex_unlock" is stored only twice in these function implementations. * Replace five calls by goto statements. This issue was detected by using the

Re: [PATCH 07/12] hwrng: bcm2835-rng: Manage an optional clock

2017-11-04 Thread Andrew Lunn
> The clk API outside of DT doesn't have knowledge of when it's "complete" > to be able to determine whether the clock is not present or temporarily > missing. I've already NAK'd this suggestion. Hi Russell O.K, yes, makes sense. We do have of_clk_get_by_name() and of_clk_get(). Would optional

[PATCH v6 2/9] i2c: add helpers to ease DMA handling

2017-11-04 Thread Wolfram Sang
One helper checks if DMA is suitable and optionally creates a bounce buffer, if not. The other function returns the bounce buffer and makes sure the data is properly copied back to the message. Reviewed-by: Jonathan Cameron Signed-off-by: Wolfram Sang

[PATCH v6 4/9] i2c: refactor i2c_master_{send_recv}

2017-11-04 Thread Wolfram Sang
Those two functions are very similar, the only differences are that one needs the I2C_M_RD flag for its message while the other one needs the buffer casted to drop the const. Introduce a generic helper which allows to specify the flags (also needed later for DMA safe variants of these calls) and

Re: [PATCH] scsi: require CAP_SYS_ADMIN to write to procfs interface

2017-11-04 Thread Randy Dunlap
On 11/04/2017 11:59 AM, Aleksa Sarai wrote: > Previously, the only capability effectively required to operate on the > /proc/scsi interface was CAP_DAC_OVERRIDE (or for some other files, > having an fsuid of GLOBAL_ROOT_UID was enough). This means that > semi-privileged processes could interfere

[PATCH v6 3/9] i2c: dev: mark RDWR buffers as DMA_SAFE

2017-11-04 Thread Wolfram Sang
Reviewed-by: Jonathan Cameron Signed-off-by: Wolfram Sang --- drivers/i2c/i2c-dev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c index 6f638bbc922db4..bbc7aadb4c899d 100644 ---

[PATCH v6 5/9] i2c: add i2c_master_{send|recv}_dmasafe

2017-11-04 Thread Wolfram Sang
Use the new helper to create variants of i2c_master_{send|recv} which mark their buffers as DMA safe. Signed-off-by: Wolfram Sang --- include/linux/i2c.h | 31 +++ 1 file changed, 31 insertions(+) diff --git a/include/linux/i2c.h

[PATCH v2] scsi: require CAP_SYS_ADMIN to write to procfs interface

2017-11-04 Thread Aleksa Sarai
Previously, the only capability effectively required to operate on the /proc/scsi interface was CAP_DAC_OVERRIDE (or for some other files, having an fsuid of GLOBAL_ROOT_UID was enough). This means that semi-privileged processes could interfere with core components of a system (such as causing a

Re: [PATCH 3/5] dt-bindings: arm: Document Socionext MB86S71 and Fujitsu F-Cue

2017-11-04 Thread Ard Biesheuvel
On 4 November 2017 at 20:06, Andreas Färber wrote: > Am 04.11.2017 um 23:39 schrieb Ard Biesheuvel: >> On 4 November 2017 at 15:30, Andreas Färber wrote: >>> Am 04.11.2017 um 22:57 schrieb Ard Biesheuvel: On 4 November 2017 at 13:44, Andreas Färber

Re: [PATCH 04/15] brd: remove dax support

2017-11-04 Thread Jens Axboe
On 10/31/2017 05:21 PM, Dan Williams wrote: > DAX support in brd is awkward because its backing page frames are > distinct from the ones provided by pmem, dcssblk, or axonram. We need > pfn_t_devmap() entries to fully support DAX, and the limited DAX support > for pfn_t_special() page frames is

Re: [PATCH v2 0/2] pinctrl: Allow indicating loss of state across suspend/resume

2017-11-04 Thread Florian Fainelli
On 11/04/2017 05:25 AM, Rafael J. Wysocki wrote: > On Friday, November 3, 2017 6:33:53 PM CET Tony Lindgren wrote: >> * Florian Fainelli [171103 17:04]: >>> On 11/03/2017 09:11 AM, Tony Lindgren wrote: >>> The pinctrl provider is losing its state, hence these two patches.

Re: [PATCH] KVM: VMX: replace move_msr_up with swap macro

2017-11-04 Thread Paolo Bonzini
- Original Message - > From: "Gustavo A. R. Silva" > To: "Paolo Bonzini" , "Radim Krčmář" > , "Thomas Gleixner" > , "Ingo Molnar" , "H. Peter Anvin" > ,

Re: WARNING in tracepoint_probe_register_prio

2017-11-04 Thread Jens Axboe
On 11/04/2017 11:26 AM, Jens Axboe wrote: > On 10/31/2017 05:14 PM, Steven Rostedt wrote: >> On Tue, 31 Oct 2017 16:30:41 -0600 >> Jens Axboe wrote: >> >>> This code dates back to: >>> >>> commit c71a896154119f4ca9e89d6078f5f63ad60ef199 >>> Author: Arnaldo Carvalho de Melo

Re: [PATCH 07/12] hwrng: bcm2835-rng: Manage an optional clock

2017-11-04 Thread Florian Fainelli
Hi Stefan, On 11/04/2017 06:50 AM, Stefan Wahren wrote: > Hi Florian, > >> Florian Fainelli hat am 2. November 2017 um 02:04 >> geschrieben: >> >> >> One of the last steps before bcm63xx-rng can be eliminated is to manage >> a clock during hwrng::init and hwrng::cleanup,

Re: [PATCH 07/12] hwrng: bcm2835-rng: Manage an optional clock

2017-11-04 Thread Stefan Wahren
> Florian Fainelli hat am 4. November 2017 um 18:59 > geschrieben: > > > Hi Stefan, > > On 11/04/2017 06:50 AM, Stefan Wahren wrote: > > Hi Florian, > > > >> Florian Fainelli hat am 2. November 2017 um 02:04 > >> geschrieben: > >> > >> > >> One

Re: [PATCH] clk: meson: gxbb: fix wrong clock for SARADC

2017-11-04 Thread Neil Armstrong
Hi Yixun, Le 04/11/2017 09:41, Yixun Lan a écrit : > > > On 11/04/17 02:17, Yixun Lan wrote: >> According to the datasheet, the clock gate bit for >> SARADC is bit[22] in Meson-GXBB/GXL series. >> >> Change-Id: Ic4fa58276d2a9ea273eef0a08541fc213ac5ac89 >> Signed-off-by: Yixun Lan

Re: [PATCH 2/2] staging: greybus/loopback: use ktime_get() for time intervals

2017-11-04 Thread Bryan O'Donoghue
On 02/11/17 14:32, Arnd Bergmann wrote: This driver is the only one using the deprecated timeval_to_ns() helper. Changing it from do_gettimeofday() to ktime_get() makes the code more efficient, more robust against concurrent settimeofday(), more accurate and lets us get rid of that helper in the

Re: [PATCH v10 1/5] serdev: Make .remove in struct serdev_device_driver optional

2017-11-04 Thread Sebastian Reichel
Hi Greg, On Sat, Nov 04, 2017 at 12:24:31PM +0100, Greg Kroah-Hartman wrote: > On Tue, Oct 31, 2017 at 09:36:52AM -0700, Andrey Smirnov wrote: > > Using devres infrastructure it is possible to write a serdev driver > > that doesn't have any code that needs to be called as a part of > > .remove.

[PATCH] media: uvcvideo: Make some structs const

2017-11-04 Thread Joe Perches
Move some data to text $ size drivers/media/usb/uvc/uvc_ctrl.o* textdata bss dec hex filename 343232364 0 366878f4f drivers/media/usb/uvc/uvc_ctrl.o.new 286598028 0 366878f4f drivers/media/usb/uvc/uvc_ctrl.o.old Signed-off-by: Joe Perches

[GIT PULL] Final KVM fixes for Linux 4.14 (rc8 or final)

2017-11-04 Thread Paolo Bonzini
Linus, The following changes since commit cc9085b6875323fd0c935ee7176583bb572821ee: Merge branch 'kvm-ppc-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc (2017-10-19 14:42:09 +0200) are available in the git repository at:

Re: WARNING in tracepoint_probe_register_prio

2017-11-04 Thread Jens Axboe
On 10/31/2017 05:14 PM, Steven Rostedt wrote: > On Tue, 31 Oct 2017 16:30:41 -0600 > Jens Axboe wrote: > >> This code dates back to: >> >> commit c71a896154119f4ca9e89d6078f5f63ad60ef199 >> Author: Arnaldo Carvalho de Melo >> Date: Fri Jan 23 12:06:27 2009

  1   2   3   4   5   >