Re: [PATCH] net: print proper warning on dst underflow

2019-09-26 Thread David Miller
From: "Jason A. Donenfeld" Date: Tue, 24 Sep 2019 11:09:37 +0200 > Proper warnings with stack traces make it much easier to figure out > what's doing the double free and create more meaningful bug reports from > users. > > Signed-off-by: Jason A. Donenfeld Applied, thanks.

Re: [PATCH] riscv: move flush_icache_range/user_range() after flush_icache_all()

2019-09-26 Thread Kefeng Wang
On 2019/9/26 14:52, Andreas Schwab wrote: > https://lore.kernel.org/linux-riscv/mvm7e9spggv@suse.de/ > > Andreas. > Hi Andreas, my change is wrong. For no SMP, lkdtm built ok because flush_icache_all() is defined as local_flush_icache_all() macro, but for SMP, the reason of build error

Re: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-26 Thread David Hildenbrand
On 26.09.19 03:34, Alastair D'Silva wrote: > From: Alastair D'Silva > > On PowerPC, the address ranges allocated to OpenCAPI LPC memory > are allocated from firmware. These address ranges may be higher > than what older kernels permit, as we increased the maximum > permissable address in commit 4

Re: [PATCH] hv_balloon: Add the support of hibernation

2019-09-26 Thread David Hildenbrand
On 25.09.19 22:03, Dexuan Cui wrote: >> From: linux-hyperv-ow...@vger.kernel.org >> [... snipped ...] >>> Anyhow, just some comments from my side :) I can see how Windows Server >>> worked around that issue right now by just XOR'ing both features. >>> >>> David / dhildenb >> >> Thanks for sharing

workqueue: PF_MEMALLOC task 14771(cc1plus) is flushing !WQ_MEM_RECLAIM events:gen6_pm_rps_work

2019-09-26 Thread Zdenek Sojka
Hello, I've hit the following dmesg with a 5.3.1 kernel; it looks similar to https://lkml.org/lkml/2019/8/28/754 , which should have been fixed as noted in https://lkml.org/lkml/2019/8/28/763 (if the patch is in the 5.3 release) [ 2680.302771] [ cut here ] [ 2680.302862]

Re: [PATCH 1/2] devfreq: Rename devfreq_update_status() to devfreq_update_stats() and viceversa

2019-09-26 Thread Ben Dooks
/ On 2019-09-25 19:43, Matthias Kaehlcke wrote: devfreq has two functions with very similar names, devfreq_update_status() and devfreq_update_stats(). _update_status() currently updates frequency transitions statistics, while _update_stats() retrieves the device 'status'. The function names are

Re: [PATCH v1] mm/memory_hotplug: Don't take the cpu_hotplug_lock

2019-09-26 Thread David Hildenbrand
On 25.09.19 22:32, Qian Cai wrote: > On Wed, 2019-09-25 at 21:48 +0200, David Hildenbrand wrote: >> On 25.09.19 20:20, Qian Cai wrote: >>> On Wed, 2019-09-25 at 19:48 +0200, Michal Hocko wrote: On Wed 25-09-19 12:01:02, Qian Cai wrote: > On Wed, 2019-09-25 at 09:02 +0200, David Hildenbrand

Re: [PATCH v1] mm/memory_hotplug: Don't take the cpu_hotplug_lock

2019-09-26 Thread Michal Hocko
On Wed 25-09-19 14:20:59, Qian Cai wrote: > On Wed, 2019-09-25 at 19:48 +0200, Michal Hocko wrote: > > On Wed 25-09-19 12:01:02, Qian Cai wrote: > > > On Wed, 2019-09-25 at 09:02 +0200, David Hildenbrand wrote: > > > > On 24.09.19 20:54, Qian Cai wrote: > > > > > On Tue, 2019-09-24 at 17:11 +0200,

Re: [PATCH V2 1/2] string: Add stracpy and stracpy_pad mechanisms

2019-09-26 Thread Rasmus Villemoes
On 26/09/2019 02.01, Stephen Kitt wrote: > Le 25/09/2019 23:50, Andrew Morton a écrit : >> On Tue, 23 Jul 2019 06:51:36 -0700 Joe Perches wrote: >> >>> Several uses of strlcpy and strscpy have had defects because the >>> last argument of each function is misused or typoed. >>> >>> Add macro mechan

[PATCH] staging: rtl8188eu: fix HighestRate check in odm_ARFBRefresh_8188E()

2019-09-26 Thread Denis Efremov
It's incorrect to compare HighestRate with 0x0b twice in the following manner "if (HighestRate > 0x0b) ... else if (HighestRate > 0x0b) ...". The "else if" branch is constantly false. The second comparision should be with 0x03 according to the max_rate_idx in ODM_RAInfo_Init(). Cc: Larry Finger C

Re: [PATCH v2 3/3] platform/x86: intel_oaktrail: Use pr_warn instead of pr_warning

2019-09-26 Thread Andy Shevchenko
On Thu, Sep 26, 2019 at 9:09 AM Kefeng Wang wrote: > On 2019/9/26 13:48, Andy Shevchenko wrote: > > On Thu, Sep 26, 2019 at 4:29 AM Kefeng Wang > > wrote: > >> On 2019/9/25 23:04, Andy Shevchenko wrote: > >>> On Fri, Sep 20, 2019 at 1:55 PM Kefeng Wang > >>> wrote: > >>> You have to send to pr

Re: [PATCH v2] ipv6: do not free rt if FIB_LOOKUP_NOREF is set on suppress rule

2019-09-26 Thread David Miller
From: "Jason A. Donenfeld" Date: Tue, 24 Sep 2019 16:01:28 +0200 > Commit 7d9e5f422150 removed references from certain dsts, but accounting > for this never translated down into the fib6 suppression code. This bug > was triggered by WireGuard users who use wg-quick(8), which uses the > "suppress-

Re: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-26 Thread David Hildenbrand
On 26.09.19 09:12, David Hildenbrand wrote: > On 26.09.19 03:34, Alastair D'Silva wrote: >> From: Alastair D'Silva >> >> On PowerPC, the address ranges allocated to OpenCAPI LPC memory >> are allocated from firmware. These address ranges may be higher >> than what older kernels permit, as we incre

Re: [PATCH v1] mm/memory_hotplug: Don't take the cpu_hotplug_lock

2019-09-26 Thread Michal Hocko
On Thu 26-09-19 09:26:13, David Hildenbrand wrote: [...] > I'd like to hear what Michal thinks. If we do want the cpu hotplug lock, > we can at least restrict it to the call paths (e.g., online_pages()) > where the lock is really needed and document that. Completely agreed. Conflating cpu and memo

Re: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-26 Thread Oscar Salvador
On Thu, Sep 26, 2019 at 11:34:05AM +1000, Alastair D'Silva wrote: > From: Alastair D'Silva > @@ -291,6 +307,10 @@ int __ref __add_pages(int nid, unsigned long pfn, > unsigned long nr_pages, > unsigned long nr, start_sec, end_sec; > struct vmem_altmap *altmap = restrictions->altmap; >

[RESEND PATCH] ARM/hw_breakpoint: add ARMv8.1/ARMv8.2 debug architecutre versions support in enable_monitor_mode()

2019-09-26 Thread Candle Sun
From: Candle Sun When ARMv8.1/ARMv8.2 cores are used in AArch32 mode, arch_hw_breakpoint_init() in arch/arm/kernel/hw_breakpoint.c will be used. >From ARMv8 specification, different debug architecture versions defined: * 0110 ARMv8, v8 Debug architecture. * 0111 ARMv8.1, v8 Debug architecture, w

Re: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-26 Thread David Hildenbrand
On 26.09.19 09:40, Oscar Salvador wrote: > On Thu, Sep 26, 2019 at 11:34:05AM +1000, Alastair D'Silva wrote: >> From: Alastair D'Silva >> @@ -291,6 +307,10 @@ int __ref __add_pages(int nid, unsigned long pfn, >> unsigned long nr_pages, >> unsigned long nr, start_sec, end_sec; >> struct

Re: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-26 Thread Michal Hocko
On Thu 26-09-19 09:12:50, David Hildenbrand wrote: > On 26.09.19 03:34, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > On PowerPC, the address ranges allocated to OpenCAPI LPC memory > > are allocated from firmware. These address ranges may be higher > > than what older kernels permit

Re: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-26 Thread Michal Hocko
On Thu 26-09-19 11:34:05, Alastair D'Silva wrote: > From: Alastair D'Silva > > On PowerPC, the address ranges allocated to OpenCAPI LPC memory > are allocated from firmware. These address ranges may be higher > than what older kernels permit, as we increased the maximum > permissable address in c

[PATCH] scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry()

2019-09-26 Thread Daniel Wagner
Commit 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not called from the completion path") introduced the WARN_ON_ONCE in qla2x00_status_cont_entry(). The assumption was that there is only one status continuations element. According to the firmware documentation it is possible that multip

Re: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-26 Thread David Hildenbrand
On 26.09.19 09:43, Michal Hocko wrote: > On Thu 26-09-19 09:12:50, David Hildenbrand wrote: >> On 26.09.19 03:34, Alastair D'Silva wrote: >>> From: Alastair D'Silva >>> >>> On PowerPC, the address ranges allocated to OpenCAPI LPC memory >>> are allocated from firmware. These address ranges may be

Re: [PATCH] arm64: Allow disabling of the compat vDSO

2019-09-26 Thread Catalin Marinas
On Thu, Sep 26, 2019 at 01:06:50AM +0100, Vincenzo Frascino wrote: > On 9/25/19 6:08 PM, Catalin Marinas wrote: > > On Wed, Sep 25, 2019 at 09:53:16AM -0700, Nick Desaulniers wrote: > >> On Wed, Sep 25, 2019 at 6:09 AM Catalin Marinas > >> wrote: > >>> Suggestions for future improvements of the c

Re: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-26 Thread Michal Hocko
On Thu 26-09-19 09:40:05, Oscar Salvador wrote: > On Thu, Sep 26, 2019 at 11:34:05AM +1000, Alastair D'Silva wrote: > > From: Alastair D'Silva > > @@ -291,6 +307,10 @@ int __ref __add_pages(int nid, unsigned long pfn, > > unsigned long nr_pages, > > unsigned long nr, start_sec, end_sec; > >

Re: [PATCH net v2] vsock: Fix a lockdep warning in __vsock_release()

2019-09-26 Thread Stefano Garzarella
Hi Dexuan, On Thu, Sep 26, 2019 at 01:11:27AM +, Dexuan Cui wrote: > Lockdep is unhappy if two locks from the same class are held. > > Fix the below warning for hyperv and virtio sockets (vmci socket code > doesn't have the issue) by using lock_sock_nested() when __vsock_release() > is called

Re: [PATCH v2 3/3] platform/x86: intel_oaktrail: Use pr_warn instead of pr_warning

2019-09-26 Thread Kefeng Wang
On 2019/9/26 15:32, Andy Shevchenko wrote: > On Thu, Sep 26, 2019 at 9:09 AM Kefeng Wang > wrote: >> On 2019/9/26 13:48, Andy Shevchenko wrote: >>> On Thu, Sep 26, 2019 at 4:29 AM Kefeng Wang >>> wrote: On 2019/9/25 23:04, Andy Shevchenko wrote: > On Fri, Sep 20, 2019 at 1:55 PM Kef

Re: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-26 Thread Oscar Salvador
On Thu, Sep 26, 2019 at 11:34:05AM +1000, Alastair D'Silva wrote: > From: Alastair D'Silva > > On PowerPC, the address ranges allocated to OpenCAPI LPC memory > are allocated from firmware. These address ranges may be higher > than what older kernels permit, as we increased the maximum > permissa

Re: WARN_ON_ONCE in qla2x00_status_cont_entry

2019-09-26 Thread Daniel Wagner
On Wed, Sep 25, 2019 at 06:33:35PM -0700, Bart Van Assche wrote: > On 2019-09-25 05:39, Daniel Wagner wrote: > > So I after starring on the code I am not sure if the WARN_ON_ONCE is > > correct. It assumes that after processing one status continuation, > > there is no more work. Though it looks lik

Re: [RFC PATCH] x86/doc/boot_protocol: Correct the description of "reloc"

2019-09-26 Thread Cao jin
On 9/26/19 2:01 PM, Ingo Molnar wrote: > * Cao jin wrote: > >> The fields marked with (reloc) actually are not dedicated for writing, >> but communicating info for relocatable kernel with boot loaders. For >> example: >> >> >> Field name: pref_address >>

Re: [PATCH v3] dt-bindings: at24: convert the binding document to yaml

2019-09-26 Thread Bartosz Golaszewski
śr., 25 wrz 2019 o 22:38 Rob Herring napisał(a): > > From: Bartosz Golaszewski > > Convert the binding document for at24 EEPROMs from txt to yaml. The > compatible property uses a regex pattern to address all the possible > combinations of "vendor,model" strings. > > Signed-off-by: Bartosz Golasz

Re: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-09-26 Thread Marco Felsch
Hi, On 19-09-25 18:07, Anson Huang wrote: > The SCU firmware does NOT always have return value stored in message > header's function element even the API has response data, those special > APIs are defined as void function in SCU firmware, so they should be > treated as return success always. > >

Re: [PATCH 1/2] spi: Add call to spi_slave_abort() function when spidev driver is released

2019-09-26 Thread Lukasz Majewski
Hi Geert, > Hi Lukasz, > > On Thu, Sep 26, 2019 at 3:33 AM Lukasz Majewski wrote: > > This change is necessary for spidev devices (e.g. /dev/spidev3.0) > > working in the slave mode (like NXP's dspi driver for Vybrid SoC). > > > > When SPI HW works in this mode - the master is responsible for >

Re: [PATCH] udf: prevent memory leak in udf_new_inode

2019-09-26 Thread Jan Kara
On Wed 25-09-19 23:24:08, Al Viro wrote: > On Wed, Sep 25, 2019 at 04:39:03PM -0500, Navid Emamdoost wrote: > > In udf_new_inode if either udf_new_block or insert_inode_locked fials > > the allocated memory for iinfo->i_ext.i_data should be released. > > "... because of such-and-such reasons" part

Re: [PATCH] async: Let kfree() out of the critical area of the lock

2019-09-26 Thread Yunfeng Ye
On 2019/9/25 23:20, Alexander Duyck wrote: > On Wed, 2019-09-25 at 20:52 +0800, Yunfeng Ye wrote: >> It's not necessary to put kfree() in the critical area of the lock, so >> let it out. >> >> Signed-off-by: Yunfeng Ye >> --- >> kernel/async.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3

RE: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-09-26 Thread Anson Huang
Hi, Marco > On 19-09-25 18:07, Anson Huang wrote: > > The SCU firmware does NOT always have return value stored in message > > header's function element even the API has response data, those > > special APIs are defined as void function in SCU firmware, so they > > should be treated as return succ

Re: [PATCH 1/4] arm64: vdso32: Introduce COMPAT_CC_IS_GCC

2019-09-26 Thread Catalin Marinas
On Thu, Sep 26, 2019 at 07:03:50AM +0100, Vincenzo Frascino wrote: > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 37c610963eee..afe8c948b493 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -110,7 +110,7 @@ config ARM64 > select GENERIC_STRNLEN_USER > se

Re: [PATCH] ACPICA: make acpi_load_table() return table index

2019-09-26 Thread Shevchenko, Andriy
On Wed, Sep 25, 2019 at 09:13:34PM +0300, Schmauss, Erik wrote: > > -Original Message- > > From: Ferry Toth > > Sent: Thursday, September 12, 2019 12:37 PM > > To: Moore, Robert ; Nikolaus Voss > > ; Shevchenko, Andriy > > ; Schmauss, Erik ; > > Rafael J. Wysocki > > Cc: Len Brown ; Jacek

Re: [PATCH 2/5] dt-bindings: mfd: da9062: add regulator voltage selection documentation

2019-09-26 Thread Marco Felsch
On 19-09-25 16:18, Adam Thomson wrote: > On 25 September 2019 16:52, Marco Felsch wrote: > > > Hi Adam, > > > > On 19-09-24 09:23, Adam Thomson wrote: > > > On 17 September 2019 13:43, Marco Felsch wrote: > > > > > > > Add the documentation which describe the voltage selection gpio support. > > >

[PATCH] net: phy: micrel: add Asym Pause workaround for KSZ9021

2019-09-26 Thread Hans Andersson
From: Hans Andersson The Micrel KSZ9031 PHY may fail to establish a link when the Asymmetric Pause capability is set. This issue is described in a Silicon Errata (DS8691D or DS8692D), which advises to always disable the capability. Micrel KSZ9021 has no errata, but has the same issue wit

Hello

2019-09-26 Thread Edith Brown
-- Hello dear how are you? my name is Edith Brown i am a U.S military woman is my pleasure meeting you here best regards

Re: [PATCH v2] platform/x86: dell-laptop: fix broken kbd backlight on Inspiron 10xx

2019-09-26 Thread Pali Rohár
On Wednesday 25 September 2019 18:06:40 Andy Shevchenko wrote: > On Wed, Sep 25, 2019 at 12:48 PM Pacien TRAN-GIRARD > wrote: > > > > This patch adds a quirk disabling keyboard backlight support for the > > Dell Inspiron 1012 and 1018. > > > > Those models wrongly report supporting keyboard backli

[v8 0/2] mtd: rawnand: Add Cadence NAND controller driver

2019-09-26 Thread Piotr Sroka
Driver for Cadence HPNFC NAND flash controller. HW DMA interface Page write and page read operations are executed in Command DMA mode. Commands are defined by DMA descriptors. In CDMA mode controller own DMA engine is used (Master DMA mode). Other operations defined by nand_op_instr are executed i

[PATCH] iio: imu: adis16480: clean up a condition

2019-09-26 Thread Dan Carpenter
The "t" variable is unsigned so it can't be less than zero. We really are just trying to prevent divide by zero bugs so just checking against zero is sufficient. Signed-off-by: Dan Carpenter --- drivers/iio/imu/adis16480.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv

[v8 2/2] dt-bindings: mtd: Add Cadence NAND controller driver

2019-09-26 Thread Piotr Sroka
Document the bindings used by Cadence NAND controller driver Signed-off-by: Piotr Sroka Reviewed-by: Rob Herring --- Changes for v8: - none Changes for v7: - none Changes for v6: - add documentation for address-cells and size-cells - remove not needed space - put myself as maintainer of the Cade

Re: [PATCH] sched/vtime: Fix guest/system mis-accounting on task switch

2019-09-26 Thread Peter Zijlstra
On Wed, Sep 25, 2019 at 11:42:42PM +0200, Frederic Weisbecker wrote: > vtime_account_system() assumes that the target task to account cputime > to is always the current task. This is most often true indeed except on > task switch where we call: > > vtime_common_task_switch(prev) >

[PATCH] ns2: Fix off by one bugs in ns2_pinmux_enable()

2019-09-26 Thread Dan Carpenter
The pinctrl->functions[] array has pinctrl->num_functions elements and the pinctrl->groups[] array is the same way. These are set in ns2_pinmux_probe(). So the > comparisons should be >= so that we don't read one element beyond the end of the array. Fixes: b5aa1006e4a9 ("pinctrl: ns2: add pinmux

[v8 1/2] mtd: rawnand: Add new Cadence NAND driver to MTD subsystem

2019-09-26 Thread Piotr Sroka
Add new Cadence NAND driver to MTD subsystem Signed-off-by: Piotr Sroka Reported-by: kbuild test robot Reported-by: Julia Lawall --- Changes for v8: - fix compilation waring in cadence_nand_attach_chip function - change reallocating DMA common buffer to be done after all chips are attached. C

Re: [PATCH] soc: renesas: rcar-sysc: fix memory leak in rcar_sysc_pd_init

2019-09-26 Thread Simon Horman
Ni Navid, thanks for your patch. On Wed, Sep 25, 2019 at 04:03:53PM -0500, Navid Emamdoost wrote: > In rcar_sysc_pd_init when looping over info->areas errors may happen but > the error handling path does not clean up the intermediate allocated > memories. > > This patch changes the error handlin

Re: [PATCH 2/4] arm64: vdso32: Detect binutils support for dmb ishld

2019-09-26 Thread Catalin Marinas
On Thu, Sep 26, 2019 at 07:03:51AM +0100, Vincenzo Frascino wrote: > diff --git a/arch/arm64/include/asm/vdso/compat_barrier.h > b/arch/arm64/include/asm/vdso/compat_barrier.h > index fb60a88b5ed4..3fd8fd6d8fc2 100644 > --- a/arch/arm64/include/asm/vdso/compat_barrier.h > +++ b/arch/arm64/include/

Re: [PATCH 3/4] arm64: vdso32: Fix compilation warning

2019-09-26 Thread Catalin Marinas
On Thu, Sep 26, 2019 at 07:03:52AM +0100, Vincenzo Frascino wrote: > diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h > index b61b50bf68b1..b1c8c43234c5 100644 > --- a/arch/arm64/include/asm/memory.h > +++ b/arch/arm64/include/asm/memory.h > @@ -228,11 +228,16 @@ stati

[PATCH] quota: avoid increasing DQST_LOOKUPS when iterating over dirty/inuse list

2019-09-26 Thread Chengguang Xu
It is meaningless to increase DQST_LOOKUPS number while iterating over dirty/inuse list, so just avoid it. Signed-off-by: Chengguang Xu --- fs/quota/dquot.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c index 6e826b454082..00a3c6df2ea3 100644 --- a/fs/q

Re: [PATCH] vhost: introduce mdev based hardware backend

2019-09-26 Thread Michael S. Tsirkin
On Thu, Sep 26, 2019 at 12:54:27PM +0800, Tiwei Bie wrote: > This patch introduces a mdev based hardware vhost backend. > This backend is built on top of the same abstraction used > in virtio-mdev and provides a generic vhost interface for > userspace to accelerate the virtio devices in guest. > >

Re: [PATCH 4/4] arm64: Remove gettimeofday.S

2019-09-26 Thread Catalin Marinas
On Thu, Sep 26, 2019 at 07:03:53AM +0100, Vincenzo Frascino wrote: > gettimeofday.S was originally removed with the introduction of the > support for Unified vDSOs in arm64 and replaced with the C > implementation. > > The file seems again present in the repository due to a side effect of > rebase

Re: [PATCH V2 1/2] string: Add stracpy and stracpy_pad mechanisms

2019-09-26 Thread Joe Perches
On Wed, 2019-09-25 at 14:50 -0700, Andrew Morton wrote: > On Tue, 23 Jul 2019 06:51:36 -0700 Joe Perches wrote: > > > Several uses of strlcpy and strscpy have had defects because the > > last argument of each function is misused or typoed. > > > > Add macro mechanisms to avoid this defect. > >

[PATCH] async: Using current_work() to implement current_is_async()

2019-09-26 Thread Yunfeng Ye
current_is_async() can be implemented using current_work(), it's better not to be aware of the workqueue's internal information. Signed-off-by: Yunfeng Ye --- kernel/async.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/async.c b/kernel/async.c index 1de270d..a

Re: [PULL REQUEST] i2c for 5.4

2019-09-26 Thread Wolfram Sang
Hi Linus, > > - new driver for ICY, an Amiga Zorro card :) > > Christ. Will that thing _never_ die? Well, a couple of happy users there... > I don't know what the proper mutt incantation is to make it join the > modern world, but I'm sure one exists, and then your emails would get > names right

Re: [PATCH] KVM: nVMX: cleanup and fix host 64-bit mode checks

2019-09-26 Thread Paolo Bonzini
On 26/09/19 01:55, Krish Sadhukhan wrote: > > > On 09/25/2019 09:47 AM, Jim Mattson wrote: >> On Wed, Sep 25, 2019 at 9:34 AM Paolo Bonzini >> wrote: >>> KVM was incorrectly checking vmcs12->host_ia32_efer even if the "load >>> IA32_EFER" exit control was reset.  Also, some checks were not using

[GIT PULL] add virtio-fs

2019-09-26 Thread Miklos Szeredi
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git tags/virtio-fs-5.4 [There's a trivial merge conflict under Documentation/] Virtio-fs allows exporting directory trees on the host and mounting them in guest(s). This isn't actually a new filesystem,

Re: [PATCH 0/7] add support for clocksource/clockevent DT selection

2019-09-26 Thread Claudiu.Beznea
On 25.09.2019 20:19, Daniel Lezcano wrote: > External E-Mail > > > Hi Claudiu, > > On 10/09/2019 15:47, Claudiu Beznea wrote: >> Hi, >> >> This series adds support to permit the selection of clocksource/clockevent >> via DT. > > Thanks for the proposal and taking care of making some progress

[PATCH] z3fold: claim page in the beginning of free

2019-09-26 Thread Vitaly Wool
There's a really hard to reproduce race in z3fold between z3fold_free() and z3fold_reclaim_page(). z3fold_reclaim_page() can claim the page after z3fold_free() has checked if the page was claimed and z3fold_free() will then schedule this page for compaction which may in turn lead to random page fau

Re: [PATCH v2] scripts: Move ipc/ to kernel/ipc/: don't check the ipc dir

2019-09-26 Thread Joe Perches
On Thu, 2019-09-26 at 09:26 +0800, Yunfeng Ye wrote: > After the commit 76128326f97c ("toplevel: Move ipc/ to kernel/ipc/: move > the files"), we met some error messages: > > ./scripts/checkpatch.pl: > "Must be run from the top-level dir. of a kernel tree" > > ./scripts/get_maintainer.pl: >

[PATCH 1/2] can: D_CAN: perform a sofware reset on open

2019-09-26 Thread Jeroen Hofstee
When the C_CAN interface is closed it is put in power down mode, but does not reset the error counters / state. So reset the D_CAN on open, so the reported state and the actual state match. According to [1], the C_CAN module doesn't have the software reset. [1] http://www.bosch-semiconductors.co

[PATCH 2/2] can: C_CAN: add bus recovery events

2019-09-26 Thread Jeroen Hofstee
While the state is update when the error counters increase and decrease, there is no event when the bus recovers and the error counters decrease again. So add that event as well. Change the state going downward to be ERROR_PASSIVE -> ERROR_WARNING -> ERROR_ACTIVE instead of directly to ERROR_ACTIV

Re: [PATCH V2 1/2] string: Add stracpy and stracpy_pad mechanisms

2019-09-26 Thread Rasmus Villemoes
On 26/09/2019 10.25, Stephen Kitt wrote: > Le 26/09/2019 09:29, Rasmus Villemoes a écrit : >> On 26/09/2019 02.01, Stephen Kitt wrote: >>> Le 25/09/2019 23:50, Andrew Morton a écrit : On Tue, 23 Jul 2019 06:51:36 -0700 Joe Perches wrote: >> >> Please don't. At least not for the cases whe

Re: [PATCH] compiler: enable CONFIG_OPTIMIZE_INLINING forcibly

2019-09-26 Thread Geert Uytterhoeven
Hi Yamada-san, On Fri, Aug 30, 2019 at 5:44 AM Masahiro Yamada wrote: > Commit 9012d011660e ("compiler: allow all arches to enable > CONFIG_OPTIMIZE_INLINING") allowed all architectures to enable > this option. A couple of build errors were reported by randconfig, > but all of them have been iron

Re: [PATCH v4 05/10] mm: Return faster for non-fatal signals in user mode faults

2019-09-26 Thread Peter Xu
On Tue, Sep 24, 2019 at 08:45:18AM -0700, Matthew Wilcox wrote: [...] > Oh, and while you're looking at the callers of handle_mm_fault(), a > lot of them don't check conditions in the right order. x86, at least, > handles FAULT_RETRY before handling FAULT_ERROR, which is clearly wrong. > > Kiri

Re: Regression in dbdda842fe96 ("printk: Add console owner and waiter logic to load balance console writes") [Was: Regression in fd5f7cde1b85 ("...")]

2019-09-26 Thread Petr Mladek
On Wed 2019-09-18 16:52:52, Sergey Senozhatsky wrote: > On (09/18/19 09:11), Uwe Kleine-König wrote: > > I rechecked and indeed fd5f7cde1b85's parent has the problem, too, so I > > did a mistake during my bisection :-| > > > > Redoing the bisection (a bit quicker this time) points to > > > > dbdd

[PATCH net] net: dsa: qca8k: Use up to 7 ports for all operations

2019-09-26 Thread Michal Vokáč
The QCA8K family supports up to 7 ports. So use the existing QCA8K_NUM_PORTS define to allocate the switch structure and limit all operations with the switch ports. This was not an issue until commit 0394a63acfe2 ("net: dsa: enable and disable all ports") disabled all unused ports. Since the unuse

Re: [PATCHv2] Bluetooth: trivial: tidy up printk message output from btrtl.

2019-09-26 Thread Rui Salvaterra
Hi, Marcel, On Thu, 26 Sep 2019 at 07:34, Marcel Holtmann wrote: > > Hi Rui, [patch snipped] > I have some similar patch in my tree. Can you check what is still missing and > send a new version. Thanks. Yeah, from a cursory look at your tree, it seems about the same as mine. I'll take a deepe

Re: [PATCH] compiler: enable CONFIG_OPTIMIZE_INLINING forcibly

2019-09-26 Thread Masahiro Yamada
Hi Geert, On Thu, Sep 26, 2019 at 5:54 PM Geert Uytterhoeven wrote: > > Hi Yamada-san, > > On Fri, Aug 30, 2019 at 5:44 AM Masahiro Yamada > wrote: > > Commit 9012d011660e ("compiler: allow all arches to enable > > CONFIG_OPTIMIZE_INLINING") allowed all architectures to enable > > this option. A

Re: [Patch V10 0/8] Tegra XUSB gadget driver support

2019-09-26 Thread Thierry Reding
On Mon, Sep 23, 2019 at 01:55:44PM +0530, Nagarjuna Kristam wrote: > Patches 1-3 are phy driver changes to add support for device > mode. > Patches 4-7 are changes related to XUSB device mode > controller driver. > Patch 8 is to enable drivers for XUDC support in defconfig > > Test Steps(USB 2.0):

Re: [PATCH V2 1/2] string: Add stracpy and stracpy_pad mechanisms

2019-09-26 Thread Stephen Kitt
Le 26/09/2019 09:29, Rasmus Villemoes a écrit : On 26/09/2019 02.01, Stephen Kitt wrote: Le 25/09/2019 23:50, Andrew Morton a écrit : On Tue, 23 Jul 2019 06:51:36 -0700 Joe Perches wrote: Several uses of strlcpy and strscpy have had defects because the last argument of each function is misu

Re: [RFC PATCH] xen/gntdev: Stop abusing DT of_dma_configure API

2019-09-26 Thread Nicolas Saenz Julienne
On Wed, 2019-09-25 at 16:50 -0500, Rob Herring wrote: > As the comment says, this isn't a DT based device. of_dma_configure() > is going to stop allowing a NULL DT node, so this needs to be fixed. > > Not sure exactly what setup besides arch_setup_dma_ops is needed... > > Cc: Robin Murphy > Cc:

Re: [PATCH 1/3] mm, page_owner: fix off-by-one error in __set_page_owner_handle()

2019-09-26 Thread Kirill A. Shutemov
On Wed, Sep 25, 2019 at 04:30:50PM +0200, Vlastimil Babka wrote: > As noted by Kirill, commit 7e2f2a0cd17c ("mm, page_owner: record page owner > for > each subpage") has introduced an off-by-one error in __set_page_owner_handle() > when looking up page_ext for subpages. As a result, the head page

[GIT PULL] tracing/probe: Fix same probe event argument matching

2019-09-26 Thread Steven Rostedt
Linus, Srikar Dronamraju fixed a bug in the new multi probe code. Please pull the latest trace-v5.4-2 tree, which can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git trace-v5.4-2 Tag SHA1: ba75d3b05b6e1e995b9c934f8e387c93e879c18b Head SHA1: f8d7ab2bded89

[PATCH] arch/x86/boot: use prefix map to avoid embedded paths

2019-09-26 Thread Ross Burton
From: Bruce Ashfield It was observed that the kernel embeds the path in the x86 boot artifacts. >From https://bugzilla.yoctoproject.org/show_bug.cgi?id=13458: [ If you turn on the buildpaths QA test, or try a reproducible build, you discover that the kernel image contains build paths.

Re: [PATCH v4 4/8] mm/memory_hotplug: Poison memmap in remove_pfn_range_from_zone()

2019-09-26 Thread Aneesh Kumar K.V
David Hildenbrand writes: @@ -134,11 +134,12 @@ void memunmap_pages(struct dev_pagemap *pgmap) > mem_hotplug_begin(); > + remove_pfn_range_from_zone(page_zone(pfn_to_page(pfn)), pfn, > +PHYS_PFN(resource_size(res))); That should be part of PATCH 3? >

Re: mtd raw nand denali.c broken for Intel/Altera Cyclone V

2019-09-26 Thread Tim Sander
Hi Am Mittwoch, 11. September 2019, 04:37:46 CEST schrieb Masahiro Yamada: > Hi Dinh, > > On Wed, Sep 11, 2019 at 12:22 AM Dinh Nguyen wrote: > > On 9/10/19 8:48 AM, Tim Sander wrote: > > > Hi > > > > > > I have noticed that my SPF records where not in place after moving the > > > server, so i

Re: [PATCH v4 2/8] mm/memory_hotplug: Don't access uninitialized memmaps in shrink_zone_span()

2019-09-26 Thread Aneesh Kumar K.V
David Hildenbrand writes: > Let's limit shrinking to !ZONE_DEVICE so we can fix the current code. We > should never try to touch the memmap of offline sections where we could > have uninitialized memmaps and could trigger BUGs when calling > page_to_nid() on poisoned pages. > > Stopping to shrink

Re: [PATCH v4 4/8] mm/memory_hotplug: Poison memmap in remove_pfn_range_from_zone()

2019-09-26 Thread David Hildenbrand
On 26.09.19 11:10, Aneesh Kumar K.V wrote: > David Hildenbrand writes: > @@ -134,11 +134,12 @@ void memunmap_pages(struct dev_pagemap *pgmap) > >> mem_hotplug_begin(); >> +remove_pfn_range_from_zone(page_zone(pfn_to_page(pfn)), pfn, >> + PHYS_PFN(resource

Re: [PATCH] sample/hw_breakpoint: avoid sample hw_breakpoint recursion for arm/arm64

2019-09-26 Thread Peter Zijlstra
On Mon, Sep 23, 2019 at 04:09:35PM +0800, wangxu wrote: > From: Wang Xu > > For x86/ppc, hw_breakpoint is triggered after the instruction is > executed. > > For arm/arm64, which is triggered before the instruction executed. > Arm/arm64 skips the instruction by using single step. But it only > su

Re: [PATCH 2/3] mm, debug, kasan: save and dump freeing stack trace for kasan

2019-09-26 Thread Kirill A. Shutemov
On Wed, Sep 25, 2019 at 04:30:51PM +0200, Vlastimil Babka wrote: > The commit 8974558f49a6 ("mm, page_owner, debug_pagealloc: save and dump > freeing stack trace") enhanced page_owner to also store freeing stack trace, > when debug_pagealloc is also enabled. KASAN would also like to do this [1] to

RE: [PATCH V9 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-09-26 Thread Peng Fan
Hi Andre, > Subject: Re: [PATCH V9 1/2] dt-bindings: mailbox: add binding doc for the > ARM SMC/HVC mailbox > [...] > > + supported identifier are passed from consumers, or listed in the > > + the arm,func-id > > ^ > This is now obsolete

[PATCH] csky: Bugfix add zero_fp fixup perf backtrace panic

2019-09-26 Thread guoren
From: Guo Ren We need set fp zero to let backtrace know the end. The patch fixup perf callchain panic problem, because backtrace didn't know what is the end of fp. Signed-off-by: Guo Ren Reported-by: Mao Han --- arch/csky/kernel/entry.S | 50 +++--- a

Re: [PATCH 2/3] soc: amlogic: Add support for Secure power domains controller

2019-09-26 Thread Jianxin Pan
Hi Kevin, Thanks for your review. Please see my comments below. On 2019/9/26 6:41, Kevin Hilman wrote: > Hi Jianxin, > > Jianxin Pan writes: > >> Add support for the Amlogic Secure Power controller. In A1/C1 series, power >> control registers are in secure domain, and should be accessed by sm

Re: [PATCH 3/3] mm, page_owner: rename flag indicating that page is allocated

2019-09-26 Thread Kirill A. Shutemov
On Wed, Sep 25, 2019 at 04:30:52PM +0200, Vlastimil Babka wrote: > Commit 37389167a281 ("mm, page_owner: keep owner info when freeing the page") > has introduced a flag PAGE_EXT_OWNER_ACTIVE to indicate that page is tracked > as > being allocated. Kirril suggested naming it PAGE_EXT_OWNER_ALLOCED

Re: [PATCH v4 1/8] dt-bindings: timer: Convert Exynos MCT bindings to json-schema

2019-09-26 Thread Krzysztof Kozlowski
On Wed, Sep 25, 2019 at 03:40:52PM +0200, Marek Szyprowski wrote: > Hi Krzysztof, > > On 23.09.2019 18:14, Krzysztof Kozlowski wrote: > > Convert Samsung Exynos Soc Multi Core Timer bindings to DT schema format > > using json-schema. > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > >

RE: [PATCH 1/2] regulator: da9062: Simplify da9062_buck_set_mode for BUCK_MODE_MANUAL case

2019-09-26 Thread Adam Thomson
On 26 September 2019 06:51, Axel Lin wrote: > The sleep flag bit decides the mode for BUCK_MODE_MANUAL case, simplify > the logic as the result is the same. > > Signed-off-by: Axel Lin This patch will need to be rebased on Marco's update titled: "regulator: da9062: fix suspend_enable/d

Re: [PATCH v5] dt-bindings: sound: Convert Samsung I2S controller to dt-schema

2019-09-26 Thread Krzysztof Kozlowski
On Wed, Sep 25, 2019 at 03:26:28PM +0200, Marek Szyprowski wrote: > From: Maciej Falkowski > > Convert Samsung I2S controller to newer dt-schema format. > > Signed-off-by: Maciej Falkowski > Signed-off-by: Marek Szyprowski > --- > v5: > - Removed '#clock-cells' property from required propertie

Re: [PATCH v4 2/8] mm/memory_hotplug: Don't access uninitialized memmaps in shrink_zone_span()

2019-09-26 Thread David Hildenbrand
On 26.09.19 11:12, Aneesh Kumar K.V wrote: > David Hildenbrand writes: > >> Let's limit shrinking to !ZONE_DEVICE so we can fix the current code. We >> should never try to touch the memmap of offline sections where we could >> have uninitialized memmaps and could trigger BUGs when calling >> page

RE: [PATCH 2/2] regulator: da9063: Simplify da9063_buck_set_mode for BUCK_MODE_MANUAL case

2019-09-26 Thread Adam Thomson
On 26 September 2019 06:51, Axel Lin wrote: > The sleep flag bit decides the mode for BUCK_MODE_MANUAL case, simplify > the logic as the result is the same. > > Signed-off-by: Axel Lin Reviewed-by: Adam Thomson > --- > drivers/regulator/da9063-regulator.c | 9 +++-- > 1 file changed, 3 i

RE: [PATCH v9 1/3] arm64: cpufeature: introduce helper cpu_has_hw_af()

2019-09-26 Thread Justin He (Arm Technology China)
Hi Catalin > -Original Message- > From: Catalin Marinas > Sent: 2019年9月25日 22:38 > To: Justin He (Arm Technology China) > Cc: Will Deacon ; Mark Rutland > ; James Morse ; Marc > Zyngier ; Matthew Wilcox ; Kirill A. > Shutemov ; linux-arm- > ker...@lists.infradead.org; linux-kernel@vger.k

Re: [PATCH] arch/x86/boot: use prefix map to avoid embedded paths

2019-09-26 Thread Borislav Petkov
Don't forget to CC: lkml and x...@kernel.org on x86 patches. On Thu, Sep 26, 2019 at 10:11:32AM +0100, Ross Burton wrote: > From: Bruce Ashfield > > It was observed that the kernel embeds the path in the x86 boot > artifacts. > > From https://bugzilla.yoctoproject.org/show_bug.cgi?id=13458: >

Re: [PATCH 3/3] mm, page_owner: rename flag indicating that page is allocated

2019-09-26 Thread Vlastimil Babka
On 9/26/19 11:18 AM, Kirill A. Shutemov wrote: > On Wed, Sep 25, 2019 at 04:30:52PM +0200, Vlastimil Babka wrote: >> Commit 37389167a281 ("mm, page_owner: keep owner info when freeing the page") >> has introduced a flag PAGE_EXT_OWNER_ACTIVE to indicate that page is tracked >> as >> being allocate

Re: [PATCH] compiler: enable CONFIG_OPTIMIZE_INLINING forcibly

2019-09-26 Thread Geert Uytterhoeven
Hi Yamada-san, On Thu, Sep 26, 2019 at 11:03 AM Masahiro Yamada wrote: > On Thu, Sep 26, 2019 at 5:54 PM Geert Uytterhoeven > wrote: > > On Fri, Aug 30, 2019 at 5:44 AM Masahiro Yamada > > wrote: > > > Commit 9012d011660e ("compiler: allow all arches to enable > > > CONFIG_OPTIMIZE_INLINING")

Re: [PATCH 2/3] mm, debug, kasan: save and dump freeing stack trace for kasan

2019-09-26 Thread Vlastimil Babka
On 9/26/19 11:16 AM, Kirill A. Shutemov wrote: > On Wed, Sep 25, 2019 at 04:30:51PM +0200, Vlastimil Babka wrote: >> The commit 8974558f49a6 ("mm, page_owner, debug_pagealloc: save and dump >> freeing stack trace") enhanced page_owner to also store freeing stack trace, >> when debug_pagealloc is al

Re: [PATCH v3 4/5] media: v4l2-ctrl: Add jpeg enc exif mode control

2019-09-26 Thread Hans Verkuil
On 9/24/19 9:43 AM, Xia Jiang wrote: > Add jpeg enc CID definition for exif mode control. > > Signed-off-by: Xia Jiang > --- > v3: new add patch for V4L2_CID_JPEG_ENABLE_EXIF > --- > Documentation/media/uapi/v4l/ext-ctrls-jpeg.rst | 10 ++ > drivers/media/v4l2-core/v4l2-ctrls.c

Re: [PATCH] PCI: mobiveil: Fix csr_read/write build issue

2019-09-26 Thread Andrew Murray
On Wed, Sep 25, 2019 at 10:21:21PM +0800, Kefeng Wang wrote: > The riscv has csr_read/write macro, see arch/riscv/include/asm/csr.h, > the same function naming will cause build error, rename them to > __csr_read/write to fix it. > > drivers/pci/controller/pcie-mobiveil.c:238:69: error: macro "csr_

[PATCH v2] arch/x86/boot: use prefix map to avoid embedded paths

2019-09-26 Thread Ross Burton
From: Bruce Ashfield It was observed that the kernel embeds the path in the x86 boot artifacts. >From https://bugzilla.yoctoproject.org/show_bug.cgi?id=13458: [ If you turn on the buildpaths QA test, or try a reproducible build, you discover that the kernel image contains build paths.

Re: [PATCH] ipc/sem: Fix race between to-be-woken task and waker

2019-09-26 Thread Peter Zijlstra
On Fri, Sep 20, 2019 at 11:54:02AM -0400, Waiman Long wrote: > While looking at a customr bug report about potential missed wakeup in > the system V semaphore code, I spot a potential problem. The fact that > semaphore waiter stays in TASK_RUNNING state while checking queue status > may lead to mi

[PATCH v5 00/16] mm: Page fault enhancements

2019-09-26 Thread Peter Xu
This is v5 of the series. As Matthew suggested, I split the previous patch "mm: Return faster for non-fatal signals in user mode faults" into a few smaller ones: 1. One patch to introduce fatal_signal_pending(), and use it in archs that can directly apply 2. A few more patches to let th

  1   2   3   4   5   6   7   >