Re: [PATCH v4 0/9] remoteproc: Add support for attaching with rproc

2020-06-04 Thread Arnaud POULIQUEN
Hi Mathieu, On 6/1/20 7:51 PM, Mathieu Poirier wrote: > This fourth iteration implements a solution that is fairly different from > what was proposed in V3 and earlier versions. Three aspects have been > revisited: > > 1) Only the scenario where the remoteproc core is attaching to the remote >

Re: [PATCH -tip] kcov: Make runtime functions noinstr-compatible

2020-06-04 Thread Marco Elver
On Thu, 4 Jun 2020 at 16:03, Andrey Konovalov wrote: > > On Thu, Jun 4, 2020 at 1:09 PM Peter Zijlstra wrote: > > > > On Thu, Jun 04, 2020 at 11:50:57AM +0200, Marco Elver wrote: > > > The KCOV runtime is very minimal, only updating a field in 'current', > > > and none of

Re: [RFC PATCH] gpio: uapi: v2 proposal

2020-06-04 Thread Kent Gibson
On Thu, Jun 04, 2020 at 02:06:31PM +0200, Bartosz Golaszewski wrote: > śr., 27 maj 2020 o 07:58 Linus Walleij napisał(a): > > > > On Mon, May 25, 2020 at 4:19 PM Kent Gibson wrote: > > > > > > > +struct gpioline_config { > > > > > + __u8 default_values[GPIOLINES_MAX]; > > > > > > > > So 32

NVIDIA GP107 (137000a1) - acr: failed to load firmware

2020-06-04 Thread Zeno Davatz
Hi With Kernel 5.7 I am still getting this, while booting: ~> uname -a Linux zenogentoo 5.7.0 #80 SMP Thu Jun 4 16:10:03 CEST 2020 x86_64 Intel(R) Core(TM) i7 CPU 960 @ 3.20GHz GenuineIntel GNU/Linux ~> dmesg |grep nouveau [0.762872] nouveau :05:00.0: NVIDIA GP107 (137000a1) [

Re: [PATCH 5/5] gcc-plugins/stackleak: Don't instrument vgettimeofday.c in arm64 VDSO

2020-06-04 Thread Jann Horn
On Thu, Jun 4, 2020 at 4:21 PM Alexander Popov wrote: > On 04.06.2020 17:14, Jann Horn wrote: > > Maybe at some point we should replace exclusions based on > > GCC_PLUGINS_CFLAGS and KASAN_SANITIZE and UBSAN_SANITIZE and > > OBJECT_FILES_NON_STANDARD and so on with something more generic... > >

Re: [PATCH 00/10] Remove uninitialized_var() macro

2020-06-04 Thread Kees Cook
On Thu, Jun 04, 2020 at 09:26:58AM +0200, Sedat Dilek wrote: > On Thu, Jun 4, 2020 at 5:33 AM Nathan Chancellor > wrote: > > > > On Wed, Jun 03, 2020 at 04:31:53PM -0700, Kees Cook wrote: > > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > > > (or can in the future), and

[PATCH] KVM: nVMX: Inject #GP when nested_vmx_get_vmptr() fails to read guest memory

2020-06-04 Thread Vitaly Kuznetsov
Syzbot reports the following issue: WARNING: CPU: 0 PID: 6819 at arch/x86/kvm/x86.c:618 kvm_inject_emulated_page_fault+0x210/0x290 arch/x86/kvm/x86.c:618 ... Call Trace: ... RIP: 0010:kvm_inject_emulated_page_fault+0x210/0x290 arch/x86/kvm/x86.c:618 ... nested_vmx_get_vmptr+0x1f9/0x2a0

Re: [PATCH 01/10] x86/mm/numa: Remove uninitialized_var() usage

2020-06-04 Thread Kees Cook
On Thu, Jun 04, 2020 at 09:58:07AM +0200, Thomas Gleixner wrote: > Kees Cook writes: > > -#ifdef NODE_NOT_IN_PAGE_FLAGS > > - pfn_align = node_map_pfn_alignment(); > > - if (pfn_align && pfn_align < PAGES_PER_SECTION) { > > - printk(KERN_WARNING "Node alignment %LuMB < min %LuMB, >

Re: [Nouveau] NVIDIA GP107 (137000a1) - acr: failed to load firmware

2020-06-04 Thread Ilia Mirkin
Starting with kernel 5.6, loading nouveau without firmware (for GPUs where it is required, such as yours) got broken. You are loading nouveau without firmware, so it fails. The firmware needs to be available to the kernel at the time of nouveau loading. Cheers, -ilia On Thu, Jun 4, 2020 at

Re: [PATCH -tip] kcov: Make runtime functions noinstr-compatible

2020-06-04 Thread Peter Zijlstra
On Thu, Jun 04, 2020 at 04:02:54PM +0200, Andrey Konovalov wrote: > > Now, luckily Joerg went and ripped out the vmalloc faults, let me check > > where those patches are... w00t, they're upstream in this merge window. > > Could you point me to those patches? git log

Re: [PATCH] mm/vmalloc: fix a typo in comment

2020-06-04 Thread David Hildenbrand
On 04.06.20 20:52, Jeongtae Park wrote: > There is a typo in comment, fix it. > "nother" -> "another" > > Signed-off-by: Jeongtae Park > Cc: Andrey Ryabinin > Cc: Christoph Hellwig > --- > mm/vmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c

[PATCH][next] RDMA/mlx5: remove duplicated assignment to resp.response_length

2020-06-04 Thread Colin King
From: Colin Ian King The assignment to resp.response_length is never read since it is being updated again on the next statement. The assignment is redundant so removed it. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/infiniband/hw/mlx5/qp.c | 2 -- 1 file

Re: linux-next: build failure on powerpc 8xx with 16k pages

2020-06-04 Thread Christophe Leroy
On 06/04/2020 12:00 PM, Peter Zijlstra wrote: On Thu, Jun 04, 2020 at 12:17:23PM +0100, Will Deacon wrote: Hi, [+Peter] On Thu, Jun 04, 2020 at 10:48:03AM +, Christophe Leroy wrote: Using mpc885_ads_defconfig with CONFIG_PPC_16K_PAGES instead of CONFIG_PPC_4K_PAGES, getting the

Re: [PATCH] KVM: nVMX: Inject #GP when nested_vmx_get_vmptr() fails to read guest memory

2020-06-04 Thread Paolo Bonzini
On 04/06/20 16:31, Vitaly Kuznetsov wrote: > Syzbot reports the following issue: > > WARNING: CPU: 0 PID: 6819 at arch/x86/kvm/x86.c:618 > kvm_inject_emulated_page_fault+0x210/0x290 arch/x86/kvm/x86.c:618 > ... > Call Trace: > ... > RIP: 0010:kvm_inject_emulated_page_fault+0x210/0x290

BUG: using smp_processor_id() in preemptible code in debug_smp_processor_id

2020-06-04 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:065fcfd4 selftests: net: ip_defrag: ignore EPERM git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=15c3e51610 kernel config: https://syzkaller.appspot.com/x/.config?x=d89141553e61b775 dashboard

Re: [PATCH] pwm: Add missing "CONFIG_" prefix

2020-06-04 Thread Uwe Kleine-König
On Wed, Jun 03, 2020 at 03:40:56PM -0700, Kees Cook wrote: > The IS_ENABLED() use was missing the CONFIG_ prefix which would have > lead to skipping this code. > > Fixes: 3ad1f3a33286 ("pwm: Implement some checks for lowlevel drivers") > Signed-off-by: Kees Cook > --- > drivers/pwm/core.c | 2

Re: [PATCH 5/5] gcc-plugins/stackleak: Don't instrument vgettimeofday.c in arm64 VDSO

2020-06-04 Thread Alexander Popov
On 04.06.2020 17:25, Jann Horn wrote: > On Thu, Jun 4, 2020 at 4:21 PM Alexander Popov wrote: >> On 04.06.2020 17:14, Jann Horn wrote: >>> Maybe at some point we should replace exclusions based on >>> GCC_PLUGINS_CFLAGS and KASAN_SANITIZE and UBSAN_SANITIZE and >>> OBJECT_FILES_NON_STANDARD and

Re: [PATCH] checkpatch: Avoid missing typo suggestions

2020-06-04 Thread Maxim Uvarov
On Thu, 4 Jun 2020 at 10:29, Joe Perches wrote: > > On Thu, 2020-06-04 at 09:55 +0300, Maxim Uvarov wrote: > > On Thu, 4 Jun 2020 at 03:39, Joe Perches wrote: > > Hi Maxim. > > > > btw: My codespell dictionary file moved to > > > /usr/lib/python3/dist-packages/codespell_lib/data/dictionary.txt >

Re: [PATCH 30/30] KVM: nSVM: implement KVM_GET_NESTED_STATE and KVM_SET_NESTED_STATE

2020-06-04 Thread Paolo Bonzini
Sorry I missed this. On 02/06/20 02:11, Krish Sadhukhan wrote: >> >> + >> +    /* SMM temporarily disables SVM, so we cannot be in guest mode.  */ >> +    if (is_smm(vcpu) && (kvm_state->flags & >> KVM_STATE_NESTED_GUEST_MODE)) >> +    return -EINVAL; >> + >> +    if (!(kvm_state->flags &

Re: [PATCH] mm/memory_hotplug: fix default_zone_for_pfn() to include highmem zone range

2020-06-04 Thread David Hildenbrand
On 04.06.20 15:39, Vamshi K Sthambamkadi wrote: > On x86_32, while onlining highmem sections, the func default_zone_for_pfn() > defaults target zone to ZONE_NORMAL (movable_node_enabled = 0). Onlining of > pages is successful, and these highmem pages are moved into zone_normal. > > As a

Re: 回复: Re: [RFC PATCH 0/8] dax: Add a dax-rmap tree to support reflink

2020-06-04 Thread Darrick J. Wong
On Thu, Jun 04, 2020 at 03:37:42PM +0800, Ruan Shiyang wrote: > > > On 2020/4/28 下午2:43, Dave Chinner wrote: > > On Tue, Apr 28, 2020 at 06:09:47AM +, Ruan, Shiyang wrote: > > > > > > 在 2020/4/27 20:28:36, "Matthew Wilcox" 写道: > > > > > > > On Mon, Apr 27, 2020 at 04:47:42PM +0800,

Re: [PATCH] KVM: nVMX: Inject #GP when nested_vmx_get_vmptr() fails to read guest memory

2020-06-04 Thread Vitaly Kuznetsov
Paolo Bonzini writes: > On 04/06/20 16:31, Vitaly Kuznetsov wrote: >> Syzbot reports the following issue: >> >> WARNING: CPU: 0 PID: 6819 at arch/x86/kvm/x86.c:618 >> kvm_inject_emulated_page_fault+0x210/0x290 arch/x86/kvm/x86.c:618 >> ... >> Call Trace: >> ... >> RIP:

Re: [PATCH] KVM: nVMX: Inject #GP when nested_vmx_get_vmptr() fails to read guest memory

2020-06-04 Thread Sean Christopherson
On Thu, Jun 04, 2020 at 04:40:52PM +0200, Paolo Bonzini wrote: > On 04/06/20 16:31, Vitaly Kuznetsov wrote: ... > > KVM could've handled the request correctly by going to userspace and > > performing I/O but there doesn't seem to be a good need for such requests > > in the first place. Sane

[PATCH v2 1/2] kcov, objtool: Make runtime functions noinstr-compatible

2020-06-04 Thread Marco Elver
While we lack a compiler attribute to add to noinstr that would disable KCOV, make the KCOV runtime functions return if the caller is in a noinstr section. We then whitelist __sanitizer_cov_*() functions in objtool. __sanitizer_cov_*() cannot safely become safe noinstr functions as-is, as they may

Re: [PATCH 01/10] x86/mm/numa: Remove uninitialized_var() usage

2020-06-04 Thread Kees Cook
On Thu, Jun 04, 2020 at 01:41:07PM +0200, Miguel Ojeda wrote: > On Thu, Jun 4, 2020 at 9:58 AM Thomas Gleixner wrote: > > > > but if we ever lose the 1 then the above will silently compile the code > > within the IS_ENABLED() section out. > > Yeah, I believe `IS_ENABLED()` is only meant for

[PATCH v2 2/2] kcov: Pass -fno-stack-protector with Clang

2020-06-04 Thread Marco Elver
For Clang, correctly pass -fno-stack-protector via a separate cc-option, as -fno-conserve-stack does not exist with Clang. Signed-off-by: Marco Elver --- kernel/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/Makefile b/kernel/Makefile index

Re: [RFC v2 7/9] mm/damon: Implement callbacks for physical memory monitoring

2020-06-04 Thread David Hildenbrand
On 04.06.20 09:26, SeongJae Park wrote: > On Wed, 3 Jun 2020 18:09:21 +0200 David Hildenbrand wrote: > >> On 03.06.20 16:11, SeongJae Park wrote: >>> From: SeongJae Park >>> >>> This commit implements the four callbacks (->init_target_regions, >>> ->update_target_regions,

Re: [PATCH v3 25/75] x86/sev-es: Add support for handling IOIO exceptions

2020-06-04 Thread Sean Christopherson
On Thu, Jun 04, 2020 at 12:15:02PM +0200, Joerg Roedel wrote: > On Wed, Jun 03, 2020 at 04:07:16PM -0700, Sean Christopherson wrote: > > On Wed, Jun 03, 2020 at 04:23:25PM +0200, Joerg Roedel wrote: > > > User-space can also cause IOIO #VC exceptions, and user-space can be > > > 32-bit legacy code

Re: [PATCH 09/10] treewide: Remove uninitialized_var() usage

2020-06-04 Thread Kees Cook
On Thu, Jun 04, 2020 at 10:23:06AM -0300, Jason Gunthorpe wrote: > On Wed, Jun 03, 2020 at 04:32:02PM -0700, Kees Cook wrote: > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > > (or can in the future), and suppresses unrelated compiler warnings > > (e.g. "unused

Re: [PATCH RFC] uaccess: user_access_begin_after_access_ok()

2020-06-04 Thread Al Viro
On Thu, Jun 04, 2020 at 02:10:27PM +0800, Jason Wang wrote: > > > get_user(flags, desc->flags) > > > smp_rmb() > > > if (flags & VALID) > > > copy_from_user(, desc, sizeof adesc); > > > > > > this would be a good candidate I think. > > Perhaps, once we get stac/clac out of raw_copy_from_user()

Re: [RFC PATCH v4 02/10] vfio/pci: macros to generate module_init and module_exit for vendor modules

2020-06-04 Thread Cornelia Huck
On Sun, 17 May 2020 22:45:10 -0400 Yan Zhao wrote: > vendor modules call macro module_vfio_pci_register_vendor_handler to > generate module_init and module_exit. > It is necessary to ensure that vendor modules always call > vfio_pci_register_vendor_driver() on driver loading and >

Re: [PATCH RFC] uaccess: user_access_begin_after_access_ok()

2020-06-04 Thread Al Viro
On Thu, Jun 04, 2020 at 06:10:23AM -0400, Michael S. Tsirkin wrote: > stac() > for (i = 0; i < 64; ++i) { >get_user(flags, desc[i].flags) unsafe_get_user(), please. >smp_rmb() >if (!(flags & VALID)) > break; >copy_from_user([i], desc + i,

Re: [Nouveau] NVIDIA GP107 (137000a1) - acr: failed to load firmware

2020-06-04 Thread Zeno Davatz
Dear Ilia Thank you for your reply. On Thu, Jun 4, 2020 at 4:36 PM Ilia Mirkin wrote: > Starting with kernel 5.6, loading nouveau without firmware (for GPUs > where it is required, such as yours) got broken. > > You are loading nouveau without firmware, so it fails. > > The firmware needs to be

[PATCHv7 0/3] optee: register drivers on optee bus

2020-06-04 Thread Maxim Uvarov
v7: - check return value of dev_set_name() (Jarkko Sakkinen) v6: - description, comments, patches reorder and destroy workqueue (Sumit Garg) v5: - removed pr_err and fix typos in description (Jarkko Sakkinen) - added missed kfree in optee_open() v4: - sysfs entry is optee-ta-uuid (Jerome

[PATCHv7 3/3] tpm_ftpm_tee: register driver on TEE bus

2020-06-04 Thread Maxim Uvarov
OP-TEE based fTPM Trusted Application depends on tee-supplicant to provide NV RAM implementation based on RPMB secure storage. So this dependency can be resolved via TEE bus where we only invoke fTPM driver probe once fTPM device is registered on the bus which is only true after the tee-supplicant

[PATCH -next] fork: silence a false postive warning in __mmdrop

2020-06-04 Thread Qian Cai
The linux-next commit bf2c59fce407 ("sched/core: Fix illegal RCU from offline CPUs") delayed, idle->active_mm = _mm; into finish_cpu() instead of idle_task_exit() which results in a false positive warning that was originally designed in the commit 3eda69c92d47 ("kernel/fork.c: detect early free

[PATCHv7 2/3] optee: enable support for multi-stage bus enumeration

2020-06-04 Thread Maxim Uvarov
Some drivers (like ftpm) can operate only after tee-supplicant runs because of tee-supplicant provides things like storage services (rpmb, shm).  This patch splits probe of non tee-supplicant dependable drivers to the early stage, and after tee-supplicant run probe other drivers. Signed-off-by:

[PATCHv7 1/3] optee: use uuid for sysfs driver entry

2020-06-04 Thread Maxim Uvarov
With the evolving use-cases for TEE bus, now it's required to support multi-stage enumeration process. But using a simple index doesn't suffice this requirement and instead leads to duplicate sysfs entries. So instead switch to use more informative device UUID for sysfs entry like:

Re: [PATCH 05/14] mm: workingset: let cache workingset challenge anon

2020-06-04 Thread Johannes Weiner
On Thu, Jun 04, 2020 at 03:35:27PM +0200, Vlastimil Babka wrote: > On 6/1/20 10:44 PM, Johannes Weiner wrote: > > From a8faceabc1454dfd878caee2a8422493d937a394 Mon Sep 17 00:00:00 2001 > > From: Johannes Weiner > > Date: Mon, 1 Jun 2020 14:04:09 -0400 > > Subject: [PATCH] mm: workingset: let

Re: [PATCH 2/5] gcc-plugins/stackleak: Use asm instrumentation to avoid useless register saving

2020-06-04 Thread Miguel Ojeda
Hi Alexander, On Thu, Jun 4, 2020 at 3:50 PM Alexander Popov wrote: > > diff --git a/include/linux/compiler_attributes.h > b/include/linux/compiler_attributes.h > index cdf016596659..522d57ae8532 100644 > --- a/include/linux/compiler_attributes.h > +++ b/include/linux/compiler_attributes.h > @@

Re: [PATCH] regulator: mt6360: Add support for MT6360 regulator

2020-06-04 Thread Randy Dunlap
On 6/4/20 12:06 AM, Gene Chen wrote: > diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig > index f4b72cb..05a3b14 100644 > --- a/drivers/regulator/Kconfig > +++ b/drivers/regulator/Kconfig > @@ -680,6 +680,16 @@ config REGULATOR_MT6358 > This driver supports the control of

Re: [PATCH] iommu/mediatek: Use totalram_pages to setup enable_4GB

2020-06-04 Thread Christoph Hellwig
On Thu, Jun 04, 2020 at 01:32:40PM +0200, David Hildenbrand wrote: > Just a thought: If memory hotplug is applicable as well, you might > either want to always assume data->enable_4GB, or handle memory hotplug > events from the memory notifier, when new memory gets onlined (not sure > how tricky

Re: [PATCH v2 3/7] selftests/ftrace: Add "requires:" list support

2020-06-04 Thread Masami Hiramatsu
Hi Steve, On Wed, 3 Jun 2020 10:33:43 -0400 Steven Rostedt wrote: > On Wed, 3 Jun 2020 08:51:13 +0900 > Masami Hiramatsu wrote: > > > On Tue, 2 Jun 2020 09:21:45 -0400 > > Steven Rostedt wrote: > > > > > On Tue, 2 Jun 2020 18:08:31 +0900 > > > Masami Hiramatsu wrote: > > > > > > > +++

RE: general protection fault in ima_free_template_entry

2020-06-04 Thread Roberto Sassu
> From: syzbot > [mailto:syzbot+223310b454ba6b759...@syzkaller.appspotmail.com] > Sent: Thursday, June 4, 2020 4:23 PM > Hello, > > syzbot found the following crash on: > > HEAD commit:e7b08814 Add linux-next specific files for 20200529 > git tree: linux-next > console output:

Re: [PATCH v2] KVM: x86: Assign correct value to array.maxnent

2020-06-04 Thread Sean Christopherson
On Thu, Jun 04, 2020 at 12:16:36PM +0800, Xiaoyao Li wrote: > Delay the assignment of array.maxnent to use correct value for the case > cpuid->nent > KVM_MAX_CPUID_ENTRIES. > > Fixes: e53c95e8d41e ("KVM: x86: Encapsulate CPUID entries and metadata in > struct") > Signed-off-by: Xiaoyao Li > ---

Re: [PATCH v7 5/5] drivers/tty/serial: add LiteUART driver

2020-06-04 Thread Randy Dunlap
Hi-- On 6/4/20 3:14 AM, Mateusz Holenko wrote: > +config SERIAL_LITEUART > + tristate "LiteUART serial port support" > + depends on HAS_IOMEM > + depends on OF || COMPILE_TEST > + depends on LITEX_SOC_CONTROLLER > + select SERIAL_CORE > + help > + This driver is for

Re: [Nouveau] NVIDIA GP107 (137000a1) - acr: failed to load firmware

2020-06-04 Thread Zeno Davatz
On Thu, Jun 4, 2020 at 4:36 PM Ilia Mirkin wrote: > > Starting with kernel 5.6, loading nouveau without firmware (for GPUs > where it is required, such as yours) got broken. > > You are loading nouveau without firmware, so it fails. > > The firmware needs to be available to the kernel at the time

Re: [RFC 00/16] KVM protected memory extension

2020-06-04 Thread Marc Zyngier
Hi Kirill, Thanks for this. On Fri, 22 May 2020 15:51:58 +0300 "Kirill A. Shutemov" wrote: > == Background / Problem == > > There are a number of hardware features (MKTME, SEV) which protect guest > memory from some unauthorized host access. The patchset proposes a purely > software feature

Re: [PATCH] scs: Report SCS usage in bytes rather than number of entries

2020-06-04 Thread Will Deacon
On Wed, Jun 03, 2020 at 10:06:13AM -0700, Kees Cook wrote: > On Wed, Jun 03, 2020 at 04:12:17PM +0100, Will Deacon wrote: > > Fix the SCS debug usage check so that we report the number of bytes > > usedm, rather than the number of entries. > > typo: used > > > > > Fixes: 5bbaf9d1fcb9 ("scs: Add

Re: [PATCH v2 3/7] selftests/ftrace: Add "requires:" list support

2020-06-04 Thread Steven Rostedt
On Fri, 5 Jun 2020 00:08:50 +0900 Masami Hiramatsu wrote: > > Reviewed-by: Steven Rostedt (VMware) > > Thanks, and I've already sent v3. > > https://lkml.kernel.org/r/159115200085.70027.6141550347953439240.stgit@devnote2 I tested that too, and you can keep my Reviewed-by on the patch set.

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-04 Thread Jassi Brar
On Thu, Jun 4, 2020 at 4:20 AM Sudeep Holla wrote: > > On Wed, Jun 03, 2020 at 01:32:42PM -0500, Jassi Brar wrote: > > On Wed, Jun 3, 2020 at 1:04 PM Sudeep Holla wrote: > > > > > > On Fri, May 29, 2020 at 09:37:58AM +0530, Viresh Kumar wrote: > > > > On 28-05-20, 13:20, Rob Herring wrote: > > >

Re: [PATCH] KVM: VMX: Always treat MSR_IA32_PERF_CAPABILITIES as a valid PMU MSR

2020-06-04 Thread Sean Christopherson
On Thu, Jun 04, 2020 at 09:37:59AM +0800, Xu, Like wrote: > On 2020/6/4 4:33, Sean Christopherson wrote: > >Unconditionally return true when querying the validity of > >MSR_IA32_PERF_CAPABILITIES so as to defer the validity check to > >intel_pmu_{get,set}_msr(), which can properly give the MSR a

Re: [PATCH] iommu/arm-smmu: Mark qcom_smmu_client_of_match as possibly unused

2020-06-04 Thread Will Deacon
On Wed, Jun 03, 2020 at 03:15:07PM -0600, Jordan Crouse wrote: > When CONFIG_OF=n of_match_device() gets pre-processed out of existence > leaving qcom-smmu_client_of_match unused. Mark it as possibly unused to > keep the compiler from warning in that case. > > Fixes: 0e764a01015d

Re: [PATCH v3 40/75] x86/sev-es: Compile early handler code into kernel image

2020-06-04 Thread Borislav Petkov
On Thu, Jun 04, 2020 at 01:54:13PM +0200, Joerg Roedel wrote: > It is not only the trace-point, this would also eliminate exception > handling in case the MSR access triggers a #GP. The "Unhandled MSR > read/write" messages would turn into a "General Protection Fault" > message. But the early

Re: [PATCH 1/1] nvme-fcloop: verify wwnn and wwpn format

2020-06-04 Thread James Smart
On 5/25/2020 9:21 PM, Dongli Zhang wrote: The nvme host and target verify the wwnn and wwpn format via nvme_fc_parse_traddr(). For instance, it is required that the length of wwnn to be either 21 ("nn-0x") or 19 (nn-). Add this verification to nvme-fcloop so that the input should always be in

Re: [PATCH] coccinelle: api: add kzfree script

2020-06-04 Thread Markus Elfring
> Check for memset() with 0 followed by kfree(). I suggest to simplify the SmPL code a bit like the following. > +virtual context > +virtual org > +virtual report > +virtual patch +virtual context, org, report, patch … > +@@ > + > +( > +* memset(E, 0, ...); > +| > +* memset(E, '\0', ...); >

Re: [PATCH 01/10] x86/mm/numa: Remove uninitialized_var() usage

2020-06-04 Thread Miguel Ojeda
On Thu, Jun 4, 2020 at 4:56 PM Kees Cook wrote: > > Er? That's not what it looked like to me: > > #define IS_BUILTIN(option) __is_defined(option) > #define IS_ENABLED(option) __or(IS_BUILTIN(option), IS_MODULE(option)) > > But just to be sure, I just tested in with a real build: > > [

Re: [PATCH 1/5] gcc-plugins/stackleak: Exclude alloca() from the instrumentation logic

2020-06-04 Thread Alexander Popov
On 04.06.2020 17:01, Jann Horn wrote: > On Thu, Jun 4, 2020 at 3:51 PM Alexander Popov wrote: >> Some time ago Variable Length Arrays (VLA) were removed from the kernel. >> The kernel is built with '-Wvla'. Let's exclude alloca() from the >> instrumentation logic and make it simpler. The

Re: Re: [RFC v2 7/9] mm/damon: Implement callbacks for physical memory monitoring

2020-06-04 Thread SeongJae Park
On Thu, 4 Jun 2020 16:58:13 +0200 David Hildenbrand wrote: > On 04.06.20 09:26, SeongJae Park wrote: > > On Wed, 3 Jun 2020 18:09:21 +0200 David Hildenbrand > > wrote: > > > >> On 03.06.20 16:11, SeongJae Park wrote: > >>> From: SeongJae Park > >>> > >>> This commit implements the four

Re: [RFC PATCH v4 04/10] vfio/pci: let vfio_pci know number of vendor regions and vendor irqs

2020-06-04 Thread Cornelia Huck
On Sun, 17 May 2020 22:49:44 -0400 Yan Zhao wrote: > This allows a simpler VFIO_DEVICE_GET_INFO ioctl in vendor driver > > Cc: Kevin Tian > Signed-off-by: Yan Zhao > --- > drivers/vfio/pci/vfio_pci.c | 23 +-- > drivers/vfio/pci/vfio_pci_private.h | 2 ++ >

Re: [Nouveau] NVIDIA GP107 (137000a1) - acr: failed to load firmware

2020-06-04 Thread Ilia Mirkin
On Thu, Jun 4, 2020 at 11:16 AM Zeno Davatz wrote: > > On Thu, Jun 4, 2020 at 4:36 PM Ilia Mirkin wrote: > > > > Starting with kernel 5.6, loading nouveau without firmware (for GPUs > > where it is required, such as yours) got broken. > > > > You are loading nouveau without firmware, so it

Re: [PATCH v2 1/2] kcov, objtool: Make runtime functions noinstr-compatible

2020-06-04 Thread Peter Zijlstra
On Thu, Jun 04, 2020 at 04:56:34PM +0200, Marco Elver wrote: > While we lack a compiler attribute to add to noinstr that would disable > KCOV, make the KCOV runtime functions return if the caller is in a > noinstr section. We then whitelist __sanitizer_cov_*() functions in > objtool. >

Re: [GIT PULL] SELinux patches for v5.8

2020-06-04 Thread Casey Schaufler
On 6/4/2020 5:45 AM, Stephen Smalley wrote: > On Wed, Jun 3, 2020 at 6:39 PM Casey Schaufler wrote: >> On 6/3/2020 3:12 PM, James Morris wrote: >>> On Wed, 3 Jun 2020, Casey Schaufler wrote: >>> The use of security modules was expected to be rare. >>> This is not correct. Capabilities were

Re: [PATCH] iommu/mediatek: Use totalram_pages to setup enable_4GB

2020-06-04 Thread David Hildenbrand
On 04.06.20 17:06, Christoph Hellwig wrote: > On Thu, Jun 04, 2020 at 01:32:40PM +0200, David Hildenbrand wrote: >> Just a thought: If memory hotplug is applicable as well, you might >> either want to always assume data->enable_4GB, or handle memory hotplug >> events from the memory notifier, when

Re: [PATCH v3 42/75] x86/sev-es: Setup GHCB based boot #VC handler

2020-06-04 Thread Borislav Petkov
On Thu, Jun 04, 2020 at 02:07:49PM +0200, Joerg Roedel wrote: > This are IDT entry points and the names above follow the convention for > them, like e.g. 'page_fault', 'nmi' or 'general_protection'. Should I > still add the verbs or just add a comment explaining what those symbols > are? Hmmkay,

Re: [PATCH v2] hwmon: bt1-pvt: Define Temp- and Volt-to-N poly as maybe-unused

2020-06-04 Thread Guenter Roeck
On Wed, Jun 03, 2020 at 03:07:53AM +0300, Serge Semin wrote: > Clang-based kernel building with W=1 warns that some static const > variables are unused: > > drivers/hwmon/bt1-pvt.c:67:30: warning: unused variable 'poly_temp_to_N' > [-Wunused-const-variable] > static const struct pvt_poly

[PATCH v1] reset: intel: fix a compile warning about REG_OFFSET redefined

2020-06-04 Thread Dejin Zheng
kernel test robot reports a compile warning about REG_OFFSET redefined in the reset-intel-gw.c after merging commit e44ab4e14d6f4 ("regmap: Simplify implementation of the regmap_read_poll_timeout() macro"). the warning is like that: drivers/reset/reset-intel-gw.c:18:0: warning: "REG_OFFSET"

Re: [PATCH v2 1/5] perf/x86/rapl: move RAPL support to common x86 code

2020-06-04 Thread Stephane Eranian
On Thu, Jun 4, 2020 at 6:11 AM Johannes Hirte wrote: > > On 2020 Jun 01, Stephane Eranian wrote: > > On Mon, Jun 1, 2020 at 5:39 AM Johannes Hirte > > wrote: > > > > > > On 2020 Mai 27, Stephane Eranian wrote: > > > > > > ... > > > > diff --git a/arch/x86/events/Makefile

Re: [PATCH] KVM: nVMX: Inject #GP when nested_vmx_get_vmptr() fails to read guest memory

2020-06-04 Thread Vitaly Kuznetsov
Sean Christopherson writes: > On Thu, Jun 04, 2020 at 04:40:52PM +0200, Paolo Bonzini wrote: >> On 04/06/20 16:31, Vitaly Kuznetsov wrote: > > ... > >> > KVM could've handled the request correctly by going to userspace and >> > performing I/O but there doesn't seem to be a good need for such

Re: [GIT PULL] SELinux patches for v5.8

2020-06-04 Thread Stephen Smalley
On Thu, Jun 4, 2020 at 11:28 AM Casey Schaufler wrote: > > On 6/4/2020 5:45 AM, Stephen Smalley wrote: > > On Wed, Jun 3, 2020 at 6:39 PM Casey Schaufler > > wrote: > >> On 6/3/2020 3:12 PM, James Morris wrote: > >>> On Wed, 3 Jun 2020, Casey Schaufler wrote: > >>> > The use of security

Re: [PATCH v3 2/7] documentation for stats_fs

2020-06-04 Thread Emanuele Giuseppe Esposito
Hi, + +The STATS_FS_HIDDEN attribute won't affect the aggregation, it will only +block the creation of the files. Why does HIDDEN block the creation of files? instead of their visibility? The file itself is used to allow the user to view the content of a value. In order to make it hidden,

[PATCH] i2c: npcm7xx: Remove unnecessary parentheses

2020-06-04 Thread Gustavo A. R. Silva
Remove unnecessary parentheses around _bus_. This issue was found with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/i2c/busses/i2c-npcm7xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-npcm7xx.c

Re: drivers/reset/reset-intel-gw.c:18: warning: "REG_OFFSET" redefined

2020-06-04 Thread Dejin Zheng
implementation of the regmap_read_poll_timeout() macro > date: 6 weeks ago > config: arm-randconfig-r035-20200604 (attached as .config) > compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget > https://raw.githubusercontent.com/intel/lkp-tests/m

Re: v5.7: new core kernel option missing help text

2020-06-04 Thread Valentin Schneider
On 04/06/20 14:05, Thara Gopinath wrote: > On Thu, 4 Jun 2020 at 06:56, Valentin Schneider >> >> Right, s/defconfig/arch kconfig/ or somesuch. >> > > CPU_FREQ_THERMAL also has to be enabled for this to be effective. > Since arm64 defconfig enables CPU_FREQ_THERMAL (by enabling CPU_THERMAL),

Re: [PATCH] coccinelle: api: add kzfree script

2020-06-04 Thread Denis Efremov
On 6/4/20 5:15 PM, Julia Lawall wrote: > Did you try ... here but find that some subexpressions of E could be > modified in between? Yes, I tried to use "... when != E = E1 when != " and results were bad. Now, I've tried forall and when strict. Here are examples: // forall added // Works

Re: [RFC v2 7/9] mm/damon: Implement callbacks for physical memory monitoring

2020-06-04 Thread David Hildenbrand
On 04.06.20 17:23, SeongJae Park wrote: > On Thu, 4 Jun 2020 16:58:13 +0200 David Hildenbrand wrote: > >> On 04.06.20 09:26, SeongJae Park wrote: >>> On Wed, 3 Jun 2020 18:09:21 +0200 David Hildenbrand >>> wrote: >>> On 03.06.20 16:11, SeongJae Park wrote: > From: SeongJae Park >

[tip:x86/entry] BUILD SUCCESS b8797e281f77cdac3988e9a97b1c76eabbabaefa

2020-06-04 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/entry branch HEAD: b8797e281f77cdac3988e9a97b1c76eabbabaefa Merge branch 'linus' into x86/entry, to resolve conflicts i386-tinyconfig vmlinux size:

Re: [patch V9 00/39] x86/entry: Rework leftovers (was part V)

2020-06-04 Thread Andy Lutomirski
On Thu, Jun 4, 2020 at 6:35 AM Peter Zijlstra wrote: > > On Thu, Jun 04, 2020 at 03:29:26PM +0200, Paolo Bonzini wrote: > > On 04/06/20 15:25, Peter Zijlstra wrote: > > > It being enabled through IA32_DEBUGCTL instead of through DR7 means that > > > the current code doesn't disable it and this

Re: [PATCH v1] Bluetooth: hci_qca: Fix double free during SSR timeout

2020-06-04 Thread bgodavar
On 2020-06-04 19:27, Venkata Lakshmi Narayana Gubba wrote: Due to race conditions between qca_hw_error and qca_controller_memdump during SSR timeout,the same pointer is freed twice. Which results to double free error. Now a lock is acquired while SSR state moved to timeout. Signed-off-by:

Re: [RFC 00/16] KVM protected memory extension

2020-06-04 Thread Sean Christopherson
+Jun On Thu, Jun 04, 2020 at 04:15:23PM +0100, Marc Zyngier wrote: > Hi Kirill, > > Thanks for this. > > On Fri, 22 May 2020 15:51:58 +0300 > "Kirill A. Shutemov" wrote: > > > == Background / Problem == > > > > There are a number of hardware features (MKTME, SEV) which protect guest > >

Re: [PATCH v2 1/2] arm64: dts: Add a device tree for the Librem 5 phone

2020-06-04 Thread Mark Brown
On Thu, Jun 04, 2020 at 10:47:55AM +0200, Martin Kepplinger wrote: > + reg_audio_pwr_en: regulator-audio-pwr-en { > + compatible = "regulator-fixed"; > + pinctrl-names = "default"; > + pinctrl-0 = <_audiopwr>; > + regulator-name =

Re: [PATCH] coccinelle: api: add kzfree script

2020-06-04 Thread Julia Lawall
On Thu, 4 Jun 2020, Denis Efremov wrote: > > > On 6/4/20 5:15 PM, Julia Lawall wrote: > > Did you try ... here but find that some subexpressions of E could be > > modified in between? > > Yes, I tried to use "... when != E = E1 when != " and results were bad. > Now, I've tried forall and when

Re: Re: [RFC v2 7/9] mm/damon: Implement callbacks for physical memory monitoring

2020-06-04 Thread SeongJae Park
On Thu, 4 Jun 2020 17:39:49 +0200 David Hildenbrand wrote: > On 04.06.20 17:23, SeongJae Park wrote: > > On Thu, 4 Jun 2020 16:58:13 +0200 David Hildenbrand > > wrote: > > > >> On 04.06.20 09:26, SeongJae Park wrote: > >>> On Wed, 3 Jun 2020 18:09:21 +0200 David Hildenbrand > >>> wrote: >

Re: [PATCH] scsi: megaraid_sas: fix kdump kernel boot hung caused by JBOD

2020-06-04 Thread Kai Liu
On 2020/06/04 Thu 16:39, Chandrakanth Patil wrote: Hi Martin, Xiaoming Gao, Kai Liu, It is a known firmware issue and has been fixed. Please update to the latest firmware available in the Broadcom support website. Please let me know if you need any further information. Hi Chandrakanth,

Re: [patch V9 00/39] x86/entry: Rework leftovers (was part V)

2020-06-04 Thread Peter Zijlstra
On Thu, Jun 04, 2020 at 08:42:52AM -0700, Andy Lutomirski wrote: > x86 is not an architecture. x86 is a gauntlet through which operating > system developers must run. That made my day :-) > I think we can tolerate this particular mess -- can't we just say that > a BUS LOCK DEBUG EXCEPTION is

Re: [PATCH] coccinelle: api: add kzfree script

2020-06-04 Thread Julia Lawall
On Thu, 4 Jun 2020, Markus Elfring wrote: > > Check for memset() with 0 followed by kfree(). > > I suggest to simplify the SmPL code a bit like the following. > > > > +virtual context > > +virtual org > > +virtual report > > +virtual patch > > +virtual context, org, report, patch This is

Re: [PATCH] ovl: explicitly initialize error in ovl_copy_xattr()

2020-06-04 Thread Kees Cook
On Thu, Jun 04, 2020 at 10:42:45AM +0200, gli...@google.com wrote: > Under certain circumstances (we found this out running Docker on a > Clang-built kernel with CONFIG_INIT_STACK_ALL) ovl_copy_xattr() may > return uninitialized value of |error| from ovl_copy_xattr(). > It is then returned by

Re: [PATCH 0/6] arm64: dts: qcom: smmu/USB nodes and HDK855/HDK865 dts

2020-06-04 Thread Manivannan Sadhasivam
On Thu, Jun 04, 2020 at 10:06:19AM -0400, Jonathan Marek wrote: > On 6/4/20 9:52 AM, Manivannan Sadhasivam wrote: > > Hi, > > > > On Sat, May 23, 2020 at 10:38:06PM -0400, Jonathan Marek wrote: > > > Add dts nodes for apps_smmu and USB for both sm8150 and sm8250. > > > > > > > I've tested this

Re: [PATCH] ovl: explicitly initialize error in ovl_copy_xattr()

2020-06-04 Thread Kees Cook
On Thu, Jun 04, 2020 at 10:57:24AM +0200, Miklos Szeredi wrote: > On Thu, Jun 4, 2020 at 10:43 AM wrote: > > > > Under certain circumstances (we found this out running Docker on a > > Clang-built kernel with CONFIG_INIT_STACK_ALL) ovl_copy_xattr() may > > return uninitialized value of |error|

Re: [RFC PATCH] gpio: uapi: v2 proposal

2020-06-04 Thread Kent Gibson
On Thu, Jun 04, 2020 at 02:43:08PM +0200, Bartosz Golaszewski wrote: > sob., 16 maj 2020 o 08:45 Kent Gibson napisał(a): > > > > Add a new version of the uAPI to address existing 32/64bit alignment > > issues, add support for debounce, and provide some future proofing by > > adding padding

Re: [RFC v2 7/9] mm/damon: Implement callbacks for physical memory monitoring

2020-06-04 Thread David Hildenbrand
On 04.06.20 17:51, SeongJae Park wrote: > On Thu, 4 Jun 2020 17:39:49 +0200 David Hildenbrand wrote: > >> On 04.06.20 17:23, SeongJae Park wrote: >>> On Thu, 4 Jun 2020 16:58:13 +0200 David Hildenbrand >>> wrote: >>> On 04.06.20 09:26, SeongJae Park wrote: > On Wed, 3 Jun 2020

Re: [PATCH] KVM: nVMX: Inject #GP when nested_vmx_get_vmptr() fails to read guest memory

2020-06-04 Thread Sean Christopherson
On Thu, Jun 04, 2020 at 05:33:25PM +0200, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > > > On Thu, Jun 04, 2020 at 04:40:52PM +0200, Paolo Bonzini wrote: > >> On 04/06/20 16:31, Vitaly Kuznetsov wrote: > > > > ... > > > >> > KVM could've handled the request correctly by going to

Re: [Nouveau] NVIDIA GP107 (137000a1) - acr: failed to load firmware

2020-06-04 Thread Zeno Davatz
Thank you, Ilia On Thu, Jun 4, 2020 at 5:25 PM Ilia Mirkin wrote: > There's a lot more firmware files than that ... everything in the > gp107 directory. Also this would only be necessary if nouveau is built > into the kernel. The files just have to be available whenever nouveau > is loaded --

Re: [PATCH RT 1/2] tasklet: Address a race resulting in double-enqueue

2020-06-04 Thread Ramon Fried
On Thu, Apr 23, 2020 at 11:55 PM wrote: > > From: Zhang Xiao > > v4.19.115-rt49-rc1 stable review patch. > If anyone has any objections, please let me know. > > --- > > > The kernel bugzilla has the following race condition reported: > > CPU0CPU1CPU2 >

Re: [PATCH -tip] kcov: Make runtime functions noinstr-compatible

2020-06-04 Thread Peter Zijlstra
On Thu, Jun 04, 2020 at 04:02:54PM +0200, Andrey Konovalov wrote: > On Thu, Jun 4, 2020 at 1:09 PM Peter Zijlstra wrote: > > That whole kcov_remote stuff confuses me. > > > > KCOV_ENABLE() has kcov_fault_in_area(), which supposedly takes the > > vmalloc faults for the current task, but who does

Re: [PATCH 3/3] spi: bcm2835: Enable shared interrupt support

2020-06-04 Thread Florian Fainelli
On 6/4/2020 5:32 AM, Mark Brown wrote: > On Wed, Jun 03, 2020 at 08:46:55PM -0700, Florian Fainelli wrote: >> The SPI controller found in the BCM2711 and BCM7211 SoCs is instantiated >> 5 times, with all instances sharing the same interrupt line. We >> specifically match the two compatible

Re: [PATCH] leds: mt6360: Add LED driver for MT6360

2020-06-04 Thread Dan Murphy
Gene On 6/4/20 1:26 AM, Gene Chen wrote: From: Gene Chen Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode, and 3-channel RGB LED support Register/Flash/Breath Mode Signed-off-by: Gene Chen base-commit: 098c4adf249c198519a4abebe482b1e6b8c50e47 ---

[tip:WIP.x86/mm] BUILD SUCCESS c30a3e465817f0c5a3c94678edf0fd15585cadd9

2020-06-04 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git WIP.x86/mm branch HEAD: c30a3e465817f0c5a3c94678edf0fd15585cadd9 Merge branch 'linus' into WIP.x86/mm, to resolve conflict i386-tinyconfig vmlinux size:

Re: coccinelle: api: add kzfree script

2020-06-04 Thread Markus Elfring
>>> +virtual context >>> +virtual org >>> +virtual report >>> +virtual patch >> >> +virtual context, org, report, patch > > This is pointless. I find the proposed SmPL code variant more succinct. >> How does the SmPL asterisk functionality fit to the operation >> modes “org” and “report”? > >

Re: [PATCH 0/6] arm64: dts: qcom: smmu/USB nodes and HDK855/HDK865 dts

2020-06-04 Thread Jonathan Marek
On 6/4/20 11:58 AM, Manivannan Sadhasivam wrote: On Thu, Jun 04, 2020 at 10:06:19AM -0400, Jonathan Marek wrote: On 6/4/20 9:52 AM, Manivannan Sadhasivam wrote: Hi, On Sat, May 23, 2020 at 10:38:06PM -0400, Jonathan Marek wrote: Add dts nodes for apps_smmu and USB for both sm8150 and sm8250.

  1   2   3   4   5   6   7   8   9   10   >