Re: Fwd: Re: [PATCH 1/3] regmap: flat: use the cache_present bitmap

are done? Something like in the following patch: Acked-by: Alexander Sverdlin alexander.sverd...@nsn.com diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index 42b45ac..de7f353 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c

Re: [PATCH 1/1] of: fdt: fix memory initialization for expanded DT

wladislav...@gmail.com Acked-by: Alexander Sverdlin alexander.sverd...@nsn.com --- drivers/of/fdt.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c index 6bb7cf2..b10ba00 100644 --- a/drivers/of/fdt.c +++ b/drivers/of/fdt.c

Re: [PATCH 1/5] OF: Clear detach flag on attach

on FDT unflattening ? -- Best regards, Alexander Sverdlin. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 0/3 - V2] Introducing Device Tree Overlays

the whole series on our MIPS64 platforms (currently old patchset from bbxm tree is successfully used for a while). -- Best regards, Alexander Sverdlin. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 1/5] OF: Clear detach flag on attach

in overlay_proc_release(), I suppose. So the call to of_node_clear_flag() is superfluous, but doesn't hurt. On Nov 6, 2013, at 10:46 AM, Alexander Sverdlin wrote: Hello Pantelis, On 05/11/13 21:03, ext Pantelis Antoniou wrote: On Nov 5, 2013, at 9:43 PM, Gerhard Sittig wrote

Re: [PATCH] of: i2c: Export single device registration method

to a function. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com We use the same patch since kernel 3.10.0, so: Acked-by: Alexander Sverdlin alexander.sverd...@nsn.com Tested-by: Alexander Sverdlin alexander.sverd...@nsn.com --- drivers/i2c/i2c-core.c | 99

Re: [PATCH 0/5] OF: Fixes in preperation of DT overlays

, for all 5 patches: Tested-by: Alexander Sverdlin alexander.sverd...@nsn.com Reviewed-by: Alexander Sverdlin alexander.sverd...@nsn.com drivers/of/Makefile | 2 +- drivers/of/base.c | 77 drivers/of/util.c | 253 include

Re: [PATCH 1/3] OF: Introduce Device Tree resolve support.

-consulting.com Reviewed-by: Alexander Sverdlin alexander.sverd...@nsn.com --- .../devicetree/dynamic-resolution-notes.txt| 25 ++ drivers/of/Kconfig | 9 + drivers/of/Makefile| 1 + drivers/of/resolver.c

Re: [PATCH 2/3] OF: Introduce DT overlay support.

; +} + +#endif + #endif /* _LINUX_OF_H */ -- Best regards, Alexander Sverdlin. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH 0/3 - V2] Introducing Device Tree Overlays

-- Best regards, Alexander Sverdlin. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v3 5/5] OF: Introduce utility helper functions

NULL; +} + ... -- Best regards, Alexander Sverdlin. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v3 5/5] OF: Introduce utility helper functions

); +err_fail_name: +kfree(propn); +return NULL; +} + ... -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best regards, Alexander

Re: [PATCH] mtd: phram: Make phram 64-bit compatible

and not really satisfy anyone? I was also irritated re-inventing the wheel here, but the problem is -- millions of people out there have their startup scripts and uboot environments for phram, who expect this just to work with the next kernel upgrade... -- Best regards, Alexander Sverdlin

Re: [PATCH 2/2] i2c-mux-gpio: eliminate i2c channel order assumptions

-off-by: Ionut Nicu ioan.nicu@nsn.com So, for the code itself Acked-by: Alexander Sverdlin alexander.sverd...@nsn.com --- drivers/i2c/muxes/i2c-mux-gpio.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes

Re: [PATCH 5/6] OF: Utility helper functions for dynamic nodes

*/ -- Best regards, Alexander Sverdlin. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 5/6] OF: Utility helper functions for dynamic nodes

-controller but with a non-NULL value. My proposed fix for this was to remove the if () condition. propn-value will be allocated with kmalloc(0) which returns ZERO_SIZE_PTR which is != NULL. [snip] + #endif /* _LINUX_OF_H */ -- Best regards, Alexander Sverdlin. Regards -- Pantelis

Re: [PATCH 5/6] OF: Utility helper functions for dynamic nodes

regards, Alexander Sverdlin. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v8 7/8] of: spi: Export single device registration method and accessors

); } +EXPORT_SYMBOL(of_find_spi_master_by_node); + #else static void of_register_spi_devices(struct spi_master *master) { } #endif -- Best regards, Alexander Sverdlin. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] of: spi: Export single device registration method and accessors (v2)

() of_find_spi_device_by_node(). Changes since v1: * Brown paper bug with parameter on of_register_spi_device(). Signed-off-by: Pantelis Antoniou pantelis.anton...@konsulko.com Acked-by: Alexander Sverdlin alexaner.sverd...@nsn.com --- drivers/spi/spi.c | 255

Re: [PATCH] i2c: davinci: fixup wait_for_completion_timeout handling

is positive, so that nobody will copy the wrong code out. So the change is correct, Acked-by: Alexander Sverdlin alexander.sverd...@nokia.com --- Patch was compile tested with davinci_all_defconfig (implies CONFIG_I2C_DAVINCI=y) Patch is against 4.0-rc4 (localversion-next is -next-20150317

Re: [PATCH v3 3/5] i2c: recovery: change input parameter to i2c_adapter for prepare/unprepare_recovery

i2c_adapter *); /* gpio recovery */ int scl_gpio; Acked-by: Alexander Sverdlin alexander.sverd...@nokia.com -- Best regards, Alexander Sverdlin. Sent from my pdp-11 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH v3 4/5] i2c: davinci: use bus recovery infrastructure

) { -- Best regards, Alexander Sverdlin. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] i2c: i2c-mux-gpio: Change log level to debug for probe deferrals

. This patch changes the error messages from these deferral cases to debug messages. Signed-off-by: Ionut Nicu ioan.nicu@nokia.com Acked-by: Alexander Sverdlin alexander.sverd...@nokia.com --- drivers/i2c/muxes/i2c-mux-gpio.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions

Re: [PATCH 5/5] i2c: davinci: use ICPFUNC to toggle I2C as gpio for bus recovery

seems to work when SDA is held low externally. Acked-by: Alexander Sverdlin alexander.sverd...@nokia.com Tested-by: Michael Lawnick michael.lawn...@nokia.com --- .../devicetree/bindings/i2c/i2c-davinci.txt| 3 + drivers/i2c/busses/i2c-davinci.c | 102

Re: [PATCH v2] i2c: i2c-mux-gpio: remove error messages for probe deferrals

. This patch removes the error messages for these deferral cases. Signed-off-by: Ionut Nicu ioan.nicu@nokia.com Acked-by: Alexander Sverdlin alexander.sverd...@nokia.com --- drivers/i2c/muxes/i2c-mux-gpio.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git

Re: [PATCH] mtd: fix: avoid race condition when accessing mtd-usecount

-by: Brian Norris computersforpe...@gmail.com Acked-by: Alexander Sverdlin alexander.sverd...@nokia.com --- diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index 2b0c52870999..df7c6c70757a 100644 --- a/drivers/mtd/mtd_blkdevs.c +++ b/drivers/mtd/mtd_blkdevs.c @@ -197,6 +197,7

[PATCH] clk: axm55xx: Use %zu in pr_info for size_t

); ^ Signed-off-by: Alexander Sverdlin alexander.sverd...@nokia.com --- drivers/clk/clk-axm5516.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/clk/clk-axm5516.c b/drivers/clk/clk-axm5516.c index 0f6368c..c7c91a5 100644 --- a/drivers/clk/clk-axm5516.c +++ b/drivers/clk/clk

Re: [Patch v2] driver/i2c/mux: Add register based mux i2c-mux-reg

BE users must take care... Other than that it looks good to me... -- Best regards, Alexander Sverdlin. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] of: acpi: Rename of_node() and acpi_node() to to_of_node() and to_acpi_node()

of_node() instead) it became clear that the names for the functions are too short and too generic for global scope. Signed-off-by: Alexander Sverdlin alexander.sverd...@gmail.com --- Compile-tested on x86_64 with ACPI and ARM with OF. drivers/base/property.c | 26

Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg

in device tree if used, or in platform data. Signed-off-by: York Sun york...@freescale.com CC: Wolfram Sang w...@the-dreams.de CC: Paul Bolle pebo...@tiscali.nl CC: Peter Korsgaard peter.korsga...@barco.com CC: Alexander Sverdlin alexander.sverd...@nokia.com I can think about external FPGA

Re: [PATCH] i2c: octeon: remove unused signal handling

handling case in the return handling. This just removes this dead code. While at it the return variable is adjusted to the type expected. Signed-off-by: Nicholas Mc Guire hof...@osadl.org Looks good, Reviewed-by: Alexander Sverdlin alexander.sverd...@nokia.com --- V2: Thanks to Wolfram Sang

Re: [PATCH] driver/i2c/mux: Add register based mux i2c-mux-reg

that adds a struct platform_device with a i2c-mux-reg name lands? Any platform code which will register the platform_device will trigger uevent and udevd will be able to find the module with this macro. This is a legacy alternative to device-tree approach. -- Best regards, Alexander Sverdlin

Re: [PATCH] driver/i2c/mux: Add register based mux i2c-mux-reg

, Alexander Sverdlin. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] driver/i2c/mux: Add register based mux i2c-mux-reg

the module complete in a sense that it supports both types of binding. There is a legacy probe function in it, all the support for legacy binding with platform_data in it and this modalias is simply the last part of it. -- Best regards, Alexander Sverdlin. -- To unsubscribe from this list: send

Re: [PATCH] driver/i2c/mux: Add register based mux i2c-mux-reg

now no animal was hurt with it. -- Best regards, Alexander Sverdlin. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH] driver/i2c/mux: Add register based mux i2c-mux-reg

; + unsigned int idle; + unsigned int *reg; Yeah, this is really bad idea. You maybe want something like __iomem cookie here instead of this bare pointer. +}; + +#endif /* __LINUX_I2C_MUX_REG_H */ Other than the mentioned above, this is a useful code. -- Best regards, Alexander

Re: [PATCH] driver/i2c/mux: Add register based mux i2c-mux-reg

do not see the platform_device, because there are no users yet, put this MODULE_ALIAS() is perfectly fine, it will allow automatic module loading in non-DT case. -- Best regards, Alexander Sverdlin. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [RFC PATCH] i2c: busses: i2c-omap: Increase timeout for i2c interrupt

OMAP_I2C_TIMEOUT (msecs_to_jiffies(1000)) +#define OMAP_I2C_TIMEOUT (msecs_to_jiffies(60 * 1000)) /* timeout for pm runtime autosuspend */ #define OMAP_I2C_PM_TIMEOUT 1000/* ms */ -- Best regards, Alexander Sverdlin. -- To unsubscribe from this list: send the line unsubscribe linux

[PATCH] sched: Change sysctl_sched_rt_period type to signed int

sched_rt_handler() uses proc_dointvec() to assign this variable and global_rt_period() anyway converts it to u64. After this change it's not possible to assign negative values to sched_rt_period_us any more. Signed-off-by: Alexander Sverdlin alexander.sverd...@nokia.com Reported-by: Vivenzio Pagliari

Re: [RFC PATCH] i2c: busses: i2c-omap: Increase timeout for i2c interrupt

10 opcodes more in hardirq handler, it's much better for the whole system than to trigger scheduler and thread and and and just because of these 10 opcodes. -- Best regards, Alexander Sverdlin. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH] MIPS: Fix early CM probing

he requirement for them to call mips_cm_probe manually > (although doing so isn't harmful for now). > > Signed-off-by: Paul Burton <paul.bur...@imgtec.com> Reviewed-by: Alexander Sverdlin <alexander.sverd...@nokia.com> > --- > > arch/mips/kernel/setup.c |

Re: [PATCH] i2c: Prevent endless uevent loop with dev_dbg

and it will suffer from removing this uevent access and I see no easy way how to provide the same level of information about the device in the log. On the other hand the fix in the Kernel is trivial and we have no information loss. Maybe it deserves a comment, so that this call is not changed back at

Re: [PATCH v13 06/12] usb: xhci: use bus->sysdev for DMA configuration

; > Cc: Baolin Wang <baolin.w...@linaro.org> > Cc: Vivek Gautam <vivek.gau...@codeaurora.org> > Cc: Alexander Sverdlin <alexander.sverd...@nokia.com> > Cc: Mathias Nyman <mathias.ny...@linux.intel.com> > > Signed-off-by: Arnd Bergmann <a...@arndb.de>

[PATCH] serial: earlycon: Extend earlycon command line option to support 64-bit addresses

earlycon implementation used "unsigned long" internally, but there are systems (ARM with LPAE) where sizeof(unsigned long) == 4 and uart is mapped beyond 4GiB address range. Switch to resource_size_t internally and replace obsoleted simple_strtoul() with kstrtoull(). Signed-off-by:

[PATCH] serial: core: Fix handling of options after MMIO address

ut the new and recommended kstrtoull() requires null-terminated string and returns -EINVAL in case there are "options" at the end. There is no recommended to use function currently that will support it, so stick to obsolete simple_strtoull() variant. Signed-off-by: Alexander Sverdlin <alexander.sverd

[PATCH] tools: liblockdep: Don't mix fd-based and stream IO

)[0xb6f8544c] /lib/ld-linux-armhf.so.3(+0xac4)[0xb6f75ac4] Therefore change all bare printf(...) to dprintf(STDOUT_FILENO, ...) to sychronize with backtrace_symbols_fd(). Signed-off-by: Alexander Sverdlin <alexander.sverd...@gmail.com> Cc: Sasha Levin <sasha.le...@oracle.com> --- tools

[PATCH] tools: add install make target for liblockdep

Allow user to call "liblockdep_install" target. Also add liblockdep to "all" and "install" targets (as "help" command suggests). Signed-off-by: Alexander Sverdlin <alexander.sverd...@gmail.com> Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc:

Re: [v5,5/6] usb: dwc3: use bus->sysdev for DMA configuration

igned-off-by: Arnd Bergmann <a...@arndb.de> > Signed-off-by: Sriram Dash <sriram.d...@nxp.com> > Tested-by: Baolin Wang <baolin.w...@linaro.org> Successfully tested on arm64/axxia with DWC3 USB host, XHCIs properly inherit DMA configuration. Therefore: Tested-b

Re: [v5,1/6] usb: separate out sysdev pointer from usb_bus

gt; Signed-off-by: Sriram Dash <sriram.d...@nxp.com> > Tested-by: Baolin Wang <baolin.w...@linaro.org> Successfully tested on arm64/axxia with DWC3 USB host, XHCIs properly inherit DMA configuration. Therefore: Tested-by: Alexander Sverdlin <alexander.sverd...@nokia.com> > C

Re: [v5,6/6] usb: dwc3: Do not set dma coherent mask

t;sriram.d...@nxp.com> Successfully tested on arm64/axxia with DWC3 USB host, XHCIs properly inherit DMA configuration. Therefore: Tested-by: Alexander Sverdlin <alexander.sverd...@nokia.com> > --- > Changes in v5: > - No update > > Changes in v4: > - No update >

Re: [v5,4/6] usb: xhci: use bus->sysdev for DMA configuration

properly inherit DMA configuration. Therefore: Tested-by: Alexander Sverdlin <alexander.sverd...@nokia.com> > --- > Changes in v5: > - No update > > Changes in v4: > - No update > > Changes in v3: > - No update > > Changes in v2: > - Separate out xh

Re: [PATCH] mtd:avoid blktrans_open/release race and avoid insmod ftl.ko deadlock

> > seq_puts(m, "dev:size erasesize name\n"); > - mutex_lock(_table_mutex); > + mtd_table_mutex_lock(); > mtd_for_each_device(mtd) { > seq_printf(m, "mtd%d: %8.8llx %8.8x \"%s\"\n", > mtd->index, (unsigned long long)mtd->size, > mtd->erasesize, mtd->name); > } > - mutex_unlock(_table_mutex); > + mtd_table_mutex_unlock(); > return 0; > } > > diff --git a/drivers/mtd/mtdcore.h b/drivers/mtd/mtdcore.h > index 55fdb8e..cb1d8fa 100644 > --- a/drivers/mtd/mtdcore.h > +++ b/drivers/mtd/mtdcore.h > @@ -3,7 +3,6 @@ > * You should not use them for _anything_ else. > */ > > -extern struct mutex mtd_table_mutex; > > struct mtd_info *__mtd_next_device(int i); > int add_mtd_device(struct mtd_info *mtd); > @@ -21,6 +20,9 @@ void mtd_part_parser_cleanup(struct mtd_partitions *parts); > > int __init init_mtdchar(void); > void __exit cleanup_mtdchar(void); > +extern void mtd_table_mutex_lock(void); > +extern void mtd_table_mutex_unlock(void); > +extern void mtd_table_assert_mutex_locked(void); > > #define mtd_for_each_device(mtd) \ > for ((mtd) = __mtd_next_device(0); \ > -- Best regards, Alexander Sverdlin.

Re: [PATCH] timers: Fix overflow in get_next_timer_interrupt

n tickless core and with following applied: > > sched/nohz: add debugfs control over sched_tick_max_deferment > https://lkml.org/lkml/2013/9/16/499 > > Signed-off-by: Matija Glavinic Pecotic <matija.glavinic-pecotic@nokia.com> Reviewed-by: Alexander Sv

Re: [PATCH 1/9] ARM: ep93xx: allow NULL clock for clk_get_rate

4/1: ep93xx: initial implementation of the > clk_* API") > Cc: Hartley Sweeten <hswee...@visionengravers.com> > Cc: Alexander Sverdlin <alexander.sverd...@gmail.com> > Cc: Russell King <li...@armlinux.org.uk> > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@

Re: [PATCH 02/12] ARM: ep93xx: use ARM_PATCH_PHYS_VIRT

mbol when we don't have to hardcode the address anyway. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Alexander Sverdlin <alexander.sverd...@gmail.com> > --- >  arch/arm/Kconfig | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [1/5] w83627ehf: Use hwmon_device_register_with_info and sensor groups

; > Signed-off-by: Peter Huewe <peterhu...@gmx.de> I've applied the whole series (5 of 5 patches) on top of hwmon-next and tested on Intel D525MW, where the module finds "W83627DHG-P chip at 0x290". The values of all the inputs are exactly the same as back in Linux v4.7.x (when the

Re: [1/5] w83627ehf: Use hwmon_device_register_with_info and sensor groups

; > Signed-off-by: Peter Huewe <peterhu...@gmx.de> I've applied the whole series (5 of 5 patches) on top of hwmon-next and tested on Intel D525MW, where the module finds "W83627DHG-P chip at 0x290". The values of all the inputs are exactly the same as back in Linux v4.7.x (when the

Re: stable-rc/linux-4.4.y build: 199 builds: 13 failed, 186 passed, 13 errors, 4 warnings (v4.4.71-63-g409ebd600970)

fcc as that's best here.  I don't think > > anyone really cares about this driver in 4.4, and if they do, then they > > can speak up :) > > Sounds fine. ep93xx was once an important platform and the chips are > still being sold, but I guess not many users remain. A

Re: [PATCH 00/21] MIPS memblock: Remove bootmem code and switch to NO_BOOTMEM

arch-code coding style. While I'm working on it, you can still > use > the current patchset for some limited tests. Please Cc me in this case, I should be able to test on Octeon MIPS64 platform. -- Best regards, Alexander Sverdlin.

[PATCH] MAINTAINERS: EP93XX: Update maintainership

As agreed with Ryan, change the maintainership. Signed-off-by: Alexander Sverdlin <alexander.sverd...@gmail.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9e984645c4b0..5a248d0f 100644 --- a/MAINTAINERS

Re: [6/8] cris-cryptocop: Delete two variables in cryptocop_ioctl_process()

t they were not read within this function. > Thus remove them. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Reviewed-by: Alexander Sverdlin <alexander.sverd...@gmail.com> > --- > arch/cris/arch-v32/drivers/cryptocop.c | 14 -- > 1 file cha

Re: [PATCH 1/5] cris: nand: Delete an error message for a failed memory allocation in crisv32_nand_flash_probe()

wrapper = kzalloc(sizeof(struct mtd_info_wrapper), GFP_KERNEL); > if (!wrapper) { > - printk(KERN_ERR "Unable to allocate CRISv32 NAND MTD " > - "device structure.\n"); > err = -ENOMEM; > return NULL; > } -- Alexander Sverdlin.

Re: [PATCH 1/5] cris: nand: Delete an error message for a failed memory allocation in crisv32_nand_flash_probe()

On 04/10/17 20:45, SF Markus Elfring wrote: > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Reviewed-by: Alexander Sver

Re: [PATCH 5/5] cris: nand: Split a condition check in crisv32_nand_flash_probe()

Hello Markus, On 04/10/17 20:50, SF Markus Elfring wrote: > * Split a condition check for failed calls of the function "ioremap" > so that the return value in the variable "write_cs" will also be > immediately checked. > > * Adjust jump targets according to the Linux coding style convention.

Re: [PATCH 4/5] cris: nand: Delete an unnecessary local variable in crisv32_nand_flash_probe()

On 04/10/17 20:48, SF Markus Elfring wrote: > The local variable "err" was never read in this function. > Thus remove it. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Reviewed-by: Alexander Sverdlin <alexander.sverd...@gmail.com> > ---

Re: [PATCH v2 6/6] ARM: ep93xx: ts72xx: Add support for BK3 board - ts72xx derivative

sistent alignment... > > Even more. checkpatch.pl did not complained checkpatch.pl wouldn't complain, as there are basically two styles, some people do not align the individual assignments in the structures at all. But I was quite confident in the beginning and now even applied your v3 to the code. And indeed it's unaligned... I even checked with emacs. Still unaligned. -- Alexander Sverdlin.

Re: [PATCH v3 5/6] ARM: ep93xx: ts72xx: cosmetic: Add some description to ts72xx code

*** > > + * IO map > > + > > +*** > > +**/ > > There is also something funny with the patch. The lines above appear to be > getting split incorrectly. That's definitely not the case, I can apply the patch to 4.14 just fine and there is no funny wrapping. But you are right about the rest, it should be re-based. -- Alexander Sverdlin.

Re: [PATCH v2 1/6] ARM: ep93xx: ts72xx: Use DEFINE_RES_MEM macros where applicable

Hi! On 21/11/17 15:31, Lukasz Majewski wrote: > This commit cleans up the code by using dedicated macros instead of > full definitions. > > Signed-off-by: Lukasz Majewski <lu...@denx.de> Acked-by: Alexander Sverdlin <alexander.sverd...@gmail.com> > --- > Changes

Re: [PATCH v2 2/6] ARM: ep93xx: ts72xx: Provide include guards for ts72xx.h file

Hi! On 21/11/17 15:32, Lukasz Majewski wrote: > This commit adds include file guards to ts72xx.h > > Signed-off-by: Lukasz Majewski <lu...@denx.de> Acked-by: Alexander Sverdlin <alexander.sverd...@gmail.com> > --- > Changes for v2: > - None > --- > arch/ar

Re: [PATCH v2 4/6] ARM: ep93xx: ts72xx: Rewrite map IO code to be reusable

Hi! On 21/11/17 15:32, Lukasz Majewski wrote: > The map IO common code has been excluded to be reused by other ts72xx > clones. > > Signed-off-by: Lukasz Majewski <lu...@denx.de> Acked-by: Alexander Sverdlin <alexander.sverd...@gmail.com> > > --- > Changes fo

Re: [PATCH v2 6/6] ARM: ep93xx: ts72xx: Add support for BK3 board - ts72xx derivative

Hello Lukasz, some nitpicking below... On 21/11/17 15:32, Lukasz Majewski wrote: > The BK3 board is a derivative of the ts72xx reference design. > > Signed-off-by: Lukasz Majewski > --- > Changes for v2: > - Place bk3 support code to the ts72xx.c file > --- >

Re: [PATCH v2 3/6] ARM: ep93xx: ts72xx: Rewrite ts72xx_register_flash() to accept parameters

lu...@denx.de> Acked-by: Alexander Sverdlin <alexander.sverd...@gmail.com> > > --- > Changes for v2: > - New patch > --- > arch/arm/mach-ep93xx/ts72xx.c | 20 > 1 file changed, 8 insertions(+), 12 deletions(-) > > diff --git a/arch/arm/mac

Re: [PATCH v5 0/4] ARM: ep93xx: ts72xx: Add support for BK3 board

Hello Linus! On Wed Dec 13 08:34:22 2017 Linus Walleij wrote: > On Tue, Dec 12, 2017 at 12:36 AM, Lukasz Majewski wrote: > Out of curiosity: Liebherr is obviously doing heavy-duty industrial > control systems. Likewise Hartley is doing similar business

Re: [PATCH v5 0/4] ARM: ep93xx: ts72xx: Add support for BK3 board

Hi! On Mon Dec 18 12:55:40 2017 Arnd Bergmann wrote: > > GCC 7.2 is working > > Ah wait, this is still for ep93xx, which is always at least armv4t, > right? So it won't have a problem with the armv4 deprecation anyway, even Correct. -- Alex.

Re: [RFC] MIPS memblock: Remove bootmem code and switch to NO_BOOTMEM

till possess the Octeon MIPS64 > platform to test the patchset? yes, I'd like to test such a serious change on Octeon2. Please include me in the distribution list. -- Best regards, Alexander Sverdlin.

Re: [PATCH 0/4] ARM: ep93xx: ts72xx: Add support for BK3 board

Hello Lukasz! On 17/11/17 00:22, Lukasz Majewski wrote: > This patch series adds support for Liebherr's BK3 board, being > a derivative of TS72XX design. > > This patchset consists of following patches: > > - ts72xx.[c|h] cosmetic cleanup/improvement > - Move the common code for ts72xx and BK3

Re: [PATCH] lockdep: Add missing declaration of 'pr_cont()'

@huawei.com> Your commit brought my attention to the fact that commit 681fbec881 brought a regression, rendering 20fb654ae fix ineffective. But this is not related to your change, which I believe is correct: Reviewed-by: Alexander Sverdlin <alexander.sverd...@gmail.com> > --- >  tools/

Re: [PATCH v4 0/5] ARM: ep93xx: ts72xx: Add support for BK3 board

Hello Hartley, On 05/12/17 19:14, Hartley Sweeten wrote: >> This patch series adds support for Liebherr's BK3 board, being a derivative >> of TS72XX design. >> >> This patchset consists of following patches: >> >> - ts72xx.[c|h] cosmetic cleanup/improvement >> - Rewrite ts72xx.c to be reusable

Re: [PATCH v5 0/4] ARM: ep93xx: ts72xx: Add support for BK3 board

Hi Arnd! On Wed Dec 20 14:14:07 2017 Arnd Bergmann wrote: > > If it will be still possible to build the binary kernel of the same > > size after the conversion, I'm in for testing, otherwise it will not > > fit into Flash any more... > > I think there is an increase in code size

Re: [PATCH v5 0/4] ARM: ep93xx: ts72xx: Add support for BK3 board

Hi! On Wed Dec 20 13:50:28 2017 Arnd Bergmann wrote: > I'm generally more interested in the multiplatform conversion than > the DT conversion, and I think converting this one to multiplatform > isn't actually that hard, and doesn't have a significant risk for > regressions, the

Re: [PATCH 00/14] MIPS: memblock: Switch arch code to NO_BOOTMEM

ly tested startup though. Therefore, Tested-by: Alexander Sverdlin <alexander.sverd...@nokia.com> I've noticed one positive effect I cannot explain -- with almost the same physical memory map I observe almost 2 megabytes more available memory after startup: without patches: root

Re: [PATCH] i2c-mux-reg: Delete an error message for a failed memory allocation in i2c_mux_reg_probe_dt()

On 01/02/18 17:24, SF Markus Elfring wrote: > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Reviewed-by: Alexander Sver

[PATCH 1/3] ftrace: Add module to ftrace_make_call() parameters

ARM support for modules' PLTs will require a module pointer in ftrace_make_call() exactly as ftrace_make_nop() has it. Change the function signature without functional change for now. Signed-off-by: Alexander Sverdlin <alexander.sverd...@nokia.com> --- arch/arm/kernel/ftrace.c

[PATCH 3/3] ftrace: Add MODULE_PLTS support

) [] (load_module) from [] (SyS_finit_module+0x59/0x84) [] (SyS_finit_module) from [] (ret_fast_syscall+0x1/0x18) ---[ end trace e1b64ced7a89adcd ]--- ftrace failed to modify [] 0xe9ef7006 actual: 02:f0:3b:fa ftrace record flags: 0 (0) expected tramp: c0314265 Signed-off-by: Alexander Sverdlin <alexander.sv

[PATCH 0/3] ARM: Implement MODULE_PLT support in FTRACE

: ftrace: don't validate branch via PLT in ftrace_make_nop() But the presented ARM variant has just a half of the footprint in terms of the changed LoCs. It also retains the code validation-before-modification instead of switching it off. Alexander Sverdlin (3): ftrace: Add module

[PATCH 2/3] ARM: PLT: Move struct plt_entries definition to header

No functional change, later it will be re-used in several files. Signed-off-by: Alexander Sverdlin <alexander.sverd...@nokia.com> --- arch/arm/include/asm/module.h | 9 + arch/arm/kernel/module-plts.c | 9 - 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/ar

Re: [PATCH 4/6] mips: factor out RapidIO Kconfig entry

apidIO IP block will need to "select HAS_RAPIDIO" > in the platform-/machine-specific "config ARCH_*" Kconfig entry. > > Cc: Andrew Morton > Cc: Alexander Sverdlin > Cc: John Paul Walters > Cc: linux-m...@linux-mips.org > Cc: linux-kernel@vger.kernel.org &

Re: [PATCH v2] serial: 8250_of: Fix for lack of interrupt support

; defer probe, instead of assuming it. > > Fixes: c58caaab3bf8 ("serial: 8250: of: Defer probe on missing IRQ") > Signed-off-by: John Garry This indeed looks like a proper way to handle both cases: Reviewed-by: Alexander Sverdlin Tested-by: Alexander Sverdlin &g

Re: [PATCH v4 2/2] ARM: ftrace: Add MODULE_PLTS support

bol references, etc). Thus, you still have to use an #ifdef if the code inside the block references symbols that will not exist if the condition is not met." But we can of course ignore it. -- Best regards, Alexander Sverdlin.

Re: [PATCH v4 2/2] ARM: ftrace: Add MODULE_PLTS support

n any case, if you insist, I can try to rework the whole stuff implementing >> module_finalize(). >> > I think it would be much better to use the module_finalize() hook for > this, given that it is only called once already, and all the data you > need is still available. No problem, but some kind of (*) block would still be required, because get_module_plt() has to work after module_finalize() as well as *before* it. So before module_finalize() we would have to dereference pltsec->plt->sh_addr conditionally. > Note that ARM already has such a function, so you'll need to add a > call there, i.e., > > if (IS_ENABLED(CONFIG_ARM_MODULE_PLTS)) > module_plt_alloc_fixed(); > > or something like that. The CONFIG_FTRACE dependency can be kept local > to module-plts.c > -- Best regards, Alexander Sverdlin.

[PATCH v4 0/2] ARM: Implement MODULE_PLT support in FTRACE

modification, save module pointer in struct dyn_arch_ftrace instead (PowerPC way) Alexander Sverdlin (2): ARM: PLT: Move struct plt_entries definition to header ARM: ftrace: Add MODULE_PLTS support arch/arm/include/asm/ftrace.h | 3 +++ arch/arm/include/asm/module.h | 10 +++ arch/arm

[PATCH v4 2/2] ARM: ftrace: Add MODULE_PLTS support

) [] (load_module) from [] (SyS_finit_module+0x59/0x84) [] (SyS_finit_module) from [] (ret_fast_syscall+0x1/0x18) ---[ end trace e1b64ced7a89adcd ]--- ftrace failed to modify [] 0xe9ef7006 actual: 02:f0:3b:fa ftrace record flags: 0 (0) expected tramp: c0314265 Signed-off-by: Alexander Sverdlin <alexander.sv

[PATCH v4 1/2] ARM: PLT: Move struct plt_entries definition to header

No functional change, later it will be re-used in several files. Signed-off-by: Alexander Sverdlin <alexander.sverd...@nokia.com> --- arch/arm/include/asm/module.h | 9 + arch/arm/kernel/module-plts.c | 9 - 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/ar

Re: [PATCH v4 2/2] ARM: ftrace: Add MODULE_PLTS support

e. >> + if (!pltsec->plt_count) >> + prealloc_fixed(pltsec, plt); I'll prepare v5 based on your other comments. -- Best regards, Alexander Sverdlin.

Re: [PATCH v4 2/2] ARM: ftrace: Add MODULE_PLTS support

; > This means that you are relying on get_module_plt() being called at > least once at module load time, which is not guaranteed. This is indeed guaranteed. For FTRACE use case. If it's being called from FTRACE in run time, this would mean there were long calls in this module section, which in turn means, get_module_plt() was called at least once for this module and this section. This doesn't hold in general, though. In any case, if you insist, I can try to rework the whole stuff implementing module_finalize(). -- Best regards, Alexander Sverdlin.

Re: [PATCH v4 2/2] ARM: ftrace: Add MODULE_PLTS support

On 13/03/18 18:39, Ard Biesheuvel wrote: > if (IS_ENABLED(CONFIG_ARM_MODULE_PLTS)) > module_plt_alloc_fixed(); Do you consider this a legal C code if without module-plts.o the function would not exist at all? That's too much relying on optimizer I think... -- Best regards, Ale

Re: [PATCH v3 2/2] ARM: ftrace: Add MODULE_PLTS support

+ plt = pltsec->plt_ent; >> >> - struct plt_entries *plt = (struct plt_entries *)pltsec->plt->sh_addr; >> - int idx = 0; >> + idx = ARRAY_SIZE(fixed_plts); >> + while (idx) >> + if (plt->lit[--idx] == val) >> + return (u32)>ldr[idx]; >> > Same here. -- Best regards, Alexander Sverdlin.

[PATCH v3 2/2] ARM: ftrace: Add MODULE_PLTS support

) [] (load_module) from [] (SyS_finit_module+0x59/0x84) [] (SyS_finit_module) from [] (ret_fast_syscall+0x1/0x18) ---[ end trace e1b64ced7a89adcd ]--- ftrace failed to modify [] 0xe9ef7006 actual: 02:f0:3b:fa ftrace record flags: 0 (0) expected tramp: c0314265 Signed-off-by: Alexander Sverdlin <alexander.sv

[PATCH v3 0/2] ARM: Implement MODULE_PLT support in FTRACE

ARM_MODULE_PLTS is enabled v2: * As suggested by Steven Rostedt, refrain from tree-wide API modification, save module pointer in struct dyn_arch_ftrace instead (PowerPC way) Alexander Sverdlin (2): ARM: PLT: Move struct plt_entries definition to header ARM: ftrace: Add MODULE_PLTS support

[PATCH v3 1/2] ARM: PLT: Move struct plt_entries definition to header

No functional change, later it will be re-used in several files. Change-Id: Icfa32669b3582d713b3ad680c25620d3d4844bdd Signed-off-by: Alexander Sverdlin <alexander.sverd...@nokia.com> --- arch/arm/include/asm/module.h | 9 + arch/arm/kernel/module-plts.c | 9 - 2 files chan

  1   2   3   4   >