Re: [PATCH 1/1] OMAP4: DSS: Add panel for Blaze Tablet boards

Hi, Thanks for looking into if you want you can put me in CC and I can review the next patches (perhaps V2 of the patches) + mutex_lock(tc358765_i2c-xfer_lock); + ret = i2c_transfer(tc358765_i2c-client-adapter, msg, 1); + mutex_unlock(tc358765_i2c-xfer_lock); What about

Re: [PATCH v2 1/1] OMAP4: DSS: Add panel for Blaze Tablet boards

Hi Ruslan, TC358765 is DSI-to-LVDS transmitter from Toshiba, used in OMAP44XX Blaze Tablet and Blaze Tablet2 boards. I think it's fine, just some nitpicks and checkpatch warnings +struct { + struct device *dev; + struct dentry *dir; +} tc358765_debug; Should this be static?

Re: [PATCH 1/1] OMAP4: DSS: Add panel for Blaze Tablet boards

Hi, TC358765 is DSI-to-LVDS transmitter from Toshiba, used in OMAP44XX Blaze Tablet and Blaze Tablet2 boards. I had a really fast look and I have few comments +static int tc358765_read_register(struct omap_dss_device *dssdev, + u16 reg, u32 *val) +{ +

Re: [PATCH v2 1/1] OMAP4: DSS: Add panel for Blaze Tablet boards

+ char name[30]; + char buf[50]; + + if (size = sizeof(buf)) + size = sizeof(buf); what's the point of this? This is a way to limit copied from userspace data by available buffer size, widely used in current kernel sources. Are you implying there is some

Re: [PATCH v5 1/4] mfd: add syscon driver based on regmap

Hi Dong, On Tue, Sep 04, 2012 at 11:20:08AM +0800, Dong Aisheng wrote: +static int __devinit syscon_probe(struct platform_device *pdev) +{ + struct device *dev = pdev-dev; Do we really need this variable? Anyway you are using it only once in the dev_info. + struct device_node *np =

Re: [PATCH v5 1/4] mfd: add syscon driver based on regmap

On Tue, Sep 04, 2012 at 07:46:02PM +0800, Dong Aisheng wrote: On Tue, Sep 04, 2012 at 07:35:45PM +0800, Andi Shyti wrote: Hi Dong, On Tue, Sep 04, 2012 at 11:20:08AM +0800, Dong Aisheng wrote: +static int __devinit syscon_probe(struct platform_device *pdev) +{ + struct device *dev

Re: [PATCH 0/4] cbus/retu drivers to mainline

Koskinen (4): i2c: introduce i2c-cbus driver mfd: introduce retu-mfd driver watchdog: introduce retu_wdt driver input: misc: introduce retu-pwrbutton I had a look to the patches 1, 2 and 4, so for them Reviewed-by: Andi Shyti a...@etezian.org -- To unsubscribe from this list: send

Re: [NEW DRIVER V1 0/7] please comment on this new PMIC driver

Hi Tony, for your very helpful comments on all on the patches in this first submission attempt, I will digest and regurgitate a second attempt as soon as I can. once you have digested and regurgitated :), you could also split the patchset in smaller patches, I would say at least one patch per

[PATCH] btrfs: raid56: avoid double allocation

alloc_rbio frees already bbio and raid_map, therefore they don't need to be freed in case it fails Signed-off-by: Andi Shyti a...@etezian.org --- fs/btrfs/raid56.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c index 0525e13

[PATCH] ext4: extents: len and lblock may be used uninitialized

if ext_debugging is enabled and path[depth].p_ext is NULL, len and lblock are printed non initialized Signed-off-by: Andi Shyti a...@etezian.org --- fs/ext4/extents.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index a618738

Re: [V9fs-developer] [PATCH] net: trans_rdma: remove unused function

Hi, To be more precise, there's a single call to c-trans_mode-cancelled in net/9p/client.c, in p9_client_flush, which is called on subfunction returning -ERESTARTSYS... which never happens as far as I could see. This will be useful once/if we start working on client recovery, though - so

[PATCH] 9p: client: remove unused code and any reference to cancelled function

This patch reverts commit 80b45261a0b263536b043c5ccfc4ba4fc27c2acc which was implementing a 'cancelled' functionality to notify that a cancelled request will not be replied. This implementation was not used anywhere and therefore removed. Signed-off-by: Andi Shyti a...@etezian.org --- include

Re: [PATCH] 9p: client: remove unused code and any reference to cancelled function

Hi David, On Thu, Jul 25, 2013 at 10:54:24AM +0200, Andi Shyti wrote: This patch reverts commit 80b45261a0b263536b043c5ccfc4ba4fc27c2acc which was implementing a 'cancelled' functionality to notify that a cancelled request will not be replied. This implementation was not used anywhere

Re: [PATCH 2/2] cifs: file: initialize oparms.reconnect before using it

Hi Steve, Your patch looks reasonable. Would you repost the patch to linux-cifs mailing list (and add any additional reviewers or testers if you would like if you got feedback)? Thanks for your mail, Actually linux-cifs is on CC and this is the output of get_maintainer: Steve French

[PATCH RESEND] cifs: file: initialize oparms.reconnect before using it

and checks for oparms.reconnect which is not initialized. To avoid this the oparms structure initialization is anticipated before the if statement. This issue has been reported by scan.coverity.com Signed-off-by: Andi Shyti a...@etezian.org --- fs/cifs/file.c | 18 +- 1 file

Re: [PATCH RESEND] cifs: file: initialize oparms.reconnect before using it

+ oparms.tcon = tcon; + oparms.cifs_sb = cifs_sb; + oparms.desired_access = desired_access; + oparms.create_options = create_options; This patch just moves the brokenness around. You're setting .desired_access here to an unintialized variable. create_options also looks like it

[PATCH v2] cifs: file: initialize oparms.reconnect before using it

and checks for oparms.reconnect which is not initialized. This issue has been reported by scan.coverity.com Signed-off-by: Andi Shyti a...@etezian.org --- fs/cifs/file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 1e57f36..7e36ae3 100644 --- a/fs/cifs/file.c

[PATCH] rsxx: core: fix memory leak

if 'copy_from_user' fails, the 'rsxx_cram_write()' function returns without freeing the allocated buffer 'buf'. Free 'buf' before returning. This issue has been reported by scan.coverity.com Signed-off-by: Andi Shyti a...@etezian.org --- drivers/block/rsxx/core.c | 4 +++- 1 file changed, 3

[PATCH v2 1/1] rsxx: core: fix memory leak

Free 'buf' before returning. the 'rsxx_cram_write()' function returns twice without freeing the allocated buffer 'buf' causing a possible memory leak. This issue has been reported by scan.coverity.com Signed-off-by: Andi Shyti a...@etezian.org --- drivers/block/rsxx/core.c | 7 --- 1 file

[PATCH v2 0/1] fix meamleak on rsxx/core.c

Hi, this version is a bit better since it fixes two memleak situations. Andi Andi Shyti (1): rsxx: core: fix memory leak drivers/block/rsxx/core.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) -- 1.8.4.rc2 -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 1/1] net: add dm9620 net usb driver

Hi Joseph, had a fast look... [ ... ] +static int dm9620_set_eeprom(struct net_device *net, + struct ethtool_eeprom *eeprom, u8 *data) +{ + struct usbnet *dev = netdev_priv(net); + int offset = eeprom-offset; + int len = eeprom-len; + int done; + + if

[PATCH] mlx5: qp: variable may be used uninitialized

in the sq_overhead() function, if qp_typ is equal to IB_QPT_RC, size will be used uninitialized. Signed-off-by: Andi Shyti a...@etezian.org --- drivers/infiniband/hw/mlx5/qp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband

[PATCH] u8500_defconfig: allow creation and mounting of devtmpfs

This patch enables CONFIG_DETTMPFS and CONFIG_DEVTMPFS_MOUNT flags for u8500 based devices. In this way it's possible to create a tmpfs/ramfs already in the early stages of the boot, allowing programs like udev/mdev to populate the /dev directory. Signed-off-by: Andi Shyti a...@etezian.org

Re: [[RFC]] scripts/robopatch.pl: the mechanical bride of checkpatch.pl

+# $ scripts/checkpatch.pl WHATEVER /tmpcheckpatch.log ^^ I guess you have a typo here. I actually used this, it doesn't know what msleep is and it fails, so that to go ahead I had to remove the msleep lines from /tmp/checpatch.log. Andi -- To

Re: Use of drivers/platform and matching include?

Hi, As we look at upstreaming more support for the Qualcomm MSM SoCs there are a number of drivers or library like routines that are unique to the MSM platform, we are thinking that putting them under: just a question, is this code the one you have already in codeaurora for

[PATCH] media: cx24117: remove dead code in always 'false' if statement

At this point of the execution in the function cx24117_attach() demod cannot be '0'. In that case the function returns earlier with an error value ('NULL'). Remove the if statement. This error has been reported by scan.coverity.com Signed-off-by: Andi Shyti a...@etezian.org --- drivers/media

[PATCH] media: cx24117: use a valid dev pointer for dev_err printout

Don't use 'state-priv-i2c-dev' reference to device because state is still 'NULL'. Use 'i2c-dev' instead. This bug has been reported by scan.coverity.com Signed-off-by: Andi Shyti a...@etezian.org --- Hi, please apply this patch after my previous patch, forgot to format them together. Thanks

[PATCH 18/19] bh1770glc: Corrected proximity sensor rates

...@gmail.com Signed-off-by: Andi Shyti a...@etezian.org --- drivers/misc/bh1770glc.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/misc/bh1770glc.c b/drivers/misc/bh1770glc.c index 526cdb6..ef1ab49 100644 --- a/drivers/misc/bh1770glc.c +++ b/drivers/misc

[PATCH 07/19] bh1770glc: split read result function

prox_read_result() has been split in two functions: - ps_get_result(): reads the proximity value from the register - prox_read_result(): applies the logic above the proximity value Signed-off-by: Andi Shyti a...@etezian.org --- drivers/misc/bh1770glc.c | 53

[PATCH 08/19] bh1770glc: logic change in the proximity read

the prox0_raw file in the sysfs interface reads the proximity value directly from the register instead of reporting the last read value; in this way userspace applications can have a real time value Signed-off-by: Andi Shyti a...@etezian.org --- drivers/misc/bh1770glc.c |5 + 1 file

[PATCH 04/19] bh1770glc: Added raw lux output file for ALS to sysfs

From: Onur Atilla oati...@gmail.com lux0_raw file gives the raw Ambient Light Sensor (ALS) value, before adjusting it with the calibration coefficients, whereas lux0_inputreturns the calibrated ALS value. Signed-off-by: Onur Atilla oati...@gmail.com Signed-off-by: Andi Shyti a...@etezian.org

[PATCH 02/19] bh1770glc: different glass attenuation parameters

From: Onur Atilla oati...@gmail.com The Ambient Light Sensor (ALS) glass attenuation parameter should be configurable and two new parameters are introduced: als_scf_BH1770 and als_scf_SFH7770. Signed-off-by: Onur Atilla oati...@gmail.com Signed-off-by: Andi Shyti a...@etezian.org --- include

[PATCH 03/19] bh1770glc: lux0_glass_factor lux0_comp_factor on sysfs

From: Onur Atilla oati...@gmail.com Introduced lux0_glass_factor and lux0_comp_factor on sysfs lux0_glass_factor and lux0_sensor_comp_factor are provided as read-only files on the sysfs structure of the bh1770glc optical sensor. Signed-off-by: Onur Atilla oati...@gmail.com Signed-off-by: Andi

[PATCH 00/19] misc: bh1770glc features and fixes

on top of any branch since they don't affect any core code. Thanks, Andi Andi Shyti (7): bh1770glc: added input device interface bh1770glc: removed proximity adjustement bh1770glc: split read result function bh1770glc: logic change in the proximity read bh1770glc: use min_t instead of min

[PATCH 13/19] bh1770glc: Code cleaning and aligning in source code

From: Onur Atilla oati...@gmail.com Removed unused variables and definitions, adjusted some code alignement and removed trailing spaces. Signed-off-by: Onur Atilla oati...@gmail.com Signed-off-by: Andi Shyti a...@etezian.org --- drivers/misc/bh1770glc.c | 55

[PATCH 14/19] bh1770glc: Modified the neutral glass attenuation value

From: Onur Atilla oati...@gmail.com Changed the neutral glass attenuation value from 16384 to 8192. This is for adaptation to the new scaling factor. Signed-off-by: Onur Atilla oati...@gmail.com Signed-off-by: Andi Shyti a...@etezian.org --- include/linux/i2c/bh1770glc.h |4 ++-- 1 file

[PATCH 11/19] bh1770glc: removed lux_read_raw_result() function

lux_raw_result_show() will run directly the lux_get_result() instead of using another support function Signed-off-by: Andi Shyti a...@etezian.org --- drivers/misc/bh1770glc.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/misc/bh1770glc.c b/drivers/misc

[PATCH 17/19] bh1770glc: Implemented switch for interrupt operation

...@gmail.com Signed-off-by: Andi Shyti a...@etezian.org --- drivers/misc/bh1770glc.c | 10 ++ include/linux/i2c/bh1770glc.h |1 + 2 files changed, 11 insertions(+) diff --git a/drivers/misc/bh1770glc.c b/drivers/misc/bh1770glc.c index 383cefe..526cdb6 100644 --- a/drivers/misc

[PATCH 16/19] bh1770glc: Added sanity check for scf

From: Onur Atilla oati...@gmail.com Sensor compensation factor input from the platform is being checked now before use. Signed-off-by: Onur Atilla oati...@gmail.com Signed-off-by: Andi Shyti a...@etezian.org --- drivers/misc/bh1770glc.c | 13 +++-- 1 file changed, 11 insertions(+), 2

[PATCH 05/19] bh1770glc: Removed obsolete offset settings from SFH7770 code

From: Onur Atilla oati...@gmail.com Some obsolete version-dependent coefficient and constant settings were removed out of the sensor detection functions. These values cause unwanted offset between different sensor types. Signed-off-by: Onur Atilla oati...@gmail.com Signed-off-by: Andi Shyti

[PATCH 01/19] bh1770glc: added input device interface

The driver generates an event in /dev/input/ under the name 'bh1770'. It's a switch event where is reported '0' or '1' whenever the sensor detects something crossing the threshold. Signed-off-by: Onur Atilla oati...@gmail.com Signed-off-by: Phil Carmody p...@asdf.org Signed-off-by: Andi Shyti

[PATCH 10/19] bh1770glc: use kstrtoul instead of strict_strtoul

sensor sysfs interface. Signed-off-by: Andi Shyti a...@etezian.org Signed-off-by: Onur Atilla oati...@gmail.com --- drivers/misc/bh1770glc.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/misc/bh1770glc.c b/drivers/misc/bh1770glc.c index bd90eaf

[PATCH 12/19] bh1770glc: Introduced dynamic threshold

. According to the actual status of the proximity interrupt, the threshold is set dynamically using a newly introduced hysteresis value. Hysteresis is a configurable parameter. Signed-off-by: Onur Atilla oati...@gmail.com Signed-off-by: Andi Shyti a...@etezian.org --- drivers/misc/bh1770glc.c

[PATCH 09/19] bh1770glc: use min_t instead of min

Signed-off-by: Andi Shyti a...@etezian.org --- drivers/misc/bh1770glc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/bh1770glc.c b/drivers/misc/bh1770glc.c index 031a9fa..bd90eaf 100644 --- a/drivers/misc/bh1770glc.c +++ b/drivers/misc/bh1770glc.c @@ -273,7

[PATCH 19/19] bh1770glc: Proximity sensor LED current update

...@gmail.com Signed-off-by: Andi Shyti a...@etezian.org --- drivers/misc/bh1770glc.c | 11 ++- include/linux/i2c/bh1770glc.h |1 + 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/misc/bh1770glc.c b/drivers/misc/bh1770glc.c index ef1ab49..0af50bf 100644

[PATCH 06/19] bh1770glc: removed proximity adjustement

proximity sensor doesn't need to be adjusted; removed all the overcode used for the proximity coefficients Signed-off-by: Andi Shyti a...@etezian.org --- drivers/misc/bh1770glc.c | 39 ++- 1 file changed, 2 insertions(+), 37 deletions(-) diff --git

[PATCH 15/19] bh1770glc: Modified scaler variable

From: Onur Atilla oati...@gmail.com Changed all exposed scalers to 8192 (Q13) in order to achieve consistency in the sysfs interface. Signed-off-by: Onur Atilla oati...@gmail.com Signed-off-by: Andi Shyti a...@etezian.org --- drivers/misc/bh1770glc.c |4 ++-- 1 file changed, 2 insertions

[PATCH 0/2] etzkx accelerometer support

, Andi Andi Shyti (2): drivers/misc: etzkx driver for kxcnl/kxtnk accelerometer Documentation: added etzkx driver documentation Documentation/misc-devices/etzkx.txt | 325 + drivers/misc/Kconfig | 12 + drivers/misc/Makefile|1 + drivers/misc/etzkx.c

[PATCH 2/2] Documentation: added etzkx driver documentation

The etzkx driver's documentation contains some basic information about - accelerometer chip overview - driver interfaces - driver usage Signed-off-by: Andi Shyti a...@etezian.org Reviewed-by: Onur Atilla oati...@gmail.com --- Documentation/misc-devices/etzkx.txt | 325

Re: [PATCH 0/2] etzkx accelerometer support

these two patches provide the etzkx device driver which supports the following accelerometers: - Kionix kxcnl - Kionix kxtnk - ST lisn3dsh Support for ST lis3dsh accelerometer is still in progress. The etzkx accelerometers are a kind of devices that are able to do

Re: [PATCH 0/2] etzkx accelerometer support

these two patches provide the etzkx device driver which supports the following accelerometers: - Kionix kxcnl - Kionix kxtnk - ST lisn3dsh Support for ST lis3dsh accelerometer is still in progress. The etzkx accelerometers are a kind of devices that

Re: [PATCH 01/19] bh1770glc: added input device interface

Signed-off-by: Andi Shyti a...@etezian.org --- drivers/misc/bh1770glc.c | 58 +- 1 file changed, 57 insertions(+), 1 deletion(-) Doesn't this mean that this driver is now an input driver, so it shouldn't be using the odd sysfs api, and should

Re: [PATCH 03/19] bh1770glc: lux0_glass_factor lux0_comp_factor on sysfs

Introduced lux0_glass_factor and lux0_comp_factor on sysfs lux0_glass_factor and lux0_sensor_comp_factor are provided as read-only files on the sysfs structure of the bh1770glc optical sensor. You can't add/remove/modify sysfs files without the proper Documentation/ABI changes as

Re: [PATCH 00/19] misc: bh1770glc features and fixes

This patchset contains a collection of new features and fixes for the bh1770glc driver for the BH1770 and SFH7770 proximity and ambient light sensor device. Remind me again why this isn't an drivers/iio/ driver, using that api? Well, the driver is not written by me, I just found it as it

Re: [PATCH 01/19] bh1770glc: added input device interface

The driver generates an event in /dev/input/ under the name 'bh1770'. It's a switch event where is reported '0' or '1' whenever the sensor detects something crossing the threshold. Doesn't this mean that this driver is now an input driver, so it shouldn't be using the odd

Re: Use of drivers/platform and matching include?

just a question, is this code the one you have already in codeaurora for 8974/8226/8626/8610 etc? Yes. Finally, I would say! But you should have done this much earlier so that you could have made the life of your customers easier and maybe they could have helped you on upstreaming the code.

[PATCH] net: trans_rdma: remove unused function

-by: Andi Shyti a...@etezian.org --- net/9p/trans_rdma.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c index 928f2bb..8f68df5 100644 --- a/net/9p/trans_rdma.c +++ b/net/9p/trans_rdma.c @@ -588,17 +588,6 @@ static int rdma_cancel(struct

[PATCH] vga16fb: remove unused variable

From: Andi Shyti andi.sh...@gmail.com This patch gets rid of the following warning: drivers/video/vga16fb.c: In function ‘vga16fb_destroy’: drivers/video/vga16fb.c:1268:26: warning: unused variable ‘dev’ [-Wunused-variable] struct platform_device *dev = container_of(info-device, struct

[PATCH 2/2] cifs: file: initialize oparms.reconnect before using it

and checks for oparms.reconnect which is not initialized. To avoid this the oparms structure initialization is anticipated before the if statement. Signed-off-by: Andi Shyti a...@etezian.org --- fs/cifs/file.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

Re: [PATCH 2/2] cifs: file: initialize oparms.reconnect before using it

This is patch 1/1, not 2/2... messed up with git. Andi On Mon, Jul 22, 2013 at 09:24:00PM +0200, Andi Shyti wrote: In the cifs_reopen_file function, if the following statement is asserted: (tcon-unix_ext cap_unix(tcon-ses) (CIFS_UNIX_POSIX_PATH_OPS_CAP (tcon

[PATCH] fs: bio-integrity: fix possible segmentation fault

free bvec_integrity_pool if it's allocated, not bio_integrity_pool Signed-off-by: Andi Shyti a...@etezian.org --- fs/bio-integrity.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c index 8fb4291..45e944f 100644 --- a/fs/bio-integrity.c

Re: [PATCH 0/2] etzkx accelerometer support

Hi Greg, these two patches provide the etzkx device driver which supports the following accelerometers: Why isn't this a drivers/iio/accel/ driver instead of a misc driver? Please make this an iio driver, then you will be using the correct user/kernel api to talk to your

Re: [PATCH v5 6/8] drivers: soc: add support for exynos SROM driver

On Tue, Oct 20, 2015 at 02:45:37PM +0530, Pankaj Dubey wrote: > This patch adds Exynos SROM controller driver which will handle > save restore of SROM registers during S2R. > > Signed-off-by: Pankaj Dubey ... > +config EXYNOS_SROM > + bool > + depends on ARM

Re: [PATCH v4 6/8] drivers: soc: add support for exynos SROM driver

Hi Pavel, > > AFAIR Fedin was talking about missing functionality, not about adding > > the contribution by himself. So he might add it or he might not. I did > > not receive any commitments from him. > > I am waiting for the driver to be integrated, because i see it's constantly > redesigned.

Re: [PATCH 25/34] clk: s2mps11: Migrate to clk_hw based OF and registration APIs

Hi Stephen, > Now that we have clk_hw based provider APIs to register clks, we > can get rid of struct clk pointers while registering clks in > these drivers, allowing us to move closer to a clear split of > consumer and provider clk APIs. > > Cc: Andi Shyti <andi.sh

Re: [PATCH] spi: add spi_sync_single_transfer wrapper for single spi_transfer

Hi Lars, > > The spi_sync_single_transfer function calls spi_sync_transfer > > with a single spi_transfer element, instead of an array. > > So, what's the advantage of using this as opposed to calling > spi_sync_transfer with a 1 for the number of transfers? Not much, but it keeps the code a

Re: [PATCH] clk: samsung: exynos5433: use clock_ignore_unused flag for SPI3 related clocks

Hi Tomasz, > > The SPI 3 bus uses two clocks, a bus clock and an input clock. > > Do not disable the clocks when unused in order to allow access to > > the SPI 3 device. > > If unused, why would access to SPI 3 device needed? because next I will submit a small driver which uses the SPI3.

Re: [PATCH 1/5] spi: do not fail if the CS line is not connected

Hi Mark, > > > > In this case do not fail and defer to the SPI device drivers the > > > > responsibility to check whether the num-cs is '0'. > > > > A SPI controller always has one chip seelct, it may not be controllable > > > but it's at least logically present. > > > This is true, but there

Re: [PATCH] clk: samsung: exynos5433: use clock_ignore_unused flag for SPI3 related clocks

Hi Tomasz, > >> > The SPI 3 bus uses two clocks, a bus clock and an input clock. > >> > Do not disable the clocks when unused in order to allow access to > >> > the SPI 3 device. > >> > >> If unused, why would access to SPI 3 device needed? > > > > because next I will submit a small driver which

Re: [PATCH] clk: samsung: exynos5433: use clock_ignore_unused flag for SPI3 related clocks

> Unfortunately I have to NAK this patch. Please add proper support for > them to the SPI driver. I agree, this is quite a lazy solution. But your comment is giving me more work than what I was willing to have, also because in this driver the SPI1 is aslo using CLK_IGNORE_UNUSED :) Thanks for

[PATCH] spi: add spi_sync_single_transfer wrapper for single spi_transfer

The spi_sync_single_transfer function calls spi_sync_transfer with a single spi_transfer element, instead of an array. Signed-off-by: Andi Shyti <andi.sh...@samsung.com> --- include/linux/spi/spi.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/include/linux/spi/s

[PATCH v2 4/5] spi: s3c64xx: simplify if statement in prepare_transfer function

The whole function is inside an 'if' statement ("!is_polling(sdd)"). Check the opposite of that statement at the beginning and exit, this way we can have one level less of indentation. Remove the goto paths as they are redundant. Signed-off-by: Andi Shyti <andi.sh...@samsung.com&

[PATCH v2 5/5] spi: s3c64xx: use unsigned type for fifo handling variables

, to be in we will keep the 32 bit size. Signed-off-by: Andi Shyti <andi.sh...@samsung.com> Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- drivers/spi/spi-s3c64xx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/dri

[PATCH v2 1/5] spi: s3c64xx: group the CS signalling writes in a single function

To enable/disable the CS line, the driver performs a writel in the S3C64XX_SPI_SLAVE_SEL registers. Group the register's configuration in a single function. Signed-off-by: Andi Shyti <andi.sh...@samsung.com> --- drivers/spi/spi-s3c64xx.c | 36 ++-- 1 file c

[PATCH v2 0/5] s3c64xx: consider the case of a disconnected CS line and some code rework

he commit messages Thanks, Andi Andi Shyti (5): spi: s3c64xx: group the CS signalling writes in a single function spi: s3c64xx: consider the case when the CS line is not connected spi: s3c64xx: do not configure the device twice spi: s3c64xx: simplify if statement in prepare_transfer fu

[PATCH v2 2/5] spi: s3c64xx: consider the case when the CS line is not connected

) and never disable it. Signed-off-by: Andi Shyti <andi.sh...@samsung.com> --- Documentation/devicetree/bindings/spi/spi-samsung.txt | 3 +++ drivers/spi/spi-s3c64xx.c | 9 - include/linux/platform_data/spi-s3c64xx.h | 1 + 3 files changed, 12 inse

[PATCH v2 3/5] spi: s3c64xx: do not configure the device twice

don't have the imformation about "bit per word" and frequency. Signed-off-by: Andi Shyti <andi.sh...@samsung.com> --- drivers/spi/spi-s3c64xx.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index

[PATCH 0/5] SPI CS line logical change and s3c64xx code rework

. Andi Andi Shyti (5): spi: do not fail if the CS line is not connected spi: s3c64xx: group the CS signalling writes in a single function spi: s3c64xx: consider the case where the CS line is not connected spi: s3c64xx: do not configure the device twice spi: s3c63xx: simplify if statement

[PATCH] clk: samsung: exynos5433: use clock_ignore_unused flag for SPI3 related clocks

From: Jaehoon Chung <jh80.ch...@samsung.com> The SPI 3 bus uses two clocks, a bus clock and an input clock. Do not disable the clocks when unused in order to allow access to the SPI 3 device. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> Signed-off-by: Andi Shyti <andi.sh

[PATCH 5/5] spi: s3c63xx: simplify if statement in prepare_transfer function

The whole function is in an if statement ("!is_polling(sdd)"). Check the opposite of that statement at the beginning and exit, this way we can have a level less of indentation. Remove the goto paths as they are redundant. Signed-off-by: Andi Shyti <andi.sh...@samsung.com> ---

[PATCH 4/5] spi: s3c64xx: do not configure the device twice

the imformation about "bit per word" and frequency. Signed-off-by: Andi Shyti <andi.sh...@samsung.com> --- drivers/spi/spi-s3c64xx.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 3d54c5f

[PATCH 1/5] spi: do not fail if the CS line is not connected

to check whether the num-cs is '0'. Signed-off-by: Andi Shyti <andi.sh...@samsung.com> --- drivers/spi/spi.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 77e6e45..f22dc27 100644 --- a/drivers/spi/spi.c +++ b/d

[PATCH 2/5] spi: s3c64xx: group the CS signalling writes in a single function

To enable/disable the CS line, the driver performs a writel in the S3C64XX_SPI_SLAVE_SEL registers. Put together all the writes in that register in a single function. Signed-off-by: Andi Shyti <andi.sh...@samsung.com> --- drivers/spi/spi-s3c64xx.c | 36 ++---

[PATCH 3/5] spi: s3c64xx: consider the case where the CS line is not connected

When the CS line is not connected, it is not needed to enable or disable the chip selection functionality from the s3c64xx devices. Keep et enable already at the initialization (by writing '0' in the S3C64XX_SPI_SLAVE_SEL register) and never disable it. Signed-off-by: Andi Shyti <andi

Re: [PATCH] spi: add spi_sync_single_transfer wrapper for single spi_transfer

On Fri, Jun 17, 2016 at 12:34:53PM +0100, Mark Brown wrote: > On Fri, Jun 17, 2016 at 09:43:11AM +0900, Andi Shyti wrote: > > > > > The spi_sync_single_transfer function calls spi_sync_transfer > > > > with a single spi_transfer element, instead of an array. >

Re: [PATCH 1/5] spi: do not fail if the CS line is not connected

Hi Mark, > > Some SPI connected devices do not have any CS line connected as > > some devices are alway enabled. Indeed, until now, a common > > workaround was to assign to num_chipselect a -1 value or 255 > > (num_chipselect is unsigned). > > > > In this case do not fail and defer to the SPI

Re: [PATCH v4 0/3] arm64/clk: EXYNOS: Consolidate Exynos7 symbol

n applies on my branch :) Feel free to add Reviewed-by: Andi Shyti <andi.sh...@samsung.com> Andi

Re: [PATCH] rtc: max77686: Cleanup and reduce dmesg output

>device as /dev/rtcX. > > Signed-off-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> Looks good, Reviewed-by: Andi Shyti <andi.sh...@samsung.com> > --- > > Patch rebased on top of Javier's v4: > [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support

Re: [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support

Hi Javier, In case I forgot any, for the whole patchset, Reviewed-by: Andi Shyti <andi.sh...@samsung.com> Andi On Wed, Jan 27, 2016 at 12:36:36AM -0300, Javier Martinez Canillas wrote: > Hello, > > On a recent disussion [0] with Krzysztof Kozlowski and Laxman Dewa

Re: [PATCH v3 02/10] rtc: max77686: Use ARRAY_SIZE() instead of current array length

osg.samsung.com> > Reviewed-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> > Tested-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> Reviewed-by: Andi Shyti <andi.sh...@samsung.com> > --- > > Changes in v3: > - Add Krzysztof Kozlowski's Tested-by tag to patch

Re: [PATCH v3 01/10] rtc: max77686: Fix max77686_rtc_read_alarm() return value

t; > Reviewed-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> > Tested-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> > Acked-by: Laxman Dewangan <ldewan...@nvidia.com> Reviewed-by: Andi Shyti <andi.sh...@samsung.com> > --- > > Changes in v3: > -

Re: [PATCH v3 04/10] rtc: max77686: Use a driver data struct instead hard-coded values

g.samsung.com> > Acked-by: Laxman Dewangan <ldewan...@nvidia.com> Reviewed-by: Andi Shyti <andi.sh...@samsung.com> > --- > > Changes in v3: > - Fix max77686 delay. Suggested by Krzysztof Kozlowski. > - Assign mask to u8 instead of int. Suggested by Krzysztof Kozlowski

Re: [PATCH v3 03/10] rtc: max77686: Use usleep_range() instead of msleep()

Javier Martinez Canillas <jav...@osg.samsung.com> > Reviewed-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> > Tested-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> Reviewed-by: Andi Shyti <andi.sh...@samsung.com> > --- > > Changes in v3: > - Add Kr

Re: [PATCH v3 08/10] rtc: Remove Maxim 77802 driver

: Krzysztof Kozlowski <k.kozlow...@samsung.com> > Acked-by: Laxman Dewangan <ldewan...@nvidia.com> Reviewed-by: Andi Shyti <andi.sh...@samsung.com> > --- > > Changes in v3: > - Add Laxman Dewangan's Acked-by tag to patch #8. > > Changes in v2: > - Add K

Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn()

Hi Javier, > if (tm->tm_year < 100) { > - pr_warn("RTC can't handle year %d. Assume it's 2000.\n", > - 1900 + tm->tm_year); > + dev_warn(info->dev, > + "RTC can't handle year %d. Assume

Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn()

> >>if (tm->tm_year < 100) { > >>- pr_warn("RTC can't handle year %d. Assume it's 2000.\n", > >>- 1900 + tm->tm_year); > >>+ dev_warn(info->dev, > >>+"RTC can't handle year %d. Assume it's

Re: [PATCH v3 06/10] rtc: max77686: Add max77802 support

rt both instead of duplicating a lot of code in 2 drivers. > > Suggested-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> > Acked-by: Laxman Dewangan <ldewan...@nvidia.com> Reviewed-by: Andi Shyti <andi.sh...@sa

Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn()

> > On 01/26/2016 10:22 PM, Andi Shyti wrote: > >> Hi Javier, > >> > >>> if (tm->tm_year < 100) { > >>> -pr_warn("RTC can't handle year %d. Assume it's 2000.\n", > >>> -1900 + tm-&g

Re: [PATCH v2] regulator: s2mps11: Simplify expression used in BUILD_BUG_ON

Hi Krzysztof, > Following BUILD_BUG_ON using a variable fails for some of the compilers > and optimization levels (reported for gcc 4.9): > var = ARRAY_SIZE(s2mps15_regulators); > BUILD_BUG_ON(S2MPS_REGULATOR_MAX < var); > Fix this by using ARRAY_SIZE directly. > > Additionally add

Re: [PATCH v2] regulator: s2mps11: Simplify expression used in BUILD_BUG_ON

> >> Following BUILD_BUG_ON using a variable fails for some of the compilers > >> and optimization levels (reported for gcc 4.9): > >>var = ARRAY_SIZE(s2mps15_regulators); > >>BUILD_BUG_ON(S2MPS_REGULATOR_MAX < var); > >> Fix this by using ARRAY_SIZE directly. > >> > >> Additionally add

  1   2   3   4   5   6   7   8   9   10   >