to calculate the resolution in third
party drivers like hid-multitouch.
This patch also complete the function with additional valid axes.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
Nice, but please see comment below.
drivers/hid/hid-input.c | 11
Hi Henrik,
On Mon, Oct 29, 2012 at 8:05 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
HID spec details special values for the HID field unit exponent.
Basically, the range [0x8..0xf] correspond to [-8..-1].
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
On Mon, Oct 29, 2012 at 8:25 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
Currently, there is no way to know the index of the current field
in the .input_mapping and .event callbacks when this field is inside
an array of HID fields.
This patch forwards this index to the
on the last element
in this array.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@enac.fr
---
drivers/hid/hid-multitouch.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 725d155..95562d8
for this
distinction in hid-multitouch.
We recognize Win8 certified devices from their vendor feature 0xffc5
where Microsoft put a signed blob in the report to check if the device
passed the certification.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
drivers/hid/hid
that the quirk ALWAYS_VALID is taken into account and
also ensures its precedence over the other VALID* quirks.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
drivers/hid/hid-multitouch.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
Since we seem to never actually
Hi Henrik,
On Mon, Oct 29, 2012 at 11:19 PM, Henrik Rydberg rydb...@euromail.se wrote:
On Fri, Oct 26, 2012 at 10:44:24AM +0200, Benjamin Tissoires wrote:
Win 8 specification is much more precise than the Win 7 one.
Moreover devices that need to take certification must be submitted
by the
multitouch protocol.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
drivers/hid/hid-multitouch.c | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
I suppose the idea here is to send position and distance values even
when there is no touch
use it
according to the specification).
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
Documentation/input/event-codes.txt | 7 +++
drivers/hid/hid-input.c | 4
drivers/hid/hid-multitouch.c| 11 +--
include/linux/hid.h
can't remove the 2 usb related headers because the
function mt_resume has a specific patch for usb devices.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
drivers/hid/hid-multitouch.c | 63
++--
1 file changed, 37 insertions(+), 26
Hi Henrik,
On Wed, Oct 31, 2012 at 7:53 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
On Mon, Oct 29, 2012 at 11:19 PM, Henrik Rydberg rydb...@euromail.se wrote:
On Fri, Oct 26, 2012 at 10:44:24AM +0200, Benjamin Tissoires wrote:
Win 8 specification is much more precise than
On Wed, Oct 31, 2012 at 8:16 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
This is a nice feature, useful in many other contexts. As such, I
think it should be defined in the context of the input subsystem, with
a more specific definition added to the documentation. For
of this particular device.
So, if you judge that those two device-specific classes are absolutely
needed (after all, you have the device in your hands), you have my
reviewed-by:
Reviewed-by Benjamin Tissoires benjamin.tissoi...@gmail.com
Thanks,
Benjamin
+ },
+
{ }
};
@@ -893,9
Hi JJ,
On Wed, Oct 3, 2012 at 5:08 AM, Jian-Jhong Ding jj_d...@emc.com.tw wrote:
Hi Benjamin,
I have one little question about __i2chid_command(), please see below.
benjamin.tissoires benjamin.tissoi...@gmail.com writes:
From: Benjamin Tissoires benjamin.tissoi...@enac.fr
Microsoft
of the specification.
This will come when ACPI 5.0 devices will be available.
Once the ACPI part will be done, OEM will not have to declare HID over I2C
devices in their platform specific driver.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@enac.fr
---
Hi,
this is finally my first implementation
Hi Dmitry,
thanks for the review.
On Wed, Oct 3, 2012 at 6:43 PM, Dmitry Torokhov
dmitry.torok...@gmail.com wrote:
Hi Benjamin,
A few random comments...
On Fri, Sep 14, 2012 at 03:41:43PM +0200, benjamin.tissoires wrote:
From: Benjamin Tissoires benjamin.tissoi...@enac.fr
Microsoft
Hi Jean,
Thanks for the comments, the tests and the review. I'm going to try to
answer most of the remarks, so here is the first:
On Sat, Oct 6, 2012 at 10:04 PM, Jean Delvare kh...@linux-fr.org wrote:
Hi Benjamin,
[...]
a
ERROR: hiddev_report_event [drivers/i2c/i2c-hid.ko] undefined!
ERROR:
On Sat, Oct 6, 2012 at 11:39 PM, Stéphane Chatty cha...@enac.fr wrote:
Le 6 oct. 2012 à 23:28, Jiri Kosina a écrit :
On Sat, 6 Oct 2012, Jiri Kosina wrote:
My vote is a clear 3. It took me a few years to kick all users (as
opposed to implementers) of i2c from drivers/i2c and finding them a
,
On Fri, 14 Sep 2012 15:41:43 +0200, benjamin.tissoires wrote:
From: Benjamin Tissoires benjamin.tissoi...@enac.fr
Microsoft published the protocol specification of HID over i2c:
http://msdn.microsoft.com/en-us/library/windows/hardware/hh852380.aspx
This patch introduces an implementation
On Sun, Nov 4, 2012 at 9:54 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
The goal of this patch is to implement in a reliable way Win 8
multitouch protocol (to avoid quirking many devices). Thanks to the
precision they made in the specification, I think it is feasible:
they add
can't remove the 2 usb related headers because the
function mt_resume has a specific patch for usb devices.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
drivers/hid/hid-multitouch.c | 63
++--
1 file changed, 37 insertions
Hi Henrik,
grrr damn new gmail interface, I clicked on the wrong button.
sorry for the noise.
On Mon, Nov 5, 2012 at 2:28 PM, Benjamin Tissoires
benjamin.tissoi...@gmail.com wrote:
Hi Henrik,
On Mon, Nov 5, 2012 at 1:57 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin
On Tue, Oct 30, 2012 at 11:09 AM, Benjamin Tissoires
benjamin.tissoi...@gmail.com wrote:
On Mon, Oct 29, 2012 at 8:25 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
Currently, there is no way to know the index of the current field
in the .input_mapping and .event callbacks when
On Mon, Oct 22, 2012 at 6:07 PM, Dmitry Torokhov
dmitry.torok...@gmail.com wrote:
On Mon, Oct 22, 2012 at 11:47:42AM +0800, Jian-Jhong Ding wrote:
Scott Liu scott@emc.com.tw writes:
+
+struct mt_device {
+ struct mt_slot curdata; /* placeholder of incoming data */
+ __u8
Hi Jiri,
On Fri, Nov 9, 2012 at 4:49 AM, Jiri Kosina jkos...@suse.cz wrote:
On Tue, 16 Oct 2012, Benjamin Tissoires wrote:
--- /dev/null
+++ b/drivers/hid/i2c-hid/i2c-hid.c
...
+static int i2c_hid_alloc_buffers(struct i2c_hid *ihid)
+{
+ /* the worst case is computed from
Hi Jiri,
On Tue, Nov 13, 2012 at 8:47 AM, Jiri Kosina jkos...@suse.cz wrote:
On Wed, 7 Nov 2012, Benjamin Tissoires wrote:
Hi Guys,
here is the third version of this patchset.
I think I included most of Henrik's comments.
Happy reviewing :)
Cheers,
Benjamin
v1 introduction:
So
On 11/09/2012 09:45 AM, Dmitry Torokhov wrote:
Hi Benjamin,
On Wed, Nov 07, 2012 at 05:37:35PM +0100, Benjamin Tissoires wrote:
Win 8 digitizer devices provides the actual scan time computed by the
hardware itself. The value is global to the frame and is not specific
to the multitouch
On 11/07/2012 05:37 PM, Benjamin Tissoires wrote:
Computes the scan time according to the specification.
It also ensures that if the time between two events is greater
than MAX_SCAN_INTERVAL, the scan time will be reset.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
Hi Henrik,
thanks for the review of the patchset. I'll do my best for the next version :)
On Tue, Nov 13, 2012 at 5:42 PM, Henrik Rydberg rydb...@euromail.se wrote:
On Wed, Nov 07, 2012 at 05:37:34PM +0100, Benjamin Tissoires wrote:
Win8 devices supporting hovering must provides InRange HID
Hi Henrik,
On Tue, Nov 13, 2012 at 6:27 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
From: Benjamin Tissoires benjamin.tissoi...@gmail.com
Date: Tue, 13 Nov 2012 15:12:17 +0100
Subject: [PATCH v4] HID: hid-multitouch: forwards MSC_TIMESTAMP
Computes the device timestamp
Hi Henrik,
On Tue, Nov 13, 2012 at 6:33 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
here is the third version of this patchset.
I think I included most of Henrik's comments.
Happy reviewing :)
thanks for the changes :-)
and thanks for the review.
Jiri,
I am fine
On Tue, Nov 13, 2012 at 7:04 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
Why [-1,1] here?
At first, I only used [0,1]. However, it's still the same problem with
the information being kept between the touches:
if you start an application after having touched your device, you
devices will be available.
Once the ACPI part is done, OEM will not have to declare HID over I2C
devices in their platform specific driver.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
Hi Guys,
here is the v2 of the HID over I2C driver.
Changes since v1:
* s/i2chid/i2c_hid
On Sun, Oct 7, 2012 at 9:03 PM, Jean Delvare kh...@linux-fr.org wrote:
On Sun, 7 Oct 2012 18:57:36 +0200, Benjamin Tissoires wrote:
On Sun, Oct 7, 2012 at 4:28 PM, Jean Delvare kh...@linux-fr.org wrote:
On Fri, 14 Sep 2012 15:41:43 +0200, benjamin.tissoires wrote:
+ u16 readRegister
Hi Jiri,
On Tue, Oct 16, 2012 at 10:17 AM, Jiri Slaby jsl...@suse.cz wrote:
On 10/15/2012 10:38 PM, Benjamin Tissoires wrote:
Notes:
{1}: I don't have all the informations in the beginning of the probe
function to
get the real size I need to allocate. So the behavior is to allocate first
is for invalid argument.
So ENODEV is the right return value.
Anyway, thanks for the review.
Cheers,
Benjamin
Benjamin Tissoires benjamin.tissoi...@gmail.com writes:
diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
new file mode 100644
index 000..8b6c31a
--- /dev/null
are also supported through
a patch by Alex Karpenko. The patch also adds support for the 2nd
and 5th generation of the controller, and the menu key on newer
brushed metal remotes.
Tested-by: Fabien André fabien.an...@gmail.com
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
On 04/17/2013 12:30 PM, Oliver Neukum wrote:
On Wednesday 17 April 2013 11:03:09 Benjamin Tissoires wrote:
+static void appleir_remove(struct hid_device *hid)
+{
+ struct appleir *appleir = hid_get_drvdata(hid);
+ del_timer_sync(appleir-key_up_timer);
+ hid_hw_stop(hid
are also supported through
a patch by Alex Karpenko. The patch also adds support for the 2nd
and 5th generation of the controller, and the menu key on newer
brushed metal remotes.
Tested-by: Fabien André fabien.an...@gmail.com
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/hid/hid-debug.c | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
index 094cbcf..1dc8104 100644
--- a/drivers/hid/hid-debug.c
+++ b/drivers
Hi Jiri,
This is a small rework of the HID debugfs.
I encountered a problem with multitouch devices: they have too much usages to
fit into the fixed size output buffer of 512.
So I digg a little, and end up with those 4 patches.
Cheers,
Benjamin
Benjamin Tissoires (4):
HID: debug: break out
116 and an usage
count of 92. The result is that the ring buffer is not big enough to
contain the whole output, giving a partial debug information.
This estimate gives:
- 512 for a regular keyboard
- 524 for a regular mouse
- 2648 for Elan 04f3:0732
Signed-off-by: Benjamin Tissoires benjamin.tissoi
hid_find_max_report() was used both in usbhid and i2c-hid.
Put it in core to avoid code duplication.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/hid/hid-core.c| 29 +
drivers/hid/i2c-hid/i2c-hid.c | 15 +++
drivers
No semantic changes, but hid_dump_report should be in hid-debug.c, not
in hid-core.c
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/hid/hid-core.c| 25 ++---
drivers/hid/hid-debug.c | 30 ++
include/linux/hid
On 04/17/2013 07:44 PM, Jiri Kosina wrote:
On Wed, 17 Apr 2013, Benjamin Tissoires wrote:
Hi Jiri,
This is a small rework of the HID debugfs.
I encountered a problem with multitouch devices: they have too much usages to
fit into the fixed size output buffer of 512.
So I digg a little
for some devices and it adds processing in the
kernel because debugfs returns human readable strings outputs.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
Hi Jiri,
well, this is the patch I mentioned earlier.
I don't think it will break anything, but I don't know how many
On 04/04/2013 09:51 AM, Jiri Kosina wrote:
On Tue, 2 Apr 2013, Benjamin Tissoires wrote:
Since kernel 3.7, it appears that the input registration occured before
the end of magicmouse_setup_input(). This is shown by receiving a lot of
EV_SYN SYN_REPORT 1 instead of normal EV_SYN SYN_REPORT 0
mika.westerb...@linux.intel.com
Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Signed-off-by: Huzefa Kankroliwala huzefa.nomanx.kankroliw...@intel.com
This is based on some old version of the driver though. Could you please
rebase it so that it applies on top of for-next branch
Hi Mika,
On Wed, Apr 3, 2013 at 12:56 PM, Mika Westerberg
mika.westerb...@linux.intel.com wrote:
Instead of open-coding ACPI GPIO resource lookup in each driver, we provide
a helper function analogous to Device Tree version that allows drivers to
specify which GPIO resource they are interested
On Thu, Apr 4, 2013 at 11:38 AM, Mika Westerberg
mika.westerb...@linux.intel.com wrote:
On Thu, Apr 04, 2013 at 11:19:53AM +0200, Benjamin Tissoires wrote:
Hi Mika,
On Wed, Apr 3, 2013 at 12:56 PM, Mika Westerberg
mika.westerb...@linux.intel.com wrote:
Instead of open-coding ACPI GPIO
On Thu, Apr 4, 2013 at 11:57 AM, Mika Westerberg
mika.westerb...@linux.intel.com wrote:
On Thu, Apr 04, 2013 at 11:42:11AM +0200, Benjamin Tissoires wrote:
On Thu, Apr 4, 2013 at 11:38 AM, Mika Westerberg
mika.westerb...@linux.intel.com wrote:
On Thu, Apr 04, 2013 at 11:19:53AM +0200
are also supported through
a patch by Alex Karpenko. The patch also adds support for the 2nd
and 5th generation of the controller, and the menu key on newer
brushed metal remotes.
Tested-by: Fabien André fabien.an...@gmail.com
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
Hi
Hi Jiri,
On 04/09/2013 10:10 PM, Jiri Kosina wrote:
On Mon, 8 Apr 2013, Benjamin Tissoires wrote:
This driver was originally written by James McKenzie, updated by
Greg Kroah-Hartman, further updated by Bastien Nocera, with suspend
support added.
I ported it to the HID subsystem, in order
.input_configured guarantees that the race is not occuring, and that
the call of input_set_events_per_packet(input, 60) is taken into account
by input_register().
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=908604
Reported-and-Tested-By: Clarke Wixon cwi...@usa.net
Signed-off-by: Benjamin
the actual size. Thanks for
fixing it.
I just have one small formatting comment (see below).
Except that, Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Reviewed-by: Mika Westerberg mika.westerb...@linux.intel.com
Signed-off-by: Huzefa Kankroliwala huzefa.nomanx.kankroliw
.
For backward compatibility, we need to add a quirk to request
this behavior.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/hid/hid-input.c | 77
+
include/linux/hid.h | 1 +
2 files changed, 78 insertions(+)
diff
the creation of input devices
for the not used mouse emulation present on Win7 certified devices.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/hid/hid-multitouch.c | 55
1 file changed, 51 insertions(+), 4 deletions(-)
I
On 03/19/2013 10:38 PM, Henrik Rydberg wrote:
Hi Benjamin,
This is not just cosmetics, it can help to write udev and X.org
rules.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/hid/hid-multitouch.c | 24 +++-
1 file changed, 23 insertions
this behavior.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/hid/hid-input.c | 77
+
include/linux/hid.h | 1 +
2 files changed, 78 insertions(+)
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
The tablet udev rule relies on BTN_STYLUS to be set.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/hid/hid-multitouch.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 174..aceaf6c 100644
certified devices.
Since hid-multitouch sets the quirk HID_QUIRK_NO_INPUT_SYNC, we need
to manually send SYN events for pen report too.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/hid/hid-multitouch.c | 66 +---
1 file changed, 62
This is not just cosmetics, it can help to write udev and X.org
rules.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/hid/hid-multitouch.c | 31 ++-
1 file changed, 30 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-multitouch.c
hid-multitouch only handles touch events, so there is no point in
mapping other kind of events.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/hid/hid-multitouch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-multitouch.c b
To implement different methods for pen and touch, the previous
implementation has to be reworked.
This detection of the input attached to the touch sensor is the same
than the one used in mt_report().
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/hid/hid
There is no need to register an input device containing no events.
This allows drivers using the quirk MULTI_INPUT to register one input
per report effectively used.
For backward compatibility, we need to add a quirk to request
this behavior.
Signed-off-by: Benjamin Tissoires benjamin.tissoi
, but the change is quite small (again, tested on my database)
- patch 6 has been reworked, though it's not clear if it's better
- patch 7 has been reworked, the set_bit occurs now in input_configured()
Cheers,
Benjamin
Benjamin Tissoires (7):
HID: input: don't register unmapped input devices
HID
This will allow easier integration of hybrid pen and touch devices.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/hid/hid-multitouch.c | 123 +--
1 file changed, 83 insertions(+), 40 deletions(-)
diff --git a/drivers/hid/hid
() call is far much simpler than the hid-input one as
many of the different tests do not apply to multitouch touchpads.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
Hi guys,
really sorry for that. I forgot that I had in one of my drawer of my desk one
prototype of a touchpad
On Wed, Mar 27, 2013 at 2:11 PM, Jiri Kosina jkos...@suse.cz wrote:
I don't think it's a big deal (to my knowledge, no retail product uses this
feature), but it's still a regression in 3.9.
I am queuing this for 3.9 still, thanks.
Benjamin, just please double-check that the patch is ok as-is
://bugzilla.kernel.org/show_bug.cgi?id=49781
Reported-and-tested-by: Bob Bowles bobjohnbow...@gmail.com
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
Hi guys,
this bug has taken too long to be solved. I managed to figure out the root cause
recently thanks to the work of Jelle
Hi Randy,
On Wed, Mar 6, 2013 at 8:26 PM, Randy Dunlap rdun...@infradead.org wrote:
On 03/05/13 16:50, Stephen Rothwell wrote:
Hi all,
Changes since 20130305:
on i386 and x86_64:
Sorry, it looks like my patches went not very smoothly.
ERROR: usb_control_msg
In the HID drivers tranport cleanup series, I removed the dependency
between hid-holtek and usbhid. This was wrong as hid-holtek.c relies
extensively on usb calls.
This fixes compilation error when CONFIG_USB_SUPPORT is not enabled.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
On Thu, Mar 7, 2013 at 11:09 AM, Jiri Kosina jkos...@suse.cz wrote:
On Thu, 7 Mar 2013, Benjamin Tissoires wrote:
on i386 and x86_64:
Sorry, it looks like my patches went not very smoothly.
ERROR: usb_control_msg [drivers/hid/hid-multitouch.ko] undefined!
I've submitted a new patch
On Thu, Mar 7, 2013 at 11:33 AM, Jiri Kosina jkos...@suse.cz wrote:
On Thu, 7 Mar 2013, Benjamin Tissoires wrote:
You should have at least one other patch for hid-mt:
https://patchwork.kernel.org/patch/2193641/
Ah, right, that one is in my queue as well, sorry for not mentioning it in
my
On Thu, Mar 7, 2013 at 3:26 PM, Jiri Kosina jkos...@suse.cz wrote:
On Wed, 27 Feb 2013, Benjamin Tissoires wrote:
Some drivers send the idle command directly to underlying device,
creating an unwanted dependency on the underlying transport layer.
This patch adds hid_hw_idle() to the interface
On Thu, Mar 7, 2013 at 4:07 PM, Jiri Kosina jkos...@suse.cz wrote:
On Tue, 5 Mar 2013, Benjamin Tissoires wrote:
hid_output_raw_report() makes a direct call to usb_control_msg(). However,
some USB3 boards have shown that the usb device is not ready during the
.probe(). This blocks the entire
On Thu, Nov 29, 2012 at 3:00 PM, Jiri Kosina jkos...@suse.cz wrote:
On Fri, 23 Nov 2012, Benjamin Tissoires wrote:
This just refactors the allocation of hid_input.
No semantic changes.
As this is a generic cleanup, I am taking this one through
for-3.8/upstream branch.
Thanks Jiri.
Sorry
On Tue, Nov 27, 2012 at 9:21 PM, Henrik Rydberg rydb...@euromail.se wrote:
On Fri, Nov 23, 2012 at 04:31:26PM +0100, Benjamin Tissoires wrote:
During the probe, third party drivers can now safely create a new
input devices depending on the parsing of the reports descriptor.
Signed-off
.
I'll try to address all of your comments.
I have a few answers to some of your remarks (I fully agree with all
of the others):
On Mon, 12 Nov 2012 15:42:59 +0100, Benjamin Tissoires wrote:
Microsoft published the protocol specification of HID over i2c:
http://msdn.microsoft.com/en-us/library
On Mon, Dec 3, 2012 at 2:02 PM, Jean Delvare kh...@linux-fr.org wrote:
Hi Benjamin,
On Mon, 3 Dec 2012 12:32:03 +0100, Benjamin Tissoires wrote:
Hi Jean,
On Fri, Nov 30, 2012 at 3:56 PM, Jean Delvare kh...@linux-fr.org wrote:
Hi Benjamin, Jiri,
Sorry for the late review. But better
On Tue, Dec 4, 2012 at 11:31 AM, Jiri Kosina jkos...@suse.cz wrote:
On Mon, 3 Dec 2012, Benjamin Tissoires wrote:
I know that it already have been used by one Nvidia team and by Elan
for internal tests. So I don't know if it's possible to change it now
(though it's not a big deal).
Yes
on the mutex to protect the potential race on .open and
.close, but meanwhile, here is a first batch of patches.
Cheers,
Benjamin
Benjamin Tissoires (14):
HID: i2c-hid: change I2C name
HID: i2c-hid: fix memory corruption due to missing hid declarations
HID: i2c-hid: enhance Kconfig
HID: i2c
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
drivers/hid/i2c-hid/i2c-hid.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
index d6fdb3e..da04948 100644
--- a/drivers/hid/i2c-hid
no I2C driver has i2c in its name. It makes more sense to call this
i2c driver hid.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
drivers/hid/i2c-hid/i2c-hid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c
On Wed, Dec 5, 2012 at 10:59 AM, Jean Delvare kh...@linux-fr.org wrote:
On Tue, 4 Dec 2012 16:27:50 +0100, Benjamin Tissoires wrote:
If i2c_hid_get_report fails, exit i2c_hid_init_report.
The printk log is already called by i2c_hid_get_report, so no need
to add some more printks.
Signed-off
On Tue, Dec 4, 2012 at 10:42 PM, Jean Delvare kh...@linux-fr.org wrote:
On Tue, 4 Dec 2012 16:27:43 +0100, Benjamin Tissoires wrote:
HID descriptors contains 4 bytes of reserved field.
The previous implementation was overriding the next fields in struct i2c_hid.
Signed-off-by: Benjamin
On Wed, Dec 5, 2012 at 11:10 AM, Jean Delvare kh...@linux-fr.org wrote:
On Tue, 4 Dec 2012 16:27:51 +0100, Benjamin Tissoires wrote:
Simplifies i2c_hid_alloc_buffers tests, and makes this function
responsible of the assignment of ihid-bufsize.
The condition for the reallocation
:27 PM, Benjamin Tissoires
benjamin.tissoi...@gmail.com wrote:
The previous memcpy implementation relied on the size advertized by the
device. There were no guarantees that buf was big enough.
Some gymnastic is also required with the +2/-2 to take into account
the first 2 bytes where the total
On Mon, Feb 11, 2013 at 11:13 AM, Mika Westerberg
mika.westerb...@linux.intel.com wrote:
On Fri, Feb 08, 2013 at 03:37:29PM +0100, Benjamin Tissoires wrote:
so, here is the hid drivers cleanup. The aim is to remove as much as possible
direct calls to usbhid for hid drivers. Thus, other
...@linux.intel.com
Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Cheers,
Benjamin
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
, Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Cheers,
Benjamin
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
is HID_GROUP_SENSOR_HUB.
Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com
Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Thanks Mika for this series!
Cheers,
Benjamin
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
On Mon, Feb 11, 2013 at 4:53 PM, Pandruvada, Srinivas
srinivas.pandruv...@intel.com wrote:
This was added to load sensor hub driver on USB plug in without explicit
modprobe.
But with last few changes to remove vendor and product id, we need to do
modprobe this driver.
So removal is OK.
I
stored in
the different fields.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
drivers/hid/hid-core.c | 4
include/linux/hid.h| 2 ++
2 files changed, 6 insertions(+)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 5ae2cb1..b671e4e 100644
as the correct information are packed at the begining of the frame.
Unfortunately, CountactCount is most of the time at the end of the report.
The solution is to pick it when we have the whole report in raw_event.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
drivers/hid/hid
Hi Henrik,
On Sun, Feb 3, 2013 at 2:07 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
so, this is the v2 of the support of win7/8 devices.
Looks like it is getting there, thanks.
Thanks for the review. However, before sending a new patch series, I'd
like to have your answers to
on the values stored in
the different fields.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
---
drivers/hid/hid-core.c | 4
include/linux/hid.h| 2 ++
2 files changed, 6 insertions(+)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index
On Mon, Feb 4, 2013 at 12:42 PM, Henrik Rydberg rydb...@euromail.se wrote:
Hi Benjamin,
Why not an index here?
Just because an index is not sufficient. You need two things: an index
within the field, and the actual field (a pointer to a struct
hid_field). Each .value is local to a field,
On Tue, Feb 5, 2013 at 12:13 PM, Jiri Kosina jkos...@suse.cz wrote:
On Mon, 4 Feb 2013, Henrik Rydberg wrote:
Thanks for the review. However, before sending a new patch series, I'd
like to have your answers to my comments as I mostly disagree on
everything :)
With good reason,
Do you mind if I send the usbhid dependency and the pen+multitouch
series this week, or we are too close to the 3.9 opening window?
Please just send the patches, and let's see whether they will make it for
3.8 or I'll queue (some of) them for 3.9.
Well, I didn't wanted to push them into 3.8
1 - 100 of 4109 matches
Mail list logo
