[PATCH] Staging: wlan-ng: fixed "block comments" warnings

2016-08-06 Thread Claudiu Beznea
This patch fix "block comments use *" warning returned by checkpatch.pl script. Signed-off-by: Claudiu Beznea --- drivers/staging/wlan-ng/hfa384x.h | 234 +++-- drivers/staging/wlan-ng/hfa384x_usb.c | 172 drivers/stagi

[PATCH] Staging: wlan-ng: removed unused code

2016-08-08 Thread Claudiu Beznea
This patch removes unused code from wlan-ng driver. Signed-off-by: Claudiu Beznea --- drivers/staging/wlan-ng/p80211types.h | 43 --- 1 file changed, 43 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211types.h b/drivers/staging/wlan-ng/p80211types.h

[PATCH] Staging: wlan-ng: Improved case statements in p80211req_mibset_mibget()

2016-08-23 Thread Claudiu Beznea
s bits representing the DID item number. To get this item number use P80211DID_ITEM(). Signed-off-by: Claudiu Beznea --- drivers/staging/wlan-ng/p80211req.c | 28 +--- 1 file changed, 9 insertions(+), 19 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211req.c b/drivers/s

[PATCH] Staging: wlan-ng: removed duplicate code in p80211req.c

2016-08-24 Thread Claudiu Beznea
This patch removes duplicate code in p80211req_mibset_mibget() by adding p80211req_handle_action() function. Signed-off-by: Claudiu Beznea --- drivers/staging/wlan-ng/p80211req.c | 41 +++-- 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/drivers

[PATCH] Staging: wlan-ng: removed switch-case statements with macro

2016-08-25 Thread Claudiu Beznea
This patch removes multiple switch-case statements with a new macro. The macro will generate the corresponding bit mask based on the key index received as input. Signed-off-by: Claudiu Beznea --- drivers/staging/wlan-ng/cfg80211.c | 85 ++--- drivers/staging

[PATCH v2] Staging: wlan-ng: removed duplicate code in p80211req.c

2016-08-25 Thread Claudiu Beznea
This patch removes duplicate code in p80211req_mibset_mibget() by adding p80211req_handle_action() function. Changes since v1: Removed prototype of p80211req_handle_action() from the prototype list and add directly the function definition. Signed-off-by: Claudiu Beznea --- drivers/staging/wlan

Re: [PATCH v6 1/1] pwm: mediatek: add MT2712/MT7622 support

2017-10-25 Thread Claudiu Beznea
ne: ---) changes history (these will be ignored by git if placed here), e.g.: Changes in v6: - this and that Changes in v5: - this and that ... Changes in v2: - this and that Other than this it is OK from my point of view. After fixing the things I mentioned, you can add my: Reviewed-

[PATCH] ARM: at91: pm: remove pm_bu initialization in at91_pm_backup_init()

2018-08-08 Thread Claudiu Beznea
There is no need to initialize pm_bu since it is used only if backup mode is selected. In case backup mode initialization fails (which means pm_bu is invalid) the ULP0 mode will be selected. Signed-off-by: Claudiu Beznea --- arch/arm/mach-at91/pm.c | 3 --- 1 file changed, 3 deletions(-) diff

Re: [PATCH v2] mtd: atmel-quadspi: add suspend/resume hooks

2018-06-21 Thread Claudiu Beznea
Hi Marek, On 19.06.2018 04:28, Marek Vasut wrote: > On 06/18/2018 02:00 PM, Claudiu Beznea wrote: >> >> >> On 18.06.2018 12:53, Marek Vasut wrote: >>> On 06/18/2018 11:49 AM, Boris Brezillon wrote: >>>> Hi Claudiu, >>>> >>>> The

[RESEND PATCH v5 3/9] pwm: cros-ec: populate PWM mode in of_xlate function

2018-08-28 Thread Claudiu Beznea
Populate PWM mode in of_xlate function to avoid pwm_apply_state() failure. Signed-off-by: Claudiu Beznea --- drivers/pwm/pwm-cros-ec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/pwm-cros-ec.c b/drivers/pwm/pwm-cros-ec.c index 9c13694eaa24..78d28d60a468 100644 --- a/drivers

[PATCH 0/6] shutdown procedure verification for SAMA5D2

2018-08-30 Thread Claudiu Beznea
Hi, Patch 1 from this series implement a fix for shutdown procedure for SAMA5D2. The rest of the patch are improvements as follows: patch 2 - use only one function for poweroff patches 3-6 - cosmetic improvements The patches are based on latest sys-reset/for-next [1]. Thank you, Claudiu Beznea

[PATCH 2/6] power: reset: at91-poweroff: use only one poweroff function

2018-08-30 Thread Claudiu Beznea
Use only one poweroff function for sama5d2 and adapt it to work for both scenarios (having LPDDR or not). Signed-off-by: Claudiu Beznea --- drivers/power/reset/at91-sama5d2_shdwc.c | 29 - 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/drivers/power

[PATCH 1/6] power: reset: at91-poweroff: switch to slow clock before shutdown

2018-08-30 Thread Claudiu Beznea
at a much lower low frequency. To solve this switch the master clock to slock clock just before writing shutdown command to shutdown controller. Signed-off-by: Claudiu Beznea Suggested-by: Patrice Vilchez --- arch/arm/mach-at91/pm_suspend.S | 8 drivers/power/reset/at91

[PATCH 4/6] power: reset: at91-poweroff: make sclk part of struct shdwc

2018-08-30 Thread Claudiu Beznea
Make sclk part of struct shdwc to have all the data specific to SHDWC grouped together in one structure. Signed-off-by: Claudiu Beznea --- drivers/power/reset/at91-sama5d2_shdwc.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/power/reset/at91

[PATCH 5/6] power: reset: at91-poweroff: rename at91_shdwc_base member of struct shdwc

2018-08-30 Thread Claudiu Beznea
Rename at91_shdwc_base member of struct shdwc to shdwc_base. There is already an "at91" string in at91_shdwc object. Signed-off-by: Claudiu Beznea --- drivers/power/reset/at91-sama5d2_shdwc.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

[PATCH 6/6] power: reset: at91-poweroff: do not procede if at91_shdwc is allocated

2018-08-30 Thread Claudiu Beznea
There should be only one instance of struct shdwc in the system. This is referenced through at91_shdwc. Return in probe if at91_shdwc is already allocated. Signed-off-by: Claudiu Beznea --- drivers/power/reset/at91-sama5d2_shdwc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers

[PATCH 3/6] power: reset: at91-poweroff: make mpddrc_base part of struct shdwc

2018-08-30 Thread Claudiu Beznea
Make mpddrc_base part of struct shdwc since there is also only one instance of struct shdwc *at91_shdwc in system and to have all data specific to SHDWC grouped together. Signed-off-by: Claudiu Beznea --- drivers/power/reset/at91-sama5d2_shdwc.c | 19 ++- 1 file changed, 10

Re: [PATCH v6 3/3] ARM: dts: at91: sama5d2 Xplained: add pin muxing for I2S

2018-07-30 Thread Claudiu Beznea
: status = "disabled" and if there are pin conflicts with other controllers to put a mark in there, something like: status = "disabled"; /* Conflict with X */ I'm seeing that i2s1 is in conflict with sdmmc1 and spi0. Thank you, Claudiu B

[PATCH] ARM: dts: at91: fix typo for PIN_PB22

2018-07-11 Thread Claudiu Beznea
Fix typo for PIN_PB22 on TD function. Signed-off-by: Claudiu Beznea --- arch/arm/boot/dts/sama5d2-pinfunc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/sama5d2-pinfunc.h b/arch/arm/boot/dts/sama5d2-pinfunc.h index e57191fb83de..ac61491c9d7f 100644

Re: [PATCH v2 10/16] pwm: Add PWM modes

2018-01-23 Thread Claudiu Beznea
On 22.01.2018 20:12, Rob Herring wrote: > On Mon, Jan 22, 2018 at 2:54 AM, Claudiu Beznea > wrote: >> >> >> On 20.01.2018 00:34, Rob Herring wrote: >>> On Fri, Jan 12, 2018 at 04:22:57PM +0200, Claudiu Beznea wrote: >>>> Define a macros fo

Re: [PATCH v2 10/16] pwm: Add PWM modes

2018-01-23 Thread Claudiu Beznea
On 23.01.2018 17:21, Rob Herring wrote: > On Tue, Jan 23, 2018 at 4:40 AM, Claudiu Beznea > wrote: >> >> >> On 22.01.2018 20:12, Rob Herring wrote: >>> On Mon, Jan 22, 2018 at 2:54 AM, Claudiu Beznea >>> wrote: >>>> >>>> >&

Re: [PATCH] drivers: pwm: pwm-atmel: implement suspend/resume functions

2018-01-11 Thread Claudiu Beznea
+0300 >>>> m18063 wrote: >>>> >>>>> Hi Boris, >>>>> >>>>> On 10.04.2017 17:35, Boris Brezillon wrote: >>>>>> On Mon, 10 Apr 2017 17:20:20 +0300 >>>>>> Claudiu Beznea wrote: >>

Re: [PATCH v1 2/4] ARM: PWM: add allwinner sun8i R40/V40/T3 pwm support.

2018-01-11 Thread Claudiu Beznea
On 11.01.2018 13:32, hao_zhang wrote: > This patch add allwinner sun8i R40/V40/T3 pwm support. > > Signed-off-by: hao_zhang > --- > drivers/pwm/Kconfig | 10 ++ > drivers/pwm/Makefile| 1 + > drivers/pwm/pwm-sun8i-r40.c | 394 > >

[PATCH v2 00/16] extend PWM framework to support PWM modes

2018-01-12 Thread Claudiu Beznea
es on atmel SAMA5D2 SoC. Thank you, Claudiu Beznea [1] https://www.spinics.net/lists/arm-kernel/msg580275.html Changes in v2: - remove of_xlate and of_pwm_n_cells and use generic functions to pharse DT inputs; this is done in patches 1, 2, 3, 4, 5, 6, 7 of this series; this will make easy the a

[PATCH v2 05/16] ARM: dts: clps711x: update pwm-cells

2018-01-12 Thread Claudiu Beznea
Update pwm-cells to 2 to allow initialization of channel number an period. Cc: Alexander Shiyan Signed-off-by: Claudiu Beznea --- arch/arm/boot/dts/ep7209.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/ep7209.dtsi b/arch/arm/boot/dts/ep7209.dtsi

[PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-12 Thread Claudiu Beznea
translated differently the "pwms" bindings; the "pwms" bindings now are generic to all drivers and all drivers should provide them in the format described in pwm documentation). Cc: Thierry Reding Cc: Mike Dunn Cc: Brian Norris Cc: Alexander Shiyan Signed-off-by: Claudiu Bez

[PATCH v2 08/16] drivers: pwm: core: extend PWM framework with PWM modes

2018-01-12 Thread Claudiu Beznea
channel will have associated a mode in the PWM state. Proper helper functions were added to get/set PWM mode. The mode could also be set from DT. Only modes registered for PWM chip could be set for a PWM channel. Signed-off-by: Claudiu Beznea --- drivers/pwm/core.c | 62

[PATCH v2 07/16] arm64: dts: rockchip: update pwm-cells

2018-01-12 Thread Claudiu Beznea
Update pwm-cells to 2 to allow initialization of channel number an period. Cc: Brian Norris Signed-off-by: Claudiu Beznea --- arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions

[PATCH v2 11/16] pwm: add documentation for PWM modes

2018-01-12 Thread Claudiu Beznea
Add documentation for PWM normal and complementary modes. Signed-off-by: Claudiu Beznea --- Documentation/devicetree/bindings/pwm/pwm.txt | 17 ++-- Documentation/pwm.txt | 29 +-- 2 files changed, 42 insertions(+), 4 deletions

[PATCH v2 12/16] pwm: atmel: add pwm capabilities

2018-01-12 Thread Claudiu Beznea
Add pwm capabilities to Atmel PWM controllers. Signed-off-by: Claudiu Beznea --- drivers/pwm/pwm-atmel.c | 58 +++-- 1 file changed, 37 insertions(+), 21 deletions(-) diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c index 32427d2b7877

[PATCH v2 15/16] pwm: add documentation for pwm push-pull mode

2018-01-12 Thread Claudiu Beznea
Add documentation for PWM push-pull mode. Signed-off-by: Claudiu Beznea --- Documentation/devicetree/bindings/pwm/pwm.txt | 8 +++- Documentation/pwm.txt | 18 ++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree

[PATCH v2 16/16] pwm: atmel: add push-pull mode support

2018-01-12 Thread Claudiu Beznea
Add support for PWM push-pull mode. This is only supported by SAMA5D2 SoCs. Signed-off-by: Claudiu Beznea --- drivers/pwm/pwm-atmel.c | 38 ++ 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c

[PATCH v2 14/16] pwm: add push-pull mode

2018-01-12 Thread Claudiu Beznea
Add macro for push-pull mode to be used in DT. Signed-off-by: Claudiu Beznea --- include/dt-bindings/pwm/pwm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/dt-bindings/pwm/pwm.h b/include/dt-bindings/pwm/pwm.h index b8617431f8ec..c6365807c30d 100644 --- a/include/dt-bindings/pwm

[PATCH v2 13/16] drivers: pwm: core: add push-pull mode support

2018-01-12 Thread Claudiu Beznea
Add push-pull mode support in PWM code. In push-pull mode the channels outputs has same polarity and the edges are complementary delayed for one period. Signed-off-by: Claudiu Beznea --- drivers/pwm/sysfs.c | 2 ++ include/linux/pwm.h | 9 +++-- 2 files changed, 9 insertions(+), 2 deletions

[PATCH v2 10/16] pwm: Add PWM modes

2018-01-12 Thread Claudiu Beznea
Define a macros for PWM modes to be used by device tree sources. Signed-off-by: Claudiu Beznea --- include/dt-bindings/pwm/pwm.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/dt-bindings/pwm/pwm.h b/include/dt-bindings/pwm/pwm.h index ab9a077e3c7d..b8617431f8ec 100644 --- a

[PATCH v2 09/16] drivers: pwm: core: add PWM mode to pwm_config()

2018-01-12 Thread Claudiu Beznea
Add PWM mode to pwm_config() function. The drivers which uses pwm_config() were adapted to this change. Signed-off-by: Claudiu Beznea --- arch/arm/mach-s3c24xx/mach-rx1950.c | 5 +++-- drivers/bus/ts-nbus.c| 2 +- drivers/clk/clk-pwm.c| 3 ++- drivers/gpu/drm

[PATCH v2 04/16] pwm: clps711x: update documentation regarding pwm-cells

2018-01-12 Thread Claudiu Beznea
pwm-cells should be at least 2 to provide channel number and period value. Cc: Alexander Shiyan Signed-off-by: Claudiu Beznea --- Documentation/devicetree/bindings/pwm/cirrus,clps711x-pwm.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree

[PATCH v2 06/16] ARM: dts: pxa: update pwm-cells

2018-01-12 Thread Claudiu Beznea
Update pwm-cells to 2 to allow initialization of channel number an period. Signed-off-by: Claudiu Beznea --- arch/arm/boot/dts/pxa25x.dtsi | 4 ++-- arch/arm/boot/dts/pxa27x.dtsi | 8 arch/arm/boot/dts/pxa3xx.dtsi | 8 3 files changed, 10 insertions(+), 10 deletions(-) diff

[PATCH v2 03/16] pwm: cros-ec: update documentation regarding pwm-cells

2018-01-12 Thread Claudiu Beznea
pwm-cells should be at least 2 to provide channel number and period value. Cc: Brian Norris Signed-off-by: Claudiu Beznea --- Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings

[PATCH v2 02/16] pwm: pxa: update documentation regarding pwm-cells

2018-01-12 Thread Claudiu Beznea
pwm-cells should be at least 2 to provide channel number and period value. Cc: Mike Dunn Signed-off-by: Claudiu Beznea --- Documentation/devicetree/bindings/pwm/pxa-pwm.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pwm/pxa

Re: [PATCH v2 02/16] pwm: pxa: update documentation regarding pwm-cells

2018-01-22 Thread Claudiu Beznea
On 20.01.2018 00:30, Rob Herring wrote: > On Fri, Jan 12, 2018 at 04:22:49PM +0200, Claudiu Beznea wrote: >> pwm-cells should be at least 2 to provide channel number and period value. >> >> Cc: Mike Dunn >> Signed-off-by: Claudiu Beznea >> --- >> Do

Re: [PATCH v2 11/16] pwm: add documentation for PWM modes

2018-01-22 Thread Claudiu Beznea
On 20.01.2018 00:39, Rob Herring wrote: > On Fri, Jan 12, 2018 at 04:22:58PM +0200, Claudiu Beznea wrote: >> Add documentation for PWM normal and complementary modes. > > This and the previous patch can be combined. OK > >> >> Signed-off-by: Claudiu Beznea >&

Re: [PATCH v2 10/16] pwm: Add PWM modes

2018-01-22 Thread Claudiu Beznea
On 20.01.2018 00:34, Rob Herring wrote: > On Fri, Jan 12, 2018 at 04:22:57PM +0200, Claudiu Beznea wrote: >> Define a macros for PWM modes to be used by device tree sources. >> >> Signed-off-by: Claudiu Beznea >> --- >> include/dt-bindings/pwm/pwm.h | 3 +++

Re: [PATCH 1/3] clocksource: timer-dm: Check prescaler value

2018-01-22 Thread Claudiu Beznea
On 17.01.2018 23:47, Ladislav Michl wrote: > Invalid value silently disables use of the prescaler. > Use -1 explicitely for that purpose and error out on > invalid value. > > Signed-off-by: Ladislav Michl > --- > drivers/clocksource/timer-dm.c |4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH 2/3] pwm: pwm-omap-dmtimer: Fix frequency when using prescaler

2018-01-22 Thread Claudiu Beznea
On 17.01.2018 23:47, Ladislav Michl wrote: > Prescaler setting is currently not taken into account. > Fix that by introducing freq member variable and initialize > it at device probe time. This also avoids frequency > recomputing at each pwm configure time. > > Signed-off-by: Ladislav Michl > -

Re: [PATCH 3/3] clocksource: timer-dm: Make unexported functions static

2018-01-22 Thread Claudiu Beznea
On 17.01.2018 23:48, Ladislav Michl wrote: > As dmtimer no longer exports functions, make those previously > exported static. > > Signed-off-by: Ladislav Michl > --- > Note: only those functions assigned to timer ops are made static >as some others will be needed later for event captur

Re: [PATCH 1/3] clocksource: timer-dm: Check prescaler value

2018-01-22 Thread Claudiu Beznea
On 22.01.2018 11:59, Ladislav Michl wrote: > On Mon, Jan 22, 2018 at 11:00:15AM +0200, Claudiu Beznea wrote: >> >> >> On 17.01.2018 23:47, Ladislav Michl wrote: >>> Invalid value silently disables use of the prescaler. >>> Use -1 explicitely for that pur

Re: [PATCH v6 08/10] pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops

2018-01-08 Thread Claudiu Beznea
On 02.01.2018 12:09, Keerthy wrote: > Adapt driver to utilize dmtimer pdata ops instead of pdata-quirks. > > Signed-off-by: Keerthy > Tested-by: Ladislav Michl > --- > drivers/pwm/pwm-omap-dmtimer.c | 39 ++- > 1 file changed, 22 insertions(+), 17 deletions

Re: [PATCH v6 08/10] pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops

2018-01-08 Thread Claudiu Beznea
On 08.01.2018 16:44, Neil Armstrong wrote: > On 08/01/2018 15:33, Keerthy wrote: >> >> >> On Monday 08 January 2018 02:14 PM, Claudiu Beznea wrote: >>> >>> >>> On 02.01.2018 12:09, Keerthy wrote: >>>> Adapt driver to utilize dmtime

Re: [PATCH v2 03/16] pwm: cros-ec: update documentation regarding pwm-cells

2018-01-17 Thread Claudiu Beznea
On 15.01.2018 11:01, Claudiu Beznea wrote: > > > On 12.01.2018 20:31, Brian Norris wrote: >> On Fri, Jan 12, 2018 at 04:22:50PM +0200, Claudiu Beznea wrote: >>> pwm-cells should be at least 2 to provide channel number and period value. >> >> Nacked-by: Bria

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-18 Thread Claudiu Beznea
On 18.01.2018 01:14, Brian Norris wrote: > On Tue, Jan 16, 2018 at 10:24:59AM +0200, Claudiu Beznea wrote: >> Please explain me further. From this I understand, as a general rule, >> that the device tree binaries from, e.g. 3 years ago, should be >> compatible with, e.g. t

Re: [PATCH v2 03/16] pwm: cros-ec: update documentation regarding pwm-cells

2018-01-18 Thread Claudiu Beznea
On 18.01.2018 01:10, Brian Norris wrote: > On Wed, Jan 17, 2018 at 10:29:53AM +0200, Claudiu Beznea wrote: >> With these changes, if pwm-cells=1 then only PWM-channel will be parsed, > > I'm not sure if I'm understanding you correctly but...no. If cells is 1, >

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-15 Thread Claudiu Beznea
Hi Boris, Thanks for your review. See below my answers. On 12.01.2018 20:35, Brian Norris wrote: > Hi, > > On Fri, Jan 12, 2018 at 04:22:48PM +0200, Claudiu Beznea wrote: >> Remove of_pwm_simple_xlate() and of_pwm_xlate_with_flags() functions >> and add of_pwm_xlate() which

Re: [PATCH v2 03/16] pwm: cros-ec: update documentation regarding pwm-cells

2018-01-15 Thread Claudiu Beznea
On 12.01.2018 20:31, Brian Norris wrote: > On Fri, Jan 12, 2018 at 04:22:50PM +0200, Claudiu Beznea wrote: >> pwm-cells should be at least 2 to provide channel number and period value. > > Nacked-by: Brian Norris > > We don't control the period from the kernel; only

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-15 Thread Claudiu Beznea
On 15.01.2018 10:41, Claudiu Beznea wrote: > Hi Boris, s/Boris/Brian > > Thanks for your review. See below my answers. > > On 12.01.2018 20:35, Brian Norris wrote: >> Hi, >> >> On Fri, Jan 12, 2018 at 04:22:48PM +0200, Claudiu Beznea wrote: >

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-16 Thread Claudiu Beznea
On 15.01.2018 22:27, Andy Shevchenko wrote: > On Mon, Jan 15, 2018 at 10:41 AM, Claudiu Beznea > wrote: > >> For this driver, the PWM bindings were changed (I did a grep by >> "google,cros-ec-pwm" >> and located only: >> arch/arm64/boot/dts/rockchip/

Re: [PATCH v2 01/16] drivers: pwm: core: use a single of xlate function

2018-01-16 Thread Claudiu Beznea
On 16.01.2018 11:07, Neil Armstrong wrote: > On 12/01/2018 15:22, Claudiu Beznea wrote: >> Remove of_pwm_simple_xlate() and of_pwm_xlate_with_flags() functions >> and add of_pwm_xlate() which is used in all cases no mather if the OF >> bindings are with PWM flags or not. T

Re: [PATCH] staging: wilc1000: replace kmalloc + memcpy with kmemdup

2018-03-27 Thread Claudiu Beznea
On 26.03.2018 20:16, Colin King wrote: > From: Colin Ian King > > Replace several allocation and memcpys with kmemdup and add in some > missing memory allocation failure checks. Also fix an incorrect > -EFAULT return with -ENOMEM. > > Signed-off-by: Colin Ian King > --- > drivers/staging/w

Re: [PATCH] staging: wilc1000: Remove unnecessary braces {} around single statement block

2018-04-12 Thread Claudiu Beznea
On 10.04.2018 17:49, Eyal Ilsar wrote: > Remove unnecessary braces {} around an 'if' statement block with a single > statement. Issue found by checkpatch. You should add an empty line before "Signed-off" line as stated in [1]. I would also add a space b/w your name and your email in Signed-off

Re: [PATCH v2] staging: wilc1000: Remove unnecessary braces {} around single statement block

2018-04-12 Thread Claudiu Beznea
On 12.04.2018 10:59, Eyal Ilsar wrote: > Remove unnecessary braces {} around an 'if' statement block with a single > statement. Issue found by checkpatch. > > Signed-off-by: Eyal Ilsar Reviewed-by: Claudiu Beznea > --- > Added an empty line before the 

Re: [PATCH v2] mtd: atmel-quadspi: add suspend/resume hooks

2018-06-18 Thread Claudiu Beznea
f > there could be some problem. Hi Marek, I tested only with read/writes while suspending, simple scripts, but not having ubifs mounted on QSPI NOR. I will double check also with ubifs mounted on QSPI NOR and come back with the results. Thank you, Claudiu > >> Thanks, >> >&g

Re: [PATCH] arm/mach-at91/pm: Do not double put the device node

2018-08-16 Thread Claudiu Beznea
r_exit(&i); return dev; } So, I think a put_device(&pdev->dev) has to be called in at91_pm_config_ws() instead of of_node_put(np). My bad! Thank you, Claudiu Beznea >> I detect the issue with the help of Coccinelle. &

Re: [PATCH] ARM: dts: at91: fix typo for PIN_PB22

2018-07-16 Thread Claudiu Beznea
Hi Ludovic, On 12.07.2018 09:30, Ludovic Desroches wrote: > Hi Claudiu, > > On Wed, Jul 11, 2018 at 07:25:37PM +0300, Claudiu Beznea wrote: >> Fix typo for PIN_PB22 on TD function. > > In fact, this typo is present in several places in this file. It could > be worth fix

[PATCH 3/4] ARM: at91: pm: add PMC fast startup registers defines

2018-07-17 Thread Claudiu Beznea
Add PMC fast startup registers defines. Signed-off-by: Claudiu Beznea --- include/linux/clk/at91_pmc.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/linux/clk/at91_pmc.h b/include/linux/clk/at91_pmc.h index 4ea2cbf9b50d..931ab05f771d 100644 --- a/include/linux/clk

[PATCH 1/4] ARM: at91: pm: Use ULP0 naming instead of slow clock

2018-07-17 Thread Claudiu Beznea
-wenyou.y...@atmel.com Signed-off-by: Claudiu Beznea --- arch/arm/mach-at91/pm.c | 18 +- arch/arm/mach-at91/pm.h | 3 ++- arch/arm/mach-at91/pm_suspend.S | 12 ++-- 3 files changed, 17 insertions(+), 16 deletions(-) diff --git a/arch/arm/mach-at91/pm.c b/arch

[PATCH 2/4] ARM: at91: pm: Add ULP1 mode support

2018-07-17 Thread Claudiu Beznea
: Wenyou Yang Signed-off-by: Ludovic Desroches [claudiu.bez...@microchip.com: aligned with 4.18-rc1] Signed-off-by: Claudiu Beznea --- arch/arm/mach-at91/pm.c | 1 + arch/arm/mach-at91/pm.h | 3 +- arch/arm/mach-at91/pm_suspend.S | 142

[PATCH 0/4] rework ULP1 patches

2018-07-17 Thread Claudiu Beznea
o ULP modes. Patch 1/4: replaces slow clock with ULP0 Patch 2/4: is the Wenyou's patch wich adds ULP1 support Patch 3/4: is defining PMC fast startup registers The patches were based on v4.18-rc1. [1] https://patchwork.kernel.org/patch/8595091/ Claudiu Beznea (3): ARM: at91: pm: Use U

[PATCH 4/4] ARM: at91: pm: configure wakeup sources for ULP1 mode

2018-07-17 Thread Claudiu Beznea
was also used in case backup mode initialization failed). Signed-off-by: Claudiu Beznea --- arch/arm/mach-at91/pm.c | 165 +--- 1 file changed, 143 insertions(+), 22 deletions(-) diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c index

Re: [PATCH 4/4] ARM: at91: pm: configure wakeup sources for ULP1 mode

2018-07-17 Thread Claudiu Beznea
On 17.07.2018 13:45, Alexandre Belloni wrote: > Hi, > > On 17/07/2018 11:26:57+0300, Claudiu Beznea wrote: >> Since for ULP1 PM mode of SAMA5D2 the wakeup sources are limited and >> well known add a method to check if these wakeup sources are defined by >> user (

[RESEND PATCH] ARM: at91: pm: configure wakeup sources for ULP1 mode

2018-07-17 Thread Claudiu Beznea
was also used in case backup mode initialization failed). Signed-off-by: Claudiu Beznea --- arch/arm/mach-at91/pm.c | 168 +--- 1 file changed, 146 insertions(+), 22 deletions(-) diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c index

[PATCH v2] ARM: dts: at91: fix typos for SSC TD functions

2018-07-17 Thread Claudiu Beznea
Fix typo for TD function of pins PIN_PB22 and PIN_PC14 Signed-off-by: Claudiu Beznea --- Changes in v2: - fix typo also for PC14 pin - change patch subject to reflect new changes arch/arm/boot/dts/sama5d2-pinfunc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch

Re: [PATCH v5 0/9] extend PWM framework to support PWM modes

2018-07-18 Thread Claudiu Beznea
Hi Thierry, It's been a while since I submitted this version but no feedback so far on it. I re-done it as you suggested. Do you have any thoughts on this version? Thank you, Claudiu beznea On 22.05.2018 15:07, Claudiu Beznea wrote: > Hi, > > Please give feedback on these patches

[PATCH v5 0/9] extend PWM framework to support PWM modes

2018-05-22 Thread Claudiu Beznea
s/class/pwm/pwmchip0/pwm2# cat mode [normal] complementary push-pull The PWM push-pull mode could be usefull in applications like half bridge converters. This series also add PWM modes support for Atmel/Microchip SoCs. Thank you, Claudiu Beznea [1] https://www.spinics.net/lists/arm-kernel/msg580275.h

[PATCH v5 2/9] pwm: clps711x: populate PWM mode in of_xlate function

2018-05-22 Thread Claudiu Beznea
Populate PWM mode in of_xlate function to avoid pwm_apply_state() failure. Signed-off-by: Claudiu Beznea --- drivers/pwm/pwm-clps711x.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-clps711x.c b/drivers/pwm/pwm-clps711x.c index 26ec24e457b1

[PATCH v5 3/9] pwm: cros-ec: populate PWM mode in of_xlate function

2018-05-22 Thread Claudiu Beznea
Populate PWM mode in of_xlate function to avoid pwm_apply_state() failure. Signed-off-by: Claudiu Beznea --- drivers/pwm/pwm-cros-ec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/pwm-cros-ec.c b/drivers/pwm/pwm-cros-ec.c index 9c13694eaa24..78d28d60a468 100644 --- a/drivers

[PATCH v5 7/9] pwm: add push-pull mode support

2018-05-22 Thread Claudiu Beznea
Add push-pull mode support. In push-pull mode the channels' outputs have same polarities and the edges are complementary delayed for one period. Signed-off-by: Claudiu Beznea --- drivers/pwm/core.c | 1 + include/linux/pwm.h | 3 +++ 2 files changed, 4 insertions(+) diff --git a/driver

[PATCH v5 9/9] pwm: atmel: add push-pull mode support

2018-05-22 Thread Claudiu Beznea
Add support for PWM push-pull mode. This is only supported by SAMA5D2 SoCs. Signed-off-by: Claudiu Beznea --- drivers/pwm/pwm-atmel.c | 40 1 file changed, 36 insertions(+), 4 deletions(-) diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c

[PATCH v5 8/9] pwm: add documentation for pwm push-pull mode

2018-05-22 Thread Claudiu Beznea
Add documentation for PWM push-pull mode. Signed-off-by: Claudiu Beznea Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/pwm/pwm.txt | 2 ++ Documentation/pwm.txt | 16 include/dt-bindings/pwm/pwm.h | 1 + 3 files changed

[PATCH v5 5/9] pwm: add PWM modes

2018-05-22 Thread Claudiu Beznea
Add PWM normal and complementary modes. Signed-off-by: Claudiu Beznea --- Documentation/devicetree/bindings/pwm/pwm.txt | 9 +++-- Documentation/pwm.txt | 26 +++--- include/dt-bindings/pwm/pwm.h | 1 + 3 files changed, 31

[PATCH v5 6/9] pwm: atmel: add pwm capabilities

2018-05-22 Thread Claudiu Beznea
Add pwm capabilities for Atmel/Microchip PWM controllers. Signed-off-by: Claudiu Beznea --- drivers/pwm/pwm-atmel.c | 80 - 1 file changed, 52 insertions(+), 28 deletions(-) diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c index

[PATCH v5 4/9] pwm: pxa: populate PWM mode in of_xlate function

2018-05-22 Thread Claudiu Beznea
Populate PWM mode in of_xlate function to avoid pwm_apply_state() failure. Signed-off-by: Claudiu Beznea --- drivers/pwm/pwm-pxa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/pwm-pxa.c b/drivers/pwm/pwm-pxa.c index 4143a46684d2..4c88cb47d6ba 100644 --- a/drivers/pwm/pwm

[PATCH v5 1/9] pwm: extend PWM framework with PWM modes

2018-05-22 Thread Claudiu Beznea
include/dt-bindings/pwm/pwm.h. Only modes supported by PWM channel could be set. If nothing is specified for a PWM channel, via DT, the first available mode will be used (normally, this will be PWM normal mode). Signed-off-by: Claudiu Beznea --- drivers/pwm/cor

[PATCH] mtd: atmel-quadspi: add suspend/resume hooks

2018-05-23 Thread Claudiu Beznea
Implement suspend/resume hooks. Signed-off-by: Claudiu Beznea --- drivers/mtd/spi-nor/atmel-quadspi.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/mtd/spi-nor/atmel-quadspi.c b/drivers/mtd/spi-nor/atmel-quadspi.c index 6c5708bacad8..85d7610fb920 100644

Re: [PATCH] staging: wilc1000: fix spelling mistake: "Preamle" -> "Preamble"

2018-05-23 Thread Claudiu Beznea
On 22.05.2018 19:49, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in netdev_err error message > > Signed-off-by: Colin Ian King Reviewed-by: Claudiu Beznea > --- > drivers/staging/wilc1000/host_interface.c | 2 +- > 1 file ch

Re: [PATCH v2 4/4] ARM: PWM: add allwinner sun8i pwm support.

2018-02-28 Thread Claudiu Beznea
On 25.02.2018 15:53, hao_zhang wrote: > This patch add allwinner sun8i pwm support. > > Signed-off-by: hao_zhang > --- > drivers/pwm/Kconfig | 10 ++ > drivers/pwm/Makefile| 1 + > drivers/pwm/pwm-sun8i.c | 401 > > 3 files changed,

[PATCH v4 8/9] pwm: add documentation for pwm push-pull mode

2018-03-29 Thread Claudiu Beznea
Add documentation for PWM push-pull mode. Signed-off-by: Claudiu Beznea Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/pwm/pwm.txt | 2 ++ Documentation/pwm.txt | 16 include/dt-bindings/pwm/pwm.h | 1 + 3 files changed

[PATCH v4 4/9] pwm: pxa: populate PWM mode in of_xlate function

2018-03-29 Thread Claudiu Beznea
Populate PWM mode in of_xlate function to avoid pwm_apply_state() failure. Signed-off-by: Claudiu Beznea --- drivers/pwm/pwm-pxa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/pwm-pxa.c b/drivers/pwm/pwm-pxa.c index 4143a46684d2..4c88cb47d6ba 100644 --- a/drivers/pwm/pwm

[PATCH v4 9/9] pwm: atmel: add push-pull mode support

2018-03-29 Thread Claudiu Beznea
Add support for PWM push-pull mode. This is only supported by SAMA5D2 SoCs. Signed-off-by: Claudiu Beznea --- drivers/pwm/pwm-atmel.c | 40 1 file changed, 36 insertions(+), 4 deletions(-) diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c

[PATCH v4 2/9] pwm: clps711x: populate PWM mode in of_xlate function

2018-03-29 Thread Claudiu Beznea
Populate PWM mode in of_xlate function to avoid pwm_apply_state() failure. Signed-off-by: Claudiu Beznea --- drivers/pwm/pwm-clps711x.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-clps711x.c b/drivers/pwm/pwm-clps711x.c index 26ec24e457b1

[PATCH v4 6/9] pwm: atmel: add pwm capabilities

2018-03-29 Thread Claudiu Beznea
Add pwm capabilities for Atmel/Microchip PWM controllers. Signed-off-by: Claudiu Beznea --- drivers/pwm/pwm-atmel.c | 80 - 1 file changed, 52 insertions(+), 28 deletions(-) diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c index

[PATCH v4 0/9] extend PWM framework to support PWM modes

2018-03-29 Thread Claudiu Beznea
s/class/pwm/pwmchip0/pwm2# cat mode [normal] complementary push-pull The PWM push-pull mode could be usefull in applications like half bridge converters. This series also add PWM modes support for Atmel/Microchip SoCs. Thank you, Claudiu Beznea [1] https://www.spinics.net/lists/arm-kernel/msg5802

[PATCH v4 7/9] pwm: add push-pull mode support

2018-03-29 Thread Claudiu Beznea
Add push-pull mode support. In push-pull mode the channels' outputs have same polarities and the edges are complementary delayed for one period. Signed-off-by: Claudiu Beznea --- drivers/pwm/core.c | 1 + include/linux/pwm.h | 3 +++ 2 files changed, 4 insertions(+) diff --git a/driver

[PATCH v4 5/9] pwm: add PWM modes

2018-03-29 Thread Claudiu Beznea
Add PWM normal and complementary modes. Signed-off-by: Claudiu Beznea --- Documentation/devicetree/bindings/pwm/pwm.txt | 9 +++-- Documentation/pwm.txt | 26 +++--- include/dt-bindings/pwm/pwm.h | 1 + 3 files changed, 31

[PATCH v4 1/9] pwm: extend PWM framework with PWM modes

2018-03-29 Thread Claudiu Beznea
include/dt-bindings/pwm/pwm.h. Only modes supported by PWM channel could be set. If nothing is specified for a PWM channel, via DT, the first available mode will be used (normally, this will be PWM normal mode). Signed-off-by: Claudiu Beznea --- drivers/pwm/cor

[PATCH v4 3/9] pwm: cros-ec: populate PWM mode in of_xlate function

2018-03-29 Thread Claudiu Beznea
Populate PWM mode in of_xlate function to avoid pwm_apply_state() failure. Signed-off-by: Claudiu Beznea --- drivers/pwm/pwm-cros-ec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/pwm-cros-ec.c b/drivers/pwm/pwm-cros-ec.c index 9c13694eaa24..78d28d60a468 100644 --- a/drivers

Re: [PATCH] mtd: atmel-quadspi: add suspend/resume hooks

2018-06-04 Thread Claudiu Beznea
On 29.05.2018 22:15, Boris Brezillon wrote: > On Wed, 23 May 2018 19:08:48 +0300 > Claudiu Beznea wrote: > >> Implement suspend/resume hooks. >> >> Signed-off-by: Claudiu Beznea >> --- >> drivers/mtd/spi-nor/atmel-quadspi.c | 23 ++

[PATCH v2] mtd: atmel-quadspi: add suspend/resume hooks

2018-06-04 Thread Claudiu Beznea
Implement suspend/resume hooks. Signed-off-by: Claudiu Beznea --- Changes in v2: - use __maybe_unused instead of #ifdef CONFIG_PM_SLEEP drivers/mtd/spi-nor/atmel-quadspi.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/mtd/spi-nor/atmel-quadspi.c b/drivers

Re: [RFC PATCH 5/5] net: macb: Add WOL support with ARP

2018-05-15 Thread Claudiu Beznea
Hi Harini, On 10.05.2018 13:37, Harini Katakam wrote: > Hi Claudiu, > > On Fri, May 4, 2018 at 5:47 PM, Claudiu Beznea > wrote: >> >> >> On 22.03.2018 15:51, harinikatakamli...@gmail.com wrote: >>> From: Harini Katakam >>> >>> Thi

Re: [PATCH] staging/wilc1000: fix wilc_mac_xmit()'s return type

2018-04-25 Thread Claudiu Beznea
Hi Luc, I'm resending this since last time I only send it to staging ml. Could you, please, change the "return 0;"s inside wilc_mac_xmit() with "return NETDEV_TX_OK" ? Thank you, Claudiu On 24.04.2018 15:18, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'net

[PATCH] power: reset: at91-reset: free resources on exit path

2021-02-09 Thread Claudiu Beznea
Free resources on exit path (failure path of probe and remove). Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Claudiu Beznea --- drivers/power/reset/at91-reset.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/drivers

  1   2   3   4   5   6   7   >