wait ~450-950 microseconds.
Signed-off-by: Colin Ian King
---
drivers/usb/early/ehci-dbgp.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/early/ehci-dbgp.c b/drivers/usb/early/ehci-dbgp.c
index ee0ebac..89dcf15 100644
--- a/drivers/usb/early/ehci-dbgp.c
+++ b
On 23/01/13 22:02, Arnaldo Carvalho de Melo wrote:
Em Mon, Jan 21, 2013 at 01:53:21PM +0900, Namhyung Kim escreveu:
On Sat, 19 Jan 2013 16:36:54 +, Colin King wrote:
From: Colin Ian King
__perf_evsel__read_on_cpu() only bails out with -ENOMEM if
evsel->counts is NULL
On 20/09/16 16:39, Alex Deucher wrote:
> On Tue, Sep 20, 2016 at 11:16 AM, Colin King wrote:
>> From: Colin Ian King
>>
>> The check for an out of bound index into array interrupt_status_offsets
>> is off-by-one. Fix this and also don't compared to a hard coded
On 23/09/16 19:20, Vaibhav Agarwal wrote:
> On Fri, Sep 23, 2016 at 10:28 PM, Greg Kroah-Hartman
> wrote:
>> On Fri, Sep 23, 2016 at 11:25:40AM +0100, Colin King wrote:
>>> From: Colin Ian King
>>>
>>> Currently, if info is null, the dev_err message is de
On 24/09/16 22:08, Ido Schimmel wrote:
> On Sat, Sep 24, 2016 at 06:03:38PM -0700, Colin King wrote:
>> From: Colin Ian King
>>
>> There is an earlier check and return if err is non-zero, so
>> the check to see if it is zero is redundant in every iteration
>> of
On 27/07/16 15:38, Matt Fleming wrote:
> On Wed, 20 Jul, at 11:11:06AM, Colin Ian King wrote:
>> From: Colin Ian King
>>
>> Although very unlikey, if size is too small or zero, then we end up with
>> status not being set and returning garbage. Inst
On 13/09/16 13:46, Linus Walleij wrote:
> On Tue, Sep 13, 2016 at 2:31 PM, Arnd Bergmann wrote:
>
>> Please try to avoid adding initializations in the local variable
>> declaration, they just hide otherwise useful warnings when
>> you get a function that actually does something incorrect
>> in so
On 15/09/16 18:10, Kalle Valo wrote:
> Colin King writes:
>
>> From: Colin Ian King
>>
>> When chan is zero mwifiex_create_custom_regdomain does not kfree
>> regd and we have a memory leak. Fix this by freeing regd before
>> the return.
>>
>> S
On 16/08/17 14:58, Leon Romanovsky wrote:
> On Wed, Aug 16, 2017 at 02:42:50PM +0100, Colin King wrote:
>> From: Colin Ian King
>>
>> Trivial fix to spelling mistakes in the mlx4 driver.
>>
>> Signed-off-by: Colin Ian King
>> ---
>> dri
On 16/08/17 15:00, Jan Kara wrote:
> On Wed 16-08-17 09:06:20, Colin King wrote:
>> From: Colin Ian King
>>
>> Trivial fix to spelling mistake in reiserfs_warning message
>>
>> Signed-off-by: Colin Ian King
>
> Thanks. Added to my tree. BTW, w
On 16/08/17 14:37, Laurentiu Tudor wrote:
> On 08/16/2017 03:06 PM, Dan Carpenter wrote:
>> On Wed, Aug 16, 2017 at 12:44:51PM +0100, Colin King wrote:
>>> From: Colin Ian King
>>>
>>> The previous fix removed the equal to zero comparisons by the strcmps and
On 17/08/17 13:21, Emil Velikov wrote:
> On 17 August 2017 at 11:37, Colin King wrote:
>> From: Colin Ian King
>>
>> The check to see if mstm->msto is null is redundant because it is
>> an array and hence can never be null. Remove the redundant check.
>>
>
On 17/08/17 23:07, Ilia Mirkin wrote:
> On Thu, Aug 17, 2017 at 6:03 PM, Colin King wrote:
>> From: Colin Ian King
>>
>> The null check on the array msto is incorrect since msto is never
>> null. The null check should be instead on msto[i] since this is
>>
ed to be setup correctly.
>>
>> Detected by CoverityScan, CID#1437563 ("Unitialized scalar variable")
>>
>> Signed-off-by: Colin Ian King
>> ---
>> drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deleti
On 30/05/17 11:58, Mark Brown wrote:
> On Tue, May 30, 2017 at 10:44:20AM +0100, Colin King wrote:
>> From: Colin Ian King
>>
>> Fixes smatch warning: unused variable 'i' [-Wunused-variable]
>>
>> Signed-off-by: Colin Ian King
>> ---
>> dr
On 02/11/17 14:14, walter harms wrote:
>
>
> Am 02.11.2017 15:01, schrieb Colin King:
>> From: Colin Ian King
>>
>> Variable rts is being assigned but it is never read, hence it can be
>> removed. The assignment to param_new to zero is redundant as it is
>&g
On 02/11/17 14:21, Colin Ian King wrote:
> On 02/11/17 14:14, walter harms wrote:
>>
>>
>> Am 02.11.2017 15:01, schrieb Colin King:
>>> From: Colin Ian King
>>>
>>> Variable rts is being assigned but it is never read, hence it can be
>>> r
On 14/11/17 13:45, Julia Lawall wrote:
>
>
> On Tue, 14 Nov 2017, Colin King wrote:
>
>> From: Colin Ian King
>>
>> Trivial fix to spelling mistake in pr_err error message text
>>
>> Signed-off-by: Colin Ian King
>> ---
>> drivers/c
On 29/10/17 13:30, Julia Lawall wrote:
>
>
> On Sun, 29 Oct 2017, Colin King wrote:
>
>> From: Colin Ian King
>>
>> Pointer pix is being initialized to a value and a little later
>> being assigned the same value again. Remove the redundant second
>>
d way as opposed to just removing it and
then hitting an issue with a null ptr deference.
>
>> Signed-off-by: Colin Ian King
>> ---
>> drivers/ps3/ps3-vuart.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/ps3/ps3-vua
Hi,
Recent commit 82ff27bc52a88cb5cc400bfa64e210d3ec8dfebd ("xfs: automatic
dfops buffer relogging") removed the assignment of variable error:
- error = xfs_defer_bjoin(tp->t_dfops, bp);
if (error) {
xfs_trans_bhold_release(tp, bp);
xfs_trans_brelse(t
On 20/07/18 11:31, John Johansen wrote:
> On 07/14/2018 09:19 AM, Colin King wrote:
>> From: Colin Ian King
>>
>> Pointer 'info' is being assigned but is never used hence it is
>> redundant and can be removed.
>>
>> Cleans up clang warning:
>&
On 11/05/17 14:55, Bart Van Assche wrote:
> On Thu, 2017-05-11 at 11:16 +0100, Colin King wrote:
>> From: Colin Ian King
>>
>> Making target_parse_xcopy_cmd static fixes sparse warning:
>>
>> "warning: symbol 'target_parse_xcopy_cmd' was not
On 11/05/17 19:16, David Miller wrote:
> From: Colin King
> Date: Thu, 11 May 2017 18:29:29 +0100
>
>> From: Colin Ian King
>>
>> The error status err is initialized as zero and then being checked
>> several times to see if it is less than zero even when it has
On 14/05/17 10:25, Mark Brown wrote:
> On Wed, May 10, 2017 at 09:30:20AM +0100, Colin King wrote:
>> From: Colin Ian King
>>
>> Trivial fix to spelling mistake in dev_err messages.
>
> If this is a resend why do I not seem to have a copy of this patch?
>
Pro
On 12/01/18 17:48, Tvrtko Ursulin wrote:
>
> Hi,
>
> On 12/01/2018 17:36, Colin King wrote:
>> From: Colin Ian King
>>
>> I believe the sizeof(attr) should be in fact sizeof(*attr), fortunately
>> the current code works because sizeof(struct attribute
On 12/01/18 22:38, Andy Gospodarek wrote:
> On Fri, Jan 12, 2018 at 10:11:17AM -0800, Michael Chan wrote:
>> On Fri, Jan 12, 2018 at 9:46 AM, Colin King wrote:
>>> From: Colin Ian King
>>>
>>> In the case where cmp_type == CMP_TYPE_RX_L2_TPA_START_CMP t
Hi,
CoverityScan detected a couple of issues, one of which was introduced
with the following commit:
commit 6106c0f82481e686b337ee0c403821fb5c3c17ef
Author: NeilBrown
Date: Thu Jan 11 15:06:40 2018 +1100
CoverityScan CID#1464078 ("Uninitialized scalar variable")
I'm not sure what the expecte
On 26/03/18 16:35, Ajay Singh wrote:
> Thanks for submitting the patch.
>
> On Wed, 21 Mar 2018 13:03:18 -0700
> Joe Perches wrote:
>
>> On Wed, 2018-03-21 at 19:19 +, Colin King wrote:
>>> From: Colin Ian King
>>>
>>> There are three kma
On 11/04/18 14:39, David Howells wrote:
> Colin King wrote:
>
>> Shifting 1 (a 32 bit signed int) more than 32 places will overflow
>> the int, so explicitly use 1ULL to avoid this overflow.
>> ...
>> -mask = (1 << nr_slots) - 1;
>> +mask = (1ULL << nr_slots) - 1;
>
> nr_slots cannot be
On 11/04/18 15:10, David Howells wrote:
> Colin Ian King wrote:
>
>>>> - mask = (1 << nr_slots) - 1;
>>>> + mask = (1ULL << nr_slots) - 1;
>>>
>>> nr_slots cannot be larger than 9, so what I wrote is actually fine and is
>>>
On 12/04/18 16:12, Dan Carpenter wrote:
> This isn't right. It introduces a leak.
Yup, and I see Gustavo is working on a correct fix, I'll leave that to him.
>
> regards,
> dan carpenter
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a messa
On 20/03/18 10:35, Dongsheng Yang wrote:
> Hi Colin,
>
> On 03/19/2018 09:33 PM, Colin King wrote:
>> From: Colin Ian King
>>
>> Trivial fix to spelling mistake in rdb_warn message text
>>
>> Signed-off-by: Colin Ian King
>> ---
>> drivers/
On 21/03/18 19:09, Joe Perches wrote:
> On Wed, 2018-03-21 at 19:06 +, Colin King wrote:
>> From: Colin Ian King
>>
>> The pointer workload is dereferenced before it is null checked, hence
>> there is a potential for a null pointer dereference on workload. Fix
&g
On 21/03/18 19:23, Chris Wilson wrote:
> Quoting Colin Ian King (2018-03-21 19:18:28)
>> On 21/03/18 19:09, Joe Perches wrote:
>>> On Wed, 2018-03-21 at 19:06 +, Colin King wrote:
>>>> From: Colin Ian King
>>>>
>>>> The pointer wor
On 23/03/18 17:36, Colin King wrote:
> From: Colin Ian King
>
> The #define for __PHYDMKFREE_H__ is missing a character and is not
> the same as the guard check. Defined this correctly.
>
> Cleans up clang warning:
> warning: '__PHYDMKFREE_H__' is used as a h
On 10/04/18 15:22, Dan Carpenter wrote:
> On Tue, Apr 10, 2018 at 02:41:23PM +0100, Colin King wrote:
>> From: Colin Ian King
>>
>> Currently function __load_ucode_amd can assign an uninitialized cp to *ret
>> if get_builtin_microcode returns false.
>
> What ar
On 13/03/18 16:21, Mark Brown wrote:
> On Tue, Mar 13, 2018 at 01:36:26PM +, Colin King wrote:
>> From: Colin Ian King
>>
>> The pointer cpu_dai is assigned a value but the pointer is never
>> read, hence it is redundant and can be removed.
>
> There's
On 15/11/2018 21:42, Richard Weinberger wrote:
> Am Donnerstag, 15. November 2018, 21:38:50 CET schrieb Garry McNulty:
>> If the call to ubifs_read_nnode() fails in ubifs_lpt_calc_hash() an
>> error is returned without freeing the memory allocated to 'buf'.
>> Jump to 'out' label to free allocated
On 13/11/2018 09:38, Colin King wrote:
> From: Colin Ian King
>
> Pointer port is dereferenced on port->private_data when assigning pointer
> pdata before port is null checked, leading to a potential null pointer
> dereference. Fix this by assigning pdata after the null point
On 09/12/2018 17:13, Christophe JAILLET wrote:
> Le 09/12/2018 à 16:01, Colin King a écrit :
>> From: Colin Ian King
>>
>> Currently the node == -1 check is being performed twice, the
>> second check is redundant and can be removed. Fix this by
>> removing the
On 02/07/18 13:43, Colin King wrote:
> From: Colin Ian King
>
> The check to see if platform_get_irq failed is performed on the
> unsigned value of pctrl->irq[i] and the check is never true because
> an unsigned cannot be less than zero. Fix this by assinging the
> signed
On 30/05/18 18:59, Al Stone wrote:
> On 05/30/2018 11:14 AM, Colin King wrote:
>> From: Colin Ian King
>>
>> The function acpi_table_parse_enties_array can potentially return a
>> negative value if parsing fails. Currently the check on the return
>> is not ch
On 05/07/18 10:52, Dan Carpenter wrote:
> On Thu, Jul 05, 2018 at 10:37:32AM +0100, Colin King wrote:
>> diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c
>> index 88c12474a0c3..2d6b62c6d9ab 100644
>> --- a/drivers/net/ethernet/sun/niu.c
>> +++ b/drivers/net/ethernet/sun/
Ooops, $SUBJECT should be:
"drm/selftest: fix spelling mistake "dimention" -> "dimension"
On 10/12/2018 09:26, Colin King wrote:
> From: Colin Ian King
>
> There is a spelling mistake in a pr_err message, fix this.
>
> Signed-off-by: Colin Ian Ki
On 11/12/2018 09:48, Dan Carpenter wrote:
> On Sun, Dec 09, 2018 at 03:08:32PM +, Colin King wrote:
>> From: Colin Ian King
>>
>> The initialization of ret is redundant as it is being re-assigned to
>> the return value from the call to imx8m_clk_composite_compute_di
Static analysis with CoverityScan picked up an out of bounds read issue
that has been in the Raylink wireless LAN card driver since it appeared
in the kernel:
drivers/net/wireless/ray_cs.c:
accessing org[3] is out of bounds, the array has just 3 elements.
959if (proto == htons(E
Hi,
Static analysis with CoverityScan found a potential null pointer
deference issue with a null uart with recent commit
6d7f677a2afa1c82d7fc7af7f9159cbffd5dc010 ("serial: 8250: Rate limit
serial port rx interrupts during input overruns").
Coverity Analysis is below:
983uart = serial82
On 22/12/2018 11:26, Colin King wrote:
> From: Colin Ian King
>
> Currently rdev is dereferenced when assigning desc before rdev is null
> checked, hence there is a potential null pointer dereference on rdev.
> Fix this by null checking rdev first.
>
> Detected by Cove
On 22/12/2018 19:34, Al Viro wrote:
> On Sat, Dec 22, 2018 at 12:27:50PM +, Colin King wrote:
>> From: Colin Ian King
>>
>> Currently if s is null or when returning via the error exit label
>> out_opt_err leaks of the allocated opts can occur. Fix the leak
>>
On 08/01/2019 09:42, Dan Carpenter wrote:
> On Mon, Jan 07, 2019 at 05:15:15PM +, Colin King wrote:
>> From: Colin Ian King
>>
>> The call to SMB2_queary_acl can allocate memory to pntsd and also
>> return a failure via a call to SMB2_query_acl (and then query
On 24/12/2018 18:08, David Miller wrote:
> From: Colin King
> Date: Sat, 22 Dec 2018 16:58:41 +
>
>> @@ -777,10 +777,7 @@ static void cops_rx(struct net_device *dev)
>> }
>>
>> /* Get response length. */
>> -if(lp->board==DAYNA)
>> -pkt_len = inb(ioaddr) &
Hi,
Static analysis with CoverityScan on linux-next detected a potential
null pointer dereference with the following commit:
>From d8a1051ed4ba55679ef24e838a1942c9c40f0a14 Mon Sep 17 00:00:00 2001
From: Mike Kravetz
Date: Sat, 22 Dec 2018 10:55:57 +1100
Subject: [PATCH] hugetlbfs: use i_mmap_rws
On 10/10/18 08:51, Matt Ranostay wrote:
> On Tue, Oct 9, 2018 at 5:09 AM Colin King wrote:
>>
>> From: Colin Ian King
>>
>> The IIO_CHAN_INFO_SCALE case is missing a break statement and in
>> the unlikely event that chan->address is not matched in the nest
On 29/10/2018 12:28, Arnaldo Carvalho de Melo wrote:
> Em Fri, Oct 26, 2018 at 06:58:39PM +0100, Colin King escreveu:
>> From: Colin Ian King
>>
>> Trivial fix to a spelling mistake of the error access name EACCESS,
>> rename to EACCES
>
> Thanks, applied.
>
$SUBJECT should be:
tlclk: clean an indentation issue, remove extraneous tabs
On 30/10/2018 11:56, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to clean up an indentation issue, remove tabs
>
> Signed-off-by: Colin Ian King
> ---
> driv
On 08/11/2018 09:09, Boris Brezillon wrote:
> On Wed, 7 Nov 2018 20:42:08 +
> Hi Colin,
>
> Colin King wrote:
>
>> From: Colin Ian King
>>
>> Currently max_read_ds is being updated twice, which is incorrect.
>> The second assignment shou
On 11/10/18 16:42, Takashi Iwai wrote:
> On Wed, 10 Oct 2018 16:15:42 +0200,
> Colin King wrote:
>>
>> From: Colin Ian King
>>
>> Currently the return from pnp_port_start is being checked for validity
>> by checking if it is greater or equal to zero, however,
On 13/10/2018 16:27, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in MODULE_DESCRIPTION text
>
> Signed-off-by: Colin Ian King
> ---
> drivers/power/supply/ds2780_battery.c | 2 +-
> drivers/power/supply/ds2781_battery.c | 2 +-
Hi,
Static analysis has found a couple of issues as follows:
commit 551f205aff9198e17add1264dd781771d1a2bd9d
Author: Yang Shi
Date: Thu Oct 4 07:43:18 2018 +1000
mm: brk: downgrade mmap_sem to read when shrinking
Static analysis with CoverityScan has detected an issue in mm/mmap.c,
funct
On 17/07/18 10:30, Dan Carpenter wrote:
> On Mon, Jul 16, 2018 at 01:09:54PM +0100, Colin King wrote:
>> From: Colin Ian King
>>
>> In the case where async_copy is successfully allocated but
>> the call to nfs4_init_cp_state fails, async_copy is not
>> current
Signed-off-by: Colin Ian King
---
drivers/dax/bus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
index 797e1ebff299..f758afbf8f09 100644
--- a/drivers/dax/bus.c
+++ b/drivers/dax/bus.c
@@ -1204,7 +1204,6 @@ static ssize_t mapping_store(struct device *d
There are two spelling mistakes in the tracepoint message text. Fix them.
Signed-off-by: Colin Ian King
---
include/trace/events/firewire.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/trace/events/firewire.h b/include/trace/events/firewire.h
index
On 20/04/2021 16:31, Peter Zijlstra wrote:
> On Tue, Apr 20, 2021 at 05:03:03PM +0200, Peter Zijlstra wrote:
>> On Tue, Apr 20, 2021 at 03:29:07PM +0100, Colin King wrote:
>>> From: Colin Ian King
>>>
>>> The 64 bit value read from MSR_ARCH_PERFMON_FIXED_CTR_CT
There is a spelling mistake in a dev_warn message. Fix it.
Signed-off-by: Colin Ian King
---
drivers/nvdimm/region_devs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c
index 83dbf398ea84..8f5274b04348 100644
--- a
ue is never actually read
from 'error' [deadcode.DeadStores]
Signed-off-by: Colin Ian King
---
fs/dax.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/dax.c b/fs/dax.c
index 2ababb89918d..cb36c6746fc4 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -1830,
Hi,
Static analysis on linux-next today using Coverity found an issue in the
following commit:
commit 3ad3f8f93c81f81d6e28b2e286b03669cc1fb3b0
Author: Hariprasad Kelam
Date: Thu Feb 11 21:28:34 2021 +0530
octeontx2-af: cn10k: MAC internal loopback support
The analysis is as follows:
723
On 16/02/2021 14:01, Colin King wrote:
> From: Colin Ian King
>
> There is a spelling mistake in the -g help option, I believe
> it should be "graph". Fix it.
>
> Signed-off-by: Colin Ian King
> ---
> tools/tracing/latency/latency-collector.c | 2 +-
&g
On 09/04/2021 07:46, Masahiro Yamada wrote:
> On Thu, Apr 8, 2021 at 12:25 AM Colin King wrote:
>>
>> From: Colin Ian King
>>
>> The for-loop iterates with a u8 loop counter i and compares this
>> with the loop upper limit of num_parents that is an int type.
>
On 29/03/2021 08:13, Ido Schimmel wrote:
> On Sat, Mar 27, 2021 at 10:33:34PM +, Colin King wrote:
>> From: Colin Ian King
>>
>> The variable force is being initialized with a value that is
>> never read and it is being updated later with a new value. The
>>
On 12/01/15 18:02, Geert Uytterhoeven wrote:
> On Mon, Jan 12, 2015 at 4:27 PM, Colin King wrote:
>> From: Colin Ian King
>>
>> [drivers/video/fbdev/broadsheetfb.c:673]:
>> (error) Memory leak: sector_buffer
>>
>> sector_buff
On 31/05/15 23:15, Sergei Shtylyov wrote:
> Hello.
>
> On 06/01/2015 01:00 AM, Colin King wrote:
>
>> From: Colin Ian King
>
>> If kzalloc returns null then isp1760_ep_alloc_request performs
>> a null pointer deference on req.
>
>Dereference, not
On 22/05/18 16:21, Tariq Toukan wrote:
>
>
> On 22/05/2018 11:37 AM, Colin King wrote:
>> From: Colin Ian King
>>
>> Trivial fix to spelling mistake in mlx4_dbg debug message
>>
>> Signed-off-by: Colin Ian King
>> ---
>> drivers/net/ethernet
On 04/04/18 11:24, Dan Carpenter wrote:
> On Tue, Apr 03, 2018 at 03:45:40PM +0200, Ladislav Michl wrote:
>> On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote:
>>> From: Colin Ian King
>>
>> Hello Colin,
>>
>>> Trivial fix to spelling mistake
On 29/03/18 12:59, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in DP_INFO message text
>
> Signed-off-by: Colin Ian King
> ---
> drivers/net/ethernet/qlogic/qed/qed_ll2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
On 29/03/18 14:01, Joe Perches wrote:
> On Thu, 2018-03-29 at 13:41 +0100, Colin King wrote:
>> Trivial fix to spelling mistakes/typos in various DP_* messages.
> []
>> diff --git a/drivers/net/ethernet/qlogic/qed/qed_vf.c
>> b/drivers/net/ethernet/qlogic/qed/qed_vf.c
> []
>> @@ -231,7 +231,7 @@ s
On 29/03/18 18:31, Steven Rostedt wrote:
> On Thu, 29 Mar 2018 18:24:31 +0100
> Colin King wrote:
>
>> From: Colin Ian King
>>
>> Trivial fix to spelling mistake in message text
>>
>> Signed-off-by: Colin Ian King
>> ---
>> tools/testing/s
On 30/04/18 14:19, Manivannan Sadhasivam wrote:
> Hi Colin,
>
> On Mon, Apr 30, 2018 at 02:14:20PM +0100, Colin King wrote:
>> From: Colin Ian King
>>
>> There is a missing break in case PIN_CONFIG_DRIVE_STRENGTH leading to
>> a fall-through to the PIN_CO
Hi there,
Static analysis with CoverityScan picked up an explicit null pointer
dereference in the the following commit:
commit 3bb4c3bc85bf77a76c921671800bde2e1bf82a88
Author: Niklas Söderlund
Date: Sat Apr 14 07:57:18 2018 -0400
media: rcar-vin: add group allocator functions
in:
+stati
On 06/06/18 13:18, Colin King wrote:
> From: Colin Ian King
>
> The current use of result is or'ing in values and checking for
> a non-zero result, however, result is not initialized to zero
> so it potentially contains garbage to start with. Fix this by
> initializing
On 07/06/18 08:35, Johan Hovold wrote:
> On Wed, Jun 06, 2018 at 07:02:03PM +0300, Andy Shevchenko wrote:
>> On Wed, Jun 6, 2018 at 4:43 PM, Colin King wrote:
>>> From: Colin Ian King
>>>
>>> Currently saved_vals is being allocated and there is no check for
On 17/04/2019 12:07, Mukesh Ojha wrote:
>
> On 4/17/2019 4:25 PM, Colin King wrote:
>> From: Colin Ian King
>>
>> There are a couple of spelling mistakes in test assert messages. Fix
>> them.
>>
>> Signed-off-by: Colin Ian King
>
> Well, how are
ositive, 45000 in this case), and errno values (negative, -ESRCH in this
> case) to check both fake success and fake failure during syscall skipping.
>
> Reported-by: Colin Ian King
> Fixes: a33b2d0359a0 ("selftests/seccomp: Add tests for basic ptrace actions")
> C
On 03/04/2019 23:02, Darren Hart wrote:
> On Sat, Mar 30, 2019 at 12:17:12AM +, Colin King wrote:
>> From: Colin Ian King
>>
>> Currently the kfree of output.pointer can be potentially freeing
>> an uninitalized pointer in the case where out_data is NULL. Fix th
On 03/04/2019 23:26, Darren Hart wrote:
> On Wed, Apr 03, 2019 at 11:05:12PM +0100, Colin Ian King wrote:
>> On 03/04/2019 23:02, Darren Hart wrote:
>>> On Sat, Mar 30, 2019 at 12:17:12AM +, Colin King wrote:
>>>> From: Colin Ian King
>>>>
>>
On 24/02/2021 07:55, Dan Carpenter wrote:
> On Tue, Feb 23, 2021 at 07:38:21PM +, Colin King wrote:
>> From: Colin Ian King
>>
>> Currently the array gpmc_cs is indexed by cs before it cs is range checked
>> and the pointer read from this out-of-index read is d
Hi,
Static analysis on linux-next with Coverity had detected a potential
null pointer dereference with the following commit:
commit f5065508897a922327f32223082325d10b069ebc
Author: Shyam Prasad N
Date: Fri Feb 12 04:38:43 2021 -0800
cifs: Retain old ACEs when converting between mode bits
Hi,
Static analysis with Coverity on linux-next has found an issue with the
following commit:
commit 1c099ab44727c8e42fe4de4d91b53cec3ef02860
Author: Sean Wang
Date: Thu Jan 28 03:33:39 2021 +0800
mt76: mt7921: add MCU support
The analysis is as follows:
390 static void
391 mt7921_mcu_t
On 10/02/2021 17:45, Colin King wrote:
> From: Colin Ian King
>
> The assignment to dma_dev has been performed twice in one
> statement. Fix this by removing the extraneous assignment.
>
> Addresses-Coverity: ("Evaluation order violation")
> Fixes: fdcd
On 11/02/2021 07:31, Michael Tretter wrote:
> On Wed, 10 Feb 2021 18:49:38 +, Colin King wrote:
>> From: Colin Ian King
>>
>> The pointer 'divider' has previously been null checked followed by
>> a return, hence the subsequent null check is redundant deadc
On 11/02/2021 10:41, Dan Carpenter wrote:
> On Wed, Feb 10, 2021 at 11:03:03PM +0200, Sakari Ailus wrote:
>> Hi Colin,
>>
>> On Wed, Feb 10, 2021 at 07:07:52PM +, Colin King wrote:
>>> From: Colin Ian King
>>>
>>> Currently there is a dev_
On 04/02/2021 09:25, Pawel Laszczak wrote:
>
> I've sent the patch that remove this one and others similar printk from
> driver.
Thanks Pawel.
Colin
>
>>
>>
>> On Thu, Feb 04, 2021 at 05:07:16AM +, Pawel Laszczak wrote:
>>> Hi Dan,
>>&g
On 08/02/2021 15:06, Dan Carpenter wrote:
> On Sun, Feb 07, 2021 at 11:21:20PM +, Colin King wrote:
>> From: Colin Ian King
>>
>> Shifting the integer value 1 is evaluated using 32-bit rithmetic
>> and then used in an expression that expects a 64-bit value, so
Hi,
Static analysis with Coverity has detected an uninitialized value being
used in a comparison. The error was detected on a recent change to
drivers/staging/greybus/audio_topology.c however the issue actually
dates back to the original commit:
commit 6339d2322c47f4b8ebabf9daf0130328ed72648b
Au
On 10/08/2020 15:06, Colin King wrote:
> From: Colin Ian King
>
> Currently invalid CPU addresses are not being sanity checked resulting in
> SATA setup failure on a SynQuacer SC2A11 development machine. The original
> check was removed by and earlier commit, so add a sanity che
On 05/08/2020 09:06, Willem de Bruijn wrote:
> On Wed, Aug 5, 2020 at 2:54 AM Eric Dumazet wrote:
>>
>>
>>
>> On 8/4/20 5:30 AM, Colin King wrote:
>>> From: Colin Ian King
>>>
>>> The current test will exit with a failure if it cannot set a
On 05/08/2020 09:44, Willem de Bruijn wrote:
> On Wed, Aug 5, 2020 at 10:22 AM Colin Ian King
> wrote:
>>
>> On 05/08/2020 09:06, Willem de Bruijn wrote:
>>> On Wed, Aug 5, 2020 at 2:54 AM Eric Dumazet wrote:
>>>>
>>>>
>>>>
>&
gt; usccess||success
> -usupported||unsupported
> uncommited||uncommitted
> uncompatible||incompatible
> unconditionaly||unconditionally
>
>
Ah, good catch. My bad.
Acked-by: Colin Ian King
On 05/08/2020 22:27, Alex Deucher wrote:
> On Wed, Aug 5, 2020 at 4:53 PM Joe Perches wrote:
>>
>> On Wed, 2020-08-05 at 16:01 -0400, Alex Deucher wrote:
>>> On Wed, Aug 5, 2020 at 7:35 AM Colin King wrote:
>>>> From: Colin Ian King
>>>>
>>
Hi,
Static analysis with Coverity has detected a potential issue with the
following commit:
commit 0b0e299720bb99428892a23ecbd2b4b7f61ccf6d
Author: Vladimir Oltean
Date: Mon Aug 3 19:48:23 2020 +0300
net: dsa: sja1105: use detected device id instead of DT one on mismatch
The analysis is
1 - 100 of 567 matches
Mail list logo
