On 06/10/14 08:53, Chen-Yu Tsai wrote:
Hi,
On Mon, Jun 9, 2014 at 6:59 PM, LABBE Corentin
clabbe.montj...@gmail.com wrote:
Add support for the Security System included in Allwinner SoC A20.
The Security System is a hardware cryptographic accelerator that support
AES/MD5/SHA1/DES/3DES/PRNG
Le 22/05/2014 17:28, Arnd Bergmann a écrit :
On Thursday 22 May 2014 17:09:56 LABBE Corentin wrote:
Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com
---
drivers/crypto/Kconfig| 49 ++
drivers/crypto/Makefile |1 +
drivers/crypto/sunxi-ss.c | 1476
,
+},
+};
+
+module_platform_driver(sunxi_ss_driver);
+
+MODULE_DESCRIPTION(Allwinner Security System crypto accelerator);
+MODULE_LICENSE(GPL);
+MODULE_AUTHOR(Corentin LABBE clabbe.montj...@gmail.com);
MODULE_ALIAS is missing I think.
Thanks for your review.
--
To unsubscribe from this list: send the line
Le 14/06/2014 21:01, Marek Vasut a écrit :
On Tuesday, June 10, 2014 at 02:43:15 PM, LABBE Corentin wrote:
Add necessary changes for configuring and compiling the Security System
driver.
Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com
---
drivers/crypto/Kconfig | 91
+1,118 @@
+/*
+ * sunxi-ss.c - hardware cryptographic accelerator for Allwinner A20 SoC
+ *
+ * Copyright (C) 2013-2014 Corentin LABBE clabbe.montj...@gmail.com
+ *
+ * Support AES cipher with 128,192,256 bits keysize.
+ * Support MD5 and SHA1 hash algorithms.
+ * Support DES and 3DES
Le 19/07/2014 20:00, Joe Perches a écrit :
(Adding Mark Allyn and Jayant Mangalampalli)
Is this still project still active?
I do not know
On Sat, 2014-07-19 at 19:34 +0200, LABBE Corentin wrote:
Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com
---
drivers/staging/sep/sep_main.c
Le 23/07/2014 17:51, Marek Vasut a écrit :
On Wednesday, July 23, 2014 at 04:13:09 PM, Herbert Xu wrote:
On Wed, Jul 23, 2014 at 04:07:20PM +0200, Marek Vasut wrote:
On Wednesday, July 23, 2014 at 03:57:35 PM, Herbert Xu wrote:
On Sat, May 24, 2014 at 02:00:03PM +0200, Marek Vasut wrote:
+
Le 24/07/2014 08:00, Herbert Xu a écrit :
On Sat, Jul 12, 2014 at 02:59:13PM +0200, LABBE Corentin wrote:
+/* sunxi_hash_init: initialize request context
+ * Activate the SS, and configure it for MD5 or SHA1
+ */
+int sunxi_hash_init(struct ahash_request *areq)
+{
+const char
Le 24/07/2014 15:38, Herbert Xu a écrit :
On Thu, Jul 24, 2014 at 01:04:55PM +0200, Corentin LABBE wrote:
Le 24/07/2014 08:00, Herbert Xu a écrit :
On Sat, Jul 12, 2014 at 02:59:13PM +0200, LABBE Corentin wrote:
+/* sunxi_hash_init: initialize request context
+ * Activate the SS
Le 22/10/2014 11:00, Arnd Bergmann a écrit :
On Sunday 19 October 2014 16:16:22 LABBE Corentin wrote:
Add support for the Security System included in Allwinner SoC A20.
The Security System is a hardware cryptographic accelerator that support
AES/MD5/SHA1/DES/3DES/PRNG algorithms.
file mode 100644
index 000..e66d7e2
--- /dev/null
+++ b/drivers/crypto/sunxi-ss/sunxi-ss-core.c
@@ -0,0 +1,318 @@
+/*
+ * sunxi-ss-core.c - hardware cryptographic accelerator for Allwinner A20
SoC
+ *
+ * Copyright (C) 2013-2014 Corentin LABBE clabbe.montj...@gmail.com
+ *
+ * Core
On 10/21/14 01:28, Vladimir Zapolskiy wrote:
Hello LABBE,
On 19.10.2014 17:16, LABBE Corentin wrote:
Add support for the Security System included in Allwinner SoC A20.
The Security System is a hardware cryptographic accelerator that support
AES/MD5/SHA1/DES/3DES/PRNG algorithms.
[]
+
+
Le 21/10/2014 01:52, Joe Perches a écrit :
On Tue, 2014-10-21 at 02:28 +0300, Vladimir Zapolskiy wrote:
On 19.10.2014 17:16, LABBE Corentin wrote:
Add support for the Security System included in Allwinner SoC A20.
The Security System is a hardware cryptographic accelerator that support
Le 17/11/2014 18:06, Terence Eden a écrit :
From: edent github@shkspr.mobi
Signed-off-by: edent github@shkspr.mobi
---
crypto/ahash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/ahash.c b/crypto/ahash.c
index f6a36a5..ffbcda3 100644
---
Le 26/03/2015 19:31, Boris Brezillon a écrit :
Hi Corentin,
Here is a quick review, there surely are a lot of other things I didn't
spot.
On Mon, 16 Mar 2015 20:01:22 +0100
LABBE Corentin clabbe.montj...@gmail.com wrote:
Add support for the Security System included in Allwinner SoC
Le 15/05/2015 08:52, Herbert Xu a écrit :
On Thu, May 14, 2015 at 02:59:01PM +0200, LABBE Corentin wrote:
+int sun4i_hash_export(struct ahash_request *areq, void *out)
+{
+struct sun4i_req_ctx *op = ahash_request_ctx(areq);
+
+memcpy(out, op, sizeof(struct sun4i_req_ctx));
+
Le 23/05/2015 16:35, Boris Brezillon a écrit :
Hi Corentin,
On Sat, 23 May 2015 15:12:23 +0200
Corentin LABBE clabbe.montj...@gmail.com wrote:
Le 17/05/2015 10:45, Boris Brezillon a écrit :
Hi Corentin,
I started to review this new version, and I still think there's
something wrong
Le 15/05/2015 09:31, Maxime Ripard a écrit :
On Thu, May 14, 2015 at 02:58:58PM +0200, LABBE Corentin wrote:
The Security System is a hardware cryptographic accelerator that support
AES/MD5/SHA1/DES/3DES/PRNG algorithms.
It could be found on many Allwinner SoC.
This patch enable the Security
Le 17/05/2015 10:45, Boris Brezillon a écrit :
Hi Corentin,
I started to review this new version, and I still think there's
something wrong with the way your processing crypto requests.
From my POV this is not asynchronous at all (see my comments inline),
but maybe Herbert can confirm that.
Le 15/05/2015 08:49, Herbert Xu a écrit :
On Thu, May 14, 2015 at 02:59:01PM +0200, LABBE Corentin wrote:
+err = crypto_ablkcipher_setkey(op-fallback, kkey, op-keylen);
+if (err != 0) {
+dev_err(ss-dev, Cannot set key on fallback\n);
+return -EINVAL;
+}
Le 24/05/2015 05:32, Herbert Xu a écrit :
On Sat, May 23, 2015 at 04:35:36PM +0200, Boris Brezillon wrote:
Since all SG I get was always a multiple of 16 (AES BLOCK SIZE) it was a
sort of confirmation.
Herbert ? does am I right or a chunking test is missing for cbc(aes) in
testmgr.h
On 19/08/2015 16:35, Michal Suchanek wrote:
Hello,
when building a kernel with sunxi crypto driver as merged into the
sinxi-wip branch I get a compiler warning.
I am not sure this is the latest version of the driver. It does not
seem to be in mainline yet.
Thanks
Michal
In file included
Le 16/11/2015 19:33, Brian Norris a écrit :
> On Thu, Nov 12, 2015 at 09:19:09AM +0100, Uwe Kleine-König wrote:
>> I really wonder there is no helper
>> function like:
>>
>> #define of_sensible_name(dev)
>> of_match_device(dev->driver->of_match_table, dev)
>
> How about
Le 16/11/2015 18:07, Felipe Balbi a écrit :
>
> Hi,
>
> LABBE Corentin writes:
>> of_match_device could return NULL, and so cause a NULL pointer
>> dereference later. Renaming id to of_id (like all others do) in the
>> process.
>>
>> Reported-by: coverity (CID
Hello
I am working on some tools for checking the good working of crypto device (and
benching them).
One of the tool use cryptodev (http://cryptodev-linux.org/) for using the
kernel crypto API
(and so any hardware accelerated crypto).
The tool compare the results of an AES cipher via cryptodev
Le 12/10/2015 21:24, kbuild test robot a écrit :
> Hi LABBE,
>
> [auto build test ERROR on crypto/master -- if it's inappropriate base, please
> suggest rules for selecting the more suitable base]
>
> url:
>
> This patch adds Altera PCIe MSI driver. This soft IP supports configurable
> number of vectors, which is a dts parameter.
>
> Signed-off-by: Ley Foon Tan
> Reviewed-by: Marc Zyngier
> +
> +static inline void msi_writel(struct altera_msi *msi, u32
Le 09/12/2015 16:32, Jani Nikula a écrit :
> On Wed, 09 Dec 2015, LABBE Corentin wrote:
>> My latest commit introduce some case where a valid mode, could be
>> rejected.
>> simple_strtox functions stop at first non-digit character, but kstrtox not.
>> So args like
Le 22/12/2015 13:27, Andre Przywara a écrit :
> The length parameter in this dev_dbg() call is actually a size_t,
> so use the proper type to avoid warnings when compiling for 64-bit
> architectures.
>
> Signed-off-by: Andre Przywara
> ---
>
Le 06/06/2016 16:14, Rob Herring a écrit :
> On Fri, Jun 03, 2016 at 11:56:28AM +0200, LABBE Corentin wrote:
>> This patch adds documentation for Device-Tree bindings for the
>> Allwinner sun8i-emac driver.
>>
>> Signed-off-by: LABBE Corentin
>> ---
>>
Le 26/01/2016 14:44, Arnd Bergmann a écrit :
> gcc correctly warns that the printk output contains a variable that
> it thinks is not initialized in some cases:
>
> drivers/crypto/sunxi-ss/sun4i-ss-cipher.c: In function 'sun4i_ss_cipher_poll':
> drivers/crypto/sunxi-ss/sun4i-ss-cipher.c:254:76:
Hello
I had some report of random data corruption of people using cryptsetup with my
sun4i-ss driver (via AF_ALG).
Even if it is hard to hit, I could confirm it by continuously moving files on a
LUKS encrypted FS and comparing hash of it before and after.
The corruption is always when
Le 22/03/2016 17:04, LABBE Corentin a écrit :
> The current sun4i-ss driver is subject to data corruption when
> ciphering/deciphering.
> It occurs randomly on end of handled data.
> No root cause have been found and the only way to remove it is to replace
> all spin_lock_bh by they irq
When a PHY is found, printing which one was found (and which type/model) is
a good information to know.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/s
This patch fix the checkpatch warning about free software address.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/chain_mode.c | 4
drivers/net/ethernet/stmicro/stmmac/common.h | 4
drivers/net/ethernet/stmicro/
checkpatch complains about two unsigned without type after.
Since the value return is u32, it is simpler to replace it by u32 instead
of "unsigned int"
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++--
1
140Mbit/s to 500Mbit/s.
Under dwmac-sunxi an iperf run use half less interrupts.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/drive
As said by checkpatch ENOSYS means 'invalid syscall nr' and nothing
else.
This patch replace ENOSYS by the more appropriate value EINVAL.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
1 file changed, 1 insertion
This patch fix the checkpatch warning about asm/io.h.
Sorting all includes in the process.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drive
Since commit cf32deec16e4 ("stmmac: add tx_skbuff_dma to save descriptors used
by PTP"),
the struct dma_desc *p in stmmac_tx_clean was not used at all.
This patch remove this dead code.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/etherne
The u64 x variable in sysfs_display_ring is unused.
This patch remove it.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mai
On Tue, Jan 31, 2017 at 11:13:49AM +0100, Giuseppe CAVALLARO wrote:
> On 1/31/2017 10:11 AM, Corentin Labbe wrote:
> > The stmmac_mdio_busy_wait() function do the same job than
> > readl_poll_timeout().
> > So is is better to replace it.
> >
> > Signed-off
The dwmac_dma_reset function use an open coded of readl_poll_timeout().
Replace the open coded handling with the proper function.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 14 ++
1 file changed, 6 insertions
Add 1000 as a valid speed in the error message about invalid speed
in stmmac_adjust_link()
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/et
The stmmac_mdio_busy_wait() function do the same job than
readl_poll_timeout().
So is is better to replace it.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 33 ---
1 file changed, 11 insertions(
The bus_setup function pointer is not used at all, this patch remove it.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4
include/linux/stmmac.h| 1 -
2 files changed, 5 deletions(-)
diff
Hello
I am currently working on dwmac-sun8i glue driver for Allwinner H3/A83T/A64.
This serie is the result of all minor problem found in the stmmac driver.
Regards
Corentin Labbe (17):
net: stmmac: fix the typo on MAC_RNABLE_RX
net: stmmac: Remove the bus_setup function pointer
net
the define MAC_RNABLE_RX have a typo, rename it to MAC_ENABLE_RX
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/common.h| 2 +-
drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
This patch fix some typos in comments.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 6 +++---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 16
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.
This patch rewrite two test against NULL value with correct style.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/
The ethtool stat counter rx_crc from stmmac is mis-named, the name
seems to speak about the number of RX CRC done, but in fact it is about
errors.
This patch rename it to rx_crc_errors, just like the same ifconfig
counter.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
d
Checkpatch complains about some code style problem on stmmac_mdio.c.
This patch fix them.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drive
On Tue, Jan 31, 2017 at 11:28:03AM +0100, Giuseppe CAVALLARO wrote:
> On 1/31/2017 10:11 AM, Corentin Labbe wrote:
> > The stmmac driver run TX completion under NAPI but without checking the
> > work done by the TX completion function.
> >
> > This patch add work/
On Wed, Feb 08, 2017 at 02:41:58AM -0800, Joe Perches wrote:
> On Wed, 2017-02-08 at 09:31 +0100, Corentin Labbe wrote:
> > Checkpatch complains about some code style problem on stmmac_mdio.c.
> > This patch fix them.
> []
> > diff --git a/drivers/net/ethernet/stmicro/stm
The stmmac_mdio_busy_wait() function do the same job than
readl_poll_timeout().
So is is better to replace it.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac
The message about invalid speed does not state 1000 as a valid speed.
It is much simpler to said that the speed is invalid.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +--
1 file changed, 1 insertion(+), 2 del
The bus_setup function pointer is not used at all, this patch remove it.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4
include/linux/stmmac.h| 1 -
2 files changed, 5 deletions(-)
diff
This patch rewrite two test against NULL value with correct style.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deleti
Checkpatch complains about some code style problem on stmmac_mdio.c.
This patch fix them.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 7 ---
1 fil
Since commit cf32deec16e4 ("stmmac: add tx_skbuff_dma to save descriptors used
by PTP"),
the struct dma_desc *p in stmmac_tx_clean was not used at all.
This patch remove this dead code.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
Acked-by: Giuseppe Cavalla
When a PHY is found, printing which one was found (and which type/model) is
a good information to know.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/d
checkpatch complains about two unsigned without type after.
Since the value return is u32, it is simpler to replace it by u32 instead
of "unsigned int"
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com>
---
driver
the define MAC_RNABLE_RX have a typo, rename it to MAC_ENABLE_RX
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com>
---
drivers/net/ethernet/stmicro/stmmac/common.h| 2 +-
drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c
This patch fix some typos in comments.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 6 +++---
drivers/net/ethernet/stmicro/stmmac/stmmac
netdev_dbg() in "net: stmmac: print phy information"
- Removed patch "net: stmmac: Implement NAPI for TX", it will be reworked
- Changed error message in "Correct the error message about invalid speed"
- Added some acked-by
Corentin Labbe (16):
net: stmmac: fix the typo
This patch fix the checkpatch warning about free software address.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/chain_mode.c | 4
drivers/net/ethernet/stmicro/stmmac/common.h | 4
drivers/net/ethernet/stmicro/
The dwmac_dma_reset function use an open coded of readl_poll_timeout().
Replace the open coded handling with the proper function.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 14 ++
1 file changed, 6 insertions
This patch fix the checkpatch warning about asm/io.h.
Sorting all includes in the process.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drive
The ethtool stat counter rx_crc from stmmac is mis-named, the name
seems to speak about the number of RX CRC done, but in fact it is about
errors.
This patch rename it to rx_crc_errors, just like the same ifconfig
counter.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
As said by checkpatch ENOSYS means 'invalid syscall nr' and nothing
else.
This patch replace ENOSYS by the more appropriate value EINVAL.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com>
---
drivers/net/ethernet/st
The u64 x variable in sysfs_display_ring is unused.
This patch remove it.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 ---
1 file changed, 3 deletions(-)
On Tue, Jan 31, 2017 at 11:10:04AM +0100, Giuseppe CAVALLARO wrote:
> On 1/31/2017 10:11 AM, Corentin Labbe wrote:
> > When a PHY is found, printing which one was found (and which type/model) is
> > a good information to know.
> >
> > Signed-off-by: Corentin Labbe
On Fri, Feb 03, 2017 at 10:15:30AM -0500, David Miller wrote:
> From: Corentin Labbe <clabbe.montj...@gmail.com>
> Date: Fri, 3 Feb 2017 14:41:45 +0100
>
> > On Tue, Jan 31, 2017 at 11:12:25PM -0500, David Miller wrote:
> >> From: Corentin Labbe <clabbe.montj...@
On Tue, Jan 31, 2017 at 11:12:25PM -0500, David Miller wrote:
> From: Corentin Labbe <clabbe.montj...@gmail.com>
> Date: Tue, 31 Jan 2017 10:11:48 +0100
>
> > The stmmac driver run TX completion under NAPI but without checking
> > the work done by the TX completion
return -ENODEV;
> + }
> +
> + pdata = of_id->data;
> +
> dsi = devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL);
> if (!dsi)
> return -ENOMEM;
Hello
You could use of_device_get_match_data()
Regards
Corentin Labbe
return -ENODEV;
> + }
> soc = (struct mtk_soc_data *)match->data;
>
> eth = devm_kzalloc(>dev, sizeof(*eth), GFP_KERNEL);
> --
Hello
You could use of_device_get_match_data() and simplifiy code
Regards
Corentin Labbe
htool".
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/common.h | 4 +-
.../net/ethernet/stmicro/stmmac/dwmac1000_core.c | 10 +--
.../net/ethernet/stmicro/stmmac/dwmac1000_dma.c| 16 ++---
.../net/ethernet/stmicro/stmm
.
What do you think about this issue ?
Corentin Labbe (1):
net: stmmac: unify registers dumps methods
drivers/net/ethernet/stmicro/stmmac/common.h | 4 +-
.../net/ethernet/stmicro/stmmac/dwmac1000_core.c | 10 +--
.../net/ethernet/stmicro/stmmac/dwmac1000_dma.c| 16 ++---
.../net/eth
On Thu, Feb 16, 2017 at 12:58:46PM -0800, Florian Fainelli wrote:
> On 02/16/2017 04:48 AM, Corentin Labbe wrote:
> > +
> > +Optional properties:
> > +- allwinner,tx-delay: TX clock delay chain value. Range value is 0-0x07.
> > Default is 0)
> > +- allwinner,rx-
This commit fix the typo argumnet/argument
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/neterion/vxge/vxge-ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/neterion/vxge/vxge-ethtool.c
b/drivers/net/et
This commit fix the typo argumnet/argument
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/neterion/s2io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/neterion/s2io.c
b/drivers/net/ethernet/neterion/s2io.c
htool".
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com>
---
drivers/net/ethernet/stmicro/stmmac/common.h | 4 +-
.../net/ethernet/stmicro/stmmac/dwmac1000_core.c | 10 +--
.../net/ethernet/stmicr
The stmmac_adjust_link() function is called too rarely for having
likely() macros being useful.
Just remove likely annotation in it.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com>
Reviewed-by: Giuseppe Cavallaro &
Hello
This is a follow up of my previous stmmac serie which address some comment
done in v2.
Corentin Labbe (8):
net: stmmac: remove useless parenthesis
net: stmmac: likely is useless in occasional function
net: stmmac: use SPEED_UNKNOWN/DUPLEX_UNKNOWN
net: stmmac: set speed
This patch remove some useless parenthesis.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com>
Reviewed-by: Giuseppe Cavallaro <peppe.cavall...@st.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 8 +++
As suggested by Joe Perches, replacing the "if phydev" logic permit to
reduce indentation in the for loop.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com>
Reviewed-by: Giuseppe Cavallaro <peppe.cavall...
It is easier to follow the logic by removing the not operator
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com>
Reviewed-by: Giuseppe Cavallaro <peppe.cavall...@st.com>
---
drivers/net/ethernet/stmicro/stmmac/stm
This patch mutualise a bit by running stmmac_hw_fix_mac_speed() after
the switch in case of valid speed.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com>
Reviewed-by: Giuseppe Cavallaro <peppe.cavall...@st.com>
In case of invalid speed given, stmmac_adjust_link() still record it as
current speed.
This patch modify the default case to set speed as SPEED_UNKNOWN if not
10/100/1000.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com&
The 10/100 case have too many ifcase.
This patch split it for removing an if.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com>
Reviewed-by: Giuseppe Cavallaro <peppe.cavall...@st.com>
---
drivers/net/ether
It is better to use DUPLEX_UNKNOWN instead of just "-1".
Using 0 for an invalid speed is bad since 0 is a valid value for speed.
So this patch replace 0 by SPEED_UNKNOWN.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
Acked-by: Giuseppe Cavallaro <peppe.cavall.
As suggested by Joe Perches, replacing the "if phydev" logic permit to
reduce indentation in the for loop.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 82 +++
1 file changed, 40 insertions(
It is easier to follow the logic by removing the not operator
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/s
Hello
This is a follow up of my previous stmmac serie which address some comment
done in v2.
Corentin Labbe (8):
net: stmmac: remove useless parenthesis
net: stmmac: likely is useless in occasional function
net: stmmac: use SPEED_UNKNOWN/DUPLEX_UNKNOWN
net: stmmac: set speed
The 10/100 case have too many ifcase.
This patch split it for removing an if.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/net/et
This patch remove some useless parenthesis.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 8
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff
The stmmac_adjust_link() function is called too rarely for having
likely() macros being useful.
Just remove likely annotation in it.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 8
1 file changed, 4 insertions
It is better to use DUPLEX_UNKNOWN instead of just "-1".
Using 0 for an invalid speed is bad since 0 is a valid value for speed.
So this patch replace 0 by SPEED_UNKNOWN.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/st
In case of invalid speed given, stmmac_adjust_link() still record it as
current speed.
This patch modify the default case to set speed as SPEED_UNKNOWN if not
10/100/1000.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |
This patch mutualise a bit by running stmmac_hw_fix_mac_speed() after
the switch in case of valid speed.
Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff
1 - 100 of 2385 matches
Mail list logo