Re: Stale NFS handles on 2.4.2

2001-02-24 Thread David Fries
that. -- +-+ | David Fries| | [EMAIL PROTECTED] | +-+ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: Stale NFS handles on 2.4.2

2001-02-24 Thread David Fries
o shut about everything down to do that. -- +-+ | David Fries| | [EMAIL PROTECTED] | +-+ - To unsubscribe from this list: se

Re: Stale NFS handles on 2.4.2

2001-02-25 Thread David Fries
directory on the new mount was fine, but the problem directory on the old mount was still stale. Yes it is a ext2 file system being exported. It is using the kernel nfs server. -- +-+ | David Fries

Re: Stale NFS handles on 2.4.2

2001-02-26 Thread David Fries
work already. -- +-+ | David Fries| | [EMAIL PROTECTED] | +-+ - To unsubscribe from this list: send the line "unsubscribe linux-k

pcmcia plug and hang 2.4

2001-03-18 Thread David Fries
(dd9jn+kvh) eth0: Intel: port 0x300, irq 3, hwaddr 00:A0:C9:7A:CE:D5 eth0: autonegotiation failed; using 10mbs eth0: MII detected; using 10mbs eth0: media 10BaseT, silicon revision 4 eth0: no IPv6 routers present -- +-+ | David

Re: goodbye

2001-04-07 Thread David Fries
all I have is, accepted by university, hope it gets there... -- +-+ | David Fries| | [EMAIL PROTECTED]| +-+ - To unsubscribe from

[PATCH] system timer: fix crash in 100Hz system timer

2008-01-05 Thread David Fries
at /proc/interrupts. Signed-off-by: David Fries [EMAIL PROTECTED] -- David Fries [EMAIL PROTECTED] http://fries.net/~david/ (PGP encryption key available) diff --git a/include/linux/acct.h b/include/linux/acct.h index 302eb72..86b848d 100644 --- a/include/linux/acct.h +++ b/include/linux/acct.h

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-08 Thread David Fries
return when I unplug the joystick. Thanks for fixing the other drivers, I didn't think of looking at them. -- David Fries [EMAIL PROTECTED] http://fries.net/~david/pgpkey.txt - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

[PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-01 Thread David Fries
by the USB HUB even if I'm only touching the chair and floor! The kernel then removes the old joystick and redetects it as a new joystick. I've also included a test program to verify that a blocking select, poll, and read call will return if the joystick is unplugged. -- David Fries [EMAIL PROTECTED

[PATCH] rtc_sysfs_show_hctosys(): display 0 if resume failed

2012-09-07 Thread David Fries
-by: David Fries da...@fries.net Cc: Matthew Garrett m...@redhat.com Cc: Alessandro Zummo a.zu...@towertech.it Cc: Uwe Kleine-König u.kleine-koe...@pengutronix.de Cc: Andrew Morton a...@linux-foundation.org --- On Fri, Sep 07, 2012 at 04:56:26PM -0700, Andrew Morton wrote: On Sat, 25 Aug 2012 21:19:31

Re: linux-next: build failure after merge of the final tree (akpm tree related)

2012-09-13 Thread David Fries
...@canb.auug.org.au -- David Fries da...@fries.netPGP pub CB1EE8F0 http://fries.net/~david/ signature.asc Description: Digital signature

Re: linux-next: build failure after merge of the final tree (akpm tree related)

2012-09-13 Thread David Fries
On Thu, Sep 13, 2012 at 11:34:29PM +1000, Stephen Rothwell wrote: Hi David, On Thu, 13 Sep 2012 08:24:08 -0500 David Fries da...@fries.net wrote: On Thu, Sep 13, 2012 at 06:11:27PM +1000, Stephen Rothwell wrote: Hi all, After merging the final tree, today's linux-next build

[PATCH] rtc_sysfs_show_hctosys 0 if resume failed

2012-08-25 Thread David Fries
. This uses only CONFIG_RTC_HCTOSYS_DEVICE for conditional compilation instead of it and CONFIG_RTC_HCTOSYS. rtc_hctosys_ret was moved to class.c so rtc_hctosys can be removed with just a Kconfig change if boot time setting isn't desired. Signed-off-by: David Fries da...@fries.net Cc: Matthew Garrett m

[PATCH 2/2] W1: w1_therm.c is flagging 0C etc as invalid

2008-01-19 Thread David Fries
commit d05074b1beb66d40283228bd226f7244407375bb Author: David Fries [EMAIL PROTECTED] Date: Sat Jan 19 18:06:49 2008 -0600 The extra rom[0] check is flagging valid temperatures as invalid when there is already a CRC data transmission check. w1_therm_read_bin() if (rom[8] == crc rom[0

[PATCH 1/2] W1: w1_therm.c ds18b20 decode freezing temperatures correctly

2008-01-19 Thread David Fries
commit c4ad974f3acef11e538e825ca0cb73be6faf2461 Author: David Fries [EMAIL PROTECTED] Date: Sun Nov 4 18:14:21 2007 -0600 Corrected the decoding of negative C temperatures. The code did a binary OR of two bytes to make a 16 bit value, but assignd it to an integer. This caused the value

W1: w1_slave units, standardize 1C or .001C? Break API

2008-01-21 Thread David Fries
. The .001 C does truncate one bit of precision from the ds18b20 by the way. 45 01 4b 46 7f ff 0b 10 84 : crc=84 YES 45 01 4b 46 7f ff 0b 10 84 t=20312 -- David Fries [EMAIL PROTECTED] http://fries.net/~david/ (PGP encryption key available) -- To unsubscribe from this list: send the line

Re: W1: w1_slave units, standardize 1C or .001C? Break API

2008-01-22 Thread David Fries
= 719.96 ?F The range for the sensor is -55 to 125 C, if an application didn't care about precision they could store it in a signed 8 bit value just fine. -- David Fries [EMAIL PROTECTED] http://fries.net/~david/ (PGP encryption key available) -- To unsubscribe from this list: send the line unsubscribe

Re: W1: w1_slave units, standardize 1C or .001C? Break API

2008-01-22 Thread David Fries
. It would be easier to parse. If the conversion fails return 0 bytes. Just an idea, but if someone wants it they can write the patch. -- David Fries [EMAIL PROTECTED] http://fries.net/~david/ (PGP encryption key available) -- To unsubscribe from this list: send the line unsubscribe linux-kernel

[PATCH] W1: w1_therm.c standardize units to millidegrees C

2008-01-23 Thread David Fries
as it will now be 1000 times bigger. Fortunately there can't be that many users out there, or some of these bugs will have been fixed by now, such as the negative C error (see previous patch) that makes me think the ds18b20 is the better choice to change because of the current bugs. Signed-off-by: David Fries

Re: [PATCH] W1: w1_therm.c standardize units to millidegrees C

2008-01-24 Thread David Fries
if they are detected without the driver constantly scanning the bus for the same old devices. By the way the default bus scan takes 7.7 seconds to complete and then sleeps 10 seconds before the next scan leaving the bus idle for only 56% of the time. -- David Fries [EMAIL PROTECTED] http

[2.6 patch] eepro100 resume patch

2007-07-13 Thread David Fries
. Signed-off-by: David Fries [EMAIL PROTECTED] Index: drivers/net/Kconfig === RCS file: /home/david/kernel/k/spacedout/patches/linux/drivers/net/Attic/Kconfig,v retrieving revision 1.1.2.1 diff -u -r1.1.2.1 Kconfig --- drivers/net

Re: [2.6 patch] eepro100 resume patch

2007-07-14 Thread David Fries
On Fri, Jul 13, 2007 at 09:11:28PM -0700, Kok, Auke wrote: [adding netdev] David Fries wrote: When I did a software suspend to disk then resumed the Intel network card using eepro100 driver would be unable to transmit packets. I tracked this down and found a register write after the print

Re: [PATCH 1/1] Add strong pullup emulation to w1-gpio master driver.

2013-11-12 Thread David Fries
On Tue, Nov 12, 2013 at 05:07:14AM +0400, Evgeny Boger wrote: +David Fries da...@fries.net Hi David, Would you please comment on this? On Mon, Nov 11, 2013 at 06:36:54PM +0400, Evgeny Boger wrote: Strong pullup is emulated by driving pin logic high after write command when using tri

Re: [PATCH 1/1] Add strong pullup emulation to w1-gpio master driver.

2013-11-12 Thread David Fries
On Wed, Nov 13, 2013 at 05:15:52AM +0400, Evgeny Boger wrote: 11/12/2013 12:01 PM, David Fries: On Tue, Nov 12, 2013 at 05:07:14AM +0400, Evgeny Boger wrote: +David Fries da...@fries.net Hi David, Would you please comment on this? On Mon, Nov 11, 2013 at 06:36:54PM +0400, Evgeny Boger

[PATCH] w1: bundle reply if the request was bundled

2014-02-18 Thread David Fries
A program can bundle multiple messages and commands together when making one wire requests, which is going to be much more efficient than sending lots of little packets one write at a time. With this change the kernel will then bundle responses to requests that were bundled, where it's probably

Re: [patch] w1: small type cleanup in sysfs

2014-02-11 Thread David Fries
one despite the tmp 1 check. Acked-by: David Fries da...@fries.net On Tue, Feb 11, 2014 at 07:08:26PM +0300, Dan Carpenter wrote: On 64 bit systems, a large value for tmp could be truncated so we still end up with a -max_slave_count which is less than one despite the tmp 1 check

[RFC] w1: fixes and bundling replies

2014-03-22 Thread David Fries
On Fri, Feb 21, 2014 at 01:07:28AM +0400, Evgeniy Polyakov wrote: Your approach and patch seem correct, but I worry about how old commands are processed. Do I get it right, that replies to old non-bundle commands are queued back instead of sending immediately, but since it is not bundle but

[PATCH 1/3] w1: fix netlink refcnt leak on error path

2014-03-22 Thread David Fries
. Signed-off-by: David Fries da...@fries.net --- drivers/w1/w1_netlink.c | 44 ++-- 1 file changed, 26 insertions(+), 18 deletions(-) diff --git a/drivers/w1/w1_netlink.c b/drivers/w1/w1_netlink.c index 5234964..a02704a 100644 --- a/drivers/w1/w1_netlink.c

[PATCH 2/3] connector: allow multiple messages to be sent in one packet

2014-03-22 Thread David Fries
identifies there being multiple of the next. Signed-off-by: David Fries da...@fries.net --- Documentation/connector/connector.txt | 13 ++--- drivers/connector/connector.c | 17 +++-- include/linux/connector.h |1 + 3 files changed, 26 insertions(+), 5

[PATCH 3/3] w1: optional bundling of netlink kernel replies

2014-03-22 Thread David Fries
such as the data returned from a read. Signed-off-by: David Fries da...@fries.net Some of the common variable names have been standardized as follows. struct cn_msg *cn struct w1_netlink_msg *msg struct w1_netlink_cmd *cmd struct w1_master *dev When an argument and a function scope variable would collide, add

Re: [PATCH] w1: Fix refcount leak in netlink connector

2014-03-23 Thread David Fries
-- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- David Fries da...@fries.netPGP pub CB1EE8F0 http

Re: [PATCH] w1: do not unlock unheld list_mutex in __w1_remove_master_device()

2014-05-06 Thread David Fries
On Wed, May 07, 2014 at 01:42:12AM +0400, Alexey Khoroshilov wrote: On 01.05.2014 07:48, David Fries wrote: On Thu, May 01, 2014 at 12:37:58AM +0400, Alexey Khoroshilov wrote: w1_process_callbacks() expects to be called with dev-list_mutex held, but it is the fact only in w1_process

Re: [PATCH v2] w1: do not unlock unheld list_mutex in __w1_remove_master_device()

2014-05-06 Thread David Fries
Acked-by: David Fries da...@fries.net On Wed, May 07, 2014 at 01:26:04AM +0400, Alexey Khoroshilov wrote: w1_process_callbacks() expects to be called with dev-list_mutex held, but it is the fact only in w1_process(). __w1_remove_master_device() calls w1_process_callbacks() after it releases

[PATCH 0/4] w1: refcnt fix, skip non-error send, docs

2014-02-02 Thread David Fries
I could submit these patches as in, which would require the previous set, or I could merge the documentation into the previous set and resubmit them all since they haven't made it into the kernel tree yet. Opinions? Here's a small refcnt fix, skipping sending non-error messages, and documentation

[PATCH 4/4] w1: update cn_netlink_send documentation

2014-02-02 Thread David Fries
Signed-off-by: David Fries da...@fries.net --- Documentation/connector/connector.txt | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/Documentation/connector/connector.txt b/Documentation/connector/connector.txt index e5c5f5e..9bdfc1a 100644 --- a/Documentation

[PATCH 2/4] w1: only send_error when there is an error

2014-02-02 Thread David Fries
Otherwise there's an extra reply being sent out for each async message. Some commands such as W1_CMD_LIST_SLAVES will be identical except one message has data and the other doesn't making it difficult for a program to know if all the slaves just vanished or what happened. Signed-off-by: David

[PATCH 1/4] w1: fix netlink refcnt leak on error path

2014-02-02 Thread David Fries
. Signed-off-by: David Fries da...@fries.net --- drivers/w1/w1_netlink.c | 44 ++-- 1 file changed, 26 insertions(+), 18 deletions(-) diff --git a/drivers/w1/w1_netlink.c b/drivers/w1/w1_netlink.c index 5234964..a02704a 100644 --- a/drivers/w1/w1_netlink.c

[PATCH 3/4] w1: document struct w1_netlink_msg and struct w1_netlink_cmd

2014-02-02 Thread David Fries
I wasn't sure on the length, so I looked it up and documented it. Signed-off-by: David Fries da...@fries.net --- drivers/w1/w1_netlink.h | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/w1/w1_netlink.h b/drivers/w1/w1_netlink.h index 1e9504e..c646a98

Re: [PATCH 0/4] w1: refcnt fix, skip non-error send, docs

2014-02-03 Thread David Fries
On Tue, Feb 04, 2014 at 03:59:38AM +0400, z...@ioremap.net wrote: Hi 03.02.2014, 05:15, David Fries da...@fries.net:  I could submit these patches as in, which would require the previous  set, or I could merge the documentation into the previous set and  resubmit them all since

[PATCH 16/16] hold bus_mutex in netlink and search

2014-01-14 Thread David Fries
netlink and /sys slaves were executing bus commands at the same time. Signed-off-by: David Fries da...@fries.net --- This fixes existing bugs, tacking it to the end of the previous patch series. drivers/w1/masters/ds1wm.c |4 +++- drivers/w1/masters/ds2490.c |8 ++-- drivers/w1

Re: [PATCH 16/16] hold bus_mutex in netlink and search

2014-01-15 Thread David Fries
15.01.2014, 08:52, David Fries da...@fries.net: The bus_mutex needs to be taken to serialize access to a specific bus. netlink wasn't updated when bus_mutex was added and was calling without that lock held, and not all of the masters were holding the bus_mutex in a search.  This was causing

[PATCH 00/14] w1: async netlink, search, fixes, and improvements

2014-01-15 Thread David Fries
This patch series aims to extend and improve the netlink interface to the one wire system. Netlink is exposed as a socket interface which is normally assumed to be asynchronous which only blocks waiting on incoming packets or a fulls end buffer, but were executed on the calling thread. A bus

[PATCH 01/15] w1: fix w1_send_slave dropping a slave id

2014-01-15 Thread David Fries
, there is space. Instead, if there isn't space send and clear the buffer, then there is always space for the slave id. Signed-off-by: David Fries da...@fries.net Cc: sta...@vger.kernel.org Acked-by: Evgeniy Polyakov z...@ioremap.net --- drivers/w1/w1_netlink.c | 25 + 1 file

[PATCH 02/15] w1: fixup search to support abort from netlink

2014-01-15 Thread David Fries
early if the hardware is removed in the middle of a search. Signed-off-by: David Fries da...@fries.net Acked-by: Evgeniy Polyakov z...@ioremap.net Cc: Marcin Jurkowski marci...@gmail.com Cc: Josh Boyer jwbo...@gmail.com Cc: Sven Geggus li...@fuchsschwanzdomain.de --- drivers/w1/w1.c |3

[PATCH 03/15] w1: Only wake up the search process if it is going to be searching

2014-01-15 Thread David Fries
It's valid to set the search count to 0 to stop searching, so don't wake up the search thread to not search. Signed-off-by: David Fries da...@fries.net Acked-by: Evgeniy Polyakov z...@ioremap.net --- drivers/w1/w1.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 05/15] w1: continue slave search where previous left off

2014-01-15 Thread David Fries
Search will detect at most max_slave_count devices per run, if there are more pick up the next search where the previous left off. Signed-off-by: David Fries da...@fries.net Acked-by: Evgeniy Polyakov z...@ioremap.net --- drivers/w1/w1.c | 18 +++--- drivers/w1/w1.h |3 +++ 2

[PATCH 04/15] w1: increase w1_max_slave_count, allow write access

2014-01-15 Thread David Fries
the first time the count is reached and there were more devices to discover to let the user know why not all the devices were found. Signed-off-by: David Fries da...@fries.net Acked-by: Evgeniy Polyakov z...@ioremap.net --- drivers/w1/w1.c | 30 -- drivers/w1/w1.h |2

[PATCH 09/15] w1: reply only to the requester portid

2014-01-15 Thread David Fries
such as add/remove master/slave devices. Signed-off-by: David Fries da...@fries.net Acked-by: Evgeniy Polyakov z...@ioremap.net --- drivers/w1/w1.h |5 + drivers/w1/w1_netlink.c | 42 +- 2 files changed, 30 insertions(+), 17 deletions(-) diff --git

[PATCH 08/15] connector: add portid to unicast in addition to broadcasting

2014-01-15 Thread David Fries
This allows replying only to the requestor portid while still supporting broadcasting. Pass 0 to portid for the previous behavior. Signed-off-by: David Fries da...@fries.net Acked-by: Evgeniy Polyakov z...@ioremap.net --- Documentation/connector/cn_test.c |2 +- drivers/connector

[PATCH 06/15] w1: new netlink commands, add/remove/list slaves

2014-01-15 Thread David Fries
memory when needed, so move kzalloc into w1_get_slaves where it was used. Signed-off-by: David Fries da...@fries.net Acked-by: Evgeniy Polyakov z...@ioremap.net --- drivers/w1/w1.c |6 +-- drivers/w1/w1.h |3 ++ drivers/w1/w1_netlink.c | 125

[PATCH 07/15] w1: process w1 netlink commands in w1_process thread

2014-01-15 Thread David Fries
Netlink is a socket interface and is expected to be asynchronous. Clients can now make w1 requests without blocking by making use of the w1_master thread to process netlink commands which was previously only used for doing an automatic bus search. Signed-off-by: David Fries da...@fries.net Acked

[PATCH 10/15] w1: ds2490 reduce magic numbers

2014-01-15 Thread David Fries
Use a #define for the usb vendor request type, clear the status byte and use that instead of a magic offset in checking if idle. Signed-off-by: David Fries da...@fries.net Acked-by: Evgeniy Polyakov z...@ioremap.net --- drivers/w1/masters/ds2490.c | 23 +++ 1 file changed

[PATCH 11/15] w1: ds2490 USB setup fixes

2014-01-15 Thread David Fries
as it is an interrupt pipe (bulk worked, it was just technically the wrong call). Signed-off-by: David Fries da...@fries.net Acked-by: Evgeniy Polyakov z...@ioremap.net --- drivers/w1/masters/ds2490.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git

[PATCH 12/15] w1: ds2490 fix and enable hardware search

2014-01-15 Thread David Fries
went from 23.16 seconds to about 3 seconds, this takes the time for the search down to .307346 seconds. Signed-off-by: David Fries da...@fries.net Acked-by: Evgeniy Polyakov z...@ioremap.net --- Documentation/w1/masters/ds2490 |2 - drivers/w1/masters/ds2490.c | 108

[PATCH 13/15] w1: use family_data instead of rom in w1_slave

2014-01-15 Thread David Fries
to do with that printed temperature value. Modify the code to store the last good conversion in family_data, which is designed for custom data structures. Signed-off-by: David Fries da...@fries.net Acked-by: Evgeniy Polyakov z...@ioremap.net --- drivers/w1/slaves/w1_therm.c | 21

[PATCH 15/15] w1: hold bus_mutex in netlink and search

2014-01-15 Thread David Fries
netlink and /sys slaves were executing bus commands at the same time. Signed-off-by: David Fries da...@fries.net Acked-by: Evgeniy Polyakov z...@ioremap.net --- drivers/w1/masters/ds1wm.c |4 +++- drivers/w1/masters/ds2490.c |8 ++-- drivers/w1/w1_netlink.c | 13 +++-- 3

[PATCH 14/15] w1: format for DocBook and fixes

2014-01-15 Thread David Fries
Switch the code documentation format style to DocBook format, enable DocBook documentation generation, and fix some comments. Signed-off-by: David Fries da...@fries.net Acked-by: Evgeniy Polyakov z...@ioremap.net --- Documentation/DocBook/Makefile |2 +- Documentation/DocBook/w1.tmpl | 101

pull w1 updates to linux-next?

2014-01-15 Thread David Fries
merged upstream won't be updated unless I have another set of changes. cd5f76716a37ebef3e8b771d672ba552a25dafd5 git://github.com/dfries/linux.git w1_rework -- David Fries da...@fries.netPGP pub CB1EE8F0 http://fries.net/~david/ -- To unsubscribe from this list: send the line unsubscribe linux

[PATCH 03/14] w1: Only wake up the search process if it is going to be searching

2013-12-28 Thread David Fries
It's valid to set the search count to 0 to stop searching, so don't wake up the search thread to not search. Signed-off-by: David Fries da...@fries.net Cc: Evgeniy Polyakov z...@ioremap.net --- drivers/w1/w1.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/w1

[PATCH 01/14] w1: fix w1_send_slave dropping a slave id

2013-12-28 Thread David Fries
, there is space. Instead, if there isn't space send and clear the buffer, then there is always space for the slave id. Signed-off-by: David Fries da...@fries.net Cc: sta...@vger.kernel.org Cc: Evgeniy Polyakov z...@ioremap.net --- drivers/w1/w1_netlink.c | 25 + 1 file

[PATCH 02/14] w1: fixup search to support abort from netlink

2013-12-28 Thread David Fries
early if the hardware is removed in the middle of a search. Signed-off-by: David Fries da...@fries.net Cc: Evgeniy Polyakov z...@ioremap.net Cc: Marcin Jurkowski marci...@gmail.com Cc: Josh Boyer jwbo...@gmail.com Cc: Sven Geggus li...@fuchsschwanzdomain.de --- drivers/w1/w1.c |3 +-- drivers

[PATCH 14/14] w1: format for DocBook and fixes

2013-12-28 Thread David Fries
Switch the code documentation format style to DocBook format, enable DocBook documentation generation, and fix some comments. Signed-off-by: David Fries da...@fries.net Cc: Evgeniy Polyakov z...@ioremap.net --- Documentation/DocBook/Makefile |2 +- Documentation/DocBook/w1.tmpl | 101

[PATCH 06/14] w1: new netlink commands, add/remove/list slaves

2013-12-28 Thread David Fries
memory when needed, so move kzalloc into w1_get_slaves where it was used. Signed-off-by: David Fries da...@fries.net Cc: Evgeniy Polyakov z...@ioremap.net --- drivers/w1/w1.c |6 +-- drivers/w1/w1.h |3 ++ drivers/w1/w1_netlink.c | 125

[PATCH 10/14] w1: ds2490 reduce magic numbers

2013-12-28 Thread David Fries
Use a #define for the usb vendor request type, clear the status byte and use that instead of a magic offset in checking if idle. Signed-off-by: David Fries da...@fries.net Cc: Evgeniy Polyakov z...@ioremap.net --- drivers/w1/masters/ds2490.c | 23 +++ 1 file changed, 15

[PATCH 07/14] w1: process w1 netlink commands in w1_process thread

2013-12-28 Thread David Fries
Netlink is a socket interface and is expected to be asynchronous. Clients can now make w1 requests without blocking by making use of the w1_master thread to process netlink commands which was previously only used for doing an automatic bus search. Signed-off-by: David Fries da...@fries.net Cc

[PATCH 08/14] connector: add portid to unicast in addition to broadcasting

2013-12-28 Thread David Fries
This allows replying only to the requestor portid while still supporting broadcasting. Pass 0 to portid for the previous behavior. Signed-off-by: David Fries da...@fries.net Cc: Evgeniy Polyakov z...@ioremap.net --- Documentation/connector/cn_test.c |2 +- drivers/connector/cn_proc.c

[PATCH 12/14] w1: ds2490 fix and enable hardware search

2013-12-28 Thread David Fries
went from 23.16 seconds to about 3 seconds, this takes the time for the search down to .307346 seconds. Signed-off-by: David Fries da...@fries.net Cc: Evgeniy Polyakov z...@ioremap.net --- Documentation/w1/masters/ds2490 |2 - drivers/w1/masters/ds2490.c | 108

[PATCH 04/14] w1: increase w1_max_slave_count, allow write access

2013-12-28 Thread David Fries
the first time the count is reached and there were more devices to discover to let the user know why not all the devices were found. Signed-off-by: David Fries da...@fries.net Cc: Evgeniy Polyakov z...@ioremap.net --- drivers/w1/w1.c | 30 -- drivers/w1/w1.h |2 ++ 2

[PATCH 09/14] w1: reply only to the requester portid

2013-12-28 Thread David Fries
such as add/remove master/slave devices. Signed-off-by: David Fries da...@fries.net Cc: Evgeniy Polyakov z...@ioremap.net --- drivers/w1/w1.h |5 + drivers/w1/w1_netlink.c | 42 +- 2 files changed, 30 insertions(+), 17 deletions(-) diff --git

[PATCH 13/14] w1: use family_data instead of rom in w1_slave

2013-12-28 Thread David Fries
to do with that printed temperature value. Modify the code to store the last good conversion in family_data, which is designed for custom data structures. Signed-off-by: David Fries da...@fries.net Cc: Evgeniy Polyakov z...@ioremap.net --- drivers/w1/slaves/w1_therm.c | 21

[PATCH 11/14] w1: ds2490 USB setup fixes

2013-12-28 Thread David Fries
as it is an interrupt pipe (bulk worked, it was just technically the wrong call). Signed-off-by: David Fries da...@fries.net Cc: Evgeniy Polyakov z...@ioremap.net --- drivers/w1/masters/ds2490.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/w1

[PATCH 00/14] w1: async netlink, search, fixes, and improvements

2013-12-28 Thread David Fries
This patch series aims to extend and improve the netlink interface to the one wire system. Netlink is exposed as a socket interface which is normally assumed to be asynchronous which only blocks waiting on incoming packets or a fulls end buffer, but were executed on the calling thread. A bus

[PATCH 05/14] w1: continue slave search where previous left off

2013-12-28 Thread David Fries
Search will detect at most max_slave_count devices per run, if there are more pick up the next search where the previous left off. Signed-off-by: David Fries da...@fries.net Cc: Evgeniy Polyakov z...@ioremap.net --- drivers/w1/w1.c | 18 +++--- drivers/w1/w1.h |3 +++ 2 files

Re: w1: 3.14-rc7 - possible recursive locking detected

2014-03-23 Thread David Fries
w1_rework -- David Fries da...@fries.netPGP pub CB1EE8F0 http://fries.net/~david/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH] w1: do not unlock unheld list_mutex in __w1_remove_master_device()

2014-04-30 Thread David Fries
of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- David Fries da...@fries.netPGP pub CB1EE8F0 http://fries.net/~david/ -- To unsubscribe from this list: send the line unsubscribe

Re: [RFC] w1: fixes and bundling replies

2014-04-07 Thread David Fries
Evgeniy, Could you review this set of patches in this thread? Thanks. On Sat, Mar 22, 2014 at 08:27:44PM -0500, David Fries wrote: On Fri, Feb 21, 2014 at 01:07:28AM +0400, Evgeniy Polyakov wrote: Your approach and patch seem correct, but I worry about how old commands are processed. Do I

[PATCH 0/3] w1: fixes and bundling replies

2014-04-08 Thread David Fries
A program can bundle a sequence of commands in one netlink packet but the kernel was having to reply in many different packets, this adds a flag W1_CN_BUNDLE in the cn_msg.flags to allow the kernel to bundle the replies in to one message. This is opt in to avoid breaking programs that aren't

[PATCH 3/3] w1: optional bundling of netlink kernel replies

2014-04-08 Thread David Fries
such as the data returned from a read. Some of the common variable names have been standardized as follows. struct cn_msg *cn struct w1_netlink_msg *msg struct w1_netlink_cmd *cmd struct w1_master *dev When an argument and a function scope variable would collide, add req_ to the argument. Signed-off-by: David

[PATCH 1/3] w1: fix netlink refcnt leak on error path

2014-04-08 Thread David Fries
. Signed-off-by: David Fries da...@fries.net Acked-by: Evgeniy Polyakov z...@ioremap.net --- drivers/w1/w1_netlink.c | 44 ++-- 1 file changed, 26 insertions(+), 18 deletions(-) diff --git a/drivers/w1/w1_netlink.c b/drivers/w1/w1_netlink.c index 5234964

[PATCH 2/3] connector: allow multiple messages to be sent in one packet

2014-04-08 Thread David Fries
identifies there being multiple of the next. Signed-off-by: David Fries da...@fries.net Acked-by: Evgeniy Polyakov z...@ioremap.net --- Documentation/connector/connector.txt | 13 ++--- drivers/connector/connector.c | 17 +++-- include/linux/connector.h

Re: [PATCH 1/3] w1: fix netlink refcnt leak on error path

2014-04-08 Thread David Fries
window. Let me know if I should rewrite it for stable and which kernel version. The other two patches are more feature based changes. On Tue, Apr 08, 2014 at 10:37:07PM -0500, David Fries wrote: If the message type is W1_MASTER_CMD or W1_SLAVE_CMD, then a reference is taken when searching

[PATCH] w1: avoid recursive device_add

2014-04-16 Thread David Fries
are setup before the add goes out. Belisko Marek reported this change fixed the deadlock he was seeing on ARM device tree, while testing on my x86-64 system never saw the deadlock. Reported-by: Belisko Marek marek.beli...@gmail.com Signed-off-by: David Fries da...@fries.net --- Evgeniy any

Re: w1: 3.14-rc7 - possible recursive locking detected

2014-04-13 Thread David Fries
+0200, Belisko Marek wrote: Hi, On Mon, Mar 24, 2014 at 1:01 PM, Evgeniy Polyakov z...@ioremap.net wrote: Hi everyone 24.03.2014, 01:50, David Fries da...@fries.net: On Mon, Mar 17, 2014 at 10:38:13PM +0100, Belisko Marek wrote: booting latest 3.14-rc7 on gta04 board gives following

Re: [PATCH 0/4] w1: refcnt fix, skip non-error send, docs

2014-02-06 Thread David Fries
On Wed, Feb 05, 2014 at 03:48:45AM +0400, z...@ioremap.net wrote: Hi 04.02.2014, 09:51, David Fries da...@fries.net: Help me understand what the protocol is supposed to be.  Assuming there aren't any errors, is there supposed to be a w1_netlink_send_error generated reply per netlink

Re: [PATCH 0/4] w1: refcnt fix, skip non-error send, docs

2014-02-07 Thread David Fries
On Sat, Feb 08, 2014 at 01:23:43AM +0400, z...@ioremap.net wrote: Hi 07.02.2014, 10:00, David Fries da...@fries.net: Here's a patch to implement that.  Is this what you have in mind? From 4ed65d81b0121a8c191a9833d041484e9097198b Mon Sep 17 00:00:00 2001 From: David Fries da

Re: [PATCH] Revert ds1wm.c from w1: hold bus_mutex in netlink and search

2014-02-08 Thread David Fries
This reverts ds1wm.c from commit d3a8a9dbb903c73a7ec2deae4c9b7d74b6834f4c. Of the three files changed ds1wm.c ds2490.c and w1_netlink.c, it turns out ds1wm.c was locking bus_mutex, but inside the loop and I missed it. Reverting ds1wm.c to the previous version. Signed-off-by: David Fries da

[PATHC 0/2] cn: w1: buffer size checks

2014-11-10 Thread David Fries
Greg Kroah-Hartman, These issues were found by Dan Carpenter with a static checker and will check message buffer lengths from userspace or avoid length overflows. Evgeniy Polyakov has given his ack, and they can be applied to the stable branch as well. [PATCH 1/2] cn: verify msg-len before

[PATCH 1/2] cn: verify msg-len before making callback

2014-11-10 Thread David Fries
Acked-by: Evgeniy Polyakov z...@ioremap.net Signed-off-by: David Fries da...@fries.net --- drivers/connector/connector.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/connector/connector.c b/drivers/connector/connector.c index f612d68..30f5228 100644 --- a/drivers/connector

[PATCH 2/2] w1: avoid potential u16 overflow

2014-11-10 Thread David Fries
Reported-by: Dan Carpenter dan.carpen...@oracle.com Acked-by: Evgeniy Polyakov z...@ioremap.net Signed-off-by: David Fries da...@fries.net --- drivers/w1/w1_netlink.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/w1_netlink.c b/drivers/w1/w1_netlink.c index

[PATCH 2/2] w1: avoid potential u16 overflow

2014-11-09 Thread David Fries
Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: David Fries da...@fries.net --- drivers/w1/w1_netlink.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/w1_netlink.c b/drivers/w1/w1_netlink.c index dd96562..881597a 100644 --- a/drivers/w1

[PATHC 0/2] cn: w1: buffer size checks

2014-11-09 Thread David Fries
These issues were found by Dan Carpenter with a static checker. Evgeniy are you okay with these? [PATCH 1/2] cn: verify msg-len before making callback [PATCH 2/2] w1: avoid potential u16 overflow -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

[PATCH 1/2] cn: verify msg-len before making callback

2014-11-09 Thread David Fries
Signed-off-by: David Fries da...@fries.net --- drivers/connector/connector.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/connector/connector.c b/drivers/connector/connector.c index f612d68..30f5228 100644 --- a/drivers/connector/connector.c +++ b/drivers/connector/connector.c

Re: [PATCH 0/2] w1: slaves: w1_therm: Add sysfs entry for current temperature

2015-01-06 Thread David Fries
on this. Mariusz Gorski (2): w1: slaves: w1_therm: Extract read_rom function w1: slaves: w1_therm: Add temp attribute drivers/w1/slaves/w1_therm.c | 83 ++-- 1 file changed, 65 insertions(+), 18 deletions(-) -- 2.2.1 -- David Fries da...@fries.net

Re: [PATCH 0/2] w1: slaves: w1_therm: Add sysfs entry for current temperature

2015-01-06 Thread David Fries
-- David Fries da...@fries.netPGP pub CB1EE8F0 http://fries.net/~david/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH 2/2] w1: slaves: w1_therm: Add temp attribute

2015-01-06 Thread David Fries
wanted to point out that this returns without unlocking bus_mutex. -- David Fries da...@fries.netPGP pub CB1EE8F0 http://fries.net/~david/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

2015-03-17 Thread David Fries
On Sat, Mar 14, 2015 at 11:55:16PM +0300, Evgeniy Polyakov wrote: Hi David 12.03.2015, 03:54, David Fries da...@fries.net: Would that be removing all four refcnt, w1_slave, w1_master, w1_family, w1_cb_block, or just some of them?  It sounds good to me, if that had bugs there would

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

2015-03-18 Thread David Fries
On Wed, Mar 18, 2015 at 06:18:53PM +0300, Evgeniy Polyakov wrote: Hi 18.03.2015, 07:20, David Fries da...@fries.net:  static void w1_therm_remove_slave(struct w1_slave *sl)  { + int refcnt = atomic_sub_return(1, THERM_REFCNT(sl-family_data)); + while(refcnt) { + msleep(1000

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

2015-03-09 Thread David Fries
, but keeping the original sleep-time tm. Oops, sorry, it got lost in the shuffle, here's the first patch again (the others were for debugging and increase that time and so wouldn't go upstream anyway). From 777f5fd75f5f99a3352863e83d226c7b65ebdaa4 Mon Sep 17 00:00:00 2001 From: David Fries da

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

2015-03-11 Thread David Fries
a timed lock or try lock first. -- David Fries da...@fries.netPGP pub CB1EE8F0 http://fries.net/~david/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

2015-03-11 Thread David Fries
On Tue, Mar 10, 2015 at 04:52:00PM +0300, Evgeniy Polyakov wrote: Hi 10.03.2015, 02:09, David Fries da...@fries.net: diff --git a/drivers/w1/slaves/w1_therm.c b/drivers/w1/slaves/w1_therm.c index 1f11a20..39a9e6a 100644 --- a/drivers/w1/slaves/w1_therm.c +++ b/drivers/w1/slaves

  1   2   3   >