Hi folks,
does anyone know how to build an linux kernel for running on
the Zyxel G-570U router box ?
thx
--
-
Enrico Weigelt== metux IT service - http://www.metux.de
erated and picked dynamically via kprobes-alike approach. If the
device happens to be directly cpu-accessible, ops for direct memory
access are inserted, otherwise appropriate function calls. Or maybe
the bpf jit somehow could be abused for that ?
--mtx
--
Enrico Weigelt, metux IT consult
Free so
of the National Instruments hardware
(except those few which are supported by iio/comedi).
NI itself doesn't have any actually usable Linux support
(not even on ther Linux based cRIO controllers :o)
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
ame, *dst_uname;
+ u8 hashval[SHA1_DIGEST_SIZE] = { 0 };
+ char *cmdbuf;
+
+ if (!(cmdbuf = kzalloc(count, GFP_KERNEL)))
count is unbound, please apply a limit check.
ok.
+ {
+ char *walk = cmdbuf;
cmdbuf is toxic, make sure it is at least nul-terminated.
Am I missing something ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
/proc/self/setgroups': Permission denied
daemon@alphabox:~ unshare -f -r -U
unshare: can't open '/proc/self/setgroups': Permission denied
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
On 14.02.2018 12:30, Richard Weinberger wrote:
On Wed, Feb 14, 2018 at 12:27 PM, Enrico Weigelt wrote:
On 14.02.2018 11:24, Aleksa Sarai wrote:
What distribution are you using and which release?
On a self-compiled system.
Forgot to enable namespaces in the kernel. Now it seems to work
as
need an own user ns for private mnt ns ? (except for the suid
bit, which I wanna get rid of anyways).
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
Seems it fails to write the uid map.
Is the order of setgroups vs uid_map correct ?
What's the exact relation between user and mnt namespace ?
Why do I need an own user ns for private mnt ns ? (except for the suid
bit, which I wanna get rid of anyways).
mount related system calls are root-only. Therefore you need the user
namespace to become a root in your own little world. :)
I'm looking for a way to do that w/o being root (or something similar).
Actually, I don't like to change the user namespace, as it would cause
a lot of trouble w/ the /dev/cap[hash|use] devices, which I'm using for
user switching (as said: I'm going to get rid of suid completely).
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
lose(PATH_PROC_GIDMAP, uidmap_buf);
} else
if (setgrp_str) {
hmm, now it works, but only when strace'ing it.
that's really strange.
But still I wonder whether user_ns really solves my problem, as I don't
want to create sandboxed users, but only private namespaces just
interface w/ additional
parameters for that.
(and of course gplv3 as Al pointed out is a blocker)
already fixed.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
.
Yes, that's the plan :)
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
On 14.02.2018 19:12, Richard Weinberger wrote:
BTW: Your issue is fixed/known. Just checked.
aha, on 1.2.28 ... I'll have to upgrade.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
Hi folks,
in fork.c, a spinlock is held for fs_struct refcounting, while other
places - eg. switch_task_namespaces uses atomic_dec_and_test() on
the nsproxy.
What's the exact difference here ? Could the atomic counting also used
for fs_struct ?
--mtx
--
Enrico Weigelt, metux IT consult
On 15.02.2018 10:14, Richard Weinberger wrote:
On Wed, Feb 14, 2018 at 10:13 PM, Enrico Weigelt wrote:
Hi folks,
in fork.c, a spinlock is held for fs_struct refcounting, while other
places - eg. switch_task_namespaces uses atomic_dec_and_test() on
the nsproxy.
What's the exact diffe
using module aliases
(though that doesn't work for built-in drivers).
Configure by already compiled binaries ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
t out)
* only certain whitelisted filesystems allowed (eg. 9P and FUSE)
Maybe that all could be enabled by a new capability.
any suggestions ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
On 13.02.2018 22:12, Enrico Weigelt wrote:
CC @contain...@lists.linux-foundation.org
Hi folks,
I'm currently trying to implement plan9 semantics on Linux and
yet sorting out how to do the mount namespace handling.
On plan9, any unprivileged process can create its own namespace
and
esn't work for me (even as root). But docker works,
so user namespaces should be working. Any idea what could be wrong ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
Hi folks,
I've got device with some strange device that triggers two irqs via one
line. Rising means buffer A filled, falling mean buffer B filled.
I'd like to handle that via two separate interrupts. Is it possible to
register both an rising and an falling edge irq on the same line ?
--mtx
roid stuff, ...) went a long way towards mainline, some
still have a long way to go. That's just because it's these topics
are far from being trivial. And that shouldn't stop anybody.
> If I understand the context correctly, the previous "regime" could be
> the culprit
ing out how things work
> themselves, and sometimes there is just not enough time to say anything.
Yes. I've been demotivated by this problem myself. But I know, I can't
expect anybody else do to my homework for me.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
nately, I have no idea, what exactly you've seen in the mirror.
I can only judge on what I've seen here in the last decades. And I like
you exactly that way. Especially the rude part, eg. when it's about
corporations like NVidia, or people who try to refit the Kernel for
their broken userland stuff.
If I may propose a patches to your /dev/brain, the only issue would be
100% strict GPL enforcement ;-)
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
;
wouldn't it be better to #ifdef-out the whole code in this case ?
--mtx
--
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software
, both patches should be squashed into one, IMHO.
cu
--
Enrico Weigelt, metux IT consult
+49-151-27565287
MELAG Medizintechnik oHG Sitz Berlin Registergericht AG Charlottenburg HRA
21333 B
Wichtiger Hinweis: Diese Nachricht kann vertrauliche oder nur für einen
begrenzten Personenkreis bestimmte
edom is more than just $0 price)
And there shouldn't be any proprietary firmware anyways.
cu
--
Enrico Weigelt, metux IT consult
+49-151-27565287
MELAG Medizintechnik oHG Sitz Berlin Registergericht AG Charlottenburg HRA
21333 B
Wichtiger Hinweis: Diese Nachricht kann vertrauliche oder nur
Am 25.05.2015 um 09:14 schrieb Rob Landley:
Personally, I'm sad we're starting to get ACPI for arm but if device
tree data files are only available under GPL, people will hold their
nose and deploy ACPI.
What's the big deal with having DTS/DTB under GPL ?
cu
--
Enrico We
7;s now several weeks ago (IIRC, on rc1) - I'm currently rebasing
everything again to the recent master.
cu
--
Enrico Weigelt, metux IT consult
+49-151-27565287
MELAG Medizintechnik oHG Sitz Berlin Registergericht AG Charlottenburg HRA
21333 B
Wichtiger Hinweis: Diese Nachricht kann vertraulich
ow moved to Phillip's recent ipuv3 patches, but still
have lots of others (about 30) for my tqma53-based board, which might
be generic enough for going into mainline someday (many of them by
ptx folks).
Should I post them to lkml or somewhere else ?
cu
--
Enrico Weigelt, metux
st vendor DTBs
anyways. And I won't help people doing crippled proprietary stuff,
not at this critical point.
Even for larger systems - except the crippled x86 world - I won't even
allow any proprietary bootloader/firmware.
cu
--
Enrico Weigelt, metux IT consult
+49-151-27565287
MELA
ansputer grid ... but that's
going to be off-topic ...
This interface can be very low level (eg: CPU jumps to 0xffff upon reset),
> run a little bit of code to initialize some on-chip controllers and
Yes, and I need to know exactly how to do that initialization, so I can
p
Am 29.05.2015 um 17:01 schrieb Richard Weinberger:
Hi,
On Fri, May 29, 2015 at 4:53 PM, Enrico Weigelt, metux IT consult
wrote:
Am 29.05.2015 um 04:54 schrieb Luis R. Rodriguez:
Actually, I really wonder why folks are sticking to ancient kernels on
newer hardware.
Enterprise distribution
Am 29.05.2015 um 19:36 schrieb Theodore Ts'o:
> Yes, it's ugly, but there still are some SOC and drivers that aren't
available on newer kernels.
Why so, exactly ?
cu
--
Enrico Weigelt, metux IT consult
+49-151-27565287
MELAG Medizintechnik oHG Sitz Berlin Registergericht
ture). So, it ends up in having no
GPU, therefore no GL/GSL, therefore no QtQuick/QML.
Pavel already mentioned the correct way to go: chip vendors should
provide proper (mainline'able) patches, or at least full specs.
And I'll add: those who dont, should simply be boycotted.
cu
--
Enrico
to latest wireless-testing) and
stabilize that by cherry-picking individual patches on top of it.
Can you estimate the required workforce ?
Some statistics on that would be really nice.
cu
--
Enrico Weigelt, metux IT consult
+49-151-27565287
MELAG Medizintechnik oHG Sitz Berlin Register
alized in parallel.
Unfortunately, I've missed that ... could you please resend you patches?
Boot time reduction is one of the topics on my 2do in several weeks.
cu
--
Enrico Weigelt, metux IT consult
+49-151-27565287
MELAG Medizintechnik oHG Sitz Berlin Registergericht AG Charlottenburg HRA
213
hacks (eg. Freescale
is one of the worst). So I'll have to forward-port drivers to newer
kernels - but I never had the practical need to backport one.
Actually, I really wonder why folks are sticking to ancient kernels on
newer hardware.
--mtx
--
Enrico Weigelt, metux IT consult
+49-151-275
taining a copy.
P.S. some of us actually care about licenses being appropriate to what
they're applied to, and at least theoretically capable of being
honored. Your email footer may be very slightly undermining your
position here.
This is just a dumb auto-generated footer, coming from m
to be some
subsystem, similar to those for other bus'es (eg. pci, usb, ...) ?
Maybe that deserves a bit more documentation :p
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
is work (w/o introducing a massive security
hole) is disable suid for those processes (actually, one day i'd like to
get rid of it completely, but that's another story).
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
On 15.04.19 21:59, Aleksa Sarai wrote:
> Just spit-balling -- is no_new_privs not sufficient for this usecase?> Not
> granting privileges such as setuid during execve(2) is the main>
point of that flag.
Oh, I wasn't aware of that. Thanks.
--mtx
--
Enrico Weigelt, metu
But: how can we handle things like cgroups ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
we don't need to build in oftree probing stuff when oftree isn't
enabled at all.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/input/keyboard/gpio_keys_polled.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/gpio_keys_p
Instead of hardcoding the input name to the driver name
('gpio-keys-polled'), allow the passing a name via platform data
('name' field was already present), but default to old behaviour
in case of NULL.
Cc: Dmitry Torokhov
Cc: linux-in...@vger.kernel.org
Signed-off-by: Enri
Support the recently introduced gpio lookup tables for
attaching to gpio lines. So, harcoded gpio numbers aren't
needed anymore.
Cc: Dmitry Torokhov
Cc: linux-in...@vger.kernel.org
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/input/keyboard/gpio_keys_polled.c
Hello folks,
here're some improvements for the gpio-keys-polled driver.
The first patch isn't in the driver itself, but adds a little module helper
for conditionally declaring oftree module table if oftree is enabled
(only needed for the last patch)
have fun.
--mtx
Little helper macro that declares an oftree module device table,
if CONFIG_OF is enabled. Otherwise it's just noop.
This is also helpful if some drivers can be built w/ or w/o
oftree support.
Signed-off-by: Enrico Weigelt, metux IT consult
---
include/linux/mod_devicetable.h | 9 +++
his
own, narrow down some limits and pass this to some other agent that
acts on behalf of him and is allowed to use his share of the system
resources for that.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
nism, so the creating process can define what the holder of the
fd can actually do.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
mmands, eg. for sending
signals.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
s I
> mistakenly mentioned earlier) on a pidfd act *exactly* like a
> waitid(2) on the corresponding process and making POLLIN just mean
> "waitid will succeed". It's a nice simple model that's easy to reason
> about and that makes it easy to port existing code to pidf
useful, if another process can get the
same process handle via procfs. This also would allow the scenario
described above w/o srvfs: pidfiles could just be symlinks to the
corresponding /proc files.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
ctually duplicating the open file ? (maybe add a flag for
that to dup3 ?)
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
On 20.04.19 02:17, Christian Brauner wrote:
> It's not off the table that we can add a pidfd_open() if that becomes> a real
> thing.
What are the exact semantics of pidfd_open() ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.
some upcoming projects is
monitoring processes in a container from the outside.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
roject,>
independent of pidfds proper and of the very simple and effective> pidfd
system that Joel has proposed in his patch series.
At that point I'm wondering: what pidfd is actually meant for,
if not process monitoring ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and
Hello folks,
here're some fixes for libata to make NVME and TCG OPAL work:
* fix a little build break in nvme (forgotten include and Kconfig select)
* introduce sysctl knob for enabling tpm stuff at runtime
(sed-util expects since several years, so it seems that piece just might
have been fo
, etc. As we're dealing just w/ a plain boolean value, that's
only checked when an tpm-related ioctl is called, we're fine w/ that.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/libata-core.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/a
sgl_free(req->sg);
^~~~
ida_free
Cause:
1. missing include to
2. SGL_ALLOC needs to be enabled
Therefore adding the missing include, as well as Kconfig dependency.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/nvme/target/Kconfig | 1 +
drivers/nvme
Register a sysctl directory for libata, so upcoming knobs
can be added here.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/libata-core.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index adf2878
On 19.04.19 09:40, Dmitry Torokhov wrote:
> Hi Enrico,
>
> On Tue, Apr 16, 2019 at 09:57:22PM +0200, Enrico Weigelt, metux IT consult
> wrote:
>> Little helper macro that declares an oftree module device table,
>> if CONFIG_OF is enabled. Otherwise it's just noop.
igure that the generic solution will still take some time, so can we
take this one for the next merge window and rework it in the next one ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
Little helper macro that declares an oftree module device table,
if CONFIG_OF is enabled. Otherwise it's just noop.
This is also helpful if some drivers can be built w/ or w/o
oftree support.
Signed-off-by: Enrico Weigelt, metux IT consult
---
include/linux/mod_devicetable.h | 9 +++
be defined in asm/processor.h,>
> but proc_task_arch_status() has four parameters, I don't want
unnecessary> "struct pid_namespace *ns" and "struct pid *pid" leaked
into arch headers,> so I defined task_arch_status(m, task) to avoid that.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
ruct pid_namespace
>> *ns,
>> +struct pid *pid, struct task_struct *task)
>> +{
>> +task_arch_status(m, task);
>> +return 0;
>> +}
Is that wrapper really neeeded ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
ble to the user, so somebody who doesn't need
it, can just disable it.
(I, personally, tend to disable everything I don't need)
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/libahci_platform.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/ata/libahci_platform.c b
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/sata_gemini.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/ata/sata_gemini.c b/drivers
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/ahci_octeon.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/ata/ahci_octeon.c b/drivers/ata
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/sata_dwc_460ex.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/sata_rcar.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/ata/sata_rcar.c b/drivers/ata
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/pata_bk3710.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/ata/pata_bk3710.c b/drivers/ata
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/ahci_tegra.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/ata/ahci_tegra.c b
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/ahci_xgene.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/drivers/ata
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/ata/ahci_seattle.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/ata/ahci_seattle.c b/drivers/ata
n't checked yet).
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
On 12.03.19 10:17, Ben Dooks wrote:
> On 11/03/2019 18:54, Enrico Weigelt, metux IT consult wrote:
>> don't need the temporary variable "dev", directly use &pdev->dev
>>
>> Signed-off-by: Enrico Weigelt, metux IT consult
>
> This is qu
instead of fetching out start and len from a struct resource for
passing it to devm_ioremap(), directly use devm_ioremap_resource()
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/tty/serial/8250/8250_lpc18xx.c | 3 +--
drivers/tty/serial/8250/8250_mtk.c | 3 +--
drivers/tty
Use helper devm_ioremap_resource() to make the code a little bit
shorter and easier to read.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/tty/serial/8250/8250_dw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_dw.c
b/drivers/tty
Hello folks,
I'm currently working on some cleanups in drivers/tty/serial.
There're several cases where new helpers, like devm_platform_ioremap_resource
can be used, other places can use devm_ioremap_resource() for a bit
cleaner code.
Another topic here is using struct resource, instead of separ
---
drivers/tty/serial/vt8500_serial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/vt8500_serial.c
b/drivers/tty/serial/vt8500_serial.c
index 3d58e9b..331a9dd 100644
--- a/drivers/tty/serial/vt8500_serial.c
+++ b/drivers/tty/serial/vt8500_serial.c
@@ -69
The standard data structure for holding io resources in the
kernel is struct resource. Serial drivers yet don't really
use it (except when retrieving from oftree).
This patch introduces a new field in struct uart_port for that,
plus several helpers. Yet it's up to the individual drivers for
using
---
drivers/tty/serial/zs.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/tty/serial/zs.c b/drivers/tty/serial/zs.c
index b03d3e4..2fd4821 100644
--- a/drivers/tty/serial/zs.c
+++ b/drivers/tty/serial/zs.c
@@ -986,14 +986,13 @@ static void zs_relea
---
drivers/tty/serial/8250/8250_bcm2835aux.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_bcm2835aux.c
b/drivers/tty/serial/8250/8250_bcm2835aux.c
index bd53661..0738d14 100644
--- a/drivers/tty/serial/8250/8250_bcm2835aux.c
+++ b/
Use helper devm_ioremap_resource() to make the code a little bit
shorter and easier to read.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/tty/serial/8250/8250_ingenic.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_ingenic.c
b
---
drivers/tty/serial/xilinx_uartps.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/tty/serial/xilinx_uartps.c
b/drivers/tty/serial/xilinx_uartps.c
index 74089f5..92aff38 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_u
On 12.03.19 12:26, Thierry Reding wrote:
> You're not consistent within the series itself. In patch 3 you went the
> other way and dropped usage of pdev->dev in favour of the local dev
> variable.
ups, you got me :O
--
Enrico Weigelt, metux IT consult
Free software a
lle script for that. When I added
> that function I noticed there are 1200+ instances in the kernel that
> need fixing. I think we'll be better off automating it.
haven't coped w/ this yet ... I'll first need to have a deeper look
at it. advices welcomed.
--mtx
--
Enrico Weig
, using w/o requesting/claiming - isn't that a bug ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
andle module
targets like we do in the kernel, etc).
I'll yet have to find a decent way for syncing w/ the kernel, while
retaining history. Maybe some filter-branch + rebase voodoo ;-)
Feel free to play around :)
https://github.com/metux/kconfig
--mtx
--
Enrico Weigelt, metux IT consul
On 13.03.19 00:54, Andrew Jeffery wrote:
>
> For the ASPEED bits:
>
> Acked-by: Andrew Jeffery
>
shall I split the patch ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
On 12.03.19 17:33, Greg KH wrote:
> On Tue, Mar 12, 2019 at 03:57:33PM +0100, Enrico Weigelt, metux IT consult
> wrote:
>> ---
>> drivers/tty/serial/8250/8250_bcm2835aux.c | 12
>> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> No changelog or si
r for early>
reviewers simply by not having written an explanation or at least a>
reference to the explanation.
Understood.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
later
use it consistently ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
nx_devtable.c
> +> +extern PCI_BOARD snx_pci_board_conf[];
> +
> +
> +why all these extern functions ?
> +
> function definition in multiple .c files.
it's not a function, but an array of structs.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
+subsystem.
> +
> +can i drop it ? it seems that it has no effect when port gone away.
If it's not needed, remove it. We don't like dead code.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
On 07.04.19 23:09, Khz2020 wrote:
> Please see attached. It was working fine prior to installing Canon linux
> drivers. CUPS disconnect maybe?
Wrong list. This maillist is about the linux KERNEL, whilst your problem
is about CUPS. So, please ask the CUPS folks.
--mtx
--
Enrico Weigelt,
form/x86/pcengines-apuv2.c
vs.
drivers/gpio/gpio-amd-fch.c
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
On 11.02.21 12:41, Andy Shevchenko wrote:
Hi,
On Thu, Feb 11, 2021 at 1:15 PM Enrico Weigelt, metux IT consult
wrote:
On 10.02.21 11:30, Andy Shevchenko wrote:
Use cases are boards with non-oftree firmware (ACPI, etc) where certain
platform devices can't be directly enumerate
On 11.02.21 21:13, Rob Herring wrote:
On Mon, Feb 8, 2021 at 10:58 AM Enrico Weigelt, metux IT consult
wrote:
Also print out the phandle ID on error message, as a debug aid.
I already have this patch applied in my tree. Why do you keep sending it?
Sorry, didn't know that when sendi
1 - 100 of 937 matches
Mail list logo
