Re: [PATCH] MAINTAINERS/vfio-ccw: add Farhan and Eric, make Halil Reviewer

2018-12-12 Thread Eric Farman
On 12/12/2018 09:59 AM, Christian Borntraeger wrote: Eric and Farhan will help with maintaining vfio-ccw. Cc: Cornelia Huck Cc: Halil Pasic Cc: Farhan Ali Cc: Eric Farman Signed-off-by: Christian Borntraeger --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

Re: [PATCH v3 2/6] vfio: ccw: Rework subchannel state on setup

2018-12-18 Thread Eric Farman
My questions to this patch from the original RFC series are still outstanding. :( https://marc.info/?l=linux-s390&m=154223063716128&w=2 On 11/28/2018 07:41 AM, Pierre Morel wrote: The subchannel enablement and the according setting to the VFIO_CCW_STATE_STANDBY state should only be done when

Re: [PATCH 1/1] s390/virtio_ccw: fix config change notifications

2024-06-13 Thread Eric Farman
ins about a missing 'Closes' tag. > Unfortunately I don't have an appropriate URL at hand. @Sebastian, > @Boqiao: do you have any suggetions? > --- >  drivers/s390/virtio/virtio_ccw.c | 4 +++- >  1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Eric Farman

Re: [PATCH v2] vfio iommu type1: Improve vfio_iommu_type1_pin_pages performance

2020-12-09 Thread Eric Farman
ned-off-by: Xiaoyang Xu (...) hi Cornelia Huck, Eric Farman, Zhenyu Wang, Zhi Wang vfio_pin_pages() accepts an array of unrelated iova pfns and processes each to return the physical pfn. When dealing with large arrays of contiguous iovas, vfio_iommu_type1_pin_pages is very inefficient bec

Re: [PATCH] s390: cio: Return -EFAULT if copy_to_user() fails

2021-03-01 Thread Eric Farman
On 3/1/21 8:13 AM, Heiko Carstens wrote: On Mon, Mar 01, 2021 at 08:01:33PM +0800, Wang Qing wrote: The copy_to_user() function returns the number of bytes remaining to be copied, but we want to return -EFAULT if the copy doesn't complete. Signed-off-by: Wang Qing --- drivers/s390/cio/vfi

Re: [PATCH v2] vfio iommu type1: Improve vfio_iommu_type1_pin_pages performance

2020-12-14 Thread Eric Farman
On 12/10/20 8:56 AM, xuxiaoyang (C) wrote: On 2020/12/9 22:42, Eric Farman wrote: On 12/9/20 6:54 AM, Cornelia Huck wrote: On Tue, 8 Dec 2020 21:55:53 +0800 "xuxiaoyang (C)" wrote: On 2020/11/21 15:58, xuxiaoyang (C) wrote: vfio_pin_pages() accepts an array of unrelated

Re: [PATCH v3 1/1] vfio-ccw: Enable transparent CCW IPL from DASD

2020-05-06 Thread Eric Farman
On 5/5/20 8:15 PM, Jared Rossi wrote: > Remove the explicit prefetch check when using vfio-ccw devices. > This check does not trigger in practice as all Linux channel programs > are intended to use prefetch. > > It is expected that all ORBs issued by Linux will request prefetch. > Although non-

Re: [PATCH v4 1/1] vfio-ccw: Enable transparent CCW IPL from DASD

2020-05-06 Thread Eric Farman
a channel program that > is dependent on non-prefetch. > > Signed-off-by: Jared Rossi Reviewed-by: Eric Farman > --- > Documentation/s390/vfio-ccw.rst | 6 ++ > drivers/s390/cio/vfio_ccw_cp.c | 19 --- > 2 files changed, 18 insertions(+), 7 deletions(-)

Re: [PATCH v2 0/4] KVM: optimize the kvm_vcpu_on_spin

2017-08-10 Thread Eric Farman
On 08/08/2017 04:14 AM, Longpeng (Mike) wrote: On 2017/8/8 15:41, Cornelia Huck wrote: On Tue, 8 Aug 2017 12:05:31 +0800 "Longpeng(Mike)" wrote: This is a simple optimization for kvm_vcpu_on_spin, the main idea is described in patch-1's commit msg. I think this generally looks good now

sysbench throughput degradation in 4.13+

2017-09-12 Thread Eric Farman
Hi Peter, Rik, Running sysbench measurements in a 16CPU/30GB KVM guest on a 20CPU/40GB s390x host, we noticed a throughput degradation (anywhere between 13% and 40%, depending on test) when moving the host from kernel 4.12 to 4.13. The rest of the host and the entire guest remain unchanged; i

Re: sysbench throughput degradation in 4.13+

2017-09-27 Thread Eric Farman
On 09/27/2017 05:35 AM, Peter Zijlstra wrote: On Fri, Sep 22, 2017 at 12:12:45PM -0400, Eric Farman wrote: MySQL. We've tried a few different configs with both test=oltp and test=threads, but both show the same behavior. What I have settled on for my repro is the following:

Re: sysbench throughput degradation in 4.13+

2017-09-28 Thread Eric Farman
On 09/27/2017 01:58 PM, Rik van Riel wrote: On Wed, 27 Sep 2017 11:35:30 +0200 Peter Zijlstra wrote: On Fri, Sep 22, 2017 at 12:12:45PM -0400, Eric Farman wrote: MySQL. We've tried a few different configs with both test=oltp and test=threads, but both show the same behavior. What I

Re: sysbench throughput degradation in 4.13+

2017-09-22 Thread Eric Farman
On 09/13/2017 04:24 AM, 王金浦 wrote: 2017-09-12 16:14 GMT+02:00 Eric Farman : Hi Peter, Rik, Running sysbench measurements in a 16CPU/30GB KVM guest on a 20CPU/40GB s390x host, we noticed a throughput degradation (anywhere between 13% and 40%, depending on test) when moving the host from

Re: sysbench throughput degradation in 4.13+

2017-09-22 Thread Eric Farman
On 09/22/2017 11:53 AM, Peter Zijlstra wrote: On Fri, Sep 22, 2017 at 11:03:39AM -0400, Eric Farman wrote: Hi Peter, Rik, With OSS last week, I'm sure this got lost in the deluge, so here's a friendly ping. Very much so, inbox is a giant trainwreck ;-) My apologies. :) I