On Thu Jan 24 13, Greg Kroah-Hartman wrote:
> 3.0-stable review patch. If anyone has any objections, please let me know.
>
> --
>
> From: Alan Cox
>
> commit 7b4f6ecacb14f384adc1a5a67ad95eb082c02bd1 upstream.
>
> They don't always appear as AHCI class devices but instead as ID
Commit 13ad20c1 "x86 cpu_hotplug: unmap cpu2node when the cpu is
hotremoved" in linux-next added code to acpi_unmap_lsapic() that
causes section mismatch warnings:
WARNING: vmlinux.o(.text+0x694f2): Section mismatch in reference from the
function acpi_unmap_lsapic()
to the function .cpu
In 3.5 warning during build 'no previous prototype for term'. Since it
is only used in watchdog-test.c make term() static.
Signed-off-by: Jerry Snitselaar
---
Documentation/watchdog/src/watchdog-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentatio
On Thu, Jul 26, 2012 at 8:52 PM, Jerry Snitselaar wrote:
> In 3.5 warning during build 'no previous prototype for term'. Since it
> is only used in watchdog-test.c make term() static.
>
> Signed-off-by: Jerry Snitselaar
> ---
> Documentation/watchdog/src/watchdog-tes
Running 3.11.0-07547-g44598f9 I hit the following last night. I have
not had it reproduce since then. Should there be some lock cleanup in
the error path prior to the dput() call like unlock_rcu_walk()?
[ 1705.083706] ===
[ 1705.083709] [ INFO: suspicious RCU usage. ]
)
acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0)
Signed-off-by: Jerry Snitselaar
---
drivers/acpi/acpi_i2c.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/acpi/acpi_i2c.c b/drivers/acpi/acpi_i2c.c
index 82045e3..2c5c65d 100644
--- a/drivers/acpi/acpi_i2c.c
+++ b/dr
)
acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0)
Signed-off-by: Jerry Snitselaar
---
drivers/acpi/acpi_i2c.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/acpi/acpi_i2c.c b/drivers/acpi/acpi_i2c.c
index 82045e3..2c5c65d 100644
--- a/drivers/acpi/acpi_i2c.c
+++ b/dr
Sorry for the double send. This one was apparently blocked by the
greylisting on vger.kernel.org and it was hours before I received
notification of that. I forgot to bcc myself and had no record of the
git send-email successfully completing. Just ignore this patch.
Jerry
--
To unsubscribe from thi
On Tue Aug 20 13, Rafael J. Wysocki wrote:
> On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote:
> > On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote:
> > > Without MODULE_LICENSE set, I get the following with modprobe:
> > >
> > > a
On Tue Aug 20 13, Rafael J. Wysocki wrote:
> On Monday, August 19, 2013 04:35:29 PM Jerry Snitselaar wrote:
> > On Tue Aug 20 13, Rafael J. Wysocki wrote:
> > > On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote:
> > > > On Fri, Aug 16, 2013 at 06:26:35PM
On Tue Aug 20 13, Mika Westerberg wrote:
> On Mon, Aug 19, 2013 at 08:34:03PM -0700, Jerry Snitselaar wrote:
> > On Tue Aug 20 13, Rafael J. Wysocki wrote:
> > > On Monday, August 19, 2013 04:35:29 PM Jerry Snitselaar wrote:
> > > > On Tue Aug 20 13, Rafael J. Wyso
With the <= max condition in the for loop, it will be always go 1
element further than needed. If the condition for the while loop is
never met, then max is MAX_STAT_DEPTH, and for loop will walk off the
end of nodesizes[].
Signed-off-by: Jerry Snitselaar
---
net/ipv4/fib_trie.c | 2 +-
1 f
Currently there are error paths in btrfs_rm_device() where EINVAL is
returned telling the user they passed an invalid argument even though
they passed a valid device. Change to return EPERM instead as the
operation is not permitted.
Signed-off-by: Jerry Snitselaar
---
fs/btrfs/volumes.c | 8
With commit 28d528c8 "ASoC: core: Remove pointless error on card
registration failure", the variable ret is no longer used in
soc_probe() and generates an unused variable warning during a build.
Signed-off-by: Jerry Snitselaar
---
sound/soc/soc-core.c | 1 -
1 file changed, 1 deletio
On Wed Jul 25 12, Takao Indoh wrote:
> >Thanks for tracking this, Takao!
> >
> >I bet you are using x86_64 not x86 PAE? If so, could you try this patch
> >https://patchwork.kernel.org/patch/1195751/
> >? I already reviewed it.
>
> Great, I applied it and now kdump works. Thanks!
>
> Thanks,
> Tak
On Sat Aug 11 12, Jerry Snitselaar wrote:
> On Wed Jul 25 12, Takao Indoh wrote:
> > >Thanks for tracking this, Takao!
> > >
> > >I bet you are using x86_64 not x86 PAE? If so, could you try this patch
> > >https://patchwork.kernel.org/patch/1195751/
> >
eeded for
list cleanup in devcgroup_css_free().
Signed-off-by: Jerry Snitselaar
Acked-by: Tejun Heo
---
security/device_cgroup.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/security/device_cgroup.c b/security/device_cgroup.c
index d794abc..1c69e38 100644
--- a
eeded for
list cleanup in devcgroup_css_free().
Signed-off-by: Jerry Snitselaar
Acked-by: Tejun Heo
Acked-by: Aristeu Rozanski
---
security/device_cgroup.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/security/device_cgroup.c b/security/device_cgroup.c
index d794
On Wed Oct 25 17, Jarkko Sakkinen wrote:
On Wed, Oct 25, 2017 at 07:17:17AM -0700, Matthew Garrett wrote:
On Wed, Oct 25, 2017 at 6:44 AM, Jarkko Sakkinen
wrote:
> I'm implementing a fix for CVE-2017-15361 that simply blacklists
> vulnerable FW versions. I think this is the only responsible act
On Wed Oct 18 17, SF Markus Elfring wrote:
For 1/4 and 2/4: explain why the message can be omitted.
Why did you not reply directly with this request for the update steps
with the subject “Delete an error message for a failed memory allocation
in tpm_…()”?
https://patchwork.kernel.org/patch/100
On Wed May 23 18, Jarkko Sakkinen wrote:
On Fri, May 18, 2018 at 03:30:32PM -0700, Jerry Snitselaar wrote:
On Mon Mar 26 18, Jarkko Sakkinen wrote:
> In order to make struct tpm_buf the first class object for constructing TPM
> commands, migrate tpm2_shutdown() to use it. In addition, r
7
release as we are already late in the cycle?
Kind regards,
Laurent Bigonville
It should go into his branch during the merge window for 4.18.
Le 11/05/18 à 21:02, Laurent Bigonville a écrit :
Le 05/05/18 à 22:03, Jerry Snitselaar a écrit :
On Sat May 05 18, Jerry Snitselaar wrote:
F
-off-by: Jarkko Sakkinen
Reviewed-by: Jerry Snitselaar
---
drivers/char/tpm/tpm2-cmd.c | 44
1 file changed, 12 insertions(+), 32 deletions(-)
diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c
index 96c77c8e7f40..7665661d9230
On Mon Mar 26 18, Jarkko Sakkinen wrote:
In order to make struct tpm_buf the first class object for constructing TPM
commands, migrate tpm2_probe() to use it.
Signed-off-by: Jarkko Sakkinen
Acked-by: Jay Freyensee
Reviewed-by: Jerry Snitselaar
---
drivers/char/tpm/tpm2-cmd.c | 37
On Mon Mar 26 18, Jarkko Sakkinen wrote:
In order to make struct tpm_buf the first class object for constructing TPM
commands, migrate tpm2_get_tpm_pt() to use it.
Signed-off-by: Jarkko Sakkinen
Reviewed-by: Jerry Snitselaar
---
drivers/char/tpm/tpm2-cmd.c | 63
On Mon Nov 05 18, Jerry Snitselaar wrote:
On Fri Oct 19 18, Stefan Berger wrote:
Extend the documentation for trusted keys with documentation for how to
set up a key for a TPM 2.0 so it can be used with a TPM 2.0 as well.
Signed-off-by: Stefan Berger
Reviewed-by: Mimi Zohar
---
.../security
On Fri Oct 19 18, Stefan Berger wrote:
Extend the documentation for trusted keys with documentation for how to
set up a key for a TPM 2.0 so it can be used with a TPM 2.0 as well.
Signed-off-by: Stefan Berger
Reviewed-by: Mimi Zohar
Acked-by: Jerry Snitselaar
---
.../security/keys
On Fri Oct 19 18, Stefan Berger wrote:
Extend the documentation for trusted keys with documentation for how to
set up a key for a TPM 2.0 so it can be used with a TPM 2.0 as well.
Signed-off-by: Stefan Berger
Reviewed-by: Mimi Zohar
---
.../security/keys/trusted-encrypted.rst | 31 ++
Critical tracepoint hooks shoud never call anything that takes a lock,
so they are unable to call getrawmonotonic() or ktime_get().
Export the rest of the tracing clock functions so can be used in
tracepoint hooks.
Cc: Steven Rostedt
Cc: Ingo Molnar
Signed-off-by: Jerry Snitselaar
---
kernel
tracepoint hook to sched_wakeup. They were using ktime_get() for a
time source, but it grabs a seq lock and caused a deadlock to occur.
v2: added background info and fixed typo
Cc: Steven Rostedt
Cc: Ingo Molnar
Signed-off-by: Jerry Snitselaar
---
kernel/trace/trace_clock.c | 3 +++
1 file changed
On Fri May 29 20, Jerry Snitselaar wrote:
On Tue Apr 14 20, Joerg Roedel wrote:
Hi,
here is the second version of this patch-set. The first version with
some more introductory text can be found here:
https://lore.kernel.org/lkml/20200407183742.4344-1-j...@8bytes.org/
Changes v1->
On Mon Jun 01 20, Jerry Snitselaar wrote:
On Fri May 29 20, Jerry Snitselaar wrote:
On Tue Apr 14 20, Joerg Roedel wrote:
Hi,
here is the second version of this patch-set. The first version with
some more introductory text can be found here:
https://lore.kernel.org/lkml
On Tue Jun 02 20, Lu Baolu wrote:
Hi Jerry,
On 6/1/20 6:42 PM, Jerry Snitselaar wrote:
Hi Joerg,
With this patchset, I have an epyc system where if I boot with
iommu=nopt and force a dump I will see some io page faults for a nic
on the system. The vmcore is harvested and the system reboots
On Mon May 18 20, Joerg Roedel wrote:
On Fri, May 15, 2020 at 08:23:13PM +0100, Robin Murphy wrote:
But that's not what this is; this is (supposed to be) the exact same "don't
actually perform the attach yet" logic as before, just restricting it to
default domains in the one place that it actual
On Mon May 18 20, Joerg Roedel wrote:
On Fri, May 15, 2020 at 08:23:13PM +0100, Robin Murphy wrote:
But that's not what this is; this is (supposed to be) the exact same "don't
actually perform the attach yet" logic as before, just restricting it to
default domains in the one place that it actual
,7 +3191,7 @@ static void set_dte_irq_entry(u16 devid, struct
> irq_remap_table *table)
> dte &= ~DTE_IRQ_PHYS_ADDR_MASK;
> dte |= iommu_virt_to_phys(table->table);
> dte |= DTE_IRQ_REMAP_INTCTL;
> - dte |= DTE_IRQ_TABLE_LEN;
> + dte |= DTE_INTTABLEN;
> dte |= DTE_IRQ_REMAP_ENABLE;
>
> amd_iommu_dev_table[devid].data[2] = dte;
Reviewed-by: Jerry Snitselaar
e device table mapping entry (DTE).
>
> Fixes: 73db2fc595f3 ("iommu/amd: Increase interrupt remapping table limit to
> 512 entries")
> Reported-by: Jerry Snitselaar
> Signed-off-by: Suravee Suthikulpanit
> ---
> drivers/iommu/amd/amd_iommu_types.h | 2 +-
> 1 file
Matthew Garrett @ 2020-10-15 15:39 MST:
> On Thu, Oct 15, 2020 at 2:44 PM Jerry Snitselaar wrote:
>>
>> There is a misconfiguration in the bios of the gpio pin used for the
>> interrupt in the T490s. When interrupts are enabled in the tpm_tis
>> driver code this re
Will Deacon @ 2020-12-09 11:50 MST:
> On Wed, Dec 09, 2020 at 10:07:46AM -0800, Linus Torvalds wrote:
>> On Wed, Dec 9, 2020 at 6:12 AM Will Deacon wrote:
>> >
>> > Please pull this one-liner AMD IOMMU fix for 5.10. It's actually a fix
>> > for a fix, where the size of the interrupt remapping t
On Wed, Dec 9, 2020 at 12:12 PM Jerry Snitselaar wrote:
>
>
> Will Deacon @ 2020-12-09 11:50 MST:
>
> > On Wed, Dec 09, 2020 at 10:07:46AM -0800, Linus Torvalds wrote:
> >> On Wed, Dec 9, 2020 at 6:12 AM Will Deacon wrote:
> >> >
> >> > Plea
On Wed, Dec 9, 2020 at 12:18 PM Linus Torvalds
wrote:
>
> On Wed, Dec 9, 2020 at 11:12 AM Jerry Snitselaar wrote:
> >
> > Since the field in the device table entry format expects it to be n
> > where there are 2^n entries in the table I guess it should be:
> >
&
Hans de Goede @ 2020-11-19 07:42 MST:
> Hi,
>
> On 11/19/20 7:36 AM, Jerry Snitselaar wrote:
>>
>> Matthew Garrett @ 2020-10-15 15:39 MST:
>>
>>> On Thu, Oct 15, 2020 at 2:44 PM Jerry Snitselaar
>>> wrote:
>>>>
>>>>
Lu Baolu @ 2020-11-26 19:12 MST:
> Hi Jerry,
>
> On 11/27/20 5:35 AM, Jerry Snitselaar wrote:
>> Lu Baolu @ 2020-11-26 04:01 MST:
>>
>>> Hi Jerry,
>>>
>>> On 2020/11/26 4:27, Jerry Snitselaar wrote:
>>>> Is there a reason we check the
Jerry Snitselaar @ 2020-11-30 10:50 MST:
> Lu Baolu @ 2020-11-26 19:12 MST:
>
>> Hi Jerry,
>>
>> On 11/27/20 5:35 AM, Jerry Snitselaar wrote:
>>> Lu Baolu @ 2020-11-26 04:01 MST:
>>>
>>>> Hi Jerry,
>>>>
>>>> On
he problem occurring, disable interrupts, and revert to
polling when it happens.
Cc: Jarkko Sakkinen
Cc: Jason Gunthorpe
Cc: Peter Huewe
Cc: James Bottomley
Cc: Matthew Garrett
Cc: Hans de Goede
Signed-off-by: Jerry Snitselaar
---
drivers/char/tpm/tpm_tis_c
detect the problem occurring, disable interrupts, and revert to
polling when it happens.
Cc: Jarkko Sakkinen
Cc: Jason Gunthorpe
Cc: Peter Huewe
Cc: James Bottomley
Cc: Matthew Garrett
Cc: Hans de Goede
Signed-off-by: Jerry Snitselaar
---
v2: drop tpm_tis specific workqueue and use just system_w
Jerry Snitselaar @ 2020-11-30 19:58 MST:
> When enabling the interrupt code for the tpm_tis driver we have
> noticed some systems have a bios issue causing an interrupt storm to
> occur. The issue isn't limited to a single tpm or system manufacturer
> so keeping a denylist of
James Bottomley @ 2020-12-03 14:05 MST:
> On Thu, 2020-12-03 at 13:14 -0700, Jerry Snitselaar wrote:
>> Jerry Snitselaar @ 2020-12-02 23:11 MST:
> [...]
>> > The interrupt storm detection code works on the T490s. I'm not sure
>> > what is going on with the L
Huewe
Cc: James Bottomley
Cc: Matthew Garrett
Cc: Hans de Goede
Signed-off-by: Jerry Snitselaar
---
drivers/gpu/drm/i915/i915_pmu.c | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c
index
490 instead of
T490s.
Changes from v1:
- drop tpm_tis specific workqueue and use just system_w.
Jerry Snitselaar (4):
irq: export kstat_irqs
drm/i915/pmu: Use kstat_irqs to get interrupt count
tpm_tis: Disable interrupts if interrupt storm detected
tpm_tis: Disable Interr
detect the problem occurring, disable interrupts, and revert to
polling when it happens.
Cc: Jarkko Sakkinen
Cc: Jason Gunthorpe
Cc: Peter Huewe
Cc: James Bottomley
Cc: Matthew Garrett
Cc: Hans de Goede
Signed-off-by: Jerry Snitselaar
---
v3: - Change include from linux/kernel_stat.h to linu
Sakkinen
Cc: Jason Gunthorpe
Cc: Peter Huewe
Cc: James Bottomley
Cc: Matthew Garrett
Cc: Hans de Goede
Signed-off-by: Jerry Snitselaar
---
include/linux/irqdesc.h | 1 +
kernel/irq/irqdesc.c| 1 +
2 files changed, 2 insertions(+)
diff --git a/include/linux/irqdesc.h b/include/linux
Signed-off-by: Jerry Snitselaar
---
drivers/char/tpm/tpm_tis.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index 4ed6e660273a..7322e0986a83 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
Thomas Gleixner @ 2020-12-06 10:54 MST:
> Jerry,
>
> On Fri, Dec 04 2020 at 18:43, Jerry Snitselaar wrote:
>
> The proper prefix is 'genirq:' git log kernel/irq/irqdesc.c would have
> told you.
>
>> To try and detect potential interrupt storms that
>&g
Thomas Gleixner @ 2020-12-06 09:38 MST:
> On Fri, Dec 04 2020 at 18:43, Jerry Snitselaar wrote:
>
>> Now that kstat_irqs is exported, get rid of count_interrupts in
>> i915_pmu.c
>> --- a/drivers/gpu/drm/i915/i915_pmu.c
>> +++ b/drivers/gpu/drm/i915/i915_pmu.c
Jarkko Sakkinen @ 2020-11-23 20:26 MST:
> On Wed, Nov 18, 2020 at 11:36:20PM -0700, Jerry Snitselaar wrote:
>>
>> Matthew Garrett @ 2020-10-15 15:39 MST:
>>
>> > On Thu, Oct 15, 2020 at 2:44 PM Jerry Snitselaar
>> > wrote:
>> >>
>> &
Is there a reason we check the requested guest address width against the
iommu's mgaw, instead of the agaw that we already know for the iommu?
I've run into a case with a new system where the mgaw reported is 57,
but if they set PAE to 46 instead of 52 in the bios, then sagaw reports
the highest
Jerry Snitselaar @ 2020-11-30 20:26 MST:
> Jerry Snitselaar @ 2020-11-30 19:58 MST:
>
>> When enabling the interrupt code for the tpm_tis driver we have
>> noticed some systems have a bios issue causing an interrupt storm to
>> occur. The issue isn't limi
Suravee Suthikulpanit @ 2020-10-14 19:50 MST:
> Certain device drivers allocate IO queues on a per-cpu basis.
> On AMD EPYC platform, which can support up-to 256 cpu threads,
> this can exceed the current MAX_IRQ_PER_TABLE limit of 256,
> and result in the error message:
>
> AMD-Vi: Failed t
Jarkko Sakkinen @ 2020-12-02 09:49 MST:
> On Tue, Dec 01, 2020 at 12:59:23PM -0700, Jerry Snitselaar wrote:
>>
>> Jerry Snitselaar @ 2020-11-30 20:26 MST:
>>
>> > Jerry Snitselaar @ 2020-11-30 19:58 MST:
>> >
>> >> When enabling the interrup
Jerry Snitselaar @ 2020-12-02 17:02 MST:
> Jarkko Sakkinen @ 2020-12-02 09:49 MST:
>
>> On Tue, Dec 01, 2020 at 12:59:23PM -0700, Jerry Snitselaar wrote:
>>>
>>> Jerry Snitselaar @ 2020-11-30 20:26 MST:
>>>
>>> > Jerry Snitselaar @ 2
Jerry Snitselaar @ 2020-12-02 23:11 MST:
> Jerry Snitselaar @ 2020-12-02 17:02 MST:
>
>> Jarkko Sakkinen @ 2020-12-02 09:49 MST:
>>
>>> On Tue, Dec 01, 2020 at 12:59:23PM -0700, Jerry Snitselaar wrote:
>>>>
>>>> Jerry Snitselaar @ 2020-11-30
Lu Baolu @ 2020-11-26 04:01 MST:
> Hi Jerry,
>
> On 2020/11/26 4:27, Jerry Snitselaar wrote:
>> Is there a reason we check the requested guest address width against
>> the
>> iommu's mgaw, instead of the agaw that we already know for the iommu?
>> I'
Lu Baolu @ 2020-11-26 19:12 MST:
> Hi Jerry,
>
> On 11/27/20 5:35 AM, Jerry Snitselaar wrote:
>> Lu Baolu @ 2020-11-26 04:01 MST:
>>
>>> Hi Jerry,
>>>
>>> On 2020/11/26 4:27, Jerry Snitselaar wrote:
>>>> Is there a reason we check the
Fix coding style warnings reported by checkpath.
Signed-off-by: Jerry Snitselaar
---
drivers/staging/line6/capture.c | 3 +++
drivers/staging/line6/midi.c | 2 ++
drivers/staging/line6/playback.c | 6 +-
drivers/staging/line6/pod.c | 5 +
drivers/staging/line6/toneport.c | 2
Clean up of coding style warnings from checkpatch
Signed-off-by: Jerry Snitselaar
---
drivers/scsi/virtio_scsi.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index 16bfd50..fa0b25f 100644
--- a/drivers/scsi
Fix coding style warnings from checkpatch
Signed-off-by: Jerry Snitselaar
---
drivers/scsi/virtio_scsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index 9f2fccc..9248a1e 100644
--- a/drivers/scsi/virtio_scsi.c
Clean up sparse warnings for cred struct dereference.
Signed-off-by: Jerry Snitselaar
---
drivers/staging/android/binder.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index fc59281..6279d82
On Mon Aug 11 14, Nicholas Krause wrote:
> I am fixing the bug entry , https://bugzilla.kernel.org/show_bug.cgi?id=60461.
> This entry states that we are not checking the skb allocated in
> fw_download_code
> and after checking I fixed it to check for the NULL value before using the
> allocate
>
tpm_tis.c already gets actbl2.h via linux/acpi.h -> acpi/acpi.h ->
acpi/actbl.h -> acpi/actbl2.h, so the direct include in tpm_tis.c
is not needed.
Signed-off-by: Jerry Snitselaar
---
Jarrko, this is a trivial thing I noticed while doing some work.
Not sure if you guys care, but th
On Mon Jan 04 16, Jerry Snitselaar wrote:
tpm_tis.c already gets actbl2.h via linux/acpi.h -> acpi/acpi.h ->
acpi/actbl.h -> acpi/actbl2.h, so the direct include in tpm_tis.c
is not needed.
Signed-off-by: Jerry Snitselaar
---
Jarrko, this is a trivial thing I noticed while doing
On Mon Feb 22 16, Jarkko Sakkinen wrote:
On Mon, Feb 22, 2016 at 12:56:53PM +1100, James Morris wrote:
On Sat, 20 Feb 2016, Jarkko Sakkinen wrote:
> Hi James,
>
> I'm sorry for the late pull request for 4.5. The reason for this was
> the latency in my previous one. I picked with care the absolu
With commit b56fc3c53654 ("hv_netvsc: Fix a bug in netvsc_start_xmit()"),
skb variable is no longer used in netvsc_send. Remove variable and dead
code that depended on it.
Cc: Haiyang Zhang
Cc: K. Y. Srinivasan
Signed-off-by: Jerry Snitselaar
---
drivers/net/hyperv/netvsc.c | 9 ++
len.
Cleaned up the code a bit as well per suggestion of Steve Rostedt.
Cc: "Steven Rostedt (Red Hat)"
Signed-off-by: Jerry Snitselaar
---
lib/seq_buf.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/seq_buf.c b/lib/seq_buf.c
index 5c94e10..cb18469 100
On Thu Aug 29 19, Jarkko Sakkinen wrote:
On Thu, Aug 29, 2019 at 05:40:40PM +0300, Jarkko Sakkinen wrote:
On Tue, Aug 27, 2019 at 05:46:21PM -0700, Jerry Snitselaar wrote:
> There was revealed a bug in the STM TPM chipset used in Dell R415s.
> Bug is observed so far only on chipset fi
On Thu Aug 29 19, Jarkko Sakkinen wrote:
On Tue, Aug 27, 2019 at 05:46:21PM -0700, Jerry Snitselaar wrote:
There was revealed a bug in the STM TPM chipset used in Dell R415s.
Bug is observed so far only on chipset firmware 1.2.8.28
(1.2 TPM, device-id 0x0, rev-id 78). After some number of
On Thu Aug 29 19, Jarkko Sakkinen wrote:
Replace existing TPM 1.x version structs with new structs that consolidate
the common parts into a single struct so that code duplication is no longer
needed in caps_show().
Cc: Alexey Klimov
Cc: Jerry Snitselaar
Signed-off-by: Jarkko Sakkinen
We've run into a case where a customer has an STM TPM 1.2 chip
(version 1.2.8.28), that is getting into an inconsistent state and
they end up getting tpm transmit errors. In really old tpm code this
wasn't seen because the code that grabbed the duration values from the
chip could fail silently, an
implementation of ->update_durations method
that matches only STM devices with specific firmware version.
Cc: Peter Huewe
Cc: Jarkko Sakkinen
Cc: Jason Gunthorpe
Signed-off-by: Alexey Klimov
Signed-off-by: Jerry Snitselaar
---
v3: Rework update_durations to make use of new version structs
from
-by: Jerry Snitselaar
Tested-by: Jerry Snitselaar
---
drivers/char/tpm/tpm-sysfs.c | 44 ++--
drivers/char/tpm/tpm.h | 23 ---
2 files changed, 32 insertions(+), 35 deletions(-)
diff --git a/drivers/char/tpm/tpm-sysfs.c b/drivers/char/tpm/tpm
Patch adds method ->update_durations to override returned
durations in case TPM chip misbehaves for TPM 1.2 drivers.
Cc: Peter Huewe
Cc: Jarkko Sakkinen
Cc: Jason Gunthorpe
Signed-off-by: Alexey Klimov
Signed-off-by: Jerry Snitselaar
---
v3: no changes
v2: newline cleanup as requested
On Thu Aug 29 19, Jarkko Sakkinen wrote:
Replace existing TPM 1.x version structs with new structs that consolidate
the common parts into a single struct so that code duplication is no longer
needed in caps_show().
Cc: Alexey Klimov
Cc: Jerry Snitselaar
Signed-off-by: Jarkko Sakkinen
On Thu Aug 29 19, Jerry Snitselaar wrote:
From: Jarkko Sakkinen
Replace existing TPM 1.x version structs with new structs that consolidate
the common parts into a single struct so that code duplication is no longer
needed in caps_show().
Cc: Peter Huewe
Cc: Jason Gunthorpe
Cc: Alexey Klimov
1):
tpm: Remove duplicate code from caps_show() in tpm-sysfs.c
Jerry Snitselaar (2):
tpm: provide a way to override the chip returned durations
tpm_tis: override durations for STM tpm with firmware 1.2.8.28
Patch adds method ->update_durations to override returned
durations in case TPM chip misbehaves for TPM 1.2 drivers.
Cc: Peter Huewe
Cc: Jason Gunthorpe
Signed-off-by: Alexey Klimov
Signed-off-by: Jerry Snitselaar
Reviewed-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm1-cmd.c |
implementation of ->update_durations method
that matches only STM devices with specific firmware version.
Cc: Peter Huewe
Cc: Jarkko Sakkinen
Cc: Jason Gunthorpe
Signed-off-by: Alexey Klimov
Signed-off-by: Jerry Snitselaar
Reviewed-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm_tis_core.c |
-by: Jerry Snitselaar
Tested-by: Jerry Snitselaar
---
drivers/char/tpm/tpm-sysfs.c | 45 ++--
drivers/char/tpm/tpm.h | 23 --
2 files changed, 33 insertions(+), 35 deletions(-)
diff --git a/drivers/char/tpm/tpm-sysfs.c b/drivers/char/tpm/tpm
On Tue Sep 03 19, Doug Anderson wrote:
Hi,
On Tue, Sep 3, 2019 at 9:28 AM Sasha Levin wrote:
From: Vadim Sukhomlinov
[ Upstream commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 ]
TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling
future TPM operations. TPM 1.2 behavior
On Fri Aug 30 19, Jordan Hand wrote:
For systems with a TPM2 chip which use ACPI to expose event logs, retrieve the
crypto-agile event log from the TPM2 ACPI table. The TPM2 table is defined
in section 7.3 of the TCG ACPI Specification (see link).
The TPM2 table is used by SeaBIOS in place of th
implementation of ->update_durations method
that matches only STM devices with specific firmware version.
Cc: Peter Huewe
Cc: Jarkko Sakkinen
Cc: Jason Gunthorpe
Signed-off-by: Alexey Klimov
Signed-off-by: Jerry Snitselaar
---
v2: Make suggested changes from Jarkko
- change struct field name
Patch adds method ->update_durations to override returned
durations in case TPM chip misbehaves for TPM 1.2 drivers.
Cc: Peter Huewe
Cc: Jarkko Sakkinen
Cc: Jason Gunthorpe
Signed-off-by: Alexey Klimov
Signed-off-by: Jerry Snitselaar
---
v2: newline cleanup as requested by Jarkko
driv
We've run into a case where a customer has an STM TPM 1.2 chip
(version 1.2.8.28) that is getting into an inconsistent state and
they end up getting tpm transmit errors. In really old tpm code this
wasn't seen because the code that grabbed the duration values from the
chip could fail silently, and
On Tue Sep 10 19, Jarkko Sakkinen wrote:
The chip is not released when the validation for @digests fails. Add
tpm_put_ops() to the failure path.
Cc: sta...@vger.kernel.org
Reported-by: Roberto Sassu
Signed-off-by: Jarkko Sakkinen
Reviewed-by: Jerry Snitselaar
---
drivers/char/tpm/tpm
md;
rc = tpm_transmit_cmd(chip, &buf, 0, "attempting to a send a command");
- tpm_buf_destroy(&buf);
+
out:
tpm_put_ops(chip);
return rc;
--
2.20.1
Nothing uses the out label any longer so it should be dropped as well, but
other than that...
Acked-by: Jerry Snitselaar
On Mon Sep 16 19, Jerry Snitselaar wrote:
On Mon Sep 16 19, Jarkko Sakkinen wrote:
tpm_send() does not give anymore the result back to the caller. This
would require another memcpy(), which kind of tells that the whole
approach is somewhat broken. Instead, as Mimi suggested, this commit
just
On Wed Oct 02 19, Sasha Levin wrote:
On Wed, Oct 02, 2019 at 03:57:58PM +0200, Greg KH wrote:
On Wed, Oct 02, 2019 at 04:14:44PM +0300, Jarkko Sakkinen wrote:
From: Vadim Sukhomlinov
commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream
TPM 2.0 Shutdown involve sending TPM2_Shutdown to TP
On Wed Oct 02 19, Jerry Snitselaar wrote:
On Wed Oct 02 19, Sasha Levin wrote:
On Wed, Oct 02, 2019 at 03:57:58PM +0200, Greg KH wrote:
On Wed, Oct 02, 2019 at 04:14:44PM +0300, Jarkko Sakkinen wrote:
From: Vadim Sukhomlinov
commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream
TPM 2.0
On Wed Oct 02 19, Jarkko Sakkinen wrote:
On Mon, Sep 02, 2019 at 07:27:32AM -0700, Jerry Snitselaar wrote:
We've run into a case where a customer has an STM TPM 1.2 chip
(version 1.2.8.28), that is getting into an inconsistent state and
they end up getting tpm transmit errors. In reall
(e.g. power events)>
Take allocation out of the tpm_buf framework and make it purely a wrapper
for the data buffer.
Link: https://patchwork.kernel.org/patch/11146585/
Cc: Mimi Zohar
Cc: Jerry Snitselaar
Cc: James Bottomley
Cc: Sumit Garg
Cc: Stefan Berger
Signed-off-by: Jarkko Sakki
On Mon Sep 02 19, Jerry Snitselaar wrote:
We've run into a case where a customer has an STM TPM 1.2 chip
(version 1.2.8.28), that is getting into an inconsistent state and
they end up getting tpm transmit errors. In really old tpm code this
wasn't seen because the code that grabbed th
1 - 100 of 191 matches
Mail list logo
