Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Jonathan Corbet
On Thu, 13 Sep 2012 17:46:32 +0200 Federico Vaga wrote: > > A few words explaining why this memory handling module is required or > > beneficial will definitely improve the commit :) > > ok, I will write some lines In general, all of these patches need *much* better changelogs (i.e. they need

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Jonathan Corbet
On Thu, 13 Sep 2012 17:42:33 +0200 Federico Vaga wrote: > > The header and esp. the source could really do with more > > documentation. It is not at all clear from the code what the > > dma-streaming allocator does and how it differs from other > > allocators. > > The other allocators are not

Re: [PATCH] Documentation/SubmittingPatches: implicit permission for public reports

2012-10-24 Thread Jonathan Corbet
On Wed, 24 Oct 2012 10:22:02 -0400 Ed Cashin wrote: > +contribution. Please note that this tag should not be added without > +the reporter's permission unless the problem was reported in a public > +forum. That said, if we diligently credit our bug reporters, they I know what you're getting at

[PATCH] Avoid buffer overflows in get_user_pages()

2008-02-11 Thread Jonathan Corbet
y others which might be lurking in similar code. I also think that the number of pages should be unsigned, but changing the prototype of this function probably requires some more careful review. Signed-off-by: Jonathan Corbet <[EMAIL PROTECTED]> diff --git a/mm/memory.c b/mm/memory.c ind

[PATCH 0/8][for -mm] mem_notify v6

2008-02-11 Thread Jonathan Corbet
> the Linux Today article is very nice description. (great works by Jake Edge) > http://www.linuxworld.com/news/2008/020508-kernel.html Just for future reference...the above-mentioned article is from LWN, syndicated onto LinuxWorld. It has, so far as I know, never been near Linux Today. Glad you

Re: [PATCH] Avoid buffer overflows in get_user_pages()

2008-02-14 Thread Jonathan Corbet
Oliver Pinter <[EMAIL PROTECTED]> wrote: > for stable (.22 .23 .24) ? > > git id in mainline: 900cf086fd2fbad07f72f4575449e0d0958f860f I sent it to the stable folks a couple days ago. Thanks, jon Jonathan Corbet / LWN.net / [EMAIL PROTECTED] -- To unsubscribe from this list

Re: [PATCH 07/16] slab: overloading the RCU head over the LRU for RCU free

2013-08-27 Thread Jonathan Corbet
On Thu, 22 Aug 2013 17:44:16 +0900 Joonsoo Kim wrote: > With build-time size checking, we can overload the RCU head over the LRU > of struct page to free pages of a slab in rcu context. This really help to > implement to overload the struct slab over the struct page and this > eventually reduce m

Re: [PATCH net-next] net: rename low latency sockets functions to busy poll

2013-07-09 Thread Jonathan Corbet
On Mon, 08 Jul 2013 16:20:34 +0300 Eliezer Tamir wrote: > Rename POLL_LL to POLL_BUSY_LOOP. So pardon me if I speak out of turn, but it occurs to me to wonder...should the SO_LL socket option be renamed in a similar fashion before this interface escapes into the wild? Thanks, jon -- To unsubsc

Re: [PATCH 2/6] rcu: Create rcu_sync infrastructure

2013-10-08 Thread Jonathan Corbet
OK, so this is a real nit, but...in the changelog: > static inline void rcu_sync_enter(struct rcu_sync_struct *xxx) > { > atomic_inc(&xxx->counter); > synchronize_sched(); > } > > static inline void rcu_sync_enter(struct rcu_sync_str

Re: Claws (was [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c)

2013-10-10 Thread Jonathan Corbet
On Thu, 10 Oct 2013 14:37:15 -0700 Linus Torvalds wrote: > Steven, I'd suggest just jettisoning that mailer. FWIW, I've used claws for years and never run into an issue like that. This email comes from claws; the quoting looks right in the compose window now, I assume it will go out in good form

Re: linux-next: old trees

2013-09-25 Thread Jonathan Corbet
On Tue, 17 Sep 2013 17:01:24 +1000 Stephen Rothwell wrote: > jc_docs 2 years, 6 months ago I was afraid it would be the oldest tree on the list, but it's not even close...:) I've been meaning to do some stuff there for a bit; the problem is that life keeps getting in the way. If

Re: [RFC 1/3] mm: Add VM pressure notifications

2012-11-13 Thread Jonathan Corbet
On Wed, 7 Nov 2012 03:01:28 -0800 Anton Vorontsov wrote: > This patch introduces vmpressure_fd() system call. The system call creates > a new file descriptor that can be used to monitor Linux' virtual memory > management pressure. I noticed a couple of quick things as I was looking this over...

Re: [PATCH 1/1] ethernet driver: dm9000: davicom: Upgrade the driver to suit for all DM9000 series chips

2013-03-25 Thread Jonathan Corbet
On Mon, 25 Mar 2013 16:04:42 +0800 Joseph CHANG wrote: > From: Joseph CHANG > > Some necessary modification for DM9000 series chips to be better in operation! Interesting, this had been sent to me privately at about the same time. For the record, here's what I sent back:

Re: [PATCH] Documentation: update references to v2.6.x in development-process

2013-07-16 Thread Jonathan Corbet
On Mon, 15 Jul 2013 19:34:44 -0400 Paul Gortmaker wrote: > The last mainline release of a v2.6.x kernel was back in May 2011. > Here we update references to be 3.x based, which also means updating > some dates and statistics. Ccing the author of the document never hurts :) I actually went throu

Re: [Ksummit-2013-discuss] [ATTEND] DT, maintainership, development process

2013-07-29 Thread Jonathan Corbet
On Mon, 29 Jul 2013 15:10:33 +0200 "Rafael J. Wysocki" wrote: > That actually is simple enough. > > Check out the Linus' master branch and do > > $ git log --ancestry-path --merges .. So I picked a recent, single-signoff patch mostly at random: 8ade62857ef77bdf639185410fbcd811aa700cb2

Re: [PATCH] trivial: adjust code alignment

2013-08-05 Thread Jonathan Corbet
On Mon, 5 Aug 2013 18:19:18 +0200 (CEST) Julia Lawall wrote: > Oops, thanks for spotting that. I'm not sure whether it is safe to abort > these calls as soon as the first one fails, but perhaps I could introduce > some more variables, and test them all afterwards. Yes, it would be safe. But

Re: [RFC v01 1/3] PowerCap: Documentation

2013-08-05 Thread Jonathan Corbet
On Fri, 2 Aug 2013 11:08:50 -0700 Srinivas Pandruvada wrote: > +power_uw (rw): Current power counter in micro-watts. Write to this counter > +resets the counter to zero. If the counter can not be reset, then this > attribute > +is read-only. Sorry if I'm slow, but... power is an instantaneous

Re: dummy irq trace 'Flags mismatch'

2013-04-30 Thread Jonathan Corbet
an IRQ number Reported-by: Dave Jones Signed-off-by: Jonathan Corbet diff --git a/drivers/misc/dummy-irq.c b/drivers/misc/dummy-irq.c index 7014167..c37eeed 100644 --- a/drivers/misc/dummy-irq.c +++ b/drivers/misc/dummy-irq.c @@ -19,7 +19,7 @@ #include #include -static int irq; +static

Re: [PATCH] Enable A20 gate

2013-05-07 Thread Jonathan Corbet
On Tue, 7 May 2013 16:54:23 +0500 Syed Salman Mansoor wrote: > I am a newbie and trying to learn so that I can contribute whatever I can. If you have not already done so, please have a look at: Documentation/HOWTO Documentation/development-process both of which can be found in

Re: [ANNOUNCE] ktap 0.1 released

2013-05-21 Thread Jonathan Corbet
On Tue, 21 May 2013 11:56:14 +0800 "zhangwei(Jovi)" wrote: > we welcome bug reports and fixes for the issues. I'm messing with it...first impression: unable create tracepoint event sys_enter_mmap on cpu 4, err: -19 unable create tracepoint event sys_enter_mmap on cpu 5, err: -19

Re: Update VIP to videobuf2 and control framework

2012-08-01 Thread Jonathan Corbet
uffer come from > > videobuf-dma-contig (cached) version. After I made this buffer I found the > > videobuf2-dma-nc made by Jonathan Corbet and I improve the allocator with > > some suggestions (http://patchwork.linuxtv.org/patch/7441/). The VIP doesn't > > work with video

Re: Davicom DM9000C driver

2012-09-19 Thread Jonathan Corbet
On Wed, 19 Sep 2012 13:58:08 +0800 Allen Huang (黃偉格) wrote: > I'm Allen Huang from Davicom. We are hereby opensourcing the linux > driver for our DM9000C. That is great, but please read the development process documentation on how best to submit something like this. We would much rather see a

Re: Davicom DM9000C driver

2012-09-20 Thread Jonathan Corbet
On Thu, 20 Sep 2012 09:08:00 + Arnd Bergmann wrote: > More importantly, the patch should be against the version that is > already present in the kernel as drivers/net/ethernet/davicom/dm9000.c, > which appears to be mostly the same as the version that is submitted > here. Sigh. Leave it to

[PATCH] Documentation/patch-tags, one more time

2008-02-08 Thread Jonathan Corbet
various tags attached to patches. Signed-off-by: Jonathan Corbet <[EMAIL PROTECTED]> --- Documentation/00-INDEX |2 + Documentation/patch-tags | 76 ++ 2 files changed, 78 insertions(+), 0 deletions(-) create mode 100644 Documentation

[PATCH] Documenting patch tags yet one more time

2008-02-08 Thread Jonathan Corbet
ewed-by: really means. Signed-off-by: Jonathan Corbet <[EMAIL PROTECTED]> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 08a1ed1..cc00c8e 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -328,7 +328,7 @@ now, but you c

Re: [RFC PATCH -v2 0/4] Persistent events

2012-08-16 Thread Jonathan Corbet
On Thu, 16 Aug 2012 19:45:19 +0200 Borislav Petkov wrote: > off and on I get some free time to work on that, here's the latest > incarnation. It contains review feedback from the earlier round. Can I add one small request for the next round? I've looked through the patches and the code a bit, a

Re: [PATCH 3/6 v14] gpio: Add userland device interface to block GPIO

2013-01-22 Thread Jonathan Corbet
On Tue, 22 Jan 2013 13:06:41 +0100 Roland Stigge wrote: > This patch adds a character device interface to the block GPIO system. So I was looking at this, and a couple of things caught my eye... > +static int gpio_block_fop_open(struct inode *in, struct file *f) > +{ > + int i; > + stru

Re: Question about using new request_threaded_irq

2012-12-17 Thread Jonathan Corbet
s usually to quiet the device and return; it cannot sleep. If it's return value is IRQ_WAKE_THREAD, the thread_fn() will be called in process context; it *can* sleep. In the example you cite, there is no immediate handler, only the thread_fn(); the call to a blocking function from within the t

Re: Question about using new request_threaded_irq

2012-12-17 Thread Jonathan Corbet
On Mon, 17 Dec 2012 17:06:43 +0100 Marcos Lois Bermúdez wrote: > I'm a bit confusing because i see a outdated page that talks about this > new IRQ API, but now i see that it's very outdated: > > http://lwn.net/Articles/302043/ I normally encourage people to rely on LWN for everything, of cours

Re: [RFC] mmiotrace full patch, preview 1

2008-02-26 Thread Jonathan Corbet
Hey, Pekka, A couple of little things I noticed... > +static int post_kmmio_handler(unsigned long condition, struct pt_regs *regs) > +{ > + int ret = 0; > + struct kmmio_probe *probe; > + struct kmmio_fault_page *faultpage; > + struct kmmio_context *ctx = &get_cpu_var(kmmio_ctx);

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2013-01-07 Thread Jonathan Corbet
On Mon, 7 Jan 2013 00:09:47 +0100 Alessandro Rubini wrote: > I don't expect you'll see serious performance differences on the PC. I > think ARM users will have better benefits, due to the different cache > architecture. You told me Jon measured meaningful figures on a Marvel > CPU. It made the

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2013-01-08 Thread Jonathan Corbet
On Tue, 08 Jan 2013 07:50:41 +0100 Marek Szyprowski wrote: > > Couldn't this performance difference be due to the usage of GFP_DMA inside > > the VB2 code, like Federico's new patch series is proposing? > > > > If not, why are there a so large performance penalty? > > Nope, this was caused rat

Re: 2nd attempt: help with dma_alloc_coherent() + dma_free_coherent()

2013-01-08 Thread Jonathan Corbet
On Tue, 8 Jan 2013 23:51:59 +0800 Jeff Chua wrote: > I'm trying to understand how this oops in the diva driver and it's just a > simple dma_alloc_coherent() followed by dma_free_coherent(), but it oops. > Why? Hmm...from a quick look... > static u32 *clock_data_addr; > static dma_addr_t clock_d

Re: Current doc for writing device drivers?

2000-11-13 Thread Jonathan Corbet
> The Rubini book is being updated for 2.2 and 2.4, but I dunno when it > will go to press. We're working on it - honest! The book will go out for technical review before too long; I believe the current target date to have it on the shelves is April. We'd hoped for sooner, but, given how 2.4 de

Re: [BUG] Hard lockup using emu10k1-based sound card

2000-11-15 Thread Jonathan Corbet
Just as another data point, I, too, had trouble with lockups with the emu10k1 (with the 2.4.0-test driver and ALSA both). I noticed that it was sharing an interrupt with ACPI. As soon as I rebuilt the kernel with the ACPI Interpreter option turned off, the problem went away. It's not the first

Re: Device Driver Question.

2000-09-12 Thread Jonathan Corbet
ould look at would be the Raw I/O driver, .../drivers/char/raw.c, though that requires an understanding of the kiovec structure as well. jon Jonathan Corbet Executive editor, LWN.net [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

The zen of kernel virtual addresses

2000-10-21 Thread Jonathan Corbet
does not appear to be a function to go from a user or kernel virtual address to a physical address or struct page - one must manually walk through the levels of page tables to get there via the pte. Any corrections / suggestions would be much appreciated. jon Jonathan Corbet Executive editor, LWN.net

On running user mode helpers

2000-12-08 Thread Jonathan Corbet
ng in user space? Perhaps exec_usermodehelper should become private to kmod.c? I also see that call_usermodehelper will call do_exit() if the exec fails, while the path taken in request_module does not do that. Can both be right? Thanks, jon Jonathan Corbet Executive editor, LWN.net [EMAIL PROTE

Re: [ANNOUNCE] Kernel Janitor's TODO list (really sleep_on)

2001-01-29 Thread Jonathan Corbet
ning? Obviously, I'm thinking about ripping out much of the sleep_on() discussion as a last-minute change. I would be most curious to hear whether people think that would be the right thing to do. Thanks, jon Jonathan Corbet Executive editor, LWN.net [EMAIL PROTECTED] - To unsubscribe fro

Re: 2.6 partition support driver methods

2005-08-03 Thread Jonathan Corbet
if you need them: http://lwn.net/Kernel/LDD3/ jon Jonathan Corbet Executive editor, LWN.net [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/major

Re: 2.6 partition support driver methods

2005-08-04 Thread Jonathan Corbet
Mukund JB. <[EMAIL PROTECTED]> wrote: > BUT, when a card is inserted in the socket 3, I am NOT able to mount and > it says. > Mount: /dev/tfa12 is not a valid block device > > Can you convey me where exactly I am missing or why is it failing? First step would be to look in /proc/partitions (and

[PATCH] fix adm9240 oops

2005-08-25 Thread Jonathan Corbet
The adm9240 driver, in adm9240_detect(), allocates a structure. The error path attempts to kfree() a subfield of that structure, resulting in an oops (or slab corruption) if the hardware is not present. This one seems worth fixing for 2.6.13. jon Signed-off-by: Jonathan Corbet <[EM

Re: [PATCH] drivers/hwmon/*: kfree() correct pointers

2005-08-25 Thread Jonathan Corbet
tch in Greg's tree looks fine (it's a straightforward fix, after all); I'd recommend that it be merged before 2.6.13. jon Jonathan Corbet Executive editor, LWN.net [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: 2.6.13 new option timer frequency

2005-08-29 Thread Jonathan Corbet
: http://lwn.net/Articles/145973/ jon Jonathan Corbet Executive editor, LWN.net [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Ple

Re: [RFC] [PATCH] A clean approach to writeout throttling

2007-12-10 Thread Jonathan Corbet
Hey, Daniel, I'm just getting around to looking at this. One thing jumped out at me: > + if (bio->bi_throttle) { > + struct request_queue *q = bio->bi_queue; > + bio->bi_throttle = 0; /* or detect multiple endio and err? */ > + atomic_add(bio->bi_throttle,

RFC: reviewer's statement of oversight

2007-10-08 Thread Jonathan Corbet
Last month, at the kernel summit, there was discussion of putting a Reviewed-by: tag onto patches to document the oversight they had received on their way into the mainline. That tag has made an occasional appearance since then, but there has not yet been a discussion of what it really means. So

Re: RFC: reviewer's statement of oversight

2007-10-08 Thread Jonathan Corbet
Al Viro <[EMAIL PROTECTED]> wrote: > > A patch which is not "worthwhile" is also not "appropriate". Mere > > correctness in a mathematical sense is not enough as technical review > > criterion. > > Yes, but there's also such thing as "worthwhile removal". Good point. So the text should probabl

Re: RFC: reviewer's statement of oversight

2007-10-08 Thread Jonathan Corbet
ns? Perhaps the DCO should move to this file as well? jon --- Add a document on patch tags. Signed-off-by: Jonathan Corbet <[EMAIL PROTECTED]> diff --git a/Documentation/00-INDEX b/Documentation/00-INDEX index 43e89b1..fa1518b 100644 --- a/Documentation/00-INDEX +++ b/Documentation/

Re: RFC: reviewer's statement of oversight

2007-10-09 Thread Jonathan Corbet
Neil Brown <[EMAIL PROTECTED]> wrote: > I find it is always good to know *why* we have the tags. That > information is a useful complement to what they mean, and can guide > people in adding them. Hmm...I was just going to go with the "because I told you so" approach that I use with my kids. It

[PATCH] Documentation/patch-tags V2

2007-10-09 Thread Jonathan Corbet
Signed-off-by: Jonathan Corbet <[EMAIL PROTECTED]> diff --git a/Documentation/00-INDEX b/Documentation/00-INDEX index 43e89b1..fa1518b 100644 --- a/Documentation/00-INDEX +++ b/Documentation/00-INDEX @@ -284,6 +284,8 @@ parport.txt - how to use the parallel-port driver.

[PATCH] Documentation/patch-tags v3

2007-10-11 Thread Jonathan Corbet
Here's the current version of the patch-tags document; I've made changes in response to comments from a Randy Dunlap and Scott Preece. The only substantive change, though, is the removal of the privacy term, since it really does seem to be overkill. It can come back if it turns out to be truly ne

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-27 Thread Jonathan Corbet
Rusty said: > Well, introduce an EXPORT_SYMBOL_INTERNAL(). It's a lot less code. But > you'd > still need to show that people are having trouble knowing what APIs to use. Might the recent discussion on the exporting of sys_open() and sys_read() be an example here? There would appear to be a

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-27 Thread Jonathan Corbet
Greg KH <[EMAIL PROTECTED]> wrote: > Jonathan, I used your old lwn.net article about kobjects as the basis > for this document, I hope you don't mind Certainly I have no objections, I'm glad it was useful. A few little things... > It is rare (even unknown) for kernel code to create a standalone

Re: [PATCH 1/2] Extend sys_clone and sys_unshare system calls API

2008-01-16 Thread Jonathan Corbet
Hi, Pavel, [Adding Ulrich] > I use the last bit in the clone_flags for CLONE_LONGARG. When set it > will denote that the child_tidptr is not a pointer to a tid storage, > but the pointer to the struct long_clone_struct which currently > looks like this: I'm probably just totally off the deep en

Extending syscalls (was: [PATCH 1/2] Extend sys_clone and sys_unshare system calls API)

2008-01-17 Thread Jonathan Corbet
Al Viro sez: > Nah, just put an XML parser into the kernel to have the form match the > contents... > > Al "perhaps we should newgroup alt.tasteless.api for all that stuff" Viro Heh, indeed. But we do seem to have a recurring problem of people wanting to extend sys_foo() beyond the confines of

Re: [RFC/PATCH 2/8] revoke: inode revoke lock V7

2007-12-18 Thread Jonathan Corbet
This is a relatively minor detail in the rather bigger context of this patch, but... > @@ -642,6 +644,7 @@ struct inode { > struct list_headinotify_watches; /* watches on this inode */ > struct mutexinotify_mutex; /* protects the watches list */ > #endif > + w

Linux Device Drivers, Third Edition online

2005-03-14 Thread Jonathan Corbet
for all of your friends, though :) jon Jonathan Corbet Executive editor, LWN.net [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Pl

Re: [RFC] rwsem removal from kobj_map

2005-02-18 Thread Jonathan Corbet
semaphore. Since you're passing that separately now, I would think that the subsystem argument could simply go away altogether. Once that's done, you should be able to delete cdev_subsys as well; when I cleaned that stuff up, I only left it there for kobj_map(). jon Jonathan Corbet Execut

Re: When the FUD is all around (sniff).

2001-06-26 Thread Jonathan Corbet
t the needs of the market and minds of investors, is one of the reasons that investors have rapidly lost interest in Linux distributors and Linux-related businesses. Cool. Linus caused the end of the stock bubble... jon Jonathan Corbet Executive editor, LWN.net [EMAIL PROTECTED] - To unsubs

Re: Making a module 2.4 compatible

2001-06-26 Thread Jonathan Corbet
so hit the net, but that's going to take a little longer. If it doesn't answer all your questions, then we failed to achieve what we set out to do. jon Jonathan Corbet Executive editor, LWN.net [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-k

Re: Linux kernel programming for beginners

2001-05-15 Thread Jonathan Corbet
l working on the right license for the online release - if people have suggestions, I would be glad to receive them privately. jon (who's glad we didn't tell people how to request major device numbers...) Jonathan Corbet Executive editor, LWN.net [EMAIL PROTECTED] - To unsubscrib

Re: [PATCH] Add seq_file howto to Documentation/

2007-07-23 Thread Jonathan Corbet
o have anything I put on LWN go into Documentation/ if there's interest - just say the word. jon To: linux-kernel@vger.kernel.org Subject: [PATCH] seq_file documentation cc: [EMAIL PROTECTED] From: Jonathan Corbet <[EMAIL PROTECTED]> Date: Thu, 13 Nov 2003 10:16:31 -0700 Sender: corbet

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-24 Thread Jonathan Corbet
> Items for consideration would be: > > - if this stuff is good, shouldn't other code be using it? If so, is > this new infrastructure in the correct place? > > - if, otoh, this infrastructure is _not_ suitable for other code, well, > what was wrong with it? > > - if the requirement is good

[PATCH] msleep() with hrtimers

2007-08-03 Thread Jonathan Corbet
causing msleep(1) to sleep for at least 20ms on HZ=100 systems. Using hrtimers allows msleep() to sleep for something much closer to the requested time. Signed-off-by: Jonathan Corbet <[EMAIL PROTECTED]> --- 2.6.23-rc1/kernel/timer.c.orig 2007-08-02 13:45:20.0 -0600 +++ 2.6.23-rc1/k

Re: [PATCH] Revised timerfd() interface

2007-08-15 Thread Jonathan Corbet
Sorry for the late commentary...as I looked this over, one thing popped into my mind > b) Make the 'clockid' immutable: it can only be set >if 'ufd' is -1 -- that is, on the timerfd() call that >first creates a timer. timerfd() is looking increasingly like a multiplexor system call in

Patch tags [was writeout stalls in current -git]

2007-11-06 Thread Jonathan Corbet
Andrew wrote: > > Reviewed-by: Fengguang Wu <[EMAIL PROTECTED]> > > I would prefer Tested-by: :( This seems like as good an opportunity as any to toss my patch tags document out there one more time. I still think it's a good idea to codify some sort of consensus on what these tags mean... jo

Re: Patch tags [was writeout stalls in current -git]

2007-11-09 Thread Jonathan Corbet
Adrian Bunk <[EMAIL PROTECTED]> wrote: > What's missing is a definition which of them are formal tags that must > be explicitely given (look at point 13 in SubmittingPatches). > > Signed-off-by: and Reviewed-by: are the formal tags someone must have > explicitely given and that correspond to so

Re: Make OLPC camera driver depend on x86.

2006-12-12 Thread Jonathan Corbet
Dave Jones <[EMAIL PROTECTED]> wrote: > - depends on I2C && VIDEO_V4L2 > + depends on I2C && VIDEO_V4L2 && X86_32 Any particular reason why? I wouldn't be surprised to see Cafe used with other processors in the future. And I happen to know the driver works on x86-64 systems...or at leas

Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]

2006-12-13 Thread Jonathan Corbet
Greg's patch: > + printk(KERN_WARNING "%s: This module will not be able " > + "to be loaded after January 1, 2008 due to its " > + "license.\n", mod->name); If you're going to go ahead with this, shouldn't the message say

Re: [RFC PATCH 0/6] Convert all tasklets to workqueues

2007-06-24 Thread Jonathan Corbet
. I will make an attempt to do that testing, but the next few weeks involve some insane travel which will make that hard. Stay tuned. Thanks, jon Jonathan Corbet / LWN.net / [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messag

Re: [RFC PATCH 0/6] Convert all tasklets to workqueues

2007-06-25 Thread Jonathan Corbet
without the patch. Consider my minor qualms withdrawn, there doesn't seem to be any trouble in this area. Thanks, jon Jonathan Corbet / LWN.net / [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EM

[PATCH/RFC] msleep() with hrtimers

2007-07-15 Thread Jonathan Corbet
code will at least drop down to single-jiffy delays much of the time (though not deterministically so). On my x86_64 system with Thomas's hrtimer/dyntick patch applied, msleep(1) gives almost exactly what was asked for. jon Use hrtimers for msleep() and msleep_interruptible() Signed-off-by

Re: [PATCH/RFC] msleep() with hrtimers

2007-07-16 Thread Jonathan Corbet
Hey, Roman, > One possible problem here is that setting up that timer can be > considerably more expensive, for a relative timer you have to read the > current time, which can be quite expensive (e.g. your machine now uses the > PIT timer, because TSC was deemed unstable). That's a possibility

Re: [PATCH/RFC] msleep() with hrtimers

2007-07-16 Thread Jonathan Corbet
Roman Zippel <[EMAIL PROTECTED]> wrote: > > That's a possibility, I admit I haven't benchmarked it. I will say that > > I don't think it will be enough to matter - msleep() is not a hot-path > > sort of function. Once the system is up and running it almost never > > gets called at all - at least

[PATCH] "volatile considered harmful", take 2

2007-05-10 Thread Jonathan Corbet
Who knew a documentation patch would get so many reviews? I like it... Anyway, here's a new version in which I attempt to respond to all the comments that came in. Thanks to everybody for looking it over. jon Steer developers away from the volatile type. Signed-off-by: Jonathan C

[PATCH] "volatile considered harmful", take 3

2007-05-11 Thread Jonathan Corbet
es in Documentation/ held to a high standard of writing, but, unless somebody has a factual issue this time around I would like to declare Mission Accomplished and move on. Thanks, jon --- Encourage developers to avoid the volatile type class in kernel code. Signed-off-by: Jonathan Corbet

Re: [PATCH] Documentation: improvement to volatile considered harmful (resubmit)

2007-07-02 Thread Jonathan Corbet
Heikki Orsila <[EMAIL PROTECTED]> wrote: > I'm resubmitting this as I didn't get any replies, this time CCeing > proper people, sorry.. > > Kernel locking/synchronization primitives are better than volatile types > from code readability point of view also. I think that just dilutes the real po

Re: [RFC/PATCH] doc: volatile considered evil

2007-05-08 Thread Jonathan Corbet
more like a normal document: http://lwn.net/Articles/233479/ Comments welcome. If people think it suits the need I'll happily make a version which moves from the LWN style to Documentation/ and send it in. Thanks, jon Jonathan Corbet / LWN.net / [EMAIL PROTECTED] - To unsubscribe from this

[PATCH] "volatile considered harmful" document

2007-05-09 Thread Jonathan Corbet
OK, here's an updated version of the volatile document - as a plain text file this time. It drops a new file in Documentation/, but might it be better as an addition to CodingStyle? Comments welcome, jon Tell kernel developers why they shouldn't use volatile. Signed-off-by: Jonat

[PATCH] Fix up PCI power management doc

2007-03-22 Thread Jonathan Corbet
I noticed that the PCI power management document file had fallen a little behind the times, so I fixed it up. jon Update the documentation of PCI power management functions. Signed-off-by: Jonathan Corbet <[EMAIL PROTECTED]> diff --git a/Documentation/power/pci.txt b/Documentation

Re: [PATCH v4] Documentation: Move samples from doc to samples/

2016-07-19 Thread Jonathan Corbet
On Mon, 18 Jul 2016 15:55:00 -0400 Mahesh Khanwalkar wrote: > Moved sample code found in Documentation/ to samples/ but kept actual > documentation where it is, while updating any in-text references to the > moved code. Updated the Documentation/Makefile and samples/Makefile to > reflect the chan

Re: [PATCH] docs: Remove kernel-doc-nano-HOWTO.txt

2016-07-20 Thread Jonathan Corbet
nel-doc-nano-HOWTO.txt is there, and various other docs had pointers to it. So I've just committed this instead, hope it's OK... jon --- >From 8ed292fe864e9ed7d335515e97590122a56d7cba Mon Sep 17 00:00:00 2001 From: Jonathan Corbet Date: Wed, 20 Jul 2016 16:43:41 -0600 Subject: [PATC

Re: [PATCH 1/2] dax: some small updates to dax.txt documentation

2016-07-20 Thread Jonathan Corbet
On Thu, 14 Jul 2016 15:40:48 -0600 Ross Zwisler wrote: > These are originally from Matthew Wilcox and were part of his huge > "mm,fs,dax: Change ->pmd_fault to ->huge_fault" patch that was part of PUD > support. > > I'm breaking these small changes out as they stand on their own and add > useful

Re: [PATCH 1/2] dax: some small updates to dax.txt documentation

2016-07-20 Thread Jonathan Corbet
On Wed, 20 Jul 2016 16:18:57 -0700 Andrew Morton wrote: > > So how were you thinking of routing these? I can take the docs fix, of > > course, but part 2 is a bit out of my turf. If you want to route them > > together via another tree that's fine, just let me know. > > I have them queued. Y

Re: [PATCH v5 2/2] Doc/memory-barriers: Add Korean translation

2016-07-21 Thread Jonathan Corbet
On Thu, 21 Jul 2016 07:23:46 -0700 "Paul E. McKenney" wrote: > If Minchan is OK with this version, if Ingo and Jon have no objections, > and given the small change below, I will take it. None here. Acked-by: Jonathan Corbet jon

Re: [PATCH 1/8] samples: move accounting example code from Documentation

2016-09-19 Thread Jonathan Corbet
On Mon, 19 Sep 2016 08:47:32 -0600 Shuah Khan wrote: > Move accounting examples to samples and remove it from Documentation > Makefile. Create a new Makefile to build accounting. It can be built > from top level directory or from accounting directory: So I like the basic idea of these patches; i

Re: [PATCH 2/8] samples: move auxdisplay example code from Documentation

2016-09-19 Thread Jonathan Corbet
On Mon, 19 Sep 2016 08:47:33 -0600 Shuah Khan wrote: > Move auxdisplay examples to samples and remove it from Documentation > Makefile. Create a new Makefile to build auxdisplay. It can be built > from top level directory or from auxdisplay directory: Documentation/auxdisplay/cfag12864b needs to

Re: [PATCH 3/8] samples: move laptops example code from Documentation

2016-09-19 Thread Jonathan Corbet
On Mon, 19 Sep 2016 08:47:34 -0600 Shuah Khan wrote: > Move laptops examples to samples and remove it from Documentation > Makefile. Create a new Makefile to build laptops. It can be built > from top level directory or from laptops directory: This one might be better called a "tool" rather than

Re: [PATCH 4/8] samples: move mic/mpssd example code from Documentation

2016-09-19 Thread Jonathan Corbet
mic/mpssd or cd samples/mic/mpssd; make This one seems good as-is Acked-by: Jonathan Corbet jon

Re: [PATCH 5/8] samples: move misc-devices/mei example code from Documentation

2016-09-19 Thread Jonathan Corbet
irectory: This one still has a fair amount of code hiding in the .txt files, but that's a separate job. Acked-by: Jonathan Corbet jon

Re: [PATCH 6/8] samples: move pcmcia example code from Documentation

2016-09-19 Thread Jonathan Corbet
On Mon, 19 Sep 2016 08:47:37 -0600 Shuah Khan wrote: > Move pcmcia examples to samples and remove it from Documentation > Makefile. Create a new Makefile to build pcmcia. It can be built > from top level directory or from pcmcia directory: Does PCMCIA still exist/work? I guess it probably must

Re: [PATCH 7/8] samples: move timers example code from Documentation

2016-09-19 Thread Jonathan Corbet
updating. Otherwise Acked-by: Jonathan Corbet jon

Re: [PATCH 8/8] samples: move watchdog example code from Documentation

2016-09-19 Thread Jonathan Corbet
On Mon, 19 Sep 2016 08:47:39 -0600 Shuah Khan wrote: > Move watchdog examples to samples and remove it from Documentation > Makefile. Create a new Makefile to build watchdog. It can be built > from top level directory or from watchdog directory: Updates needed to watchdog-api.txt and wdt.txt; pr

Re: [PATCH] Documentation: DMA-API-HOWTO: Fix a typo

2016-09-20 Thread Jonathan Corbet
On Tue, 20 Sep 2016 09:04:20 -0700 Andrey Smirnov wrote: > - if (dma_mapping_error(cp->dev, dma_handle)) { > + if (dma_mapping_error(cp->dev, mapping)) { Interesting, that has been wrong for the entire git era; another patch fixed that line a few years ago, but left the w

Re: [PATCH v10 RESEND 0/3] Documentation: Add description of enable multi-cpus support for kdump

2016-09-20 Thread Jonathan Corbet
On Mon, 19 Sep 2016 13:59:46 +0800 Baoquan He wrote: > This is v10 post. In this patchset patch 1/3 is added to give more details > about nr_cpus and maxcpus in kernel-parameters.txt. This is suggested by > Jonathan since the description of them is unclear so that people can't see > what's the ex

Re: [PATCH] [linux-next] Fix double word "the the" in Doc/filesystems

2016-09-20 Thread Jonathan Corbet
On Tue, 20 Sep 2016 12:49:59 +0900 Masanari Iida wrote: > This patch fix typos "the the" found in Documentation/filesystems. So this patch doesn't apply. > Signed-off-by: Masanari Iida > --- > Documentation/filesystems/autofs4-mount-control.txt | 10 +- In particular, this one fails.

Re: [PATCH v4 00/29] Create a book for Kernel development

2016-09-20 Thread Jonathan Corbet
On Mon, 19 Sep 2016 08:07:34 -0300 Mauro Carvalho Chehab wrote: > That's the 4th version of this series. It also contains a second patch series > with more ReST conversions and documentation improvements. > This patchset merges the content of a second patch series: > > [PATCH 00/17] Improv

Re: [PATCH v2 0/4] Move runnable examples code from Documentation to samples

2016-09-21 Thread Jonathan Corbet
On Wed, 21 Sep 2016 13:47:29 -0600 Shuah Khan wrote: > Move runnable examples code from Documentation to samples. I moved > just the example code, and left documentation files as is. > > I dropped accounting, laptops, and pcmcia from this v2 series as per > the v1 feedback on these being a bette

[PATCH] docs: Remove space-before-label guidance from CodingStyle

2016-09-21 Thread Jonathan Corbet
ned-off-by: Jonathan Corbet --- Documentation/CodingStyle | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle index 852253c932fe..9c61c039ccd9 100644 --- a/Documentation/CodingStyle +++ b/Documentation/CodingStyle @@ -45

Re: [PATCH v2 0/3] Move runnable tools from Documentation to tools

2016-09-22 Thread Jonathan Corbet
ols. > > If v2 patches look good, and if I get an okay, I will try to get > these into 4.9-rc1 Acked-by: Jonathan Corbet Though I still wonder if we really need to keep some of those tools... jon

  1   2   3   4   5   6   7   8   9   10   >