Re: [ANNOUNCE] Kernel Janitor's TODO list (really sleep_on)

2001-01-29 Thread Jonathan Corbet
m thinking about ripping out much of the sleep_on() discussion as a last-minute change. I would be most curious to hear whether people think that would be the right thing to do. Thanks, jon Jonathan Corbet Executive editor, LWN.net [EMAIL PROTECTED] - To unsubscribe from this list: sen

Re: Linux kernel programming for beginners

2001-05-15 Thread Jonathan Corbet
working on the right license for the online release - if people have suggestions, I would be glad to receive them privately. /self-serving-stuff jon (who's glad we didn't tell people how to request major device numbers...) Jonathan Corbet Executive editor, LWN.net [EMAIL PROTECTED

Re: Device Driver Question.

2000-09-12 Thread Jonathan Corbet
at would be the Raw I/O driver, .../drivers/char/raw.c, though that requires an understanding of the kiovec structure as well. jon Jonathan Corbet Executive editor, LWN.net [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

The zen of kernel virtual addresses

2000-10-21 Thread Jonathan Corbet
virtual address to a physical address or struct page - one must manually walk through the levels of page tables to get there via the pte. Any corrections / suggestions would be much appreciated. jon Jonathan Corbet Executive editor, LWN.net [EMAIL PROTECTED] - To unsubscribe from this list: send the

On running user mode helpers

2000-12-08 Thread Jonathan Corbet
ng in user space? Perhaps exec_usermodehelper should become private to kmod.c? I also see that call_usermodehelper will call do_exit() if the exec fails, while the path taken in request_module does not do that. Can both be right? Thanks, jon Jonathan Corbet Executive editor, LWN.net [EMAIL

Re: Current doc for writing device drivers?

2000-11-13 Thread Jonathan Corbet
The Rubini book is being updated for 2.2 and 2.4, but I dunno when it will go to press. We're working on it - honest! The book will go out for technical review before too long; I believe the current target date to have it on the shelves is April. We'd hoped for sooner, but, given how 2.4

Re: [BUG] Hard lockup using emu10k1-based sound card

2000-11-15 Thread Jonathan Corbet
Just as another data point, I, too, had trouble with lockups with the emu10k1 (with the 2.4.0-test driver and ALSA both). I noticed that it was sharing an interrupt with ACPI. As soon as I rebuilt the kernel with the ACPI Interpreter option turned off, the problem went away. It's not the first

Re: When the FUD is all around (sniff).

2001-06-26 Thread Jonathan Corbet
the needs of the market and minds of investors, is one of the reasons that investors have rapidly lost interest in Linux distributors and Linux-related businesses. Cool. Linus caused the end of the stock bubble... jon Jonathan Corbet Executive editor, LWN.net [EMAIL PROTECTED] - To unsubscribe

Re: Making a module 2.4 compatible

2001-06-26 Thread Jonathan Corbet
the net, but that's going to take a little longer. If it doesn't answer all your questions, then we failed to achieve what we set out to do. /BlatantSelfPromotion jon Jonathan Corbet Executive editor, LWN.net [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux

[PATCH] Fix up PCI power management doc

2007-03-22 Thread Jonathan Corbet
I noticed that the PCI power management document file had fallen a little behind the times, so I fixed it up. jon Update the documentation of PCI power management functions. Signed-off-by: Jonathan Corbet [EMAIL PROTECTED] diff --git a/Documentation/power/pci.txt b/Documentation/power/pci.txt

Re: [PATCH] cafe_ccic: default to allocating DMA buffers at probe time

2007-09-19 Thread Jonathan Corbet
, no other systems out there using the CAFE controller. Making things work by default for the one user (with a fair number of deployed systems!) makes sense to me. So... Acked-by: Jonathan Corbet [EMAIL PROTECTED] That said, I do prefer the original name for the parameter. jon Jonathan Corbet

Re: [RFC/PATCH 2/8] revoke: inode revoke lock V7

2007-12-18 Thread Jonathan Corbet
This is a relatively minor detail in the rather bigger context of this patch, but... @@ -642,6 +644,7 @@ struct inode { struct list_headinotify_watches; /* watches on this inode */ struct mutexinotify_mutex; /* protects the watches list */ #endif +

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-27 Thread Jonathan Corbet
Rusty said: Well, introduce an EXPORT_SYMBOL_INTERNAL(). It's a lot less code. But you'd still need to show that people are having trouble knowing what APIs to use. Might the recent discussion on the exporting of sys_open() and sys_read() be an example here? There would appear to be a

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-27 Thread Jonathan Corbet
Greg KH [EMAIL PROTECTED] wrote: Jonathan, I used your old lwn.net article about kobjects as the basis for this document, I hope you don't mind Certainly I have no objections, I'm glad it was useful. A few little things... It is rare (even unknown) for kernel code to create a standalone

Re: [RFC] [PATCH] A clean approach to writeout throttling

2007-12-10 Thread Jonathan Corbet
Hey, Daniel, I'm just getting around to looking at this. One thing jumped out at me: + if (bio-bi_throttle) { + struct request_queue *q = bio-bi_queue; + bio-bi_throttle = 0; /* or detect multiple endio and err? */ + atomic_add(bio-bi_throttle,

[PATCH] Avoid buffer overflows in get_user_pages()

2008-02-11 Thread Jonathan Corbet
be lurking in similar code. I also think that the number of pages should be unsigned, but changing the prototype of this function probably requires some more careful review. Signed-off-by: Jonathan Corbet [EMAIL PROTECTED] diff --git a/mm/memory.c b/mm/memory.c index e5628a5..7f50fd8 100644

[PATCH 0/8][for -mm] mem_notify v6

2008-02-11 Thread Jonathan Corbet
the Linux Today article is very nice description. (great works by Jake Edge) http://www.linuxworld.com/news/2008/020508-kernel.html Just for future reference...the above-mentioned article is from LWN, syndicated onto LinuxWorld. It has, so far as I know, never been near Linux Today. Glad you

Re: [PATCH] Avoid buffer overflows in get_user_pages()

2008-02-14 Thread Jonathan Corbet
Oliver Pinter [EMAIL PROTECTED] wrote: for stable (.22 .23 .24) ? git id in mainline: 900cf086fd2fbad07f72f4575449e0d0958f860f I sent it to the stable folks a couple days ago. Thanks, jon Jonathan Corbet / LWN.net / [EMAIL PROTECTED] -- To unsubscribe from this list: send the line

Re: [PATCH] Documentation/SubmittingPatches: implicit permission for public reports

2012-10-24 Thread Jonathan Corbet
On Wed, 24 Oct 2012 10:22:02 -0400 Ed Cashin ecas...@coraid.com wrote: +contribution. Please note that this tag should not be added without +the reporter's permission unless the problem was reported in a public +forum. That said, if we diligently credit our bug reporters, they I know what

Re: [RFC 1/3] mm: Add VM pressure notifications

2012-11-13 Thread Jonathan Corbet
On Wed, 7 Nov 2012 03:01:28 -0800 Anton Vorontsov anton.voront...@linaro.org wrote: This patch introduces vmpressure_fd() system call. The system call creates a new file descriptor that can be used to monitor Linux' virtual memory management pressure. I noticed a couple of quick things as I

Re: [PATCH 1/4] module: implement module_inhibit_unload()

2007-09-24 Thread Jonathan Corbet
Hi, Tejun, I was just looking over these changes... + /* Don't proceed till inhibition is lifted. */ + add_wait_queue(module_unload_wait, wait); + set_current_state(TASK_UNINTERRUPTIBLE); + if (atomic_read(module_unload_inhibit_cnt)) + schedule(); +

Re: [patch 2/4] new timerfd API v2 - new timerfd API

2007-09-25 Thread Jonathan Corbet
One quick question: Like the previous timerfd API implementation, read(2) and poll(2) are supported (with the same interface). Looking at that interface, it appears that a process doing a read() on a timerfd with no timer set will block for a very long time. It's an obvious don't do that

Re: [PATCH 04/22] CRED: Request a credential record for a kernel service

2007-09-25 Thread Jonathan Corbet
daemon to be used as a base for the context. + * @dentry: A file or dir to be used as a base for the file creation + * context. + * Return 0 if successful. The comment describes a dentry argument, but the actual function does not have that argument. jon Jonathan Corbet / LWN.net / [EMAIL

Re: A unresponsive file system can hang all I/O in the system on linux-2.6.23-rc6 (dirty_thresh problem?)

2007-09-28 Thread Jonathan Corbet
Andrew wrote: It's unrelated to the actual value of dirty_thresh: if the machine fills up with dirty (or unstable) NFS pages then eventually new writers will block until that condition clears. 2.4 doesn't have this problem at low levels of dirty data because 2.4 VFS/MM doesn't account for

RFC: reviewer's statement of oversight

2007-10-08 Thread Jonathan Corbet
Last month, at the kernel summit, there was discussion of putting a Reviewed-by: tag onto patches to document the oversight they had received on their way into the mainline. That tag has made an occasional appearance since then, but there has not yet been a discussion of what it really means. So

Re: RFC: reviewer's statement of oversight

2007-10-08 Thread Jonathan Corbet
Al Viro [EMAIL PROTECTED] wrote: A patch which is not worthwhile is also not appropriate. Mere correctness in a mathematical sense is not enough as technical review criterion. Yes, but there's also such thing as worthwhile removal. Good point. So the text should probably say

Re: RFC: reviewer's statement of oversight

2007-10-08 Thread Jonathan Corbet
the DCO should move to this file as well? jon --- Add a document on patch tags. Signed-off-by: Jonathan Corbet [EMAIL PROTECTED] diff --git a/Documentation/00-INDEX b/Documentation/00-INDEX index 43e89b1..fa1518b 100644 --- a/Documentation/00-INDEX +++ b/Documentation/00-INDEX @@ -284,6 +284,8

Re: RFC: reviewer's statement of oversight

2007-10-09 Thread Jonathan Corbet
Neil Brown [EMAIL PROTECTED] wrote: I find it is always good to know *why* we have the tags. That information is a useful complement to what they mean, and can guide people in adding them. Hmm...I was just going to go with the because I told you so approach that I use with my kids. It works

[PATCH] Documentation/patch-tags V2

2007-10-09 Thread Jonathan Corbet
-by: Jonathan Corbet [EMAIL PROTECTED] diff --git a/Documentation/00-INDEX b/Documentation/00-INDEX index 43e89b1..fa1518b 100644 --- a/Documentation/00-INDEX +++ b/Documentation/00-INDEX @@ -284,6 +284,8 @@ parport.txt - how to use the parallel-port driver. parport-lowlevel.txt

Re: [PATCH] Add seq_file howto to Documentation/

2007-07-23 Thread Jonathan Corbet
interest - just say the word. jon To: linux-kernel@vger.kernel.org Subject: [PATCH] seq_file documentation cc: [EMAIL PROTECTED] From: Jonathan Corbet [EMAIL PROTECTED] Date: Thu, 13 Nov 2003 10:16:31 -0700 Sender: corbet I went ahead and packaged up my seq_file document as a basic text file

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-24 Thread Jonathan Corbet
Items for consideration would be: - if this stuff is good, shouldn't other code be using it? If so, is this new infrastructure in the correct place? - if, otoh, this infrastructure is _not_ suitable for other code, well, what was wrong with it? - if the requirement is good,

Re: [PATCH] Revised timerfd() interface

2007-08-15 Thread Jonathan Corbet
Sorry for the late commentary...as I looked this over, one thing popped into my mind b) Make the 'clockid' immutable: it can only be set if 'ufd' is -1 -- that is, on the timerfd() call that first creates a timer. timerfd() is looking increasingly like a multiplexor system call in

[PATCH] Documentation/patch-tags v3

2007-10-11 Thread Jonathan Corbet
Here's the current version of the patch-tags document; I've made changes in response to comments from a Randy Dunlap and Scott Preece. The only substantive change, though, is the removal of the privacy term, since it really does seem to be overkill. It can come back if it turns out to be truly

[PATCH] msleep() with hrtimers

2007-08-03 Thread Jonathan Corbet
) to sleep for at least 20ms on HZ=100 systems. Using hrtimers allows msleep() to sleep for something much closer to the requested time. Signed-off-by: Jonathan Corbet [EMAIL PROTECTED] --- 2.6.23-rc1/kernel/timer.c.orig 2007-08-02 13:45:20.0 -0600 +++ 2.6.23-rc1/kernel/timer.c 2007-08-03

Re: [RFC] rwsem removal from kobj_map

2005-02-18 Thread Jonathan Corbet
you're passing that separately now, I would think that the subsystem argument could simply go away altogether. Once that's done, you should be able to delete cdev_subsys as well; when I cleaned that stuff up, I only left it there for kobj_map(). jon Jonathan Corbet Executive editor, LWN.net

Linux Device Drivers, Third Edition online

2005-03-14 Thread Jonathan Corbet
of your friends, though :) jon Jonathan Corbet Executive editor, LWN.net [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH 1/1] ethernet driver: dm9000: davicom: Upgrade the driver to suit for all DM9000 series chips

2013-03-25 Thread Jonathan Corbet
, here's what I sent back: From: Jonathan Corbet cor...@lwn.net To: Allen Huang (黃偉格) allen_hu...@davicom.com.tw Subject: Re: Davicom Linux driver Date: Mon, 25 Mar 2013 09:55:48 -0600 Organization: LWN.net On Mon, 25 Mar 2013 18:31:35 +0800 Allen Huang (黃偉格) allen_hu...@davicom.com.tw wrote

Re: [PATCH 3/6 v14] gpio: Add userland device interface to block GPIO

2013-01-22 Thread Jonathan Corbet
On Tue, 22 Jan 2013 13:06:41 +0100 Roland Stigge sti...@antcom.de wrote: This patch adds a character device interface to the block GPIO system. So I was looking at this, and a couple of things caught my eye... +static int gpio_block_fop_open(struct inode *in, struct file *f) +{ + int i;

[PATCH] fix adm9240 oops

2005-08-25 Thread Jonathan Corbet
The adm9240 driver, in adm9240_detect(), allocates a structure. The error path attempts to kfree() a subfield of that structure, resulting in an oops (or slab corruption) if the hardware is not present. This one seems worth fixing for 2.6.13. jon Signed-off-by: Jonathan Corbet [EMAIL PROTECTED

Re: [PATCH] drivers/hwmon/*: kfree() correct pointers

2005-08-25 Thread Jonathan Corbet
fine (it's a straightforward fix, after all); I'd recommend that it be merged before 2.6.13. jon Jonathan Corbet Executive editor, LWN.net [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: 2.6.13 new option timer frequency

2005-08-29 Thread Jonathan Corbet
/Articles/145973/ jon Jonathan Corbet Executive editor, LWN.net [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: 2.6 partition support driver methods

2005-08-03 Thread Jonathan Corbet
: http://lwn.net/Kernel/LDD3/ jon Jonathan Corbet Executive editor, LWN.net [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: 2.6 partition support driver methods

2005-08-04 Thread Jonathan Corbet
Mukund JB. [EMAIL PROTECTED] wrote: BUT, when a card is inserted in the socket 3, I am NOT able to mount and it says. Mount: /dev/tfa12 is not a valid block device Can you convey me where exactly I am missing or why is it failing? First step would be to look in /proc/partitions (and the

Re: Make OLPC camera driver depend on x86.

2006-12-12 Thread Jonathan Corbet
Dave Jones [EMAIL PROTECTED] wrote: - depends on I2C VIDEO_V4L2 + depends on I2C VIDEO_V4L2 X86_32 Any particular reason why? I wouldn't be surprised to see Cafe used with other processors in the future. And I happen to know the driver works on x86-64 systems...or at least it did

Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]

2006-12-13 Thread Jonathan Corbet
Greg's patch: + printk(KERN_WARNING %s: This module will not be able + to be loaded after January 1, 2008 due to its + license.\n, mod-name); If you're going to go ahead with this, shouldn't the message say that the

Re: Davicom DM9000C driver

2012-09-19 Thread Jonathan Corbet
On Wed, 19 Sep 2012 13:58:08 +0800 Allen Huang (黃偉格) allen_hu...@davicom.com.tw wrote: I'm Allen Huang from Davicom. We are hereby opensourcing the linux driver for our DM9000C. That is great, but please read the development process documentation on how best to submit something like this.

Re: Davicom DM9000C driver

2012-09-20 Thread Jonathan Corbet
On Thu, 20 Sep 2012 09:08:00 + Arnd Bergmann a...@arndb.de wrote: More importantly, the patch should be against the version that is already present in the kernel as drivers/net/ethernet/davicom/dm9000.c, which appears to be mostly the same as the version that is submitted here. Sigh.

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Jonathan Corbet
On Thu, 13 Sep 2012 17:46:32 +0200 Federico Vaga federico.v...@gmail.com wrote: A few words explaining why this memory handling module is required or beneficial will definitely improve the commit :) ok, I will write some lines In general, all of these patches need *much* better

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Jonathan Corbet
On Thu, 13 Sep 2012 17:42:33 +0200 Federico Vaga federico.v...@gmail.com wrote: The header and esp. the source could really do with more documentation. It is not at all clear from the code what the dma-streaming allocator does and how it differs from other allocators. The other

Re: [RFC PATCH -v2 0/4] Persistent events

2012-08-16 Thread Jonathan Corbet
On Thu, 16 Aug 2012 19:45:19 +0200 Borislav Petkov b...@amd64.org wrote: off and on I get some free time to work on that, here's the latest incarnation. It contains review feedback from the earlier round. Can I add one small request for the next round? I've looked through the patches and the

Re: Update VIP to videobuf2 and control framework

2012-08-01 Thread Jonathan Corbet
videobuf-dma-contig (cached) version. After I made this buffer I found the videobuf2-dma-nc made by Jonathan Corbet and I improve the allocator with some suggestions (http://patchwork.linuxtv.org/patch/7441/). The VIP doesn't work with videobu2-dma-contig and I think this solution is easier

[PATCH] Documentation/patch-tags, one more time

2008-02-08 Thread Jonathan Corbet
the various tags attached to patches. Signed-off-by: Jonathan Corbet [EMAIL PROTECTED] --- Documentation/00-INDEX |2 + Documentation/patch-tags | 76 ++ 2 files changed, 78 insertions(+), 0 deletions(-) create mode 100644 Documentation/patch-tags

[PATCH] Documenting patch tags yet one more time

2008-02-08 Thread Jonathan Corbet
-off-by: Jonathan Corbet [EMAIL PROTECTED] diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 08a1ed1..cc00c8e 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -328,7 +328,7 @@ now, but you can do this to mark internal company

Re: [PATCH 1/2] Extend sys_clone and sys_unshare system calls API

2008-01-16 Thread Jonathan Corbet
Hi, Pavel, [Adding Ulrich] I use the last bit in the clone_flags for CLONE_LONGARG. When set it will denote that the child_tidptr is not a pointer to a tid storage, but the pointer to the struct long_clone_struct which currently looks like this: I'm probably just totally off the deep end,

Extending syscalls (was: [PATCH 1/2] Extend sys_clone and sys_unshare system calls API)

2008-01-17 Thread Jonathan Corbet
Al Viro sez: Nah, just put an XML parser into the kernel to have the form match the contents... Al perhaps we should newgroup alt.tasteless.api for all that stuff Viro Heh, indeed. But we do seem to have a recurring problem of people wanting to extend sys_foo() beyond the confines of its

Re: [RFC] mmiotrace full patch, preview 1

2008-02-26 Thread Jonathan Corbet
Hey, Pekka, A couple of little things I noticed... +static int post_kmmio_handler(unsigned long condition, struct pt_regs *regs) +{ + int ret = 0; + struct kmmio_probe *probe; + struct kmmio_fault_page *faultpage; + struct kmmio_context *ctx = get_cpu_var(kmmio_ctx); + +

Patch tags [was writeout stalls in current -git]

2007-11-06 Thread Jonathan Corbet
Andrew wrote: Reviewed-by: Fengguang Wu [EMAIL PROTECTED] I would prefer Tested-by: :( This seems like as good an opportunity as any to toss my patch tags document out there one more time. I still think it's a good idea to codify some sort of consensus on what these tags mean... jon

Re: Patch tags [was writeout stalls in current -git]

2007-11-09 Thread Jonathan Corbet
Adrian Bunk [EMAIL PROTECTED] wrote: What's missing is a definition which of them are formal tags that must be explicitely given (look at point 13 in SubmittingPatches). Signed-off-by: and Reviewed-by: are the formal tags someone must have explicitely given and that correspond to some

Re: Question about using new request_threaded_irq

2012-12-17 Thread Jonathan Corbet
On Mon, 17 Dec 2012 17:06:43 +0100 Marcos Lois Bermúdez marcos.disca...@gmail.com wrote: I'm a bit confusing because i see a outdated page that talks about this new IRQ API, but now i see that it's very outdated: http://lwn.net/Articles/302043/ I normally encourage people to rely on LWN

Re: Question about using new request_threaded_irq

2012-12-17 Thread Jonathan Corbet
. If it's return value is IRQ_WAKE_THREAD, the thread_fn() will be called in process context; it *can* sleep. In the example you cite, there is no immediate handler, only the thread_fn(); the call to a blocking function from within the thread_fn() is correct. Hope that helps, jon Jonathan Corbet

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2013-01-07 Thread Jonathan Corbet
On Mon, 7 Jan 2013 00:09:47 +0100 Alessandro Rubini rub...@gnudd.com wrote: I don't expect you'll see serious performance differences on the PC. I think ARM users will have better benefits, due to the different cache architecture. You told me Jon measured meaningful figures on a Marvel CPU.

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2013-01-08 Thread Jonathan Corbet
On Tue, 08 Jan 2013 07:50:41 +0100 Marek Szyprowski m.szyprow...@samsung.com wrote: Couldn't this performance difference be due to the usage of GFP_DMA inside the VB2 code, like Federico's new patch series is proposing? If not, why are there a so large performance penalty? Nope, this

Re: 2nd attempt: help with dma_alloc_coherent() + dma_free_coherent()

2013-01-08 Thread Jonathan Corbet
On Tue, 8 Jan 2013 23:51:59 +0800 Jeff Chua jeff.chua.li...@gmail.com wrote: I'm trying to understand how this oops in the diva driver and it's just a simple dma_alloc_coherent() followed by dma_free_coherent(), but it oops. Why? Hmm...from a quick look... static u32 *clock_data_addr;

Re: [RFC PATCH 0/6] Convert all tasklets to workqueues

2007-06-24 Thread Jonathan Corbet
to do that testing, but the next few weeks involve some insane travel which will make that hard. Stay tuned. Thanks, jon Jonathan Corbet / LWN.net / [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [RFC PATCH 0/6] Convert all tasklets to workqueues

2007-06-25 Thread Jonathan Corbet
minor qualms withdrawn, there doesn't seem to be any trouble in this area. Thanks, jon Jonathan Corbet / LWN.net / [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH] Documentation: improvement to volatile considered harmful (resubmit)

2007-07-02 Thread Jonathan Corbet
Heikki Orsila [EMAIL PROTECTED] wrote: I'm resubmitting this as I didn't get any replies, this time CCeing proper people, sorry.. Kernel locking/synchronization primitives are better than volatile types from code readability point of view also. I think that just dilutes the real point.

[PATCH/RFC] msleep() with hrtimers

2007-07-15 Thread Jonathan Corbet
will at least drop down to single-jiffy delays much of the time (though not deterministically so). On my x86_64 system with Thomas's hrtimer/dyntick patch applied, msleep(1) gives almost exactly what was asked for. jon Use hrtimers for msleep() and msleep_interruptible() Signed-off-by: Jonathan

Re: [PATCH/RFC] msleep() with hrtimers

2007-07-16 Thread Jonathan Corbet
Hey, Roman, One possible problem here is that setting up that timer can be considerably more expensive, for a relative timer you have to read the current time, which can be quite expensive (e.g. your machine now uses the PIT timer, because TSC was deemed unstable). That's a possibility, I

Re: [PATCH/RFC] msleep() with hrtimers

2007-07-16 Thread Jonathan Corbet
Roman Zippel [EMAIL PROTECTED] wrote: That's a possibility, I admit I haven't benchmarked it. I will say that I don't think it will be enough to matter - msleep() is not a hot-path sort of function. Once the system is up and running it almost never gets called at all - at least, on my

Re: [RFC/PATCH] doc: volatile considered evil

2007-05-08 Thread Jonathan Corbet
://lwn.net/Articles/233479/ Comments welcome. If people think it suits the need I'll happily make a version which moves from the LWN style to Documentation/ and send it in. Thanks, jon Jonathan Corbet / LWN.net / [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux

[PATCH] volatile considered harmful document

2007-05-09 Thread Jonathan Corbet
OK, here's an updated version of the volatile document - as a plain text file this time. It drops a new file in Documentation/, but might it be better as an addition to CodingStyle? Comments welcome, jon Tell kernel developers why they shouldn't use volatile. Signed-off-by: Jonathan Corbet

[PATCH] volatile considered harmful, take 2

2007-05-10 Thread Jonathan Corbet
Who knew a documentation patch would get so many reviews? I like it... Anyway, here's a new version in which I attempt to respond to all the comments that came in. Thanks to everybody for looking it over. jon Steer developers away from the volatile type. Signed-off-by: Jonathan Corbet [EMAIL

[PATCH] volatile considered harmful, take 3

2007-05-11 Thread Jonathan Corbet
to a high standard of writing, but, unless somebody has a factual issue this time around I would like to declare Mission Accomplished and move on. Thanks, jon --- Encourage developers to avoid the volatile type class in kernel code. Signed-off-by: Jonathan Corbet [EMAIL PROTECTED] diff --git

Re: [PATCH] trivial: adjust code alignment

2013-08-05 Thread Jonathan Corbet
On Mon, 5 Aug 2013 18:19:18 +0200 (CEST) Julia Lawall julia.law...@lip6.fr wrote: Oops, thanks for spotting that. I'm not sure whether it is safe to abort these calls as soon as the first one fails, but perhaps I could introduce some more variables, and test them all afterwards. Yes, it

Re: [RFC v01 1/3] PowerCap: Documentation

2013-08-05 Thread Jonathan Corbet
On Fri, 2 Aug 2013 11:08:50 -0700 Srinivas Pandruvada srinivas.pandruv...@linux.intel.com wrote: +power_uw (rw): Current power counter in micro-watts. Write to this counter +resets the counter to zero. If the counter can not be reset, then this attribute +is read-only. Sorry if I'm slow,

Re: [Ksummit-2013-discuss] [ATTEND] DT, maintainership, development process

2013-07-29 Thread Jonathan Corbet
On Mon, 29 Jul 2013 15:10:33 +0200 Rafael J. Wysocki r...@sisk.pl wrote: That actually is simple enough. Check out the Linus' master branch and do $ git log --ancestry-path --merges commit.. So I picked a recent, single-signoff patch mostly at random:

Re: [PATCH 07/16] slab: overloading the RCU head over the LRU for RCU free

2013-08-27 Thread Jonathan Corbet
On Thu, 22 Aug 2013 17:44:16 +0900 Joonsoo Kim iamjoonsoo@lge.com wrote: With build-time size checking, we can overload the RCU head over the LRU of struct page to free pages of a slab in rcu context. This really help to implement to overload the struct slab over the struct page and this

Re: [PATCH net-next] net: rename low latency sockets functions to busy poll

2013-07-09 Thread Jonathan Corbet
On Mon, 08 Jul 2013 16:20:34 +0300 Eliezer Tamir eliezer.ta...@linux.intel.com wrote: Rename POLL_LL to POLL_BUSY_LOOP. So pardon me if I speak out of turn, but it occurs to me to wonder...should the SO_LL socket option be renamed in a similar fashion before this interface escapes into the

Re: [PATCH] Documentation: update references to v2.6.x in development-process

2013-07-16 Thread Jonathan Corbet
On Mon, 15 Jul 2013 19:34:44 -0400 Paul Gortmaker paul.gortma...@windriver.com wrote: The last mainline release of a v2.6.x kernel was back in May 2011. Here we update references to be 3.x based, which also means updating some dates and statistics. Ccing the author of the document never hurts

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-11 Thread Jonathan Corbet
On Thu, 10 Oct 2013 18:00:48 -0700 Linus Torvalds torva...@linux-foundation.org wrote: File a bug on Claws, and if the developers brush it off as your own problem, just stop using the PoS. They acknowledge the bug - it was already known to them, actually. With luck we'll see a fix soon. jon

Re: [PATCH/RFC] wait_for_completion_timeout() considered harmful.

2013-11-18 Thread Jonathan Corbet
On Tue, 19 Nov 2013 00:42:09 +0100 Peter Zijlstra pet...@infradead.org wrote: I briefly talked to Thomas about this earlier today and we need to fix this at a lower level -- the quick 'n dirty solution is to add 1 jiffy down in the timer-wheel when we enqueue these things. That can lead to

Re: [RFC PATCH tip 5/5] tracing filter examples in BPF

2013-12-03 Thread Jonathan Corbet
On Mon, 2 Dec 2013 20:28:50 -0800 Alexei Starovoitov a...@plumgrid.com wrote: GCC-BPF backend is available on github (since gcc plugin infrastructure doesn't allow for out-of-tree backends) Do you have a pointer to where this backend can be found? I've done a bit of digging around but seem

Re: [PATCH tip/core/locking 4/4] Documentation/memory-barriers.txt: Document ACCESS_ONCE()

2013-12-05 Thread Jonathan Corbet
On Wed, 4 Dec 2013 14:46:59 -0800 Paul E. McKenney paul...@linux.vnet.ibm.com wrote: From: Paul E. McKenney paul...@linux.vnet.ibm.com The situations in which ACCESS_ONCE() is required are not well documented, so this commit adds some verbiage to memory-barriers.txt. [...] + But

Re: [RFC PATCH for-next 3/4] epoll: struct epoll support

2014-02-24 Thread Jonathan Corbet
So I was just looking things over quickly, and something jumped out at me. In ep_control(): + } else if (!(*io) epi) { + /* delete this eventpoll entry */ + if (is_file_epoll(target)) { + tep = target-private_data; +

Re: [PATCH] Enable A20 gate

2013-05-07 Thread Jonathan Corbet
On Tue, 7 May 2013 16:54:23 +0500 Syed Salman Mansoor syed.salman.mans...@gmail.com wrote: I am a newbie and trying to learn so that I can contribute whatever I can. If you have not already done so, please have a look at: Documentation/HOWTO Documentation/development-process

Re: dummy irq trace 'Flags mismatch'

2013-04-30 Thread Jonathan Corbet
to specify an IRQ number Reported-by: Dave Jones da...@redhat.com Signed-off-by: Jonathan Corbet cor...@lwn.net diff --git a/drivers/misc/dummy-irq.c b/drivers/misc/dummy-irq.c index 7014167..c37eeed 100644 --- a/drivers/misc/dummy-irq.c +++ b/drivers/misc/dummy-irq.c @@ -19,7 +19,7 @@ #include

Re: [ANNOUNCE] ktap 0.1 released

2013-05-21 Thread Jonathan Corbet
On Tue, 21 May 2013 11:56:14 +0800 zhangwei(Jovi) jovi.zhang...@huawei.com wrote: we welcome bug reports and fixes for the issues. I'm messing with it...first impression: unable create tracepoint event sys_enter_mmap on cpu 4, err: -19 unable create tracepoint event

Re: [PATCH -next] media/platform/marvell-ccic: fix cafe_ccic build error

2013-10-31 Thread Jonathan Corbet
On Thu, 31 Oct 2013 11:07:28 -0700 Randy Dunlap rdun...@infradead.org wrote: From: Randy Dunlap rdun...@infradead.org The cafe_ccic driver (the mcam-core.c part of it) uses dma_sg interfaces so it needs to select VIDEOBUF2_DMA_SG to prevent build errors. Geert sent a patch too a little

Re: [PATCH 2/6] rcu: Create rcu_sync infrastructure

2013-10-08 Thread Jonathan Corbet
OK, so this is a real nit, but...in the changelog: static inline void rcu_sync_enter(struct rcu_sync_struct *xxx) { atomic_inc(xxx-counter); synchronize_sched(); } static inline void rcu_sync_enter(struct rcu_sync_struct

Re: Claws (was [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c)

2013-10-10 Thread Jonathan Corbet
On Thu, 10 Oct 2013 14:37:15 -0700 Linus Torvalds torva...@linux-foundation.org wrote: Steven, I'd suggest just jettisoning that mailer. FWIW, I've used claws for years and never run into an issue like that. This email comes from claws; the quoting looks right in the compose window now, I

Re: linux-next: old trees

2013-09-25 Thread Jonathan Corbet
On Tue, 17 Sep 2013 17:01:24 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: jc_docs 2 years, 6 months ago I was afraid it would be the oldest tree on the list, but it's not even close...:) I've been meaning to do some stuff there for a bit; the problem is that life keeps

Re: [PATCH v2 net-next 0/2] split BPF out of core networking

2014-06-02 Thread Jonathan Corbet
On Mon, 2 Jun 2014 00:01:44 -0700 Alexei Starovoitov a...@plumgrid.com wrote: This patch set splits BPF out of core networking into generic component Quick, probably dumb question: if you're going to split it out, why not split it out entirely, into kernel/ or (perhaps better) lib/? The whole

Re: [PATCH 2/2] dma: Add Xilinx AXI Central Direct Memory Access Engine driver support

2014-04-08 Thread Jonathan Corbet
On Mon, 7 Apr 2014 20:22:54 +0530 Srikanth Thokala stho...@xilinx.com wrote: Kindly review this driver and please let me know if you have any comments. Here's some comments from a quick look at the patch; they do not qualify as a proper review by any means. +/** + * struct xilinx_cdma_chan -

Re: [RFC PATCH 5/5] gfs2: Add xreaddir file operation and supporting functions

2014-07-29 Thread Jonathan Corbet
On Fri, 25 Jul 2014 12:38:08 -0500 Abhi Das a...@redhat.com wrote: This patch adds support in GFS2 for the xgetdents syscall by implementing the xreaddir file operation. So I was trying to make sense of this, and ran into one little thing that jumped out at me: +static int

Re: [RFC PATCH 5/5] gfs2: Add xreaddir file operation and supporting functions

2014-07-30 Thread Jonathan Corbet
On Tue, 29 Jul 2014 18:25:57 -0400 (EDT) Abhijith Das a...@redhat.com wrote: + if ((xc-xc_xattr_mask XSTAT_XATTR_ALL) + lxd-xd_blob.xb_xattr_count) { How can that be right? lxd is __user, it doesn't seem right to be dereferencing it directly...? Wouldn't the call to

Re: [PATCH 0/2] Documenation: kmemleak: Add an explanation about CONFIG_DEBUG_KMEMLEAK_DEFAULT_OFF=y case.

2014-10-24 Thread Jonathan Corbet
On Fri, 24 Oct 2014 16:52:20 +0100 Catalin Marinas catalin.mari...@arm.com wrote: Both patches look fine to me. Acked-by: Catalin Marinas catalin.mari...@arm.com Both applied, thanks. jon -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCH] vdso: don't require 64-bit math in standalone test

2014-10-25 Thread Jonathan Corbet
On Fri, 24 Oct 2014 12:12:58 -0700 Randy Dunlap rdun...@infradead.org wrote: Jon, please pick this up. It was Acked-by: Peter Foley pefol...@pefoley.com Done. jon -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

[PATCH] MAINTAINERS: Become the docs maintainer

2014-10-17 Thread Jonathan Corbet
It seems it's my turn to be the documentation maintainer for a bit. My plan is to work to ensure that docs patches don't fall through the cracks; I assume most changes will continue to flow through subsystem-specific trees. Acked-by: Jiri Kosina jkos...@suse.cz Signed-off-by: Jonathan Corbet cor

Re: [PATCH] DocBook: fix media build error

2014-10-20 Thread Jonathan Corbet
On Sun, 19 Oct 2014 19:39:17 -0700 Randy Dunlap rdun...@infradead.org wrote: Fix media DocBook build errors by making the orderedlist balanced. That definitely makes things work better. Will send upward if need be. Thanks, jon -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v2 1/1] Documentation: dt-bindings: Explain order in patch series

2014-10-20 Thread Jonathan Corbet
On Tue, 14 Oct 2014 10:25:52 +0100 Mark Rutland mark.rutl...@arm.com wrote: Following the discussion around [1], this makes sense to me, so: Acked-by: Mark Rutland mark.rutl...@arm.com Applied to my shiny new docs tree in case nobody else grabs it. jon -- To unsubscribe from this list: send

  1   2   3   4   5   6   7   8   9   10   >